Re: [REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

2020-08-10 Thread Bart Van Assche
On 2020-08-10 10:51, Wes Hardaker wrote: > Bart Van Assche writes: > >> That's a great question. This fix only affects pass-persist on Unix >> platforms and Cygwin but neither affects the MSVC build nor any of the >> MinGW builds since the affected code was already disabled for the >> latter two

Re: [REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

2020-08-10 Thread Wes Hardaker via Net-snmp-coders
Bart Van Assche writes: > That's a great question. This fix only affects pass-persist on Unix > platforms and Cygwin but neither affects the MSVC build nor any of the > MinGW builds since the affected code was already disabled for the > latter two platforms. Thanks. Follow-on: do we have any cl

Re: [REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

2020-08-10 Thread Bart Van Assche
On 2020-08-10 08:37, Wes Hardaker wrote: > Bart Van Assche writes: > >> However, I don't think rewriting that file so close to the v5.9 release >> is appropriate. Hence this patch that makes the smallest possible >> change. > > To be clear, this affects *only* pass-persist *only* on windows corr

Re: [REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

2020-08-10 Thread Wes Hardaker via Net-snmp-coders
Bart Van Assche writes: > However, I don't think rewriting that file so close to the v5.9 release > is appropriate. Hence this patch that makes the smallest possible > change. To be clear, this affects *only* pass-persist *only* on windows correct? IE, it's a fix for a specific combination. But