Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-20 Thread Robert Story
On Wed 2017-12-20 12:38:22-0500 Bill wrote: > > On Wed 2017-12-20 12:13:48-0500 Bill wrote: > > > > The attached patch against master builds with and without TLS > > > > transports on CentOS 6 (openssl 1.0) and Fedora 27 (openssl > > > > 1.1). > > Thanks! I'll note that this still results in

Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-20 Thread Bill Fenner
On Wed, Dec 20, 2017 at 12:22 PM, Robert Story wrote: > On Wed 2017-12-20 12:13:48-0500 Bill wrote: > > > The attached patch against master builds with and without TLS > > > transports on CentOS 6 (openssl 1.0) and Fedora 27 (openssl 1.1). > > > > Can you attach "git show" instead of "git log", o

Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-20 Thread Robert Story
On Wed 2017-12-20 12:13:48-0500 Bill wrote: > > The attached patch against master builds with and without TLS > > transports on CentOS 6 (openssl 1.0) and Fedora 27 (openssl 1.1). > > Can you attach "git show" instead of "git log", or point me to your > repo if it's public and I'll cherry-pick you

Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-20 Thread Bill Fenner
On Wed, Dec 20, 2017 at 12:01 PM, Robert Story wrote: > On Wed 2017-12-20 10:51:07-0500 Robert wrote: > > On Wed 2017-12-20 08:42:19-0500 Bill wrote: > > > I've attached a patch that at least compiles that pulls the compat > > > functions that snmpusm needs into the new #if, dunno if you have a >

Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-20 Thread Bill Fenner
On Wed, Dec 20, 2017 at 10:51 AM, Robert Story wrote: > On Wed 2017-12-20 08:42:19-0500 Bill wrote: > > I've attached a patch that at least compiles that pulls the compat > > functions that snmpusm needs into the new #if, dunno if you have a > > better idea. I haven't tested it with TLS transpor

Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-20 Thread Robert Story
On Wed 2017-12-20 10:51:07-0500 Robert wrote: > On Wed 2017-12-20 08:42:19-0500 Bill wrote: > > I've attached a patch that at least compiles that pulls the compat > > functions that snmpusm needs into the new #if, dunno if you have a > > better idea. I haven't tested it with TLS transports. > >

Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-20 Thread Bill Fenner
On Wed, Dec 20, 2017 at 10:24 AM, Bart Van Assche wrote: > On 12/20/17 05:42, Bill Fenner wrote: > >> I've attached a patch that at least compiles that pulls the compat >> functions that snmpusm needs into the new #if, dunno if you have a better >> idea. I haven't tested it with TLS transports.

Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-20 Thread Robert Story
On Wed 2017-12-20 08:42:19-0500 Bill wrote: > I've attached a patch that at least compiles that pulls the compat > functions that snmpusm needs into the new #if, dunno if you have a > better idea. I haven't tested it with TLS transports. I thins that snmp_openssl. c is the right place for any nee

Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-20 Thread Bart Van Assche
On 12/20/17 05:42, Bill Fenner wrote: I've attached a patch that at least compiles that pulls the compat functions that snmpusm needs into the new #if, dunno if you have a better idea.  I haven't tested it with TLS transports. Hello Bill, I would like to have as few dependencies on the NETSNM

Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-20 Thread Bill Fenner
Well, for the compat functions that snmpusm needs, we need +#include +#include which is easy if we naively assume that the headers are protected against multi-inclusion. And there are more compat functions in this file, that need more headers to build, that snmpusm doesn't. Some errors: snmp

Re: DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-19 Thread Bart Van Assche
On 12/19/17 10:36, Bill Fenner wrote: > snmplib/netsnmp-openssl.c is not built unless HAVE_LIBSSL is defined, > which is only defined if the TLS transports are used.  After the removal > of the compat functions from apps/snmpusm.c, if you build with only USM > transports, there is nothing to pro

DH_get0_pqg not defined on 5.8 master if you build without TLS transport

2017-12-19 Thread Bill Fenner
snmplib/netsnmp-openssl.c is not built unless HAVE_LIBSSL is defined, which is only defined if the TLS transports are used. After the removal of the compat functions from apps/snmpusm.c, if you build with only USM transports, there is nothing to provide the DH_get0_pqg compatibility function. B