Fixing warnings in snmplib/snmpksm.c

2011-02-23 Thread Niels Baggesen
In my eternal quest for warnings I now hit snmpksm, which did not even compile on my standard CentOS setups :-( I would like to solicit some input on the changes that I made to get it to compile and quell warnings, so would some of you who has a Kerberos setup please look at the attached dif?

Re: Fixing warnings in snmplib/snmpksm.c

2011-02-23 Thread Magnus Fromreide
On Wed, 2011-02-23 at 22:38 +0100, Niels Baggesen wrote: In my eternal quest for warnings I now hit snmpksm, which did not even compile on my standard CentOS setups :-( I would like to solicit some input on the changes that I made to get it to compile and quell warnings, so would some of

Re: Fixing warnings in snmplib/snmpksm.c

2011-02-23 Thread Niels Baggesen
On Wed, Feb 23, 2011 at 11:22:16PM +0100, Magnus Fromreide wrote: Chunk 4 looks marvelous. How did this ever compile? I have no idea if this ever compiled :-) It is certainly some years ago last time Chunk 5-12: Why print lengths as signed integers? Lazyness. Then you only have to change one

Re: Fixing warnings in snmplib/snmpksm.c

2011-02-23 Thread Magnus Fromreide
On Wed, 2011-02-23 at 23:31 +0100, Niels Baggesen wrote: On Wed, Feb 23, 2011 at 11:22:16PM +0100, Magnus Fromreide wrote: Chunk 4 looks marvelous. How did this ever compile? I have no idea if this ever compiled :-) It is certainly some years ago last time :-) Chunk 5-12: Why print

Re: Fixing warnings in snmplib/snmpksm.c

2011-02-23 Thread Niels Baggesen
On Thu, Feb 24, 2011 at 12:01:32AM +0100, Magnus Fromreide wrote: There is the third option as well: % NETSNMP_PRIz u, LENGTH_something The drawback is that it is even longer but the advantage is that it is correct on both 32 and 64-bit platforms, but then, so are the other two

Re: Fixing warnings in snmplib/snmpksm.c

2011-02-23 Thread Wes Hardaker
On Wed, 23 Feb 2011 23:31:11 +0100, Niels Baggesen n...@users.sourceforge.net said: NB On Wed, Feb 23, 2011 at 11:22:16PM +0100, Magnus Fromreide wrote: Chunk 4 looks marvelous. How did this ever compile? NB I have no idea if this ever compiled :-) It is certainly some years NB ago last time