On Thu, 28 Jul 2005 13:20:31 +0100 Dave wrote:
DS> I've put together a "menu-driven" version of this driver (attached),
I love the idea. I've only give the attachment the briefest of glances, so
just have some superficial comments.
1) I'm not sure why you have all the currentXX variables. The m2c
On Thu, 28 Jul 2005 14:06:20 +0100 Dave wrote:
DS> > I´m pretty sure there isn´t a leak - the calling function should detect
DS> > if the pointer changed.
DS>
DS> Ummm... I don't think it does.
DS> [...]
DS> So the 'myString_get' routine is being passed the buffer from the
DS> varbind structure.
> DS> The other suggestion relates to the 'object_get' routines
> DS> Currently, this code includes checks on the size of the buffer
> DS> passed in, and re-allocates memory if necessary (potentially
> DS> resulting in a memory leak, since the old memory doesn't appear
> DS> to be released).
>
On Wed, 2005-07-27 at 20:15 -0400, Robert Story wrote:
> On Mon, 25 Jul 2005 17:21:20 +0100 Dave wrote:
> DS> We should probably ensure that the hard-coded and interactive
> DS> defaults match - either bringing the hard-coded settings into
> DS> line with the interactive versions (my preference), o
On Mon, 25 Jul 2005 17:21:20 +0100 Dave wrote:
DS> We should probably ensure that the hard-coded and interactive
DS> defaults match - either bringing the hard-coded settings into
DS> line with the interactive versions (my preference), or vice versa.
Agreed.
DS> The other suggestion relates to the
Robert,
as you may have guessed, I've now moved on to looking at the MfD
framework again. I've noticed a couple of things that don't look
quite right, or could perhaps be useful tweaked a bit.
Firstly, the code generated by running
mib2c -c mib2c.mfd.conf {myTable}
and accepting all the defau
