Re: CFV: Re: Odd code

2010-09-02 Thread Thomas Anders
Wes Hardaker wrote: > The obvious patch is: +1 +Thomas -- This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thr

Re: CFV: Re: Odd code

2010-09-01 Thread Magnus Fromreide
On Wed, 2010-09-01 at 07:22 -0700, Wes Hardaker wrote: > > On Wed, 01 Sep 2010 08:00:44 +0200, Magnus Fromreide > > said: > > MF> if ((rc = > netsnmp_sess_config_transport(in_session->transport_configuration, > MF> transport)) != SNMPERR_SUCCESS) { > MF> return rc; > in_session-> s_snmp

Re: CFV: Re: Odd code

2010-09-01 Thread Robert Story
On Wed, 01 Sep 2010 07:22:09 -0700 Wes wrote: WH> Whoops; good catch. It should be the second so the tools print the WH> right error message when an error is encountered. WH> WH> The obvious patch is: +1 -- This SF.net

CFV: Re: Odd code

2010-09-01 Thread Wes Hardaker
> On Wed, 01 Sep 2010 08:00:44 +0200, Magnus Fromreide > said: MF> if ((rc = netsnmp_sess_config_transport(in_session->transport_configuration, MF> transport)) != SNMPERR_SUCCESS) { MF> return rc; in_session-> s_snmp_errno = rc; in_session-> s_errno = 0; MF> return rc; MF> } Whoops; goo

Re: Odd code

2010-08-31 Thread Madhu
its with the net-snmp-5.6.pre3 release as i found... On Wed, Sep 1, 2010 at 11:46 AM, rakesh zingade wrote: > can you mention the snmp version in which you saw this piece of code? > > I check 5.5 and 5.4 but unable to find the same.. > > > On Wed, Sep 1, 2010 at 11:30 AM, Magnus Fromreide wrote:

Re: Odd code

2010-08-31 Thread Magnus Fromreide
On Wed, 2010-09-01 at 11:46 +0530, rakesh zingade wrote: > can you mention the snmp version in which you saw this piece of code? trunk (5.6 to be - so yes, this is new code) -- This SF.net Dev2Dev email is sponsored by:

Re: Odd code

2010-08-31 Thread rakesh zingade
can you mention the snmp version in which you saw this piece of code? I check 5.5 and 5.4 but unable to find the same.. On Wed, Sep 1, 2010 at 11:30 AM, Magnus Fromreide wrote: > In snmp_api.c, at line 1521-1527, there is the following piece of code: > >if ((rc = > netsnmp_sess_config_transp