Re: proposal: snmplib/string_utils.c

2004-10-08 Thread Andy Smith
Robert Story (Coders) wrote: On Thu, 07 Oct 2004 21:43:48 -0400 Andy wrote: AS> I did another CVS pull this AS> afternoon and started with a fresh tree, I am getting unresolved AS> references to strtok_r when I try to compile the agent. I looked for the AS> function definition, but all 'grep -In

Re: proposal: snmplib/string_utils.c

2004-10-08 Thread Coders
On Thu, 07 Oct 2004 21:43:48 -0400 Andy wrote: AS> I did another CVS pull this AS> afternoon and started with a fresh tree, I am getting unresolved AS> references to strtok_r when I try to compile the agent. I looked for the AS> function definition, but all 'grep -Inr strtok_r ./snmplib' bought

Re: proposal: snmplib/string_utils.c

2004-10-07 Thread Andy Smith
Has the local strtok_r function gone away completely now? I did a CVS pull last night and was getting errors in the MinGW build about a header included in strtok_r.c, ok...we can handle that. I was able to compile by idefing the include out for mingw. I did another CVS pull this afternoon and s

Re: proposal: snmplib/string_utils.c

2004-10-06 Thread Dave Shield
> So the current choices are: > > 1) add strtok_r to tool.c as a temporary location > > 2) add new file strtok_r.c (seems to be the previous pattern) > > 3) add a new file string_utils.c, merging in existing str*.c files > > 4) come to some quick concensus on what a proper directory hierarchy f

Re: Re: proposal: snmplib/string_utils.c

2004-10-06 Thread slif
> > From: Robert Story (Coders) <[EMAIL PROTECTED]> > Date: 2004/10/05 Tue PM 07:39:06 EDT > To: [EMAIL PROTECTED] > Subject: Re: proposal: snmplib/string_utils.c > > On Tue, 5 Oct 2004 19:09:55 -0400 Robert wrote: > RS> I'm looking at applying the strtok

RE: proposal: snmplib/string_utils.c

2004-10-06 Thread Geert De Peuter
eld Cc: [EMAIL PROTECTED] Subject: Re: proposal: snmplib/string_utils.c On Wed, 06 Oct 2004 09:44:01 +0100 Dave wrote: DS> > If people don't like combining them, how about at least putting DS> > them in a sub-directory? DS> DS> I have long been advocating a more structured

Re: proposal: snmplib/string_utils.c

2004-10-06 Thread Coders
On Wed, 06 Oct 2004 09:44:01 +0100 Dave wrote: DS> > If people don't like combining them, how about at least putting them in a DS> > sub-directory? DS> DS> I have long been advocating a more structured approach to the library. DS> But I don't think now is the right time to start doing this. Ok, i

Re: proposal: snmplib/string_utils.c

2004-10-06 Thread Dave Shield
> If people don't like combining them, how about at least putting them in a > sub-directory? I have long been advocating a more structured approach to the library. But I don't think now is the right time to start doing this. We're meant to be concentrating on getting 5.2 out of the door. *Everyt

Re: proposal: snmplib/string_utils.c

2004-10-05 Thread Coders
On Tue, 5 Oct 2004 19:45:01 -0400 [EMAIL PROTECTED] wrote: SN> > From: Robert Story (Coders) <[EMAIL PROTECTED]> SN> > Any objections to merging strlcpy.c, strtol.c, strtoul.c and the new SN> > strtok_r into one file, string_utils.c? (or a similarly named file) SN> > SN> I see no reason to merge t

Re: proposal: snmplib/string_utils.c

2004-10-05 Thread Coders
On Tue, 5 Oct 2004 16:30:13 -0700 Steve wrote: SF> On Tue, Oct 05, 2004 at 07:09:55PM -0400, Robert Story wrote: SF> This smells like a bad idea. I can imagine all kinds of linker issues if SF> one of the functions is required by the platform [...] The code already exists, in their own files. All

Re: proposal: snmplib/string_utils.c

2004-10-05 Thread slif
I see no reason to merge them together, do you ? > > From: Robert Story (Coders) <[EMAIL PROTECTED]> > Date: 2004/10/05 Tue PM 07:09:55 EDT > To: [EMAIL PROTECTED] > Subject: proposal: snmplib/string_utils.c > > I'm looking at applying the strtok_r patch for 5.2, which will include a > strtok_r

Re: proposal: snmplib/string_utils.c

2004-10-05 Thread Coders
On Tue, 5 Oct 2004 19:09:55 -0400 Robert wrote: RS> I'm looking at applying the strtok_r patch for 5.2, which will include a RS> strtok_r implementation for platforms where it is missing. I started to RS> look for a place to put that implementation, and I notices that there are RS> several other st

Re: proposal: snmplib/string_utils.c

2004-10-05 Thread Steve Friedl
On Tue, Oct 05, 2004 at 07:09:55PM -0400, Robert Story wrote: > I'm looking at applying the strtok_r patch for 5.2, which will include a > strtok_r implementation for platforms where it is missing. I started to look > for a place to put that implementation, and I notices that there are several > ot