Re: merging cach_handler handler arg passing

2005-06-13 Thread Robert Story
On Mon, 13 Jun 2005 16:43:00 +0100 Dave wrote: DS> I propose that we make this change, and see how it turns out ok, done.. -- NOTE: messages sent directly to me, instead of the lists, will be deleted unless they are requests for paid consulting services. Robert Story; NET-SNMP Junkie

Re: merging cach_handler handler arg passing

2005-06-13 Thread Dave Shield
On Mon, 2005-06-06 at 17:38, Robert Story wrote: > On Mon, 06 Jun 2005 17:02:42 +0100 Dave wrote: > DS> What would actually break if the declaration was changed [to] > DS> netsnmp_handler_args *cache_hint; > DS> > DS> If anything is currently using this field, they must be casting > DS> it to

Re: merging cach_handler handler arg passing

2005-06-06 Thread Robert Story
On Mon, 06 Jun 2005 17:02:42 +0100 Dave wrote: DS> What would actually break if the declaration was changed from DS> DS> void *cache_hint; DS> DS> to DS> netsnmp_handler_args *cache_hint; DS> DS> If anything is currently using this field, they must be casting DS> it to a 'netsnmp_handl

Re: merging cach_handler handler arg passing

2005-06-06 Thread Dave Shield
On Mon, 2005-06-06 at 16:44, Robert Story wrote: > DS> Given that's [cache_hint] is only ever used as a pointer to a > DS> netsnmp_handler_args structure, why not declare it as such. > And now I'd imagine we are stuck in the backwards compatibility > tarpit. Or do you think we can bend the rules

Re: merging cach_handler handler arg passing

2005-06-06 Thread Robert Story
On Mon, 06 Jun 2005 10:10:14 +0100 Dave wrote: DS> The main disadvantage of the 'cache_hint' approach is that the DS> hint field is defined as an opaque "void*" pointer. How is a DS> MIB developer meant to know how to use it? Ummm, our excellent documentation? Hee hee, ha ha! Oh, I kill myself!

Re: merging cach_handler handler arg passing

2005-06-06 Thread Dave Shield
On Fri, 2005-06-03 at 20:40, Robert Story wrote: > I just noticed that you added 4 pointers to the cache_handler structure > for passing handler args to the load routine. This does almost the exact > same thing as the cache hint stuff I added in 5.2. > I'd like to see if we can't agree on a mergin

merging cach_handler handler arg passing

2005-06-03 Thread Robert Story
Dave, I just noticed that you added 4 pointers to the cache_handler structure for passing handler args to the load routine. This does almost the exact same thing as the cache hint stuff I added in 5.2. There are two main differences: 1) I added a cache_hint void *, while you added 4 pointers spec