Re: CFV: Fix possible memory overrun in fsys_getfsstats.c

2012-08-23 Thread Wes Hardaker
Dave Shield writes: >> Probably the module/code you are discussing is only used on BSD >> or there is an implementation of strlcpy somewhere in net-snmp for >> systems without. > > The second is actually true. (See snmplib/strlcpy.c) Yep, and because we're using it in lots of places and we hav

Re: CFV: Fix possible memory overrun in fsys_getfsstats.c

2012-08-23 Thread Wes Hardaker
Niels Baggesen writes: >> - It's considered a good programming practice to terminate strings >>properly that are announced as '\0'-terminated. > > SNMP OCTET STRINGS are not C strings, they are completely different > beasts. They should not be confused. Yes, but there is one thing to consid

Re: win32: errno instead of WSAGetLastError to handle WinSock errors?

2012-08-23 Thread Wes Hardaker
Schmoll Walter writes: > These are just my suggestions of what could be done. They looked like good ideas to me. Now we just need someone to create the patch :-) -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net --

Re: CFV: Return RSS not VSZ for hrSWRunPerfMem

2012-08-23 Thread Wes Hardaker
Niels Baggesen writes: > The description for hrSWRunPerfMem says that this is the amount > of Real Memory used by the process. This patch corrects this for > BSD systems +1 if this one question is true: does the new struct symbol exist everywhere? -- Wes Hardaker Please mail all replies to net-

Re: CFV: Add pkginfo data for OpenBSD (patch 3559414)

2012-08-23 Thread Wes Hardaker
Niels Baggesen writes: > Here is a corrected version! +1 :-) -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net -- Live Security Virtual Conference Exclusive live event will cover all the

Re: CFV: Add missing process status values (Net/Open-BSD)

2012-08-23 Thread Wes Hardaker
Niels Baggesen writes: > The attached patch completes the conversion of process status for > hrSWRunTable with some missing values +1 -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net --

Re: CFV: Fix for hrStorageTable on AIX (bug 3557159)

2012-08-23 Thread Wes Hardaker
Niels Baggesen writes: > The attached patch makes sure that we populate hrStorageTable on AIX. > The module in question is only used under AIX. +1 -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net --

how to view debug information in subagent mibs

2012-08-23 Thread Ire w
Hi, I am running snmp agent in a target device on linux 2.6. I need to debug IF-MIB C codes and print out my debug information. Because it is a daemon process, printf will not send to console. So, I used :syslog( LOG_DEBUG, " ifTable: testing") ; and check : cat /var/log/messages but I h

Re: CFV: Return RSS not VSZ for hrSWRunPerfMem

2012-08-23 Thread Niels Baggesen
Den 23-08-2012 19:14, Wes Hardaker skrev: > Niels Baggesen writes: > >> The description for hrSWRunPerfMem says that this is the amount >> of Real Memory used by the process. This patch corrects this for >> BSD systems > > +1 if this one question is true: does the new struct symbol exist everywher