[REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

2020-08-08 Thread Bart Van Assche
>From https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html: "The fclose() function shall perform the equivalent of a close() on the file descriptor that is associated with the stream pointed to by stream." See also https://github.com/net-snmp/net-snmp/issues/157 . Fixes: fd9a42d

Re: [REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

2020-08-08 Thread Magnus Fromreide
On Sat, Aug 08, 2020 at 11:17:52AM -0700, Bart Van Assche wrote: > From https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html: > "The fclose() function shall perform the equivalent of a close() on the file > descriptor that is associated with the stream pointed to by stream." > >

Re: [REQUEST FOR VOTES] snmpd: Call fclose() after fdopen() but not close()

2020-08-08 Thread Bart Van Assche
On 2020-08-08 16:16, Magnus Fromreide wrote: > I am putting in a 0 vote here because I think a larger rewrite is needed. Hi Magnus, I agree that agent/mibgroup/ucd-snmp/pass_persist.c should be rewritten. However, I don't think rewriting that file so close to the v5.9 release is appropriate. Henc