Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds

2010-12-22 Thread Dave Shield
On 22 December 2010 04:42, Wes Hardaker harda...@users.sourceforge.net wrote: We actually need two votes now per patch now:  - 5.5.1 (now in pre1) +1(though I'd be tempted to set the two lengths at the start of the loop, rather than the end)  - 5.6.1 (now in rc1) Hmm this

Re: doubt in nested table implementation

2010-12-22 Thread sujata patra
Thanks Wes. Ignore my last query on netsnmp_table_helper_add_indexes(). I found where I did make the mistake. From: sujata patra sujata_patra2...@yahoo.com To: Wes Hardaker harda...@users.sourceforge.net Cc: Wes Hardaker harda...@users.sourceforge.net;

Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds

2010-12-22 Thread Bill Fenner
On Wed, Dec 22, 2010 at 3:28 AM, Dave Shield d.t.shi...@liverpool.ac.uk wrote: On 22 December 2010 04:42, Wes Hardaker harda...@users.sourceforge.net wrote:  - 5.6.1 (now in rc1) Hmm   this isn't really a show-stopper, so strictly speaking shouldn't be applied. It's somehow a

CFV: Fix for bug 3109144: cant load vacmView from persistent storage

2010-12-22 Thread Niels Baggesen
The bug describes how the view mask is lost when read from the snmpd persistent file. This patch fixes it (and removes some identity casts). The crucial point is setting the viewMaskLen before calling read_octet_string. Index: snmplib/vacm.c

Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds

2010-12-22 Thread Robert Story
On Wed, 22 Dec 2010 08:28:56 + Dave wrote: DS On 22 December 2010 04:42, Wes Hardaker harda...@users.sourceforge.net wrote: DS We actually need two votes now per patch now: DS DS  - 5.5.1 (now in pre1) DS DS +1(though I'd be tempted to set the two lengths DS at the start of

Re: CFV: Fix for bug 3109144: cant load vacmView from persistent storage

2010-12-22 Thread Robert Story
On Wed, 22 Dec 2010 15:55:14 +0100 Niels wrote: NB The bug describes how the view mask is lost when read from the snmpd NB persistent file. NB NB This patch fixes it (and removes some identity casts). The crucial NB point is setting the viewMaskLen before calling read_octet_string. +1

Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds

2010-12-22 Thread Dave Shield
On 22 December 2010 16:13, Robert Story rst...@freesnmp.com wrote: DS  - 5.6.1 (now in rc1) DS DS Hmm   this isn't really a show-stopper, so strictly speaking DS shouldn't be applied. I dunno... I think broken AgentX processing is a pretty big deal. But remember the definition of show

Re: CFV: Fix for bug 3109144: cant load vacmView from persistent storage

2010-12-22 Thread Dave Shield
On 22 December 2010 14:55, Niels Baggesen n...@users.sourceforge.net wrote: The bug describes how the view mask is lost when read from the snmpd persistent file. 5.5.1: +1 5.6.1: +1 iff rc2 scheduled -1 otherwise Dave

Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds

2010-12-22 Thread Wes Hardaker
On Wed, 22 Dec 2010 18:55:49 +, Dave Shield d.t.shi...@liverpool.ac.uk said: DS Unless I've missed something, the effects of this particular problem DS don't match any of these three cases. (I believe it results in wrong DS or missing information - though I haven't been paying much

Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds

2010-12-22 Thread Wes Hardaker
On Wed, 22 Dec 2010 07:34:44 -0500, Bill Fenner fen...@gmail.com said: BF It's somehow a regression against net-snmp 5.5, so IMO it is more BF important for 5.6. I can't explain what is different in 5.5 that it BF worked with the same code, but it did. I suspect luck was involved. I suspect

Re: CFV: patch from Bill Fenner for agentx oids with multiple varbinds

2010-12-22 Thread Dave Shield
On 22 December 2010 21:51, Wes Hardaker harda...@users.sourceforge.net wrote: DS Maybe we need to review our definitions of show stopper at DS next month's admin meeting. Probably a worthy discussion. I've added this to the agenda. (Having first created an agenda to add it to :-)) Dave

schedule for 5.6.1

2010-12-22 Thread Wes Hardaker
5.6.1.rc2: 12/28 5.6.1: 1/4 -- Wes Hardaker Please mail all replies to net-snmp-coders@lists.sourceforge.net -- Learn how Oracle Real Application Clusters (RAC) One Node allows customers to consolidate database