Re: [PATCH 0/4] ip-forward-mib performance improvements

2011-03-16 Thread Robert Story
On Fri, 11 Mar 2011 09:10:01 -0800 Stephen wrote: SH The netlink one is a bit problematic, in that it unconditionally replaces the SH old code, and we need to support older systems which might not have netlink. SH Is there some header/constant we can check for that will indicate whether or

Re: [PATCH 0/4] ip-forward-mib performance improvements

2011-03-16 Thread Stephen Hemminger
On Wed, 16 Mar 2011 11:13:25 -0400 Robert Story rst...@freesnmp.com wrote: On Fri, 11 Mar 2011 09:10:01 -0800 Stephen wrote: SH The netlink one is a bit problematic, in that it unconditionally replaces the SH old code, and we need to support older systems which might not have netlink.

Re: [PATCH 0/4] ip-forward-mib performance improvements

2011-03-11 Thread Robert Story
On Mon, 28 Feb 2011 12:37:17 -0800 Stephen wrote: SH These patches fix the problems with walking the forwarding mib when a SH router has full BGP feed. Excellent! I'm glad someone finally had the time to fix this. The first 3 patches are no-brainers. I'll apply them shortly. The netlink one is

Re: [PATCH 0/4] ip-forward-mib performance improvements

2011-03-11 Thread Stephen Hemminger
On Fri, 11 Mar 2011 08:46:51 -0500 Robert Story rst...@freesnmp.com wrote: On Mon, 28 Feb 2011 12:37:17 -0800 Stephen wrote: SH These patches fix the problems with walking the forwarding mib when a SH router has full BGP feed. Excellent! I'm glad someone finally had the time to fix this.

Re: [PATCH 0/4] ip-forward-mib performance improvements

2011-03-11 Thread Stephen Hemminger
On Fri, 11 Mar 2011 08:46:51 -0500 Robert Story rst...@freesnmp.com wrote: On Mon, 28 Feb 2011 12:37:17 -0800 Stephen wrote: SH These patches fix the problems with walking the forwarding mib when a SH router has full BGP feed. Excellent! I'm glad someone finally had the time to fix this.

Re: [PATCH 0/4] ip-forward-mib performance improvements

2011-03-11 Thread Bart Van Assche
On Fri, Mar 11, 2011 at 6:42 PM, Stephen Hemminger shemmin...@vyatta.comwrote: On Fri, 11 Mar 2011 08:46:51 -0500 Robert Story rst...@freesnmp.com wrote: On Mon, 28 Feb 2011 12:37:17 -0800 Stephen wrote: SH These patches fix the problems with walking the forwarding mib when a SH router

Re: [PATCH 0/4] ip-forward-mib performance improvements

2011-03-11 Thread Stephen Hemminger
On Fri, 11 Mar 2011 18:46:56 +0100 Bart Van Assche bvanass...@acm.org wrote: On Fri, Mar 11, 2011 at 6:42 PM, Stephen Hemminger shemmin...@vyatta.comwrote: On Fri, 11 Mar 2011 08:46:51 -0500 Robert Story rst...@freesnmp.com wrote: On Mon, 28 Feb 2011 12:37:17 -0800 Stephen wrote:

[PATCH 0/4] ip-forward-mib performance improvements

2011-02-28 Thread Stephen Hemminger
These patches fix the problems with walking the forwarding mib when a router has full BGP feed. See http://linux-network-plumber.blogspot.com/2011/02/net-snmp-ip-forward-table-performance.html for the full saga. --