Re: iscsid - lfs and ipv6 issues

2023-11-19 Thread Ede Wolf
Am 19.11.23 um 13:42 schrieb Ede Wolf: Secondly: The iscsi target is ctld on FreeBSD. Currently even without any authentication. Now I doubt that an offline reporting is the case, because, relabelling the lun to 4.2BSD and mounting it with ffs does work. Without anything else being done on e

Re: iscsid - lfs and ipv6 issues

2023-11-19 Thread Ede Wolf
Am 19.11.23 um 13:23 schrieb Michael van Elst: On Sun, Nov 19, 2023 at 12:34:13PM +0100, Ede Wolf wrote: Hello, first of all a very big thanks to all of you. Since it seems I am the only one who is using ipv6 with iscsi, I do not need a fix. I can live (as I am doing now) with ipv4. I just know

Re: iscsid - lfs and ipv6 issues

2023-11-19 Thread Michael van Elst
On Sun, Nov 19, 2023 at 12:34:13PM +0100, Ede Wolf wrote: > Hello, > > first of all a very big thanks to all of you. Since it seems I am the only > one who is using ipv6 with iscsi, I do not need a fix. I can live (as I am > doing now) with ipv4. > I just know I do not have to waste any time in tr

Re: iscsid - lfs and ipv6 issues

2023-11-19 Thread Ede Wolf
Am 17.11.23 um 23:22 schrieb Michael van Elst: lis...@nebelschwaden.de (Ede Wolf) writes: I am having two issues with iscsid/iscsictl. First, it seems, I cannot mount an lfs formatted iscsi lun, no matter wether this drive is gpt/wedge or plain disklabelled: # mount -t lfs /dev/dk0 /import/

Re: iscsid - lfs and ipv6 issues

2023-11-18 Thread Michael van Elst
On Sat, Nov 18, 2023 at 07:47:47PM +0700, Robert Elz wrote: > > Using getaddrinfo() would be much better of course. That's what I have now -- Michael van Elst Internet: mlel...@serpens.de "A potential Snark may lurk in every t

Re: iscsid - lfs and ipv6 issues

2023-11-18 Thread Robert Elz
Date:Sat, 18 Nov 2023 10:46:18 - (UTC) From:mlel...@serpens.de (Michael van Elst) Message-ID: And wrt this part: | The address string is later used in iscsid_driverif.c, a name | is resolved with gethostbyname(), so while an ipv6 address might | be accepted

Re: iscsid - lfs and ipv6 issues

2023-11-18 Thread Robert Elz
Date:Sat, 18 Nov 2023 18:25:58 +0700 From:Robert Elz Message-ID: <28754.1700306...@jacaranda.noi.kre.to> | one way to do that might be | if (sp2 = strchr(str, ']')) And in that, sp2 isn't needed, just use sp instead, leading to sp = strchr(sp, ':');

Re: iscsid - lfs and ipv6 issues

2023-11-18 Thread Robert Elz
Date:Sat, 18 Nov 2023 11:26:50 - (UTC) From:mlel...@serpens.de (Michael van Elst) Message-ID: | k...@munnari.oz.au (Robert Elz) writes: | | >That looks to me as if it should work, and is a lot cleaner, though | >I doubt there's a great need to remove the [

Re: iscsid - lfs and ipv6 issues

2023-11-18 Thread Michael van Elst
k...@munnari.oz.au (Robert Elz) writes: >That looks to me as if it should work, and is a lot cleaner, though >I doubt there's a great need to remove the [] if they were given. getaddrinfo() doesn't strip or handle brackets.

Re: iscsid - lfs and ipv6 issues

2023-11-18 Thread Robert Elz
Actually, no, I don't think that will work after all - in an address like [fe80::1]:1234 the + sp = strchr(str, ':'); + if (sp != NULL) { + if (strchr(sp + 1, ':') != NULL) { code is going to happen, and set the port to 0 (instead of the intended 1234) - it need

Re: iscsid - lfs and ipv6 issues

2023-11-18 Thread Robert Elz
That looks to me as if it should work, and is a lot cleaner, though I doubt there's a great need to remove the [] if they were given. kre

Re: iscsid - lfs and ipv6 issues

2023-11-18 Thread Michael van Elst
k...@munnari.oz.au (Robert Elz) writes: > | The address parser looks broken. >It certainly is, it is horrid. >and the relevant function is get_address() Maybe the patch below. It's still a bit naive (you can bracket anything, not just ipv6 literals). The address string is later used in iscsid_

Re: iscsid - lfs and ipv6 issues

2023-11-18 Thread Robert Elz
Date:Fri, 17 Nov 2023 22:22:24 - (UTC) From:mlel...@serpens.de (Michael van Elst) Message-ID: | The address parser looks broken. It certainly is, it is horrid. | For some reason the first character is skipped when it tries | to identify IPv6, At the relev

Re: iscsid - lfs and ipv6 issues

2023-11-17 Thread Michael van Elst
lis...@nebelschwaden.de (Ede Wolf) writes: >I am having two issues with iscsid/iscsictl. First, it seems, I cannot >mount an lfs formatted iscsi lun, no matter wether this drive is >gpt/wedge or plain disklabelled: ># mount -t lfs /dev/dk0 /import/ >mount_lfs: /dev/dk0 on /import: Operation not