Fw: Re: 2.6.13-rc4-mm1

2005-07-31 Thread Andrew Morton
I assume this came in via David's net-2.6.14 tree.. Begin forwarded message: Date: Mon, 01 Aug 2005 07:52:29 +0200 From: Alexandre Buisse <[EMAIL PROTECTED]> To: Andrew Morton <[EMAIL PROTECTED]>, linux-kernel@vger.kernel.org Subject: Re: 2.6.13-rc4-mm1 Hi Andrew, I have this when I enable n

Re: [PATCH] Move bind_hash from tcp_sock to inet_sock

2005-07-31 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Mon, 1 Aug 2005 02:25:46 -0300 > Last one for tonight, tomorrow I'll continue the series. Applied, thanks Arnaldo. BTW, I'm about to rebuild the net-2.6.14 tree in order to help Andrew avoid some conflicts he's been running into when

[PATCH] Move bind_hash from tcp_sock to inet_sock

2005-07-31 Thread Arnaldo Carvalho de Melo
Hi David, Last one for tonight, tomorrow I'll continue the series. rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git - Arnaldo tree d149bde0e2bfd088aca778493f251167612298f4 parent e9ce33a100ac5f276db9eeed08ac1ed7f1e5f099 author Arnaldo Carvalh

Re: [PATCH][INET] Move the TCP hashtable functions/structs to inet_hashtables.[ch]

2005-07-31 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Mon, 1 Aug 2005 02:10:30 -0300 > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14-2.git All pulled, thanks Arnaldo. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROT

[PATCH][INET] Move the TCP hashtable functions/structs to inet_hashtables.[ch]

2005-07-31 Thread Arnaldo Carvalho de Melo
Hi David, This one completes the last changeset, moving the renamed functions to inet_hashtables.[ch], if you agree on the two last ones pull this one + the others from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14-2.git The last two ones are still at: rsync

Re: [Bugme-new] [Bug 4952] New: IPSec incompabilty. Linux kernel waits to long to start using new SA for outbound traffic.

2005-07-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 1 Aug 2005 14:30:46 +1000 > Well the problem is that the kernel simply doesn't have the information > to selectively flush dst's given a new SA. All it can do is flush out > all cached dst entries when a new SA is added. Because SA changes are > ac

Re: 2.6.13-rc4 - kernel panic - BUG at net/ipv4/tcp_output.c:918

2005-07-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 1 Aug 2005 09:36:57 +1000 > On Sun, Jul 31, 2005 at 04:21:53PM -0700, David S. Miller wrote: > > > > However, if that actually occurs, cwnd_quota would decrement past zero > > in tcp_write_xmit() and hit negative, something we also BUG() on way > > b

Re: [Bugme-new] [Bug 4952] New: IPSec incompabilty. Linux kernel waits to long to start using new SA for outbound traffic.

2005-07-31 Thread Herbert Xu
On Sun, Jul 31, 2005 at 09:26:31PM -0700, David S. Miller wrote: > > Keep in mind (as Miyazawa-san mentioned) the Mobile IPV6 > implementation will be using XFRMs inside of the kernel to do it's > implementation and we will need to handle this case. Interesting. I'll need to look this up to see

Re: [git patches] net driver fixes

2005-07-31 Thread Miles Bader
Linus Torvalds <[EMAIL PROTECTED]> writes: > Ugh. It's not like we want people saying "Hi there" in our changelogs. Well the _occasional_ friendly greeting might be kinda nice... -miles hi mom! -- Ich bin ein Virus. Mach' mit und kopiere mich in Deine .signature. fnord. - To unsubscribe from th

Re: [Bugme-new] [Bug 4952] New: IPSec incompabilty. Linux kernel waits to long to start using new SA for outbound traffic.

2005-07-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 1 Aug 2005 13:52:50 +1000 > On Mon, Aug 01, 2005 at 05:46:26AM +0200, Krzysztof Oledzki wrote: > > > > Any new patches to test? ;) > > As I said in an earlier message, you should patch racoon to delete > the old *outbound* SA when the new SA has be

Re: Fw: Re: [Bugme-new] [Bug 4952] New: IPSec incompabilty. Linux kernel waits to long to start using new SA for outbound traffic.

2005-07-31 Thread Herbert Xu
On Mon, Aug 01, 2005 at 05:46:26AM +0200, Krzysztof Oledzki wrote: > > Any new patches to test? ;) As I said in an earlier message, you should patch racoon to delete the old *outbound* SA when the new SA has been negotiated. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert X

Re: Fw: Re: [Bugme-new] [Bug 4952] New: IPSec incompabilty. Linux kernel waits to long to start using new SA for outbound traffic.

2005-07-31 Thread Krzysztof Oledzki
On Thu, 28 Jul 2005, Krzysztof Oledzki wrote: On Wed, 27 Jul 2005, Andrew Morton wrote: Please cc netdev@vger.kernel.org, [EMAIL PROTECTED], [EMAIL PROTECTED] on any reply. Begin forwarded message: Date: Wed, 27 Jul 2005 15:18:39 -0700 (PDT) From: "David S. Miller" <[EMAIL PROTECTED

Re: [git patches] net driver fixes

2005-07-31 Thread Linus Torvalds
On Sun, 31 Jul 2005, Jeff Garzik wrote: > > Please pull from the 'upstream-fixes' branch of > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git > > to obtain the fixes described in the attached diffstat/changelog/patch. Could you please try to edit the emails you apply to

Re: 2.6.13-rc4 - kernel panic - BUG at net/ipv4/tcp_output.c:918

2005-07-31 Thread Herbert Xu
On Sun, Jul 31, 2005 at 04:21:53PM -0700, David S. Miller wrote: > > However, if that actually occurs, cwnd_quota would decrement past zero > in tcp_write_xmit() and hit negative, something we also BUG() on way > before the next tcp_tso_should_defer() call. Not necessarily. We could hit tso_fragm

Re: 2.6.13-rc4 - kernel panic - BUG at net/ipv4/tcp_output.c:918

2005-07-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 1 Aug 2005 09:03:14 +1000 > I suspect that the MSS stored in the skb disagrees with the > mss_now. So when tso_fragment chops it up we end up with a TSO count > that's greater than what we started with. Oh yes, that would bolix things up. If we ge

Re: 2.6.13-rc4 - kernel panic - BUG at net/ipv4/tcp_output.c:918

2005-07-31 Thread Herbert Xu
On Sun, Jul 31, 2005 at 10:48:21PM +, David S. Miller wrote: > > that is the only exception to the "(tp->snd_cwnd <= in_flight)" > rule. I agree. I suspect that the MSS stored in the skb disagrees with the mss_now. So when tso_fragment chops it up we end up with a TSO count that's greater t

Re: 2.6.13-rc4 - kernel panic - BUG at net/ipv4/tcp_output.c:918

2005-07-31 Thread David S. Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sun, 31 Jul 2005 15:12:51 -0700 > I've been trying to upgrade kernel from 2.6.12.3 to 2.6.13-rc4 on a > rather loaded http server, but i'm currently having a kernel panic a few > minutes only after booting. The bug was reproductible (the crash > hap

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-07-31 Thread Herbert Xu
On Sun, Jul 31, 2005 at 11:40:11AM -0700, David S. Miller wrote: > > Well... Looking at your code, I came away understanding that > you needed to make the IPC objects unique per saddr/ID. That's > what you hash them by. I see. The ID is actually a constant in my original patch. The idea is tha

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-07-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 1 Aug 2005 08:33:00 +1000 > Actually that reminds me, we better add some accounting stuff so > that we know that it is being used. I agree. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTEC

Fw: 2.6.13-rc4 - kernel panic - BUG at net/ipv4/tcp_output.c:918

2005-07-31 Thread Andrew Morton
00GHz GenuineIntel GNU/Linux You can find dmesg, lspci and config at the following address: http://82.196.5.50/20050731/config.txt http://82.196.5.50/20050731/dmesg.txt http://82.196.5.50/20050731/lspci.txt http://82.196.5.50/20050731/sysctl.txt Best regards, Guillaume Pelat - To unsubscribe f

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-07-31 Thread Arthur Kepner
On Sun, 31 Jul 2005, Herbert Xu wrote: > . > Anyway, here is a patch to use inetpeer instead of that icky ipc > structure. It sure cuts down the size of the patch :) Icky?? (That's my baby you're talking about! :) The patch size reduction is impressive. > > I've only compile-tested this

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-07-31 Thread Arthur Kepner
On Sat, 30 Jul 2005, Herbert Xu wrote: > > I've finished my patch based on your work. Unfortunately the result > isn't as clean as I would've liked. However, it does point out a couple > of problems with your patch more clearly. Perhaps you could work on > those and come up with a better solu

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-07-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Mon, 1 Aug 2005 00:13:59 +1000 > Anyway, here is a patch to use inetpeer instead of that icky ipc > structure. It sure cuts down the size of the patch :) Yes, that is so much nicer. - To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-07-31 Thread Arthur Kepner
On Sun, 31 Jul 2005, David S. Miller wrote: > . > I would also suggest that some reasonable non-zero default max_win > be choosen. This stuff will not get tested otherwise. > Agree with this. (And I'll comment on the previous several mails in this thread once I've had time to review mor

Re: [EMAIL PROTECTED]: Re: weird sysctl behaviour]

2005-07-31 Thread David S. Miller
This is way many global+per-device sysctls work in the networking. The global setting is the default unless the per-device value is set, in which case it overrides the global value. Changing the global value does not change the per-device values. - To unsubscribe from this list: send the line "u

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-07-31 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sun, 31 Jul 2005 17:17:56 +1000 > On Sat, Jul 30, 2005 at 11:44:55PM -0700, David S. Miller wrote: > > > > I wish I could come up with a sane way to use the inetpeer cache to > > store this info. Unfortunately we need to key on address _and_ ID. > > Ho

Re: [PATCH] add new nfnetlink_log subsystem

2005-07-31 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Sat, 30 Jul 2005 19:33:15 +0200 > [NETFILTER] add proc_net_remove() to nfnetlink_queue and nfnetlink_log > > Also fixes a typo inside a comment. > Thanks to Sven Schuster <[EMAIL PROTECTED]> > > Signed-off-by: Harald Welte <[EMAIL PROTECTED]> Applied

Re: [git patches] new wireless stuffs

2005-07-31 Thread Jeff Garzik
Christoph Hellwig wrote: Any chance we can give the hostap driver a better name? hostap describes the AP mode it can operate on, but it should really be named after the hardware it supports in some way. If the driver gets rewritten, sure. Otherwise, users are already familiar with the name.

[EMAIL PROTECTED]: Re: weird sysctl behaviour]

2005-07-31 Thread Richard Braun
- Forwarded message from Pekka Savola <[EMAIL PROTECTED]> - X-Original-To: [EMAIL PROTECTED] Delivered-To: [EMAIL PROTECTED] Date: Sun, 31 Jul 2005 18:27:43 +0300 (EEST) From: Pekka Savola <[EMAIL PROTECTED]> To: Richard Braun <[EMAIL PROTECTED]> Subject: Re: weird sysctl behaviour In-Repl

Re: skge: ignoring bogus sensor interrups

2005-07-31 Thread Daniel Drake
Hi Stephen, Stephen Hemminger wrote: Try this: Index: skge-2.6/drivers/net/skge.c === --- skge-2.6.orig/drivers/net/skge.c2005-07-29 13:07:16.0 -0700 +++ skge-2.6/drivers/net/skge.c 2005-07-30 17:12:35.0 -0700 @@

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-07-31 Thread Herbert Xu
On Sun, Jul 31, 2005 at 05:17:56PM +1000, herbert wrote: > > However, this is even better :) Except that I'm confused by what you > said here that we need to key on the ID. Why do we need to key on > the ID? I would've thought that the saddr is sufficient. Anyway, here is a patch to use inetpeer

Re: [git patches] new wireless stuffs

2005-07-31 Thread Pavel Machek
Hi! > If this is post-2.6.13 material, that's fine. > > I've been getting tired of the slow movement of wireless. A little bit > of that is my fault, certainly. I've also been wanting to get these net > drivers out to Linux users. > > This adds HostAP, ipw2100, ipw2200, and the generic ieee8

[patch 1/6] drivers/net/eth16i.c : Use of the time_after() macro

2005-07-31 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- eth16i.c | 12

[patch 5/6] drivers/net/seeq8005.c : Use of the time_before() macro

2005-07-31 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_before() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- seeq8005.c |

Re: [git patches] new wireless stuffs

2005-07-31 Thread Christoph Hellwig
On Sat, Jul 30, 2005 at 07:24:46PM -0400, Jeff Garzik wrote: > > If this is post-2.6.13 material, that's fine. > > I've been getting tired of the slow movement of wireless. A little bit > of that is my fault, certainly. I've also been wanting to get these net > drivers out to Linux users. >

Re: skge: ignoring bogus sensor interrups

2005-07-31 Thread egolf
I am in vacation for a cupple of days, but I will try it as soon as I arrive home. Thx - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Resend: [RFC/PATCH] "safer ipv4 reassembly"

2005-07-31 Thread Herbert Xu
On Sat, Jul 30, 2005 at 11:44:55PM -0700, David S. Miller wrote: > > This bounds the pollution a remote entity could cause to the > number of hash chains we have, and no greater. Yes that sounds like a good idea. > I wish I could come up with a sane way to use the inetpeer cache to > store this

Re: [PATCH] add new nfnetlink_log subsystem

2005-07-31 Thread Harald Welte
Thanks for your comments, Sven. Dave: Please apply the attached patch on top of all other patches I sent you. It also fixes the same bug in nfnetlink_queue. Thanks! -- - Harald Welte <[EMAIL PROTECTED]> http://netfilter.org/ ===

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-07-31 Thread Harald Welte
On Sat, Jul 30, 2005 at 09:04:23PM -0700, David S. Miller wrote: > > attached is a patch that converts ebt_ulog to use the generic logging > > mechanism (and thus be able to use the nfnetlink_log backend). > > > > This patch breaks userspace compatibility, since the netlink message > > format of