Hi Trent:
Thanks for your good work. Here are the comments for your first patch.
I won't comment on the second patch since others have already looked
through it and I don't know enough about SELINUX to be of much help.
On Thu, Aug 11, 2005 at 02:21:15PM -0400, jaegert wrote:
>
> +static inline
Hi Dave,
I just wanted to make the patch to break compilation for
unconverted code for the skb->stamp change and noticed that
the patch is missing from your latest net-2.6.14 tree. Is
this deliberate or did it get lost?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the bo
Harald Welte wrote:
Just send two incremental patches to Dave.
Here they are. The first patch fixes the div64_64 function, the second
one renames some constants.
[NETFILTER]: Fix div64_64 in ipt_connbytes
Signded-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 62084bc1a04e2fbc492566fa
[NETLINK]: Return -EPROTONOSUPPORT in netlink_create() if no kernel socket is registered
This is necessary for dynamic number of netlink groups to make sure we know
the number of possible groups before bind() is called. With this change pure
userspace communication using unused netlink protocols
[NETLINK]: Add set/getsockopt options to support more than 32 groups
NETLINK_ADD_MEMBERSHIP/NETLINK_DROP_MEMBERSHIP are used to join/leave
groups, NETLINK_PKTINFO is used to enable nl_pktinfo control messages
for received packets to get the extended destination group number.
Signed-off-by: Patri
[NETLINK]: Support dynamic number of multicast groups per netlink family
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit a5314b2c777dc032b93f4f068ab1759f5610999f
tree 68571754baf232d5c76b15ec7e270b4af058867a
parent 2b1cc05d6484d70aae14d869730f8ce959ed7bdd
author Patrick McHardy <[E
[NETLINK]: Add "groups" argument to netlink_kernel_create
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 5719d60b114683e7c1bf1aa9a553efb641184e1b
tree c6a56c893ae404e6767f3cefbebd2a88a2981775
parent c366740a65d35924ee4efce970db8a738dd4b384
author Patrick McHardy <[EMAIL PROTECTED]
[NETLINK]: Remove unused groups member from struct netlink_skb_parms
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED],net>
---
commit 910f9b156d87a1d9d013985ce3973b9a0d27dbd6
tree a430be569a7d7c79088d7b830a57e31c98f95060
parent 1f74632caaf6f2bf31cf02ac28c5087e4224b02e
author Patrick McHardy <[E
[NETLINK]: Convert netlink users to use group numbers instead of bitmasks
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit a8a8c74ef1b37254f920103a6ce70237a6a55dab
tree c8decf70f15805fc7c23bee441b2ce8b14e7b264
parent 5c34a3fbc1e62fc90db80f148e07ea7817013dca
author Patrick McHardy <[
[NETLINK]: Use group numbers instead of bitmasks internally
Using the group number allows increasing the number of groups without
beeing limited by the size of the bitmask. It introduces one limitation
for netlink users: messages can't be broadcasted to multiple groups anymore,
however this featu
[NETLINK]: Fix module refcounting problems
Use-after-free: the struct proto_ops containing the module pointer
is freed when a socket with pid=0 is released, which besides for kernel
sockets is true for all unbound sockets.
Module refcount leak: when the kernel socket is closed before all user
so
Hi,
besides a small bugfix, this patchset adds support for dynamic number
of groups to netlink. To support an arbitary number of groups a couple
of changes had to me made, I'll explain them below. The patches are
only sent to netdev to avoid spamming your inboxes.
The destination groups of a pac
On Fri, Aug 12, 2005 at 09:15:44AM -0700, Stephen Hemminger wrote:
>
> Steps to reproduce:
> System is running 2 days and after that time produce this message
>
> KERNEL: assertion (cnt <= tp->packets_out) failed at
> net/ipv4/tcp_input.c (1476) KERNEL: assertion (cnt <= tp->packets_out)
> faile
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Wed, 10 Aug 2005 02:18:46 +0200
> BTW, an idea to make room for ipvs_property would be to place the three
> nfctinfo bits in the lower three bits of the nfct pointer. I'm not sure
> if it guarantees 8 byte alignemnt, which would be required for this
On 8/12/05, David S. Miller <[EMAIL PROTECTED]> wrote:
> From: James Morris <[EMAIL PROTECTED]>
> Date: Fri, 12 Aug 2005 15:00:49 -0400 (EDT)
> > Just do what you think is right for the core networking and we'll adjust
> > SELinux accordingly.
>
> Ok, I've pulled in Arnaldo's changes, as-is.
Than
Accidentally sent an old version of this patch. This is the current one.
e1000 driver updated to fill in the new field in netdevice and use the new
ethtool, "get_perm_addr".
Signed-off-by: Jon Wetzel <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
--- linux-2.6.13-rc6/dr
From: Jon Wetzel <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 15:52:28 -0500
> Adds a new field to net device to hold the permanent hardware
> address, and adds a new generic ethtool_op function to get that
> address.
>
> Signed-off-by: Jon Wetzel <[EMAIL PROTECTED]>
> Signed-off-by: John W. Linvill
e1000 driver updated to fill in the new field in netdevice and use the new
ethtool, "get_perm_addr".
Signed-off-by: Jon Wetzel <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
--- linux-2.6.12.3/drivers/net/e1000/e1000_ethtool.c2005-07-28
17:28:53.0 -0500
+++ l
Adds a new field to net device to hold the permanent hardware address, and adds
a new generic ethtool_op function to get that address.
Signed-off-by: Jon Wetzel <[EMAIL PROTECTED]>
Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
--- linux-2.6.13-rc6/include/linux/netdevice.h 2005-08-12 13:10
From: Kyle Moffett <[EMAIL PROTECTED]>
Date: Wed, 27 Jul 2005 22:44:00 -0400
> I would like to propose a cleanup for struct sockaddr_in that I think
> will make the code much more obvious and remove some icky padding
> math:
We can't use anonymous unions in the kernel, because they are not
suppor
From: James Morris <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 15:00:49 -0400 (EDT)
> On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote:
>
> > > Let me think about this over the weekend before we commit
> > > to doing things one way or the other.
> >
> > Take your time but as far as I understoo
Looks good. Thanks,
-Andi
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Harald Welte <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 21:03:43 +0200
> Ok, I hope everyone is fine with this patch:
It is, but I did not add the connbytes patch into my tree so I can't
use this patch as-is. That's why I replied "this is broken, fix u64
alignment" to the connbytes patch i
On 8/12/05, David S. Miller <[EMAIL PROTECTED]> wrote:
> From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
> Date: Fri, 12 Aug 2005 13:17:36 -0300
>
> > Just checked:
> >
> > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
> >
> > Has the reworked, not touching selinux tree
On Fri, Aug 12, 2005 at 08:23:55PM +0200, Andi Kleen wrote:
> > I don't think that we're ever going to fix that bug in the old
> > {get,set}sockopt interface, but rather introduce a netlink interface
> > when pkt_tables matures.
>
> All new interfaces should be emulation clean, so that if the old
On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote:
> > Let me think about this over the weekend before we commit
> > to doing things one way or the other.
>
> Take your time but as far as I understood from talking to James it was just a
> matter of rerunning some sort of userspace tool to regen
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
Date: Fri, 12 Aug 2005 13:17:36 -0300
> Just checked:
>
> rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
>
> Has the reworked, not touching selinux tree
We might have to reneg on changing things from tcpdiag
to inetdiag,
From: Ralf Baechle <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 11:38:15 +0100
> NET/ROM uses virtual interfaces so setting a queue length is wrong.
>
> Signed-off-by: Ralf Baechle DL5RB <[EMAIL PROTECTED]>
Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the
From: "Leonid Grossman" <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 14:04:47 -0400
> Why the total length has to be in the header, there may be other
> ways to pass the total TSO length to the driver?
Because the packet has to look like a legal IPV4 frame
for the rest of the networking stack, for
From: Dimitris Michailidis <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 10:00:12 -0700
> On 8/12/05, David S. Miller <[EMAIL PROTECTED]> wrote:
> > This would mean that every time we wish to change the data structures
> > and interfaces for TCP socket lookup, your drivers would need to
> > change.
>
> I don't think that we're ever going to fix that bug in the old
> {get,set}sockopt interface, but rather introduce a netlink interface
> when pkt_tables matures.
All new interfaces should be emulation clean, so that if the old interface
is replaced later it should eventually work. The best way to
From: Dimitris Michailidis <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 10:22:47 -0700
> This is true. There is nothing fundamentally preventing both passive
> and active opens to check netfilter before OKing a connection. Once a
> connection is established, it's rather impractical to run each of
> -Original Message-
> From: David S. Miller [mailto:[EMAIL PROTECTED]
> Sent: Thursday, August 11, 2005 4:35 PM
> To: [EMAIL PROTECTED]
> Cc: Leonid Grossman; netdev@vger.kernel.org
> Subject: Re: Super TSO performance drop
>
> From: Dmitry Yusupov <[EMAIL PROTECTED]>
> Date: Thu, 11
From: Harald Welte <[EMAIL PROTECTED]>
Date: Fri, 12 Aug 2005 17:37:30 +0200
> But getting back to the original connbytes issue. Is it worth fixing
> it, if the core iptables doesn't even work (the "old bug")?
I think it is a good policy to not let in new code, regardless of
context, which uses
On 8/12/05, Mitchell Blank Jr <[EMAIL PROTECTED]> wrote:
> I'm fairly pessimistic about full TOE also, I just want to see the patch
> cleaned up a bit so we can see the exact impact it would have. The RX
> optimization work presented in the Neterion and Intel papers at OLS sounds a
> lot more int
On 8/12/05, David S. Miller <[EMAIL PROTECTED]> wrote:
>
> > - static was removed from functions '__tcp_inherit_port' & '__tcp_v4_hash'
> > because these are called outside of tcp_ipv4.c from the TOM driver.
>
> There is no way you're going to be allowed to call such deep TCP
> internals from you
On Fri, Aug 12, 2005 at 06:14:39PM +0200, Balazs Scheidler wrote:
> > Whenever I want to sync the upstream tree, i
> > "ln -sf .git/refs/heads/master .git/HEAD; cg-update origin"
Sorry, there is a "cg-reset" missing between the "ln" and the "cg-update"
--
- Harald Welte <[EMAIL PROTECTED]>
Em Fri, Aug 12, 2005 at 01:09:59PM -0300, Arnaldo Carvalho de Melo escreveu:
> On 8/12/05, James Morris <[EMAIL PROTECTED]> wrote:
> > On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote:
> >
> > > Here I go regenerating the tree, at least this one is closer to the
> > > end of the series... I'll
Begin forwarded message:
Date: Fri, 12 Aug 2005 06:14:57 -0700
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Subject: [Bug 5050] New: KERNEL: assertion (cnt <= tp->packets_out)
failed at net/ipv4/tcp_input.c (1476)
http://bugzilla.kernel.org/show_bug.cgi?id=5050
Summary: KERNEL: as
On 8/12/05, James Morris <[EMAIL PROTECTED]> wrote:
> On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote:
>
> > Here I go regenerating the tree, at least this one is closer to the
> > end of the series... I'll just remove _all_ of the selinux related bits,
> > OK? Lesson learned :-)
>
> Ok, and
On Fri, Aug 12, 2005 at 02:03:20PM +0200, Andi Kleen wrote:
> > Unfortunately one of the iptables structures which is needed to get the
> > ruleset in the kernel (ipt_replace) is differently sized when compiled
> > for 32/64 bit. IIRC it doesn't work at all currently.
>
> Yes that's the old bug an
On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote:
> Here I go regenerating the tree, at least this one is closer to the
> end of the series... I'll just remove _all_ of the selinux related bits,
> OK? Lesson learned :-)
Ok, and I'll send a patch to make SELinux compile again :-)
- James
--
Em Fri, Aug 12, 2005 at 11:42:11AM -0400, James Morris escreveu:
> On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote:
>
> Please do NOT apply these changes to the SELinux code.
>
> These values are automatically generated and must be synchronized with
> userland policy.
>
> > diff --git a/sec
On Fri, 12 Aug 2005, Arnaldo Carvalho de Melo wrote:
Please do NOT apply these changes to the SELinux code.
These values are automatically generated and must be synchronized with
userland policy.
> diff --git a/security/selinux/include/av_inherit.h
> b/security/selinux/include/av_inherit.h
> -
On Thu, Aug 11, 2005 at 02:44:11PM +0200, Balazs Scheidler wrote:
> On Thu, 2005-08-11 at 22:31 +1000, Herbert Xu wrote:
> > Balazs Scheidler <[EMAIL PROTECTED]> wrote:
> > >
> > > I've attached a revised patch, this time with complete error checking,
> > > and
> > > propagating the error code to
On Fri, Aug 12, 2005 at 07:44:28AM -0400, John W. Linville wrote:
> Don't use crappy MUAs?
Well, plenty of people do. It's almost the norm so crappy probably
isn't very fair.
It does seem that most if the GUI-base MUAs though by default have
problematic settings (Mozilla, Thunderbird, Evolution
* Ralf Baechle <[EMAIL PROTECTED]> 2005-08-12 14:39
> On Fri, Aug 12, 2005 at 02:27:59PM +0100, Ralf Baechle wrote:
>
> > > Something I noticed doing the tty work. the 6pack driver calls
> > > netif_start_queue() before it calls register_netdev. I'm curious if this
> > > is allowed ?
> >
> > As p
Em Fri, Aug 12, 2005 at 09:12:36AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Aug 12, 2005 at 09:09:53PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@
> escreveu:
> > In article <[EMAIL PROTECTED]> (at Fri, 12 Aug 2005 08:40:24 -0300), [EMAIL
> > PROTECTED] (Arnaldo Carvalho de Melo) says:
> >
Em Fri, Aug 12, 2005 at 09:09:53PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@
escreveu:
> In article <[EMAIL PROTECTED]> (at Fri, 12 Aug 2005 08:40:24 -0300), [EMAIL
> PROTECTED] (Arnaldo Carvalho de Melo) says:
>
> > [INET6_HASHTABLES] Move inet6_lookup functions to
> > net/ipv4/inet6_hashtables.c
In article <[EMAIL PROTECTED]> (at Fri, 12 Aug 2005 08:40:24 -0300), [EMAIL
PROTECTED] (Arnaldo Carvalho de Melo) says:
> [INET6_HASHTABLES] Move inet6_lookup functions to net/ipv4/inet6_hashtables.c
>
> Doing this we allow tcp_diag to support IPV6 even if tcp_diag is compiled
> statically and IP
On Fri, Aug 12, 2005 at 04:52:49AM +0200, Patrick McHardy wrote:
> This functions looks broken.
I feared it...
> Divisor and divident are mixed up, the
> shifted result variable is not used in the actual division, the
> "first bit has to be < 32" assumption is wrong and num_shift is
> calculate
On Fri, Aug 12, 2005 at 12:37:55AM -0700, Chris Wedgwood wrote:
> On Sun, Aug 07, 2005 at 05:01:34PM +0200, Harald Welte wrote:
>
> > I will consult my legal counsel about this. My current naive
> > position on this is that only the actuall process of the
> > re-engineering matters, not the resul
On Thu, Aug 11, 2005 at 03:42:04PM -0700, David S. Miller wrote:
> From: Harald Welte <[EMAIL PROTECTED]>
> Date: Thu, 11 Aug 2005 22:03:49 +0200
>
> > +struct ipt_connbytes_info
> > +{
> > + struct {
> > + u_int64_t from; /* count to be matched */
> > + u_int64_t to; /* co
> Unfortunately one of the iptables structures which is needed to get the
> ruleset in the kernel (ipt_replace) is differently sized when compiled
> for 32/64 bit. IIRC it doesn't work at all currently.
Yes that's the old bug and cannot be fixed without breaking compatibility.
But we hope that c
Andi Kleen wrote:
> "David S. Miller" <[EMAIL PROTECTED]> writes:
>>
>>Won't work in x86 --> x86_64 compat environments.
>
> Thanks for catching it.
>
> The aligned u64 trick probably will
>
> #define aligned_u64 unsigned long long __attribute__((aligned(8)))
>
> It just forces i386 to be align
On Thu, Aug 11, 2005 at 10:36:34PM -0700, Chris Wedgwood wrote:
> On Fri, Aug 05, 2005 at 01:20:59PM -0400, John W. Linville wrote:
>
> > Yes. Opening attachments makes them harder to review.
>
> Lots of people can't inline patches because they are inflicted with
> crappy MUAs --- I would much p
Hi David,
Please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
This is based on the discussions we had on the [EMAIL PROTECTED]
about fully generalising tcp_diag, that is accomplished in this series of
changesets without breaking us
Hi David,
Please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
This is based on the discussions we had on the [EMAIL PROTECTED]
about fully generalising tcp_diag, that is accomplished in this series of
changesets without breaking us
Hi David,
Please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
This is based on the discussions we had on the [EMAIL PROTECTED]
about fully generalising tcp_diag, that is accomplished in this series of
changesets without breaking us
Hi David,
Please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
This is based on the discussions we had on the [EMAIL PROTECTED]
about fully generalising tcp_diag, that is accomplished in this series of
changesets without breaking us
Hi David,
Please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
This is based on the discussions we had on the [EMAIL PROTECTED]
about fully generalising tcp_diag, that is accomplished in this series of
changesets without breaking us
Hi David,
Please consider pulling from:
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git/
This is based on the discussions we had on the [EMAIL PROTECTED]
about fully generalising tcp_diag, that is accomplished in this series of
changesets without breaking us
"David S. Miller" <[EMAIL PROTECTED]> writes:
> From: Harald Welte <[EMAIL PROTECTED]>
> Date: Thu, 11 Aug 2005 22:03:49 +0200
>
> > +struct ipt_connbytes_info
> > +{
> > + struct {
> > + u_int64_t from; /* count to be matched */
> > + u_int64_t to; /* count to be matched
On Thu, Aug 11, 2005 at 10:36:34PM -0700, Chris Wedgwood wrote:
> On Fri, Aug 05, 2005 at 01:20:59PM -0400, John W. Linville wrote:
>
> > Yes. Opening attachments makes them harder to review.
>
> Lots of people can't inline patches because they are inflicted with
> crappy MUAs --- I would much
NET/ROM uses virtual interfaces so setting a queue length is wrong.
Signed-off-by: Ralf Baechle DL5RB <[EMAIL PROTECTED]>
net/netrom/nr_dev.c |1 -
1 files changed, 1 deletion(-)
Index: linux-cvs/net/netrom/nr_dev.c
===
--- lin
I'm fairly pessimistic about full TOE also, I just want to see the patch
cleaned up a bit so we can see the exact impact it would have. The RX
optimization work presented in the Neterion and Intel papers at OLS sounds a
lot more interesting to me though.
However, I do want to comment on one state
On Sun, Aug 07, 2005 at 05:01:34PM +0200, Harald Welte wrote:
> I will consult my legal counsel about this. My current naive
> position on this is that only the actuall process of the
> re-engineering matters, not the result.
Which countries is this advice valid for? Does someone need to chase
David S. Miller wrote:
From: Scott Bardone <[EMAIL PROTECTED]>
Date: Thu, 11 Aug 2005 23:16:14 -0700
- static was removed from functions '__tcp_inherit_port' & '__tcp_v4_hash'
because these are called outside of tcp_ipv4.c from the TOM driver.
There is no way you're going to be allowed to c
The networking gurus can comment on the internals of your patch better than
I can. Just a few style notes though:
> +#ifdef CONFIG_TCP_OFFLOAD
> +#define NETIF_F_TCPIP_OFFLOAD65536 /* Can offload TCP/IP */
> +#endif
No need to protect this inside CONFIG_* option
> +/* TOE API */
> +#i
69 matches
Mail list logo
