Re: Perf problem with qdisc ? dev_queue_xmit_nit() can be called many times for the same packet

2005-08-27 Thread jamal
On Sat, 2005-27-08 at 22:38 +0200, Eric Dumazet wrote: > Hi David > > I played and I have very good results with the following patches. > > # tc -s -d qdisc show dev eth0 ; sleep 10 ; tc -s -d qdisc show dev eth0 > qdisc pfifo_fast 0: bands 3 priomap 1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1 > Sent 440

[git patches] 2.6.x net driver fixes

2005-08-27 Thread Jeff Garzik
Please pull from the 'upstream-fixes' branch of rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git to obtain the fixes described in the diffstat/changelog/patch attached. drivers/net/hamradio/6pack.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) comm

Re: [Ieee80211-devel] Re: ieee80211 patches

2005-08-27 Thread Henrik Brix Andersen
On Sat, 2005-08-27 at 23:13 +0200, Pavel Machek wrote: > Well, we can fix the distros :-). If you provide a patch, I can test if this is an issue with the networking scripts of Gentoo Linux - and if so, push a patch for our baselayout to fix this issue. Regards, Brix -- Henrik Brix Andersen <[E

Re: ieee80211 patches

2005-08-27 Thread Pavel Machek
Hi! > >>Anyway, our rebasing from ieee80211 up to the latest development tip is > >>done across 29 commits, with a series size of 225k. > >> > > > >Are there any plans to fix "compiled into kernel" case? It works okay > >when modular, but when compiled into kernel, it fails to load > >firmware

Re: Perf problem with qdisc ? dev_queue_xmit_nit() can be called many times for the same packet

2005-08-27 Thread Eric Dumazet
David S. Miller a écrit : From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 24 Aug 2005 01:10:44 +0200 Looking at tg3_tx() more closely, I am not convinced it really needs to lock tp->tx_lock during the loop. tp->tx_cons (swidx) is changed in this function only, and could be changed to an ato

Re: Question on debugging reference counts on Net devices.

2005-08-27 Thread Ben Greear
David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Sat, 27 Aug 2005 11:19:24 -0700 Although my implementation is not there yet, it would be nice if we could use the address of the pointer than holds the dev reference as the key. We should then be able to also catch double deref

Re: Question on debugging reference counts on Net devices.

2005-08-27 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Sat, 27 Aug 2005 11:19:24 -0700 > Although my implementation is not there yet, it would be nice if we > could use the address of the pointer than holds the dev reference > as the key. We should then be able to also catch double dereferences > and places

Re: Question on debugging reference counts on Net devices.

2005-08-27 Thread Ben Greear
David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Sat, 27 Aug 2005 01:23:25 -0700 The more interesting parts of the patch is below. The basic idea is to pass a key in when you hold or put a device. This key matches puts with holds. #defined macros grab the file name and line

Re: [Bugme-new] [Bug 5138] New: 64bit put_unaligned/get_unaligned does not work on 32bit kernel

2005-08-27 Thread Andrew Morton
[EMAIL PROTECTED] wrote: > > http://bugzilla.kernel.org/show_bug.cgi?id=5138 > >Summary: 64bit put_unaligned/get_unaligned does not work on 32bit > kernel > Kernel Version: 2.6.12 > Status: NEW > Severity: normal > Owner: [EMAI

Re: ieee80211 patches

2005-08-27 Thread James Ketrenos
Pavel Machek wrote: >Hi! > > >>Anyway, our rebasing from ieee80211 up to the latest development tip is >>done across 29 commits, with a series size of 225k. >> > >Are there any plans to fix "compiled into kernel" case? It works okay >when modular, but when compiled into kernel, it fails to load >f

Re: 2.6.12 Performance problems

2005-08-27 Thread Danial Thom
--- "Vladimir B. Savkin" <[EMAIL PROTECTED]> wrote: > On Wed, Aug 24, 2005 at 11:08:43PM -0700, > Danial Thom wrote: > > If your test is still set up, try compiling > > something large while doing the test. The > drops > > go through the roof in my tests. > > > Couldn't this happen because ksof

Re: ieee80211 patches

2005-08-27 Thread Pavel Machek
Hi! > > Looks nice.. why is ieee->seq_number += 0x10; increased by 0x10? > > Sequence number is stored in bits 4 to 15 of the Sequence Control field > in 802.11 header. Lower 4 bits are used for fragment number. Comment would be nice. > > > separate-from-ethernet.patch > > > > Okay, here it st

Re: ieee80211 patches

2005-08-27 Thread Pavel Machek
Hi! > Anyway, our rebasing from ieee80211 up to the latest development tip is > done across 29 commits, with a series size of 225k. Are there any plans to fix "compiled into kernel" case? It works okay when modular, but when compiled into kernel, it fails to load firmware

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-27 Thread Eric Lemoine
On 8/27/05, Eric Lemoine <[EMAIL PROTECTED]> wrote: > On 8/26/05, Geoff Levand <[EMAIL PROTECTED]> wrote: > > This fixes a major bug in the Sun GEM Ether > > driver's netpoll implementation. When both polled > > and interrupt driven i/o are used simultaneously, > > for example when using kgdb over

Re: [PATCH] Fix netpoll bug in Sun GEM Ether driver

2005-08-27 Thread Eric Lemoine
On 8/26/05, Geoff Levand <[EMAIL PROTECTED]> wrote: > This fixes a major bug in the Sun GEM Ether > driver's netpoll implementation. When both polled > and interrupt driven i/o are used simultaneously, > for example when using kgdb over Ether with active > NFS mounts, a condition easily arises whe

Re: [PATCH] SiS190 driver oops on probe

2005-08-27 Thread Jeff Garzik
Arnaud Patard wrote: Hi, I was testing the sis190 driver and got an oops. Tests show that the error path is the following : sis190_init_one() -> register_netdev * Userspace sees the new interface and run ethtool ethX. * ethtool calls ethtools_get_settings * ethtools_get_settings tr

Re: Question on debugging reference counts on Net devices.

2005-08-27 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Sat, 27 Aug 2005 01:23:25 -0700 > The more interesting parts of the patch is below. The basic > idea is to pass a key in when you hold or put a device. This key > matches puts with holds. #defined macros grab the file name and > line number for printin

Re: Question on debugging reference counts on Net devices.

2005-08-27 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Sat, 27 Aug 2005 01:23:25 -0700 > I'm still learning git...I had to post filter that patch to get rid of > of the many diff --git lines that didn't seem to help much. The timestamps of the files are stored in the git index, so if they are different

Re: Question on debugging reference counts on Net devices.

2005-08-27 Thread Ben Greear
David S. Miller wrote: From: Ben Greear <[EMAIL PROTECTED]> Date: Fri, 26 Aug 2005 16:43:29 -0700 Btw, I think I found a leaked reference off in the ATM code...does this look legit to you? Definitely, that reference is leaked. Ok, I have the beginnings of my attempt at reference count deb

Re: Question on debugging reference counts on Net devices.

2005-08-27 Thread David S. Miller
From: Ben Greear <[EMAIL PROTECTED]> Date: Fri, 26 Aug 2005 16:43:29 -0700 > Btw, I think I found a leaked reference off in the ATM code...does this > look legit to you? Definitely, that reference is leaked. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mess