Jiri Benc wrote:
On Sat, 27 Aug 2005 11:21:37 -0500, James Ketrenos wrote:
The order required of user space is:
kernel hotplug hotplug script
--------
1. module load
2. netdev device registered
On Wed, 31 Aug 2005 10:52:54 -0700, Jean Tourrilhes wrote:
I personally consider that a bug in ifplugd. For example, the
hp100 Ethernet driver will start media sensing only in the open()
call, which means that ifplugd won't work on the hp100 driver.
It would be trivial to fix
No reply from ipv4/6 maintainers, forwarding this to the networking
list.
Begin forwarded message:
From: Denis Lukianov [EMAIL PROTECTED]
Date: 27 August 2005 16:54:05 GMT+04:00
To: [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]
Subject: [PATCH] Fix MCAST_EXCLUDE line dupe
Grepping for
On Wed, 31 Aug 2005 17:06:19 -0400, Peter Jones wrote:
Not necessarily started by hotplug, but started by something like
ifplugd or NetworkManager. And that class of programs is already
responsible for things like choosing what AP to associate, so it's an
extra degree of control for them, but
On Wed, 31 Aug 2005 22:40:00 +0200, Pavel Machek wrote:
AFAICS, with your patches ifconfig shows counts of wifi packets. How
do I get ethernet packet counts? Will tcpdump wlan0 work on ethernet
or wifi level?
Ethernet corresponds to 802.3, wifi is 802.11. These are different
standards
On Thu, Sep 01, 2005 at 02:13:21PM +0200, Jiri Benc wrote:
On Wed, 31 Aug 2005 10:52:54 -0700, Jean Tourrilhes wrote:
I personally consider that a bug in ifplugd. For example, the
hp100 Ethernet driver will start media sensing only in the open()
call, which means that ifplugd won't work
This patch fixes an skb memory leak under heavy receive load
(whenever the more packets have been received than the NAPI budget
allows to be processed).
Signed-off-by: Dale Farnsworth [EMAIL PROTECTED]
Index: linux-2.6.13-rc6-mm2-mv643xx-enet/drivers/net/mv643xx_eth.c
By the way, last time I looked at the ifplugd source it was using
outdated and incorrect ways to detect carrier. It should just
open a netlink socket and wait for carrier event. Instead it seems
to muck around looking at MII, wireless API and other ways
that only work on some devices. In current
On Thu, Sep 01, 2005 at 07:36:34PM +0100, Pedro Ramalhais wrote:
Oops, my brain had censored that part of the iwconfig manual.
Yeah, it come at the end of a long page ;-)
Reading that, and since i imagine that few people use it,
Not explicitely, but it's used internally.
On Tue, 30 Aug 2005 12:54:31 +0100
Daniel Drake [EMAIL PROTECTED] wrote:
Hi Stephen,
This looks like an issue I reported previously. After you use a recent skge,
you can't use any older drivers or the windows driver, but skge still works
fine every time.
I believe the SO_BINDTODEVICE case in net/ax25/af_x25.c (line 613 or so)
leaks a reference to a net device. It does a dev_get_by_name,
which holds a reference, but since it never assigns the pointer
anywhere, I do not see how it can ever free it later.
Please clue me in as to where it's
Ben Greear [EMAIL PROTECTED] writes:
Hello!
I believe that the aoecmd_cfg method in aoecmd.c can reference
the net-devices after free. The reason is that it grabs and releases
the interface with dev_hold, dev_put, but after putting everything, it
then does the transmit of the skbs...
Register interrupt handler when net device is registered. Avoids missing
interrupts if the interrupt mask gets out of sync.
Signed-off-by: Pierre Ossman [EMAIL PROTECTED]
---
The reason this patch is needed for me is that the resume function is
broken. It enables interrupts unconditionally, but
Ralf Baechle wrote:
On Thu, Sep 01, 2005 at 08:56:19PM +0200, Patrick McHardy wrote:
I believe the SO_BINDTODEVICE case in net/ax25/af_x25.c (line 613 or so)
leaks a reference to a net device. It does a dev_get_by_name,
which holds a reference, but since it never assigns the pointer
On Thu, Sep 01, 2005 at 08:56:19PM +0200, Patrick McHardy wrote:
I believe the SO_BINDTODEVICE case in net/ax25/af_x25.c (line 613 or so)
leaks a reference to a net device. It does a dev_get_by_name,
which holds a reference, but since it never assigns the pointer
anywhere, I do not see
Ed L Cashin wrote:
Ben Greear [EMAIL PROTECTED] writes:
Hello!
I believe that the aoecmd_cfg method in aoecmd.c can reference
the net-devices after free. The reason is that it grabs and releases
the interface with dev_hold, dev_put, but after putting everything, it
then does the transmit of
On Thu, Sep 01, 2005 at 03:06:47PM -0700, David S. Miller wrote:
- if (TCP_SKB_CB(buff)-sackedTCPCB_LOST) {
- tp-lost_out += tcp_skb_pcount(buff);
- tp-left_out += tcp_skb_pcount(buff);
+ tp-packets_out -= diff;
+ if (diff 0) {
+
Ok, here is the current version of the patch, and what I intend
to push to Linus:
diff-tree 4980a059ef42741e80e9efa0dabdf520f9ba0c5a (from
6b39374a27eb4be7e9d82145ae270ba02ea90dc8)
Author: David S. Miller [EMAIL PROTECTED]
Date: Thu Sep 1 15:06:18 2005 -0700
[TCP]: Keep TSO enabled even
From: Mike Kershaw [EMAIL PROTECTED]
Date: Tue, 23 Aug 2005 19:48:37 -0400
Same patch as before, only following Dave's advice to not change the
link type of an interface while its up.
Applied, thanks Mike.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
Please pull from 'upstream' branch of
rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git
to receive the tulip and iseries_veth updates described below:
drivers/net/iseries_veth.h | 46 --
drivers/net/iseries_veth.c | 869
From: Geoff Levand [EMAIL PROTECTED]
Date: Mon, 29 Aug 2005 15:04:24 -0700
Sure, your fix works, and seems to be the best way to do it.
Signed-off-by: Geoff Levand [EMAIL PROTECTED]
Applied, thanks everyone.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
From: Harald Welte [EMAIL PROTECTED]
Date: Tue, 30 Aug 2005 16:11:19 +0200
Hi Dave, Please apply.
Applied, thanks.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Michael Chan [EMAIL PROTECTED]
Date: Mon, 29 Aug 2005 13:29:50 -0700
On Sat, 2005-08-27 at 22:38 +0200, Eric Dumazet wrote:
- [TG3] : tx_lock spinlock is taken in tg3_tx() only when really needed.
This is similar to your tx_lock patch for tg3 but takes it one step
further to
From: Adrian Bunk [EMAIL PROTECTED]
Date: Wed, 24 Aug 2005 17:58:06 +0200
extern inline doesn't make much sense.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Applied, thanks Adrian.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
From: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Date: Thu, 01 Sep 2005 20:51:14 +0900 (JST)
This patch fixes the issue by using appropriate incoming interface,
in the sense of scoping architecture.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Applied, thanks.
-
To unsubscribe from this
Signed-off-by: Pavel Roskin [EMAIL PROTECTED]
diff-tree 8fc038ec51acf5f777fade80c5e38112b766aeee (from
ca955293cdfd3139e150d3b4fed3922a7eb651fb)
Author: Pavel Roskin [EMAIL PROTECTED]
Date: Thu Sep 1 19:10:12 2005 -0400
Change orinoco_translate_scan() to return error code on error.
Signed-off-by: Pavel Roskin [EMAIL PROTECTED]
diff-tree ca955293cdfd3139e150d3b4fed3922a7eb651fb (from
cb289b9f9b2a0f3ae7070a008f22e383b37526ee)
Author: Pavel Roskin [EMAIL PROTECTED]
Date: Thu Sep 1 19:08:00 2005 -0400
Fix memory leak on error in processing hostscan frames.
diff --git
Signed-off-by: Pavel Roskin [EMAIL PROTECTED]
diff-tree cb289b9f9b2a0f3ae7070a008f22e383b37526ee (from
56bfcdb38b3d04c1f8c1fd705e411f4be53b663c)
Author: Pavel Roskin [EMAIL PROTECTED]
Date: Thu Sep 1 19:05:16 2005 -0400
Optimize orinoco_join_ap() - break from loop once the requested
BSSID
Signed-off-by: Pavel Roskin [EMAIL PROTECTED]
diff-tree ceb6695092be8dcdfe2dec6ee5097d613011489d (from
6b39374a27eb4be7e9d82145ae270ba02ea90dc8)
Author: Pavel Roskin [EMAIL PROTECTED]
Date: Thu Sep 1 14:50:10 2005 -0400
Remove EXPERIMENTAL mark from PLX_HERMES, TMD_HERMES and PCI_HERMES.
Signed-off-by: Pavel Roskin [EMAIL PROTECTED]
diff-tree dce61aef99ceb57370b70222dc34d788666c0ac3 (from
ceb6695092be8dcdfe2dec6ee5097d613011489d)
Author: Pavel Roskin [EMAIL PROTECTED]
Date: Thu Sep 1 15:50:55 2005 -0400
New driver - orinoco_nortel.
This is a driver for Nortel
Signed-off-by: Pavel Roskin [EMAIL PROTECTED]
diff-tree dee4f325520d4ea29397dd67ca657b7235bb1790 (from
c88faac230cc9775445e5c644991c352e35c72a1)
Author: Pavel Roskin [EMAIL PROTECTED]
Date: Thu Sep 1 17:46:39 2005 -0400
New driver - spectrum_cs.
Driver for 802.11b cards using
Hi Dave:
This patch introduces sk_stream_wmem_schedule as a short-hand for
the sk_forward_alloc checking on egress.
Signed-off-by: Herbert Xu [EMAIL PROTECTED]
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page:
On 9/2/05, Ion Badulescu [EMAIL PROTECTED] wrote:
Hi David,
On Thu, 1 Sep 2005, David S. Miller wrote:
Thanks for the empty posting. Please provide the content you
intended to post, and furthermore please post it to the network
developer mailing list, netdev@vger.kernel.org
First
Ben Greear wrote:
At about line 132 of mirred.c, there is this code:
if (parm-ifindex) {
p-ifindex = parm-ifindex;
if (ret != ACT_P_CREATED)
*** It appears that this check could allow over-writing of p-dev below
without ever calling dev_put on the p-dev. Should
Hi:
I've finally found a potential cause of the sk_forward_alloc underflows
that people have been reporting sporadically.
When tcp_sendmsg tacks on extra bits to an existing TCP_PAGE we don't
check sk_forward_alloc even though a large amount of time may have
elapsed since we allocated the page.
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 2 Sep 2005 10:43:40 +1000
I've finally found a potential cause of the sk_forward_alloc underflows
that people have been reporting sporadically.
When tcp_sendmsg tacks on extra bits to an existing TCP_PAGE we don't
check sk_forward_alloc even
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 2 Sep 2005 08:11:37 +1000
On Thu, Sep 01, 2005 at 03:06:47PM -0700, David S. Miller wrote:
- if (TCP_SKB_CB(buff)-sackedTCPCB_LOST) {
- tp-lost_out += tcp_skb_pcount(buff);
- tp-left_out += tcp_skb_pcount(buff);
+
Hi All,
A new release of lksctp-tools 1.0.3 is now available for download. It is
based on the latest release of linux kernel 2.6.13 and can be downloaded
from
http://sourceforge.net/project/showfiles.php?group_id=26529
The release includes
* the following set of 4 RPM packages and 1
On Thu, Sep 01, 2005 at 05:53:03PM -0700, David S. Miller wrote:
+ tp-lost_out -= diff;
+ if ((int)tp-lost_out 0)
+ tp-lost_out = 0;
These checks aren't necessary.
Are you sure this can't happen if
On Sep 1, 2005, at 6:53 PM, Ion Badulescu wrote:
A few minutes later it has finally caught up to present time and it
starts receiving smaller packets containing real-time data. The TCP
window is still 16534 at this point.
[tcpdump output removed]
This is where things start going bad. The
On Thu, Sep 01, 2005 at 05:26:07PM +0200, Jiri Benc wrote:
The current implementation of ieee80211 as is in ieee80211 branch
contains ugly hack so it works with ethernet frames externally (which
are internally converted to and from 802.11 frames). Because 802.3 and
802.11 have the same format
From: Herbert Xu [EMAIL PROTECTED]
Date: Fri, 2 Sep 2005 11:08:12 +1000
Yes, because
diff = pcount(orig_skb) - (pcount(skb) + pcount(buff))
= pcount(orig_skb)
Now if orig_skb is marked as TCPCB_LOST, then by definition
tp-lost_out = pcount(orig_skb)
Therefore,
On Thu, Sep 01, 2005 at 09:28:16PM -0700, David S. Miller wrote:
Therefore,
tp-lost_out = diff
I assume the same applies to tp-left_out as well?
Yes it does.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page:
On Thu, Sep 01, 2005 at 09:44:09PM -0700, David S. Miller wrote:
Ok, how does this look?
Thanks Dave, this one looks perfect.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key:
From: Ben Greear [EMAIL PROTECTED]
Date: Mon, 29 Aug 2005 16:01:11 -0700
Latest netdevice ref-count debugging patch is up. The
patch is against 2.6.13:
http://www.candelatech.com/oss/rfcnt.patch
I reviewed this, and I think the approach can be refined and made more
robust.
The worst part
45 matches
Mail list logo