Re: A query regarding an entry in Andrew Morton's "must fix" list

2005-09-08 Thread Adhiraj Joshi
David, I am running an iperf test with 200 client threads and according to my knowledge the server opens only 1 socket for all the threads.. So this might be the same bug, what do you think? Thanks a lot, Adhiraj. On 9/9/05, David S. Miller <[EMAIL PROTECTED]> wrote: > From: Adhiraj Joshi <[EMA

Re: A query regarding an entry in Andrew Morton's "must fix" list

2005-09-08 Thread David S. Miller
From: Adhiraj Joshi <[EMAIL PROTECTED]> Date: Fri, 9 Sep 2005 11:35:27 +0530 > Hi, > > There was a bug some time back in a Must-Fix list regarding UDP > applications going in dead lock. > (http://kernel.org/pub/linux/kernel/people/akpm/must-fix/must-fix-2.txt) > Here is an extract: >

A query regarding an entry in Andrew Morton's "must fix" list

2005-09-08 Thread Adhiraj Joshi
Hi, There was a bug some time back in a Must-Fix list regarding UDP applications going in dead lock. (http://kernel.org/pub/linux/kernel/people/akpm/must-fix/must-fix-2.txt) Here is an extract:

Re: [PATCH 1/4] skge: gmac register access errors in dual port

2005-09-08 Thread Jeff Garzik
Each patch in this series appears in each email twice. Could you resend the series (privately if you wish), with only a single copy of each patch? Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo in

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread John W. Linville
On Fri, Sep 09, 2005 at 12:39:18AM +0200, Tommy Christensen wrote: > --- linux-2.6.13-git8/drivers/net/3c59x.c-origFri Sep 9 00:05:49 2005 > +++ linux-2.6.13-git8/drivers/net/3c59x.c Fri Sep 9 00:13:55 2005 > @@ -1889,7 +1889,9 @@ vortex_timer(unsigned long data) > { >

Re: RTL8169 freezes under load

2005-09-08 Thread Francois Romieu
Kyle Brantley <[EMAIL PROTECTED]> : [...] > One thing of note... I have an NV FX5200 in here, likewise using the > nvidia "kernel tainting" drivers. Do I 100% NEED TO replicate this with > that module unloaded, or is it fine (if nothing else, for now)? You need to reproduce the issue when the modu

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Jeff Garzik
Tommy Christensen wrote: Andrew Morton wrote: Should we also decrease the polling interval? Perhaps only when the cable is unplugged? Sounds like a plan. 60 seconds certainly strikes me as being very slow. OTOH, I'm not aware of the reasoning behind this choice in the first place. It might

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Tommy Christensen
Andrew Morton wrote: Should we also decrease the polling interval? Perhaps only when the cable is unplugged? Sounds like a plan. 60 seconds certainly strikes me as being very slow. OTOH, I'm not aware of the reasoning behind this choice in the first place. It might make sense for some odd setu

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Andrew Morton
Tommy Christensen <[EMAIL PROTECTED]> wrote: > > In order to spare some I/O operations, be more intelligent about > when to read from the PHY. Seems sane. Should we also decrease the polling interval? Perhaps only when the cable is unplugged? - To unsubscribe from this list: send the line "unsu

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Tommy Christensen
Bogdan Costescu wrote: I now understood what the problem was, so I'll put it in words for posterity: the Link Status bit of the MII Status register needs to be read twice to first clear the error state (link bit=0) after which the bit reports the actual value of the link. From the manual: Yes

Re: Current git tree oopses in tcp_time_to_recover

2005-09-08 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Fri, 9 Sep 2005 07:46:24 +1000 > On Thu, Sep 08, 2005 at 01:31:26PM -0700, David S. Miller wrote: > > From: Dave Hansen <[EMAIL PROTECTED]> > > Date: Thu, 08 Sep 2005 07:02:17 -0700 > > > > > KERNEL: assertion ((int)tp->lost_out >= 0) failed at net/ipv4/

Re: [PATCH] ieee80211: remove /proc entry for debug control

2005-09-08 Thread Stephen Hemminger
Resend of patch to remove /proc/iee80211 and just use /sys/module/iee80211/parameter/debug instead. It is simpler and cleaner. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Index: netdev-2.6/include/net/ieee80211.h === --- ne

Re: xfrm_lookup inconsistency

2005-09-08 Thread Patrick McHardy
David S. Miller wrote: From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 08 Sep 2005 23:00:39 +0200 When an error is returned in some cases xfrm_lookup releases the dst_entry and sets the pointer to NULL, in some it doesn't. There are multiple dst leaks in users of xfrm_lookup because not a

Re: Current git tree oopses in tcp_time_to_recover

2005-09-08 Thread Herbert Xu
On Thu, Sep 08, 2005 at 01:31:26PM -0700, David S. Miller wrote: > From: Dave Hansen <[EMAIL PROTECTED]> > Date: Thu, 08 Sep 2005 07:02:17 -0700 > > > KERNEL: assertion ((int)tp->lost_out >= 0) failed at net/ipv4/tcp_input.c > > (2148) > > So tp->lost_out went negative, didn't we discuss to deat

Re: xfrm_lookup inconsistency

2005-09-08 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Thu, 08 Sep 2005 23:00:39 +0200 > When an error is returned in some cases xfrm_lookup releases > the dst_entry and sets the pointer to NULL, in some it doesn't. > There are multiple dst leaks in users of xfrm_lookup because > not all take care to rel

RE: IPW2100 Kconfig

2005-09-08 Thread Alejandro Bonilla
> AFAIK hotplug looks for firmware in /lib/firmware and not > /etc/firmware. > > On 9/8/05, Pavel Machek <[EMAIL PROTECTED]> wrote: > > Hi! > > > > > I checked the IPW2100 in the current git from > linux-2.6 and the menuconfig > > > help (Kconfig) says you need to put the firmware in > /etc/

Re: IPW2100 Kconfig

2005-09-08 Thread Bharath Ramesh
AFAIK hotplug looks for firmware in /lib/firmware and not /etc/firmware. On 9/8/05, Pavel Machek <[EMAIL PROTECTED]> wrote: > Hi! > > > I checked the IPW2100 in the current git from linux-2.6 and the > > menuconfig > > help (Kconfig) says you need to put the firmware in /etc/firmware, it s

[git patch] wireless Kconfig dep fix

2005-09-08 Thread Jeff Garzik
Please pull from 'upstream' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git to obtain the fix described below: net/ieee80211/Kconfig |1 - 1 files changed, 1 deletion(-) commit 45ac56ca6403b83ad880083be164c425f4b50882 Author: Jeff Garzik <[EMAIL PROTECTED]> D

Re: [AX.25] Make asc2ax thread-proof

2005-09-08 Thread David S. Miller
From: Ralf Baechle DL5RB <[EMAIL PROTECTED]> Date: Wed, 7 Sep 2005 15:34:01 +0100 > Asc2ax was still using a static buffer for all invocations which isn't > exactly SMP-safe. Change asc2ax to take an additional result buffer as > the argument. Change all callers to provide such a buffer. > > Th

Re: [Bug 5201] New: Badness in dst_release at include/net/dst.h:154

2005-09-08 Thread David S. Miller
From: Julian Anastasov <[EMAIL PROTECTED]> Date: Thu, 8 Sep 2005 10:01:39 +0300 (EEST) > One such place that can damage the dst refcnts is route.c > with CONFIG_IP_ROUTE_MULTIPATH_CACHED enabled, i don't see the user's > .config. In this new code i see that rt_intern_hash is called before >

Re: Current git tree oopses in tcp_time_to_recover

2005-09-08 Thread David S. Miller
From: Dave Hansen <[EMAIL PROTECTED]> Date: Thu, 08 Sep 2005 07:02:17 -0700 > KERNEL: assertion ((int)tp->lost_out >= 0) failed at net/ipv4/tcp_input.c > (2148) So tp->lost_out went negative, didn't we discuss to death last week how this was impossible? :-) - To unsubscribe from this list: send

Re: IPW2100 Kconfig

2005-09-08 Thread Pavel Machek
Hi! > I checked the IPW2100 in the current git from linux-2.6 and the > menuconfig > help (Kconfig) says you need to put the firmware in /etc/firmware, it should > be /lib/firmware. > > Who should I send the "patch" to? Or can someone simply change that? Are you sure it is not distro-depe

Re: [PATCH] bnx2: Fix bug in irq handler and add prefetch

2005-09-08 Thread David S. Miller
From: "Michael Chan" <[EMAIL PROTECTED]> Date: Thu, 08 Sep 2005 08:32:25 -0700 > Fix bug in bnx2_interrupt() that caused an unnecessary register read. > The BNX2_PCICFG_MISC_STATUS should only be read when the status tag > has not changed. > > Add prefetch of the status block in bnx2_msi() simila

Re: [PATCH 0/2] [IPV6]: RFC3542 Support

2005-09-08 Thread David S. Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Thu, 08 Sep 2005 14:27:20 +0900 (JST) > git://git.skbuff.net/gitroot/yoshfuji/linux-2.6-git-rfc3542.git/ Pulled, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordo

Re: [PATCH] ipv6: need to use pskb_trim_rcsum

2005-09-08 Thread David S. Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 7 Sep 2005 14:42:44 -0700 > Fix pskb_trim usage in ipv6. Only the udp one is really > a bug, other places are just doing equivalent code. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Applied, thanks for fixing up this patch. - To

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Andy Fleming
On Sep 8, 2005, at 10:42, Bogdan Costescu wrote: On Thu, 8 Sep 2005, Tommy Christensen wrote: Personally, I'd prefer the delay to be < 10 seconds. If you sample every 60 seconds ? Teach Shannon how to do it ;-) If you mean to reduce the sampling period, there is a very good reason not t

Re: [PATCH] bnx2: Fix bug in irq handler and add prefetch

2005-09-08 Thread Jeff Garzik
Michael Chan wrote: Fix bug in bnx2_interrupt() that caused an unnecessary register read. The BNX2_PCICFG_MISC_STATUS should only be read when the status tag has not changed. Add prefetch of the status block in bnx2_msi() similar to tg3_msi(). The status block is not touched in bnx2_msi() and pr

Current git tree oopses in tcp_time_to_recover

2005-09-08 Thread Dave Hansen
I've noticed two oopses with a git tree I pulled yesterday. Last commit: 4706df3d3c42af802597d82c8b1542c3d52eab23 Probably the same bug as the one that Andrew Morton forwarded here: http://marc.theaimsgroup.com/?l=linux-netdev&m=112618307911533&w=2 I see a bunch of assertion failures, followed

netdev branch - kernel panic - bug in tcp_time_to_recover ?

2005-09-08 Thread Mateusz Berezecki
Hello List, Today I builded recent git snapshot of netdev tree and after a while i get this (hand noted due to hard lockup - no oops in syslog) Oops: [#1] Modules linked in: CPU: 0 EIP: 0060:[] Not tainted VLI EFLAGS: 00010246 (2.6.13-netdev) EIP is at tcp_time_to_recover+0x62/0xbf eax:

[PATCH] bnx2: Fix bug in irq handler and add prefetch

2005-09-08 Thread Michael Chan
Fix bug in bnx2_interrupt() that caused an unnecessary register read. The BNX2_PCICFG_MISC_STATUS should only be read when the status tag has not changed. Add prefetch of the status block in bnx2_msi() similar to tg3_msi(). The status block is not touched in bnx2_msi() and prefetching it will spee

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Bogdan Costescu
On Thu, 8 Sep 2005, Tommy Christensen wrote: Besides, how long would you like to wait for network connectivity after plugging in the cable? It is now lowered from [60-120] to [0-60] seconds. I now understood what the problem was, so I'll put it in words for posterity: the Link Status bit of

Re: 2.6.13-git7 strange system freeze

2005-09-08 Thread Jens Axboe
On Thu, Sep 08 2005, Michal Piotrowski wrote: > Hi, > > kernel: 2.6.13-mm2 > > it happens when I try to download new gnome-2.12 livecd from bittorrent. > > ng02:/home/michal# tail /var/log/kern.log > [..] > Sep 8 17:15:39 ng02 kernel: [ 3241.479108] KERNEL: assertion > ((int)tp->lost_out >= 0)

Re: 2.6.13-git7 strange system freeze

2005-09-08 Thread Michal Piotrowski
Hi, kernel: 2.6.13-mm2 it happens when I try to download new gnome-2.12 livecd from bittorrent. ng02:/home/michal# tail /var/log/kern.log [..] Sep 8 17:15:39 ng02 kernel: [ 3241.479108] KERNEL: assertion ((int)tp->lost_out >= 0) failed at net/ipv4/tcp_input.c (2148) Sep 8 17:15:39 ng02 kernel:

RE: Git broken for IPW2200

2005-09-08 Thread Alejandro Bonilla
> IPW2200 requires a different ieee80211 stack, this can be had at > ieee80211.sourceforge.net Joe, The stack is already in mainline in Linus Git. I should not need to download the ieee80211 from any place but compile with the one in the kernel. .Alejandro > > > Alejandro Bonilla Bee

Re: Git broken for IPW2200

2005-09-08 Thread Joe Bob Spamtest
IPW2200 requires a different ieee80211 stack, this can be had at ieee80211.sourceforge.net Alejandro Bonilla Beeche wrote: Hi, Where does one report this? I was building Linus Git tree as per I updated it at 09/07/2005 7:00PM PDT and got this while compiling. Where do I report this?

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Tommy Christensen
On Thu, 2005-09-08 at 15:35, Bogdan Costescu wrote: > On Thu, 8 Sep 2005, Tommy Christensen wrote: > > > The idea is to avoid an extra delay of 60 seconds before detecting > > link-up. > > But you are adding the read to a function that is called repeatedly to > fix an event that happens only on

Re: [PATCH] 3c59x: cleanup of mdio_read routines to use MII_* macros in include/linux/mii.h

2005-09-08 Thread Neil Horman
On Wed, Sep 07, 2005 at 09:49:13PM -0400, Jeff Garzik wrote: > > It would be nice if somebody would be motivated to check in > s/1/MII_BMSR/ to utilize the constant in include/linux/mii.h. > > Jeff > As requested, a patch to cleanup mdio_read routines in 3c59x.c to use the MII_* macros de

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Bogdan Costescu
On Thu, 8 Sep 2005, Tommy Christensen wrote: The idea is to avoid an extra delay of 60 seconds before detecting link-up. But you are adding the read to a function that is called repeatedly to fix an event that happens only once at start-up ! If this read is really needed (I still doubt it..

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Tommy Christensen
On Thu, 2005-09-08 at 13:58, Bogdan Costescu wrote: > Can the original poster give an explanation ? I've enjoyed a rather > well functioning 3c59x driver for the past ~6 years without such > double reading. Plus: > - this operation is I/O expensive > - it is performed inside a region protected by

promisc mode question

2005-09-08 Thread Catalin Toda
hi, I appreciate what you guys are doing here, congratulations for your work. My question is: in promiscous mode for an ethernet card, why linux kernel is not accepting frames (packets ) that have other mac address diffrent from one that is on the card ( or set with ifconfig ). Accepting meaning

Fw: 2.6.13-git7 strange system freeze

2005-09-08 Thread Andrew Morton
Begin forwarded message: Date: Thu, 8 Sep 2005 14:14:39 +0200 From: Michal Piotrowski <[EMAIL PROTECTED]> To: LKML Subject: 2.6.13-git7 strange system freeze Hi, after about 20 hours of uptime, my 2.6.13-git7 system freeze. I find it in my klog. Sep 8 13:45:09 ng02 kernel: KERNEL: assertio

Re: [PATCH] 3c59x: read current link status from phy

2005-09-08 Thread Bogdan Costescu
On Wed, 7 Sep 2005, Jeff Garzik wrote: The phy status register must be read twice in order to get the actual link state. Can the original poster give an explanation ? I've enjoyed a rather well functioning 3c59x driver for the past ~6 years without such double reading. Plus: - this operatio

Re: [PATCH] cleanup ieee80211_crypto.c

2005-09-08 Thread Christoph Hellwig
On Thu, Sep 08, 2005 at 12:59:29AM -0400, Jeff Garzik wrote: > >Index: linux-2.6/net/ieee80211/ieee80211_crypt.c > >=== > >--- linux-2.6.orig/net/ieee80211/ieee80211_crypt.c 2005-09-05 > >14:38:19.0 +0200 > >+++ linux-2.6/ne

[PATCH 2.6.13] pcnet32: set_ringparam implementation

2005-09-08 Thread Hubert WS Lin
Hi, This patch implements the set_ringparam(), one of the ethtool operations, which allows changing tx/rx ring sizes via ethtool. Changelog: - Changed memery allocation of tx/rx ring from static to dynamic - Implemented set_ringparam() - Tested on i386 and ppc64 Signed-off-by: Hubert WS Lin <

Re: [Bug 5201] New: Badness in dst_release at include/net/dst.h:154

2005-09-08 Thread David S. Miller
From: Julian Anastasov <[EMAIL PROTECTED]> Date: Thu, 8 Sep 2005 10:01:39 +0300 (EEST) > One such place that can damage the dst refcnts is route.c > with CONFIG_IP_ROUTE_MULTIPATH_CACHED enabled, i don't see the user's > .config. In this new code i see that rt_intern_hash is called before >