[PATCH]small fix for __ipv6_addr_type(...)

2005-11-12 Thread Yan Zheng
Hi. I think the scope for loopback address should be node local. Regards Signed-off-by: Yan Zheng <[EMAIL PROTECTED]> --- linux-2.6.15-rc1/net/ipv6/addrconf.c2005-11-13 12:23:06.0 +0800 +++ linux/net/ipv6

Re: [PATCH 2/2] LSM-IPSec Network Hooks

2005-11-12 Thread Herbert Xu
On Tue, Nov 01, 2005 at 10:23:56AM -0500, James Morris wrote: > On Tue, 1 Nov 2005, Herbert Xu wrote: > > > > + if (dir == FLOW_DIR_IN) > > > + read_lock_bh(&sk->sk_callback_lock); > > > > You've probably explained this already, but I wasn't paying attention :) > > Why is the lock only ne

Re: [PATCH 2/3] forcedeth support for irq mitigation

2005-11-12 Thread John W. Linville
On Sat, Nov 12, 2005 at 09:47:49PM -0500, John W. Linville wrote: > On Wed, Oct 26, 2005 at 04:27:23PM -0400, Ayaz Abdulla wrote: > > This patch contains support for different modes of interrupt mitigation > > of forcedeth. It includes changes based on Jeff's comments. Currently, > > the modes ar

Re: [PATCH 2/2] atmel: audit return code of create_proc_read_entry

2005-11-12 Thread John W. Linville
Hmmm...is there a 1/2? If so, please resend. I didn't get it, and I don't see it in the archive. Thanks, John On Sat, Nov 12, 2005 at 09:58:53PM +0300, Alexey Dobriyan wrote: > From: Christophe Lucas <[EMAIL PROTECTED]> > > Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> > Signed-off-by:

Re: [RFT] pcnet32: support for boards with multiple phys

2005-11-12 Thread John W. Linville
On Tue, Nov 08, 2005 at 11:43:54AM -0800, Don Fry wrote: > This patch contains code from Thomas Bogendoerfer which I have modified > somewhat. It works fine for me in my testing, but I would like > additional exposure to this code before submitting to mainline. > It should fix bugzilla bug #4219 a

Re: [PATCH] [PRISM54] Fix leaking of kernel buffers into short frames

2005-11-12 Thread Mike Kershaw
It isn't, I just hadn't seen that and it wasn't in my git pull. Someone had commented to me that "hey, did that ever get pushed up?" and at a glance it hadn't. Sorry for the noise, both patches seem to achieve the same ends. -m On Sat, Nov 12, 2005 at 09:58:35PM -0500, John W. Linville wrote: >

Re: [PATCH] [PRISM54] Fix leaking of kernel buffers into short frames

2005-11-12 Thread John W. Linville
Mike, Please explain why the patch below is any better/worse than the patch here: http://marc.theaimsgroup.com/?l=linux-netdev&m=112997172112090&w=2 Thanks! John On Sat, Nov 05, 2005 at 01:47:00PM -0500, Mike Kershaw wrote: > Josh Wright and I encountered this doing rawtx experiements

Re: [PATCH 2/3] forcedeth support for irq mitigation

2005-11-12 Thread John W. Linville
On Wed, Oct 26, 2005 at 04:27:23PM -0400, Ayaz Abdulla wrote: > This patch contains support for different modes of interrupt mitigation > of forcedeth. It includes changes based on Jeff's comments. Currently, > the modes are changed through module parameters since ethtool does not > support some

Re: Consensus? WAS(RFC 2863)

2005-11-12 Thread Krzysztof Halasa
jamal <[EMAIL PROTECTED]> writes: > I have a patch that seems to work for me on my laptop. > i.e on oper down it deletes the controversial routes added by the kernel > and on oper up it adds back those routes. > > I am not going to release this patch - until we get to some consensus. Just post it

Re: Consensus? WAS(RFC 2863)

2005-11-12 Thread Krzysztof Halasa
Jamal Hadi Salim <[EMAIL PROTECTED]> writes: > Issue 1: > 1) There are routes that are added by the kernel. These are labelled as > being added by the kernel. > 2) Others maybe added by a dynamic routing daemon and these would be > labelled as being inserted by such a daemon > 3) Yet others are a

RE: [PATCH] Remove drivers/net/gt64240eth.h

2005-11-12 Thread Chuck Meade
It is included and used in drivers/net/gt64240eth.c in the linux-mips git tree. I'm not sure what git tree you are intending to remove this file from, but it is used/needed in the linux-mips world, and the gt64240 is for MIPS systems after all. If this is intended to start a deletion of the 64240

[PATCH] Remove drivers/net/wan/lmc/lmc_prot.h

2005-11-12 Thread Alexey Dobriyan
From: Tobias Klauser <[EMAIL PROTECTED]> "grep "lmc_prot\." -r ." didn't show anything. Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Index: linux-kj/drivers/net/wan/lmc/lmc_prot.h

Re: [PATCH] Fix LLC Data Corruption

2005-11-12 Thread David S. Miller
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Date: Sat, 12 Nov 2005 18:15:28 -0200 > Looks okay, Dave can you please apply? > > Acked-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> I'll review and apply later tonight. Thanks. - To unsubscribe from this list: send the line "unsubscribe ne

[PATCH] Remove drivers/net/gt64240eth.h

2005-11-12 Thread Alexey Dobriyan
From: Tobias Klauser <[EMAIL PROTECTED]> "grep gt64240eth -r ." didn't show anything. Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Index: linux-kj/drivers/net/gt64240eth.h ===

Fw: [Bugme-new] [Bug 5591] New: KERNEL: assertion (!sk->sk_forward_alloc) failed at net/core/stream.c (279)

2005-11-12 Thread Andrew Morton
Begin forwarded message: Date: Fri, 11 Nov 2005 04:39:23 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5591] New: KERNEL: assertion (!sk->sk_forward_alloc) failed at net/core/stream.c (279) http://bugzilla.kernel.org/show_bug.cgi?id=5591 Summary: KE

Re: [PATCH] Fix LLC Data Corruption

2005-11-12 Thread Arnaldo Carvalho de Melo
On 11/12/05, Jochen Friedrich <[EMAIL PROTECTED]> wrote: > Hi Arnaldo, > > the observed data corruption happened for two reasons: > > 1. Upper layer still was allowed to send data when remote_busy_flag was >set. > > 2. TX Window handling could underflow if one REJ shrunk the window to 1 >a

Re: [IPV6]: Fix unnecessary GFP_ATOMIC allocation in fib6 dump

2005-11-12 Thread David S. Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Sat, 12 Nov 2005 12:55:13 +0100 > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kerne

Re: [PATCH] [NETFILTER]: Allow SYN+PSH as valid flag combination

2005-11-12 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Sat, 12 Nov 2005 11:39:18 +0100 > [NETFILTER] {ip,nf}_conntrack TCP: Accept SYN+PUSH like SYN > > Some devices (e.g. Qlogic iSCSI HBA hardware like QLA4010 up to firmware > 3.0.0.4) initiates TCP with SYN and PUSH flags set. > > The Linux TCP/IP stack

Re: [IPV6] Fix rtnetlink dump infinite loop

2005-11-12 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 12 Nov 2005 15:15:49 +1100 > The recent change to netlink dump "done" callback handling broke IPv6 > which played dirty tricks with the "done" callback. This causes an > infinite loop during a dump. > > The following patch fixes it. > > This bug w

[PATCH] Fix LLC Data Corruption

2005-11-12 Thread Jochen Friedrich
Hi Arnaldo, the observed data corruption happened for two reasons: 1. Upper layer still was allowed to send data when remote_busy_flag was set. 2. TX Window handling could underflow if one REJ shrunk the window to 1 and yet another REJ arrived. These patches fix both problems. Printing l

[PATCH 2/2] atmel: audit return code of create_proc_read_entry

2005-11-12 Thread Alexey Dobriyan
From: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Index: linux-kj/drivers/net/wireless/atmel.c === --- linux-kj.orig/drivers/net/wireless

[PATCH] ipw2100: Fix 'Driver using old /proc/net/wireless...' message

2005-11-12 Thread James Ketrenos
ipw2100: Fix 'Driver using old /proc/net/wireless...' message Wireless extensions moved the get_wireless_stats handler from being in net_device into wireless_handler. A prior instance of this patch resolved the issue for the ipw2200. This one fixes it for the ipw2100. Signed-off-by: Benoit Bois

Re: Consensus? WAS(RFC 2863)

2005-11-12 Thread jamal
On Fri, 2005-11-11 at 11:39 -0500, jamal wrote: > I will code this up when i get home on saturday. > I have a patch that seems to work for me on my laptop. i.e on oper down it deletes the controversial routes added by the kernel and on oper up it adds back those routes. I am not going to releas

Re: Consensus? WAS(RFC 2863)

2005-11-12 Thread Jamal Hadi Salim
On Fri, 2005-11-11 at 21:33 +0100, Krzysztof Halasa wrote: > jamal <[EMAIL PROTECTED]> writes: > > > well, the kernel doesnt add default routes - some admin or daemon does. > > So whatever solution it is should not delete such routes either. > > Sure. Inactivate them instead and activate back on

dupacks handling

2005-11-12 Thread eduardo segura
Hello, list! I am looking at the code that handles duplicate acks from peer. Please tell me if I'm wrong. dupacks are counted here static void tcp_add_reno_sack(struct sock *sk) { struct tcp_sock *tp = tcp_sk(sk); tp->sacked_out++; ** and the comparison to the fast-rexmit

Re: [RFC: 2.6 patch] remove ISA legacy functions

2005-11-12 Thread Al Viro
On Fri, Nov 11, 2005 at 10:29:18PM -0700, Matthew Wilcox wrote: > I think they work fine everywhere. Adrian wants to remove the API they > use. > > I think this is a bad idea. The drivers should be converted. They are - I'll send patches later today... - To unsubscribe from this list: send the

Re: [PATCH] parisc: remove copat_ioctl entires for pp

2005-11-12 Thread Matthew Wilcox
On Sat, Nov 12, 2005 at 10:52:13AM +0100, Christoph Hellwig wrote: > ppp ioctls handlers in parisc are wrong: > > - they would need to do a copat_ptr on ifr->ifr_ifru.ifru_data > - SIOCGPPP* ioctls are defines as SIOCDEVPRIVATE + n, so they'd >kick in for all private ioctls which is definte

Re: [-mm patch] drivers/net/wireless/tiacx/: add missing #include 'a

2005-11-12 Thread Denis Vlasenko
On Friday 11 November 2005 22:07, Adrian Bunk wrote: > This is required for always getting the vmalloc()/vfree() prototypes. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied, thanks. -- vda - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [

[IPV6]: Fix unnecessary GFP_ATOMIC allocation in fib6 dump

2005-11-12 Thread Thomas Graf
Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> Index: net-2.6/net/ipv6/route.c === --- net-2.6.orig/net/ipv6/route.c +++ net-2.6/net/ipv6/route.c @@ -1732,7 +1732,7 @@ int inet6_dump_fib(struct sk_buff *skb, /*

Re: [IPV6] Fix rtnetlink dump infinite loop

2005-11-12 Thread Thomas Graf
* Herbert Xu <[EMAIL PROTECTED]> 2005-11-12 15:15 > The recent change to netlink dump "done" callback handling broke IPv6 > which played dirty tricks with the "done" callback. This causes an > infinite loop during a dump. Absolutely right, thanks. - To unsubscribe from this list: send the line "u

[PATCH] [NETFILTER]: Allow SYN+PSH as valid flag combination

2005-11-12 Thread Harald Welte
On Fri, Nov 11, 2005 at 11:48:01AM -0800, David S. Miller wrote: > From: Patrick McHardy <[EMAIL PROTECTED]> > Date: Fri, 11 Nov 2005 14:58:01 +0100 > > > Unfortunately this is unlikely to happen, and if Linux itself > > accepts SYN|PSH, I don't see a reason why ip_conntrack shouldn't > > as well.

[PATCH] parisc: remove copat_ioctl entires for pp

2005-11-12 Thread Christoph Hellwig
ppp ioctls handlers in parisc are wrong: - they would need to do a copat_ptr on ifr->ifr_ifru.ifru_data - SIOCGPPP* ioctls are defines as SIOCDEVPRIVATE + n, so they'd kick in for all private ioctls which is defintely wrong. to implement proper ppp compat_ioctl handlig we'd need a compat_io

Re: [Ebtables-devel] Re: [PATCH] ebtables: Port ebt_[u]log.c to nf[netlink]_log

2005-11-12 Thread Harald Welte
Sorry for this extremely delayed follow-up, but I just noticed that this is the only patch in my 'master' branch that is not yet merged mainline. On Tue, Oct 18, 2005 at 03:12:17PM +, Bart De Schuymer wrote: > OK, but please fix the typo then. Shouldn't a similar comment be in > ebt_ulog? I'v

Re: Interrupts and NF_HOOKS

2005-11-12 Thread Harald Welte
On Tue, Nov 08, 2005 at 04:37:24PM +0200, John Que wrote: > Hello, > > Sorry; I did not completed my message; here is the full one: > > Thanks a lot for your answer ! > > Following your answer I did some reading in LDD3 and > "Undersatnding the linux kernel" and I want to > verify if I may that