Re: [PATCH] deinline some larger functions from netdevice.h

2006-03-29 Thread Andrew Morton
Denis Vlasenko <[EMAIL PROTECTED]> wrote: > > Network folks did non comment on these two patches, let me try > submitting them to you instead. They're both merged (one is in -linus, the other's in -davem). - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

[PATCH] deinline 200+ byte inlines in sock.h

2006-03-29 Thread Denis Vlasenko
We have 200+ byte inlines in sock.h. That's way too large in my opinion. Sizes in bytes (i386) and files where those inlines are used: 238 sock_queue_rcv_skb 2.6.16/net/x25/x25_in.o 238 sock_queue_rcv_skb 2.6.16/net/rose/rose_in.o 238 sock_queue_rcv_skb 2.6.16/net/packet/af_packet.o 238 sock_queu

Re: [PATCH] deinline some larger functions from netdevice.h

2006-03-29 Thread David S. Miller
From: Denis Vlasenko <[EMAIL PROTECTED]> Date: Thu, 30 Mar 2006 10:21:48 +0300 > Network folks did non comment on these two patches, let me try > submitting them to you instead. It's in my tree if you would bother checking: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git - To unsu

[PATCH] deinline some larger functions from netdevice.h

2006-03-29 Thread Denis Vlasenko
Hi Andrew, Network folks did non comment on these two patches, let me try submitting them to you instead. I hunted down some large inlines. This patch address those found in netdevice.h. On a allyesconfig'ured kernel: Size  Uses Wasted Name and definition = == =

Re: [PATCH 2/9] I/OAT

2006-03-29 Thread Evgeniy Polyakov
On Wed, Mar 29, 2006 at 02:54:04PM -0800, Chris Leech ([EMAIL PROTECTED]) wrote: > [I/OAT] Driver for the Intel(R) I/OAT DMA engine > > From: Chris Leech <[EMAIL PROTECTED]> > > Adds a new ioatdma driver > > Signed-off-by: Chris Leech <[EMAIL PROTECTED]> Let's do it again. Could you please desc

Re: dcache leak in 2.6.16-git8 II

2006-03-29 Thread Balbir Singh
On Thu, Mar 30, 2006 at 12:53:24AM +0200, Andi Kleen wrote: > On Thursday 30 March 2006 00:50, Andrew Morton wrote: > > > It looks that way. Didn't someone else report a sock_inode_cache leak? > > Didn't see it. > > > > I still got a copy of the /proc in case anybody wants more information. >

Re: [Patch 5/8] generic netlink interface for delay accounting

2006-03-29 Thread Balbir Singh
On Wed, Mar 29, 2006 at 10:26:29PM -0800, Andrew Morton wrote: > Balbir Singh <[EMAIL PROTECTED]> wrote: > > > > > The kmem_cache_free() can happen outside the lock. > > > > > > kmem_cache_free() and setting to NULL outside the lock is prone to > > race conditions. Consider the following scenario

Re: [Patch 5/8] generic netlink interface for delay accounting

2006-03-29 Thread Andrew Morton
Balbir Singh <[EMAIL PROTECTED]> wrote: > > > The kmem_cache_free() can happen outside the lock. > > > kmem_cache_free() and setting to NULL outside the lock is prone to > race conditions. Consider the following scenario > > A thread group T1 has exiting processes P1 and P2 > > P1 is exiting, f

Re: [Patch 5/8] generic netlink interface for delay accounting

2006-03-29 Thread Balbir Singh
Hi, Andrew On Wed, Mar 29, 2006 at 09:04:06PM -0800, Andrew Morton wrote: > Shailabh Nagar <[EMAIL PROTECTED]> wrote: > > > > delayacct-genetlink.patch > > > > Create a generic netlink interface (NETLINK_GENERIC family), > > called "taskstats", for getting delay and cpu statistics of > > tasks a

Re: [Patch 5/8] generic netlink interface for delay accounting

2006-03-29 Thread Andrew Morton
Shailabh Nagar <[EMAIL PROTECTED]> wrote: > > delayacct-genetlink.patch > > Create a generic netlink interface (NETLINK_GENERIC family), > called "taskstats", for getting delay and cpu statistics of > tasks and thread groups during their lifetime and when they exit. > > It's be best to have a n

Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

2006-03-29 Thread David S. Miller
From: "Brandeburg, Jesse" <[EMAIL PROTECTED]> Date: Wed, 29 Mar 2006 18:53:57 -0800 > To do this we have code like so in e1000_tso: > 2529 if (skb_shinfo(skb)->tso_size) { > 2530 if (skb_header_cloned(skb)) { > 2531 err = pskb_expand_head(skb, 0, 0,

Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

2006-03-29 Thread Phil Oester
On Wed, Mar 29, 2006 at 06:53:57PM -0800, Brandeburg, Jesse wrote: > Hi all, I've identified you as people who have at some point in the past > emailed one of the Linux lists with problems with e1000 and > sk_forward_alloc. It seems to be fairly widespread, but only seems to > have appeared with r

Re: [e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

2006-03-29 Thread Yoseph Basri
Hi Jesse, Thanks for your concern, My server still send warning message regarding this KERNEL: assertion (!sk_forward_alloc) after upgrade kernel 2.6.12 or 2.6.15. This is from dmesg server: Linux version 2.6.15.4 ([EMAIL PROTECTED]) (gcc version 3.3.4 (Debian 1:3.3.4-13)) #1 SMP Tue Feb 21 17

[e1000 debug] KERNEL: assertion (!sk_forward_alloc) failed...

2006-03-29 Thread Brandeburg, Jesse
Hi all, I've identified you as people who have at some point in the past emailed one of the Linux lists with problems with e1000 and sk_forward_alloc. It seems to be fairly widespread, but only seems to have appeared with recent kernel changes (after 2.6.12...) What I need from you is a reproduci

[Patch 5/8] generic netlink interface for delay accounting

2006-03-29 Thread Shailabh Nagar
delayacct-genetlink.patch Create a generic netlink interface (NETLINK_GENERIC family), called "taskstats", for getting delay and cpu statistics of tasks and thread groups during their lifetime and when they exit. Signed-off-by: Shailabh Nagar <[EMAIL PROTECTED]> Signed-off-by: Balbir Singh <[EMA

[Patch 4/8] generic netlink utility functions

2006-03-29 Thread Shailabh Nagar
genetlink-utils.patch Two utilities for simplifying usage of NETLINK_GENERIC interface. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> Signed-off-by: Shailabh Nagar <[EMAIL PROTECTED]> include/net/genetlink.h | 20 1 files changed, 20 insertions(+) Index: linux-2.6.16/i

RE: RX processing order for packet sockets and bridge

2006-03-29 Thread Simon Barber
The generic solution here is to use ebtables - the broute chain is there to perform exactly this kind of filtering. Set a rule in the broute chain to route these EAPOL frames, rather than bridging them. Then open the packet socket on the original interface. Simon -Original Message- From:

RE: [PATCH 2.6.16-rc5] S2io: Receive packet classification and steering mechanisms

2006-03-29 Thread Ravinandan Arakali
Hi, Just wondering if anybody got a chance to review below patch. Thanks, Ravi -Original Message- From: Ravinandan Arakali [mailto:[EMAIL PROTECTED] Sent: Friday, March 10, 2006 12:32 PM To: [EMAIL PROTECTED]; netdev@vger.kernel.org Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECT

Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem

2006-03-29 Thread Andrew Grover
On 3/28/06, Kumar Gala <[EMAIL PROTECTED]> wrote: > Do you only get callback when a channel is available? Yes > How do you > decide to do to provide PIO to the client? The client is responsible for using any channels it gets, or falling back to memcpy() if it doesn't get any. (I don't understand

[git patches] net driver updates

2006-03-29 Thread Jeff Garzik
[just sent upstream] The 'upstream-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git contains the following updates: Documentation/networking/bcm43xx.txt| 36 drivers/net/8390.h |2 drivers/net/acenic_firmware

[PATCH 4/9] [I/OAT] Utility functions for offloading sk_buff to iovec copies

2006-03-29 Thread Chris Leech
Provides for pinning user space pages in memory, copying to iovecs, and copying from sk_buffs including fragmented and chained sk_buffs. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/Makefile |3 drivers/dma/iovlock.c | 301

[PATCH 0/9] I/OAT

2006-03-29 Thread Chris Leech
This patch series is the a full release of the Intel(R) I/O Acceleration Technology (I/OAT) for Linux. It includes an in kernel API for offloading memory copies to hardware, a driver for the I/OAT DMA memcpy engine, and changes to the TCP stack to offload copies of received networking data to appl

[PATCH 5/9] [I/OAT] Structure changes for TCP recv offload to I/OAT

2006-03-29 Thread Chris Leech
Adds an async_wait_queue and some additional fields to tcp_sock, and a dma_cookie_t to sk_buff. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- include/linux/skbuff.h |4 include/linux/tcp.h|8 include/net/sock.h |2 ++ include/net/tcp.h |7 +++

[PATCH 6/9] [I/OAT] Rename cleanup_rbuf to tcp_cleanup_rbuf and make non-static

2006-03-29 Thread Chris Leech
Needed to be able to call tcp_cleanup_rbuf in tcp_input.c for I/OAT Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- include/net/tcp.h |2 ++ net/ipv4/tcp.c| 10 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index 54e4

[PATCH 1/9] [I/OAT] DMA memcpy subsystem

2006-03-29 Thread Chris Leech
Provides an API for offloading memory copies to DMA devices Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/Kconfig |2 drivers/Makefile |1 drivers/dma/Kconfig | 13 + drivers/dma/Makefile |1 drivers/dma/dmaengine.c | 405 +++

Re: dcache leak in 2.6.16-git8 II

2006-03-29 Thread Andi Kleen
On Thursday 30 March 2006 00:50, Andrew Morton wrote: > It looks that way. Didn't someone else report a sock_inode_cache leak? Didn't see it. > > I still got a copy of the /proc in case anybody wants more information. > > We have this fancy new /proc/slab_allocators now, it might show somethi

[PATCH 3/9] [I/OAT] Setup the networking subsystem as a DMA client

2006-03-29 Thread Chris Leech
Attempts to allocate per-CPU DMA channels Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/Kconfig | 12 + include/linux/netdevice.h |4 ++ include/net/netdma.h | 38 net/core/dev.c| 104 ++

[PATCH 9/9] [I/OAT] TCP recv offload to I/OAT

2006-03-29 Thread Chris Leech
Locks down user pages and sets up for DMA in tcp_recvmsg, then calls dma_async_try_early_copy in tcp_v4_do_rcv Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- net/ipv4/tcp.c | 101 -- net/ipv4/tcp_input.c | 74 ++

[PATCH 8/9] [I/OAT] Add a sysctl for tuning the I/OAT offloaded I/O threshold

2006-03-29 Thread Chris Leech
Any socket recv of less than this ammount will not be offloaded Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- include/linux/sysctl.h |1 + include/net/tcp.h |1 + net/core/user_dma.c|4 net/ipv4/sysctl_net_ipv4.c | 10 ++ 4 files changed, 16 i

[PATCH 7/9] [I/OAT] make sk_eat_skb I/OAT aware

2006-03-29 Thread Chris Leech
Add an extra argument to sk_eat_skb, and make it move early copied packets to the async_wait_queue instead of freeing them. Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- include/net/sock.h | 13 - net/dccp/proto.c |4 ++-- net/ipv4/tcp.c |8 net/llc/af_ll

[PATCH 2/9] I/OAT

2006-03-29 Thread Chris Leech
[I/OAT] Driver for the Intel(R) I/OAT DMA engine From: Chris Leech <[EMAIL PROTECTED]> Adds a new ioatdma driver Signed-off-by: Chris Leech <[EMAIL PROTECTED]> --- drivers/dma/Kconfig |9 drivers/dma/Makefile|1 drivers/dma/ioatdma.c | 805 +

Re: dcache leak in 2.6.16-git8 II

2006-03-29 Thread Andrew Morton
Andi Kleen <[EMAIL PROTECTED]> wrote: > > On Tuesday 28 March 2006 05:00, Andrew Morton wrote: > > Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > > > On Monday 27 March 2006 13:48, Bharata B Rao wrote: > > > > On Mon, Mar 27, 2006 at 07:50:20AM +0200, Andi Kleen wrote: > > > > > > > > > > A 2GB x86

Re: Goramo PCI200SYN WAN driver subsystem ID patch

2006-03-29 Thread Jeff Garzik
Krzysztof Halasa wrote: Hi Jeff, Goramo finally got PCI subsystem ID for their PCI200SYN card. The attached patch adds support for it - cards with old EEPROM data will emit a warning with URL for update tool. I plan to remove support for cards with old config sometime. Please apply to Linux 2.

Re: [PATCH 1/1] b44: ensure valid mac addr

2006-03-29 Thread Jeff Garzik
Gary Zambrano wrote: Added code to check for invalid MAC address from eeprom or user input. Signed-off-by: Gary Zambrano <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:

Re: [PATCH] spidernet : enable tx checksum offloading by default

2006-03-29 Thread Jeff Garzik
Jens Osterkamp wrote: This enables TX checksum offloading for the spidernet driver by default. Signed-off-by: Jens Osterkamp <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at h

Re: [PATCH 1/1] ixp2000: fix gcc4 breakage

2006-03-29 Thread Jeff Garzik
Lennert Buytenhek wrote: gcc4 doesn't like us declaring a static function inside another function. We can do away with this construct altogether and use BUILD_BUG_ON() instead (idea from Andi Kleen.) Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> applied - To unsubscribe from this lis

Re: [PATCH netdev-2.6.git] bonding: support carrier state for master

2006-03-29 Thread Jeff Garzik
Jay Vosburgh wrote: Add support for the bonding master to specify its carrier state based upon the state of the slaves. For 802.3ad, the bond is up if there is an active, parterned aggregator. For other modes, the bond is up if any slaves are up. Updates driver version to 3.0.3.

Re: [PATCH] Janitor: drivers/net/pcnet32: fix incorrect comments

2006-03-29 Thread Jeff Garzik
Linas Vepstas wrote: Please sign-off/ack/apply and/or forward upstream. [PATCH] Janitor: drivers/net/pcnet32: fix incorrect comments The comments concerning how the pcnet32 ethernet device driver selects the MAC addr to use are incorrect. A recent patch (in the last 3 months) changed how the

Re: [PATCH] spidernet : reduce console spam

2006-03-29 Thread Jeff Garzik
Jens Osterkamp wrote: This patch reduces the message level of the RX ram full messages from err to debug to prevent spamming the console leaving it in the logfiles though. Please apply. From: Jens Osterkamp <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscr

Re: [PATCH] acenic: fix section mismatches

2006-03-29 Thread Jeff Garzik
Randy.Dunlap wrote: From: Randy Dunlap <[EMAIL PROTECTED]> Fix section mismatches in acenic driver: WARNING: drivers/net/acenic.o - Section mismatch: reference to .init.data:tigon2FwText from .text between 'acenic_probe_one' (at offset 0x2409) and 'ace_interrupt' WARNING: drivers/net/acenic.o

Re: Please pull 'upstream' branch of wireless-2.6

2006-03-29 Thread Jeff Garzik
John W. Linville wrote: This is the merge of the bcm43xx driver, along with a variety of smaller changes. I would really like to see this in 2.6.17 if at all possible. Thanks! John --- The following changes since commit 5d5d7727a8cde78f798ecf04bac8031eff536f9d: David S. Miller: [SP

Re: dcache leak in 2.6.16-git8 II

2006-03-29 Thread Andi Kleen
On Tuesday 28 March 2006 05:00, Andrew Morton wrote: > Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > On Monday 27 March 2006 13:48, Bharata B Rao wrote: > > > On Mon, Mar 27, 2006 at 07:50:20AM +0200, Andi Kleen wrote: > > > > > > > > A 2GB x86-64 desktop system here is currently swapping itself t

Re: [PATCH]b44: fix force mac address before ifconfig up

2006-03-29 Thread Jeff Garzik
Gary Zambrano wrote: Initializing the b44 MAC & PCI functional blocks in the controller must occur inside init_one(). This will allow access to the MAC registers. The controller was being powered up in b44_open() which would not allow access to the registers before ifconfig was up. Philip Kohl

Re: [PATCH] dccp: use NULL for pointers, comfort sparse

2006-03-29 Thread David S. Miller
From: "Randy.Dunlap" <[EMAIL PROTECTED]> Date: Wed, 29 Mar 2006 11:18:14 -0800 > From: Randy Dunlap <[EMAIL PROTECTED]> > > Use NULL instead of 0 for pointers. > Fix these sparse warnings: > net/dccp/feat.c:207:20: warning: Using plain integer as NULL pointer > net/dccp/feat.c:325:21: warning: Us

Re: [PATCH] DECnet: Fix refcount

2006-03-29 Thread David S. Miller
From: Patrick Caulfield <[EMAIL PROTECTED]> Date: Wed, 29 Mar 2006 17:31:35 +0100 > This patch fixes a bug in the reference counting for the default DECnet > device. > > If the device is changed, then the new device had its refcount decremented > rather than the old one! Applied, thanks. Pleas

Re: RX processing order for packet sockets and bridge

2006-03-29 Thread shemminger
> On Wed, 2006-29-03 at 11:14 -0800, Jouni Malinen wrote: > [..] > > A digression: One of the problems of the bridge in my opinion is having > STP, a control protocol, inside the kernel. I do hope someone with time > will rip it out of the kernel some day. I looked into it, but the size of STP is

Re: RX processing order for packet sockets and bridge

2006-03-29 Thread jamal
On Wed, 2006-29-03 at 11:14 -0800, Jouni Malinen wrote: [..] A digression: One of the problems of the bridge in my opinion is having STP, a control protocol, inside the kernel. I do hope someone with time will rip it out of the kernel some day. > With STP disabled it is still possible to use the

[PATCH] dccp: use NULL for pointers, comfort sparse

2006-03-29 Thread Randy.Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Use NULL instead of 0 for pointers. Fix these sparse warnings: net/dccp/feat.c:207:20: warning: Using plain integer as NULL pointer net/dccp/feat.c:325:21: warning: Using plain integer as NULL pointer net/dccp/feat.c:526:20: warning: Using plain integer as NU

[PATCH] DECnet: Fix refcount

2006-03-29 Thread Patrick Caulfield
This patch fixes a bug in the reference counting for the default DECnet device. If the device is changed, then the new device had its refcount decremented rather than the old one! -- patrick diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c index cc7b9d9..85580b8 100644 --- a/net/decnet/dn

[PATCH 1/1] ixp2000: fix gcc4 breakage

2006-03-29 Thread Lennert Buytenhek
gcc4 doesn't like us declaring a static function inside another function. We can do away with this construct altogether and use BUILD_BUG_ON() instead (idea from Andi Kleen.) Signed-off-by: Lennert Buytenhek <[EMAIL PROTECTED]> --- linux-2.6.16-git16/drivers/net/ixp2000/ixpdev.c.orig2006

Re: 2.6.16: assertion (!sk->sk_forward_alloc) failed

2006-03-29 Thread JaniD++
Hello, list, I have this issue too sometimes (~daily), and i can help to find this one if somebody send me a debug patch! ;-) Cheers, Janos - Original Message - From: "Jesse Brandeburg" <[EMAIL PROTECTED]> To: "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]> Cc: "Phil Oester" <[EMAIL PROT