Re: [PATCH] deinline a few large functions in vlan code v2

2006-04-12 Thread Denis Vlasenko
On Tuesday 11 April 2006 16:59, Dave Dillow wrote: DaveM beat me to it, but as he said, it saves 5K only if you have all the drivers built in I have most of network drivers built in. I want network card to work right away in early boot, and I prefer to not regenerate initrd with new nic modules

Re: [RFC][PATCH] Avoid multi-page allocs for large mtu datagram sends

2006-04-12 Thread Herbert Xu
On Wed, Apr 05, 2006 at 05:51:02PM +, Zach Brown wrote: 2) I changed the final-frag test to be length + fraggap as the math later on seemed to match that.. is that OK? Yes that's a real bug introduced by a previous rework. Could you please split that off into a separate patch?

VLAN ARP requests

2006-04-12 Thread Florian Reitmeir
Hi, I don't if this a bug, and i tried to get some documentation about the behavier but failed, so here is my question.. (i tested this with 2.6.14 2.6.16.1) I have two network interfaces, lan = a1000 ethernet wlan = ipw2200 wireless then I give them the same network address/subnet ifconfig

[PATCH] atm: clip causes unregister hang

2006-04-12 Thread Stephen Hemminger
If Classical IP over ATM module is loaded or compile in to the kernel. Its neighbor table gets populated when permanent neighbor entries are created; but these entries are not flushed when the device is removed. Since the entry never gets flushed the unregister of the network device never

Re: [PATCH] atm: clip causes unregister hang

2006-04-12 Thread Herbert Xu
Hi Stephen: Stephen Hemminger [EMAIL PROTECTED] wrote: --- linux-2.6.16.2.orig/net/atm/clip.c 2006-04-12 10:10:43.0 -0700 +++ linux-2.6.16.2/net/atm/clip.c 2006-04-12 10:15:46.0 -0700 @@ -613,12 +613,19 @@ static int clip_device_event(struct notifier_block

Re: [RFC: 2.6 patch] the overdue removal of ip{,6}_queue

2006-04-12 Thread Patrick McHardy
Harald Welte wrote: On Tue, Apr 11, 2006 at 04:42:50PM +0200, Patrick McHardy wrote: I think we need to do two things: - make libipq_compat a drop-in replacement that doesn't require recompilation libipq is not distributed as a shared library (at least not by us), so I don't see any

Re: [RFC][PATCH] Avoid multi-page allocs for large mtu datagram sends

2006-04-12 Thread Zach Brown
Herbert Xu wrote: On Wed, Apr 05, 2006 at 05:51:02PM +, Zach Brown wrote: 2) I changed the final-frag test to be length + fraggap as the math later on seemed to match that.. is that OK? Yes that's a real bug introduced by a previous rework. Could you please split that off into a

Re: [RFC][PATCH] Avoid multi-page allocs for large mtu datagram sends

2006-04-12 Thread Herbert Xu
On Wed, Apr 12, 2006 at 11:22:58AM -0700, Zach Brown wrote: Did you have an opinion of the rest of the original patch? Sorry, I've been busy lately so I've only just started reading it. I should have something to say by tomorrow :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert

[RFD][PATCH] typhoon and core sample for folding away VLAN stuff (was: Re: [PATCH] deinline a few large functions in vlan code v2)

2006-04-12 Thread Ingo Oeser
Hi Denis, here is a sample patch for the vlan core and API plus typhoon driver converted as example. Just so you can see, what I meant with No #if in control flow code. I couldn't resist cleaning up the vlan core, while I'm at it. Of course I can seperate this, if you want the pure unilining

Fw: [Bugme-new] [Bug 6378] New: bonding mode=1 does not always pick right primary interface

2006-04-12 Thread Andrew Morton
Begin forwarded message: Date: Wed, 12 Apr 2006 05:57:27 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 6378] New: bonding mode=1 does not always pick right primary interface http://bugzilla.kernel.org/show_bug.cgi?id=6378 Summary: bonding mode=1

[PATCH] atm: clip causes unregister hang

2006-04-12 Thread Stephen Hemminger
If Classical IP over ATM module is loaded, its neighbor table gets populated when permanent neighbor entries are created; but these entries are not flushed when the device is removed. Since the entry never gets flushed the unregister of the network device never completes. Bug-reference:

Re: [PATCH] atm: clip causes unregister hang

2006-04-12 Thread Herbert Xu
Hi Stephen: On Wed, Apr 12, 2006 at 12:45:33PM -0700, Stephen Hemminger wrote: /* ignore non-CLIP devices */ - if (((struct net_device *) dev)-type != ARPHRD_ATM || - ((struct net_device *) dev)-hard_start_xmit != clip_start_xmit) + if (dev-type != ARPHRD_ATM ||

Re: [PATCH] atm: clip causes unregister hang

2006-04-12 Thread Stephen Hemminger
On Thu, 13 Apr 2006 06:00:15 +1000 Herbert Xu [EMAIL PROTECTED] wrote: Hi Stephen: On Wed, Apr 12, 2006 at 12:45:33PM -0700, Stephen Hemminger wrote: /* ignore non-CLIP devices */ - if (((struct net_device *) dev)-type != ARPHRD_ATM || - ((struct net_device *)

Re: [RFD][PATCH] typhoon and core sample for folding away VLAN stuff

2006-04-12 Thread Ben Greear
What is the reasoning for this change? Is the compiler able to optomize the right-hand-side to a constant with your change in place? - if (veth-h_vlan_proto != __constant_htons(ETH_P_8021Q)) { + if (veth-h_vlan_proto != htons(ETH_P_8021Q)) { return -EINVAL;

[2.6 patch] net/ipv4/: possible cleanups

2006-04-12 Thread Adrian Bunk
On Thu, Apr 06, 2006 at 01:38:57PM -0700, David S. Miller wrote: From: Adrian Bunk [EMAIL PROTECTED] Date: Thu, 6 Apr 2006 10:49:09 +0200 On Wed, Apr 05, 2006 at 10:25:43PM -0700, David S. Miller wrote: - remove the following unused EXPORT_SYMBO's: - devinet.c: devinet_ioctl

Re: [PATCH] atm: clip causes unregister hang

2006-04-12 Thread Herbert Xu
On Wed, Apr 12, 2006 at 01:15:27PM -0700, Stephen Hemminger wrote: If atm_init_atmarp has not been done, then to_atamarpd is a nop because atmarpd == NULL. Good point. But I don't see anything that will keep atmarpd from closing the socket. Previously the unregister_notifier calls served as

Re: [RFD][PATCH] typhoon and core sample for folding away VLAN stuff

2006-04-12 Thread Stephen Hemminger
On Wed, 12 Apr 2006 13:10:06 -0700 Ben Greear [EMAIL PROTECTED] wrote: What is the reasoning for this change? Is the compiler able to optomize the right-hand-side to a constant with your change in place? - if (veth-h_vlan_proto != __constant_htons(ETH_P_8021Q)) { + if

Re: [RFD][PATCH] typhoon and core sample for folding away VLAN stuff

2006-04-12 Thread David S. Miller
From: Ben Greear [EMAIL PROTECTED] Date: Wed, 12 Apr 2006 13:10:06 -0700 What is the reasoning for this change? Is the compiler able to optomize the right-hand-side to a constant with your change in place? - if (veth-h_vlan_proto != __constant_htons(ETH_P_8021Q)) { + if

Re: [2.6 patch] net/ipv4/: possible cleanups

2006-04-12 Thread David S. Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Wed, 12 Apr 2006 22:22:25 +0200 Done. I was eagerly awaiting this after seeing the wan drivers disappear. Thanks Bunk-bot. :-) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

[2.6 patch] net/xfrm/xfrm_state: unexport xfrm_state_mtu

2006-04-12 Thread Adrian Bunk
This patch removes the unused EXPORT_SYMBOL(xfrm_state_mtu). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.17-rc1-mm2-full/net/xfrm/xfrm_state.c.old 2006-04-12 22:38:57.0 +0200 +++ linux-2.6.17-rc1-mm2-full/net/xfrm/xfrm_state.c 2006-04-12 22:39:03.0 +0200 @@

Re: [PATCH] acxsm: Reduce the number of ACX_PACKED instructions

2006-04-12 Thread John W. Linville
On Sat, Mar 25, 2006 at 09:01:16PM +0100, Carlos Martin wrote: Up to now, we were using ACX_PACKED after every field. I've finally found out how to use only one at the end of each struct whilst maintaining the typedef where it is now. This should also apply to acx with a bit of fuzz, but I

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not hidden

2006-04-12 Thread John W. Linville
On Fri, Mar 24, 2006 at 10:57:22AM -0500, Dan Williams wrote: hidden this is something that ieee80211 does that's completely wrong. Drivers need to report the _exact_ ESSID from the air in their scan results. It's up to the user space app to deal with ESSID length of 0. What is the outcome of

Re: Window shrinking (was Linux v2.6.16-rc6)

2006-04-12 Thread Roberto Nibali
Thanks Mark, I guess packeteer closes window down properly, I thought Dave's reply meant that doing that was Treason. Packeteer is almost certainly being cavalier about the way it reduces windows. It could be a serious problem, depending on the way it treats traffic on the return path. The

Re: [PATCH] shutting down an interface should remove ipv4 addresses

2006-04-12 Thread Roberto Nibali
David S. Miller wrote: From: Matyas Koszik [EMAIL PROTECTED] Date: Tue, 11 Apr 2006 10:08:01 +0200 (CEST) Then it maybe shouldn't affect the flow of packets while the interface is down - or is it also something people depend on? Yes, people probably do depend upon it. Not that my voice

kernel panic (on DHCP discover?) in sky2 driver of 2.6.17-rc1

2006-04-12 Thread Guenther Thomsen
I'm happy to report, that the version of the sky2 driver in 2.6.17-rc1 yields line rate at low CPU utilization (as determined using ttcp). Unfortunately, it's not quite bug-free yet ;-} When enabling the second interface (of the same network controller) the kernel panics (perhaps during DHCP

Re: kernel panic (on DHCP discover?) in sky2 driver of 2.6.17-rc1

2006-04-12 Thread Stephen Hemminger
You need this patch, which Jeff hasn't applied yet. - Subject: sky2: crash when bringing up second port Sky2 driver will oops referencing bad memory if used on a dual port card. The problem is accessing past end of MIB counter space. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] ---

Re: [PATCH] atm: clip causes unregister hang

2006-04-12 Thread Stephen Hemminger
If Classical IP over ATM module is loaded, its neighbor table gets populated when permanent neighbor entries are created; but these entries are not flushed when the device is removed. Since the entry never gets flushed the unregister of the network device never completes. This version of the

[git patches] net driver fixes

2006-04-12 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git to receive the following updates: drivers/net/b44.c | 64 ++- drivers/net/bnx2.c|2 drivers/net/hydra.h | 177

Re: kernel panic (on DHCP discover?) in sky2 driver of 2.6.17-rc1

2006-04-12 Thread Guenther Thomsen
On Wednesday 12 April 2006 14:48, Stephen Hemminger wrote: You need this patch, which Jeff hasn't applied yet. - Subject: sky2: crash when bringing up second port Sky2 driver will oops referencing bad memory if used on a dual port card. The problem is accessing past end of MIB counter

[PATCH] atm: clip timer race

2006-04-12 Thread Stephen Hemminger
By inspection, the clip idle timer code is racy on SMP. Here is a safe version of timer management. Untested, I don't have ATM hardware. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c2006-04-12 14:24:10.0 -0700 +++ clip/net/atm/clip.c 2006-04-12

Re: [git patches] net driver fixes

2006-04-12 Thread Kumar Gala
Jeff, Noticed Andy's gianfar fixes aren't in here. I'd be good to see if we can get them in for 2.6.17 - kumar On Apr 12, 2006, at 5:14 PM, Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git to receive the

Re: [git patches] net driver fixes

2006-04-12 Thread Jeff Garzik
Kumar Gala wrote: Jeff, Noticed Andy's gianfar fixes aren't in here. I'd be good to see if we can get them in for 2.6.17 Never saw them... - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [git patches] net driver fixes

2006-04-12 Thread Kumar Gala
On Apr 12, 2006, at 5:45 PM, Jeff Garzik wrote: Kumar Gala wrote: Jeff, Noticed Andy's gianfar fixes aren't in here. I'd be good to see if we can get them in for 2.6.17 Never saw them... Odd, posted to netdev, Andy may not have copied you on them.

Re: [git patches] net driver fixes

2006-04-12 Thread Jeff Garzik
Kumar Gala wrote: On Apr 12, 2006, at 5:45 PM, Jeff Garzik wrote: Kumar Gala wrote: Jeff, Noticed Andy's gianfar fixes aren't in here. I'd be good to see if we can get them in for 2.6.17 Never saw them... Odd, posted to netdev, Andy may not have copied you on them.

[PATCH] Fix locking in gianfar

2006-04-12 Thread Andy Fleming
This patch fixes several bugs in the gianfar driver, including a major one where spinlocks were horribly broken: * Split gianfar locks into two types: TX and RX * Made it so gfar_start() now clears RHALT * Fixed a bug where calling gfar_start_xmit() with interrupts off would corrupt the

Re: Window shrinking (was Linux v2.6.16-rc6)

2006-04-12 Thread Andy Furniss
Roberto Nibali wrote: I had the distinct pleasure of partly get involved with debugging network stalls related to Linux clients (2.6.x kernel) and a Packeteer. Dare I suggest that it could be something as trivial as it looks like window scaling defaults to off on SunOS 2.5.1 and it's on on

Re: [RFC PATCH] softmac: (v2) send WEXT assoc/disassoc events to userspace

2006-04-12 Thread Johannes Berg
On Thu, 2006-03-09 at 15:41 -0500, Dan Williams wrote: Can you grab a debug log from wpa_supplicant? Run wpa_supplicant with the args -ddd, and _don't_ run it as a daemon. Mail the output to me if you don't want it to go to everyone on the cc list (might include SSIDs and such). That

Re: [RFD][PATCH] typhoon and core sample for folding away VLAN stuff

2006-04-12 Thread Dave Dillow
Ingo Oeser wrote: Dave Dillow: Is this style clean enough to have it in your driver? Though I'm not real fond of Denis's last patch, I think I prefer it's style to this, solely because it removes more code when VLANs are disabled -- you've left the spin_locks in, and have more #ifdefs.

help needed in n/w

2006-04-12 Thread varun
Hi all, Iam new to netfilters and iam trying to play around to understand a few things. By default when no policies are specified then it allows all traffic to go out and in to the n/w. I want to change this to default as deny. That is when there is no policy all should