Re: [PATCH] core: linkwatch should use jiffies64

2006-05-08 Thread David S. Miller
From: Stefan Rompf [EMAIL PROTECTED] Date: Sun, 7 May 2006 12:13:56 +0200 the linkwatch code can overflow on a jiffies wrap, scheduling work with a too large delay. If the delay is 0x8000, internal_add_timer() seems to overflow too, hiding the bug, so this isn't triggered too easily.

Re: [PATCH]ip_options_fragment() has no effect on fragmentation

2006-05-08 Thread Wei Yongjun
I had tested the patch under linux system, maybe this mail is correct. Fix error point to options in ip_options_fragment(). optptr get a error pointer to the ipv4 header, correct is pointer to ipv4 options. Signed-off-by: Wei Yongjun [EMAIL PROTECTED] --- a/net/ipv4/ip_options.c 2006-01-27

Re: ipsec tunnel asymmetrical mtu

2006-05-08 Thread Marco Berizzi
Herbert Xu wrote: However, the fact that the tcpdump causes more chunky packets to make it through could be an indication that there is a bug somewhere in our NAT/IPsec code or at least a suboptimal memory allocation strategy that's somehow avoided when AF_PACKET pins the skb down. Ciao

Re: [rfc][patch] ipvs: use proper timeout instead of fixed value

2006-05-08 Thread Horms
On Sun, May 07, 2006 at 11:13:33PM -0400, Andy Gospodarek wrote: On Sun, May 07, 2006 at 01:38:40PM +0900, Horms wrote: On Fri, May 05, 2006 at 02:57:26PM -0400, Andy Gospodarek wrote: On Fri, May 05, 2006 at 12:20:54PM +0900, Horms wrote: Sorry, I missunderstood your patch

Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user].

2006-05-08 Thread Evgeniy Polyakov
I hope he does not take offence at name shortening :) I've sligtly modified UDP receiving path and run several benchmarks in the following cases: 1. pure recvfrom() using copy_to_user() with 4k and 40k buffers. 2. recvfrom() remains the same, but skb-data is copied into kernel buffer which can be

Re: [RFC 1/3] [IPSEC] xfrm: Undo afinfo lock proliferation

2006-05-08 Thread Herbert Xu
Hi Ingo: On Mon, May 08, 2006 at 03:22:14PM +0200, Ingo Oeser wrote: you wrote: diff --git a/include/net/xfrm.h b/include/net/xfrm.h --- a/include/net/xfrm.h +++ b/include/net/xfrm.h @@ -204,8 +204,7 @@ struct xfrm_type; ?struct xfrm_dst; ?struct xfrm_policy_afinfo {

Re: [RFC 1/3] [IPSEC] xfrm: Undo afinfo lock proliferation

2006-05-08 Thread Ingo Oeser
Hi Herbert, Herbert Xu schrieb: It's just moving an existing line down if you look further up in the patch. Of couse I would have nothing against a patch that replaced 256 with IPPROTO_MAX or something. Ahh, that's the actual meaning here... However, I prefer to not mix clean-ups with

[PATCH,RFC] set_security implementation inside softmac

2006-05-08 Thread Daniel Drake
Hi, This patch moves the boring set_security logic (which is currently duplicated line-for-line in zd1211 and bcm43xx) into softmac, and adds a hook so that drivers can still be notified about sec changes (so that they can upload keys to the device, etc). I also attached a patch for bcm43xx

Re: [rfc][patch] ipvs: use proper timeout instead of fixed value

2006-05-08 Thread Wensong Zhang
Hi Andy, On Sun, 7 May 2006, Andy Gospodarek wrote: On Sun, May 07, 2006 at 11:32:00PM +0800, Wensong Zhang wrote: Hi Andy, Yes, the original sychronziation design is a sort of arbitary or compromised solution. We don't want to synchronize every state change from master to backup load

Re: IPv6 connect() from site-local to global IPv6 address.

2006-05-08 Thread Rick Jones
Anyway, it is valid to use (obsolete) site-local source address for global destination address. The problem seems that router does NOT send ICMPv6 destination unreachable to the sender. I don't know why, but it SHOULD. I'll pursue that question later. It wouldn't be _sufficient_ since there

Re: [PATCH] netdev: hotplug napi race cleanup

2006-05-08 Thread Stephen Hemminger
On Sat, 06 May 2006 18:09:47 -0700 (PDT) David S. Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 24 Apr 2006 15:23:41 -0700 This follows after the earlier two patches. Change the initialization of the class device portion of the net device to be

Re: dBm cutoff at -1dBm is too low

2006-05-08 Thread Jean Tourrilhes
On Sat, May 06, 2006 at 11:32:12PM -0400, Pavel Roskin wrote: On Fri, 2006-05-05 at 10:28 -0700, Jean Tourrilhes wrote: There are still quite a few drivers which have not been converted to use IW_QUAL_DBM, so I don't want to drop the backward compatibility yet. But shouldn't you

Re: [PATCH] TCP congestion module: add TCP-LP supporting for 2.6.16.14

2006-05-08 Thread Pavel Machek
Hi! TCP Low Priority is a distributed algorithm whose goal is to utilize only the excess network bandwidth as compared to the ``fair share`` of bandwidth as targeted by TCP. Available from: http://www.ece.rice.edu/~akuzma/Doc/akuzma/TCP-LP.pdf Nice... I'd like to use something like

Re: [PATCH] TCP congestion module: add TCP-LP supporting for 2.6.16.14

2006-05-08 Thread Wong Edison
umum... as i am new in submitting patch... althought i have already read for a lot of reference... i know only a little about the format required :( i would like to do whatever i need to do may u give me some hints about how to do so ?? net-nice -n 19 rsync ?? sorry that i don't know what is

Re: 2.4 kern: want to print TCP cwnd with every packet

2006-05-08 Thread Stephen Hemminger
On Sat, 6 May 2006 10:19:16 -0400 (EDT) George P Nychis [EMAIL PROTECTED] wrote: Hi, I'd like to print the TCP cwnd for the sender, with every packet before it is sent out. This way i could plot the sender window over time to show TCP's behavior in certain conditions. I see in

Re: [RFC] SECMARK 1.0

2006-05-08 Thread Karl MacMillan
On Sun, 2006-05-07 at 13:43 -0400, James Morris wrote: On Sun, 7 May 2006, Joshua Brindle wrote: It looks like you are labeling all packets on an established connection as tracked_packet_t. What is the rationale for not labeling all ftp traffic as ftpd_packet_t? Granted that its very

Re: [RFC][SECMARK 08/08] Add selinux_relabel_packet_permission() check to xt_SECMARK

2006-05-08 Thread Karl MacMillan
On Sun, 2006-05-07 at 11:40 -0400, James Morris wrote: This patch adds the selinux_relabel_packet_permission() check to the SECMARK target, so that SELinux policy is consulted to ensure that the labeling operation is permitted by the current task. Signed-off-by: James Morris [EMAIL

Re: [PATCH] TCP congestion module: add TCP-LP supporting for 2.6.16.14

2006-05-08 Thread David S. Miller
From: Pavel Machek [EMAIL PROTECTED] Date: Mon, 8 May 2006 11:29:15 + Hi! TCP Low Priority is a distributed algorithm whose goal is to utilize only the excess network bandwidth as compared to the ``fair share`` of bandwidth as targeted by TCP. Available from:

Re: [PATCH] netdev: hotplug napi race cleanup

2006-05-08 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 8 May 2006 09:54:58 -0700 The issue is are there network devices that can't sleep during register_netdevice? Oh right, I forgot about that. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: IPv6 connect() from site-local to global IPv6 address.

2006-05-08 Thread David Woodhouse
On Mon, 2006-05-08 at 09:44 -0700, Rick Jones wrote: Or get the applications fixed no? Kludging around application bugs sounds a bit like the Fram Oil Filter commercial where the mechanic is grinning while he says You can pay me now, or you can pay be later. As in pay for the slightly more

Re: [PATCH] netdev: hotplug napi race cleanup

2006-05-08 Thread Stephen Hemminger
On Mon, 08 May 2006 11:37:31 -0700 (PDT) David S. Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 8 May 2006 09:54:58 -0700 The issue is are there network devices that can't sleep during register_netdevice? Oh right, I forgot about that. We could

Re: Hardware flow control on RTL8169

2006-05-08 Thread Francois Romieu
[EMAIL PROTECTED] [EMAIL PROTECTED] : [...] I'm using a kurobox (www.kurobox.com) with a 2.6.15 kernel and I'd like to use hardware flow control with it. However it seems the driver doesn't support it, is that correct ? At least I see the device continue sending even when the other device is

Re: Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user].

2006-05-08 Thread Evgeniy Polyakov
On Mon, May 08, 2006 at 04:24:22PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: Luckily TCP processing is much more costly, e1000 interrupt handler is too big, there are a lot of context switches and other cache-unfriendly and locking stuff, but I still wonder where does 6 (!) times

Re: [PATCH] TCP congestion module: add TCP-LP supporting for 2.6.16.14

2006-05-08 Thread David S. Miller
From: Wong Edison [EMAIL PROTECTED] Date: Tue, 9 May 2006 01:50:36 +0800 Or, just include it, and select it with the TCP_CONGESTION socket option when you want it. Sorry, this does require app modifications. i would like to have more information about this so within the app after create

Re: Initial benchmarks of some VJ ideas [mmap memcpy vs copy_to_user].

2006-05-08 Thread David S. Miller
From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Mon, 8 May 2006 23:51:32 +0400 Since nocopy is actually equal to dma into mapped buffer, so we get something close to 6 times less CPU usage, and if it can be lineary transferred into performance gain, we found where the most significant part of

[PATCH] Fix RTL8019AS init for Toshiba RBTX49xx boards

2006-05-08 Thread Sergei Shtylyov
Ensure that 8-bit mode is selected for the on-board Realtek RTL8019AS chip on Toshiba RBHMA4x00, get rid of the duplicate #ifdef's when setting ei_status.word16. The chip's datasheet says that the PSTOP register shouldn't exceed 0x60 in 8-bit mode -- ensure this too. Signed-off-by: Sergei

Re: [RFC][SECMARK 08/08] Add selinux_relabel_packet_permission() check to xt_SECMARK

2006-05-08 Thread James Morris
On Mon, 8 May 2006, Karl MacMillan wrote: Glad that you added this. This only checks on the addition of rules, correct? Obviously changes that don't include an addition (e.g., removal) could change the labeling behavior. Is it possible / needed to try to provide anything like the

[PATCH 1/4] New IrDA maintainer

2006-05-08 Thread Samuel Ortiz
As agreed with Jean Tourrilhes, I am taking over IrDA maintainership. Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- MAINTAINERS |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) e6a1573bed4cefc91fafcd56eb67dd3d1e92dddc diff --git a/MAINTAINERS b/MAINTAINERS index

Re: [RFC] SECMARK 1.0

2006-05-08 Thread James Morris
On Mon, 8 May 2006, Karl MacMillan wrote: Something like CONNMARK seems preferable to me (perhaps even allowing type_transition rules to give the related packets a unique type). This makes the labeling reflect the real security property of the packets. That's arguable. The real security

[PATCH 2/4] IrDA: Removing unused EXPORT_SYMBOLs

2006-05-08 Thread Samuel Ortiz
This patch removes the following unused EXPORT_SYMBOL's: - irias_find_attrib - irias_new_string_value - irias_new_octseq_value Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- net/irda/irias_object.c |3 --- 1 files changed, 0 insertions(+), 3

[PATCH 3/4] IrDA: smsc-ircc: Minimal hotplug support.

2006-05-08 Thread Samuel Ortiz
Minimal PNP hotplug support for the smsc-ircc2 driver. A modular driver will be modprobed via hotplug, but still bypasses driver model probing. Signed-off-by: David Brownell [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] --- drivers/net/irda/smsc-ircc2.c | 14

[PATCH 4/4] IrDA: Switching to a workqueue for the SIR work

2006-05-08 Thread Samuel Ortiz
Since sir_kthread.c pretty much duplicates the workqueue functionality, we'd better switch. The SIR fsm has been merged into sir_dev.c and thus sir_kthread.c is deleted. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Signed-off-by: Samuel Ortiz [EMAIL PROTECTED] ---

[PATCH 0/9] I/OAT network recv copy offload

2006-05-08 Thread Chris Leech
A few changes after going over all the memory allocations, but mostly just keeping the patches up to date. This patch series is the a full release of the Intel(R) I/O Acceleration Technology (I/OAT) for Linux. It includes an in kernel API for offloading memory copies to hardware, a driver for

[PATCH 2/9] I/OAT network recv copy offload

2006-05-08 Thread Chris Leech
[I/OAT] Driver for the Intel(R) I/OAT DMA engine From: Chris Leech [EMAIL PROTECTED] Adds a new ioatdma driver Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/Kconfig |9 drivers/dma/Makefile|1 drivers/dma/ioatdma.c | 839

[PATCH 9/9] [I/OAT] TCP recv offload to I/OAT

2006-05-08 Thread Chris Leech
Locks down user pages and sets up for DMA in tcp_recvmsg, then calls dma_async_try_early_copy in tcp_v4_do_rcv Signed-off-by: Chris Leech [EMAIL PROTECTED] --- net/ipv4/tcp.c | 103 -- net/ipv4/tcp_input.c | 74

[PATCH 3/9] [I/OAT] Setup the networking subsystem as a DMA client

2006-05-08 Thread Chris Leech
Attempts to allocate per-CPU DMA channels Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/Kconfig | 12 + include/linux/netdevice.h |4 ++ include/net/netdma.h | 38 net/core/dev.c| 104

[PATCH 6/9] [I/OAT] Rename cleanup_rbuf to tcp_cleanup_rbuf and make non-static

2006-05-08 Thread Chris Leech
Needed to be able to call tcp_cleanup_rbuf in tcp_input.c for I/OAT Signed-off-by: Chris Leech [EMAIL PROTECTED] --- include/net/tcp.h |2 ++ net/ipv4/tcp.c| 10 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/include/net/tcp.h b/include/net/tcp.h index

[PATCH 7/9] [I/OAT] make sk_eat_skb I/OAT aware

2006-05-08 Thread Chris Leech
Add an extra argument to sk_eat_skb, and make it move early copied packets to the async_wait_queue instead of freeing them. Signed-off-by: Chris Leech [EMAIL PROTECTED] --- include/net/sock.h | 13 - net/dccp/proto.c |4 ++-- net/ipv4/tcp.c |8

[PATCH 4/9] [I/OAT] Utility functions for offloading sk_buff to iovec copies

2006-05-08 Thread Chris Leech
Provides for pinning user space pages in memory, copying to iovecs, and copying from sk_buffs including fragmented and chained sk_buffs. Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/dma/Makefile |3 drivers/dma/iovlock.c | 301

[PATCH 5/9] [I/OAT] Structure changes for TCP recv offload to I/OAT

2006-05-08 Thread Chris Leech
Adds an async_wait_queue and some additional fields to tcp_sock, and a dma_cookie_t to sk_buff. Signed-off-by: Chris Leech [EMAIL PROTECTED] --- include/linux/skbuff.h |4 include/linux/tcp.h|8 include/net/sock.h |2 ++ include/net/tcp.h |7 +++

[PATCH 1/9] [I/OAT] DMA memcpy subsystem

2006-05-08 Thread Chris Leech
Provides an API for offloading memory copies to DMA devices Signed-off-by: Chris Leech [EMAIL PROTECTED] --- drivers/Kconfig |2 drivers/Makefile |1 drivers/dma/Kconfig | 13 + drivers/dma/Makefile |1 drivers/dma/dmaengine.c | 408

[patch 8/9] Add more support for the Yukon Ultra chip found in dual core centino laptops.

2006-05-08 Thread Stephen Hemminger
The newest Yukon Ultra chipset's require more special tweaks. They seem to be like the Yukon XL chipsets. This code is transliterated from the latest SysKonnect driver; I don't have any Ultra hardware. Signed-off-by: Stephe Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++

[patch 6/9] sky2: dont write status ring

2006-05-08 Thread Stephen Hemminger
It is more efficient not to write the status ring from the processor and just read the active portion. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c2006-05-02 09:49:38.0 -0700 +++ sky2/drivers/net/sky2.c 2006-05-02 09:49:42.0

[patch 5/9] sky2: edge triggered workaround enhancement

2006-05-08 Thread Stephen Hemminger
Need to make the edge-triggered workaround timer faster to get marginally better peformance. The test_and_set_bit in schedule_prep() acts as a barrier already. Make it a module parameter so that laptops who are concerned about power can set it to 0; and user's stuck with broken BIOS's can turn the

[patch 1/9] sky2: backout NAPI reschedule

2006-05-08 Thread Stephen Hemminger
This is a backout of earlier patch. The whole rescheduling hack was a bad idea. It doesn't really solve the problem and it makes the code more complicated for no good reason. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c @@

[patch 0/9] sky2 update

2006-05-08 Thread Stephen Hemminger
Bug fixes for sky2 driver: * fix NAPI related race that caused hangs * possible fixes for Yukon Ultra PHY support * performance improvement of ring management * fix race with irq on module removal -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

[patch 4/9] sky2: use mask instead of modulo operation

2006-05-08 Thread Stephen Hemminger
Gcc isn't smart enough to know that it can do a modulo operation with power of 2 constant by doing a mask. So add macro to do it for us. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c @@ -79,6 +79,8 @@ #define NAPI_WEIGHT

[patch 2/9] sky2: status irq hang fix

2006-05-08 Thread Stephen Hemminger
The status interrupt flag should be cleared before processing, not afterwards to avoid race. Need to process in poll routine even if no new interrupt status. This is a normal occurrence when more than 64 frames (NAPI weight) are processed in one poll routine. Signed-off-by: Stephen Hemminger

[patch 3/9] sky2: tx ring index mask fix

2006-05-08 Thread Stephen Hemminger
Mask for transmit ring status was picking up bits from the unused sync ring. They were always zero, so far... Also, make sure to remind self not to make tx ring too big. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c @@ -1927,7

[patch 9/9] sky2: version 1.3

2006-05-08 Thread Stephen Hemminger
Update version number, to track changes. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c @@ -51,7 +51,7 @@ #include sky2.h #define DRV_NAME sky2 -#define DRV_VERSION1.2 +#define DRV_VERSION

Re: RFC: new WIP version of au1000_eth.c phylib conversion (was Re: RFC: au1000_etc.c phylib rewrite)

2006-05-08 Thread Andy Fleming
On May 4, 2006, at 04:17, Herbert Valerio Riedel wrote: Hello, I've tried to adapt the PHY detection code to allow for dynamic runtime configuration (with fallback to search for the 2nd MAC PHY on the 1st MAC's MII bus), as well as selectable static PHY configuration through Kconfig (e.g.

iproute2 git repository

2006-05-08 Thread Stephen Hemminger
I moved iproute2 out of CVS. New home is: git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git Will keep CVS tree up to date until the next release, after that it is will rest in peace. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Please pull updated network drivers

2006-05-08 Thread Stephen Hemminger
These fixes are for 2.6.17, please excuse my git learning curve. I have about had it for today. git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/netdev-2.6.git upstream Daniel Drake: softmac: don't reassociate if user asked for deauthentication softmac: make non-operational

r8169: only works in 10mbit/half duplex

2006-05-08 Thread Johannes Berg
Hi, New system, new trouble -- I got a system with a r8169 integrated (AOpen MiniPC) and this card only works if I force it to 10mbit half duplex by using media=1 while loading it. Even ethtool appears to have no effect, and under windows the device also is only used in 10mbit mode (only

Re: dBm cutoff at -1dBm is too low

2006-05-08 Thread Pavel Roskin
On Mon, 2006-05-08 at 10:17 -0700, Jean Tourrilhes wrote: But shouldn't you trust the drivers using IW_QUAL_DBM, whether the value is positive or negative? You can't remove the test, making the rest pointeless. Old style driver never used the flags, new style driver that don't report