RE: [PATCH] TCP Veno module for kernel 2.6.16.13

2006-05-26 Thread Fu Cheng Peng, Franklin
-Original Message- From: David Miller [mailto:[EMAIL PROTECTED] Sent: Friday, May 26, 2006 4:24 AM To: #ZHOU BIN# Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [PATCH] TCP Veno module for kernel 2.6.16.13 From: #ZHOU BIN# [EMAIL

Re: [PATCH 0/3] ixgb: driver update to 1.0.104-k4

2006-05-26 Thread Jeff Garzik
Kok, Auke wrote: Hi, This is another resend of patches sent earlier by Jeff Kirsher and completes the resend for 1.0.104-kX. Summary: [1] add performance enhancements to the buffer_info struct [2] implement copybreak [3] increment version to 1.0.104-k4 These changes are available through

Re: ipv6 routing broken in 2.6.17-rc3,4

2006-05-26 Thread Meelis Roos
(To YOSHIFUJI Hideaki: this is about the http://comments.gmane.org/gmane.linux.network/35262 thread) : I guess rt6_select() is returning ip6_null_entry and the caller is finding next best route; e.g. default route. Does this solve your problem? Sorry, typo... The unreachable route works

Re: [PATCH v2] bridge: fix locking and memory leak in br_add_bridge

2006-05-26 Thread Jiri Benc
On Thu, 25 May 2006 09:23:31 -0700, Stephen Hemminger wrote: + unregister_netdevice(dev); + err: rtnl_unlock(); + if (ret) + free_netdev(dev); return ret; I don't think this is correct. netdev_run_todo calls dev-destructor which is set to free_netdev

Re: reminder, 2.6.18 window...

2006-05-26 Thread Andi Kleen
On Wednesday 24 May 2006 10:01, Phil Dibowitz wrote: David Miller wrote: Some time in the next few weeks, it is likely that the 2.6.18 merge window will open up shortly after a 2.6.17 release. So if you have major 2.6.18 submissions planned for the networking, you need to start

Re: reminder, 2.6.18 window...

2006-05-26 Thread Andi Kleen
The current patch is fine if your hardware implements the required atomicity itself. Near all do optionally, but it would make increasing the statistics a magnitude more expensive. Atomic operations don't come cheap on modern systems. And you would need to change the fast path increments

Re: ipv6 routing broken in 2.6.17-rc3,4

2006-05-26 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Fri, 26 May 2006 11:35:53 +0300 (EEST)), Meelis Roos [EMAIL PROTECTED] says: The unreachable route works now but LAN routing still does not work. Locally generated ICMPv6 packets that should go to LAN interface still go to tun6to4. Please try this.

Re: [PATCH 3/4] myri10ge - Driver core

2006-05-26 Thread Ingo Oeser
Hi there, Benjamin Herrenschmidt wrote: On Wed, 2006-05-24 at 01:39 +1000, Anton Blanchard wrote: +#ifdef CONFIG_MTRR + mgp-mtrr = mtrr_add(mgp-iomem_base, mgp-board_span, + MTRR_TYPE_WRCOMB, 1); +#endif ... + mgp-sram = ioremap(mgp-iomem_base,

Re: [PATCH 3/4] myri10ge - Driver core

2006-05-26 Thread Benjamin Herrenschmidt
No proper interface exposed, he'll have to do an #ifdef powerpc here or such and use __ioremap with explicit page attributes. I have a hack to do that automatically for memory covered by prefetchable PCI BARs when mmap'ing from userland but not for kernel ioremap. Stupid question:

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more devices. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jeff Garzik
Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more devices. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- commit

Re: [PATCH 3/4] myri10ge - Driver core

2006-05-26 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: No proper interface exposed, he'll have to do an #ifdef powerpc here or such and use __ioremap with explicit page attributes. I have a hack to do that automatically for memory covered by prefetchable PCI BARs when mmap'ing from userland but not for kernel ioremap.

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for more devices.

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jeff Garzik
Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: bcm43xx avoid pci_find_device Change pci_find_device to safer pci_get_device with support for

Re: ipv6 routing broken in 2.6.17-rc3,4

2006-05-26 Thread Meelis Roos
The unreachable route works now but LAN routing still does not work. Locally generated ICMPv6 packets that should go to LAN interface still go to tun6to4. Please try this. This works for both unreachable and LAN routes, thanks! -- Meelis Roos ([EMAIL PROTECTED]) - To unsubscribe from this

[PATCH] [IPV6] ROUTE: Don't try less preferred routes for on-link routes.

2006-05-26 Thread YOSHIFUJI Hideaki / 吉藤英明
David, In article [EMAIL PROTECTED] (at Fri, 26 May 2006 13:44:59 +0300 (EEST)), Meelis Roos [EMAIL PROTECTED] says: The unreachable route works now but LAN routing still does not work. Locally generated ICMPv6 packets that should go to LAN interface still go to tun6to4. Please try

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): The point is that you don't need to loop over the table, pci_match_one_device() does that for you. The problem is, that there is no such function, I think. If you take a look at pci_dev_present:

Re: [PATCH 3/4] myri10ge - Driver core

2006-05-26 Thread Benjamin Herrenschmidt
On Fri, 2006-05-26 at 06:30 -0400, Jeff Garzik wrote: Benjamin Herrenschmidt wrote: No proper interface exposed, he'll have to do an #ifdef powerpc here or such and use __ioremap with explicit page attributes. I have a hack to do that automatically for memory covered by prefetchable PCI

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jeff Garzik
Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): The point is that you don't need to loop over the table, pci_match_one_device() does that for you. The problem is, that there is no such function, I think. If you take a look at pci_dev_present: The

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): Jiri Slaby wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik napsal(a): The point is that you don't need to loop over the table, pci_match_one_device() does that for you. The problem is, that there is no

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Michael Buesch
On Friday 26 May 2006 12:33, you wrote: --- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c +++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c @@ -2131,6 +2131,13 @@ out: return err; } +#ifdef CONFIG_BCM947XX +static struct pci_device_id bcm43xx_ids[] = { Call it static struct

Re: [PATCH 2/3] pci: bcm43xx avoid pci_find_device

2006-05-26 Thread Jiri Slaby
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Michael Buesch napsal(a): On Friday 26 May 2006 12:33, you wrote: --- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c +++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c @@ -2131,6 +2131,13 @@ out: return err; } +#ifdef CONFIG_BCM947XX

Safe remote kernel install howto (Re: [Bugme-new] [Bug 6613] New: iptables broken on 32-bit PReP (ARCH=ppc))

2006-05-26 Thread Ingo Oeser
Hi Meelis, Unfortunatlety, 2.6.15 does not boot on this machine so I'm locked out remotely at the moment. Here it my paranoid boot setup: 1. Use lilo -R new-kernel, to boot a kernel only once and reboot the default kernel next time. 2. Force reboot on any panic after 10 seconds:

Re: Safe remote kernel install howto (Re: [Bugme-new] [Bug 6613] New: iptables broken on 32-bit PReP (ARCH=ppc))

2006-05-26 Thread Meelis Roos
Unfortunatlety, 2.6.15 does not boot on this machine so I'm locked out remotely at the moment. Here it my paranoid boot setup: Thanks, but it's not much use here, since the machine is a PReP powerpc machine that can boot one kernel from disk (directly loaded from boot partition, no fancy

Re: Safe remote kernel install howto (Re: [Bugme-new] [Bug 6613] New: iptables broken on 32-bit PReP (ARCH=ppc))

2006-05-26 Thread Michael Tokarev
Ingo Oeser wrote: Hi Meelis, Unfortunatlety, 2.6.15 does not boot on this machine so I'm locked out remotely at the moment. Here it my paranoid boot setup: 1. Use lilo -R new-kernel, to boot a kernel only once and reboot the default kernel next time. 2. Force reboot on any

Re: Safe remote kernel install howto (Re: [Bugme-new] [Bug 6613] New: iptables broken on 32-bit PReP (ARCH=ppc))

2006-05-26 Thread Andi Kleen
4. Put sysctl -w kernel.panic_on_oops=1 as early as possible in your boot scripts[1]. You can as well boot with oops=panic -Andi - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Safe remote kernel install howto (Re: [Bugme-new] [Bug 6613] New: iptables broken on 32-bit PReP (ARCH=ppc))

2006-05-26 Thread Ingo Oeser
Hi Andi, Andi Kleen wrote: 4. Put sysctl -w kernel.panic_on_oops=1 as early as possible in your boot scripts[1]. You can as well boot with oops=panic Only on x86_64 as of Linux 2.6.16. But maybe this could be put into kernel/panic.c instead :-) Regards Ingo Oeser - To unsubscribe

Re: [PATCH 6/9] Resending NetXen 1G/10G NIC driver patch

2006-05-26 Thread Pradeep Dalvi
diff -u linux-2.6.16.18/drivers/net/netxen/netxen_nic_init.c linux-2.6.16.18/drivers/net/netxen/netxen_nic_init.c --- linux-2.6.16.18/drivers/net/netxen/netxen_nic_init.c 2006-05-25 02:43:22.0 -0700 +++ linux-2.6.16.18/drivers/net/netxen/netxen_nic_init.c 2006-05-26 04:05:34.0

Re: Fix SO_ORIGINAL_DST information leak (CVE-2006-1343)

2006-05-26 Thread Patrick McHardy
Marcel Holtmann wrote: Hi, the fix for CVE-2006-1343 (information leak) never made it upstream: http://marc.theaimsgroup.com/?l=linux-netdevm=114148078223594w=2 So here it is again against the latest git repository and with the additional line in

Re: [PATCH 1/9] Resending NetXen 1G/10G NIC driver patch

2006-05-26 Thread Pradeep Dalvi
Following are the minor changes for [PATCH 1/9] in accordance with the given suggestions. Regards, pradeep diff -u linux-2.6.16.18/drivers/net/netxen/netxen_nic_ethtool.c linux-2.6.16.18/drivers/net/netxen/netxen_nic_ethtool.c --- linux-2.6.16.18/drivers/net/netxen/netxen_nic_ethtool.c

Re: [PATCH] ip_conntrack_helper_pptp.c: fix sstate/cstate typo

2006-05-26 Thread Patrick McHardy
Alexey Dobriyan wrote: Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- --- a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c +++ b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c @@ -469,8 +469,8 @@ pptp_inbound_pkt(struct sk_buff **pskb, DEBUGP(%s but no session\n,

Re: [PATCH 4/9] Resending NetXen 1G/10G NIC driver patch

2006-05-26 Thread Pradeep Dalvi
diff -u linux-2.6.16.18/drivers/net/netxen/netxen_nic_hw.c linux-2.6.16.18/drivers/net/netxen/netxen_nic_hw.c --- linux-2.6.16.18/drivers/net/netxen/netxen_nic_hw.c 2006-05-25 02:43:22.0 -0700 +++ linux-2.6.16.18/drivers/net/netxen/netxen_nic_hw.c 2006-05-26 04:05:34.0 -0700 @@

Re: [PATCH 2/9] Resending NetXen 1G/10G NIC driver patch

2006-05-26 Thread Pradeep Dalvi
Following are the minor changes for [PATCH 2/9] in accordance with the given suggestions. Regards, pradeep diff -u linux-2.6.16.18/drivers/net/netxen/netxen_nic.h linux-2.6.16.18/drivers/net/netxen/netxen_nic.h --- linux-2.6.16.18/drivers/net/netxen/netxen_nic.h 2006-05-25 02:43:22.0

Re: [PATCH 8/9] Resending NetXen 1G/10G NIC driver patch

2006-05-26 Thread Pradeep Dalvi
diff -u linux-2.6.16.18/drivers/net/netxen/netxen_nic_main.c linux-2.6.16.18/drivers/net/netxen/netxen_nic_main.c --- linux-2.6.16.18/drivers/net/netxen/netxen_nic_main.c 2006-05-25 02:43:22.0 -0700 +++ linux-2.6.16.18/drivers/net/netxen/netxen_nic_main.c 2006-05-26 04:05:34.0

Re: [PATCH 9/9] Resending NetXen 1G/10G NIC driver patch

2006-05-26 Thread Pradeep Dalvi
diff -u linux-2.6.16.18/drivers/net/netxen/netxen_nic_niu.c linux-2.6.16.18/drivers/net/netxen/netxen_nic_niu.c --- linux-2.6.16.18/drivers/net/netxen/netxen_nic_niu.c 2006-05-25 02:43:22.0 -0700 +++ linux-2.6.16.18/drivers/net/netxen/netxen_nic_niu.c 2006-05-26 04:05:34.0 -0700 @@

Re: [PATCH 1/9] Resending NetXen 1G/10G NIC driver patch

2006-05-26 Thread Stephen Hemminger
On Fri, 26 May 2006 14:14:32 + Pradeep Dalvi [EMAIL PROTECTED] wrote: Following are the minor changes for [PATCH 1/9] in accordance with the given suggestions. Regards, pradeep diff -u linux-2.6.16.18/drivers/net/netxen/netxen_nic_ethtool.c

Re: skge driver oops

2006-05-26 Thread Stephen Hemminger
Please give this a try, it rearranges the transmit buffer management, and may avoid issues with partial completions causing SKB reuse. --- skge.orig/drivers/net/skge.c +++ skge/drivers/net/skge.c @@ -2372,7 +2372,8 @@ static int skge_xmit_frame(struct sk_buf

Netfilter and SMP

2006-05-26 Thread Majid Khan
Hi, I am developing a netfilter based application on an SMP (AMD 64;dual core) system (kernel 2.6). One thing that I noticed over a period of time was that most of the network traffic was handled by only one of the processor. Only under high network traffic (roughly 10,000 packet/sec or more)

Re: [RFC 0/4] NetLabel

2006-05-26 Thread Paul Moore
James Morris wrote: On Thu, 25 May 2006, Paul Moore wrote: This patch introduces a new kernel feature designed to support labeled networking protocols such as RIPSO and CIPSO. These protocols are required to interoperate with existing trusted operating systems such as Trusted Solaris. A few

Re: [RFC 0/4] NetLabel

2006-05-26 Thread James Morris
On Fri, 26 May 2006, Paul Moore wrote: There may be an issue with packets generated by the kernel directly and not as a result of an incoming packet but I can't think of a case where this would happen (although I suspect I am just not thinking hard enough). Do you have a scenario in mind?

Re: [PATCH 8/9] Resending NetXen 1G/10G NIC driver patch

2006-05-26 Thread Stephen Hemminger
You might also want to add support for setting dev-perm_addr and using ethtool_op_get_perm_addr() in ethtool_ops - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [RFC 0/4] NetLabel

2006-05-26 Thread Mikel L. Matthews
Paul Moore wrote: James Morris wrote: On Thu, 25 May 2006, Paul Moore wrote: This patch introduces a new kernel feature designed to support labeled networking protocols such as RIPSO and CIPSO. These protocols are required to interoperate with existing trusted operating systems such as

Re: [RFC 0/4] NetLabel

2006-05-26 Thread Paul Moore
Mikel L. Matthews wrote: Paul Moore wrote: James Morris wrote: On Thu, 25 May 2006, Paul Moore wrote: This patch introduces a new kernel feature designed to support labeled networking protocols such as RIPSO and CIPSO. These protocols are required to interoperate with existing trusted

Re: [RFC 0/4] NetLabel

2006-05-26 Thread Mikel L. Matthews
Same issue, I would drop them. Paul Moore wrote: Mikel L. Matthews wrote: Paul Moore wrote: James Morris wrote: Outgoing fragment *should* be labeled correctly assuming the Linux base network stack does the right thing (I haven't tested this yet). The issue we are discussing here is

Re: [RFC 0/4] NetLabel

2006-05-26 Thread Paul Moore
James Morris wrote: On Fri, 26 May 2006, Paul Moore wrote: - Why does this module have a version number? + printk(KERN_INFO NetLabel: Initializing (v%s %s)\n, + NETLBL_VER_STR, NETLBL_VER_DATE); The version number is there primarily to help signal possible differences in the

[PATCH 3/9] ixgb: revert an unwanted fix regarding tso/descriptors

2006-05-26 Thread Kok, Auke
There seemed to be another bug introduced as well as a performance hit with the addtion of the sentinel descriptor workaround. Removal of this workaround appears to prevent the hang. We'll take a risk and remove it, as we had never seen the originally reported bug under linux. Signed-off-by:

[PATCH 4/9] ixgb: allocate only buffersize needed

2006-05-26 Thread Kok, Auke
In order to help correct window size growth, use the MFS register to limit the packet sizes received and allocate only the buffer size necessary Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] index

[PATCH 0/9] ixgb: driver update to 1.0.109-k2

2006-05-26 Thread Kok, Auke
Hi, Here are the ixgb driver updates for 1.0.109-k2. This corresponds with the release of 1.0.109 on e1000.sf.net, and fixes several issues. e1000 update will come soon... Summary: [1] fix smp polling race condition [2] fix interface losing macaddr on ifdn/up [3] revert an unwanted fix

[PATCH 1/9] ixgb: fix smp polling race condition

2006-05-26 Thread Kok, Auke
Moved interrupt masking to before requesting the interrupt from the OS. Moved interrupt enable to after netif_poll_enable. This fixes a racy BUG() where polling would be running on another CPU at the same time that netif_poll_enable would run. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]

[PATCH 2/9] ixgb: fix interface losing macaddr on ifdn/up

2006-05-26 Thread Kok, Auke
user contributed fix for LAA across down/up, from [EMAIL PROTECTED] Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb_main.c |1 + 1 files changed, 1 insertions(+), 0

[PATCH 8/9] ixgb: remove changelog

2006-05-26 Thread Kok, Auke
same as e1000 - remove the changelog from the driver code itself. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb_main.c | 16 1 files changed, 0

[PATCH 6/9] ixgb: remove inlines, allow compiler to choose

2006-05-26 Thread Kok, Auke
deinline a few large functions as to allow the compiler to pick. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb_main.c | 16 1 files changed, 8 insertions(+),

[PATCH 7/9] ixgb: replace netdev-priv with netdev_priv()

2006-05-26 Thread Kok, Auke
fix netdev-priv == netdev_priv(netdev) Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb_ethtool.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 9/9] ixgb: update version, dates

2006-05-26 Thread Kok, Auke
increase the year dates to 2006 and bump the version to 1.0.109-k2 Signed-off-by: Auke Kok [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] --- drivers/net/ixgb/Makefile |2 +- drivers/net/ixgb/ixgb.h |2 +- drivers/net/ixgb/ixgb_ee.c |2 +-

[PATCH 5/9] ixgb: remove lock access in the fast path

2006-05-26 Thread Kok, Auke
This mimics a change made in the e1000 driver that imitates a slick tg3 way of avoiding grabbing the lock around restarting the tx queue. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] Signed-off-by: John Ronciak [EMAIL PROTECTED] ---

[PATCH] network dev.c comment cleanups

2006-05-26 Thread Stephen Hemminger
Noticed that dev_alloc_name() comment was incorrect, and more spellung errors. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- br.orig/net/core/dev.c +++ br/net/core/dev.c @@ -127,7 +127,7 @@ * sure which should go first, but I bet it won't make much *

Re: Netfilter and SMP

2006-05-26 Thread Andi Kleen
Can somebody provide me with some information on how to configure my SMP system so that both processors share the network traffic load. You would need multiple active incoming network interfaces. Linux right now doesn't support load balancing from a single interrupt. Even if it did that would

Re: [RFC 0/4] NetLabel

2006-05-26 Thread James Morris
On Fri, 26 May 2006, Paul Moore wrote: The NetLabel netlink protocol does have a version message which can be used to get the version. My main reason for doing this is not to signal changes to existing messages, i.e. break backward compatability, but to signal to user space applications that

[PATCH] GRE: fixup gre_keymap_lookup() return type

2006-05-26 Thread Alexey Dobriyan
GRE keys are 16-bit wide. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- net/ipv4/netfilter/ip_conntrack_proto_gre.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/net/ipv4/netfilter/ip_conntrack_proto_gre.c +++ b/net/ipv4/netfilter/ip_conntrack_proto_gre.c @@

Re: [PATCH, 2.6.17-rc4-git10] ieee80211softmac_io.c: fix warning defined but not used

2006-05-26 Thread John W. Linville
On Tue, May 23, 2006 at 03:49:40PM +0200, Toralf Förster wrote: Got this compiler warning today and Johannes Berg [EMAIL PROTECTED] wrote: Yeah, known 'bug', we have that code there but never use it. Feel free to submit a patch (to John Linville, CC netdev and softmac-dev) to remove it.

[PATCH] Fixup struct ip_mc_list::multiaddr type

2006-05-26 Thread Alexey Dobriyan
All users except two expect 32-bit big-endian value. One is of -multiaddr = -multiaddr variety. And last one is %08lX. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- include/linux/igmp.h |2 +- net/ipv4/igmp.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

[RFC] new qla3xxx NIC Driver v2.02.00k29 (repost)

2006-05-26 Thread Ron Mercer
Reposted with corrected URL. All, Third submission for the upstream inclusion of the qla3xxx Ethernet driver. This is a complementary network driver for our ISP4XXX parts. There is a concurrent effort underway to get the iSCSI driver (qla4xxx) integrated upstream as well. The following files

Wireless patches to push for 2.6.18?

2006-05-26 Thread John W. Linville
As David M. so recently reminded us, 2.6.17 is likely to be blessed soon. That will open a short merge window for non-fixes to go into 2.6.18. Along w/ the patches currently on the 'upstream' branch, I'd like to see some of the the drivers hanging-out only on the 'master' branch of wireless-2.6

Re: [PATCH 0/9] Resending NetXen 1G/10G NIC driver patch

2006-05-26 Thread Roland Dreier
Amit We'll implement the minor changes rightaway and post an Amit update. We are also thinking about what's the best way to Amit incorporate the data structure changes you have Amit suggested. Will post a reply on that too soon. By the way, my suggestion to the original posting

Refactor Netlink connector?

2006-05-26 Thread James Morris
I've been looking through the kernel for new subsytems which might need LSM hooks, and we've got a proliferation of Netlink abstractions: generic Netlink, nfnetlink, connector and kobject_uevent. I think we should look at consolidating some of these schemes, and if possible, into a unififed

usb wifi: zd1201 cleanups

2006-05-26 Thread Pavel Machek
Hi! I am trying to get zd1201 to work on ARM. It works okay on i386, but not on ARM -- I get no results from iwlist wlan0 scan. Anyway, here are some cleanups. Line of ~280 characters, full of whitespace really got me. Please apply, --- Cleanup coding style and other small stuff in zd1201. No

Re: [PATCH] [IPV6] ROUTE: Don't try less preferred routes for on-link routes.

2006-05-26 Thread David Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Fri, 26 May 2006 20:01:56 +0900 (JST) In article [EMAIL PROTECTED] (at Fri, 26 May 2006 13:44:59 +0300 (EEST)), Meelis Roos [EMAIL PROTECTED] says: The unreachable route works now but LAN routing still does not work. Locally generated

Re: [PATCH] network dev.c comment cleanups

2006-05-26 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 26 May 2006 10:42:48 -0700 Noticed that dev_alloc_name() comment was incorrect, and more spellung errors. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied, thanks Stephen. - To unsubscribe from this list: send the line

Please pull 'upstream-fixes' branch of wireless-2.6

2006-05-26 Thread John W. Linville
The following changes since commit 705af309505681f197f81618440954d10f120dc0: Martin Schwidefsky: s390: fix typo in stop_hz_timer. are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes Randy Dunlap: wavelan:

Re: reminder, 2.6.18 window...

2006-05-26 Thread Rick Jones
Can you ask internally on how openview would handle this? It carriers the major chunk of management tools market so it may provide good insight. I've asked the question in an internal, informal communications channel. No guarantees it will reach any OpenView types, but if it does I'll try

Re: Wireless patches to push for 2.6.18?

2006-05-26 Thread Michael Buesch
On Friday 26 May 2006 21:59, John W. Linville wrote: As David M. so recently reminded us, 2.6.17 is likely to be blessed soon. That will open a short merge window for non-fixes to go into 2.6.18. Along w/ the patches currently on the 'upstream' branch, I'd like to see some of the the drivers

[PATCH 2.6.18 2/3] tg3: Add recovery logic when MMIOs are re-ordered

2006-05-26 Thread Michael Chan
Add recovery logic when we suspect that the system is re-ordering MMIOs. Re-ordered MMIOs to the send mailbox can cause bogus tx completions and hit BUG_ON() in the tx completion path. tg3 already has logic to handle re-ordered MMIOs by flushing the MMIOs that must be strictly ordered (such as

[PATCH 2.6.18 1/3] tg3: Add 5786 PCI ID

2006-05-26 Thread Michael Chan
Add PCI ID for BCM5786 which is a variant of 5787. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 49ad60b..3de5a62 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -229,6 +229,8 @@ static struct pci_device_id tg3_pci_tbl[

Re: [PATCH 2.6.18 1/3] tg3: Add 5786 PCI ID

2006-05-26 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 26 May 2006 15:55:23 -0700 Add PCI ID for BCM5786 which is a variant of 5787. Signed-off-by: Michael Chan [EMAIL PROTECTED] Simple enough, applied to net-2.6.18 Thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH 2.6.18 2/3] tg3: Add recovery logic when MMIOs are re-ordered

2006-05-26 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 26 May 2006 16:03:07 -0700 Add recovery logic when we suspect that the system is re-ordering MMIOs. Re-ordered MMIOs to the send mailbox can cause bogus tx completions and hit BUG_ON() in the tx completion path. ... Signed-off-by: Michael Chan

Re: [PATCH 2.6.18 3/3] tg3: update version and reldate

2006-05-26 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 26 May 2006 16:03:16 -0700 Update version to 3.59. Signed-off-by: Michael Chan [EMAIL PROTECTED] Also applied, thanks a lot Michael. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: [PATCH 0/9] ixgb: driver update to 1.0.109-k2

2006-05-26 Thread Jeff Garzik
Kok, Auke wrote: Hi, Here are the ixgb driver updates for 1.0.109-k2. This corresponds with the release of 1.0.109 on e1000.sf.net, and fixes several issues. e1000 update will come soon... Summary: [1] fix smp polling race condition [2] fix interface losing macaddr on ifdn/up [3] revert an

Re: Please pull 'upstream-fixes' branch of wireless-2.6

2006-05-26 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 705af309505681f197f81618440954d10f120dc0: Martin Schwidefsky: s390: fix typo in stop_hz_timer. are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes

Re: e1000: add WoL fix for 2.6.17rc

2006-05-26 Thread Jeff Garzik
Auke Kok wrote: Jeff, Please queue the 'e1000: add shutdown handler back for WoL' for 2.6.17rc's. Since this fix is already committed to jgarzik/netdev-2.6#upstream, you can cherrypick it into #upstream-fixes: $ git-cherry-pick c653e6351e371b33b29871e5eedf610ffb3be037 perfect, done,

Re: spidernet: replace whitespaces by tabs

2006-05-26 Thread Jeff Garzik
Jens Osterkamp wrote: From: Jens Osterkamp [EMAIL PROTECTED] The original patch was using whitespaces instead of tabs. Signed-off-by: Jens Osterkamp [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [PATCH 1/2] pci_ids: add new device ids

2006-05-26 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch adds new device ids for MCP61 and MCP65 chips. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] applied. For the future, make subject line more descriptive. Add new NVIDIA device IDs would have been better. Jeff - To unsubscribe from this list: send

Re: [PATCH 2/2] forcedeth: add support for new device ids

2006-05-26 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch adds support for the new chips MCP61 and MCP65. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] ACK, but did not apply due to rejection of configuration patch - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH] r8169: add new PCI ID

2006-05-26 Thread Jeff Garzik
Yoichi Yuasa wrote: Hi, This patch add new PCI ID for r8169 driver. RTL8110SBL has this PCI ID. applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] s390: minor fix in cu3088

2006-05-26 Thread Jeff Garzik
Frank Pavlic wrote: Hi Jeff, please apply following 5 patches. Thanks ... Frank From: Cornelia Huck [EMAIL PROTECTED] In case of a parse error for the cu3088 group attribute, return -EINVAL instead of count. Signed-off-by: Frank Pavlic [EMAIL PROTECTED] applied patches 1-3 of 5 - To

Re: [PATCH 4/5] s390: lcs driver bug fixes and improvements [1/2]

2006-05-26 Thread Jeff Garzik
Frank Pavlic wrote: From: Klaus Wacker [EMAIL PROTECTED] Several problems occured with lcs device driver: - device not operational anymore after cable pull/plug-in. - unpredictable results occured, e.g. kernel panic using cards of type QD8F. -

Re: [PATCH] via-velocity: allow MTU size less than 1500 bytes

2006-05-26 Thread Jeff Garzik
Jay Cliburn wrote: Change the minimum allowable MTU size from 1500 bytes to 64 bytes. Signed-off-by: Jay Cliburn [EMAIL PROTECTED] --- linux-2.6.16.x86_64/drivers/net/via-velocity.h.orig 2006-05-23 07:42:24.0 -0500 +++ linux-2.6.16.x86_64/drivers/net/via-velocity.h 2006-05-23

Re: [PATCH v2] bridge: fix locking and memory leak in br_add_bridge

2006-05-26 Thread David Miller
From: Jiri Benc [EMAIL PROTECTED] Date: Fri, 26 May 2006 11:08:06 +0200 On Thu, 25 May 2006 09:23:31 -0700, Stephen Hemminger wrote: + unregister_netdevice(dev); + err: rtnl_unlock(); + if (ret) + free_netdev(dev); return ret; I don't think this is