Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Brian F. G. Bidulock
Chase, On Tue, 13 Jun 2006, Chase Venters wrote: I don't think that it is fair to say that an unstable API/ABI, in of itself, provides an incentive to open an existing proprietary driver. Sure it does, depending on your perspective and what you're willing to consider. The lack of a

[PATCH 2/2] 8139cp: add ethtool eeprom support

2006-06-14 Thread Philip Craig
Implement the ethtool eeprom operations for the 8139cp driver. Tested on x86 and big-endian ARM. Signed-off-by: Philip Craig [EMAIL PROTECTED] Index: linux-2.6.17-rc6/drivers/net/8139cp.c === ---

[PATCH 1/2] 8139cp: fix eeprom read command length

2006-06-14 Thread Philip Craig
The read command for the 93C46/93C56 EEPROMS should be 3 bits plus the address. This doesn't appear to affect the operation of the read command, but similar errors for write commands do cause failures. Signed-off-by: Philip Craig [EMAIL PROTECTED] Index: linux-2.6.17-rc6/drivers/net/8139cp.c

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Chase Venters
On Wednesday 14 June 2006 01:06, Brian F. G. Bidulock wrote: The interface currently under discussion is ultimately derived from the BSD socket-protocol interface, and IMHO should be EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL, if only because using _GPL serves no purpose here and can be

Re: 2.6.17: networking bug??

2006-06-14 Thread Daniel Drake
Mark Lord wrote: Further to this, the current behaviour is badly unpredictable. A machine could be working perfectly, not (noticeably) affected by this bug. And then the user adds another stick of RAM to it. This bug already existed in 2.6.16 to a certain extent: you were losing out on a

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Brian F. G. Bidulock
Chase, On Wed, 14 Jun 2006, Chase Venters wrote: One point I remember coming up in the discussion was that the EXPORT_SYMBOL()/EXPORT_SYMBOL_GPL() split was a compromise of sorts. Interfaces that were needed to support users would reasonably be placed under EXPORT_SYMBOL(). By contrast,

[PATCH 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)

2006-06-14 Thread Jesper Dangaard Brouer
The Linux traffic's control engine inaccurately calculates transmission times for packets sent over ADSL links. For some packet sizes the error rises to over 50%. This occurs because ADSL uses ATM as its link layer transport, and ATM transmits packets in fixed sized 53 byte cells. This changes

[PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)

2006-06-14 Thread Jesper Dangaard Brouer
The Linux traffic's control engine inaccurately calculates transmission times for packets sent over ADSL links. For some packet sizes the error rises to over 50%. This occurs because ADSL uses ATM as its link layer transport, and ATM transmits packets in fixed sized 53 byte cells. This changes

[PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-14 Thread Jesper Dangaard Brouer
The Linux traffic's control engine inaccurately calculates transmission times for packets sent over ADSL links. For some packet sizes the error rises to over 50%. This occurs because ADSL uses ATM as its link layer transport, and ATM transmits packets in fixed sized 53 byte cells. The

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Alan Cox
Ar Mer, 2006-06-14 am 00:07 -0600, ysgrifennodd Brian F. G. Bidulock: I think that a policy that intentionally makes it hard for proprietary modules to be developed defeats the purpose of ultimate opening and merging. It isn't policy its called copyright law. The interface currently under

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Theodore Tso
On Tue, Jun 13, 2006 at 07:53:19PM -0500, Chase Venters wrote: It is the lack of an ABI that is most frustrating to these users. And the presence of an ABI would be _very_ frustrating to core developers. Not only would these people suffer, everyone would -- developer time would be wasted

Re: [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)

2006-06-14 Thread Alan Cox
Ar Mer, 2006-06-14 am 11:40 +0200, ysgrifennodd Jesper Dangaard Brouer: option to calculate traffic transmission times (rate table) over all ATM links, including ADSL, with perfect accuracy. Pedant Only if the lowest level is encoded in a time linear manner. If you are using NRZ, NRZI etc at

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Brian F. G. Bidulock
Alan, On Wed, 14 Jun 2006, Alan Cox wrote: It isn't policy its called copyright law. I know that I said I'd shut up, but I missed in TRIPS where it said that symbols must be EXPORT_SYMBOL_GPL... Could you point that out? (Just kidding.) You don't seem to understand copyright law either. The

Re: Remove Prism II support from Orinoco

2006-06-14 Thread Jiri Benc
On Tue, 13 Jun 2006 07:30:56 +0300, Faidon Liambotis wrote: Unfortunately, that workaround doesn't work so well when you want to have the ability to plug real orinoco (hermes) cards to your computer... In other words and unless I'm missing something, there isn't currently a way to have a

Re: Refactor Netlink connector?

2006-06-14 Thread jamal
So whats the resolution on this? I actually have some cycles this coming weekend that i was hopping to spend updating the doc instead. cheers, jamal On Thu, 2006-01-06 at 10:24 -0400, James Morris wrote: On Thu, 1 Jun 2006, Thomas Graf wrote: It shouldn't be hard to split what is

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-14 Thread jamal
I have taken linux-kernel off the list. Russell's site is inaccessible to me (I actually think this is related to some DNS issues i may be having) and your masters is too long to spend 2 minutes and glean it; so heres a question or two for you: - Have you tried to do a long-lived session such

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-14 Thread Jesper Dangaard Brouer
On Wed, 2006-06-14 at 08:06 -0400, jamal wrote: Russell's site is inaccessible to me (I actually think this is related to some DNS issues i may be having) Strange, I have access to Russell's site. Maybe its his redirect feature that confuses your browser, try:

Re: netif_tx_disable and lockless TX

2006-06-14 Thread jamal
On Wed, 2006-31-05 at 19:52 +0200, Robert Olsson wrote: jamal writes: Latency-wise: TX completion interrupt provides the best latency. Processing in the poll() -aka softirq- was almost close to the hardirq variant. So if you can make things run in a softirq such as transmit one,

Problems with xfrm (IPSec) and multicast

2006-06-14 Thread Roar Bjørgum Rotvik
Hi, I have configured two Linux PC's to use IPSec to encrypt some mcast traffic, using ip xfrm. Each PC has two network cards, one connected to a LAN (unencrypted side, also called red side) and one connected to the other node (encrypted side, also called black side). Currently the setup uses

Re: driver for pptp

2006-06-14 Thread Harald Welte
On Sat, Jun 03, 2006 at 11:06:19AM +0400, [EMAIL PROTECTED] wrote: I have developed the driver for Point-to-Point Tunneling Protocol (PPTP). great news. something that I always thought of a nice-to-have. I have published the project on http://accel-pptp.sourceforge.net/ Please don't expect

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-14 Thread Kyle McMartin
On Tue, Jun 13, 2006 at 10:44:12PM -0600, Grant Grundler wrote: On Tue, Jun 13, 2006 at 08:33:22PM -0400, Jeff Garzik wrote: Grant Grundler wrote: o tulip_stop_rxtx() has to be called _after_ free_irq(). ie. v2 patch didn't fix the original race condition and when under test, dies

Offering presents for more routing tables!

2006-06-14 Thread Ben Greear
I've asked for this feature several years ago and evidently it is not trivial to increase the number of routing tables. But, perhaps someone now has time inclination? I would like to have more (a few thousand) routing tables available in the kernel so that I can use a routing table for each of

Re: [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)

2006-06-14 Thread Jesper Dangaard Brouer
On Wed, 2006-06-14 at 11:57 +0100, Alan Cox wrote: Ar Mer, 2006-06-14 am 11:40 +0200, ysgrifennodd Jesper Dangaard Brouer: option to calculate traffic transmission times (rate table) over all ATM links, including ADSL, with perfect accuracy. The other problem I see with this code is it is

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Harald Welte
On Tue, Jun 13, 2006 at 02:12:41PM -0700, Daniel Phillips wrote: This has the makings of a nice stable internal kernel api. Why do we want to provide this nice stable internal api to proprietary modules? because there is IMHO legally nothing we can do about it anyway. Use of an

Re: http://bugzilla.kernel.org/show_bug.cgi?id=6197

2006-06-14 Thread Patrick McHardy
Michael Tokarev wrote: Patrick McHardy wrote: [] He patched his kernel with the IMQ device, which is known to cause all kinds of weird problems. Wich problems? Known to whom? Known to me (who wrote the original implementation of the current IMQ device) and numerous people who were hit

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-14 Thread Grant Grundler
On Wed, Jun 14, 2006 at 09:05:06AM -0400, Kyle McMartin wrote: I think the correct sequence would be: reset tulip interrupt mask flush posted write synchronize irq /* make sure we got 'em all */ tulip_stop_rxtx /* turn off dma */

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-14 Thread Jeff Garzik
Grant Grundler wrote: On Tue, Jun 13, 2006 at 08:33:22PM -0400, Jeff Garzik wrote: Grant Grundler wrote: o tulip_stop_rxtx() has to be called _after_ free_irq(). ie. v2 patch didn't fix the original race condition and when under test, dies about as fast as the original code. You made the

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-14 Thread Jesper Dangaard Brouer
On Wed, 2006-06-14 at 10:27 -0400, Phillip Susi wrote: Jesper Dangaard Brouer wrote: The Linux traffic's control engine inaccurately calculates transmission times for packets sent over ADSL links. For some packet sizes the error rises to over 50%. This occurs because ADSL uses ATM as

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-14 Thread Phillip Susi
Jesper Dangaard Brouer wrote: The Linux traffic's control engine inaccurately calculates transmission times for packets sent over ADSL links. For some packet sizes the error rises to over 50%. This occurs because ADSL uses ATM as its link layer transport, and ATM transmits packets in fixed

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Erik Mouw
On Wed, Jun 14, 2006 at 03:30:22PM +0200, Harald Welte wrote: On Tue, Jun 13, 2006 at 02:12:41PM -0700, Daniel Phillips wrote: This has the makings of a nice stable internal kernel api. Why do we want to provide this nice stable internal api to proprietary modules? because there is

Re: Refactor Netlink connector?

2006-06-14 Thread James Morris
On Wed, 14 Jun 2006, jamal wrote: So whats the resolution on this? I actually have some cycles this coming weekend that i was hopping to spend updating the doc instead. Haven't had a chance to look at it since. -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Harald Welte
On Wed, Jun 14, 2006 at 04:29:04PM +0200, Erik Mouw wrote: On Wed, Jun 14, 2006 at 03:30:22PM +0200, Harald Welte wrote: On Tue, Jun 13, 2006 at 02:12:41PM -0700, Daniel Phillips wrote: This has the makings of a nice stable internal kernel api. Why do we want to provide this nice

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-14 Thread Andy Furniss
jamal wrote: I have taken linux-kernel off the list. Russell's site is inaccessible to me (I actually think this is related to some DNS issues i may be having) and your masters is too long to spend 2 minutes and glean it; so heres a question or two for you: - Have you tried to do a long-lived

[PATCH] bcm43xx: use softmac-suggested TX rate

2006-06-14 Thread Michael Buesch
Hi John, Sorry, took a little bit longer than expected, but here it is. :) Please queue for 2.6.18. -- From: Daniel Drake [EMAIL PROTECTED] Use Softmac-suggested TX ratecode: ieee80211softmac_suggest_txrate() Signed-off-by: Daniel Drake [EMAIL PROTECTED] Signed-off-by: Michael Buesch [EMAIL

[PATCH 6/5] rt2x00: per-queue TX flow control

2006-06-14 Thread Jiri Benc
This is a patch for rt2x00 driver to do TX flow control. It is compile-tested only. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- drivers/net/wireless/d80211/rt2x00/rt2400pci.c | 26 ++--- drivers/net/wireless/d80211/rt2x00/rt2500pci.c | 26 ++---

Re: tcp_slow_start_after_idle

2006-06-14 Thread Rick Jones
+tcp_slow_start_after_idle - BOOLEAN + If set, provide RFC2861 behavior and time out the congestion + window after an idle period. An idle period is defined at + the current RTO. If unset, the congestion window will not + be timed out after an idle period. +

Re: tcp_slow_start_after_idle

2006-06-14 Thread Zach Brown
David Miller wrote: Bringing back up this old topic: http://marc.theaimsgroup.com/?l=linux-netdevm=114564962420171w=2 I've decided to add this tunable to the net-2.6.18 tree, patch below. Nice, thanks for the heads-up. I'll pass the notice on to the guys who were asking about this

Interrupt handling on SMP system

2006-06-14 Thread Majid Khan
Hi all, I had a few question regarding how interrupt handling work on linux within a SMP systems. 1. Which processor gets the interrupt when a new packet arrives? Is there any policy mechanism which can guide the interrupt to the idle processor etc? Do the processors share an interrupt line and

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Daniel Phillips
Hi Harald, You wrote: On Tue, Jun 13, 2006 at 02:12:41PM -0700, I wrote: This has the makings of a nice stable internal kernel api. Why do we want to provide this nice stable internal api to proprietary modules? because there is IMHO legally nothing we can do about it anyway. Speaking as

Re: [openib-general] [PATCH v2 1/2] iWARP Connection Manager.

2006-06-14 Thread Steve Wise
On Tue, 2006-06-13 at 16:46 -0500, Steve Wise wrote: On Tue, 2006-06-13 at 14:36 -0700, Sean Hefty wrote: Er...no. It will lose this event. Depending on the event...the carnage varies. We'll take a look at this. This behavior is consistent with the Infiniband CM (see

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Brian F. G. Bidulock
Daniel, On Wed, 14 Jun 2006, Daniel Phillips wrote: Speaking as a former member of a grey market binary module vendor that came in from the cold I can assure you that the distinction between EXPORT and EXPORT_GPL _is_ meaningful. That tainted flag makes it extremely difficult to do deals

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-14 Thread Grant Grundler
On Wed, Jun 14, 2006 at 11:03:48AM -0400, Jeff Garzik wrote: Grant Grundler wrote: Switching the order to be: tulip_stop_rxtx(tp);/* Stop DMA */ free_irq (dev-irq, dev); /* no more races after this */ still leaves us open to IRQs being delivered _after_

Re: [PATCH 6/5] rt2x00: per-queue TX flow control

2006-06-14 Thread Ivo van Doorn
Hi, On Wednesday 14 June 2006 18:36, Jiri Benc wrote: This is a patch for rt2x00 driver to do TX flow control. It is compile-tested only. Signed-off-by: Jiri Benc [EMAIL PROTECTED] I'll put my comments for the rt2400pci driver only, since the same changes are made for each rt2x00 driver.

Re: Remove Prism II support from Orinoco

2006-06-14 Thread Mike Kershaw
On Tue, Jun 13, 2006 at 09:24:49PM +0300, Jar wrote: It always loads itself with or without blacklist. That's why I have to do 'rm -f orinoco*.* depmod -a' when the new kernel arrives. Seems that users are directed to use unsecure orinoco (wep) driver rather than secure hostap

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-14 Thread Jeff Garzik
Grant Grundler wrote: On Wed, Jun 14, 2006 at 11:03:48AM -0400, Jeff Garzik wrote: Grant Grundler wrote: Switching the order to be: tulip_stop_rxtx(tp);/* Stop DMA */ free_irq (dev-irq, dev); /* no more races after this */ still leaves us open to IRQs being

[patch] ipv4: fix lock usage in udp_ioctl

2006-06-14 Thread Heiko Carstens
From: Heiko Carstens [EMAIL PROTECTED] Fix lock usage in udp_ioctl(). Signed-off-by: Heiko Carstens [EMAIL PROTECTED] --- udp_poll() seems to have the same problem, right? As reported by the lock validator: [ BUG: illegal lock usage! ]

RE: [openib-general] [PATCH v2 1/2] iWARP Connection Manager.

2006-06-14 Thread Caitlin Bestler
[EMAIL PROTECTED] wrote: On Tue, 2006-06-13 at 16:46 -0500, Steve Wise wrote: On Tue, 2006-06-13 at 14:36 -0700, Sean Hefty wrote: Er...no. It will lose this event. Depending on the event...the carnage varies. We'll take a look at this. This behavior is consistent with the Infiniband CM

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-14 Thread Neil Horman
On Mon, Jun 12, 2006 at 02:06:00PM -0400, Neil Horman wrote: On Mon, Jun 12, 2006 at 09:42:14AM -0700, Mitch Williams wrote: On Sun, 2006-06-11 at 17:13 -0700, Neil Horman wrote: Any further thoughts on this guys? I still think my last solution solves all of the netpoll problems, and

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-14 Thread Francois Romieu
Grant Grundler [EMAIL PROTECTED] : [...] I'm not keen on adding more code to tulip_interrupt() routine for something that rarely happens (compared to IRQs) and is handled outside the interrupt routine. I'm pretty sure stopping interrupts before stopping DMA is sufficient. Can you show an

Re: [RFC/PATCH 1/2] in-kernel sockets API

2006-06-14 Thread Sridhar Samudrala
On Wed, 2006-06-14 at 10:48 -0700, Daniel Phillips wrote: Did we settle the question of whether these particular exports should be EXPORT_SYMBOL_GPL? When i submitted this patch, i didn't really think about the different ways to export these symbols. I simply used the EXPORT_SYMBOL() that is

Re: [patch] ipv4: fix lock usage in udp_ioctl

2006-06-14 Thread David Miller
From: Heiko Carstens [EMAIL PROTECTED] Date: Wed, 14 Jun 2006 21:43:05 +0200 From: Heiko Carstens [EMAIL PROTECTED] Fix lock usage in udp_ioctl(). Signed-off-by: Heiko Carstens [EMAIL PROTECTED] More likely the qeth driver shouldn't call into the socket code in hardware interrupt context.

type of sadb_x_kmprivate_reserved in pfkeyv2.h

2006-06-14 Thread Tushar Gohad
Hi David and folks, In include/linux/pfkeyv2.h, is the type 'u_int32_t' for sadb_x_kmprivate_reserved intentional or just an error while bringing in the PF_KEY IPsec extensions from KAME? struct sadb_x_kmprivate { uint16_tsadb_x_kmprivate_len; uint16_t

[Ubuntu PATCH] IRDA: Add some IBM think pads

2006-06-14 Thread Randy Dunlap
From: Ben Collins [EMAIL PROTECTED] [UBUNTU:nsc-ircc] Add some IBM think pads Add Thinkpad T60/X60/Z60/T43/R52 Infrared driver support. http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=7b8d2713435a9fb69719a282ba75e117f3f76a5b Signed-off-by: Ben Collins

[Ubuntu PATCH] Make tulip driver not handle Davicom NICs

2006-06-14 Thread Randy Dunlap
Make tulip driver not handle Davicom NICs, let dmfe take over Reference: https://launchpad.net/bugs/48287 Source URL of Patch: http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=1804482911a71bee9114cae1c2079507a38e9e7f ---

[Ubuntu PATCH] forcedeth: Let the driver work when no PHY is found

2006-06-14 Thread Randy Dunlap
From: Ben Collins [EMAIL PROTECTED] [UBUNTU:forcedeth] Let the driver work when no PHY is found This matches breezy behavior. Reference: https://launchpad.net/products/launchpad/+bug/45257

Re: tcp_slow_start_after_idle

2006-06-14 Thread David Miller
From: Zach Brown [EMAIL PROTECTED] Date: Wed, 14 Jun 2006 10:09:52 -0700 Nice, thanks for the heads-up. I'll pass the notice on to the guys who were asking about this in that thread. Which Wall Street brokerage firm was it? :-) That's basically who wants this stuff, people doing financial

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-14 Thread Grant Grundler
On Wed, Jun 14, 2006 at 10:47:20PM +0200, Francois Romieu wrote: Grant Grundler [EMAIL PROTECTED] : [...] I'm not keen on adding more code to tulip_interrupt() routine for something that rarely happens (compared to IRQs) and is handled outside the interrupt routine. I'm pretty sure

[Ubuntu PATCH] Broadcom wireless patch, PCIE/Mactel support

2006-06-14 Thread Randy Dunlap
From: Matthew Garrett [EMAIL PROTECTED] Broadcom wireless patch, PCIE/Mactel support http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=1373a8487e911b5ee204f4422ddea00929c8a4cc This patch adds support for PCIE cores to the bcm43xx driver. This is needed for

Re: tcp_slow_start_after_idle

2006-06-14 Thread David Miller
From: Rick Jones [EMAIL PROTECTED] Date: Wed, 14 Jun 2006 09:46:58 -0700 Also, does the congestion window time out or does it decay? The modification made to the cwnd is indeed a decay function, but the event is a time out, and it is also termed a restart in other writings and contexts. I

Re: [patch] ipv4: fix lock usage in udp_ioctl

2006-06-14 Thread Herbert Xu
Heiko Carstens [EMAIL PROTECTED] wrote: As reported by the lock validator: [ BUG: illegal lock usage! ] illegal {in-hardirq-W} - {hardirq-on-W} usage. syslogd/739 [HC0[0]:SC0[1]:HE1:SE0] takes: (list-lock){++..}, at: [002e36d6]

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-14 Thread Mitch Williams
On Wed, 14 Jun 2006, Neil Horman wrote: Hey, as promised, I've done some rudimentary performance benchmarking on various ways that we have talked about to solve this problem. As I previously mentioned We see the same results here, Neil. However, we've got a much less invasive patch

Re: [PATCH 2/2] NET: Accurate packet scheduling for ATM/ADSL (userspace)

2006-06-14 Thread Russell Stuart
On Wed, 2006-06-14 at 11:57 +0100, Alan Cox wrote: The other problem I see with this code is it is very tightly tied to ATM cell sizes, not to solving the generic question of packetisation. Others have made this point also. I can't speak for Jesper, but I did consider making it generic. The

Re: [PATCH] Make in-kernel hostap less annoying

2006-06-14 Thread Jouni Malinen
On Mon, Jun 12, 2006 at 03:13:02PM -0400, Kyle McMartin wrote: Most user don't want their kern.log/dmesg filled with debugging gibberish, and could turn it on if prompted. ( Example: wifi0: TXEXC - status=0x0004 ([Discon]) tx_control=000c retry_count=0 tx_rate=0 fc=0x0108 (Data::0 ToDS)

[patch] e100 statistic value rx_bytes error

2006-06-14 Thread Wei Dong
Hi All: When I test linux kernel(2.6.9-16), I found that maybe there is a bug in e100 driver. See function e100_rx_indicate() at line 1847: nic-net_stats.rx_bytes += actual_size; Here, actual_size is the actual size of an ethernent frame sans FCS.And the e100 driver gets it from skb.

Re: [patch] e100 statistic value rx_bytes error

2006-06-14 Thread Auke Kok
Wei Dong wrote: Hi All: When I test linux kernel(2.6.9-16), I found that maybe there is a bug in e100 driver. See function e100_rx_indicate() at line 1847: nic-net_stats.rx_bytes += actual_size; Here, actual_size is the actual size of an ethernent frame sans FCS.And the e100 driver

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-14 Thread Pavel Roskin
Hello, John! On Mon, 2006-06-12 at 11:24 -0400, John W. Linville wrote: On Mon, Jun 12, 2006 at 01:49:54AM +0300, Faidon Liambotis wrote: Having two drivers supporting the same set of hardware seems pretty pointless to me. Plus, it confuses hotplugging/automatic detection. This subject

Re: [PATCH 2.6.17-rc6] Remove Prism II support from Orinoco

2006-06-14 Thread Pavel Roskin
On Mon, 2006-06-12 at 17:10 -0700, Jesse Brandeburg wrote: my problem is that for my prism 2 adapter both drivers are loaded at which point neither of them works. I'm running FC5, and i have to keep removing the orinoco*.ko files to keep them from loading, so I'm all for this patch. I

Re: [patch] ipv4: fix lock usage in udp_ioctl

2006-06-14 Thread Ingo Molnar
* Herbert Xu [EMAIL PROTECTED] wrote: This is bogus. These two locks belong to two different queues and they never intersect. yeah - qeth does its own skb-queue management here, and it's done in an irq-safe manner. Heiko, in qeth_main.c, could you do something like: + static struct