Re: [PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-21 Thread Ben Greear
Kok, Auke wrote: CRC stripping is breaking SMBUS-connected BMC's. We disable this feature to make it work. This fixes related bugs regarding SOL. Shouldn't you also have to subtract 4 bytes when setting the skb len in the receive logic? Perhaps when setting the rx-bytes counter as well? Ben

[PATCH 15/21] e1000: check return value of _get_speed_and_duplex

2006-06-21 Thread Kok, Auke
We were not checking the return value of get_speed_and_duplex properly, whih may contain an error value. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletion

[PATCH 20/21] e1000: add ich8lan device ID's

2006-06-21 Thread Kok, Auke
Add the device ID's of the supported ICH8 LAN devices. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c

Re: Suspending 802.11 drivers

2006-06-21 Thread Luis R. Rodriguez
On 6/21/06, Michael Buesch <[EMAIL PROTECTED]> wrote: On Wednesday 21 June 2006 17:08, Luis R. Rodriguez wrote: > On 6/16/06, Stefan Rompf <[EMAIL PROTECTED]> wrote: > > Am Donnerstag 15 Juni 2006 21:58 schrieb Michael Buesch: > > > > I think the most important question is how a suspend/resume ac

[PATCH 19/21] e1000: allow user to disable ich8 lock loss workaround

2006-06-21 Thread Kok, Auke
The workaround for the ich8 lock loss problem is only needed for a very small amount of systems. This adds an option for the user to disable the workaround. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_param.c | 21

[PATCH 14/21] e1000: M88 PHY workaround

2006-06-21 Thread Kok, Auke
M88 rev 2 PHY needs a longer downshift to function properly. This adds a much longer downshift counter for this specific device. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.c | 46 ++

[PATCH 16/21] e1000: disable ERT

2006-06-21 Thread Kok, Auke
Hardware is reported to have problems with ERT. We disable it for all hardware to make sure we are not seeing unexplainable user problems. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |3 --- 1 files chang

[PATCH 21/21] e1000: increase version to 7.1.9-k2

2006-06-21 Thread Kok, Auke
Increment the version to 7.1.9-k2 Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000

[PATCH 13/21] e1000: add E1000_BIG_ENDIAN symbol

2006-06-21 Thread Kok, Auke
This adds a private symbol to signify endianess in our driver. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.h|2 +- drivers/net/e1000/e1000_osdep.h |3 +++ 2 files changed, 4 insertions(+), 1 deletions

[PATCH 10/21] e1000: force register write flushes to circumvent broken platforms

2006-06-21 Thread Kok, Auke
A certain AMD64 bridge (8132) has an option to turn on write combining which breaks our adapter. To circumvent this we need to flush every write. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_hw.c | 24 +++

[PATCH 12/21] e1000: fix adapter led blinking inconsistency

2006-06-21 Thread Kok, Auke
Several e1000 adapters were not blinking correctly or inconsistently. This patch cleans this up and makes them all behave the same as far as possible. Signed-off-by: Jeff Kirsher <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_ethtool.c | 15 +--

[PATCH 02/21] e1000: rework driver hardware reset locking

2006-06-21 Thread Kok, Auke
After studying the driver mac reset code it was found that there were multiple race conditions possible to reset the unit twice or bring it e1000_up() double. This fixes all occurences where the driver needs to reset the mac. We also remove irq requesting/releasing into _open and _close so that w

[PATCH 07/21] e1000: change printk into DPRINTK

2006-06-21 Thread Kok, Auke
Changing a printk message to make clear that this message is originating from e1000. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drive

[PATCH 08/21] e1000: recycle skb

2006-06-21 Thread Kok, Auke
Recycle an skb to improve performance a bit. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net

[PATCH 05/21] e1000: small performance tweak by removing double code

2006-06-21 Thread Kok, Auke
buffer_info is already filled at the end of this while() loop. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/e1000/e1000_main

[PATCH 01/21] e1000: fix loopback ethtool test

2006-06-21 Thread Kok, Auke
Ethtool was reporting that loopback failed randomly on esb2 systems. Upon study it was found that the phy manual was changed with respect to the loopback mode bits. The new value fixes it. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- driver

[PATCH 00/21] e1000: driver update to 7.1.9-k2

2006-06-21 Thread Kok, Auke
Hi, A large number of e1000 patches this update, including the release of the integrated NIC in the ICH8 motherboard chipset, which has been officially released into the public. Also known as i965, the lan chipset on this motherboard is fully supported by this driver. The motherboard actually co

[PATCH 03/21] e1000: Make PHY powerup/down a function

2006-06-21 Thread Kok, Auke
In relation to the irq work done earlier we also move the PHY powerup and powerdown functions into separate functions and move the calls to _close and _open, making the PHY stay in it's power state as long as the device is _up. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Au

[PATCH 06/21] e1000: add smart power down code

2006-06-21 Thread Kok, Auke
Smart Power Down is a power saving feature in newer e1000 hardware. We disable it because it causes time to link to be long, but make it a user choice. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000.h |1 + d

[PATCH 09/21] e1000: rework module param code with uninitialized values

2006-06-21 Thread Kok, Auke
We can take uninitialized values into account which minimizes code and allows us to simplify the parameter checking code greatly. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_param.c | 167 ++

[PATCH 11/21] e1000: disable CRC stripping workaround

2006-06-21 Thread Kok, Auke
CRC stripping is breaking SMBUS-connected BMC's. We disable this feature to make it work. This fixes related bugs regarding SOL. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |7 ++- 1 files changed, 6

[PATCH 04/21] e1000: fix CONFIG_PM blocks

2006-06-21 Thread Kok, Auke
e1000_suspend is called even when !CONFIG_PM. The non-PM code inside of it is properly #ifdef'd. This fixes the compiler warnings when !CONFIG_PM. Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]> Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |6 -- 1

Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-21 Thread Andrew Morton
On Wed, 21 Jun 2006 14:24:27 -0700 "Ron Mercer" <[EMAIL PROTECTED]> wrote: > Please add the qla3xxx NIC driver to the next netdev-2.6 GIT tree. - We won't be able to include this withot a Signed-off-by: as per section 11 of Documentation/SubmittingPatches. - The driver does a lot of: static

Re: Locking validator output on DCCP

2006-06-21 Thread Ian McDonald
On 6/21/06, Ingo Molnar <[EMAIL PROTECTED]> wrote: * Herbert Xu <[EMAIL PROTECTED]> wrote: > > Can someone tell me whether I am correct in my thinking or not? If I > > am then I will work out how to tell the lock validator not to worry > > about it. > > I agree, this looks bogus. Ingo, could y

Re: Locking validator output on DCCP

2006-06-21 Thread Ian McDonald
On 6/21/06, Arjan van de Ven <[EMAIL PROTECTED]> wrote: On Wed, 2006-06-21 at 10:34 +1000, Herbert Xu wrote: > > As I read this it is not a recursive lock as sk_clone is occurring > > second and is actually creating a new socket so they are trying to > > lock on different sockets. > > > > Can som

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-06-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 21 Jun 2006 23:58:56 -0400 (EDT)), James Morris <[EMAIL PROTECTED]> says: > On Thu, 22 Jun 2006, Kelly Daly wrote: > > > + switch (bp->netchan_buf_proto) { > > + case __constant_htons(ETH_P_IP): { > > __constant_htons and friends should not be used in

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-06-21 Thread Arnaldo Carvalho de Melo
On 6/22/06, James Morris <[EMAIL PROTECTED]> wrote: On Thu, 22 Jun 2006, Kelly Daly wrote: > + switch (bp->netchan_buf_proto) { > + case __constant_htons(ETH_P_IP): { __constant_htons and friends should not be used in runtime code, only for data being initialized at compile time. ...

Re: [patch 2.6.17] s2io driver irq fix

2006-06-21 Thread Andrew Morton
On Wed, 21 Jun 2006 15:50:49 -0400 (EDT) Ananda Raju <[EMAIL PROTECTED]> wrote: > + if (sp->intr_type == MSI_X) { > + int i; > > - free_irq(vector, arg); > + for (i=1; (sp->s2io_entries[i].in_use == MSIX_FLG); i++) { > +

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-06-21 Thread James Morris
On Thu, 22 Jun 2006, Kelly Daly wrote: > + switch (bp->netchan_buf_proto) { > + case __constant_htons(ETH_P_IP): { __constant_htons and friends should not be used in runtime code, only for data being initialized at compile time. - James -- James Morris <[EMAIL PROTECTED]> - To unsubs

Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers)

2006-06-21 Thread Herbert Xu
On Thu, Jun 22, 2006 at 10:55:44AM +1000, Herbert Xu wrote: > > I think skb_padto simply shouldn't allocate a new skb. It only needs > to extend the data area. OK, here is a patch to make it do that. [NET]: Avoid allocating skb in skb_pad First of all it is unnecessary to allocate a new skb in

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-06-21 Thread Kelly Daly
> The hash table bits look good, just as they did last time :-) > So I'll put this part into my vj-2.6 tree now, thanks. Rockin' - thanks... Sorry for the massive delay - here's the next attempt. --- diff -urp davem/include/linux/netchannel.h kelly_new/include/linux/netchannel.h --- davem/in

Re: [1/5] [NET]: Merge TSO/UFO fields in sk_buff

2006-06-21 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 22 Jun 2006 11:09:25 +1000 > ECE just needs to be replicated so it would seem to be a safe bet unless > Dave knows some really broken hardware out there? If not I'd say that > we should just assume that it works and add a new bit it if said broken >

Re: [1/5] [NET]: Merge TSO/UFO fields in sk_buff

2006-06-21 Thread Herbert Xu
On Wed, Jun 21, 2006 at 05:46:24PM -0700, Michael Chan wrote: > > OK, if time permits, I'll cook up some patches to support generic TSO > ECN with or without hardware support. Without hardware ECN, it will use > GSO to split up the packet with CWR. Can we assume that all hardware > will handle EC

Re: [1/5] [NET]: Merge TSO/UFO fields in sk_buff

2006-06-21 Thread Michael Chan
On Thu, 2006-06-22 at 09:27 +1000, Herbert Xu wrote: > Hi Michael: > > On Wed, Jun 21, 2006 at 02:48:15PM -0700, Michael Chan wrote: > > > > We have some hardware that supports TSO and ECN. Is something like the > > patch below what you had in mind to support NETIF_F_TSO_ECN? Or are you > > thi

Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers)

2006-06-21 Thread Herbert Xu
Alan Cox <[EMAIL PROTECTED]> wrote: > > skb_padto() returns either a new buffer or the existing one depending > upon the space situation. If it returns a new buffer then it frees the > old one. I think skb_padto simply shouldn't allocate a new skb. It only needs to extend the data area. Cheers,

Re: [PATCH] Export accept queue len of a TCP listening socket via /proc/net/tcp{6}

2006-06-21 Thread Herbert Xu
Sridhar Samudrala <[EMAIL PROTECTED]> wrote: >> >> What about using the same fields (rqueue/wqueue) as you did for /proc? > > I meant extending tcp_info structure to add new fields. I think the user > space also uses this structure. What about putting it into inet_idiag_msg.idiag_[rw]queue inste

Re: PATCHv3 2.6.17-rc5 tulip free_irq() called too late

2006-06-21 Thread Valerie Henson
On Tue, Jun 13, 2006 at 05:55:31PM -0600, Grant Grundler wrote: > On Thu, Jun 08, 2006 at 11:01:20AM -0600, Grant Grundler wrote: > > Here is a new patch that moves free_irq() into tulip_down(). > > The resulting code is structured the same as cp_close(). > > Val, > Two details are wrong in versio

Re: [PATCH] Export accept queue len of a TCP listening socket via /proc/net/tcp{6}

2006-06-21 Thread Sridhar Samudrala
On Thu, 2006-06-22 at 10:21 +1000, Herbert Xu wrote: > Sridhar Samudrala <[EMAIL PROTECTED]> wrote: > > > > In order to support this with netstat/ss that use netlink mechanism to > > get the socket info, i think we need to extend tcp_info to add this field. > > Can this be done in a backward compa

Re: ipv6 source address selection in addrconf.c (2.6.17)

2006-06-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Thu, 22 Jun 2006 00:57:56 +0200), Lukasz Stelmach <[EMAIL PROTECTED]> says: > Lukasz Stelmach wrote: > > Lukasz Stelmach wrote: > > > >> [...] when trying to connect to > >> > >> 2001:200:0:8002:203:47ff:fea5:3085 (www.kame.net) > >> > >> with two global addres

Re: [PATCH] Export accept queue len of a TCP listening socket via /proc/net/tcp{6}

2006-06-21 Thread Herbert Xu
Sridhar Samudrala <[EMAIL PROTECTED]> wrote: > > In order to support this with netstat/ss that use netlink mechanism to > get the socket info, i think we need to extend tcp_info to add this field. > Can this be done in a backward compatible way? What about using the same fields (rqueue/wqueue) as

[PATCH] Export accept queue len of a TCP listening socket via /proc/net/tcp{6}

2006-06-21 Thread Sridhar Samudrala
While debugging a TCP server hang issue, we noticed that currently there is no way for a user to find the acceptq backlog value for a TCP listen socket. All the standard networking utilities that display socket info like netstat, ss and /proc/net/tcp have 2 fields called rx_queue and tx_queue. I

Re: [1/5] [NET]: Merge TSO/UFO fields in sk_buff

2006-06-21 Thread Herbert Xu
Hi Michael: On Wed, Jun 21, 2006 at 02:48:15PM -0700, Michael Chan wrote: > > We have some hardware that supports TSO and ECN. Is something like the > patch below what you had in mind to support NETIF_F_TSO_ECN? Or are you > thinking about something more generic that works with or without > har

[2.6 patch] drivers/net/irda/mcs7780.c: make struct mcs_driver static

2006-06-21 Thread Adrian Bunk
This patch makes a needlessly global struct static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.17-mm1-full/drivers/net/irda/mcs7780.c.old2006-06-22 00:38:41.0 +0200 +++ linux-2.6.17-mm1-full/drivers/net/irda/mcs7780.c2006-06-22 00:38:50.0 +0200 @@ -

Re: ipv6 source address selection in addrconf.c (2.6.17)

2006-06-21 Thread Lukasz Stelmach
Lukasz Stelmach wrote: > Lukasz Stelmach wrote: > >> [...] when trying to connect to >> >> 2001:200:0:8002:203:47ff:fea5:3085 (www.kame.net) >> >> with two global addresses assigned to the ethernet card >> >> fd24:6f44:46bd:face::254 >> 2002:531f:d667:face::254 >> >> rule 8 does not work and the f

Re: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-21 Thread Francois Romieu
Ron Mercer <[EMAIL PROTECTED]> : [...] > Please add the qla3xxx NIC driver to the next netdev-2.6 GIT tree. $ less qla3xxxpatch1-v2.02.00-k31.txt [...] + * See LICENSE.qla3xxx for copyright and licensing details. 1 - The patch contains no such file (though the file is MODULE_LICENSE("GPL")).

Re: Suspending 802.11 drivers

2006-06-21 Thread Stefan Rompf
Am Mittwoch 21 Juni 2006 17:08 schrieb Luis R. Rodriguez: > Since d80211 is already being patched for sysfs how about we use sysfs > (and kobjects) to maintain the state at suspend() and resume(). This > would allow userspace tools like supplicant running in the background > to pick up from sysfs

Re: [1/5] [NET]: Merge TSO/UFO fields in sk_buff

2006-06-21 Thread Michael Chan
On Tue, 2006-06-20 at 19:10 +1000, Herbert Xu wrote: > I've made gso_type a conjunction. The idea is that you have a base type > (e.g., SKB_GSO_TCPV4) that can be modified further to support new features. > For example, if we add a hardware TSO type that supports ECN, they would > declare NETIF_F

RE: New Qlogic qla3xxx NIC Driver v2.02.00k31 for upstream inclusion

2006-06-21 Thread Ron Mercer
Jeff, Please add the qla3xxx NIC driver to the next netdev-2.6 GIT tree. Regards, Ron Mercer > -Original Message- > From: Ron Mercer > Sent: Monday, June 12, 2006 1:33 PM > To: '[EMAIL PROTECTED]' > Cc: '[EMAIL PROTECTED]'; 'netdev@vger.kernel.org' > Subject: New Qlogic qla3xxx NIC Dri

Re: [PATCH 1/3] PAL: Support of the fixed PHY

2006-06-21 Thread Michael Buesch
On Wednesday 21 June 2006 18:09, Vitaly Bordug wrote: > +static int fixed_mdio_update_regs(struct fixed_info *fixed) > +{ > + u16 *regs = fixed->regs; > + u16 bmsr = 0; > + u16 bmcr = 0; > + > + if(!regs) { > + printk(KERN_ERR "%s: regs not set up", __FUNCTION__); > +

RE: [PATCH 01/06] MLSXFRM: Granular IPSec associations for use in MLS environments

2006-06-21 Thread Venkat Yekkirala
> Can you clarify whether, with this patch, Linux will then > have a complete > labeled network implementation in terms of both LSPP > compliance and common > user requirements? I can't comment on the LSPP compliance issue since the specific/proprietary security target being used might really

Re: Suspending 802.11 drivers

2006-06-21 Thread Michael Buesch
On Wednesday 21 June 2006 17:08, Luis R. Rodriguez wrote: > On 6/16/06, Stefan Rompf <[EMAIL PROTECTED]> wrote: > > Am Donnerstag 15 Juni 2006 21:58 schrieb Michael Buesch: > > > > I think the most important question is how a suspend/resume action should be > > translated. For the managed case, it

[RFC 3/7] NetLabel: CIPSOv4 engine

2006-06-21 Thread paul . moore
Add support for the Commercial IP Security Option (CIPSO) to the IPv4 network stack. CIPSO has become a de-facto standard for trusted/labeled networking amongst existing Trusted Operating Systems such as Trusted Solaris, HP-UX CMW, etc. This implementation is designed to be used with the NetLabel

[RFC 7/7] NetLabel: unlabeled packet handling

2006-06-21 Thread paul . moore
Add unlabeled packet support to the NetLabel subsystem. NetLabel does not do any processing on unlabled packets, but it must support passing unlabled packets on both the inbound and outbound sides. --- net/netlabel/netlabel_unlabeled.c | 287 ++ net/netlabel/n

[RFC 1/7] NetLabel: documentation

2006-06-21 Thread paul . moore
Documentation for the NetLabel system, this includes a basic overview of how NetLabel works and how LSM developers can integrate it into their favorite LSM. Also, due to the difficulty of finding expired IETF drafts, I am including the IETF CIPSO draft that is the basis of the NetLabel CIPSO imple

[RFC 0/7] Updated NetLabel patch

2006-06-21 Thread paul . moore
This is an updated version of the NetLabel patch I sent out on May 25th. It contains a variety of fixes and incorporates comments from James Morris, Stephen Smalley, and Steve Grubb. An intermediate version of this patch set has also been tested against Trusted Solaris and HP-UX CMW for CIPSO int

[RFC 5/7] NetLabel: SELinux support

2006-06-21 Thread paul . moore
Add NetLabel support to the SELinux LSM. The most significant part of this patch is the addition of NetLabel hooks into the following SELinux LSM hooks: * selinux_file_permission() * selinux_socket_sendmsg() * selinux_socket_post_create() * selinux_socket_post_accept() [NEW] * selinux_socket

Re: Intel ixgb driver bug in linux-2.6.17-rc6-mm2

2006-06-21 Thread Linas Vepstas
On Tue, Jun 20, 2006 at 02:13:45PM -0700, Jesse Brandeburg wrote: > On 6/20/06, Linas Vepstas <[EMAIL PROTECTED]> wrote: > > > >I sat down to do some testing of the ixgb driver a few days ago, and > >get failures within seconds. From what I can tell, I'm getting either a > >DMA to a bad address or

[RFC 2/7] NetLabel: core network changes

2006-06-21 Thread paul . moore
Changes to the core network stack to support the NetLabel subsystem. This includes changes to support the NetLabel NETLINK communication mechanism, changes to the IPv4 option handling to support CIPSO labels, minor changes to the socket_post_create() LSM hook so that it can return error codes, and

[RFC 6/7] NetLabel: CIPSOv4 integration

2006-06-21 Thread paul . moore
Add CIPSO/IPv4 support and management to the NetLabel subsystem. These changes integrate the CIPSO/IPv4 configuration into the existing NetLabel code and enable the use of CIPSO/IPv4 within the overall NetLabel framework. --- net/netlabel/netlabel_cipso_v4.c | 583 +++

Re: [PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 21 Jun 2006 13:45:19 -0500), Steve Wise <[EMAIL PROTECTED]> says: > This patch implements a mechanism that allows interested clients to > register for notification of certain network events. The intended use > is to allow RDMA devices (linux/drivers/infinib

[PATCH 0/2][RFC] Network Event Notifier Mechanism

2006-06-21 Thread Steve Wise
This patch implements a mechanism that allows interested clients to register for notification of certain network events. The intended use is to allow RDMA devices (linux/drivers/infiniband) to be notified of neighbour updates, ICMP redirects, path MTU changes, and route changes. The reason these

[PATCH 1/2] Network Event Notifier Mechanism.

2006-06-21 Thread Steve Wise
This patch uses notifier blocks to implement a network event notifier mechanism. Clients register their callback function by calling register_netevent_notifier() like this: static struct notifier_block nb = { .notifier_call = my_callback_func }; ... register_netevent_notifier(&nb); ---

[PATCH 2/2] Core network changes to support network event notification.

2006-06-21 Thread Steve Wise
This patch adds event calls for neighbour change, route update, and routing redirect events. TODO: PMTU change events. --- net/core/Makefile|2 +- net/core/neighbour.c |8 net/ipv4/fib_semantics.c |7 +++ net/ipv4/route.c |6 ++ 4 files chang

Re: [PATCH v3 1/7] AMSO1100 Low Level Driver.

2006-06-21 Thread Steve Wise
> ok pci posting... > > basically, if you use writel() and co, the PCI bridges in the middle are > allowed (and the more fancy ones do) cache the write, to see if more > writes follow, so that the bridge can do the writes as a single burst to > the device, rather than as individual writes. This i

Re: [openib-general] [PATCH v3 1/7] AMSO1100 Low Level Driver.

2006-06-21 Thread Grant Grundler
On Wed, Jun 21, 2006 at 11:32:51AM -0500, Steve Wise wrote: > Um, what's a 'PCI posting flush'? Can you point me where its > described/used so I can see if we need it? Thanx. I've written this up before: http://iou.parisc-linux.org/ols_2002/4Posted_vs_Non_Posted.html grant - To unsubscr

Re: [PATCH v3 1/7] AMSO1100 Low Level Driver.

2006-06-21 Thread Arjan van de Ven
> 0; > > > + > > > + __raw_writew(0, elem->hw_desc + C2_RXP_STATUS); > > > + __raw_writew(0, elem->hw_desc + C2_RXP_COUNT); > > > + __raw_writew(0, elem->hw_desc + C2_RXP_LEN); > > > > you seem to be a fan of the __raw_write() functions... any reason why? > > __raw_ is not

Re: [PATCH v3 1/7] AMSO1100 Low Level Driver.

2006-06-21 Thread Steve Wise
On Tue, 2006-06-20 at 22:43 +0200, Arjan van de Ven wrote: > On Tue, 2006-06-20 at 15:30 -0500, Steve Wise wrote: > > > +/* > > + * Allocate TX ring elements and chain them together. > > + * One-to-one association of adapter descriptors with ring elements. > > + */ > > +static int c2_tx_ring_alloc

[PATCH 1/3] PAL: Support of the fixed PHY

2006-06-21 Thread Vitaly Bordug
This makes it possible for HW PHY-less boards to utilize PAL goodies. Generic routines to connect to fixed PHY are provided, as well as ability to specify software callback that fills up link, speed, etc. information into PHY descriptor (the latter feature not tested so far). Signed-off-by: Vital

[PATCH 3/3] FS_ENET: phydev pointer may be dereferenced without NULL check

2006-06-21 Thread Vitaly Bordug
When interface is down, phy is "disconnected" from the bus and phydev is NULL. But ethtool may try to get/set phy regs even at that time, which results in NULL pointer dereference and OOPS hereby. Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- drivers/net/fs_enet/fs_enet-main.c |4 +++

Re: [patch] ipv6 source address selection in addrconf.c (2.6.17)

2006-06-21 Thread Lukasz Stelmach
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - --- linux/net/ipv6/addrconf.c.orig2006-06-21 11:41:22.0 +0200 +++ linux/net/ipv6/addrconf.c 2006-06-21 17:18:56.0 +0200 @@ -862,6 +862,8 @@ static int inline ipv6_saddr_label(const *2002::/16 2 *::/9

Re: [PATCH 2/6] ehea: pHYP interface

2006-06-21 Thread Roland Dreier
I think this code needs to be refactored so that it can share with the ehca InfiniBand driver (which should be merged upstream soon). For example, you have ehea_hcall_7arg_7ret() and the ehca driver has an identical ehca_hcall_7arg_7ret(). Also: > +++ kernel/drivers/net/ehea/ehea_hcall.h 20

[IPV6] ADDRCONF: Fix default source address selection without CONFIG_IPV6_PRIVACY

2006-06-21 Thread YOSHIFUJI Hideaki / 吉藤英明
We need to update hiscore.rule even if we don't enable CONFIG_IPV6_PRIVACY, because we have more less significant rule; longest match. I think it is suitable for -stable as well. Signed-off-by: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> --- net/ipv6/addrconf.c |3 +++ 1 files changed, 3 insertion

Re: [patch] ipv6 source address selection in addrconf.c (2.6.17)

2006-06-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Wed, 21 Jun 2006 15:42:11 +0200), Lukasz Stelmach <[EMAIL PROTECTED]> says: > --- /usr/src/linux/net/ipv6/addrconf.c~ 2006-06-21 11:41:22.0 > +0200 > +++ /usr/src/linux/net/ipv6/addrconf.c2006-06-21 15:33:26.0 > +0200 > @@ -862,6

Re: Suspending 802.11 drivers

2006-06-21 Thread Luis R. Rodriguez
On 6/16/06, Stefan Rompf <[EMAIL PROTECTED]> wrote: Am Donnerstag 15 Juni 2006 21:58 schrieb Michael Buesch: I think the most important question is how a suspend/resume action should be translated. For the managed case, it is clearly an association loss, normally signalled by netif_carrier_on/of

[-mm patch] drivers/net/ni5010.c: fix compile error

2006-06-21 Thread Adrian Bunk
On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote: >... > Changes since 2.6.17-rc6-mm2: >... > +ni5010-netcard-cleanup.patch > > netdev cleanup >... This patch fixes the following compile error with CONFIG_NI5010=y: <-- snip --> ... LD .tmp_vmlinux1 drivers/built-in.o:(.in

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-21 Thread Krzysztof Matusik
Dnia środa, 21 czerwca 2006 14:54, Patrick McHardy napisał: > > I'd love to see this one implemented. I'm using HFSC more than a year and > > it never provides proper QoS on ATM/ADSL links; low delays can never be > > achieved even with significant throttling below the h/w link bandwidth. > > Mhh .

Re: ipv6 source address selection in addrconf.c (2.6.17)

2006-06-21 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Tue, 20 Jun 2006 23:38:46 +0200), Lukasz Stelmach <[EMAIL PROTECTED]> says: > Greetings. > > net/ipv6/addrconf.c:971 is > /* Rule 2: Prefer appropriate scope */ > if (hiscore.rule < 2) { > hiscore.scope = __ipv6_addr_src_scope(hiscore.addr_type); >

[patch] ipv6 source address selection in addrconf.c (2.6.17)

2006-06-21 Thread Lukasz Stelmach
Lukasz Stelmach wrote: > I found it when I was trying to figure out why when trying to connect to > > 2001:200:0:8002:203:47ff:fea5:3085 (www.kame.net) > > with two global addresses assigned to the ethernet card > > fd24:6f44:46bd:face::254 > 2002:531f:d667:face::254 > > rule 8 does not work a

No interfaces under /proc/sys/net/ipv4/conf/

2006-06-21 Thread Hasso Tepper
After upgrade to 2.6.16.20 from 2.6.11 I discovered that no dynamic interfaces (vlans, tunnels) appear under /proc/sys/net/ipv4/conf/. /proc/sys/net/ipv6/conf/ is OK. Bug? Or feature? with my best wishes, -- Hasso Tepper - To unsubscribe from this list: send the line "unsubscribe netdev" in t

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-21 Thread Patrick McHardy
Krzysztof Matusik wrote: > Dnia wtorek, 20 czerwca 2006 17:16, Patrick McHardy napisał: > >>The code wouldn't be very complicated, it just adds some overhead. If >>you do something like I described in my previous mail the overhead for >>people not using it would be an additional pointer test befor

[PATCH 6/6] ehea: Makefile & Kconfig

2006-06-21 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/Kconfig |7 +++ drivers/net/Makefile |1 + 2 files changed, 8 insertions(+) diff -Nurp -X dontdiff linux-2.6.17.1/drivers/net/Kconfig patched_kernel/drivers/net/Kconfig --- linux-2.6.17.1/drivers/net/Kconfig 2006

[PATCH 4/6] ehea: main header files

2006-06-21 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/ehea/ehea.h| 434 + drivers/net/ehea/ehea_hw.h | 319 + 2 files changed, 753 insertions(+) --- linux-2.6.17.1-orig/drivers/net/ehea/ehea.h 1969-1

[PATCH 2/6] ehea: pHYP interface

2006-06-21 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/ehea/ehea_hcall.h | 52 ++ drivers/net/ehea/ehea_phyp.c | 1020 ++ drivers/net/ehea/ehea_phyp.h | 625 + 3 files changed, 1697 insertions(+) --- linux-2.6.17.

[PATCH 5/6] ehea: eHEA Makefile

2006-06-21 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/ehea/Makefile |7 +++ 1 file changed, 7 insertions(+) --- linux-2.6.17.1-orig/drivers/net/ehea/Makefile 1969-12-31 16:00:00.0 -0800 +++ kernel/drivers/net/ehea/Makefile2006-06-21 04:44:50.132489472 -0

[PATCH 0/6] ehea: IBM eHEA Ethernet Device Driver

2006-06-21 Thread Jan-Bernd Themann
Hi, one piece of the patch set posted on Thu, 08 Jun 2006 got lost due to the spam filter of this mailing list. Here is the complete patch set once again including the (previously missing) main component in the patch 1/5. Feedback is highly appreciated. Thanks, Jan-Bernd Signed-off-by: Jan-Ber

[PATCH 3/6] ehea: queue management

2006-06-21 Thread Jan-Bernd Themann
Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> drivers/net/ehea/ehea_ethtool.c | 325 ++ drivers/net/ehea/ehea_qmr.c | 719 drivers/net/ehea/ehea_qmr.h | 390 + 3 files changed, 1434 insertions(+) -

Re: + myri10ge-build-fix.patch added to -mm tree

2006-06-21 Thread Herbert Xu
On Wed, Jun 21, 2006 at 12:09:51PM +, Brice Goglin wrote: > > Actually, we use 64 segments when TSO in enabled > (MYRI10GE_MAX_SEND_DESC_TSO): > > #define MYRI10GE_MAX_SEND_DESC_TSO ((65536 / 2048) * 2) You're right, I missed that bit. Sorry about the noise. -- Visit Openswan at http://www

Re: [PATCH 0/2] NET: Accurate packet scheduling for ATM/ADSL

2006-06-21 Thread Krzysztof Matusik
Dnia wtorek, 20 czerwca 2006 17:16, Patrick McHardy napisał: > jamal wrote: > > On Tue, 2006-20-06 at 03:04 +0200, Patrick McHardy wrote: > >>It would be nice to have support for HFSC as well, which unfortunately > >>needs to be done in the kernel since it doesn't use rate tables. > >>What about qd

Re: + myri10ge-build-fix.patch added to -mm tree

2006-06-21 Thread Brice Goglin
Herbert Xu wrote: > On Tue, Jun 20, 2006 at 09:33:42PM -0700, [EMAIL PROTECTED] wrote: >> diff -puN drivers/net/myri10ge/myri10ge.c~myri10ge-build-fix >> drivers/net/myri10ge/myri10ge.c >> --- a/drivers/net/myri10ge/myri10ge.c~myri10ge-build-fix >> +++ a/drivers/net/myri10ge/myri10ge.c >> @@ -2120,

Re: Locking validator output on DCCP

2006-06-21 Thread Ingo Molnar
* Herbert Xu <[EMAIL PROTECTED]> wrote: > > Can someone tell me whether I am correct in my thinking or not? If I > > am then I will work out how to tell the lock validator not to worry > > about it. > > I agree, this looks bogus. Ingo, could you please take a look? sure - Ian, could you try

Re: Locking validator output on DCCP

2006-06-21 Thread Arjan van de Ven
On Wed, 2006-06-21 at 10:34 +1000, Herbert Xu wrote: > > As I read this it is not a recursive lock as sk_clone is occurring > > second and is actually creating a new socket so they are trying to > > lock on different sockets. > > > > Can someone tell me whether I am correct in my thinking or not?

Re: Suspending 802.11 drivers

2006-06-21 Thread Stefan Rompf
Am Freitag 16 Juni 2006 20:36 schrieb Stefan Rompf: > (But that's an interesting point. Will sniff whether ipw2200 hardware sends > a final packet on suspend.) neither on suspend to RAM nor on suspend to disk a disassociation is sent by ipw2200 - for the AP, the client just vanishes. Stefan - T

Re: Sanitise ethtool.h and mii.h for userspace.

2006-06-21 Thread David Woodhouse
On Tue, 2006-06-20 at 21:18 -0400, Jeff Garzik wrote: > How can reviewers make an informed decision, when you completely failed > to note: > > * This breaks the primary userspace user of this header, ethtool(8) I cannot reproduce with either an ethtool-3 tarball or a fresh checkout from your git

Re: [PATCH 2/3] FS_ENET: use PAL for mii management

2006-06-21 Thread Gerhard Jaeger
Hi, On Tuesday 20 June 2006 16:58, Vitaly Bordug wrote: > > This patch should update the fs_enet infrastructure to utilize > Phy Abstraction Layer subsystem. Inside there are generic driver rehaul, > board-specific portion to respect driver changes (for 8272ads and 866ads). > > Signed-off-by: Vi