Re: [VLAN]: translate IF_OPER_DORMANT to netif_dormant_on()

2006-07-06 Thread Patrick McHardy
Ben Greear wrote: Patrick McHardy wrote: Stefan Rompf wrote: Anyway, is it good to propagate __LINK_STATE_PRESENT then? The same situation here, add a VLAN while the main interface is not present, and you are out. Can you try to revert the quoted part of my patch, I'll rethink which flags

[PATCH] SNMPv2 tcpOutSegs counter error

2006-07-06 Thread Wei Yongjun
RFC2012 saied that tcpOutSegs should excluding those containing only retransmitted octets. But in my test, linux kernel increased the tcpOutSegs even if only retransmitted octets is send out. So I think this is a bug of kernel. Refer to RFC2012, tcpOutSegs is defined as following: tcpOutSegs

[PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Shailabh Nagar
On systems with a large number of cpus, with even a modest rate of tasks exiting per cpu, the volume of taskstats data sent on thread exit can overflow a userspace listener's buffers. One approach to avoiding overflow is to allow listeners to get data for a limited and specific set of cpus. By

Re: [PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Andrew Morton
On Thu, 06 Jul 2006 05:28:35 -0400 Shailabh Nagar [EMAIL PROTECTED] wrote: On systems with a large number of cpus, with even a modest rate of tasks exiting per cpu, the volume of taskstats data sent on thread exit can overflow a userspace listener's buffers. One approach to avoiding

Re: [PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Shailabh Nagar
On Thu, 2006-07-06 at 02:56 -0700, Andrew Morton wrote: On Thu, 06 Jul 2006 05:28:35 -0400 Shailabh Nagar [EMAIL PROTECTED] wrote: On systems with a large number of cpus, with even a modest rate of tasks exiting per cpu, the volume of taskstats data sent on thread exit can overflow a

Re: [PATCH][ebtables][vlan] ebt_vlan_t target

2006-07-06 Thread Ingo Oeser
Hi Dawid, Dawid Ciężarkiewicz schrieb: my name is Dawid Ciezarkiewicz. As a part of my daily job I was to write kernel module for ebtables to let linux bridges change vlan ids in fly using logic provided by ebtables matches. After hours of tries and kernel learning, reading and googlin'

Re: [PATCH][ebtables][vlan] ebt_vlan_t target

2006-07-06 Thread Dawid Ciezarkiewicz
On Thursday, 6 July 2006 13:15, Ingo Oeser wrote: First of all: You should not implemented --vlan-target. Always return EBT_CONTINUE. That saves a lot of (duplicated) code (you can express the same using some more rules) while keeping the same flexibility level.

Re: [PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Shailabh Nagar
On systems with a large number of cpus, with even a modest rate of tasks exiting per cpu, the volume of taskstats data sent on thread exit can overflow a userspace listener's buffers. One approach to avoiding overflow is to allow listeners to get data for a limited and specific set of cpus. By

Re: [PATCH 0/3] Action API fixes

2006-07-06 Thread jamal
On Wed, 2006-05-07 at 20:47 -0700, David Miller wrote: From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 05 Jul 2006 00:05:04 +0200 Fixes for some rather serious action API bugs. Please apply. All applied, I'll push to -stable, thanks Thomas. Dave, Did you actually read my comments on the

Re: [PATCH 0/3] Action API fixes

2006-07-06 Thread jamal
On Thu, 2006-06-07 at 08:03 -0400, jamal wrote: On Wed, 2006-05-07 at 20:47 -0700, David Miller wrote: From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 05 Jul 2006 00:05:04 +0200 Fixes for some rather serious action API bugs. Please apply. All applied, I'll push to -stable, thanks

Re: [PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Thomas Graf
* Shailabh Nagar [EMAIL PROTECTED] 2006-07-06 07:37 @@ -37,9 +45,26 @@ static struct nla_policy taskstats_cmd_g __read_mostly = { [TASKSTATS_CMD_ATTR_PID] = { .type = NLA_U32 }, [TASKSTATS_CMD_ATTR_TGID] = { .type = NLA_U32 }, + [TASKSTATS_CMD_ATTR_REGISTER_CPUMASK] = {

Re: [PATCH 0/3] Action API fixes

2006-07-06 Thread Thomas Graf
* jamal [EMAIL PROTECTED] 2006-07-06 08:27 The proper patch is attached as a replacement for [PATCH 3/3] [PKT_SCHED]: Fix error handling while dumping action from Thomas. If you have already submitted it, then i will send a patch against it. I don't understand why you're picky about this

Re: [PATCH 0/3] Action API fixes

2006-07-06 Thread jamal
On Thu, 2006-06-07 at 14:45 +0200, Thomas Graf wrote: * jamal [EMAIL PROTECTED] 2006-07-06 08:27 The proper patch is attached as a replacement for [PATCH 3/3] [PKT_SCHED]: Fix error handling while dumping action from Thomas. If you have already submitted it, then i will send a patch

SKB BUG: Invalid truesize

2006-07-06 Thread Beschorner Daniel
Does it harm? SKB BUG: Invalid truesize (380) len=1383, sizeof(sk_buff)=156 SKB BUG: Invalid truesize (316) len=1383, sizeof(sk_buff)=156 SKB BUG: Invalid truesize (348) len=1383, sizeof(sk_buff)=156 SKB BUG: Invalid truesize (316) len=1383, sizeof(sk_buff)=156 SKB BUG: Invalid truesize (380)

Re: [e1000]: flow control on by default - good idea really?

2006-07-06 Thread jamal
On Wed, 2006-05-07 at 22:45 +0200, Krzysztof Oledzki wrote: On Wed, 5 Jul 2006, Auke Kok wrote: David Miller wrote: From: jamal [EMAIL PROTECTED] Date: Tue, 04 Jul 2006 15:20:39 -0400 BTW, As an addendum this default behavior changed around 2.6.16 it seems. Flow control has

Re: [PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Shailabh Nagar
On Thu, 2006-07-06 at 14:08 +0200, Thomas Graf wrote: * Shailabh Nagar [EMAIL PROTECTED] 2006-07-06 07:37 @@ -37,9 +45,26 @@ static struct nla_policy taskstats_cmd_g __read_mostly = { [TASKSTATS_CMD_ATTR_PID] = { .type = NLA_U32 }, [TASKSTATS_CMD_ATTR_TGID] = { .type = NLA_U32

RE: RDMA will be reverted

2006-07-06 Thread Caitlin Bestler
Andi Kleen wrote: We're focusing on netfilter here. Is breaking netfilter really the only issue with this stuff? Another concern is that it will just not be able to keep up with a high rate of new connections or a high number of them (because the hardware has too limited state) Neither

Re: [PATCH 2.6.17 1/9] NetXen: Makefile and ethtool interface

2006-07-06 Thread Pradeep Dalvi
Jeff, Thanks a lot for feedback. We are working on incorporating the feedback. And we will upload the entire single patch soon. Thanks, pradeep On Wednesday 05 July 2006 21:04, Jeff Garzik wrote: Linsys Contractor Amit S. Kale wrote: +static int +netxen_nic_set_settings(struct net_device

Re: RDMA will be reverted

2006-07-06 Thread Herbert Xu
Tom Tucker [EMAIL PROTECTED] wrote: All that said, the proposed patch helps not only iWARP, but other transports (iSCSI, IB) as well. It is not large, invasive, Care to explain on how it helps those other technologies? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: netif_stop_queue() and multiple hardware queues

2006-07-06 Thread Jeremy Jackson
David Miller wrote: From: Jeremy Jackson [EMAIL PROTECTED] Date: Sun, 02 Jul 2006 22:36:03 -0400 I propose that this is an architecture/framework/API issue that the Linux core networking code should be dealing with. Proposals are worthless if nobody wants to do the work to actually implement

Re: [PATCH] ixgb: add PCI Error recovery callbacks

2006-07-06 Thread Linas Vepstas
On Thu, Jul 06, 2006 at 09:21:39AM +0800, Zhang, Yanmin wrote: On Thu, 2006-07-06 at 03:44, Linas Vepstas wrote: On Wed, Jul 05, 2006 at 08:49:27AM -0700, Auke Kok wrote: Zhang, Yanmin wrote: On Fri, 2006-06-30 at 00:26, Linas Vepstas wrote: Adds PCI Error recovery callbacks to the

Re: ACX100 (softmac-based) driver ready to merge, but is it legal?

2006-07-06 Thread Denis Vlasenko
On Thursday 29 June 2006 16:26, John W. Linville wrote: I apologize for the long copy list.  I have tried to include all known interested parties. This is a follow-up to a thread started by Andrew a few weeks ago about what should be merged for 2.6.18.  One of the topics he cited was the

Re: RDMA will be reverted

2006-07-06 Thread Tom Tucker
On Fri, 2006-07-07 at 00:08 +1000, Herbert Xu wrote: Tom Tucker [EMAIL PROTECTED] wrote: All that said, the proposed patch helps not only iWARP, but other transports (iSCSI, IB) as well. It is not large, invasive, Care to explain on how it helps those other technologies? The RDMA CMA

Re: [PATCH] ixgb: add PCI Error recovery callbacks

2006-07-06 Thread Auke Kok
Linas Vepstas wrote: On Thu, Jul 06, 2006 at 09:21:39AM +0800, Zhang, Yanmin wrote: On Thu, 2006-07-06 at 03:44, Linas Vepstas wrote: On Wed, Jul 05, 2006 at 08:49:27AM -0700, Auke Kok wrote: Zhang, Yanmin wrote: On Fri, 2006-06-30 at 00:26, Linas Vepstas wrote: Adds PCI Error recovery

Re: SKB BUG: Invalid truesize

2006-07-06 Thread Auke Kok
Beschorner Daniel wrote: Does it harm? SKB BUG: Invalid truesize (380) len=1383, sizeof(sk_buff)=156 SKB BUG: Invalid truesize (316) len=1383, sizeof(sk_buff)=156 SKB BUG: Invalid truesize (348) len=1383, sizeof(sk_buff)=156 SKB BUG: Invalid truesize (316) len=1383, sizeof(sk_buff)=156 SKB BUG:

Re: [e1000]: flow control on by default - good idea really?

2006-07-06 Thread Auke Kok
jamal wrote: On Wed, 2006-05-07 at 22:45 +0200, Krzysztof Oledzki wrote: On Wed, 5 Jul 2006, Auke Kok wrote: David Miller wrote: Flow control has been on by default in the tg3 driver since the beginning, Are you sure about this Dave?;- because I do have a tg3 on my laptop. [EMAIL

Re: [PATCH] ixgb: add PCI Error recovery callbacks

2006-07-06 Thread Linas Vepstas
On Thu, Jul 06, 2006 at 11:01:35AM -0700, Auke Kok wrote: Linas Vepstas wrote: Perhaps the right fix is to figure out what parts of the driver do i/o during shutdown, and then add a line if(wedged) skip i/o; to those places? that would be relatively simple if we can check a flag (?)

Re: [PATCH, RFT] bcm43xx: init routine rewrite (bugfix)

2006-07-06 Thread John W. Linville
On Sat, Jul 01, 2006 at 10:14:23PM +0200, Michael Buesch wrote: Hi, This patch is a rewrite of the bcm43xx init routine. It is supposed to fix several issues: * up-down-up.. sequence stale-data issue (This may fix dhclient issues) * Fix init vs IRQ race. * Fix init for cards with

Bluetooth update for 2.6

2006-07-06 Thread Marcel Holtmann
Hi Dave, this is the second part of pending updates of the Bluetooth subsystem for the upcoming 2.6.18 kernel. A couple of them are only coding style cleanups which I failed to submit for the previous kernel release. They slipped somehow. The rest is driver model integration stuff. Please push

[-mm patch] drivers/net/e1000/: possible cleanups

2006-07-06 Thread Adrian Bunk
On Mon, Jul 03, 2006 at 03:03:55AM -0700, Andrew Morton wrote: ... Changes since 2.6.17-mm5: ... git-e1000.patch ... git trees. ... This patch contains the following possible cleanups: - make needlessly global functions static - #if 0 the following unused global functions: - e1000_hw.c:

Re: [PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Andrew Morton
Thomas Graf [EMAIL PROTECTED] wrote: * Shailabh Nagar [EMAIL PROTECTED] 2006-07-06 07:37 @@ -37,9 +45,26 @@ static struct nla_policy taskstats_cmd_g __read_mostly = { [TASKSTATS_CMD_ATTR_PID] = { .type = NLA_U32 }, [TASKSTATS_CMD_ATTR_TGID] = { .type = NLA_U32 }, +

Re: [PATCH] ixgb: add PCI Error recovery callbacks

2006-07-06 Thread Linas Vepstas
On Thu, Jul 06, 2006 at 01:50:59PM -0500, Linas Vepstas wrote: On Thu, Jul 06, 2006 at 11:01:35AM -0700, Auke Kok wrote: Linas Vepstas wrote: Perhaps the right fix is to figure out what parts of the driver do i/o during shutdown, and then add a line if(wedged) skip i/o; to those

Re: [PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Shailabh Nagar
Andrew Morton wrote: Thomas Graf [EMAIL PROTECTED] wrote: * Shailabh Nagar [EMAIL PROTECTED] 2006-07-06 07:37 @@ -37,9 +45,26 @@ static struct nla_policy taskstats_cmd_g __read_mostly = { [TASKSTATS_CMD_ATTR_PID] = { .type = NLA_U32 }, [TASKSTATS_CMD_ATTR_TGID] = { .type = NLA_U32

Re: [PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Thomas Graf
* Andrew Morton [EMAIL PROTECTED] 2006-07-06 14:48 In the interests of keeping this work decoupled from netlink enhancements I'd propose the below. Is it bad to modify the data at nla_data()? Yes, it points into a skb data buffer which may be shared by sitting on other queues if the message is

[PATCH 2/2] forcedeth: watermark fixup

2006-07-06 Thread Ayaz Abdulla
This patch defines the watermark registers and fixes up the use of this register. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig-2.6/drivers/net/forcedeth.c2006-07-06 15:04:39.0 -0400 +++ new-2.6/drivers/net/forcedeth.c 2006-07-06 15:05:00.0 -0400 @@ -271,8

[PATCH 1/2] forcedeth: deferral fixup

2006-07-06 Thread Ayaz Abdulla
This patch adds the definition for the deferral registers and fixes up the use of these registers. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig-2.6/drivers/net/forcedeth.c2006-07-06 15:03:45.0 -0400 +++ new-2.6/drivers/net/forcedeth.c 2006-07-06 15:03:55.0

Re: [PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Andrew Morton
Shailabh Nagar [EMAIL PROTECTED] wrote: Andrew Morton wrote: Thomas Graf [EMAIL PROTECTED] wrote: * Shailabh Nagar [EMAIL PROTECTED] 2006-07-06 07:37 @@ -37,9 +45,26 @@ static struct nla_policy taskstats_cmd_g __read_mostly = { [TASKSTATS_CMD_ATTR_PID] = { .type = NLA_U32 },

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-06 Thread Benjamin Herrenschmidt
+#if defined(__powerpc__) + /* There isn't a generic way to specify writethrough mappings */ + pgprot_val(vma-vm_page_prot) |= _PAGE_NO_CACHE; + pgprot_val(vma-vm_page_prot) |= _PAGE_WRITETHRU; + pgprot_val(vma-vm_page_prot) = ~_PAGE_GUARDED; +#endif I don't see any case

Re: [PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks]

2006-07-06 Thread Andrew Morton
Thomas Graf [EMAIL PROTECTED] wrote: * Andrew Morton [EMAIL PROTECTED] 2006-07-06 14:48 In the interests of keeping this work decoupled from netlink enhancements I'd propose the below. Is it bad to modify the data at nla_data()? Yes, it points into a skb data buffer which may be shared

Re: RDMA will be reverted

2006-07-06 Thread Herbert Xu
On Thu, Jul 06, 2006 at 12:36:24PM -0500, Tom Tucker wrote: The RDMA CMA uses IP addresses and port numbers to create a uniform addressing scheme across all transport types. For IB, it is necessary to resolve IP addresses to IB GIDs. The ARP protocol is used to do this and a netfilter rule

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-06 Thread Bryan O'Sullivan
On Fri, 2006-07-07 at 08:37 +1000, Benjamin Herrenschmidt wrote: +int ipath_unordered_wc(void) +{ + return 1; +} How is the above providing any kind of serialisation ? It's not intended to; it tells the *caller* whether to do it. b - To unsubscribe from this list: send the

Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-06 Thread Benjamin Herrenschmidt
On Thu, 2006-07-06 at 16:34 -0700, Bryan O'Sullivan wrote: On Fri, 2006-07-07 at 08:37 +1000, Benjamin Herrenschmidt wrote: +int ipath_unordered_wc(void) +{ + return 1; +} How is the above providing any kind of serialisation ? It's not intended to; it tells the *caller*

Re: [RFC] change netdevice to use struct device instead of struct class_device

2006-07-06 Thread Greg KH
On Wed, Jul 05, 2006 at 04:29:23PM +0200, Marcel Holtmann wrote: Hi Greg, The patch needs some other changes to the driver core that are also in my git tree, and included in the -mm release. Specifically these patches are needed:

Re: RDMA will be reverted

2006-07-06 Thread Tom Tucker
On Fri, 2006-07-07 at 10:03 +1000, Herbert Xu wrote: On Thu, Jul 06, 2006 at 12:36:24PM -0500, Tom Tucker wrote: The RDMA CMA uses IP addresses and port numbers to create a uniform addressing scheme across all transport types. For IB, it is necessary to resolve IP addresses to IB GIDs.

Re: [e1000]: flow control on by default - good idea really?

2006-07-06 Thread jamal
On Thu, 2006-06-07 at 11:25 -0700, Auke Kok wrote: jamal wrote: [EMAIL PROTECTED]:~/Desktop/maemo$ sudo ethtool -a eth0 Pause parameters for eth0: Autonegotiate: on RX: off TX: off mine says it's on :) Dell D610: [EMAIL PROTECTED]:~$ sudo lspci | grep -i

Re: [patch 1/7] net_device list cleanup: core

2006-07-06 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Mon, 3 Jul 2006 12:18:51 +0400), Andrey Savochkin [EMAIL PROTECTED] says: @@ -3271,22 +3277,22 @@ int unregister_netdevice(struct net_devi /* And unlink it from device chain. */ for (dp = dev_base; (d = *dp) != NULL; dp = d-next) { Why not

Re: [e1000]: flow control on by default - good idea really?

2006-07-06 Thread Michael Chan
Jamal wrote: Dell D610: [EMAIL PROTECTED]:~$ sudo lspci | grep -i bcm :02:00.0 Ethernet controller: Broadcom Corporation NetXtreme BCM5751 Gigabit Ethernet PCI Express (rev 01) This is Broadcom tg3 hardware. Are we talking about e1000 or tg3? Flow control advertisement has always