Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-12 Thread Dave Olson
On Thu, 6 Jul 2006, Benjamin Herrenschmidt wrote: | On Thu, 2006-07-06 at 16:34 -0700, Bryan O'Sullivan wrote: | > On Fri, 2006-07-07 at 08:37 +1000, Benjamin Herrenschmidt wrote: | > | > > > +int ipath_unordered_wc(void) | > > > +{ | > > > + return 1; | > > > +} | > > | > > How is the abo

another networking lockdep bug

2006-07-12 Thread Dave Jones
Not sure if this one got reported/fixed yet, as I was running a kernel from sometime last week.. Dave === [ INFO: possible circular locking dependency detected ] --- git-fetch/

Re: What's new in wireless-dev?

2006-07-12 Thread John W. Linville
On Wed, Jul 12, 2006 at 08:48:32AM -0400, John W. Linville wrote: > On Wed, Jul 12, 2006 at 11:48:32AM +0200, Jiri Benc wrote: > > On Tue, 11 Jul 2006 16:45:58 -0400, John W. Linville wrote: > > > John W. Linville: > > > d80211: use netif_tx_lock API > > > > > --- a/net/d80211/ieee80211.c >

Re: [PATCH 08/10] MLSXFRM: Add security context to acquire messages using PF_KEY

2006-07-12 Thread James Morris
On Wed, 12 Jul 2006, Venkat Yekkirala wrote: > +static inline void security_xfrm_skb_secid(struct sk_buff *skb, u32 *secid) > { > - return security_ops->xfrm_decode_session(skb, fl); > + BUG_ON(security_ops->xfrm_decode_session(skb, secid, 0)); > BUG_ON looks wrong here, in that you don'

Re: [PATCH 1/1] net: fix __sk_stream_mem_reclaim

2006-07-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 13 Jul 2006 10:54:07 +1000 > Ian McDonald <[EMAIL PROTECTED]> wrote: > > __sk_stream_mem_reclaim is only called by sk_stream_mem_reclaim. > > > > As such the check on sk->sk_forward_alloc is not needed and can be removed. > > > > Signed-off-by: Ian

Re: [PATCH 1/1] net: fix __sk_stream_mem_reclaim

2006-07-12 Thread Herbert Xu
Ian McDonald <[EMAIL PROTECTED]> wrote: > __sk_stream_mem_reclaim is only called by sk_stream_mem_reclaim. > > As such the check on sk->sk_forward_alloc is not needed and can be removed. > > Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> Acked-by: Herbert Xu <[EMAIL PROTECTED]> What's more, ev

[PATCH 1/1] net: fix __sk_stream_mem_reclaim

2006-07-12 Thread Ian McDonald
__sk_stream_mem_reclaim is only called by sk_stream_mem_reclaim. As such the check on sk->sk_forward_alloc is not needed and can be removed. Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> --- diff --git a/net/core/stream.c b/net/core/stream.c index e948969..d1d7dec 100644 --- a/net/core/stream.

[git patches] net driver fixes

2006-07-12 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/8139cp.c|2 drivers/net/e1000/e1000_main.c |2 drivers/net/forcedeth.c

Re: Bluetooth update for 2.6

2006-07-12 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Wed, 12 Jul 2006 23:49:55 +0200 > here are some bug fixes for the Bluetooth subsystem. I included the > kzalloc cleanup since I saw you still taking these kind of updates. ... > Please pull from > > > git://git.kernel.org/pub/scm/linux/ker

[PATCH 6/7] sky2: PHY power on delays

2006-07-12 Thread Stephen Hemminger
The documentation says we need to wait after turning on the PHY. Also, don't enable WOL by default. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-07-11 15:25:40.0 -0700 +++ sky2/drivers/net/sky2.c 2006-07-11 15:35:31.0 -0700

[PATCH 7/7] sky2: optimize receive restart

2006-07-12 Thread Stephen Hemminger
When the driver handles multiple packets per NAPI poll, it is better to reload the receive ring, then tell the hardware. Otherwise, under packet storm with flow control, the driver/hardware will degrade down to one packet getting through per pause-exchange. Likewise on transmit, don't wakeup until

[PATCH 1/7] sky2: fix truncated collision threshold mask

2006-07-12 Thread Stephen Hemminger
Patch to correct broken collision threshold mask in sky2 driver. Should be three bits wide, but the mask only allows for 1 bit to be set. Thanks & Regards Neil Signed-off-by: Neil Horman <[EMAIL PROTECTED]> Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> sky2.h |2 +- 1 files changed,

[PATCH 4/7] sky2: sky2_reset section mismatch

2006-07-12 Thread Stephen Hemminger
Since sky2_reset gets call from sky2_resume it shouldn't be tagged with devinit. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-07-07 13:02:23.0 -0700 +++ sky2/drivers/net/sky2.c 2006-07-07 16:31:29.0 -0700 @@ -2286,7 +2286,7

[PATCH 2/7] skge: fix truncated collision threshold mask

2006-07-12 Thread Stephen Hemminger
Patch to correct broken collision threshold mask in (same problem as sky2 driver). Should be three bits wide, but the mask only allows for 1 bit to be set. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/skge.h2006-07-07 13:02:23.0 -0700 +++ sky2/dr

[PATCH 0/7] Marvell SysKonnect related driver fixes

2006-07-12 Thread Stephen Hemminger
Minor fixes for sky2 and related drivers. Includes the collision threshold mask (and related drivers). Known outstanding problems: * sky2 hangs which are unreproducible on the machines in my environment :-( * sky2 probably has problems on dual-port card on pci-express, fixed on pci-

[PATCH 5/7] sky2: NAPI suspend/resume of dual port cards

2006-07-12 Thread Stephen Hemminger
The changes to handle suspend/resume didn't handle the case where a dual port card has the first port down, but the second is running. In this driver, all NAPI polling is done on the primary port. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sky2.c2006-07

[PATCH 3/7] sk98lin: fix truncated collision threshold mask

2006-07-12 Thread Stephen Hemminger
Patch to correct broken collision threshold mask in (same problem as sky2 driver). Should be three bits wide, but the mask only allows for 1 bit to be set. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- sky2.orig/drivers/net/sk98lin/h/xmac_ii.h 2006-04-27 11:12:38.0 -0700 ++

Bluetooth update for 2.6

2006-07-12 Thread Marcel Holtmann
Hi Dave, here are some bug fixes for the Bluetooth subsystem. I included the kzalloc cleanup since I saw you still taking these kind of updates. Regards Marcel Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git This will update the following fil

Re: [PATCH 1/2] forcedeth: deferral fixup

2006-07-12 Thread Jeff Garzik
applied 1-2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 09/10] MLSXFRM: Default labeling of socket specific IPSec policies

2006-07-12 Thread Venkat Yekkirala
This defaults the label of socket-specific IPSec policies to be the same as the socket they are set on. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- include/linux/security.h| 19 ++--- include/net/xfrm.h |2 - net/key/af_key.c| 15

[PATCH 05/10] MLSXFRM: Flow based matching of xfrm policy and state

2006-07-12 Thread Venkat Yekkirala
This implements a seemless mechanism for xfrm policy selection and state matching based on the flow sid. This also includes the necessary SELinux enforcement pieces. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- include/linux/security.h| 106 +-- include/net/flow.h

[PATCH 08/10] MLSXFRM: Add security context to acquire messages using PF_KEY

2006-07-12 Thread Venkat Yekkirala
This labels the flows that could utilize IPSec xfrms at the points they are defined so that IPSec policy and SAs at the right label can be used. The following protos are currently not handled, but they should continue to be able to use single-labeled IPSec like they currently do. ipmr ip_gre ipi

[PATCH 01/10] MLSXFRM: Granular IPSec associations for use in MLS environments

2006-07-12 Thread Venkat Yekkirala
The current approach to labeling Security Associations for SELinux purposes uses a one-to-one mapping between xfrm policy rules and security associations. This doesn’t address the needs of real world MLS (Multi-level System, traditional Bell-LaPadula) environments where a single xfrm policy rule

FOR REFERENCE ONLY: MLSXFRM: Add support to serefpolicy

2006-07-12 Thread Venkat Yekkirala
This patch has been included here just for reference. It will be submitted to the serefpolicy list later. This patch adds a polmatch avperm to arbitrate flow/state's access to a xfrm policy. It also defines MLS policy for association { sendto, recvfrom, polmatch }. NOTE: When an inbound packet i

[PATCH 03/10] MLSXFRM: Add security sid to sock

2006-07-12 Thread Venkat Yekkirala
This adds security for IP sockets at the sock level. Security at the sock level is needed to enforce the SELinux security policy for security associations even when a sock is orphaned (such as in the TCP LAST_ACK state). Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- include/linux/secur

[PATCH 02/10] MLSXFRM: Define new SELinux service routine

2006-07-12 Thread Venkat Yekkirala
This defines a routine that combines the Type Enforcement portion of one sid with the MLS portion from the other sid to arrive at a new sid. This is currently used to define a sid for a security association that is to be negotiated by IKE. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> ---

[PATCH 04/10] MLSXFRM: Add security sid to flowi

2006-07-12 Thread Venkat Yekkirala
This adds security to flow key for labeling of flows as also to allow for making flow cache lookups based on the security label seemless. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- Documentation/networking/secid.txt | 14 ++ include/net/flow.h |1 + 2

[PATCH 10/10] MLSXFRM: Auto-labeling of child sockets

2006-07-12 Thread Venkat Yekkirala
This automatically labels the TCP, Unix stream, and dccp child sockets as well as openreqs to be at the same MLS level as the peer. Signed-off-by: Venkat Yekkirala <[EMAIL PROTECTED]> --- include/linux/security.h| 43 ++ include/net/request_sock.h |1 inc

[PATCH 07/10] MLSXFRM: Add security context to acquire messages using PF_KEY

2006-07-12 Thread Venkat Yekkirala
This includes the security context of a security association created for use by IKE in the acquire messages sent to IKE daemons using PF_KEY. This would allow the daemons to include the security context in the negotiation, so that the resultant association is unique to that security context. Si

[PATCH 06/10] MLSXFRM: Add security context to acquire messages using netlink

2006-07-12 Thread Venkat Yekkirala
From: Serge Hallyn <[EMAIL PROTECTED]> This includes the security context of a security association created for use by IKE in the acquire messages sent to IKE daemons using netlink/xfrm_user. This would allow the daemons to include the security context in the negotiation, so that the resultant

Re: [patch] do not allow IPW_2100=Y or IPW_2200=Y

2006-07-12 Thread Bodo Eggert
Pavel Machek <[EMAIL PROTECTED]> wrote: > +++ linux-mm/drivers/net/wireless/ipw2200.c  These are all uses of needs_reinit: > +static int needs_reinit = 1; > + needs_reinit = 1; I asume there is something missing. -- Ich danke GMX dafür, die Verwendung meiner Adressen mittels per S

Re: [PATCH] WAN: converting generic HDLC to use netif_dormant*()

2006-07-12 Thread David Miller
From: Krzysztof Halasa <[EMAIL PROTECTED]> Date: Tue, 11 Jul 2006 23:18:45 +0200 > This patch converts generic HDLC (and WAN drivers using it) from > hdlc_set_carrier() to netif_dormant*() interface. > WAN hardware drivers should now use netif_carrier_on|off() like > other network drivers. > > Pl

Re: [Bug 6688] Memory allocation problem

2006-07-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 12 Jul 2006 21:45:13 +1000 > [IPV4]: Fix error handling for fib_insert_node call > > The error handling around fib_insert_node was broken because we always > zeroed the error before checking it. > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Ap

Re: [PATCH] bcm43xx-d80211: use SET_NETDEV_DEV

2006-07-12 Thread Michael Buesch
On Wednesday 12 July 2006 19:02, you wrote: > This adds /sys/class/net/wmaster0/device symlink. > > Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> Signed-off-by: Michael Buesch <[EMAIL PROTECTED]> > > --- > drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c |1 + > 1 files changed, 1 inserti

Re: [PATCH] d80211: make sleeping in hw->config possible #2

2006-07-12 Thread Michael Buesch
On Wednesday 12 July 2006 18:53, Jiri Benc wrote: > On Tue, 11 Jul 2006 00:54:33 +0200, Michael Buesch wrote: > > Please apply this to wireless-dev. > > Note that this is the second try to submit this patch. > > The first try contained a little bug. I'm sorry for that. > > If you already applied th

Re: [AX.25] Optimize AX.25 socket list lock

2006-07-12 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Tue, 11 Jul 2006 23:20:45 +0100 > Right now all uses of the ax25_list_lock lock are _bh locks but knowing > some code is only ever getting invoked from _bh context we can better. > > Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Applied, thanks Ralf

Re: [NETROM] lockdep: fix false positive

2006-07-12 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Tue, 11 Jul 2006 23:11:42 +0100 > NETROM network devices are virtual network devices encapsulating NETROM > frames into AX.25 which will be sent through an AX.25 device, so form a > special "super class" of normal net devices; split their locks off into

Re: [ROSE] lockdep: fix false positive

2006-07-12 Thread David Miller
From: Ralf Baechle <[EMAIL PROTECTED]> Date: Tue, 11 Jul 2006 23:13:57 +0100 > ROSE network devices are virtual network devices encapsulating ROSE > frames into AX.25 which will be sent through an AX.25 device, so form a > special "super class" of normal net devices; split their locks off into > a

tg3: oops on incompletely initialized rx ring

2006-07-12 Thread Stephane Doyon
Hi, We have stumbled on a little problem with the tg3 driver. It would appear that some RX ring entries without buffers are still used for receive when memory allocation failures occur during initial RX ring setup, which causes an oops. The tg3 driver sets tp->rx_jumbo_ptr and MAILBOX_RCV_JU

RE: [PATCH]NET: Add ECN support for TSO

2006-07-12 Thread Ravinandan Arakali
Thanks.. I will get rid of the per-session check for ECN. Ravi -Original Message- From: David Miller [mailto:[EMAIL PROTECTED] Sent: Tuesday, July 11, 2006 11:12 PM To: [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [PATCH]NET: Add ECN supp

[PATCH] bcm43xx-d80211: use SET_NETDEV_DEV

2006-07-12 Thread Jiri Benc
This adds /sys/class/net/wmaster0/device symlink. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c |1 + 1 files changed, 1 insertion(+) --- dscape.orig/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c +++ dscape/drivers/net/wireless/d802

[PATCH] d80211: SET_NETDEV_DEV for non-master devices

2006-07-12 Thread Jiri Benc
This adds /sys/class/net/*/device symlinks for non-master (wlan* and wmgmt*) devices. Signed-off-by: Jiri Benc <[EMAIL PROTECTED]> --- net/d80211/ieee80211_iface.c |2 ++ 1 files changed, 2 insertions(+) --- dscape.orig/net/d80211/ieee80211_iface.c +++ dscape/net/d80211/ieee80211_iface.c @@

Re: [PATCH] d80211: make sleeping in hw->config possible #2

2006-07-12 Thread Jiri Benc
On Tue, 11 Jul 2006 00:54:33 +0200, Michael Buesch wrote: > Please apply this to wireless-dev. > Note that this is the second try to submit this patch. > The first try contained a little bug. I'm sorry for that. > If you already applied the first one, I can provide an incremental patch. > > Note2

Re: [DOC]: generic netlink

2006-07-12 Thread Shailabh Nagar
Jamal Hadi Salim wrote: On Tue, 2006-11-07 at 16:57 -0700, Randy.Dunlap wrote: so make it a patch to Documentation/networking/... I was going to when it got in better shape. Good suggestion, I will do this soon and put it there as a patch. I have some doc corrections, Jamal. Do I send

Re: skge error; hangs w/ hardware memory hole

2006-07-12 Thread Andi Kleen
On Wednesday 12 July 2006 06:09, Kevin Brown wrote: > Andreas Kleen wrote: > > If it helps I can do a proper patch that only bounces IO > 4GB through > > the copy. > > For the A8V series of boards, that will almost certainly be just fine, > because as far as I know you can't populate them with more

Re: What's new in wireless-dev?

2006-07-12 Thread John W. Linville
On Wed, Jul 12, 2006 at 11:48:32AM +0200, Jiri Benc wrote: > On Tue, 11 Jul 2006 16:45:58 -0400, John W. Linville wrote: > > John W. Linville: > > d80211: use netif_tx_lock API > > > --- a/net/d80211/ieee80211.c > > +++ b/net/d80211/ieee80211.c > > @@ -1338,7 +1338,7 @@ static void ieee80211

Re: [Bug 6688] Memory allocation problem

2006-07-12 Thread Herbert Xu
On Wed, Jul 12, 2006 at 09:44:46PM +1000, Herbert Xu wrote: > > [IPV4]: Fix error handling for fib_insert_node call Doh, fogot the patch. [IPV4]: Fix error handling for fib_insert_node call The error handling around fib_insert_node was broken because we always zeroed the error before checking i

Re: [Bug 6688] Memory allocation problem

2006-07-12 Thread Herbert Xu
Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 19 Jun 2006 23:46:08 -0700 > [EMAIL PROTECTED] wrote: > >> http://bugzilla.kernel.org/show_bug.cgi?id=6688 > > This is looking like a net memory leak in 2.6.16. 1/3rd is in ip_fib_alias > and 2/3rds is in size-64. I've asked the reporter to app

Re: [DOC]: generic netlink

2006-07-12 Thread Jamal Hadi Salim
On Tue, 2006-11-07 at 16:57 -0700, Randy.Dunlap wrote: > so make it a patch to Documentation/networking/... > I was going to when it got in better shape. Good suggestion, I will do this soon and put it there as a patch. > I have some doc corrections, Jamal. Do I send them against > the 2006-ju

Re: [PATCH 1/1] net: fix __sk_stream_mem_reclaim

2006-07-12 Thread Herbert Xu
Ian McDonald <[EMAIL PROTECTED]> wrote: > __sk_stream_mem_reclaim is only called by sk_stream_mem_reclaim. > > As such the check on sk->sk_forward_alloc is not needed and can be removed. > > At the same time remove the EXPORT_SYMBOL_GPL as not needed and shift it > into include/net/sock.h I don'

Re: What's new in wireless-dev?

2006-07-12 Thread Jiri Benc
On Tue, 11 Jul 2006 16:45:58 -0400, John W. Linville wrote: > John W. Linville: > d80211: use netif_tx_lock API > --- a/net/d80211/ieee80211.c > +++ b/net/d80211/ieee80211.c > @@ -1338,7 +1338,7 @@ static void ieee80211_tx_pending(unsigne > struct ieee80211_txrx_data tx; > int i,

Re: [ROSE] lockdep: fix false positive

2006-07-12 Thread Ingo Molnar
* Ralf Baechle <[EMAIL PROTECTED]> wrote: > ROSE network devices are virtual network devices encapsulating ROSE > frames into AX.25 which will be sent through an AX.25 device, so form a > special "super class" of normal net devices; split their locks off into > a separate class since they always

Re: [NETROM] lockdep: fix false positive

2006-07-12 Thread Ingo Molnar
* Ralf Baechle <[EMAIL PROTECTED]> wrote: > NETROM network devices are virtual network devices encapsulating NETROM > frames into AX.25 which will be sent through an AX.25 device, so form a > special "super class" of normal net devices; split their locks off into a > separate class since they alw

Re: [PATCH] bonding: enhance the IP address check of arp_ip_target

2006-07-12 Thread Tetsuo Takata
Hi, Thank you for the comments. >> Why not just use sscanf? Here's a fixed version of the previous patch, that uses sscanf. > > Better yet, use a better interface like netlink rather than module > parameters. Wouldn't that be overkill? best regards, --- Signed-off-by: Tetsuo Takata <[EMAIL

[NETROM] lockdep: fix false positive

2006-07-12 Thread Ralf Baechle
NETROM network devices are virtual network devices encapsulating NETROM frames into AX.25 which will be sent through an AX.25 device, so form a special "super class" of normal net devices; split their locks off into a separate class since they always nest. Signed-off-by: Ralf Baechle <[EMAIL PROTE

[ROSE] lockdep: fix false positive

2006-07-12 Thread Ralf Baechle
ROSE network devices are virtual network devices encapsulating ROSE frames into AX.25 which will be sent through an AX.25 device, so form a special "super class" of normal net devices; split their locks off into a separate class since they always nest. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED

[AX.25] Optimize AX.25 socket list lock

2006-07-12 Thread Ralf Baechle
Right now all uses of the ax25_list_lock lock are _bh locks but knowing some code is only ever getting invoked from _bh context we can better. Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> --- net/ax25/af_ax25.c | 14 +++--- net/ax25/ax25_ds_subr.c |8 net/ax25/ax

[PATCH 1/1] net: fix __sk_stream_mem_reclaim

2006-07-12 Thread Ian McDonald
__sk_stream_mem_reclaim is only called by sk_stream_mem_reclaim. As such the check on sk->sk_forward_alloc is not needed and can be removed. At the same time remove the EXPORT_SYMBOL_GPL as not needed and shift it into include/net/sock.h Signed-off-by: Ian McDonald <[EMAIL PROTECTED]> --- diff -