Re: [PATCH 38 of 39] IB/ipath - More changes to support InfiniPath on PowerPC 970 systems

2006-07-13 Thread Dave Olson
On Thu, 6 Jul 2006, Benjamin Herrenschmidt wrote: | On Thu, 2006-07-06 at 16:34 -0700, Bryan O'Sullivan wrote: | On Fri, 2006-07-07 at 08:37 +1000, Benjamin Herrenschmidt wrote: | |+int ipath_unordered_wc(void) |+{ |+ return 1; |+} | | How is the above providing any

[PATCH wireless-dev] d80211: Replace rc4 code with crypto api arc4

2006-07-13 Thread Michael Wu
Replace rc4 code with crypto api arc4 This patch replaces the rc4 code used in wep.c with crypto api's arc4 cipher. The struct crypto_tfm passing in tkip isn't great, but it'll get fixed when tkip is converted to use crypto api entirely. (michael_mic) Signed-off-by: Michael Wu [EMAIL PROTECTED]

[PATCH wireless-dev] adm8211: Properly initialize priv-mode in adm8211_probe

2006-07-13 Thread Michael Wu
Properly initialize priv-mode in adm8211_probe The adm8211 driver refuses to open without this patch. Don't know how I ever tested the driver without this working. Signed-off-by: Michael Wu [EMAIL PROTECTED] --- drivers/net/wireless/d80211/adm8211/adm8211.c |1 + 1 files changed, 1

[NET]: Update frag_list in pskb_trim

2006-07-13 Thread Herbert Xu
Hi Dave: This needs to go into stable as well. In fact, there is another unrelated bug with exactly the same symptoms which was inadvertently fixed by the GSO patches. So I'll send a simpler fix for that to stable. [NET]: Update frag_list in pskb_trim When pskb_trim has to defer to

[NET]: Add missing UFO initialisations

2006-07-13 Thread Herbert Xu
Hi: This is only needed for 2.6.17-stable. [NET]: Add missing UFO initialisations This bug was unknowingly fixed the GSO patches (or rather, its effect was unknown at the time). Thanks to Marco Berizzi's persistence which is documented in the thread ipsec tunnel asymmetrical mtu, we now know

Re: another networking lockdep bug

2006-07-13 Thread Herbert Xu
Dave Jones [EMAIL PROTECTED] wrote: Not sure if this one got reported/fixed yet, as I was running a kernel from sometime last week.. I think we've seen a couple of similar ones, this one is more elaborate though :) - #1 (rtnl_mutex){--..}: [802ab792] lock_acquire+0x4a/0x69

[patch 1/2] spidernet: bug fix for init code

2006-07-13 Thread Jens Osterkamp
We want to intitialize addr instead of data register first. Signed-off-by: Jens Osterkamp [EMAIL PROTECTED] Signed-off-by: Arnd Bergmann [EMAIL PROTECTED] Index: git/drivers/net/spider_net.c === ---

[patch 2/2] spidernet: rework tx queue handling

2006-07-13 Thread Jens Osterkamp
With this patch TX queue descriptors are not chained per default any more. The pointer to next descriptor is set only when next descriptor is prepaired for transfer. Also the mechanism of checking wether Spider is ready has been changed: it checks not for CARDOWNED flag in status of previous

[patch 0/2] spidernet : two important bugfixes

2006-07-13 Thread Jens Osterkamp
This patchset contains two bugfixes, one fixes a bug in the code clearing out the sequencer ram at startup. The other is a fix for the tx queue stopping to send packets in heavy load situations. Please consider these for inclusion into 2.6.18. -- - To unsubscribe from this list: send the line

[SLHC 0/4] Misc SLHC cleanups

2006-07-13 Thread Ralf Baechle
This is a series of small cleanup to the SLHC code as part of my work on VJ compressed IP over AX.25 Ralf - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH wireless-dev] d80211: Replace rc4 code with crypto api arc4

2006-07-13 Thread Jiri Benc
On Thu, 13 Jul 2006 01:39:59 -0700, Michael Wu wrote: This patch replaces the rc4 code used in wep.c with crypto api's arc4 cipher. The struct crypto_tfm passing in tkip isn't great, but it'll get fixed when tkip is converted to use crypto api entirely. (michael_mic) Great work! Thanks, I'll

[SLHC 1/4] Cleanup SLHC configuration

2006-07-13 Thread Ralf Baechle
Convert selection of serial line header compression to use CONFIG_SLHC rather than makefile ifeq uglyness. This makes it easier to select the SLHC module from other code. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] --- drivers/isdn/i4l/Kconfig |1 + drivers/net/Kconfig |8

[SLHC 2/4] Convert to kzalloc

2006-07-13 Thread Ralf Baechle
Signed-off-by: Ralf Baechle [EMAIL PROTECTED] --- drivers/net/slhc.c |9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) Index: linux-net/drivers/net/slhc.c === --- linux-net.orig/drivers/net/slhc.c 2006-07-09

[SLHC 3/4] Remove useless casts

2006-07-13 Thread Ralf Baechle
Signed-off-by: Ralf Baechle [EMAIL PROTECTED] --- drivers/net/slhc.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) Index: linux-net/drivers/net/slhc.c === --- linux-net.orig/drivers/net/slhc.c 2006-07-10

[SLHC 4/4] Remove useless #ifdef MODULE stuff and printout

2006-07-13 Thread Ralf Baechle
Get rid of the MODULE stuff. Could have rewritten to use modern interfaces but the copyright message of this BSD licensed code isn't interesting enough to be watched on every bootup, in every syslog. Signed-off-by: Ralf Baechle [EMAIL PROTECTED] --- drivers/net/slhc.c | 14 -- 1

Re: IPSec + large packets being corrupted

2006-07-13 Thread Herbert Xu
Chris Audley [EMAIL PROTECTED] wrote: Large packet (eg. 1600 byte ping) received by VPN server A. Packet encrypted and fragmented then sent from Server A to Server B. Packet received by network subsytem on B and frag_list created ah_input() strips the AH header -- frag sizes are not changed!

Re: [Bugme-new] [Bug 6430] New: ipsec tunnel : reply is not forwarded

2006-07-13 Thread Herbert Xu
Raphael Astier [EMAIL PROTECTED] wrote: On GW1 : #setkey -f flush; spdflush; add 192.168.1.1 192.168.1.2 esp 1000 -m tunnel -E des-cbc 12345678; spdadd 10.0.0.0/24 11.0.0.0/24 any -P out ipsec esp/tunnel/192.168.1.1-192.168.1.2/require; On GW2 : (only need to have SPI to decrypt

Re: jumbo frames and memory fragmentation

2006-07-13 Thread Herbert Xu
Chris Friesen [EMAIL PROTECTED] wrote: Herbert Xu wrote: Either upgrade your kernel or backport the page-splitting code in the current tree. That's really the only sane solution for jumbo packets. Looking at the page-splitting code, it says 82571 and greater support packet-split

Re: possible dos / wsize affected frozen connection length

2006-07-13 Thread Herbert Xu
CaT [EMAIL PROTECTED] wrote: I'm just wondering if connections hanging around this long are normal. The above has now been running for 6 days. netstat is still reporting an established session. netcat has not timed out. It's all just sitting there doing nothing. TCP connections without

Re: [PATCH 03/10] MLSXFRM: Add security sid to sock

2006-07-13 Thread Stephen Smalley
On Wed, 2006-07-12 at 16:12 -0500, Venkat Yekkirala wrote: This adds security for IP sockets at the sock level. Security at the sock level is needed to enforce the SELinux security policy for security associations even when a sock is orphaned (such as in the TCP LAST_ACK state).

Re: [PATCH 10/10] MLSXFRM: Auto-labeling of child sockets

2006-07-13 Thread Stephen Smalley
On Wed, 2006-07-12 at 16:15 -0500, Venkat Yekkirala wrote: This automatically labels the TCP, Unix stream, and dccp child sockets as well as openreqs to be at the same MLS level as the peer. Signed-off-by: Venkat Yekkirala [EMAIL PROTECTED] --- include/linux/security.h| 43

RE: [PATCH 03/10] MLSXFRM: Add security sid to sock

2006-07-13 Thread Venkat Yekkirala
Is it ever possible for the isec-sid and the sksec-sid to be inconsistent with one another? I can't think of any possibility of this happening. Could you just always return the sksec-sid here and avoid the need to grab the isec altogether (dropping the requirement for sk_callback_lock at

RE: [PATCH 08/10] MLSXFRM: Add security context to acquire messag es using PF_KEY

2006-07-13 Thread Venkat Yekkirala
+static inline void security_xfrm_skb_secid(struct sk_buff *skb, u32 *secid) { - return security_ops-xfrm_decode_session(skb, fl); + BUG_ON(security_ops-xfrm_decode_session(skb, secid, 0)); BUG_ON looks wrong here, in that you don't know why the LSM returned an error, and

RE: [PATCH 08/10] MLSXFRM: Add security context to acquire messag es using PF_KEY

2006-07-13 Thread James Morris
On Thu, 13 Jul 2006, Venkat Yekkirala wrote: +static inline void security_xfrm_skb_secid(struct sk_buff *skb, u32 *secid) { - return security_ops-xfrm_decode_session(skb, fl); + BUG_ON(security_ops-xfrm_decode_session(skb, secid, 0)); BUG_ON looks wrong here, in that you

Re: [PATCH 08/10] MLSXFRM: Add security context to acquire messages using PF_KEY

2006-07-13 Thread James Morris
On Wed, 12 Jul 2006, Venkat Yekkirala wrote: This labels the flows that could utilize IPSec xfrms at the points they are defined so that IPSec policy and SAs at the right label can be used. The following protos are currently not handled, but they should continue to be able to use

[PATCH] zd1211rw: Implement SIOCGIWNICKN

2006-07-13 Thread Daniel Drake
wireless.h discourages using SIOCGIWNAME to publish the driver name which the interface belongs to. Use SIOCGIWNICKN instead. Signed-off-by: Daniel Drake [EMAIL PROTECTED] diff --git a/drivers/net/wireless/zd1211rw/zd_netdev.c b/drivers/net/wireless/zd1211rw/zd_netdev.c index 9df232c..440ef24

RE: FW: + qla3xxx-is-bust.patch added to -mm tree

2006-07-13 Thread Ron Mercer
Jeff, Regarding your June 22nd post: 14) Surely there is a better way to down the adapter than masking the interrupts and resetting the adapter? If this is ever used in non-MSI situations (common in Linux today), there is the possibility of screaming interrupts, in shared-interrupt

Re: FW: + qla3xxx-is-bust.patch added to -mm tree

2006-07-13 Thread Jeff Garzik
Ron Mercer wrote: Jeff, Regarding your June 22nd post: 14) Surely there is a better way to down the adapter than masking the interrupts and resetting the adapter? If this is ever used in non-MSI situations (common in Linux today), there is the possibility of screaming interrupts, in

Re: [SLHC 3/4] Remove useless casts

2006-07-13 Thread Christoph Hellwig
On Thu, Jul 13, 2006 at 12:12:53PM +0100, Ralf Baechle wrote: Signed-off-by: Ralf Baechle [EMAIL PROTECTED] oops, foget my previous mail :) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [SLHC 2/4] Convert to kzalloc

2006-07-13 Thread Christoph Hellwig
On Thu, Jul 13, 2006 at 12:10:48PM +0100, Ralf Baechle wrote: Signed-off-by: Ralf Baechle [EMAIL PROTECTED] at the same time please remove the useless casts of the kmalloc/kzalloc return value. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

RE: [PATCH]NET: Add ECN support for TSO

2006-07-13 Thread Ravinandan Arakali
Dave/Michael, Replicating NS bit(from super segment) across all segments looks fine. But one of the issues is the random/pseudo-random generation of ECT code points on each of these segments. The hardware will need to be capable of generating this, and I guess should be able to verify this

Re: [DOC]: generic netlink

2006-07-13 Thread Randy.Dunlap
On Mon, 19 Jun 2006 09:41:22 -0400 jamal wrote: Folks, Attached is a document that should help people wishing to use generic netlink interface. It is a WIP so a lot more to go if i see interest. Hi, I have a few random questions about gen-netlink. 1. Provider IDs (numbers) and names

RE: FW: + qla3xxx-is-bust.patch added to -mm tree

2006-07-13 Thread Ron Mercer
Freeing a kernel interrupt reservation does not imply that your hardware has stopped delivering them... in a shared interrupt situation, the code sequence free_irq() perform some action could cause the kernel to call _another_ driver's interrupt handling routine over

Re: e1000 fails to load sometimes: The EEPROM Checksum Is Not Valid

2006-07-13 Thread Auke Kok
With 2.6.17-rc5-mm2 (and other kernels), the e1000 fails to load sometimes, with the message: Intel(R) PRO/1000 Network Driver - version 7.0.38-k4-NAPI Copyright (c) 1999-2006 Intel Corporation. ACPI: PCI Interrupt :02:00.0[A] - GSI 16 (level, low) - IRQ 20 PCI: Setting latency timer

Re: [PATCH]NET: Add ECN support for TSO

2006-07-13 Thread Michael Chan
Ravinandan Arakali wrote: But one of the issues is the random/pseudo-random generation of ECT code points on each of these segments. My take is that the ECT code point should also be replicated on all TSO segments. When RFC3540 is implemented, the stack will randomly use ECT(0) or ECT(1) on

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-13 Thread Christoph Hellwig
On Sat, Jul 08, 2006 at 01:37:38PM -0700, David Miller wrote: My plan is to give dev_alloc_skb a struct netdevice * argument and introduce a alloc_netdev_node so the driver can tell what node the device is on. This gives a significant speedup for cell. I already have this implemented in

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-13 Thread Randy.Dunlap
On Thu, 13 Jul 2006 22:36:16 +0200 Christoph Hellwig wrote: ... I gave converting the dev_alloc_skb prototype everywhere a spin and it doesn't look too bad. There's only a few places that don't have a netdevice at hand, and all these look bogus: ... -

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-13 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 22:36:16 +0200 - drivers/atm/{idt77252.c, nicstar.c}, drivers/usb/atm/usbatm.c: These use private skb queues and do odd things. I can't see any point for using dev_alloc_skb with it's additional headroom

Re: e1000 fails to load sometimes: The EEPROM Checksum Is Not Valid

2006-07-13 Thread Jeremy Fitzhardinge
Auke Kok wrote: Sorry for the long wait, there's some new information on this that just this morning arrived. Thanks for the update. The latest EEPROM's from Lenovo (obtainable from their websites as .iso) seem to have this feature turned off, which resolves the issue. Do you have a

Re: e1000 fails to load sometimes: The EEPROM Checksum Is Not Valid

2006-07-13 Thread Auke Kok
Jeremy Fitzhardinge wrote: Auke Kok wrote: Sorry for the long wait, there's some new information on this that just this morning arrived. Thanks for the update. The latest EEPROM's from Lenovo (obtainable from their websites as .iso) seem to have this feature turned off, which resolves the

Re: e1000 fails to load sometimes: The EEPROM Checksum Is Not Valid

2006-07-13 Thread Jeremy Fitzhardinge
Auke Kok wrote: See: http://www-307.ibm.com/pc/support/site.wss/document.do?lndocid=MIGR-63027 links to the latest .iso image. Note: I haven't tried the 1.07 update myself. I had to *downgrade* our test system to actually expose the bug. This appears to be a link to the T60 1.06 update. Do

Re: e1000 fails to load sometimes: The EEPROM Checksum Is Not Valid

2006-07-13 Thread Auke Kok
Jeremy Fitzhardinge wrote: Auke Kok wrote: See: http://www-307.ibm.com/pc/support/site.wss/document.do?lndocid=MIGR-63027 links to the latest .iso image. Note: I haven't tried the 1.07 update myself. I had to *downgrade* our test system to actually expose the bug. This appears to be a link

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-13 Thread Stephen Hemminger
On Thu, 13 Jul 2006 22:36:16 +0200 Christoph Hellwig [EMAIL PROTECTED] wrote: On Sat, Jul 08, 2006 at 01:37:38PM -0700, David Miller wrote: My plan is to give dev_alloc_skb a struct netdevice * argument and introduce a alloc_netdev_node so the driver can tell what node the device is on.

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-13 Thread Christoph Hellwig
What's the new name? For sanity, don't reuse the name dev_alloc_skb. dev_alloc_skb. It's the by far sanest name for it, while the old usage without dev argument was misleading. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [Bugme-new] [Bug 6830] New: Need a /proc to view IF-MIB counters not in /proc/net/dev

2006-07-13 Thread Andrew Morton
Bugzilla is not the appropriate way to handle this. Please send a diff prepared as per http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt to netdev@vger.kernel.org and cc myself, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: e1000 fails to load sometimes: The EEPROM Checksum Is Not Valid

2006-07-13 Thread Jeremy Fitzhardinge
Auke Kok wrote: x60 bios upgrade 1.06 is here: (found by typing x60 bios in the search bar on the same website) http://www-307.ibm.com/pc/support/site.wss/license.do?filename=mobiles/7buj04uc.iso unfortunately the changelog for this BIOS upgrade doesn't tell us much if the DSPD feature

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-13 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 23:29:19 +0200 What's the new name? For sanity, don't reuse the name dev_alloc_skb. dev_alloc_skb. It's the by far sanest name for it, while the old usage without dev argument was misleading. As much as I would like to make

RE: [PATCH 08/10] MLSXFRM: Add security context to acquire messag es using PF_KEY

2006-07-13 Thread Venkat Yekkirala
This seems problematic in that it's not a general solution and depends always on hooking in at all of the right places in every protocol. Adding a bunch of hooks to protocol-specific code is what got us in trouble with the initial LSM submission. What about using secmark and

Re: [PATCH 2/2] correct dev_alloc_skb kerneldoc

2006-07-13 Thread Samuel Ortiz
On Thu, Jul 13, 2006 at 10:36:16PM +0200, Christoph Hellwig wrote: - net/irda/*: They allocate the skb in protocol code for TX. Should probably do a normal alloc_skb like all the other protocol code. Agreed. I will come up with a patch replacing all the useless dev_alloc_skb()

Re: [NET]: Update frag_list in pskb_trim

2006-07-13 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 19:03:41 +1000 [NET]: Update frag_list in pskb_trim When pskb_trim has to defer to ___pksb_trim to trim the frag_list part of the packet, the frag_list is not updated to reflect the trimming. This will usually work fine until you

Re: [PATCH] WAN: converting generic HDLC to use netif_dormant*()

2006-07-13 Thread Andrew Morton
On Wed, 12 Jul 2006 13:46:32 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Krzysztof Halasa [EMAIL PROTECTED] Date: Tue, 11 Jul 2006 23:18:45 +0200 This patch converts generic HDLC (and WAN drivers using it) from hdlc_set_carrier() to netif_dormant*() interface. WAN hardware

Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-13 Thread Dan Williams
On Tue, 2006-07-11 at 23:03 -0500, Larry Finger wrote: Dan Williams wrote: NAK... remember, range-max_qual.level must be _0_ if you're in dBm, I do not think this is right. From the comments in include/linux/wireless.h: /* Quality of link SNR stuff */ /* Quality

Re: [PATCH] WAN: converting generic HDLC to use netif_dormant*()

2006-07-13 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 19:45:04 -0700 On Wed, 12 Jul 2006 13:46:32 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Krzysztof Halasa [EMAIL PROTECTED] Date: Tue, 11 Jul 2006 23:18:45 +0200 This patch converts generic HDLC (and WAN drivers

Re: [PATCH] bcm43xx-softmac: Further improvement in wireless statistics

2006-07-13 Thread Larry Finger
Dan Williams wrote: Jean, what's the official word on range-max_qual.level? I don't know where I came up with the requirement that max_qual.level must be 0 to indicate that the units are in dBm (as opposed to RSSI), but it might well have been because we had no way to detect RSSI vs. dBm

Re: [PATCH]NET: Add ECN support for TSO

2006-07-13 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 12:35:37 -0700 When RFC3540 is implemented, the stack will randomly use ECT(0) or ECT(1) on the TSO super segments. On each of these super segments, the hardware will replicate the ECT code point. This will keep everything

Re: [NET]: Add missing UFO initialisations

2006-07-13 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 19:11:01 +1000 [NET]: Add missing UFO initialisations This bug was unknowingly fixed the GSO patches (or rather, its effect was unknown at the time). Thanks to Marco Berizzi's persistence which is documented in the thread ipsec

Re: [NET]: Update frag_list in pskb_trim

2006-07-13 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 19:03:41 +1000 This needs to go into stable as well. In fact, there is another unrelated bug with exactly the same symptoms which was inadvertently fixed by the GSO patches. So I'll send a simpler fix for that to stable. As I noted

Re: [SLHC 1/4] Cleanup SLHC configuration

2006-07-13 Thread David Miller
From: Ralf Baechle [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 12:06:15 +0100 Convert selection of serial line header compression to use CONFIG_SLHC rather than makefile ifeq uglyness. This makes it easier to select the SLHC module from other code. Signed-off-by: Ralf Baechle [EMAIL

Re: [PATCH 08/10] MLSXFRM: Add security context to acquire messag es using PF_KEY

2006-07-13 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 11:18:32 -0400 (EDT) I'd suggest assigning the return value to a variable and asserting that, in case defines BUG_ON to nothing and the function won't be called. Not sure what kernel policy is on this (ISTR people used to worry

Re: [PATCH 08/10] MLSXFRM: Add security context to acquire messag es using PF_KEY

2006-07-13 Thread David Miller
From: Venkat Yekkirala [EMAIL PROTECTED] Date: Thu, 13 Jul 2006 10:54:14 -0400 +static inline void security_xfrm_skb_secid(struct sk_buff *skb, u32 *secid) { - return security_ops-xfrm_decode_session(skb, fl); + BUG_ON(security_ops-xfrm_decode_session(skb, secid, 0));