Big patches are fun.
These two attached patches also roll in a switch to MAC_FMT and MAC_ARG, and
use IEEE80211_DATA_LEN when possible. Otherwise, it's the same as before
except split into two patches.
Thanks,
-Michael Wu
switch-d80211-to-new-names.bz2
Description: BZip2 compressed data
On Wed, 2006-07-19 at 14:57 -0700, Stephen Hemminger wrote:
This should fix the problem reported in
http://bugzilla.kernel.org/show_bug.cgi?id=6186
where the skb is used after freed. The code in IP multicast route.
Code was reusing an skb which could lead to use after free or double free.
On Mon, Jul 24, 2006 at 11:17:08PM -0700, David Miller ([EMAIL PROTECTED])
wrote:
From: Evgeniy Polyakov [EMAIL PROTECTED]
Date: Sun, 9 Jul 2006 17:24:46 +0400
This patch includes core kevent files:
- userspace controlling
- kernelspace interfaces
- initialisation
- notification
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 18 Jul 2006 23:04:04 +1000
Actually, I plan to differentiate between RX CHECKSUM_HW and TX
CHECKSUM_HW. Now that we have things like Xen it is possible for
RX packets to have patial checksums too.
When this is done loopback can send TX
From: Guillaume Chazarain [EMAIL PROTECTED]
Date: Wed, 19 Jul 2006 14:35:15 +0200
Herbert Xu wrote :
Probably. Patches are welcome :)
Here are they, in both case I checked that the stuff to clear
was not already cleared, but I could not produce any misbehavior
by writing random junk instead
From: Evgeniy Polyakov [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 09:51:28 +0400
On Mon, Jul 24, 2006 at 03:06:13PM -0700, David Miller ([EMAIL PROTECTED])
wrote:
Furthermore, the VJ netchannel gains can be partially obtained from
generic stateless facilities that we are going to get
On Mon, Jul 24, 2006 at 11:48:53PM -0700, David Miller ([EMAIL PROTECTED])
wrote:
And if that CPU is very busy?
Linux should somehow tell NIC that some CPUs are valid and some are not
right now, but not in a second, so scheduler must be tightly bound with
network internals.
Yes, it is
John, have a look at this code in tcp_write_timeout():
mss = min(sysctl_tcp_base_mss,
tcp_mtu_to_mss(sk, icsk-icsk_mtup.search_low)/2);
mss = max(mss, 68 - tp-tcp_header_len);
That first line looks like it should be a max() instead
of a
From: Evgeniy Polyakov [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 10:59:21 +0400
As a side completely unrelated to either my or others work note :) -
I think it is a nanooptimisation - we get a bit of performance here,
and lose those bit in other place.
When bag is filled, there is no much
On Tue, Jul 25, 2006 at 12:33:44AM -0700, David Miller ([EMAIL PROTECTED])
wrote:
From: Evgeniy Polyakov [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 10:59:21 +0400
As a side completely unrelated to either my or others work note :) -
I think it is a nanooptimisation - we get a bit of
Stephen Hemminger [EMAIL PROTECTED] wrote:
@@ -1593,12 +1594,19 @@ int ipmr_get_route(struct sk_buff *skb,
read_unlock(mrt_lock);
return -ENODEV;
}
- skb-nh.raw = skb_push(skb, sizeof(struct iphdr));
-
Patrick McHardy [EMAIL PROTECTED] wrote:
[IPROUTE]: Add support for multipath route realms
Routing realms exist per nexthop, but iproute currently only allows to send
a single route realm, which is refused by the kernel for multipath routes.
Add support for specifying per nexthop realms.
Herbert Xu wrote:
Patrick McHardy [EMAIL PROTECTED] wrote:
[IPROUTE]: Add support for multipath route realms
Routing realms exist per nexthop, but iproute currently only allows to send
a single route realm, which is refused by the kernel for multipath routes.
Add support for specifying per
On Tue, Jul 25, 2006 at 06:19:33PM +1000, Herbert Xu wrote:
new kernel:
1.2.3.4
nexthop realm 1 dev dummy0 weight 1
nexthop realm 2 dev dummy1 weight 1
nexthop realm 3 dev dummy2 weight 1
nexthop realm 4 dev dummy3 weight 1
This really looks like
In-Reply-To: [EMAIL PROTECTED]
On Mon, 24 Jul 2006 12:01:48 +0400, Jim Klimov wrote:
I recently wrote about problems with a fileserver rebooting
frequently. Another similar server got under NFS load today
and rebooted at least twice in the past few hours.
This server has a similar
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
This happened several seconds after plugging in my wireless network card
- zd1211 - with the driver from http://sourceforge.net/projects/zd1211/
However.
It was after the module was loaded, when my setup script was being run
for the device - the relevant portion:
ifconfig $device:1
David Miller wrote:
John, have a look at this code in tcp_write_timeout():
mss = min(sysctl_tcp_base_mss,
tcp_mtu_to_mss(sk, icsk-icsk_mtup.search_low)/2);
mss = max(mss, 68 - tp-tcp_header_len);
That first line looks like it should be
-- Forwarded message --
Date: Tue, 25 Jul 2006 16:38:05 +0900
From: [EMAIL PROTECTED]
To: linux-kernel@vger.kernel.org
Subject: [PATCH][IPv4/IPv6] Setting 0 for unused port field.
Hello.
The recvmsg() for raw socket seems to return random u16 value
from the kernel stack memory
In article [EMAIL PROTECTED] (at Tue, 25 Jul 2006 10:45:51 -0400 (EDT)),
James Morris [EMAIL PROTECTED] says:
The recvmsg() for raw socket seems to return random u16 value
from the kernel stack memory since port field is not initialized.
But I'm not sure this patch is correct.
Does raw
On Tue, Jul 25, 2006 at 05:15:04PM +0200, Tomasz Torcz ([EMAIL PROTECTED])
wrote:
BUG: warning at net/core/dev.c:1171/skb_checksum_help()
[c010374a] show_trace_log_lvl+0x51/0xe6
[c01037e9] show_trace+0xa/0xc
[c01038b4] dump_stack+0x13/0x15
[c02b41c4] skb_checksum_help+0x4d/0xeb
On Tue, 2006-07-25 at 17:39 +1000, Herbert Xu wrote:
Steve Wise [EMAIL PROTECTED] wrote:
Routing redirect events are broadcast as a pair of rtmsgs, RTM_DELROUTE
and RTM_NEWROUTE.
This may confuse existing rtnetlink users since you're generating an
RTM_DELROUTE message that's identical
During a Power Management session at the Ottawa Linux Symposium, it was
generally agreed that network interface drivers ought to automatically
suspend their devices (if possible) whenever:
(1) The interface is ifconfig'ed down, or
(2) No link is available.
Presumably (1) should be easy
Hello!
Code was reusing an skb which could lead to use after free or double free.
No, this does not help. The bug is not here.
I was so ashamed of this that could not touch the thing. :-)
It startled me a lot, how is it possible that the thing was in production
for several years and such bad
IP multicast route code was reusing an skb which causes
use after free and double free.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
net/ipv4/ipmr.c | 22 --
1 files changed, 16 insertions(+), 6 deletions(-)
diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c
index
David Miller wrote:
From: Rick Jones [EMAIL PROTECTED]
Date: Mon, 24 Jul 2006 17:55:24 -0700
Even enough bits for 1024 or 2048 CPUs in the single system image? I have seen
1024 touted by SGI, and with things going so multi-core, perhaps 16384 while
sounding initially bizzare would be in the
It may be a hardware interpretation, but doesn't it have non-trivial system
implications - where one runs threads/processes etc?
Only if you do process context RX processing. If you chose not to it doesn't
have much influence.
-Andi
-
To unsubscribe from this list: send the line unsubscribe
On Tue, 25 Jul 2006 20:20:01 +0400
Alexey Kuznetsov [EMAIL PROTECTED] wrote:
Hello!
Code was reusing an skb which could lead to use after free or double free.
No, this does not help. The bug is not here.
I was so ashamed of this that could not touch the thing. :-)
It startled me a
Alan Stern wrote:
During a Power Management session at the Ottawa Linux Symposium, it was
generally agreed that network interface drivers ought to automatically
suspend their devices (if possible) whenever:
(1) The interface is ifconfig'ed down, or
(2) No link is available.
Presumably
Hello!
checking tools because the skb lifetime depends on the return value.
Wouldn't it be better to have a consistent interface (skb always freed),
and clone the skb if needed for deferred processing?
But skb is not always freed in any case.
Normally it is submitted to netlink_unicast(). It
On Tuesday 25 July 2006 8:59 am, Alan Stern wrote:
During a Power Management session at the Ottawa Linux Symposium, it was
generally agreed that network interface drivers ought to automatically
suspend their devices (if possible) whenever:
(1) The interface is ifconfig'ed down, or
On Tue, 25 Jul 2006 00:52:25 -0400
Pavel Roskin [EMAIL PROTECTED] wrote:
Hello!
gregkh-driver-network-class_device-to-device.patch, which briefly
appeared in Linux 2.6.18-rc1-mm1 broke MadWifi, which is copying the
physical device information from the master network device to the
virtual
Hello!
Wouldn't it be better to have a consistent interface (skb always freed),
and clone the skb if needed for deferred processing?
I am sorry, I misunderstood you. I absolutely agree. It is much better,
the variant which I suggested is a good sample of bad programming. :-)
Alexey
-
To
The http://linux-net.osdl.org/index.php/Main_Page website I mean.
--
--
Christophe Devriese EURiD
Network Adminstrator / Developer
[EMAIL PROTECTED]
---
On Mon, 2006-07-24 at 15:23 -0700, David Miller wrote:
From: Tom Tucker [EMAIL PROTECTED]
Date: Wed, 05 Jul 2006 12:09:42 -0500
A TOE net stack is closed source firmware. Linux engineers have no way
to fix security issues that arise. As a result, only non-TOE users will
receive security
Hi,
I am new to the mailing list so I'm not sure if anybody reads these, but
here goes nothing. I recently read: Linux Advanced Routing Traffic
Control HOWTO and have been trying to test my applications using
bandwidth limitation. All the examples described in the HOWTO do not
simulate the
On 7/26/06, Christophe Devriese [EMAIL PROTECTED] wrote:
The http://linux-net.osdl.org/index.php/Main_Page website I mean.
It's a Wiki so anybody can alter content on the website. The exception
to this is that particular page - the main page. If you want something
altered on that particular
On 7/26/06, Piotrowski, Ted P. [EMAIL PROTECTED] wrote:
Hi,
I am new to the mailing list so I'm not sure if anybody reads these, but
here goes nothing. I recently read: Linux Advanced Routing Traffic
Control HOWTO and have been trying to test my applications using
bandwidth limitation. All the
Hi,
I am new to the mailing list so I'm not sure if anybody reads these, but
here goes nothing. I recently read: Linux Advanced Routing Traffic
Control HOWTO and have been trying to test my applications using
bandwidth limitation. All the examples described in the HOWTO do not
simulate the
Hello, Stephen!
On Tue, 2006-07-25 at 10:20 -0700, Stephen Hemminger wrote:
So how about these wrappers.
+static inline void netdev_set_pdev(struct net_device *dev, struct device
*pdev)
+{
+ dev-class_dev.dev = pdev;
+}
+
+static inline struct device *netdev_get_pdev(struct
Hello!
Wouldn't it be better to have a consistent interface (skb always freed),
and clone the skb if needed for deferred processing?
I think you mean this.
Note, it is real skb_clone(), not alloc_skb(). Equeued skb contains
the whole half-prepared netlink message plus room for the rest.
It
On Tue, 25 Jul 2006 17:08:11 -0400
Pavel Roskin [EMAIL PROTECTED] wrote:
Hello, Stephen!
On Tue, 2006-07-25 at 10:20 -0700, Stephen Hemminger wrote:
So how about these wrappers.
+static inline void netdev_set_pdev(struct net_device *dev, struct device
*pdev)
+{
+
On Wed, 26 Jul 2006 01:17:25 +0400
Alexey Kuznetsov [EMAIL PROTECTED] wrote:
Hello!
Wouldn't it be better to have a consistent interface (skb always freed),
and clone the skb if needed for deferred processing?
I think you mean this.
Note, it is real skb_clone(), not alloc_skb().
On Tue, Jul 25, 2006 at 10:20:05AM -0700, Stephen Hemminger wrote:
On Tue, 25 Jul 2006 00:52:25 -0400
Pavel Roskin [EMAIL PROTECTED] wrote:
Hello!
gregkh-driver-network-class_device-to-device.patch, which briefly
appeared in Linux 2.6.18-rc1-mm1 broke MadWifi, which is copying the
From: John Heffner [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 09:56:38 -0400
David Miller wrote:
John, have a look at this code in tcp_write_timeout():
mss = min(sysctl_tcp_base_mss,
tcp_mtu_to_mss(sk, icsk-icsk_mtup.search_low)/2);
mss =
On Tue, 2006-07-25 at 14:26 -0700, Stephen Hemminger wrote:
On Tue, 25 Jul 2006 17:08:11 -0400
Pavel Roskin [EMAIL PROTECTED] wrote:
Considering the drivers that are already in the kernel, you may prefer
to have a more high-level function that would clone the network device
by copying most
Prevent phylib from freeing PHY IRQ twice on closing an eth device:
phy_disconnect() first calls phy_stop_interrupts(), then it calls
phy_stop_machine() which in turn calls phy_stop_interrupts() making the
kernel complain on each bootup...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
From: Ulrich Drepper [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 12:23:53 -0700
I was very much surprised by the reactions I got after my OLS talk.
Lots of people declared interest and even agreed with the approach and
asked me to do further ahead with all this. For those who missed it,
the
On Tue, 2006-07-25 at 15:01 -0700, David Miller wrote:
From: Ulrich Drepper [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 12:23:53 -0700
I was very much surprised by the reactions I got after my OLS talk.
Lots of people declared interest and even agreed with the approach and
asked me to do
Handle dev_alloc_skb() failures when initializing the RX rings.
Without proper handling, the driver will crash when using a partial
ring.
Thanks to Stephane Doyon [EMAIL PROTECTED] for reporting the bug and
providing the initial patch.
Howie Xu [EMAIL PROTECTED] also reported the same issue.
Update version to 3.63.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index d66b06f..1b8138f 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -68,8 +68,8 @@
#define DRV_MODULE_NAMEtg3
#define PFX DRV_MODULE_NAME
Add tg3_restart_hw() to handle failures when re-initializing the
device.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index ce6f3be..1253cec 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -3590,6 +3590,28 @@ static irqreturn_t
From: Michael Chan [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 15:56:13 -0700
Add tg3_restart_hw() to handle failures when re-initializing the
device.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
Applied, thanks Michael.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the
From: Michael Chan [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 15:56:26 -0700
Update version to 3.63.
Signed-off-by: Michael Chan [EMAIL PROTECTED]
Also applied, thanks again.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More
From: Michael Chan [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 15:56:20 -0700
Handle dev_alloc_skb() failures when initializing the RX rings.
Without proper handling, the driver will crash when using a partial
ring.
Thanks to Stephane Doyon [EMAIL PROTECTED] for reporting the bug and
From: YOSHIFUJI Hideaki [EMAIL PROTECTED]
Date: Tue, 25 Jul 2006 23:53:40 +0900 (JST)
In article [EMAIL PROTECTED] (at Tue, 25 Jul 2006 10:45:51 -0400 (EDT)),
James Morris [EMAIL PROTECTED] says:
The recvmsg() for raw socket seems to return random u16 value
from the kernel stack memory
From: Kelly Daly [EMAIL PROTECTED]
Date: Tue, 11 Jul 2006 16:17:56 +1000
Implement finding of correct netchannel for buffer, default netchannel and
attach a netchannel to a socket
Signed-off-by: Kelly Daly [EMAIL PROTECTED]
Kelly, I want to apply this, but your email client has busted up
Tetsuo-san can you please use a correct From: field in your patch
postings? Thank you.
This will allow me to form a correct attribution when I apply your
patches in the future.
This time I had to perform a lengthy web search to find who is behind
these strange [EMAIL PROTECTED] email addresses
David Miller wrote:
I find it interesting that black hole detection is handled
different from a normal probe failure. I guess here we are
dealing with a more significant failure, so we should start
at the thing which is most guarenteed to work.
Black hole detection is substantially different
Alexey Kuznetsov [EMAIL PROTECTED] wrote:
I think you mean this.
Note, it is real skb_clone(), not alloc_skb(). Equeued skb contains
the whole half-prepared netlink message plus room for the rest.
It could be also skb_copy(), if we want to be puristic about mangling
cloned data, but
Herbert Xu wrote:
Evgeniy Polyakov [EMAIL PROTECTED] wrote:
It is not a bug, but remind to update nat helper function.
Yes, I need to add CHECKSUM_COMPLETE vs. CHECKSUM_PARTIAL first so that
we actually know which is which in NAT.
I have a patch which changes netfilter to do incremental
Hi Ron,
The qla3xxx driver is in the -mm tree.
For the mainline inclusion, Jeff seems ready to accept the driver:
http://marc.theaimsgroup.com/?l=linux-netdevm=115334172810775w=2
Just wondering if the qla3xxx driver is in the mainline yet?
(I am curious to have some performance comparison of
Hi Patrick:
On Wed, Jul 26, 2006 at 05:38:07AM +0200, Patrick McHardy wrote:
I have a patch which changes netfilter to do incremental checksumming.
The hook number is passed to all functions doing this so they know
how to update the checksum. Could you explain how
Herbert Xu wrote:
Hi Patrick:
On Wed, Jul 26, 2006 at 05:38:07AM +0200, Patrick McHardy wrote:
I have a patch which changes netfilter to do incremental checksumming.
The hook number is passed to all functions doing this so they know
how to update the checksum. Could you explain how
On Tue, Jul 25, 2006 at 10:05:40AM -0500, Steve Wise wrote:
But they really are seeing a delete followed by an add. That's what the
kernel is doing.
Actually that's the other thing I don't really like. The user-space
monitor may perceive that a route was actually deleted and replaced
by a
On Wed, Jul 26, 2006 at 06:01:40AM +0200, Patrick McHardy wrote:
Please send it, I'll update my patch based on that. Thanks.
Here it is, it sits on top of
commit ca6bb5d7ab22ac79f608fe6cbc6b12de6a5a19f0
Author: David Woodhouse [EMAIL PROTECTED]
Date: Thu Jun 22 16:07:52 2006 -0700
66 matches
Mail list logo
