Re: [PATCH] kthread: airo.c

2006-07-26 Thread Andrew Morton
On Mon, 24 Jul 2006 11:13:09 -0700 Sukadev Bhattiprolu [EMAIL PROTECTED] wrote: Sukadev Bhattiprolu [EMAIL PROTECTED] wrote: | Andrew, | | Javier Achirica, one of the major contributors to drivers/net/wireless/airo.c | took a look at this patch, and doesn't have any problems with it. It

Re: async network I/O, event channels, etc

2006-07-26 Thread Evgeniy Polyakov
On Tue, Jul 25, 2006 at 03:01:22PM -0700, David Miller ([EMAIL PROTECTED]) wrote: From: Ulrich Drepper [EMAIL PROTECTED] Date: Tue, 25 Jul 2006 12:23:53 -0700 I was very much surprised by the reactions I got after my OLS talk. Lots of people declared interest and even agreed with the

[BUG] stacktrace from skb_checksum_help() and skb_gso_segment()

2006-07-26 Thread Rolf Eike Beer
linux-2.6 git tree from yesterday. Before this the sky2 network driver was working. After a pseudo hotplug of the device it was working again (at least if you receive this mail *g*). What next? Eike Jul 26 08:22:51 siso-eb-i34d kernel: BUG: warning at

Re: [BUG] stacktrace from skb_checksum_help() and skb_gso_segment()

2006-07-26 Thread Evgeniy Polyakov
On Wed, Jul 26, 2006 at 08:41:48AM +0200, Rolf Eike Beer ([EMAIL PROTECTED]) wrote: linux-2.6 git tree from yesterday. Before this the sky2 network driver was working. After a pseudo hotplug of the device it was working again (at least if you receive this mail *g*). What next? It is

Re: [BUG] stacktrace from skb_checksum_help() and skb_gso_segment()

2006-07-26 Thread Rolf Eike Beer
Am Mittwoch, 26. Juli 2006 08:44 schrieb Evgeniy Polyakov: On Wed, Jul 26, 2006 at 08:41:48AM +0200, Rolf Eike Beer ([EMAIL PROTECTED]) wrote: linux-2.6 git tree from yesterday. Before this the sky2 network driver was working. After a pseudo hotplug of the device it was working again (at

Re: [PATCH 1/2] remove CONFIG_HAVE_ARCH_DEV_ALLOC_SKB

2006-07-26 Thread Christoph Hellwig
On Mon, Jul 24, 2006 at 03:44:15PM -0700, Roland Dreier wrote: skbuff.h has an #ifndef CONFIG_HAVE_ARCH_DEV_ALLOC_SKB to allow architectures to reimplement __dev_alloc_skb. It's not set on any architecture and now that we have an architecture-overrideable NET_SKB_PAD there is not point at

Re: Who maintains the website ?

2006-07-26 Thread Christophe Devriese
I would like to have a VLAN page on the main page, so that I can update it a bit with relevant info, and then include the link to the external site as it's basically a here is a patch, here is a usage page, while an explanation of the different stuff would be nice (such as the forwarding path, the

Re: Who maintains the website ?

2006-07-26 Thread Ian McDonald
On 7/26/06, Christophe Devriese [EMAIL PROTECTED] wrote: I would like to have a VLAN page on the main page, so that I can update it a bit with relevant info, and then include the link to the external site as it's basically a here is a patch, here is a usage page, while an explanation of the

[4/4] kevent: poll/select() notifications. Timer notifications.

2006-07-26 Thread Evgeniy Polyakov
This patch includes generic poll/select and timer notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake). Timer notifications can be used for fine grained per-process time

[3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Evgeniy Polyakov
This patch includes asynchronous propagation of file's data into VFS cache and aio_sendfile() implementation. Network aio_sendfile() works lazily - it asynchronously populates pages into the VFS cache (which can be used for various tricks with adaptive readahead) and then uses usual -sendfile()

[0/4] kevent: generic event processing subsystem.

2006-07-26 Thread Evgeniy Polyakov
Kevent subsystem incorporates several AIO/kqueue design notes and ideas. Kevent can be used both for edge and level notifications. It supports socket notifications (accept, send, recv), network AIO (aio_send(), aio_recv() and aio_sendfile()), inode notifications (create/remove), generic

[2/4] kevent: network AIO, socket notifications.

2006-07-26 Thread Evgeniy Polyakov
This patchset includes socket notifications and network asynchronous IO. Network AIO is based on kevent and works as usual kevent storage on top of inode. When new socket is created it is associated with inode (to save some space, since inode already has kevent_storage embedded) and when some

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Christoph Hellwig
On Wed, Jul 26, 2006 at 01:18:15PM +0400, Evgeniy Polyakov wrote: This patch includes asynchronous propagation of file's data into VFS cache and aio_sendfile() implementation. Network aio_sendfile() works lazily - it asynchronously populates pages into the VFS cache (which can be used for

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Christoph Hellwig
On Wed, Jul 26, 2006 at 01:18:15PM +0400, Evgeniy Polyakov wrote: This patch includes asynchronous propagation of file's data into VFS cache and aio_sendfile() implementation. Network aio_sendfile() works lazily - it asynchronously populates pages into the VFS cache (which can be used for

Re: Who maintains the website ?

2006-07-26 Thread Christophe Devriese
I have created the http://linux-net.osdl.org/index.php/VLAN page. What do you think ? Regards, Christophe On Wed, Jul 26, 2006 at 08:52:52PM +1200, Ian McDonald wrote: On 7/26/06, Christophe Devriese [EMAIL PROTECTED] wrote: I would like to have a VLAN page on the main page, so that I can

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Wed, 26 Jul 2006 11:04:31 +0100 And to be honest, I don't think adding all this code is acceptable if it can't replace the existing aio code while keeping the interface. So while you interface looks pretty sane the implementation needs a lot of

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Christoph Hellwig
On Wed, Jul 26, 2006 at 02:08:49PM +0400, Evgeniy Polyakov wrote: On Wed, Jul 26, 2006 at 11:00:13AM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: struct address_space_operations ext2_aops = { + .get_block = ext2_get_block, No way in hell. For whatever you do

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Evgeniy Polyakov
On Wed, Jul 26, 2006 at 11:04:31AM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: On Wed, Jul 26, 2006 at 01:18:15PM +0400, Evgeniy Polyakov wrote: This patch includes asynchronous propagation of file's data into VFS cache and aio_sendfile() implementation. Network aio_sendfile()

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Evgeniy Polyakov
On Wed, Jul 26, 2006 at 11:13:56AM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: On Wed, Jul 26, 2006 at 02:08:49PM +0400, Evgeniy Polyakov wrote: On Wed, Jul 26, 2006 at 11:00:13AM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: struct address_space_operations ext2_aops = {

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Christoph Hellwig
On Wed, Jul 26, 2006 at 02:19:21PM +0400, Evgeniy Polyakov wrote: I stopped to work on AIO, since neither existing, nor mine implementation were able to outperform sync speeds (one of the major problems in my implementation is get_user_pages() overhead, which can be completely eliminated with

Re: [1/4] kevent: core files.

2006-07-26 Thread Andrew Morton
On Wed, 26 Jul 2006 13:18:15 +0400 Evgeniy Polyakov [EMAIL PROTECTED] wrote: +static int kevent_ctl_process(struct file *file, + struct kevent_user_control *ctl, void __user *arg) +{ + int err; + struct kevent_user *u = file-private_data; + + if (!u) +

Re: [1/4] kevent: core files.

2006-07-26 Thread Evgeniy Polyakov
On Wed, Jul 26, 2006 at 03:31:05AM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: Please indent the body of the switch one tabstop to the left. .. If the user passes this an fd which was obtained via means other than kevent_ctl_init(), the kernel will explode. Do if (file-f_fop !=

[PATCH 1/3] add netdev_alloc_skb

2006-07-26 Thread Christoph Hellwig
Add a dev_alloc_skb variant that takes a struct net_device * paramater. For now that paramater is unused, but I'll use it to allocate the skb from node-local memory in a follow-up patch. Also there have been some other plans mentioned on the list that can use it. Signed-off-by: Christoph

[PATCH 3/3] deprecate dev_alloc_skb

2006-07-26 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/include/linux/skbuff.h === --- linux-2.6.orig/include/linux/skbuff.h 2006-07-26 12:06:12.0 +0200 +++ linux-2.6/include/linux/skbuff.h2006-07-26

[IPROUTE2]: documentation bug fix on mirred

2006-07-26 Thread Jamal Hadi Salim
Stephen, Heres another on top of the others i sent. If you get the time, can update your git tree with these patches? If you are planning to make a release soon, please ping me - I have at least one more patch that i need to work on. cheers, jamal Update mirred usage to fix a bug noticed by

Re: Is the qla3xxx driver in the mainline?

2006-07-26 Thread Michael Tokarev
Albert Lee wrote: [] (I am curious to have some performance comparison of qla3xxx + open iscsi v.s. qla4xxx + on board TOE/iscsi.) On wich card? I've been told that IPS4010 for example isn't supported by qla3xxx. BTW, I found qla4xxx (on IPS4010) performs noticeable worse than open-iscsi

Re: [PATCH] ip multicast route bug fix

2006-07-26 Thread Alexey Kuznetsov
HellO! I like this. However, since the cloned skb is either discarded in case of error, or queued in which case the caller discards its reference right away, wouldn't it be simpler to just do this? Well, if we wanted just to cheat those checking tools, it is nice. But if we want clarity, it

Bonding active-backup issue.

2006-07-26 Thread Christophe Devriese
If I implement a patch taking an unused flag and implementing IFF_SILENT, in order to fix incorrect bonding active-backup behavior, will it get accepted ? If not, what can I do ? -- --- Christophe Devriese

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Avi Kivity
David Miller wrote: From: Christoph Hellwig [EMAIL PROTECTED] Date: Wed, 26 Jul 2006 11:04:31 +0100 And to be honest, I don't think adding all this code is acceptable if it can't replace the existing aio code while keeping the interface. So while you interface looks pretty sane the

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Ulrich Drepper
Christoph Hellwig wrote: My personal opinion on existing AIO is that it is not the right design. Benjamin LaHaise agree with me (if I understood him right), I completely agree with that aswell. I agree, too, but the current code is not the last of the line. Suparna has a st of patches which

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Jiri Benc
On Mon, 24 Jul 2006 23:02:50 -0700, Michael Wu wrote: These two attached patches also roll in a switch to MAC_FMT and MAC_ARG, and use IEEE80211_DATA_LEN when possible. Otherwise, it's the same as before except split into two patches. Nice, thanks a lot. One more thing (hopefully the last

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Michael Wu
On Wednesday 26 July 2006 09:32, Jiri Benc wrote: One more thing (hopefully the last one), could you try to keep lines under 80 characters? I understand that with such long identifiers it is not always possible (it dramatically reduces readability of the code if you try to force the limit in

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Jiri Benc
On Wed, 26 Jul 2006 09:43:55 -0700, Michael Wu wrote: I still want to convert d80211_mgmt.h. Once that's done, I'll look through for those tabs/spaces long lines formatting issues. I won't mind if you start fixing some of those issues now, however. :) I just meant running some s/ {8}/\t/

Re: Who maintains the website ?

2006-07-26 Thread Stephen Hemminger
On Wed, 26 Jul 2006 12:14:01 +0200 Christophe Devriese [EMAIL PROTECTED] wrote: I have created the http://linux-net.osdl.org/index.php/VLAN page. What do you think ? I changed the mainpage VLAN to point to that. You might want to move the generic (non-linux stuff) to wikipedia.

[PATCH 6/24] RT2x00: Add TXPOWER_FROM_DEV and TXPOWER_TO_DEV macros

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Add TXPOWER_FROM_DEV and TXPOWER_TO_DEV macro's to convert the txpower values read from the eeprom to the value dscape expects, and vice versa. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 9/24] RT2x00: Don't use driver_data and driver_info fields

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] driver_info and driver_data are not required for rt2x00, neither is there any need to check that field when the probe() function is called. The PCI and USB layers already correctly make the checks. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff

[PATCH 23/24] RT2x00: Fix register initialization

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Thanks to ethtool a lot of problems with initialization of the registers has been discovered. This will correctly initialize all registers. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 21/24] RT2x00: Correctly initialize tx_status-control field before packet transmission

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] The control field inside the tx_status field of each entry should be correctly initialized when a packet is queued. We can use the same field to pass it to dscape when updating the beacon. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 19/24] RT2x00: Simplify *_reset() functions

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] The reset function can be greatly simplified. when a reset is required the best thing to do, is to switch the radio off and on again. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 17/24] RT2x00: reorganize allocation/initialization of ieee80211_hw and rt2x00

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Fix initialization of driver/hardware. Make a clear seperation between allocation and initialization. Remove the open() and stop() functions since they have been deprecated by dscape some time ago. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] ---

[PATCH 4/24] RT2x00: Add ethtool support

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Add ethtool support. At the moment we support the following features: * read driver info * read registers * read eeprom * enable and disable debug output Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 5/24] RT2x00: Clean up device specific rate value initialization

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] ieee80211_rate structure should be initialized by device_rate_entry And the creation of the device specific rate value can be optimized and made more clearer. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 18/24] RT2x00: Make suspend and resume handlers work correctly

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Fix suspend and resume handlers, they should no longer use net_dev-open() and net_dev-stop() since that delivers the wrong behaviour. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 22/24] RT2x00: Optimize config handlers

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Optimize the configuration handlers to only run when the current configuration has been changed. This means we need to store the current setting of most configuration options in rt2x00_dev. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 16/24] RT2x00: Fix rt61pci interrupt handling

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] rt61pci irq is a bit different compared to the others, when the irq is raised, we should read from the register which ring and which entry has been send. And this entry should be processed. Using a for loop to go through all entries is no longer working since

[PATCH 10/24] RT2x00: Add software and hardware sequence counting

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Add software sequence number counting to rt2400pci and rt2500pci, enable hardware sequence number counting for rt2500usb, rt61pci and rt73usb. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 8/24] RT2x00: Fix *_set_state() functions

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Fix problems with waking up the device at initialization time. The debug message should be more descriptive of the problem, when the device fails to wake up. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 7/24] RT2x00: Add RTS frame creation

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Support RTS. When rts is required, create the frame and send it out before the rest of the frames. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3 wireless-dev-txpower/drivers/net/wireless/d80211/rt2x00/rt2400pci.c

[PATCH 2/24] RT2x00: Add interface structure

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Move all settings depending on the current association into a seperate interface structure. Altough we only support 1 association type at a time, we do support multiple monitor devices, keep track of the number using the monitor_count field. Signed-off-by:

[PATCH 0/24] RT2x00

2006-07-26 Thread Ivo van Doorn
Hi, Here is a new series of patches to bring rt2x00 in wireless-dev up to date again. I am holding back 2 patches, which will be send later this week, but they are changes not only to rt2x00, so there is a chance those patches will be rejected at first. Anyway, here are the patches for rt2x00

[PATCH 24/24] RT2x00: Misc. fixes

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Misc. fixes * Compile fixes * Code style fixes previously overlooked * Better check of return values of functions Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3 wireless-dev-reginit/drivers/net/wireless/d80211/rt2x00/rt2400pci.c

[PATCH 15/24] RT2x00: Merge PCI and USB version of data_entry structure

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Merge the data_entry structure for USB and PCI into a single structure. This means that all access to the data_addr and desc_addr should now be performed through the functions: rt2x00pci_desc_addr() rt2x00pci_data_addr() And for usb: rt2x00usb_urb()

[PATCH 3/24] RT2x00: Merge rt2x00_pci and rt2x00_usb

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] rt2x00_pci and rt2x00_usb are for 99% equal, the only difference they have are not worth the duplicate code. Merge the structures into rt2x00_dev. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- http://www.mendiosus.nl/rt2x00/03_rt2x00_pciusb_dev.diff -

[PATCH 14/24] RT2x00: Check if read eeprom words are valid

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Make checks if the EEPROM data read is valid, if it is not, use the default values. Also fix the endian issue when reading the PCI_CONFIG_HEADER. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3

[PATCH 11/24] RT2x00: Move scan_work to scanning structure

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Remove scan_work from rt2x00_dev and place it in the scanning structure. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3 wireless-dev-sequence/drivers/net/wireless/d80211/rt2x00/rt2400pci.c

[PATCH 20/24] RT2x00: Use SET_NETDEV_DEV

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Use SET_NETDEV_DEV to help userspace detect the wireless interfaces. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3 wireless-dev-reset/drivers/net/wireless/d80211/rt2x00/rt2400pci.c

[PATCH 12/24] RT2x00: Add new rt73usb devices

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Add new rt73usb devices. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] --- diff -rU3 wireless-dev-scan/drivers/net/wireless/d80211/rt2x00/rt73usb.c wireless-dev-newdev/drivers/net/wireless/d80211/rt2x00/rt73usb.c ---

[PATCH 1/24] RT2x00: Style fix

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Coding style fix. * Reduce the amount of tabs in the code * Put Place function return type and function name on a single line * Replace 'u8 char counter' with 'unsigned int i' * Place '', '||' and '|' on the end of a line, instead of at the start.

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-07-26 Thread Michael Wu
On Wednesday 26 July 2006 09:53, Jiri Benc wrote: I just meant running some s/ {8}/\t/ on your patch :-) Also, I don't want to fix all of tab issues in d80211 by one big patch. I always have several patches pending (and other people probably too) and it leads to unnecessary rejects when

H/W requirements for NETIF_F_HW_CSUM

2006-07-26 Thread Ravinandan Arakali
Hello, Our current NIC does not provide the actual checksum value on receive path. Hence we only claim NETIF_F_IP_CSUM instead of the more general NETIF_F_HW_CSUM. To support this in a future adapter, we would like to know what exactly are the requirements (on both Rx and Tx )to claim

Re: [PATCH 10/24] RT2x00: Add software and hardware sequence counting

2006-07-26 Thread Ivo van Doorn
Hi, Add software sequence number counting to rt2400pci and rt2500pci, Ah, we don't support sequence numbering in d80211? Why didn't you yell at me? To be the honest the same reason as why I didn't yell about RTS, I had placed it on my todo list for d80211. ;) But due to limited time I have

Re: [PATCH 10/24] RT2x00: Add software and hardware sequence counting

2006-07-26 Thread Jiri Benc
On Wed, 26 Jul 2006 19:48:35 +0200, Ivo van Doorn wrote: To be the honest the same reason as why I didn't yell about RTS, Yes, another thing that should be in the stack. I had placed it on my todo list for d80211. ;) Please, if you encounter such thing, speak loudly so everybody interested

[RESEND PATCH 0/24] RT2x00

2006-07-26 Thread Ivo van Doorn
Hi, Here is a new series of patches to bring rt2x00 in wireless-dev up to date again. I am holding back 2 patches, which will be send later this week, but they are changes not only to rt2x00, so there is a chance those patches will be rejected at first. Anyway, here are the patches for

Re: [PATCH 2/24] RT2x00: Add interface structure

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Move all settings depending on the current association into a seperate interface structure. Altough we only support 1 association type at a time, we do support multiple monitor devices, keep track of the number using the monitor_count field. Signed-off-by:

Re: [PATCH 4/24] RT2x00: Add ethtool support

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Add ethtool support. At the moment we support the following features: * read driver info * read registers * read eeprom * enable and disable debug output Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3

Re: [PATCH 5/24] RT2x00: Clean up device specific rate value initialization

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] ieee80211_rate structure should be initialized by device_rate_entry And the creation of the device specific rate value can be optimized and made more clearer. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3

Re: [PATCH 6/24] RT2x00: Add TXPOWER_FROM_DEV and TXPOWER_TO_DEV macros

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Add TXPOWER_FROM_DEV and TXPOWER_TO_DEV macro's to convert the txpower values read from the eeprom to the value dscape expects, and vice versa. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3

Re: [PATCH 8/24] RT2x00: Fix *_set_state() functions

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Fix problems with waking up the device at initialization time. The debug message should be more descriptive of the problem, when the device fails to wake up. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3

Re: [PATCH 11/24] RT2x00: Move scan_work to scanning structure

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Remove scan_work from rt2x00_dev and place it in the scanning structure. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3 wireless-dev-sequence/drivers/net/wireless/d80211/rt2x00/rt2400pci.c

Re: [PATCH 10/24] RT2x00: Add software and hardware sequence counting

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Add software sequence number counting to rt2400pci and rt2500pci, enable hardware sequence number counting for rt2500usb, rt61pci and rt73usb. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3

Re: [PATCH 12/24] RT2x00: Add new rt73usb devices

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Add new rt73usb devices. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3 wireless-dev-scan/drivers/net/wireless/d80211/rt2x00/rt73usb.c wireless-dev-newdev/drivers/net/wireless/d80211/rt2x00/rt73usb.c ---

Re: [PATCH 14/24] RT2x00: Check if read eeprom words are valid

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Make checks if the EEPROM data read is valid, if it is not, use the default values. Also fix the endian issue when reading the PCI_CONFIG_HEADER. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3

Re: [PATCH 7/24] RT2x00: Add RTS frame creation

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Support RTS. When rts is required, create the frame and send it out before the rest of the frames. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3 wireless-dev-txpower/drivers/net/wireless/d80211/rt2x00/rt2400pci.c

Re: [PATCH 13/24] RT2x00: Allow link tuning while scanning

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] rt2x00 does not know when we are scanning, unless passive_scan() is being used. For consistent behaviour we should not block tuning while scanning. We should however not tune the connection when it has been disabled in the hardware. Signed-off-by: Ivo van

Re: [PATCH 21/24] RT2x00: Correctly initialize tx_status-control field before packet transmission

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] The control field inside the tx_status field of each entry should be correctly initialized when a packet is queued. We can use the same field to pass it to dscape when updating the beacon. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3

Re: [PATCH 22/24] RT2x00: Optimize config handlers

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Optimize the configuration handlers to only run when the current configuration has been changed. This means we need to store the current setting of most configuration options in rt2x00_dev. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3

Re: [PATCH 16/24] RT2x00: Fix rt61pci interrupt handling

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] rt61pci irq is a bit different compared to the others, when the irq is raised, we should read from the register which ring and which entry has been send. And this entry should be processed. Using a for loop to go through all entries is no longer working since

Re: [PATCH 19/24] RT2x00: Simplify *_reset() functions

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] The reset function can be greatly simplified. when a reset is required the best thing to do, is to switch the radio off and on again. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3 wireless-dev-suspend/drivers/net/wireless/d80211/rt2x00/rt2400pci.c

Re: [PATCH 24/24] RT2x00: Misc. fixes

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Misc. fixes * Compile fixes * Code style fixes previously overlooked * Better check of return values of functions Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3 wireless-dev-reginit/drivers/net/wireless/d80211/rt2x00/rt2400pci.c

Re: [PATCH 18/24] RT2x00: Make suspend and resume handlers work correctly

2006-07-26 Thread Ivo van Doorn
From Ivo van Doorn [EMAIL PROTECTED] Fix suspend and resume handlers, they should no longer use net_dev-open() and net_dev-stop() since that delivers the wrong behaviour. Signed-off-by: Ivo van Doorn [EMAIL PROTECTED] diff -rU3 wireless-dev-init/drivers/net/wireless/d80211/rt2x00/rt2400pci.c

[PATCH] via-rhine: NAPI poll enable

2006-07-26 Thread Stephen Hemminger
The poll_enable should be in init_registers before enabling interrupts, not in tx_timeout. Thanks for spotting it Roger. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/via-rhine.c 2006-07-25 13:43:19.0 -0700 +++ sky2/drivers/net/via-rhine.c

Re: H/W requirements for NETIF_F_HW_CSUM

2006-07-26 Thread Stephen Hemminger
On Wed, 26 Jul 2006 10:28:00 -0700 Ravinandan Arakali [EMAIL PROTECTED] wrote: Hello, Our current NIC does not provide the actual checksum value on receive path. Hence we only claim NETIF_F_IP_CSUM instead of the more general NETIF_F_HW_CSUM. To support this in a future adapter, we would

RE: H/W requirements for NETIF_F_HW_CSUM

2006-07-26 Thread Ravinandan Arakali
Steve, Thanks for the response. Pls see my comments below. -Original Message- From: Stephen Hemminger [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 26, 2006 12:16 PM To: [EMAIL PROTECTED] Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL

Re: [PATCH]NET: Add ECN support for TSO

2006-07-26 Thread Michael Chan
On Fri, 2006-07-14 at 12:12 -0400, Dan Reader wrote: If we implement the approach you suggest and all data sent uses TSO, the receiver can easily determine the expected codepoint of almost any isolated CE packet. It simply has to look at the segment before and the segment after (which it can

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Phillip Susi
Christoph Hellwig wrote: Networking and disk AIO have significantly different needs. Therefore, I really don't see it as reasonable to expect a merge of these two things. It doesn't make any sense. I'm not sure about that. The current aio interface isn't exactly nice for disk I/O either.

Re: RFC: kernel memory leak fix for af_unix datagram getpeersec

2006-07-26 Thread Stephen Smalley
On Wed, 2006-07-26 at 16:19 -0400, Catherine Zhang wrote: diff -puN include/net/scm.h~af_unix-datagram-getpeersec-ml-fix include/net/scm.h --- linux-2.6.18-rc2/include/net/scm.h~af_unix-datagram-getpeersec-ml-fix 2006-07-22 21:28:21.0 -0400 +++

Re: H/W requirements for NETIF_F_HW_CSUM

2006-07-26 Thread David Miller
From: Ravinandan Arakali [EMAIL PROTECTED] Date: Wed, 26 Jul 2006 12:34:28 -0700 You CANNOT use NETIF_F_HW_CSUM, when your hardware does not provide the checksum value. You must use NETIF_F_IP_CSUM. Your use of NETIF_F_HW_CSUM + CHECKSUM_UNNECESSARY is flat out incorrect. NETIF_F_HW_CSUM

Update of the r8169 branch

2006-07-26 Thread Francois Romieu
The r8169 branch at git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git has been replaced by an updated version which should correctly support the 8168 chipset given Boris and David's feedback. The previous version of the r8169 branch has been archived as r8169-20060612. The changes may

Re: [XFRM]: Fix protocol field value for outgoing IPv6 GSO packets

2006-07-26 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 25 Jul 2006 10:13:26 +1000 On Tue, Jul 25, 2006 at 02:09:26AM +0200, Patrick McHardy wrote: This appears to be a mistake, but I didn't follow the GSO stuff very closely, so there could be some non-obvious reason. Yes it definitely was a

[PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-07-26 Thread Thomas Graf
Adds the framework to support multiple IPv6 routing tables. Currently all automatically generated routes are put into the same table. This could be changed at a later point after considering the produced locking overhead. When locating routes for redirects only the main table is searched for now.

[PATCH 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-26 Thread Thomas Graf
Derived from net/ipv6/fib_rules.c Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.git/include/linux/fib_rules.h === --- /dev/null +++ net-2.6.git/include/linux/fib_rules.h @@ -0,0 +1,60 @@ +#ifndef __LINUX_FIB_RULES_H

[RFC] Multiple IPV6 Routing Tables Policy Routing

2006-07-26 Thread Thomas Graf
Hello, Thought it might be time to go through a round of comments on this work. Even though I've almost rewritten all the code the patches are based on the work found on www.mobile-ipv6.org. I have no idea which code was written by whom so just email me to get the credits right. Main differences

[PATCH 1/5] [IPV6]: Remove ndiscs rt6_lock dependency

2006-07-26 Thread Thomas Graf
(Ab)using rt6_lock wouldn't work anymore if rt6_lock is converted into a per table lock. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.git/net/ipv6/route.c === --- net-2.6.git.orig/net/ipv6/route.c +++

[PATCH 4/5] [IPV6]: Policy Routing Rules

2006-07-26 Thread Thomas Graf
Adds support for policy routing rules including a new local table for routes with a local destination. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.git/net/ipv6/fib6_rules.c === --- /dev/null +++

[PATCH 5/5] [IPV4]: Use Protocol Independant Policy Routing Rules Framework

2006-07-26 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.git/include/net/ip_fib.h === --- net-2.6.git.orig/include/net/ip_fib.h +++ net-2.6.git/include/net/ip_fib.h @@ -18,6 +18,7 @@ #include net/flow.h #include

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-26 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Wed, 26 Jul 2006 13:31:36 +0200 + * %NULL is returned in there is no free memory. Although this function + * allocates memory it can be called from an interrupt. ... + * %NULL is returned in there is no free memory. Looks like a typo in

Re: [PATCH 1/5] [IPV6]: Remove ndiscs rt6_lock dependency

2006-07-26 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Thu, 27 Jul 2006 00:00:01 +0200 (Ab)using rt6_lock wouldn't work anymore if rt6_lock is converted into a per table lock. Signed-off-by: Thomas Graf [EMAIL PROTECTED] This one looks great. Signed-off-by: David S. Miller [EMAIL PROTECTED] - To

Re: [PATCH Round 4 2/3] Core network changes to support network event notification.

2006-07-26 Thread Steve Wise
On Wed, 2006-07-26 at 13:39 +1000, Herbert Xu wrote: On Tue, Jul 25, 2006 at 10:05:40AM -0500, Steve Wise wrote: But they really are seeing a delete followed by an add. That's what the kernel is doing. Actually that's the other thing I don't really like. The user-space monitor may

Re: [PATCH Round 4 2/3] Core network changes to support network event notification.

2006-07-26 Thread David Miller
From: Steve Wise [EMAIL PROTECTED] Date: Wed, 26 Jul 2006 11:15:43 -0500 Dave, what do you think about removing the user-space stuff for the first round of integration? IE: Just add netevents and kernel hooks to generate them. Sure. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-26 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Thu, 27 Jul 2006 00:00:03 +0200 Derived from net/ipv6/fib_rules.c Signed-off-by: Thomas Graf [EMAIL PROTECTED] A very nice abstraction, looks great. Signed-off-by: David S. Miller [EMAIL PROTECTED] - To unsubscribe from this list: send the line

  1   2   >