Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Badari Pulavarty
Ulrich Drepper wrote: Christoph Hellwig wrote: My personal opinion on existing AIO is that it is not the right design. Benjamin LaHaise agree with me (if I understood him right), I completely agree with that aswell. I agree, too, but the current code is not the last of the line

Re: [PATCH Round 4 2/3] Core network changes to support network event notification.

2006-07-26 Thread Steve Wise
On Wed, 2006-07-26 at 13:39 +1000, Herbert Xu wrote: > On Tue, Jul 25, 2006 at 10:05:40AM -0500, Steve Wise wrote: > > > > But they really are seeing a delete followed by an add. That's what the > > kernel is doing. > > Actually that's the other thing I don't really like. The user-space > monit

Bonding active-backup issue.

2006-07-26 Thread Christophe Devriese
If I implement a patch taking an unused flag and implementing IFF_SILENT, in order to fix incorrect bonding active-backup behavior, will it get accepted ? If not, what can I do ? -- --- Christophe Devriese

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Ulrich Drepper
Christoph Hellwig wrote: >> My personal opinion on existing AIO is that it is not the right design. >> Benjamin LaHaise agree with me (if I understood him right), > > I completely agree with that aswell. I agree, too, but the current code is not the last of the line. Suparna has a st of patches

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Avi Kivity
David Miller wrote: From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Wed, 26 Jul 2006 11:04:31 +0100 > And to be honest, I don't think adding all this code is acceptable > if it can't replace the existing aio code while keeping the > interface. So while you interface looks pretty sane the > i

Re: [PATCH] ip multicast route bug fix

2006-07-26 Thread Alexey Kuznetsov
HellO! > I like this. However, since the cloned skb is either discarded in case > of error, or queued in which case the caller discards its reference right > away, wouldn't it be simpler to just do this? Well, if we wanted just to cheat those checking tools, it is nice. But if we want clarity, i

Re: Is the qla3xxx driver in the mainline?

2006-07-26 Thread Michael Tokarev
Albert Lee wrote: [] > (I am curious to have some performance comparison of > qla3xxx + open iscsi v.s. qla4xxx + on board TOE/iscsi.) On wich card? I've been told that IPS4010 for example isn't supported by qla3xxx. BTW, I found qla4xxx (on IPS4010) performs noticeable worse than open-iscsi sta

[IPROUTE2]: documentation bug fix on mirred

2006-07-26 Thread Jamal Hadi Salim
Stephen, Heres another on top of the others i sent. If you get the time, can update your git tree with these patches? If you are planning to make a release soon, please ping me - I have at least one more patch that i need to work on. cheers, jamal Update mirred usage to fix a bug noticed by And

[PATCH 1/3] add netdev_alloc_skb

2006-07-26 Thread Christoph Hellwig
Add a dev_alloc_skb variant that takes a struct net_device * paramater. For now that paramater is unused, but I'll use it to allocate the skb from node-local memory in a follow-up patch. Also there have been some other plans mentioned on the list that can use it. Signed-off-by: Christoph Hellwig

[PATCH 3/3] deprecate dev_alloc_skb

2006-07-26 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/include/linux/skbuff.h === --- linux-2.6.orig/include/linux/skbuff.h 2006-07-26 12:06:12.0 +0200 +++ linux-2.6/include/linux/skbuff.h2006-07-26

Re: [1/4] kevent: core files.

2006-07-26 Thread Evgeniy Polyakov
On Wed, Jul 26, 2006 at 01:18:15PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > +struct kevent *kevent_alloc(gfp_t mask) > +{ > + struct kevent *k; > + > + if (kevent_cache) > + k = kmem_cache_alloc(kevent_cache, mask); > + else > + k = kzalloc(size

Re: [1/4] kevent: core files.

2006-07-26 Thread Evgeniy Polyakov
On Wed, Jul 26, 2006 at 03:31:05AM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: > Please indent the body of the switch one tabstop to the left. .. > If the user passes this an fd which was obtained via means other than > kevent_ctl_init(), the kernel will explode. Do > > if (file->f_fop

Re: [1/4] kevent: core files.

2006-07-26 Thread Andrew Morton
On Wed, 26 Jul 2006 13:18:15 +0400 Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > +static int kevent_ctl_process(struct file *file, > + struct kevent_user_control *ctl, void __user *arg) > +{ > + int err; > + struct kevent_user *u = file->private_data; > + > + if (!u) > +

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Christoph Hellwig
On Wed, Jul 26, 2006 at 02:19:21PM +0400, Evgeniy Polyakov wrote: > I stopped to work on AIO, since neither existing, nor mine > implementation were able to outperform sync speeds (one of the major problems > in my implementation is get_user_pages() overhead, which can be > completely eliminated wi

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Evgeniy Polyakov
On Wed, Jul 26, 2006 at 11:13:56AM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > On Wed, Jul 26, 2006 at 02:08:49PM +0400, Evgeniy Polyakov wrote: > > On Wed, Jul 26, 2006 at 11:00:13AM +0100, Christoph Hellwig ([EMAIL > > PROTECTED]) wrote: > > > > struct address_space_operations ext2_a

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Evgeniy Polyakov
On Wed, Jul 26, 2006 at 11:04:31AM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > On Wed, Jul 26, 2006 at 01:18:15PM +0400, Evgeniy Polyakov wrote: > > > > This patch includes asynchronous propagation of file's data into VFS > > cache and aio_sendfile() implementation. > > Network aio_send

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Christoph Hellwig
On Wed, Jul 26, 2006 at 03:12:47AM -0700, David Miller wrote: > From: Christoph Hellwig <[EMAIL PROTECTED]> > Date: Wed, 26 Jul 2006 11:04:31 +0100 > > > And to be honest, I don't think adding all this code is acceptable > > if it can't replace the existing aio code while keeping the > > interface

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Christoph Hellwig
On Wed, Jul 26, 2006 at 02:08:49PM +0400, Evgeniy Polyakov wrote: > On Wed, Jul 26, 2006 at 11:00:13AM +0100, Christoph Hellwig ([EMAIL > PROTECTED]) wrote: > > > struct address_space_operations ext2_aops = { > > > + .get_block = ext2_get_block, > > > > No way in hell. For whatever

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Wed, 26 Jul 2006 11:04:31 +0100 > And to be honest, I don't think adding all this code is acceptable > if it can't replace the existing aio code while keeping the > interface. So while you interface looks pretty sane the > implementation needs a l

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Evgeniy Polyakov
On Wed, Jul 26, 2006 at 11:00:13AM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: > > struct address_space_operations ext2_aops = { > > + .get_block = ext2_get_block, > > No way in hell. For whatever you do please provide a interface at > the readpage/writepage/sendfile/etc

Re: Who maintains the website ?

2006-07-26 Thread Christophe Devriese
I have created the http://linux-net.osdl.org/index.php/VLAN page. What do you think ? Regards, Christophe On Wed, Jul 26, 2006 at 08:52:52PM +1200, Ian McDonald wrote: > On 7/26/06, Christophe Devriese <[EMAIL PROTECTED]> wrote: > >I would like to have a VLAN page on the main page, so that I can

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Christoph Hellwig
On Wed, Jul 26, 2006 at 01:18:15PM +0400, Evgeniy Polyakov wrote: > > This patch includes asynchronous propagation of file's data into VFS > cache and aio_sendfile() implementation. > Network aio_sendfile() works lazily - it asynchronously populates pages > into the VFS cache (which can be used fo

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Christoph Hellwig
On Wed, Jul 26, 2006 at 01:18:15PM +0400, Evgeniy Polyakov wrote: > > This patch includes asynchronous propagation of file's data into VFS > cache and aio_sendfile() implementation. > Network aio_sendfile() works lazily - it asynchronously populates pages > into the VFS cache (which can be used fo

[0/4] kevent: generic event processing subsystem.

2006-07-26 Thread Evgeniy Polyakov
Kevent subsystem incorporates several AIO/kqueue design notes and ideas. Kevent can be used both for edge and level notifications. It supports socket notifications (accept, send, recv), network AIO (aio_send(), aio_recv() and aio_sendfile()), inode notifications (create/remove), generic poll()/se

[2/4] kevent: network AIO, socket notifications.

2006-07-26 Thread Evgeniy Polyakov
This patchset includes socket notifications and network asynchronous IO. Network AIO is based on kevent and works as usual kevent storage on top of inode. When new socket is created it is associated with inode (to save some space, since inode already has kevent_storage embedded) and when some act

[4/4] kevent: poll/select() notifications. Timer notifications.

2006-07-26 Thread Evgeniy Polyakov
This patch includes generic poll/select and timer notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake). Timer notifications can be used for fine grained per-process time managemen

[3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-26 Thread Evgeniy Polyakov
This patch includes asynchronous propagation of file's data into VFS cache and aio_sendfile() implementation. Network aio_sendfile() works lazily - it asynchronously populates pages into the VFS cache (which can be used for various tricks with adaptive readahead) and then uses usual ->sendfile() c

Re: Who maintains the website ?

2006-07-26 Thread Ian McDonald
On 7/26/06, Christophe Devriese <[EMAIL PROTECTED]> wrote: I would like to have a VLAN page on the main page, so that I can update it a bit with relevant info, and then include the link to the external site as it's basically a "here is a patch, here is a usage" page, while an explanation of the d

Re: Who maintains the website ?

2006-07-26 Thread Christophe Devriese
I would like to have a VLAN page on the main page, so that I can update it a bit with relevant info, and then include the link to the external site as it's basically a "here is a patch, here is a usage" page, while an explanation of the different stuff would be nice (such as the forwarding path, th

Re: [PATCH 1/2] remove CONFIG_HAVE_ARCH_DEV_ALLOC_SKB

2006-07-26 Thread Christoph Hellwig
On Mon, Jul 24, 2006 at 03:44:15PM -0700, Roland Dreier wrote: > > skbuff.h has an #ifndef CONFIG_HAVE_ARCH_DEV_ALLOC_SKB to allow > > architectures to reimplement __dev_alloc_skb. It's not set on any > > architecture and now that we have an architecture-overrideable > > NET_SKB_PAD there is not p

<    1   2