Re: [RFC] nl80211 + packet injection with it and d80211

2006-08-21 Thread Johannes Berg
Jiri, thanks a lot for your work on nl80211! New netlink interface is one of the most important things regarding 802.11 stack now. Wait till you see my weekend patch series ;) Seems ineffective to me. Couldn't you require users of nl80211 to fill ieee80211_ptr field in all of their

Re: [RFC] nl80211 + packet injection with it and d80211

2006-08-21 Thread Johannes Berg
Another thing that crossed my mind: Should we have a netlink call for adding virtual interfaces as well? Because then, the ipw2x00 drivers can have their monitor interface(s) added the same way. johannes - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

RE: proposal for new wireless configuration API

2006-08-21 Thread Johannes Berg
On Fri, 2006-08-18 at 09:45 -0700, Simon Barber wrote: I did mean RSSI - just about anything that when interpreted as an 8 bit unsigned int and goes up with increasing signal fits the bill as an RSSI measure. RCPI requires a certain minimum accuracy and linearity (the accuracy required is not

RE: [clarification request] ieee80211_tx_control.pkt_type

2006-08-21 Thread Johannes Berg
On Fri, 2006-08-18 at 09:25 -0700, Simon Barber wrote: It might be appropriate to change it from pkt_type to a flag indicating that a timestamp should be added at TX time add_timestamp. This may well also end up being used for beacons too on hardware where the beacons are completely software

Re: proposal for new wireless configuration API

2006-08-21 Thread Johannes Berg
On Sat, 2006-08-19 at 00:02 +0200, Michael Buesch wrote: We currently know 6 different radio chips used by bcm43xx: http://bcm-specs.sipsolutions.net/RadioID AFAIK the chip is from broadcom, too. It is, and there is no datasheet. See http://johannes.sipsolutions.net/files/asus-wl100g.png

Re: [PATCH 6/6] IP100A Solve host error problem when in low performance embedded

2006-08-21 Thread Jesse Huang
Hi Jeff: (4) are you certain that DMACtrl should be read as a 32-bit register? In other code, you treat it as a 16-bit register. DMACtrl can read and write both in 16-bit and 32-bit. I will modify all of then as 32-bit. Thanks. Jesse - To unsubscribe from this list: send the line

[PATCH 00/18] d80211: various cleanups/fixes/changes

2006-08-21 Thread Johannes Berg
Here are various things that I worked on over the weekend. johannes -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 12/18] d80211: fix some sparse warnings

2006-08-21 Thread Johannes Berg
This patch fixes some warnings from sparse in d80211. Also fixes indentation in places near where the changes were. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/include/net/d80211.h 2006-08-20 17:21:26.778192788 +0200 +++ wireless-dev/include/net/d80211.h

[PATCH 03/18] d80211: pointers as extended booleans

2006-08-21 Thread Johannes Berg
Please review carefully, the task was so boring that I might have made stupid mistakes. --- This huge patch changes d80211 to treat pointers as extended booleans, using if (!ptr) and if (ptr) instead of comparisons with NULL. Signed-off-by: Johannes Berg [EMAIL PROTECTED] ---

[PATCH 11/18] d80211: clean up qdisc requeue

2006-08-21 Thread Johannes Berg
There was a comment saying: /* TODO: clean up the cases where master_hard_start_xmit * returns non 0 - it shouldn't ever do that. Once done we * can remove this function */ I noticed that master_hard_start_xmit never returns nonzero by following the paths it calls. This patch hence removes the

[PATCH 08/18] d80211: clean up exports

2006-08-21 Thread Johannes Berg
This puts all EXPORT_SYMBOL() macros along with the function being exported, and changes some exports that are only relevant to rate control modules and to be GPL-only because they rate control modules need to be built against the internal ieee80211_i.h header. Signed-off-by: Johannes Berg [EMAIL

[PATCH 07/18] d80211: get rid of sta_aid in favour of keeping track of TIM

2006-08-21 Thread Johannes Berg
I think this is not correct if a STA is removed for which packets are buffered, but if it is still wrong then that case was never correct to start with if the hw has a set_tim callback. --- This patch gets rid of the HUGE sta_aid array that was there in the access point structure and instead keeps

[PATCH 13/18] d80211: clean up some coding style issues

2006-08-21 Thread Johannes Berg
Try to reduce the coding style nits people will point out once we post integration patches. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/d80211/ieee80211.c2006-08-20 20:13:29.932819787 +0200 +++ wireless-dev/net/d80211/ieee80211.c 2006-08-20 20:32:55.212819787

[PATCH 18/18] d80211: fix some documentation

2006-08-21 Thread Johannes Berg
This patch fixes some spelling errors, typos etc. in d80211.h Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/include/net/d80211.h 2006-08-20 20:34:00.682819787 +0200 +++ wireless-dev/include/net/d80211.h 2006-08-20 20:58:32.412819787 +0200 @@ -17,7 +17,7 @@

[PATCH 15/18] d80211: surface IBSS debug

2006-08-21 Thread Johannes Berg
This patch surfaces the IBSS debug switch in Kconfig. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/d80211/Kconfig2006-08-20 17:38:37.978192788 +0200 +++ wireless-dev/net/d80211/Kconfig 2006-08-20 17:39:14.728192788 +0200 @@ -53,3 +53,9 @@ config

[PATCH 01/18] d80211: LED triggers

2006-08-21 Thread Johannes Berg
This patch makes d80211 export LED triggers for rx/tx and introduces functions to allow device drivers to query the trigger names for setting default triggers. It also cleans up the Makefile LED related stuff. Signed-off-by: Johannes Berg [EMAIL PROTECTED] ---

[PATCH 05/18] d80211: get rid of WME bitfield

2006-08-21 Thread Johannes Berg
This patch gets rid of the endian-ness dependent bitfield used for WME. It cleans up wme includes and adds some necessary includes in other files that got them implicitly through wme.h Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/d80211/wme.c 2006-08-20

[PATCH 09/18] d80211: move out rate control registration code

2006-08-21 Thread Johannes Berg
This patch moves some common rate control code from ieee80211.c into a new rate_control.c file. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/d80211/Makefile 2006-08-20 14:56:19.758192788 +0200 +++ wireless-dev/net/d80211/Makefile2006-08-20

[PATCH 17/18] d80211: surface powersave debug switch

2006-08-21 Thread Johannes Berg
This patch makes the verbose powersave debugging visible in Kconfig. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/d80211/Kconfig2006-08-20 17:41:50.828192788 +0200 +++ wireless-dev/net/d80211/Kconfig 2006-08-20 17:42:43.448192788 +0200 @@ -59,3 +59,10 @@

[PATCH 06/18] d80211: rework rate control registration

2006-08-21 Thread Johannes Berg
Contrary to what Jiri said, proper rate control module refcounting is much easier than allowing rate control changes on-the-fly... This patch implements only the former along with cleanups. Note that the diff between rate_control.c and rate_control_simple.c is small (modulo fixing indenting etc.),

[PATCH 10/18] d80211: clean up includes

2006-08-21 Thread Johannes Berg
This patch cleans up includes all over d80211. It might not be complete, but this was the best I could do without analysing it completely. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/d80211/fifo_qdisc.c 2006-08-20 14:56:19.058192788 +0200 +++

[PATCH 04/18] d80211: use kzalloc()

2006-08-21 Thread Johannes Berg
This changes d80211 to use kzalloc() where applicable. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/d80211/ieee80211.c2006-08-20 14:56:17.428192788 +0200 +++ wireless-dev/net/d80211/ieee80211.c 2006-08-20 14:56:18.438192788 +0200 @@ -454,11 +454,9 @@

[PATCH 16/18] d80211: get rid of MICHAEL_MIC_HWACCEL define

2006-08-21 Thread Johannes Berg
The symbol MICHAEL_MIC_HWACCEL is always defined and hence all the ifdefs using it are useless. This patch removes it. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/d80211/wpa.c 2006-08-20 17:32:40.058192788 +0200 +++ wireless-dev/net/d80211/wpa.c 2006-08-20

[PATCH 14/18] d80211: make lowlevel TX framedump option visible

2006-08-21 Thread Johannes Berg
This patch surfaces the lowlevel TX framedump option in Kconfig. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/d80211/Kconfig2006-08-20 17:28:47.578192788 +0200 +++ wireless-dev/net/d80211/Kconfig 2006-08-20 19:30:45.722819787 +0200 @@ -29,6 +29,19 @@

[PATCH 02/18] d80211: master link

2006-08-21 Thread Johannes Berg
This patch adds a link from the wiphy to the master device in sysfs. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- wireless-dev.orig/net/d80211/ieee80211.c2006-08-20 14:56:15.968192788 +0200 +++ wireless-dev/net/d80211/ieee80211.c 2006-08-20 14:56:16.818192788 +0200 @@ -4449,6 +4449,7

Re: [PATCH 02/18] d80211: master link

2006-08-21 Thread Johannes Berg
On Mon, 2006-08-21 at 09:41 +0200, Johannes Berg wrote: + sysfs_create_link(local-class_dev.kobj, dev-class_dev.kobj, master); Whoops, with the long line again, and then I fix it in patch 13. I suck at this ;) johannes - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [PATCH] locking bug in fib_semantics.c

2006-08-21 Thread Jarek Poplawski
On 17-08-2006 11:36, Alexey Kuznetsov wrote: Hello! [IPV4]: severe locking bug in fib_semantics.c The patch is for net-2.6.19, but the bug is present in all the kernels since yore. Found in 2.4 by Yixin Pan [EMAIL PROTECTED]. Why do we need lockdep, when sharp-sighted eyes are available?

Re: [PATCH] locking bug in fib_semantics.c

2006-08-21 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 21 Aug 2006 10:16:43 +0200 On 17-08-2006 11:36, Alexey Kuznetsov wrote: Hello! [IPV4]: severe locking bug in fib_semantics.c The patch is for net-2.6.19, but the bug is present in all the kernels since yore. Found in 2.4 by Yixin

Re: [PATCH 2.6.17 2/9] NetXen: Hardware access routines

2006-08-21 Thread Amit S. Kale
We can certainly create a table for all error messages. It'll hurt readability of code in many of the other places where printks are used to indicate some hardware error. -Amit On Friday 18 August 2006 20:46, Stephen Hemminger wrote: + if (fw_major != _NETXEN_NIC_LINUX_MAJOR) { +

Re: [PATCH 2.6.17 4/9] NetXen: intr routines and niu handling

2006-08-21 Thread Amit S. Kale
On Friday 18 August 2006 20:52, Stephen Hemminger wrote: Why keep track of statistics in one structure then copy out to net_device format? Instead just use original format. net_device structure contains unsigned long fields. netxen_port_stats contains u64 fields. rx_bytes and tx_bytes can

[PATCH] IP1000A: IC Plus update

2006-08-21 Thread Jesse Huang
Dear All: I had regenerate this patch from: git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git And, submit those modifications as one patch. From: Jesse Huang [EMAIL PROTECTED] Change Logs: - update maintainer information - remove some default phy params - remove

Bug in order of multiple IPv6 addresses per interface? Newest added one is preferred in difference to IPv4

2006-08-21 Thread Mark Smith
Hi, Sorry not to preserve the list/thread ID, I read the list via nntp/gmane, so please also CC' me directly for replies. # ip -6 addr show dev eth0 |grep -w inet6 |grep -w global inet6 2001:db8:0:1::253/64 scope global - #2 inet6 2001:db8:0:1::11/64 scope global- #1 So the

[1/1] network allocator, entirely zero-copy sniffer.

2006-08-21 Thread Evgeniy Polyakov
Hello. Attached patch implements fully zero-copy sniffer based on network allocator [1]. Userspace utlity can be found on NTA home page. Design notes. Network allocator steals pages from main system allocator and use them for all network allocations (it's benefits are behind the scope of

Re: [PATCH 5/7] ieee80211: export symbol ieee80211_api_version

2006-08-21 Thread Christoph Hellwig
On Mon, Aug 21, 2006 at 11:33:40AM +0800, Zhu Yi wrote: Export this symbol so that wireless drivers can check the running IEEE80211 API version dynamically. NACK (Or should I say no f***ing way :)). We don't export runtime subsystem versions, especially as they are totally useless already.

Re: [PATCH 06/14] ipw2100: Make ipw2100 depends on known working platforms

2006-08-21 Thread Christoph Hellwig
On Mon, Aug 21, 2006 at 11:37:49AM +0800, Zhu Yi wrote: ipw2100 driver doesn't support big endian by now. NACK. Fix it instead. tristate Intel PRO/Wireless 2100 Network Connection - depends on NET_RADIO PCI + depends on NET_RADIO PCI (X86 || X86_64 || IA64 || BROKEN)

Re: [PATCH 2.6.17 2/9] NetXen: Hardware access routines (name prefixed)

2006-08-21 Thread Pradeep Dalvi
diff -u linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c --- linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c 2006-08-17 07:12:34.0 -0700 +++ linux-2.6.17/drivers/net/netxen/netxen_nic_hw.c 2006-08-21 02:20:00.0 -0700 @@

Re: [PATCH 2.6.17 1/9] NetXen: Makefile and driver main file (name prefix change)

2006-08-21 Thread Pradeep Dalvi
diff -u linux-2.6.17/drivers/net/netxen/netxen_nic_main.c linux-2.6.17/drivers/net/netxen/netxen_nic_main.c --- linux-2.6.17/drivers/net/netxen/netxen_nic_main.c 2006-08-17 07:12:34.0 -0700 +++ linux-2.6.17/drivers/net/netxen/netxen_nic_main.c 2006-08-21 02:20:00.0 -0700 @@

Re: Bug in order of multiple IPv6 addresses per interface? Newest added one is preferred in difference to IPv4

2006-08-21 Thread Peter Bieringer
Mark Smith schrieb: Hi, Sorry not to preserve the list/thread ID, I read the list via nntp/gmane, so please also CC' me directly for replies. # ip -6 addr show dev eth0 |grep -w inet6 |grep -w global inet6 2001:db8:0:1::253/64 scope global - #2 inet6 2001:db8:0:1::11/64

Re: [PATCH 2.6.17 3/9] NetXen: hw initialization routines (name prefix change)

2006-08-21 Thread Pradeep Dalvi
diff -u linux-2.6.17/drivers/net/netxen/netxen_nic_init.c linux-2.6.17/drivers/net/netxen/netxen_nic_init.c --- linux-2.6.17/drivers/net/netxen/netxen_nic_init.c 2006-08-17 07:12:34.0 -0700 +++ linux-2.6.17/drivers/net/netxen/netxen_nic_init.c 2006-08-21 02:20:00.0 -0700 @@

Re: [PATCH 2.6.17 6/9] NetXen: Main header file (Name prefix change)

2006-08-21 Thread Pradeep Dalvi
diff -u linux-2.6.17/drivers/net/netxen/netxen_nic.h linux-2.6.17/drivers/net/netxen/netxen_nic.h --- linux-2.6.17/drivers/net/netxen/netxen_nic.h2006-08-17 07:12:34.0 -0700 +++ linux-2.6.17/drivers/net/netxen/netxen_nic.h2006-08-21 02:20:00.0 -0700 @@ -550,8

Re: [PATCH 5/7] ieee80211: export symbol ieee80211_api_version

2006-08-21 Thread Dan Williams
On Mon, 2006-08-21 at 11:33 +0800, Zhu Yi wrote: Export this symbol so that wireless drivers can check the running IEEE80211 API version dynamically. What's that needed for? Capability checks? Checking user's version to ensure they have a version with security fixes? What API bits changed?

Re: [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro

2006-08-21 Thread Dan Williams
On Mon, 2006-08-21 at 11:33 +0800, Zhu Yi wrote: Add IEEE80211_API_VERSION macro so that drivers are able to check it during compile time. This feature is useful to make backward IEEE80211 compatibilities for wireless drivers. Per my other mail, what exactly has changed and must be checked?

Re: [2.6.19 PATCH 4/7] ehea: ethtool interface

2006-08-21 Thread Thomas Klein
Stephen Hemminger wrote: On Fri, 18 Aug 2006 17:41:26 +0200 Thomas Klein [EMAIL PROTECTED] wrote: Hi Alexey, first of all thanks a lot for the extensive review. Alexey Dobriyan wrote: + u64 hret = H_HARDWARE; Useless assignment here and everywhere. Initializing returncodes to

[take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/kernel/kevent/kevent_timer.c

[take12 1/3] kevent: Core files.

2006-08-21 Thread Evgeniy Polyakov
Core files. This patch includes core kevent files: - userspace controlling - kernelspace interfaces - initialization - notification state machines Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/arch/i386/kernel/syscall_table.S b/arch/i386/kernel/syscall_table.S index

[take12 0/3] kevent: Generic event handling mechanism.

2006-08-21 Thread Evgeniy Polyakov
Generic event handling mechanism. Changes from 'take11' patchset: * include missing headers into patchset * some trivial code cleanups (use goto instead if if/else games and so on) * some whitespace cleanups * check for ready_callback() callback before main loop which should save us some

[take12 2/3] kevent: poll/select() notifications.

2006-08-21 Thread Evgeniy Polyakov
poll/select() notifications. This patch includes generic poll/select and timer notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake). Signed-off-by: Evgeniy Polyakov [EMAIL

Re: [2.6.19 PATCH 2/7] ehea: pHYP interface

2006-08-21 Thread Thomas Klein
Alexey Dobriyan wrote: On Fri, Aug 18, 2006 at 01:30:21PM +0200, Jan-Bernd Themann wrote: --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_phyp.c +++ kernel/drivers/net/ehea/ehea_phyp.c + hret = ehea_h_register_rpage(hcp_adapter_handle, pagesize, queue_type, +

Re: Bug in order of multiple IPv6 addresses per interface? Newest added one is preferred in difference to IPv4

2006-08-21 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article [EMAIL PROTECTED] (at Mon, 21 Aug 2006 07:36:19 +0200), Peter Bieringer [EMAIL PROTECTED] says: In IPv6, the behavior is completly different: # ip -6 addr show dev eth0 |grep -w inet6 |grep -w global inet6 2001:db8:0:1::11/64 scope global # ip -6 addr add

Re: [PATCH] locking bug in fib_semantics.c

2006-08-21 Thread Jarek Poplawski
On 21-08-2006 10:17, David Miller wrote: From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 21 Aug 2006 10:16:43 +0200 ... But I hope the real reason for this patch isn't exactly like that. Could fib_release_info() be interrupted by BH really? Absolutely, yes it can. What makes you think

Re: [2.6.19 PATCH 4/7] ehea: ethtool interface

2006-08-21 Thread Thomas Klein
Alexey Dobriyan wrote: On Fri, Aug 18, 2006 at 01:33:22PM +0200, Jan-Bernd Themann wrote: --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c +++ kernel/drivers/net/ehea/ehea_ethtool.c +{ +strncpy(info-driver, DRV_NAME, sizeof(info-driver) - 1); +strncpy(info-version,

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread Christoph Hellwig
On Fri, Aug 18, 2006 at 03:23:36PM +0400, Evgeniy Polyakov wrote: defines make some sense for userspace-visible ABIs because then people can test for features with ifdef. It doesn't make any sense for constants that are used purely in-kernel. For those enums make more sense because you

Re: [take9 2/2] kevent: poll/select() notifications. Timer notifications.

2006-08-21 Thread Christoph Hellwig
On Fri, Aug 18, 2006 at 02:59:34PM +0400, Evgeniy Polyakov wrote: If there's a really good reason we can keep things separate, but epoll and kevent_poll differs on some aspects is not one :) kevent_poll uses hash table (actually it is kevent that uses table), locking is simpler

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Christoph Hellwig
On Mon, Aug 21, 2006 at 02:19:49PM +0400, Evgeniy Polyakov wrote: Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. Shouldn't this at leat use a hrtimer? new

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 11:56:37AM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: On Fri, Aug 18, 2006 at 03:23:36PM +0400, Evgeniy Polyakov wrote: defines make some sense for userspace-visible ABIs because then people can test for features with ifdef. It doesn't make any sense for

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: On Mon, Aug 21, 2006 at 02:19:49PM +0400, Evgeniy Polyakov wrote: Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are

Re: Bug in order of multiple IPv6 addresses per interface? Newest added one is preferred in difference to IPv4

2006-08-21 Thread JINMEI Tatuya / 神明達哉
On Mon, 21 Aug 2006 12:47:36 +0200, Peter Bieringer [EMAIL PROTECTED] said: I do not favor changing this so far. Hmm, would it be possible to implement a primary flag in the future? BTW: Does anyone know about the behavior of *BSD for this issue? As far as I know, BSD variants don't have

Re: [RFC] nl80211 + packet injection with it and d80211

2006-08-21 Thread John W. Linville
On Mon, Aug 21, 2006 at 08:44:52AM +0200, Johannes Berg wrote: Another thing that crossed my mind: Should we have a netlink call for adding virtual interfaces as well? Because then, the ipw2x00 drivers can have their monitor interface(s) added the same way. Yes. -- John W. Linville [EMAIL

Re: [PATCH 5/7] ieee80211: export symbol ieee80211_api_version

2006-08-21 Thread John W. Linville
On Mon, Aug 21, 2006 at 11:33:40AM +0800, Zhu Yi wrote: Export this symbol so that wireless drivers can check the running IEEE80211 API version dynamically. The sole purpose of this would seem to be supporting out-of-stream driver development. Is there some other use that I am overlooking?

sky2 driver - large files upload problem

2006-08-21 Thread Jon Wikne
Hi Stephen rest of list, I'm having a peculiar problem with the sky2 driver. The problem is seen on the versions in kernels 2.6.16.16, 2.6.17.8 and 2.6.18-rc4. The problem appears when uploading large files (for instance via scp) _from_ the system in question. Downloads work OK, as does normal

Re: [PATCH 4/7] ieee80211: Add IEEE80211_API_VERSION macro

2006-08-21 Thread Christoph Hellwig
On Mon, Aug 21, 2006 at 11:33:22AM +0800, Zhu Yi wrote: Add IEEE80211_API_VERSION macro so that drivers are able to check it during compile time. This feature is useful to make backward IEEE80211 compatibilities for wireless drivers. NACK. - To unsubscribe from this list: send the line

Re: sky2 driver - large files upload problem

2006-08-21 Thread Daniel Drake
Hi Jon, Jon Wikne wrote: What happens is typically this: After transeferring some data, ranging from less than 100kB to 10MB, the upload freezes, i.e. gets no further. Use of ping shows the connection is effectively dead. If I do a sequence /sbin/ifdown eth0 /sbin/ifup eth0 the upload might

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 01:27:22PM +0200, Arjan van de Ven ([EMAIL PROTECTED]) wrote: On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote: ] + lockdep_set_class(t-ktimer_storage.lock, kevent_timer_key); When looking at the kevent_storage_init callers most need to do those

Re: [2.6.19 PATCH 5/7] ehea: main header files

2006-08-21 Thread Thomas Klein
Michael Neuling wrote: +static inline void ehea_update_sqa(struct ehea_qp *qp, u16 nr_wqes) +{ +struct h_epa epa = qp-epas.kernel; +epa_store_acc(epa, QPTEMM_OFFSET(qpx_sqa), + EHEA_BMASK_SET(QPX_SQA_VALUE, nr_wqes)); +} + +static inline void

Re: [PATCH] getsockopt() early argument sanity checking

2006-08-21 Thread Eugene Teo
Willy Tarreau wrote: On Sun, Aug 20, 2006 at 02:05:20AM +0200, Michael Buesch wrote: On Sunday 20 August 2006 01:48, Willy Tarreau wrote: On Sun, Aug 20, 2006 at 03:05:32AM +0400, Solar Designer wrote: [snipped] diff --git a/net/socket.c b/net/socket.c index ac45b13..910ef88 100644 ---

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 12:12:39PM +0100, Christoph Hellwig ([EMAIL PROTECTED]) wrote: +static int __init kevent_init_timer(void) +{ + struct kevent_callbacks tc = { + .callback = kevent_timer_callback, + .enqueue = kevent_timer_enqueue, + .dequeue =

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Arjan van de Ven
On Mon, 2006-08-21 at 15:59 +0400, Evgeniy Polyakov wrote: On Mon, Aug 21, 2006 at 01:27:22PM +0200, Arjan van de Ven ([EMAIL PROTECTED]) wrote: On Mon, 2006-08-21 at 15:18 +0400, Evgeniy Polyakov wrote: ] +lockdep_set_class(t-ktimer_storage.lock, kevent_timer_key); When

Re: [2.6.19 PATCH 7/7] ehea: Makefile Kconfig

2006-08-21 Thread Thomas Klein
Alexey Dobriyan wrote: On Fri, Aug 18, 2006 at 01:37:44PM +0200, Jan-Bernd Themann wrote: --- linux-2.6.18-rc4/drivers/net/Kconfig +++ patched_kernel/drivers/net/Kconfig @@ -2277,6 +2277,12 @@ config CHELSIO_T1 To compile this driver as a module, choose M here: the module

Re: [take12 3/3] kevent: Timer notifications.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 02:13:49PM +0200, Arjan van de Ven ([EMAIL PROTECTED]) wrote: Call me a cynic, but I'm always a bit sceptical about needing lockdep annotations like this... Can you explain why you need it in this case, including the proof that it's safe? Ok, again :)

[take12 4/3] kevent: Comment cleanup.

2006-08-21 Thread Evgeniy Polyakov
Remove file name from comments. dda1ae6fe306b485a91ebb58734bba06aebf diff --git a/kernel/kevent/kevent.c b/kernel/kevent/kevent.c index 2872aa2..02ecf30 100644 --- a/kernel/kevent/kevent.c +++ b/kernel/kevent/kevent.c @@ -1,6 +1,4 @@ /* - * kevent.c - * * 2006 Copyright (c) Evgeniy

Re: [PATCH 2/6] ehea: pHYP interface

2006-08-21 Thread Jan-Bernd Themann
Hi Nathan, sorry for the delayed answer. On Friday 11 August 2006 23:19, Nathan Lynch wrote: +static inline long ehea_hcall_9arg_9ret(unsigned long opcode, + unsigned long arg1, + unsigned long arg2, +

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread Bernd Petrovitsch
On Mon, 2006-08-21 at 15:13 +0400, Evgeniy Polyakov wrote: [...] And what is the difference between As others already pointed out in this thread: These are not seen by the C compiler. #define A 1 #define B 2 #define C 4 and These are known by the C compiler and thus usable/viewable in a

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread Evgeniy Polyakov
On Mon, Aug 21, 2006 at 02:53:25PM +0200, Bernd Petrovitsch ([EMAIL PROTECTED]) wrote: On Mon, 2006-08-21 at 15:13 +0400, Evgeniy Polyakov wrote: [...] And what is the difference between As others already pointed out in this thread: These are not seen by the C compiler. #define A 1

Re: [2.6.19 PATCH 1/7] ehea: interface to network stack

2006-08-21 Thread Jan-Bernd Themann
Hi On Friday 18 August 2006 16:44, Alexey Dobriyan wrote: +static int ehea_init_port_res(struct ehea_port *port, struct ehea_port_res *pr, + struct port_res_cfg *pr_cfg, int queue_token) +{ + int ret = -EINVAL; + int max_rq_entries = 0; + enum

Re: [2.6.19 PATCH 1/7] ehea: interface to network stack

2006-08-21 Thread Jörn Engel
On Mon, 21 August 2006 14:23:53 +0200, Jan-Bernd Themann wrote: Is it valid (common in the kernel environment) to treat NULL as 0 after a memset and thus to forget about initialization? Yes. According to C99, An implementation might conveivably have codes for floating zero and/or null

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-21 Thread Philip R. Auld
Hi Andrew, Rumor has it that on Fri, Aug 18, 2006 at 07:44:35PM -0700 Andrew Morton said: On Fri, 18 Aug 2006 16:44:01 -0700 Daniel Phillips [EMAIL PROTECTED] wrote: - We expect that the lots-of-dirty-anon-memory-over-swap-over-network scenario might still cause deadlocks. I assert

Re: [RFC][PATCH 2/9] deadlock prevention core

2006-08-21 Thread Jens Axboe
On Fri, Aug 18 2006, Daniel Phillips wrote: nearly the same kind of function, and suffering very nearly the same kind of problems we had in the block layer before mingo's mempool machinery arrived? Correction, the block layer wasn't buggy (eg deadlock prone) before mempool, mempool was merely

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread Bernd Petrovitsch
On Mon, 2006-08-21 at 17:01 +0400, Evgeniy Polyakov wrote: [ #define vs enum { } ] And, ugh: (gdb) list 1 enum { 2 A = 1, 3 B = 2, 4 }; 5 6 int main() 7 { 8 printf(%x\n, A | B); 9 } (gdb) bre 8 Breakpoint 1 at

Re: [PATCH 2.6.17 2/9] NetXen: Hardware access routines

2006-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2006 13:57:23 +0530 Amit S. Kale [EMAIL PROTECTED] wrote: We can certainly create a table for all error messages. It'll hurt readability of code in many of the other places where printks are used to indicate some hardware error. -Amit My suggestion was intended as an way

Re: sky2 driver - large files upload problem

2006-08-21 Thread Jon Wikne
Daniel Drake wrote: Jon Wikne wrote: What happens is typically this: After transeferring some data, ranging from less than 100kB to 10MB, the upload freezes, i.e. gets no further. Use of ping shows the connection is effectively dead. If I do a sequence /sbin/ifdown eth0 /sbin/ifup eth0 the

[PATCH] bcm43xx-softmac: Init, shutdown and restart fixes

2006-08-21 Thread Larry Finger
Hi John, Please apply this to wireless-2.6. Larry -- This fixes various bugs in the init and shutdown code that would lead to lockups and crashes, and is the softmac equivalent of the patches submitted by Michael Buesch for bcm43xx-d80211. These changes may fix some of the NETDEV WATCHDOG

Re: [PATCH] bcm43xx-softmac: Init, shutdown and restart fixes

2006-08-21 Thread Michael Buesch
On Monday 21 August 2006 16:43, Larry Finger wrote: Hi John, Please apply this to wireless-2.6. Larry -- This fixes various bugs in the init and shutdown code that would lead to lockups and crashes, and is the softmac equivalent of the patches submitted by Michael Buesch for

Re: [RFC] nl80211 + packet injection with it and d80211

2006-08-21 Thread Johannes Berg
Here's a respun patch hopefully addressing most of Jiri's comments, and allowing to add/remove virtual interfaces via netlink as well. I introduced a new notion of 'wiphy' which is just a number handed out by nl80211 for each registered backend, and I also changed it so that each backend must

[0/7] [CRYPTO]: Add hash type and hmac template

2006-08-21 Thread Herbert Xu
Hi: Dave, these patches are for cryptodev-2.6. This series of patches adds the new hash crypto type. It completely replaces the existing digest type from the user's side. For now the digest algorithm interface will remain and coexist with the new hash algorithm interface. The main reasons for

[PATCH 1/7] [CRYPTO] digest: Added user API for new hash type

2006-08-21 Thread Herbert Xu
[CRYPTO] digest: Added user API for new hash type The existing digest user interface is inadequate for support asynchronous operations. For one it doesn't return a value to indicate success or failure, nor does it take a per-operation descriptor which is essential for the issuing of requests

[PATCH 2/7] [CRYPTO] hmac: Add crypto template implementation

2006-08-21 Thread Herbert Xu
[CRYPTO] hmac: Add crypto template implementation This patch rewrites HMAC as a crypto template. This means that HMAC is no longer a hard-coded part of the API. It's now a template that generates standard digest algorithms like any other. The old HMAC is preserved until all current users are

[PATCH 5/7] [SCTP]: Use HMAC template and hash interface

2006-08-21 Thread Herbert Xu
[SCTP]: Use HMAC template and hash interface This patch converts SCTP to use the new HMAC template and hash interface. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Signed-off-by: David S. Miller [EMAIL PROTECTED] --- include/net/sctp/constants.h |4 ++-- include/net/sctp/sctp.h | 11

[PATCH 3/7] [CRYPTO] tcrypt: Use HMAC template and hash interface

2006-08-21 Thread Herbert Xu
[CRYPTO] tcrypt: Use HMAC template and hash interface This patch converts tcrypt to use the new HMAC template rather than the hard-coded version of HMAC. It also converts all digest users to use the new cipher interface. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Signed-off-by: David S. Miller

[PATCH 4/7] [IPSEC]: Use HMAC template and hash interface

2006-08-21 Thread Herbert Xu
[IPSEC]: Use HMAC template and hash interface This patch converts IPsec to use the new HMAC template. The names of existing simple digest algorithms may still be used to refer to their HMAC composites. The same structure can be used by other MACs such as AES-XCBC-MAC. This patch also switches

[PATCH 6/7] [CRYPTO] doc: Update documentation for hash and me

2006-08-21 Thread Herbert Xu
[CRYPTO] doc: Update documentation for hash and me This patch updates the documentation to reflect the switch from digest to hash. It also replaces notes about emailing James Morris to refer to me instead. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- Documentation/crypto/api-intro.txt |

[PATCH 7/7] [CRYPTO] digest: Remove old HMAC implementation

2006-08-21 Thread Herbert Xu
[CRYPTO] digest: Remove old HMAC implementation This patch removes the old HMAC implementation now that nobody uses it anymore. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Signed-off-by: David S. Miller [EMAIL PROTECTED] --- crypto/Kconfig |2 crypto/digest.c|3 -

Re: [2.6.19 PATCH 1/7] ehea: interface to network stack

2006-08-21 Thread Thomas Klein
Alexey Dobriyan wrote: On Fri, Aug 18, 2006 at 01:29:01PM +0200, Jan-Bernd Themann wrote: --- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_main.c +++ kernel/drivers/net/ehea/ehea_main.c +static inline int ehea_refill_rq3_def(struct ehea_port_res *pr, int nr_of_wqes) This one looks too big

Re: [PATCH] IP1000A: IC Plus update

2006-08-21 Thread Randy.Dunlap
On Mon, 21 Aug 2006 16:32:07 -0400 Jesse Huang wrote: Dear All: I had regenerate this patch from: git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git And, submit those modifications as one patch. From: Jesse Huang [EMAIL PROTECTED] Change Logs: - update

Re: sky2 driver - large files upload problem

2006-08-21 Thread Stephen Hemminger
On Mon, 21 Aug 2006 16:21:07 +0200 Jon Wikne [EMAIL PROTECTED] wrote: Daniel Drake wrote: Jon Wikne wrote: What happens is typically this: After transeferring some data, ranging from less than 100kB to 10MB, the upload freezes, i.e. gets no further. Use of ping shows the connection

Re: Proper pci_enable_device() error handling in resume routine

2006-08-21 Thread Auke Kok
Valerie Henson wrote: I'm trying to properly handle pci_enable_device() errors in the resume routines of a couple of tulip drivers. I noticed that several drivers pay attention to errors from pci_enable_device() in the init routine but ignore it on resume; other drivers vary wildly. What's

Re: [PATCH 02/18] d80211: master link

2006-08-21 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:09 +0200, Johannes Berg wrote: This patch adds a link from the wiphy to the master device in sysfs. Please add proper error handling and remove the link when the master device is unregistered. Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list:

Re: [take9 1/2] kevent: Core files.

2006-08-21 Thread David Miller
From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Mon, 21 Aug 2006 17:01:21 +0400 Actually I completely do not care about define or enums, it is really silly dispute, I just do not want to rewrite bunch of code _again_ and then _again_ when someone decide that defines are better. I totally

[patch 08/20] ipx: header length validation needed

2006-08-21 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] This patch will linearize and check there is enough data. It handles the pprop case as well as avoiding a whole audit of the routing code. Signed-off-by: Stephen

Re: [PATCH 06/18] d80211: rework rate control registration

2006-08-21 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:13 +0200, Johannes Berg wrote: Contrary to what Jiri said, proper rate control module refcounting is much easier than allowing rate control changes on-the-fly... This patch implements only the former along with cleanups. Note that the diff between rate_control.c and

Re: [PATCH 11/18] d80211: clean up qdisc requeue

2006-08-21 Thread Jiri Benc
On Mon, 21 Aug 2006 09:41:18 +0200, Johannes Berg wrote: There was a comment saying: /* TODO: clean up the cases where master_hard_start_xmit * returns non 0 - it shouldn't ever do that. Once done we * can remove this function */ I noticed that master_hard_start_xmit never returns nonzero

  1   2   >