[GIT PATCH] IPv6 Update for net-2.6.19, Take 2

2006-09-21 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. Here is the update for IPv6 for net-2.6.19, take 2. Changes: - Fix IsRouter flag in NAs. - Add HA/MN Support. With these changesets, net-2.6.19 will be able to handle fundermental not only CN (Correspondent Node) operation but also HA (Home Agent) / MN (Mobile Node) operations. Please

Re: [RFC 0/6] TCP socket splice

2006-09-21 Thread Evgeniy Polyakov
On Wed, Sep 20, 2006 at 02:07:11PM -0700, Ashwini Kulkarni ([EMAIL PROTECTED]) wrote: Using TCP socket splice: Application Control | _|__ |

Re: [patch 3/3] Add tsi108 On Chip Ethernet device driver support

2006-09-21 Thread Jeff Garzik
Zang Roy-r61911 wrote: On Thu, 2006-09-21 at 12:26, Jeff Garzik wrote: Zang Roy-r61911 wrote: +#define TSI108_ETH_WRITE_REG(offset, val) \ + writel(le32_to_cpu(val),data-regs + (offset)) + +#define TSI108_ETH_READ_REG(offset) \ + le32_to_cpu(readl(data-regs + (offset))) + +#define

Re: 2.6.18-rc7-mm1

2006-09-21 Thread Andi Kleen
On Wednesday 20 September 2006 16:23, Mike Galbraith wrote: On Tue, 2006-09-19 at 13:36 -0700, Andrew Morton wrote: On Tue, 19 Sep 2006 22:25:21 +0200 Rafael J. Wysocki [EMAIL PROTECTED] wrote: - It took maybe ten hours solid work to get this dogpile vaguely compiling and limping

Re: [GIT PATCH] NET: Fixes for net-2.6.19

2006-09-21 Thread Thomas Graf
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ [EMAIL PROTECTED] 2006-09-21 14:30 In article [EMAIL PROTECTED] (at Mon, 18 Sep 2006 20:57:46 +0200), Thomas Graf [EMAIL PROTECTED] says: Same here, it doesn't make sense to export macros only of functional value and used by userspace only. The same issue

Re: [PATCH 2/12] smc911x: Fix SMC_WRITE_EEPROM_CMD macro

2006-09-21 Thread bora . sahin
Hi, Send again with this time to netdev also. I didnt notice Steve not including netdev in the first place. Hi Francois/Bora, Macro abuse. It should be a function. Yes but I got smc911x.h and smc91x.h as a basis. In the smc911x.c there are macros which is longer than it, e.g.

Re: [PATCH 4/9] network namespaces: socket hashes

2006-09-21 Thread Daniel Lezcano
Andrey Savochkin wrote: The main reason is that socket hash tables should be large enough to work efficiently, but it isn't good to waste a lot of memory for each namespace. Namespaces should be cheap enough, to allow to have hundreds of them. This reason of memory efficiency, of course, has a

Re: [PATCH 2.6.18-rc6 1/2] dllink driver: porting v1.19 to linux 2.6.18-rc6

2006-09-21 Thread Florian Weimer
* Arjan van de Ven: if (irq) spin_lock(np-tx_lock); else spin_lock_irqsave(np-tx_lock, flag); double p this is wrong to do with in_interrupt() as gating factor! Well, this is not Hayim fault. It's in 2.6.18 as is. Unfortunately, the driver does

Re: [PATCH]d80211: fix iwconfig key [x] behavior

2006-09-21 Thread Jiri Benc
Hi, sorry for the delay. On Fri, 01 Sep 2006 11:37:57 +0800, Hong Liu wrote: @@ -2925,7 +2932,8 @@ static int ieee80211_ioctl_giwencode(str return 0; } - erq-length = 0; + erq-length = min((int)erq-length, sdata-keys[idx]-keylen); + memcpy(key,

Re: UDP Out 0f Sequence

2006-09-21 Thread Rick Jones
Majumder, Rajib wrote: Let's say we have 2 uniprocessor hosts connected back to back. Is there any possibility of an out-of-order scenario on recv? Your application should be written on the assumption that it is possible, regardless of the specifics of the hosts involved, however unlikely

Re: [PATCH 1/7] d80211: add SIOCSIWTXPOW, SIOCGIWTXPOW, SIOCSIWPOWER and SIOCGIWPOWER

2006-09-21 Thread mabbas
Jiri Benc wrote: Hi, sorry for the long delay. On Mon, 28 Aug 2006 13:45:18 -0700, mabbas wrote: [...] +static int ieee80211_ioctl_siwtxpow(struct net_device *dev, + struct iw_request_info *info, +union iwreq_data *wrqu, +char *extra) +{

Re: [PATCH 4/7] d80211: add support for SIOCSIWNICKN SIOCGIWNICKN

2006-09-21 Thread Jiri Benc
On Mon, 28 Aug 2006 13:50:54 -0700, mabbas wrote: This patch modify d80211 to add nick wireless command The nick command is useless as was pointed by several other developers. Therefore NAK. Thanks, Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line unsubscribe

[PATCH 1/6] NetLabel: correct improper handling of non-NetLabel peer contexts

2006-09-21 Thread paul . moore
Fix a problem where NetLabel would always set the value of sk_security_struct-peer_sid in selinux_netlbl_sock_graft() to the context of the socket, causing problems when users would query the context of the connection. This patch fixes this so that the value in sk_security_struct-peer_sid is

[PATCH 2/6] NetLabel: make the CIPSOv4 cache spinlocks bottom half safe

2006-09-21 Thread paul . moore
The CIPSOv4 cache traversal routines are triggered both the userspace events (cache invalidation due to DOI removal or updated SELinux policy) and network packet processing events. As a result there is a problem with the existing CIPSOv4 cache spinlocks as they are not bottom-half/softirq safe.

[PATCH 6/6] NetLabel: update docs with website information

2006-09-21 Thread paul . moore
Now that all of the supporting pieces of NetLabel have a home at SourceForge update the Kconfig help text and add an entry to the MAINTAINERS file. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- MAINTAINERS |7 +++ net/netlabel/Kconfig |5 - 2 files changed, 11

[PATCH 4/6] NetLabel: rework the Netlink attribute handling (part 1)

2006-09-21 Thread paul . moore
At the suggestion of Thomas Graf, rewrite NetLabel's use of Netlink attributes to better follow the common Netlink attribute usage. Signed-off-by: Paul Moore [EMAIL PROTECTED] --- include/net/cipso_ipv4.h | 16 +- include/net/netlabel.h | 49

[PATCH 3/6] NetLabel: change the SELinux permissions

2006-09-21 Thread paul . moore
Change NetLabel to use the 'recvfrom' socket permission and the SECINITSID_NETMSG SELinux SID as the NetLabel base SID for incoming packets. This patch effectively makes the old, and currently unused, SELinux NETMSG permissions NetLabel permissions. Signed-of-by: Paul Moore [EMAIL PROTECTED] ---

[PATCH 0/6] NetLabel fixes and reworked Netlink interface

2006-09-21 Thread paul . moore
This patchset, made against net-2.6.19, contains a collection of fixes for bugs found over the past few weeks as well as reworked Netlink interface which should bring NetLabel more inline with common Netlink methods. My apologies for not getting this out sooner, but the Netlink interface

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Jiri Benc
On Mon, 28 Aug 2006 13:49:35 -0700, mabbas wrote: This patch indicate unassociated and radio off status in name field NAK. Fix SIOCGIWAP handler instead. Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 2/7] d80211: add support for SIOCSIWRATE and SIOCGIWRATE

2006-09-21 Thread mabbas
Jiri Benc wrote: On Wed, 30 Aug 2006 10:19:19 -0700, Jouni Malinen wrote: On Mon, Aug 28, 2006 at 01:45:34PM -0700, mabbas wrote: This patch modify d80211 to add SIOCSIWRATE and SIOCGIWRATE commands. this patch almost does the same thing as in PRISM2_HOSTAPD_SET_RATE_SETS. I

Re: [PATCH 7/7] d80211: getting wrong freq value if we did hardware scan

2006-09-21 Thread Jiri Benc
On Mon, 28 Aug 2006 13:57:28 -0700, mabbas wrote: diff --git a/net/d80211/ieee80211_sta.c b/net/d80211/ieee80211_sta.c index a933d92..374193e 100644 --- a/net/d80211/ieee80211_sta.c +++ b/net/d80211/ieee80211_sta.c @@ -1543,8 +1543,6 @@ #endif bss-channel = channel; bss-freq =

Re: [PATCH 7/7] d80211: getting wrong freq value if we did hardware scan

2006-09-21 Thread mabbas
Jiri Benc wrote: On Mon, 28 Aug 2006 13:57:28 -0700, mabbas wrote: diff --git a/net/d80211/ieee80211_sta.c b/net/d80211/ieee80211_sta.c index a933d92..374193e 100644 --- a/net/d80211/ieee80211_sta.c +++ b/net/d80211/ieee80211_sta.c @@ -1543,8 +1543,6 @@ #endif bss-channel = channel;

Re: [PATCH] d80211: use list_for_each_entry{,_safe}

2006-09-21 Thread Jiri Benc
On Thu, 31 Aug 2006 08:58:50 +0200, Johannes Berg wrote: On Wed, 2006-08-30 at 08:43 -0700, Jouni Malinen wrote: Could you please separate cleanup parts (list_for_each changes) from functional changes (adding locking) to make it easier to review the patch? Yeah, I guess I should do that.

Re: [patch] d80211: remove sub-interface mac address policy

2006-09-21 Thread Jiri Benc
On Thu, 14 Sep 2006 07:33:21 -0700, David Kimdon wrote: Wireless vlan interfaces need to have the same mac address as other sub interfaces. Rather than complicate the kernel here by adding yet another case where uniqueness is not required, remove the check on mac address uniqueness

Re: [PATCH 1/6] NetLabel: correct improper handling of non-NetLabel peer contexts

2006-09-21 Thread James Morris
On Thu, 21 Sep 2006, [EMAIL PROTECTED] wrote: Fix a problem where NetLabel would always set the value of sk_security_struct-peer_sid in selinux_netlbl_sock_graft() to the context of the socket, causing problems when users would query the context of the connection. This patch fixes this so

Re: [PATCH 1/6] NetLabel: correct improper handling of non-NetLabel peer contexts

2006-09-21 Thread Paul Moore
James Morris wrote: On Thu, 21 Sep 2006, [EMAIL PROTECTED] wrote: Fix a problem where NetLabel would always set the value of sk_security_struct-peer_sid in selinux_netlbl_sock_graft() to the context of the socket, causing problems when users would query the context of the connection. This

[PATCH] rt2x00: remove hardware button support

2006-09-21 Thread Ivo van Doorn
compilation was broken in rt2x00 due to rfkill attributed sneaking into rt2x00dev structure. rfkill will replace current hardware button support evantually, but lets fix rt2x00 compilation and remove hardware button support for this time until rfkill has been finished. Signed-off-by Ivo van Doorn

Re: [PATCH 1/7] d80211: add SIOCSIWTXPOW, SIOCGIWTXPOW, SIOCSIWPOWER and SIOCGIWPOWER

2006-09-21 Thread Jiri Benc
Thu, 21 Sep 2006 09:43:31 -0700, mabbas pise: What about adding a new callback function fot txpower. ieee80211_hw_config callback still confusing if txpower was changed for channel change or because the user setting txpower limit. Why should the driver care? Jiri -- Jiri Benc SUSE Labs -

[PATCH] Spidernet: add ethtool -S (show statistics)

2006-09-21 Thread Jim Lewis
This patch adds the ethtool -S (show statistics) feature to the Spidernet ethernet driver. I have tested it extensively and believe it is ready to be applied. Signed-off-by: James K Lewis --- drivers/net/spider_net.c | 10 ++ drivers/net/spider_net.h | 11 ++-

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Dan Williams
On Thu, 2006-09-21 at 19:01 +0200, Jiri Benc wrote: On Mon, 28 Aug 2006 13:49:35 -0700, mabbas wrote: This patch indicate unassociated and radio off status in name field NAK. Fix SIOCGIWAP handler instead. Right; the _one_ place anyone should ever have to check for unassociated status

Re: [PATCH 6/7] d80211: diplay supported rates in readable format

2006-09-21 Thread Jiri Benc
On Mon, 28 Aug 2006 13:52:06 -0700, mabbas wrote: This patch modify d80211 to report supported rates in readable format in iwlist scan command. Applied to my tree. Thanks for the patch! Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 2/2]d80211: add hardware scan callback

2006-09-21 Thread Jiri Benc
On Fri, 01 Sep 2006 15:34:38 +0800, Hong Liu wrote: Thanks for point this out! Change to only set sta_scanning to 1 if hw_scan successes. Applied to my tree. Thanks for the patch! Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH] d80211: clean up those huge else if statements; use BUILD_BUG_ON

2006-09-21 Thread Jiri Benc
On Wed, 30 Aug 2006 10:41:00 +0200, Johannes Berg wrote: This patch replaces the if (...) else if (...) else if (...) ... statements I complained about earlier with switches. On Wed, 30 Aug 2006 10:39:30 +0200, Johannes Berg wrote: This patch makes d80211 use BUILD_BUG_ON instead of checking

Re: [patch] d80211: fix WEP on big endian cpus

2006-09-21 Thread Jiri Benc
Sun, 10 Sep 2006 17:47:16 -0400, Michael Wu pise: This patch fixes the endian issues with the ICV in WEP, as pointed out by David Kimdon [EMAIL PROTECTED], and uses __le32 where appropriate to make things clear. Applied to my tree. Thanks for the patch! Jiri -- Jiri Benc SUSE Labs - To

Re: [patch] d80211: fix multiple device ap support

2006-09-21 Thread Jiri Benc
On Tue, 5 Sep 2006 11:50:35 -0700, David Kimdon wrote: Another fix to the interpretation of dev_alloc_name() return value. dev_alloc_name() returns the number of the unit assigned or a negative errno code. Applied to my tree. Thanks for the patch! Jiri -- Jiri Benc SUSE Labs - To

Re: [patch] d80211: allow vlan interfaces to receive ToDS frames

2006-09-21 Thread Jiri Benc
Thu, 14 Sep 2006 07:33:56 -0700, David Kimdon pise: Interfaces of type IEEE80211_IF_TYPE_VLAN need to be able to receive ToDS frames. Applied to my tree. Thanks for the patch! Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [patch] Fix type of prism2_hostapd_param crypt.alg

2006-09-21 Thread Jiri Benc
On Thu, 7 Sep 2006 09:15:54 -0700, David Kimdon wrote: crypt.alg is a string, use the correct type. Applied to my tree. Thanks for the patch! Jiri -- Jiri Benc SUSE Labs - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread mabbas
Dan Williams wrote: On Thu, 2006-09-21 at 19:01 +0200, Jiri Benc wrote: On Mon, 28 Aug 2006 13:49:35 -0700, mabbas wrote: This patch indicate unassociated and radio off status in name field NAK. Fix SIOCGIWAP handler instead. Right; the _one_ place anyone should ever

Bluetooth update for 2.6

2006-09-21 Thread Marcel Holtmann
Hi Dave, here are the pending patches that didn't make it into the 2.6.18 kernel release. I have some additional fixes, but all of them need some more additional testing from my side. Regards Marcel Please pull from

Re: Update of the r8169 branch

2006-09-21 Thread Boris B. Zhmurov
Francois Romieu wrote: Boris B. Zhmurov [EMAIL PROTECTED] : [...] Any ideas are welcome. Usually my Pavlov answer is disable iptables, run latest kernel, renice ksoftirqd like hell, see if it makes a difference and keep netdev Cced. Of course there is no iptables. And linux-2.6.18 shows

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Dan Williams
On Thu, 2006-09-21 at 12:47 -0700, mabbas wrote: Dan Williams wrote: On Thu, 2006-09-21 at 19:01 +0200, Jiri Benc wrote: On Mon, 28 Aug 2006 13:49:35 -0700, mabbas wrote: This patch indicate unassociated and radio off status in name field NAK. Fix SIOCGIWAP

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread mabbas
Dan Williams wrote: On Thu, 2006-09-21 at 12:47 -0700, mabbas wrote: Dan Williams wrote: On Thu, 2006-09-21 at 19:01 +0200, Jiri Benc wrote: On Mon, 28 Aug 2006 13:49:35 -0700, mabbas wrote: This patch indicate unassociated and radio off status in name field

[PATCH] cirrus logic ep93xx ethernet driver

2006-09-21 Thread Lennert Buytenhek
The cirrus ep93xx is an ARM SoC that includes an ethernet MAC -- this patch adds a driver for that ethernet MAC. Signed-off-by: Lennert Buytenhek [EMAIL PROTECTED] Index: linux-2.6.18/drivers/net/arm/Kconfig === ---

Re: Update of the r8169 branch

2006-09-21 Thread Francois Romieu
Boris B. Zhmurov [EMAIL PROTECTED] : [...] Is there any chance to get linux worked at least as fast, as freebsd-6.1 with small udp packets? Any help will be more than welcome! Please, CC: me, due to I'm not subscribed to [EMAIL PROTECTED] Can you publish dmesg, vmstat 1 and /proc/interrupts

Re: [patch] d80211: remove sub-interface mac address policy

2006-09-21 Thread David Kimdon
On Thu, Sep 21, 2006 at 08:09:39PM +0200, Jiri Benc wrote: On Thu, 14 Sep 2006 07:33:21 -0700, David Kimdon wrote: Wireless vlan interfaces need to have the same mac address as other sub interfaces. Rather than complicate the kernel here by adding yet another case where uniqueness is not

Question about David's blog entry for NetCONF 2006, Day 1

2006-09-21 Thread Rick Jones
I was reading David's blog entries on the netdev meeting in Japan, and have a question about this bit: Currently, things like Xen have to put the card into promiscuous mode, accepting all packets, which is quite inefficient. Is the inefficient bit meant for accepting all packets, or more

Re: [PATCH 1/7] d80211: add SIOCSIWTXPOW, SIOCGIWTXPOW, SIOCSIWPOWER and SIOCGIWPOWER

2006-09-21 Thread Jiri Benc
On Thu, 21 Sep 2006 12:57:01 -0700, mabbas wrote: if the user set txpoer using iwconfig command, the driver will clap all txpower to this value for all available channels if channels original txpower is higher than txpower value. Looks like a job for the stack. If the stack takes care

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Jiri Benc
On Thu, 21 Sep 2006 13:39:18 -0700, mabbas wrote: I can fix the patch to do just that if we agree on that. Well, we need a flag indicating whether we are associated or not. I don't know about such a flag in WE (hopefully we will have that in nl80211). Now we have two possibilities: (a) If a

Fw: [Bugme-new] [Bug 7179] New: Compilation of .tmp_linux1 fails due to missing declaration in net/netfilter/xt_physdev.c

2006-09-21 Thread Andrew Morton
Methinks CONFIG_NETFILTER_XT_TARGET_CLASSIFY should depend upon CONFIG_BRIDGE_NETFILTER. Because brnf_deferred_hooks is defined in net/bridge/br_netfilter.c and is referred to in net/netfilter/xt_physdev.c. Or something else ;) Begin forwarded message: Date: Thu, 21 Sep 2006 14:41:13 -0700

Re: [PATCH 1/7] d80211: add SIOCSIWTXPOW, SIOCGIWTXPOW, SIOCSIWPOWER and SIOCGIWPOWER

2006-09-21 Thread mabbas
Jiri Benc wrote: On Thu, 21 Sep 2006 12:57:01 -0700, mabbas wrote: if the user set txpoer using iwconfig command, the driver will clap all txpower to this value for all available channels if channels original txpower is higher than txpower value. Looks like a job for the stack. If

[PATCH] skge: fiber support

2006-09-21 Thread Stephen Hemminger
Add support for older fiber versions of the SysKonnect board. These chipsets use an internal PHY so they require special handling. The older sk98lin driver already supported these Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/skge.c | 357

[PATCH 1/3] bonding: Validate probe replies in ARP monitor

2006-09-21 Thread Jay Vosburgh
Add logic to check ARP request / reply packets used for ARP monitor link integrity checking. The current method simply examines the slave device to see if it has sent and received traffic; this can be fooled by extraneous traffic. For example, if multiple hosts running bonding

[PATCH 2/3] bonding: Don't mangle LACPDUs

2006-09-21 Thread Jay Vosburgh
Fixed handling of 802.3ad LACPDUs. Do not byte swap data in place in the packet. Updated nomenclature of __ntohs_lacpdu to be htons; it was previously used for both ntohs and htons operations, but only called ntohs functions. Signed-off-by: Jay Vosburgh [EMAIL PROTECTED] diff --git

[PATCH 3/3] bonding: Fix primary selection error at enslavement time

2006-09-21 Thread Jay Vosburgh
At enslavement time, the primary slave might not be activated if there is already an active slave and the new slave is the primary. Replaced complicated logic with a call to bond_select_active_slave(), which does the right thing. Fixes

[PATCH 0/3] bonding: 3 fixes

2006-09-21 Thread Jay Vosburgh
Patch 1: Validate probe replies in ARP monitor Patch 2: Don't mangle LACPDUs Patch 3: Fix primary selection error at enslavement time These patches are against netdev-2.6#upstream with the set of 7 bonding patches from 1 September 2006 already applied. -J

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Jean Tourrilhes
On Fri, Sep 22, 2006 at 12:38:44AM +0200, Jiri Benc wrote: On Thu, 21 Sep 2006 13:39:18 -0700, mabbas wrote: I can fix the patch to do just that if we agree on that. Well, we need a flag indicating whether we are associated or not. I don't know about such a flag in WE (hopefully we will

Re: [PATCH] cirrus logic ep93xx ethernet driver

2006-09-21 Thread Jeff Garzik
Lennert Buytenhek wrote: +#include linux/config.h +#include linux/dma-mapping.h +#include linux/module.h +#include linux/kernel.h +#include linux/netdevice.h +#include linux/mii.h +#include linux/etherdevice.h +#include linux/ethtool.h +#include linux/init.h +#include linux/moduleparam.h

Re: [RFT] sky2 vs iptables

2006-09-21 Thread Stephen Hemminger
On Sat, 16 Sep 2006 23:01:46 -0400 Daniel Drake [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: On Tue, 05 Sep 2006 21:36:24 -0400 Daniel Drake [EMAIL PROTECTED] wrote: There's a strange sky2 bug on the Gentoo bugzilla: http://bugs.gentoo.org/show_bug.cgi?id=136508 sky2 seems to

[PATCH] Cirrus Logic ep93xx ethernet driver

2006-09-21 Thread Lennert Buytenhek
The Cirrus Logic ep93xx is an ARM SoC that includes an ethernet MAC -- this patch adds a driver for that ethernet MAC. Signed-off-by: Lennert Buytenhek [EMAIL PROTECTED] Index: linux-2.6.18/drivers/net/arm/Kconfig === ---

Re: [PATCH] cirrus logic ep93xx ethernet driver

2006-09-21 Thread Lennert Buytenhek
On Thu, Sep 21, 2006 at 07:10:02PM -0400, Jeff Garzik wrote: +if (!(rstat0 RSTAT0_RFP)) { +printk(KERN_CRIT ep93xx_rx: buffer not done + %.8x %.8x\n, rstat0, rstat1); +BUG(); +} +

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Jouni Malinen
On Thu, Sep 21, 2006 at 03:55:14PM -0700, Jean Tourrilhes wrote: Jean, are there any other possibilities? Yes, dropping SIOCSIWAP (set) entirely, and keep only SIOCGIWAP (get). I don't think that this would be acceptable. We need to be pragmatic. Very few people need to set a

Re: [PATCH 5/7] d80211: indicate if unassociate/radio off status

2006-09-21 Thread Jean Tourrilhes
On Thu, Sep 21, 2006 at 05:42:35PM -0700, Jouni Malinen wrote: On Thu, Sep 21, 2006 at 03:55:14PM -0700, Jean Tourrilhes wrote: Jean, are there any other possibilities? Yes, dropping SIOCSIWAP (set) entirely, and keep only SIOCGIWAP (get). I don't think that this would be

[PATCH 6/7] [DCCP]: Fix setting of packet size in CCID3

2006-09-21 Thread Ian McDonald
Set initial packet size to defaults as existing code doesn't work as set_sockopt occurs after initialisation so dccps_packet_size is of no use really. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index 7b4699a..e6c8e4c 100644 ---

[PATCH 0/7] [DCCP]: Further fixes and enhancements

2006-09-21 Thread Ian McDonald
Here is my latest set of patches for DCCP. If possible I would like these to go into 2.6.19. I have tested against 2.6.18rc5 and latest net-2.6.19 git tree of Dave M as well. Dave - Patches 1 and 2 are trivial and just introducing constants and using them. Patch 4 is shifting some code into a

[PATCH 7/7] [DCCP]: Remove socket option

2006-09-21 Thread Ian McDonald
This removes DCCP_SOCKOPT_PACKET_SIZE for two reasons: * the current code doesn't work * tx and rx should be different (introduced in former patch) Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/include/linux/dccp.h b/include/linux/dccp.h index ef1c57b..18fbbb4 100644 ---

[PATCH 2/7] [DCCP]: Use constants for CCIDs

2006-09-21 Thread Ian McDonald
With constants for CCID numbers this now uses them in some places. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccids/ccid2.c b/net/dccp/ccids/ccid2.c index 457dd3d..2efb505 100644 --- a/net/dccp/ccids/ccid2.c +++ b/net/dccp/ccids/ccid2.c @@ -808,7 +808,7 @@ static void

[PATCH 1/7] [DCCP]: Introduce constants for CCID numbers

2006-09-21 Thread Ian McDonald
This change introduces a constant for CCID numbers. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/include/linux/dccp.h b/include/linux/dccp.h index 2d7671c..a073164 100644 --- a/include/linux/dccp.h +++ b/include/linux/dccp.h @@ -169,6 +169,12 @@ enum {

[PATCH 3/7] [DCCP]: Introduce dccp_probe

2006-09-21 Thread Ian McDonald
This adds DCCP probing shamelessly ripped off from TCP probes by Stephen Hemminger. I've put in here support for further CCID3 variables as well. Andrea/Arnaldo might look to extend for CCID2. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/Kconfig b/net/dccp/Kconfig

[PATCH 4/7] [DCCP]: Shift constants into header

2006-09-21 Thread Ian McDonald
This shifts some constants from ccid3.c to ccid3.h This is not needed for in tree code (yet) but for my own work. Makes sense to have constants in header though. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c index 67d2dc0..7b4699a

[PATCH 5/7] [DCCP]: Introduce two new socket options

2006-09-21 Thread Ian McDonald
This creates two new socket options DCCP_SOCKOPT_TX_PACKET_SIZE and DCCP_SOCKOPT_RX_PACKET_SIZE. DCCP_SOCKOPT_PACKET_SIZE doesn't work and packet size should be set independently on two half connections. Signed-off-by: Ian McDonald [EMAIL PROTECTED] --- diff --git a/include/linux/dccp.h

Re: [PATCH 0/7] [DCCP]: Further fixes and enhancements

2006-09-21 Thread Arnaldo Carvalho de Melo
On 9/21/06, Ian McDonald [EMAIL PROTECTED] wrote: Here is my latest set of patches for DCCP. If possible I would like these to go into 2.6.19. I have tested against 2.6.18rc5 and latest net-2.6.19 git tree of Dave M as well. Dave - Patches 1 and 2 are trivial and just introducing constants and

Re: [PATCH 2.6.17][Trivial] net/dccp: update references to standards

2006-09-21 Thread Ian McDonald
Arnaldo - this looks good. Signed-off-by: Ian McDonald [EMAIL PROTECTED] On 9/15/06, Gerrit Renker [EMAIL PROTECTED] wrote: Sorry kmail garbled this, clean text below. - Gerrit -- diff --git a/net/dccp/Kconfig b/net/dccp/Kconfig index 859e335..2c345c0 100644 --- a/net/dccp/Kconfig +++

Re: [PATCH] net/dccp: Allow default/fallback service code

2006-09-21 Thread Ian McDonald
Gerrit, Not sure what happened here but I can't apply this with git-apply. Can you check and resubmit. Looks great patch though and would love to test! This would mean DCCP is easier to port to which must be good. Just a quick note - you didn't updated last changed date in

Re: [PATCH 1/3] sky2: tx pause bug fix

2006-09-21 Thread Andrew Hall
Unfortunately I spoke too soon.. :-( The driver no longer appears to fail under load but still fails randomly with relatively light load: Sep 22 07:04:38 localhost syslog.info -- MARK -- Sep 22 07:24:38 localhost syslog.info -- MARK -- Sep 22 07:31:52 localhost user.info kernel: NETDEV

Re: [PATCH 1/3] sky2: tx pause bug fix

2006-09-21 Thread Larry Finger
Andrew Hall wrote: Unfortunately I spoke too soon.. :-( The driver no longer appears to fail under load but still fails randomly with relatively light load: I don't know if this will help, but NETDEV watchdog timeouts in the bcm43xx driver were fixed by changing a netif_stop_queue call