[PATCH] NET : force a cache line split in hh_cache in SMP

2006-12-08 Thread Eric Dumazet
hh_lock was converted from rwlock to seqlock by Stephen. To have a 100% benefit of this change, I suggest to place read mostly fields of hh_cache in a separate cache line, because hh_refcnt may be changed quite frequently on some busy machines. Signed-off-by: Eric Dumazet [EMAIL PROTECTED]

Re: [PATCH] NET : force a cache line split in hh_cache in SMP

2006-12-08 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 08 Dec 2006 09:06:32 +0100 hh_lock was converted from rwlock to seqlock by Stephen. To have a 100% benefit of this change, I suggest to place read mostly fields of hh_cache in a separate cache line, because hh_refcnt may be changed quite

Re: [PATCH] [XFRM] Fix XFRMGRP_REPORT to use correct multicast group

2006-12-08 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Thu, 07 Dec 2006 19:14:58 -0500 Against net-2.6 but should probably go into anything stable that has reports already. Applied, thanks for this fix Jamal. I'll push it to -stable. - To unsubscribe from this list: send the line unsubscribe netdev in the body

how to change the initial queue descipline to netem?

2006-12-08 Thread Jie Xu
the main problem is that how to create a netem queue? just replace the fifo_fast in dev_activate() failed - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][NET_SCHED] sch_cbq: deactivating when grafting, purging etc.

2006-12-08 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 30 Nov 2006 13:22:47 +0100 Jarek Poplawski wrote: [NET_SCHED] sch_cbq: [PATCH 2.6.19-rc6 with Fix endless loops set of patches] - P. McHardy's Fix endless loops patch supplement (cbq_graft, cbq_qlen_notify, cbq_delete,

Re: [PATCH][NET_SCHED] sch_htb: turn intermediate classes into leaves

2006-12-08 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 30 Nov 2006 14:12:32 +0100 Jarek Poplawski wrote: On Thu, Nov 30, 2006 at 01:26:34PM +0100, Patrick McHardy wrote: Jarek Poplawski wrote: [NET_SCHED] sch_htb: [PATCH 2.6.19-rc6 with Fix endless loops set of patches] - turn

Re: 'embedded people' and the 'embedded world' (was: Re: [RFC patch] driver for the Opencores Ethernet Controller)

2006-12-08 Thread Robert Schwebel
Lennert, On Tue, Dec 05, 2006 at 01:29:36AM +0100, Lennert Buytenhek wrote: BTW (and this is not specifically directed to you.) One cannot say this loud enough. Acked-By: Robert Schwebel [EMAIL PROTECTED] Robert -- Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de Pengutronix - Linux

[IPROUTE2 PATCH][XFRM] update xfrm monitoring to use nl_mgrp

2006-12-08 Thread jamal
Stephen, I will wait until you sync all these patches ive sent; then send a couple more then i will be done. cheers, jamal [XFRM] update xfrm monitoring to use nl_mgrp Signed-off-by: J Hadi Salim [EMAIL PROTECTED] --- commit 738a5222776694ff22083e54a8f3efb6a013694e tree

Re: Marvell Libertas wifi

2006-12-08 Thread Dan Williams
On Fri, 2006-12-08 at 01:03 -0500, Alex Deucher wrote: On 12/7/06, Dan Williams [EMAIL PROTECTED] wrote: On Thu, 2006-12-07 at 12:32 -0500, Alex Deucher wrote: I just wanted to check on the status of the libertas driver from Marvell for the OLPC project. I haven't really been able to

[PATCH] MACB: Use struct delayed_work instead of struct work_struct

2006-12-08 Thread Haavard Skinnemoen
The macb driver calls schedule_delayed_work() and friends, so we need to use a struct delayed_work along with it. The conversion was explained by David Howells on lkml Dec 5 2006: http://lkml.org/lkml/2006/12/5/269 Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/net/macb.c |

[PATCH] MACB: Use __raw register access

2006-12-08 Thread Haavard Skinnemoen
Since macb is a chip-internal device, use __raw_readl and __raw_writel instead of readl/writel. This will perform native-endian accesses, which is the right thing to do on both AVR32 and ARM devices. Signed-off-by: Haavard Skinnemoen [EMAIL PROTECTED] --- drivers/net/macb.c |2 +-

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-08 Thread Stefan Rompf
Hi Thomas, Am Donnerstag, 7. Dezember 2006 11:55 schrieb Thomas Graf: --- net-2.6.orig/include/linux/rtnetlink.h2006-12-07 11:25:29.0 +0100 +++ net-2.6/include/linux/rtnetlink.h 2006-12-07 11:32:25.0 +0100 @@ -3,6 +3,8 @@ #include linux/netlink.h #include

[PATCH] myri10ge: pci msi and express state save/restore

2006-12-08 Thread Stephen Hemminger
The PCI MSI and express state are already saved and restored by the current versions of pci_save_state/pci_restore_state. Therefore it should no longer be necessary for the driver to do it. This patch has not been tested on the hardware. On suspend, handle pci_set_power_state errors, and on

Re: [PATCH] myri10ge: pci msi and express state save/restore

2006-12-08 Thread Brice Goglin
It looks ok to me, except that you should also remove devctl and msi_flags from myri10ge_priv since these fields were only used in the functions that are dropped by this patch. However, I won't be able to test the patch on real hardware within the next days... Thanks a lot! Brice Stephen

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-08 Thread Jim Gifford
I have seen issues with some version of unifdef remove any instance of __KERNEL__, is the #ifndef __KERNEL__ really necessary. Has anyone tested to make sure the install_headers will not accidently remove this? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Fw: [Bug 7635] New: ioctl(fd,TCSBRK,1) on socket yields EFAULT, expected EINVAL/ENOTTY

2006-12-08 Thread Stephen Hemminger
Begin forwarded message: Date: Tue, 5 Dec 2006 08:55:19 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 7635] New: ioctl(fd,TCSBRK,1) on socket yields EFAULT, expected EINVAL/ENOTTY http://bugzilla.kernel.org/show_bug.cgi?id=7635 Summary: ioctl(fd,TCSBRK,1) on

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-08 Thread Mike Frysinger
On Friday 08 December 2006 12:33, Jim Gifford wrote: I have seen issues with some version of unifdef remove any instance of __KERNEL__ so use a version of unifdef that isnt broken ? -mike pgpsiyqaE9CFU.pgp Description: PGP signature

Re: Marvell Libertas wifi

2006-12-08 Thread Alex Deucher
On 12/8/06, Dan Williams [EMAIL PROTECTED] wrote: On Fri, 2006-12-08 at 01:03 -0500, Alex Deucher wrote: On 12/7/06, Dan Williams [EMAIL PROTECTED] wrote: On Thu, 2006-12-07 at 12:32 -0500, Alex Deucher wrote: I just wanted to check on the status of the libertas driver from Marvell for

Re: how to change the initial queue descipline to netem?

2006-12-08 Thread Stephen Hemminger
On Fri, 8 Dec 2006 16:14:23 +0800 Jie Xu [EMAIL PROTECTED] wrote: the main problem is that how to create a netem queue? just replace the fifo_fast in dev_activate() failed - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 04/26] rt2x00: EEPROM 93Cx6

2006-12-08 Thread Ivo van Doorn
On Sunday 03 December 2006 19:39, Michael Wu wrote: On Sunday 03 December 2006 13:19, Ivo van Doorn wrote: rt2400pci, rt2500pci and rt61pci share exactly the same code for the eeprom reading. The only difference is that rt61pci has a slightly different register reading approach. In any

[PATCH] chelsio: working NAPI

2006-12-08 Thread Stephen Hemminger
This driver tries to enable/disable NAPI at runtime, but does so in an unsafe manner, and the NAPI interrupt handling is a mess. Replace it with a compile time selected NAPI implementation. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/Kconfig |8 +++

Re: [Devel] Re: Network virtualization/isolation

2006-12-08 Thread Eric W. Biederman
Herbert Poetzl [EMAIL PROTECTED] writes: But, ok, it is not the real point to argue so much imho and waste our time instead of doing things. well, IMHO better talk (and think) first, then implement something ... not the other way round, and then start fixing up the mess ... Well we need a

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-08 Thread David Miller
From: Stefan Rompf [EMAIL PROTECTED] Date: Fri, 8 Dec 2006 15:25:18 +0100 (MET) The _RTA and _PAYLOAD-macros are also part of userspace headers and need to be restored. Both dhcpclient and quagga need at least IFA_RTA and IFLA_RTA to compile, but there may be more macros than in the following

Re: [Bug 7635] New: ioctl(fd,TCSBRK,1) on socket yields EFAULT, expected EINVAL/ENOTTY

2006-12-08 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 8 Dec 2006 09:50:55 -0800 ioctl(TCSBRK,1) errno pty 0 pipe 22/EINVAL /dev/null 25/ENOTTY reg_file 25/ENOTTY socket14/EFAULT If you call a TTY ioctl on a socket, it might not work, don't

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-08 Thread Daniel Jacobowitz
On Fri, Dec 08, 2006 at 01:33:34PM -0800, David Miller wrote: From: Stefan Rompf [EMAIL PROTECTED] Date: Fri, 8 Dec 2006 15:25:18 +0100 (MET) The _RTA and _PAYLOAD-macros are also part of userspace headers and need to be restored. Both dhcpclient and quagga need at least IFA_RTA and

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-08 Thread David Miller
From: Daniel Jacobowitz [EMAIL PROTECTED] Date: Fri, 8 Dec 2006 16:36:14 -0500 On Fri, Dec 08, 2006 at 01:33:34PM -0800, David Miller wrote: From: Stefan Rompf [EMAIL PROTECTED] Date: Fri, 8 Dec 2006 15:25:18 +0100 (MET) The _RTA and _PAYLOAD-macros are also part of userspace headers

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-08 Thread Daniel Jacobowitz
On Fri, Dec 08, 2006 at 01:47:52PM -0800, David Miller wrote: The _RTA and _PAYLOAD-macros are also part of userspace headers and need to be restored. Both dhcpclient and quagga need at least IFA_RTA and IFLA_RTA to compile, but there may be more macros than in the following

Re: [Bug 7635] New: ioctl(fd,TCSBRK,1) on socket yields EFAULT, expected EINVAL/ENOTTY

2006-12-08 Thread Stephen Hemminger
On Fri, 08 Dec 2006 13:36:33 -0800 (PST) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 8 Dec 2006 09:50:55 -0800 ioctl(TCSBRK,1) errno pty 0 pipe22/EINVAL /dev/null 25/ENOTTY reg_file25/ENOTTY socket

Re: [openib-general] [RFC] [PATCH V2 0/3] bonding support foroperation over IPoIB

2006-12-08 Thread Or Gerlitz
On 12/8/06, Carl Yang (caryang) [EMAIL PROTECTED] wrote: Can you please forward me (or to the email alias) an example bonding sysfs script which can be used to set bonding to work with patches 1-3? Sure, i did it along with sending the patches, you can the thing here:

Re: [PATCH 3/16] Spidernet RX Locking

2006-12-08 Thread Benjamin Herrenschmidt
A spinlock is expensive in the fast path, which is why Jeff says it's invasive. spider_net_decode_one_descr() is called from spider_net_poll() (which is the netdev-poll callback) and also from spider_net_handle_rxram_full(). The rxramfull routine is called from a tasklet that is fired off

[PATCH 04/22] e1000: display FC link properties

2006-12-08 Thread Kok, Auke
Previously there was no way of determining the actual flow control properties of a link state. We display them at link up to provide this information as some other drivers do. Ethtool needs probably to add this status information. Signed-off-by: Auke Kok [EMAIL PROTECTED] ---

[PATCH 02/22] ixgb: Maybe stop TX if not enough free descriptors

2006-12-08 Thread Kok, Auke
A similar patch to commit 65c7973fa5b46b024f38be208aa477e8daf9a603 but now for ixgb. Cc: Herbert Xu [EMAIL PROTECTED] Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb.h |1 + drivers/net/ixgb/ixgb_ethtool.c |1

[PATCH 03/22] ixgb: Write RA register high word first, increment version

2006-12-08 Thread Kok, Auke
We need to disable the AV bit before flushing the low register. Signed-off-by: [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/ixgb/ixgb_hw.c |3 ++- drivers/net/ixgb/ixgb_main.c |2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH 01/22] e1000: Fix early TSO completion

2006-12-08 Thread Kok, Auke
This fix was already merged in commit 96f9c2e277768099479fbed7c3b69c294b1fadef but reverted in commit 989316ddfeafd0e8fb51a4d811383769ad62637a. After stresstesting we found that the fix does not add new regressions and works around a TX hang spotted by several users. Signed-off-by: Jesse

[PATCH 00/22] ixgb, e1000 fixes

2006-12-08 Thread Kok, Auke
Hi, This patch series contains exclusively fixes for ixgb and e1000. Most importantly, it addresses two issues in the recently merged msi interrupt handler and dynamic itr code, as well as some major manageability feature handling code. These patches apply against netdev-2.6 #upstream-linus

[PATCH 06/22] e1000: minor tso ipv6 cleanups

2006-12-08 Thread Kok, Auke
Zero descriptor ip_config field and use skb_shinfo to detect IPV6 packet. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[PATCH 15/22] e1000: simplify msi specific interrupt handler

2006-12-08 Thread Kok, Auke
Simplify the msi interrupt handler to avoid issues with delayed ICR reads. This avoids adapter specific problems at the cost of some performance. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000.h |1 -

[PATCH 14/22] e1000: always turn on receives on esb2

2006-12-08 Thread Kok, Auke
In rare occasions, esb2 systems would end up started without the RX unit being turned on. Add a check that runs post-init to make sure. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c |7 +++ 1 files

[PATCH 22/22] # This series applies on GIT commit 0ae851352a87db3f829511816a2da227860bf585

2006-12-08 Thread Kok, Auke
00_ixgb_sentinel.patch 01_ixgb_maybe_stop_tx.patch 02_ixgb_reorder_write.patch 03_e1000_add_fc_detect_printout.patch 04_e1000_itr_fixups.patch 05_e1000_cosmetic_csum_changes.patch 06_e1000_fix_tx_carrier_errors.patch 07_e1000_init_release_manageability.patch 08_e1000_pba_calc.patch

[PATCH 20/22] e1000: Fix poor quad port performance with NAPI

2006-12-08 Thread Kok, Auke
This fix attempts to solve a customer reported issue with NAPI enabled e1000 having bad performance when transmitting simultaneously on four ports. The issue comes down to an interaction between NAPI hardware interrupt balancing, and the driver rescheduling poll on the same processor. We try to

[PATCH 07/22] e1000: omit stats for broken counter in 82543

2006-12-08 Thread Kok, Auke
82543 does not count tx_carrier_errors properly in FD mode. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

[PATCH 09/22] e1000: Fix PBA allocation calculations

2006-12-08 Thread Kok, Auke
Assign the PBA to be large enough to contain at least 2 jumbo frames on all adapters. This dramatically increases performance on several adapters and fixes TX performance degradation issues where the PBA was misallocated in the old algorithm. Signed-off-by: Bruce Allan [EMAIL PROTECTED]

[PATCH 05/22] e1000: dynamic itr code fixes

2006-12-08 Thread Kok, Auke
The dynamic interrupt rate control patches omitted proper counting for jumbo's and TSO. We also out the lower bits of a user-provided hardcoded itr setting beccause they are used for control. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] ---

[PATCH 13/22] e1000: disable TSO when debugging slab

2006-12-08 Thread Kok, Auke
CONFIG_DEBUG_SLAB kills TSO on the 82544, so we're better off turing TSO off in this rare case, assuming performance is not an issue for people running slab debugging. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c

[PATCH 19/22] e1000: Don't set tipg (fiber) timings for pci-e adapters to fix fiber output

2006-12-08 Thread Kok, Auke
the driver has (ancient) code for messing with TIPG from the 82542 days. Unfortunately this code was running on our current adapters and setting TIPG for fiber to be +1 over the copper value. This caused 1.45Mpps to be sent instead of 1.487Mpps. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED]

[PATCH 21/22] e1000: Version increment 7.3.20-k2 and minor cleanups

2006-12-08 Thread Kok, Auke
Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000.h |6 + drivers/net/e1000/e1000_hw.c| 52 +++ drivers/net/e1000/e1000_hw.h|1 + drivers/net/e1000/e1000_main.c |9 +++ drivers/net/e1000/e1000_osdep.h |

[PATCH 12/22] e1000: Fix powerdown link loss when forced to gig speed

2006-12-08 Thread Kok, Auke
disable phy power mode to prevent the NIC from attempting to autoneg to i10/100mbit when running in forced gig mode as it would lose link at shutdown. This allows you to force gig speed and still use WoL/IPMI after shutdow. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke

[PATCH 08/22] e1000: Fix all manageability workarounds

2006-12-08 Thread Kok, Auke
Several bugs existed in how we handle various manageability issues and workarounds. We consolidate all release and init code in two single functions and call them from appropriate locations. This fixes several BMC packet redirect issues and powerup/down hiccups. Add 3 extra packet redirect

[PATCH 16/22] e1000: Rewrite parm handling code to warn when forcing autoneg to gig only.

2006-12-08 Thread Kok, Auke
Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_param.c | 15 +++ 1 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/net/e1000/e1000_param.c b/drivers/net/e1000/e1000_param.c index

[PATCH 11/22] e1000: Fire a link even interrupt instead of a watchdog at init.

2006-12-08 Thread Kok, Auke
Instead of calling a watchdog event we let our interrupt handler cascade a link event. This allows us to spot link up immediately after _up() without racing against a new watchdog. Signed-off-by: Jesse Brandeburg [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] ---

[PATCH 17/22] e1000: set max frame size before enabling new link settings

2006-12-08 Thread Kok, Auke
Signed-off-by: Bruce Allan [EMAIL PROTECTED] Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_main.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c index cb6b732..34ceff1 100644 ---

Re: [Bug 7635] New: ioctl(fd,TCSBRK,1) on socket yields EFAULT, expected EINVAL/ENOTTY

2006-12-08 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 8 Dec 2006 14:00:21 -0800 That is not true on BSD or other unix standardish ioctl's. There are no conflicts between the TIOC... values and the SIOC... values There is absolutely nothing that we can do about this under Linux without breaking

Re: [NETLINK]: Restore API compatibility of address and neighbour bits

2006-12-08 Thread David Miller
From: Daniel Jacobowitz [EMAIL PROTECTED] Date: Fri, 8 Dec 2006 16:52:06 -0500 On Fri, Dec 08, 2006 at 01:47:52PM -0800, David Miller wrote: The _RTA and _PAYLOAD-macros are also part of userspace headers and need to be restored. Both dhcpclient and quagga need at least IFA_RTA

Re: [PATCH 04/26] rt2x00: EEPROM 93Cx6

2006-12-08 Thread Michael Wu
On Friday 08 December 2006 13:56, Ivo van Doorn wrote: I have checked the adm80211 code as well, it seems to behave quite the same, with the most notable difference the fact that adm80211 writes the READ_OPCODE and the word index within a single command, while in eeprom_93cx6 this is split

Re: [Devel] Re: Network virtualization/isolation

2006-12-08 Thread Herbert Poetzl
On Fri, Dec 08, 2006 at 12:57:49PM -0700, Eric W. Biederman wrote: Herbert Poetzl [EMAIL PROTECTED] writes: But, ok, it is not the real point to argue so much imho and waste our time instead of doing things. well, IMHO better talk (and think) first, then implement something ... not

Re: [Devel] Re: Network virtualization/isolation

2006-12-08 Thread Andrew Morton
On Sat, 9 Dec 2006 04:50:02 +0100 Herbert Poetzl [EMAIL PROTECTED] wrote: On Fri, Dec 08, 2006 at 12:57:49PM -0700, Eric W. Biederman wrote: Herbert Poetzl [EMAIL PROTECTED] writes: But, ok, it is not the real point to argue so much imho and waste our time instead of doing things.

Re: [Devel] Re: Network virtualization/isolation

2006-12-08 Thread Herbert Poetzl
On Fri, Dec 08, 2006 at 10:13:48PM -0800, Andrew Morton wrote: On Sat, 9 Dec 2006 04:50:02 +0100 Herbert Poetzl [EMAIL PROTECTED] wrote: On Fri, Dec 08, 2006 at 12:57:49PM -0700, Eric W. Biederman wrote: Herbert Poetzl [EMAIL PROTECTED] writes: But, ok, it is not the real point to

[PATCH] d80211: remove pkt_type/pkt_probe_resp

2006-12-08 Thread Michael Wu
d80211: remove pkt_type/pkt_probe_resp Nobody uses pkt_type, and the information can be obtained from the header. This removes it and the associated code that keeps tracks of it. Signed-off-by: Michael Wu [EMAIL PROTECTED] --- include/net/d80211.h |1 - net/d80211/ieee80211.c |

Re: [PATCH 3/10] cxgb3 - HW access routines - part 1

2006-12-08 Thread Jan Engelhardt
On Dec 7 2006 19:25, [EMAIL PROTECTED] wrote: +void t3_set_reg_field(struct adapter *adapter, unsigned int addr, u32 mask, +u32 val) +{ + u32 v = t3_read_reg(adapter, addr) ~mask; + + t3_write_reg(adapter, addr, v | val); + (void)t3_read_reg(adapter, addr);

Re: [PATCH 0/10] cxgb3: Chelsio T3 1G/10G ethernet device driver

2006-12-08 Thread Stephen Hemminger
Minor style stuff (that can be fixed later). 1) /* C style comments */ are preferred over // C++ style 2) Please use C99 style structure initializers especially for OS interface structures like ops for MII. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH 5/10] cxgb3 - scatter gather engine

2006-12-08 Thread Stephen Hemminger
The NAPI code in the cxgb2 driver was a mess (see patch today), don't know if cxgb3 could use the similar brain surgery.. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] 2.6 driver for Silan SC92031 (second try)

2006-12-08 Thread Cesar Eduardo Barros
From: Cesar Eduardo Barros [EMAIL PROTECTED] This is a driver for the Silan SC92031/Rsltek 8139D NIC chip. This chip is found on at least one counterfeit Encore ENL832-TX-RENT NIC [1], which came with a mini-CD with the 2.4 driver. A slightly older version of the driver was found at [2]. The

Re: [PATCH] 2.6 driver for Silan SC92031 (second try)

2006-12-08 Thread Andrew Morton
On Fri, 08 Dec 2006 18:17:06 -0200 Cesar Eduardo Barros [EMAIL PROTECTED] wrote: From: Cesar Eduardo Barros [EMAIL PROTECTED] This is a driver for the Silan SC92031/Rsltek 8139D NIC chip. ... +config SC92031 + depends on NET_PCI PCI EXPERIMENTAL + select CRC32 ... + }