Re: [Netchannels take19] new netchannel release.

2006-12-22 Thread Evgeniy Polyakov
On Fri, Dec 22, 2006 at 01:40:33AM +0100, Hans Henrik Happe ([EMAIL PROTECTED]) wrote: Code is in development state, but I would like to hear comments about overall design, features, usefullness for the kernel and get feedback on kernel side. I follow your work with great interest, even

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-22 Thread Jarek Poplawski
On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote: [PATCH] igmp: spin_lock_bh in timer igmp_timer_expire() uses spin_lock(im-lock) but this lock is also taken by other igmp timers, so it should be changed to bh version. ... but according to theory this doesn't matter. I was

Re: [PATCH] fix cfg80211 WE compat code

2006-12-22 Thread Johannes Berg
On Fri, 2006-12-22 at 00:30 -0500, Pavel Roskin wrote: Actually, iwpriv without arguments is still hosed. In this case, cfg80211_wext_ioctl() returns -EOPNOTSUPP. Ahrg, right, probably caused by me ripping out large chunks of code of of the base function after copying it as the cfg80211

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-22 Thread Herbert Xu
Jarek Poplawski [EMAIL PROTECTED] wrote: [PATCH] igmp: spin_lock_bh in timer igmp_timer_expire() uses spin_lock(im-lock) but this lock is also taken by other igmp timers, so it should be changed to bh version. When you're in a timer BH is already disabled. So this patch is redundant.

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-22 Thread Jarek Poplawski
On Fri, Dec 22, 2006 at 10:16:30PM +1100, Herbert Xu wrote: Jarek Poplawski [EMAIL PROTECTED] wrote: [PATCH] igmp: spin_lock_bh in timer igmp_timer_expire() uses spin_lock(im-lock) but this lock is also taken by other igmp timers, so it should be changed to bh version. When you're

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-22 Thread Ben Greear
Jarek Poplawski wrote: On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote: On 20-12-2006 03:13, Ben Greear wrote: This is from 2.6.18.2 kernel with my patch set. The MAC-VLANs are in active use. From the backtrace, I am thinking this might be a generic problem, however. Any

Re: [PATCH] igmp: spin_lock_bh in timer (Re: BUG: soft lockup detected on CPU#0!)

2006-12-22 Thread Ben Greear
Jarek Poplawski wrote: On Fri, Dec 22, 2006 at 08:13:08AM +0100, Jarek Poplawski wrote: On 20-12-2006 03:13, Ben Greear wrote: This is from 2.6.18.2 kernel with my patch set. The MAC-VLANs are in active use. From the backtrace, I am thinking this might be a generic problem, however. Any

[PATCH] Fix up smc911x after work_struct changes

2006-12-22 Thread Peter Korsgaard
Fix up the smc911x driver after the work_struct changes. Signed-off-by: Peter Korsgaard [EMAIL PROTECTED] diff -urpN linux-2.6.20-rc1/drivers/net/smc911x.c linux-2.6.20-rc1.new/drivers/net/smc911x.c --- linux-2.6.20-rc1/drivers/net/smc911x.c 2006-11-29 22:57:37.0 +0100 +++

Re: Generic PHY lib vs. locking

2006-12-22 Thread David Hollis
On Fri, 2006-12-22 at 15:07 +1100, Benjamin Herrenschmidt wrote: Hi Andy ! I've been looking at porting various drivers (EMAC, sungem, spider_net, ...) to the generic PHY stuff. However, I have one significant problem here. One solution would be to change it to use a mutex instead of a

The new SSB subsystem for bcm43xx (and others)

2006-12-22 Thread Michael Buesch
and such an embedded device natively. In previous implementations the normal bcm43xx PCI driver was run on these devices, by emulating a PCI bus on top of the real SSB Bus. The Quilt series for all this can be downloaded here: http://bu3sch.de/misc/new-ssb-20061222.tar.bz2 This series applies against my wireless

removing gotos considered harmful...

2006-12-22 Thread David Miller
Because of massively painful regressions like the following, I absolutely refuse to apply cleanup patches to remove gotos for clarity. All such patches do is change the code and potentially add bugs, they don't help in any way at all. Gerrit, please be more careful next time, and resist the

Re: Generic PHY lib vs. locking

2006-12-22 Thread Benjamin Herrenschmidt
On Fri, 2006-12-22 at 10:24 -0500, David Hollis wrote: On Fri, 2006-12-22 at 15:07 +1100, Benjamin Herrenschmidt wrote: Hi Andy ! I've been looking at porting various drivers (EMAC, sungem, spider_net, ...) to the generic PHY stuff. However, I have one significant problem here.

Re: removing gotos considered harmful...

2006-12-22 Thread Arnaldo Carvalho de Melo
On 12/22/06, David Miller [EMAIL PROTECTED] wrote: Because of massively painful regressions like the following, I absolutely refuse to apply cleanup patches to remove gotos for clarity. All such patches do is change the code and potentially add bugs, they don't help in any way at all. Gerrit,

Fwd: d80211 and SMP

2006-12-22 Thread mohamed Abbas
Hi I was looking at SMP issues in d80211 stack, below in my finding. I did change the d80211 stack to add SMP safety code. I will email these patches later after I update them with what ever feedback I will get back. The D80211 stack has many entry points; this could leads to race conditions

d80211 and SMP issues

2006-12-22 Thread mohamed Abbas
Hi Sorry if you receive this email twice, my email is acting a little weird. I was looking at SMP issues in d80211 stack, below in my finding. I did change the d80211 stack to add SMP safety code. I will email these patches later after I update them with what ever feedback I will get back.

Re: [PATCH 2/10] cxgb3 - main source file

2006-12-22 Thread Arjan van de Ven
Using request_firmware assumes that the driver knows the FW file name no it knows an ALIAS for it. and the driver initiates the load. That's not our model where we work with different FWs, don't know what the names are, you can have the user make a symlink to the one he wants. No Big Deal.

[RFC][PATCH -mm 0/5] proposal for dynamic configurable netconsole

2006-12-22 Thread Keiichi KII
From: Keiichi KII [EMAIL PROTECTED] The netconsole is a very useful module for collecting kernel message under certain circumstances(e.g. disk logging fails, serial port is unavailable). But current netconsole is not flexible. For example, if you want to change ip address for logging agent, in

[RFC][PATCH -mm 3/5] add interface for netconsole using sysfs

2006-12-22 Thread Keiichi KII
From: Keiichi KII [EMAIL PROTECTED] This patch contains the following changes. create a sysfs entry for netconsole in /sys/class/misc. This entry has elements related to netconsole as follows. You can change configuration of netconsole(writable attributes such as IP address, port number and so

[RFC][PATCH -mm 4/5] switch function of netpoll

2006-12-22 Thread Keiichi KII
From: Keiichi KII [EMAIL PROTECTED] This patch contains switch function of netpoll. If enabled attribute of certain port is '1', this port is used and the configurations of this port are uable to change. If enabled attribute of certain port is '0', this port isn't used and the configurations of

[RFC][PATCH -mm 5/5] add add element in /sys/class/misc/netconsole

2006-12-22 Thread Keiichi KII
From: Keiichi KII [EMAIL PROTECTED] This patch contains the following changes. To add port dynamically, create add element in /sys/class/misc/netconsole. ex) echo @/eth0,@192.168.0.1/ /sys/class/misc/netconsole/add then the port is added with the settings sending kernel messages to

bcm43xx from 2.6.20-rc1-mm1 on HPC nx6325 (x86_64)

2006-12-22 Thread Larry Finger
I'm trying to make the bcm43xx driver out of the 2.6.20-rc1-mm1 kernel work on an HPC nx6325, with no luck, so far, although I'm using a firmware that has been reported to work with these boxes (http://gentoo-wiki.com/HARDWARE_Gentoo_on_HP_Compaq_nx6325#Onboard_Wireless_.28802.11.29). The driver

Re: [RFC][PATCH -mm 0/5] proposal for dynamic configurable netconsole

2006-12-22 Thread Stephen Hemminger
On Fri, 22 Dec 2006 21:01:09 +0900 Keiichi KII [EMAIL PROTECTED] wrote: From: Keiichi KII [EMAIL PROTECTED] The netconsole is a very useful module for collecting kernel message under certain circumstances(e.g. disk logging fails, serial port is unavailable). But current netconsole is not

netfilter tables config problem

2006-12-22 Thread Randy Dunlap
(on 2.6.20-rc1-git8) It's possible to have CONFIG_NETFILTER_XTABLES=y and CONFIG_IP6_NF_MATCH_IPV6HEADER=m, which causes this build error: net/built-in.o: In function `hashlimit_match': xt_hashlimit.c:(.text+0x1c887): undefined reference to `ipv6_find_hdr' make: *** [.tmp_vmlinux1] Error 1