Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-09 Thread Jarek Poplawski
On Mon, Jan 08, 2007 at 10:03:50AM -0800, Stephen Hemminger wrote: On Mon, 08 Jan 2007 08:57:10 -0800 Ben Greear [EMAIL PROTECTED] wrote: Jarek Poplawski wrote: On Fri, Jan 05, 2007 at 12:33:43PM -0800, Ben Greear wrote: ... So, I do believe this was the problem we were

Re: [PATCH] INET: fix incorrect inet_sock-is_icsk assignment

2007-01-09 Thread Jarek Poplawski
On Mon, Jan 08, 2007 at 09:47:29AM -0500, Paul Moore wrote: ... I guess it all depends on who is reading it ;) Sure! I only had a feeling your way is maybe slightly less often used so I wanted some opinion. Personally, I don't care too much either way as long as it is fixed. Yes, you've

Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-09 Thread Thibaut VARENE
On 1/9/07, Jarek Poplawski [EMAIL PROTECTED] wrote: On Tue, Jan 09, 2007 at 11:27:59AM +0100, Thibaut VARENE wrote: ... I suspected both and changed both the disk and the ram for quality parts, that I tested afterwards. Both passed thorough tests. You wrote about half an hour, so overheating

Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-09 Thread Jarek Poplawski
On Tue, Jan 09, 2007 at 11:56:59AM +0100, Thibaut VARENE wrote: ... I'm suspecting the driver, but I'm not a specialist :) No problem, me also! I've also suspected the driver, looked at the code, found nothing yet (as expected), but this info about exception in malloc, introduces some doubts...

Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-09 Thread Jarek Poplawski
On Tue, Jan 09, 2007 at 11:27:59AM +0100, Thibaut VARENE wrote: ... I suspected both and changed both the disk and the ram for quality parts, that I tested afterwards. Both passed thorough tests. Finally, using the other NIC on the box (a VIA Rhine II, 100Mbps), works absolutely fine. If

Re: [PATCH 1/5] s390: qeth driver fixes

2007-01-09 Thread Frank Pavlic
Sorry for the trouble and also thank you very much for having done the extra work. I made the patches using git-format-patch so seems that I have to review them more carefully or I still haven't understand to use git-format-patch properly. In any case I will read the documents you mentioned once

Re: [PATCH 1/5] s390: qeth driver fixes

2007-01-09 Thread Jeff Garzik
Frank Pavlic wrote: Sorry for the trouble and also thank you very much for having done the extra work. I made the patches using git-format-patch so seems that I have to review them more carefully or I still haven't understand to use git-format-patch properly. In any case I will read the

Re: Using 802.11x wireless usb device on MIPS platform

2007-01-09 Thread Ralf Baechle
On Tue, Jan 09, 2007 at 10:52:14AM +0800, colin wrote: I have used two 802.11x wireless usb devices successfully on MIPS platform. One is realtek 8187 and the other one is ralink 2571. I would like to put them into kernel tree and then I found that there are not many 802.11x devices supported

Re: [PATCH] INET: fix incorrect inet_sock-is_icsk assignment

2007-01-09 Thread Paul Moore
On Tuesday 09 January 2007 3:43 am, Jarek Poplawski wrote: ... But if you consider this code will probably become classical and will be read, quoted and teached next 1000 years, then the style could matter... This from the guy who believes Justin Timberlake rocks! ;) All right, you convinced

Re: [PATCH] INET: fix incorrect inet_sock-is_icsk assignment

2007-01-09 Thread Arnaldo Carvalho de Melo
On 1/9/07, Paul Moore [EMAIL PROTECTED] wrote: On Tuesday 09 January 2007 3:43 am, Jarek Poplawski wrote: ... But if you consider this code will probably become classical and will be read, quoted and teached next 1000 years, then the style could matter... This from the guy who believes

RED + ECN not working

2007-01-09 Thread rbj2
Hello, I have been trying to get the RED qdisc and ECN to work for the past few weeks and all my experiments have failed. Here is the setup I am using. Src -- R1 -- R2 -- Dst Between Src and R1 is a 100Mbps link and between R1 and R2 a 10Mbps link. I set up the qdisc at R1 as follows tc

Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-09 Thread Thibaut VARENE
On 1/9/07, Jarek Poplawski [EMAIL PROTECTED] wrote: On Tue, Jan 09, 2007 at 11:27:59AM +0100, Thibaut VARENE wrote: ... I suspected both and changed both the disk and the ram for quality parts, that I tested afterwards. Both passed thorough tests. Finally, using the other NIC on the box (a

[PATCH] INET: style updates for the inet_sock-is_icsk assignment fix

2007-01-09 Thread Paul Moore
A quick patch to change the inet_sock-is_icsk assignment to better fit with existing kernel coding style. Signed-off-by: Paul Moore [EMAIL PROTECTED] Cc: Jarek Poplawski [EMAIL PROTECTED] Cc: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/ipv4/af_inet.c |2 +- net/ipv6/af_inet6.c |2

Re: [PATCH 3/3] chelsio: more rx speedup

2007-01-09 Thread Stephen Hemminger
On Tue, 9 Jan 2007 09:42:03 +0100 Ingo Oeser [EMAIL PROTECTED] wrote: Hi Stephen, Stephen Hemminger schrieb: --- netdev-2.6.orig/drivers/net/chelsio/sge.c +++ netdev-2.6/drivers/net/chelsio/sge.c [...] @@ -1043,45 +1046,42 @@ static void recycle_fl_buf(struct freelQ * be copied but

[PATCH] Fix phy_read/write redefinition errors in ucc_geth_phy.c

2007-01-09 Thread timur
From: Timur Tabi [EMAIL PROTECTED] The local versions of phy_read() and phy_write() in ucc_geth_phy.c conflict with the prototypes in include/linux/phy.h, so this patch renames them, moves them to the top of the file (while eliminating the redundant prototype), and makes them static.

[PATCH] Update ucc_geth.c for new workqueue structure

2007-01-09 Thread timur
From: Timur Tabi [EMAIL PROTECTED] The workqueue interface changed with David Howell's patch on 11/22/2006 (SHA 65f27f38446e1976cc98fd3004b110fedcddd189). Several drivers were updated with that patch to handle the new interface, but ucc_geth.c was not one of them. This patch updates ucc_geth.c

Re: [PATCH] INET: style updates for the inet_sock-is_icsk assignment fix

2007-01-09 Thread Arnaldo Carvalho de Melo
On 1/9/07, Paul Moore [EMAIL PROTECTED] wrote: A quick patch to change the inet_sock-is_icsk assignment to better fit with existing kernel coding style. Signed-off-by: Paul Moore [EMAIL PROTECTED] Cc: Jarek Poplawski [EMAIL PROTECTED] Cc: Arnaldo Carvalho de Melo [EMAIL PROTECTED]

Re: Using 802.11x wireless usb device on MIPS platform

2007-01-09 Thread Michael Wu
On Tuesday 09 January 2007 09:09, Ralf Baechle wrote: On Tue, Jan 09, 2007 at 10:52:14AM +0800, colin wrote: I have used two 802.11x wireless usb devices successfully on MIPS platform. One is realtek 8187 and the other one is ralink 2571. I would like to put them into kernel tree and then I

[PATCH] [SCTP]: Fix err_hdr assignment in sctp_init_cause.

2007-01-09 Thread Sridhar Samudrala
[SCTP]: Fix err_hdr assignment in sctp_init_cause. The subh-err_hdr should point to the error header, not the data. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] Signed-off-by: Sridhar Samudrala [EMAIL PROTECTED] --- net/sctp/sm_make_chunk.c |4 ++-- 1 files changed, 2 insertions(+), 2

fixing opt-ack DoS against TCP stack

2007-01-09 Thread Gavin McCullagh
Hi, recently, a few of us came up with a novel (or so we thought) DoS attack against TCP. We spent some time implementing and testing it and found it to work worryingly well. It turns out that we are not the first to come across this attack. Rob Sherwood and colleagues in Maryland were a year

Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-09 Thread Dale Farnsworth
On Tue, Jan 09, 2007 at 06:44:49PM +0100, Thibaut VARENE wrote: On 1/9/07, Jarek Poplawski [EMAIL PROTECTED] wrote: On Tue, Jan 09, 2007 at 11:27:59AM +0100, Thibaut VARENE wrote: ... I suspected both and changed both the disk and the ram for quality parts, that I tested afterwards. Both

[PATCH 0/3] myri10ge minor updates for 2.6.20

2007-01-09 Thread Brice Goglin
Hi Jeff, These should be the last 3 patches to finalize myri10ge version 1.2.0: 1. myri10ge: make wc_fifo usage load-time tunable 2. myri10ge: check that we can get an irq 3. myri10ge: update driver version to 1.2.0 Please apply to 2.6.20. thanks, Brice - To unsubscribe from this list: send the

[PATCH 3/3] myri10ge: update driver version to 1.2.0

2007-01-09 Thread Brice Goglin
Driver is now at version 1.2.0. Signed-off-by: Brice Goglin [EMAIL PROTECTED] --- drivers/net/myri10ge/myri10ge.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-rc/drivers/net/myri10ge/myri10ge.c === ---

[PATCH 1/3] myri10ge: make wc_fifo usage load-time tunable

2007-01-09 Thread Brice Goglin
Under some circumstances, using WC without the WC fifo is faster. So we make it possible to tune wc_fifo with a module parameter. Signed-off-by: Brice Goglin [EMAIL PROTECTED] --- drivers/net/myri10ge/myri10ge.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Index:

[PATCH 2/3] myri10ge: check that we can get an irq

2007-01-09 Thread Brice Goglin
Now that IRQ allocation is done in myri10ge_open(), we want to still check when loading the driver that IRQ allocation could succeed later. Additionaly, we fix the initialization and printing of netdev-irq. Signed-off-by: Brice Goglin [EMAIL PROTECTED] --- drivers/net/myri10ge/myri10ge.c | 15

Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-09 Thread Thibaut VARENE
On 1/9/07, Dale Farnsworth [EMAIL PROTECTED] wrote: On Tue, Jan 09, 2007 at 06:44:49PM +0100, Thibaut VARENE wrote: On 1/9/07, Jarek Poplawski [EMAIL PROTECTED] wrote: On Tue, Jan 09, 2007 at 11:27:59AM +0100, Thibaut VARENE wrote: ... I suspected both and changed both the disk and the ram

[PATCH 5/12] forcedeth: optimized routines

2007-01-09 Thread Ayaz Abdulla
This patch breaks up the routines into two versions, one for legacy descriptor versions (ver 1 and ver 2) and one for desc ver 3. This will make the new desc functions more leaner and further reductions will be made in next few patches. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] ---

[PATCH 0/12] forcedeth optimizations

2007-01-09 Thread Ayaz Abdulla
This set of patches contains optimizations for the forcedeth driver that help reduce CPU utilization and increase throughput, especially for small packet sizes. The main changes include ring accessing, tx locking, optimizing code branches, remove descriptor checks in data paths, reducing

[PATCH 7/12] forcedeth: tx data path optimization

2007-01-09 Thread Ayaz Abdulla
This patch optimizes the tx data paths and cleans up the code (removes vlan from descr1/2 since only valid for desc3, changes to make code easier to read, etc). Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 14:05:28.0 -0500 +++

[PATCH 8/12] forcedeth: rx data path optimization

2007-01-09 Thread Ayaz Abdulla
This patch optimizes the rx data paths and cleans up the code. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 14:06:32.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-08 14:18:37.0 -0500 @@ -1317,9 +1317,9 @@

[PATCH 10/12] forcedeth: tx max work

2007-01-09 Thread Ayaz Abdulla
This patch adds a limit to how much tx work can be done in each iteration of tx processing. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 20:34:35.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-08 20:35:22.0 -0500 @@ -1859,14

[PATCH 11/12] forcedeth: statistics supported

2007-01-09 Thread Ayaz Abdulla
This patch introduces hw statistics for older devices that supported it. It breaks up the counters supported into separate versions. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 20:35:53.0 -0500 +++ new/drivers/net/forcedeth.c

[PATCH 12/12] forcedeth: statistics optimization

2007-01-09 Thread Ayaz Abdulla
This patch optimizes the data paths that can support hw counters. It removes the sw counted statistics. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 18:32:08.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-08 18:42:58.0 -0500

[PATCH 1/12] forcedeth: dma access

2007-01-09 Thread Ayaz Abdulla
This patch allows the hardware to fetch the tx and rx ring descriptors with 64 bytes per access instead of 32 bytes. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-07 15:10:15.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-07

[PATCH 3/12] forcedeth: tx locking

2007-01-09 Thread Ayaz Abdulla
This patch reduces the amount of code within the lock to only the critical sections. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-07 22:30:08.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-07 22:30:02.0 -0500 @@ -1569,12

[PATCH 2/12] forcedeth: ring access

2007-01-09 Thread Ayaz Abdulla
This patch modifys ring access by using pointers. This avoids computing the current index and avoids accessing the base address of the rings. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 13:31:01.0 -0500 +++

[PATCH 4/12] forcedeth: rx skb recycle

2007-01-09 Thread Ayaz Abdulla
This patch removes the code that recycled the skb on error. This will help in reducing the branches in the main data paths. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-07 22:31:14.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-07

[PATCH 6/12] forcedeth: tx limiting

2007-01-09 Thread Ayaz Abdulla
This patch optimizes the logic for tx limiting. It adds a flag to check on the completion side instead of recalculating the number of empty slots. Also, it removes the fields that were previous used for limiting since they have no value. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] ---

[PATCH 9/12] forcedeth: irq data path optimization

2007-01-09 Thread Ayaz Abdulla
This patch optimizes the irq data paths and cleans up the code. Signed-Off-By: Ayaz Abdulla [EMAIL PROTECTED] --- orig/drivers/net/forcedeth.c2007-01-08 20:33:47.0 -0500 +++ new/drivers/net/forcedeth.c 2007-01-08 20:33:39.0 -0500 @@ -2777,7 +2777,6 @@

Re: [patch]net/xfrm:fix crash in ipsec audit logging

2007-01-09 Thread Joy Latten
On Tue, 2006-12-26 at 13:37 -0500, jamal wrote: On Tue, 2006-26-12 at 18:56 +0100, Ingo Molnar wrote: + xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid, + AUDIT_MAC_IPSEC_DELSPD, delete, xp, NULL); + if (!delete) { struct sk_buff

[PATCH] d80211: don't symlink empty default keys

2007-01-09 Thread Jan Kiszka
This gets rid of annoying wlan0: cannot create symlink to default key in my syslog with latest rt2x00. The patch takes care that in case of (key/old_key == NULL set_tx_key) the existing default key symlink is removed correctly. Moreover, it tests for key!=NULL before trying to register a new

Re: [PATCH] [SCTP]: Fix err_hdr assignment in sctp_init_cause.

2007-01-09 Thread David Miller
From: Sridhar Samudrala [EMAIL PROTECTED] Date: Tue, 09 Jan 2007 11:26:49 -0800 [SCTP]: Fix err_hdr assignment in sctp_init_cause. The subh-err_hdr should point to the error header, not the data. Signed-off-by: Vlad Yasevich [EMAIL PROTECTED] Signed-off-by: Sridhar Samudrala [EMAIL

Re: [PATCH] INET: style updates for the inet_sock-is_icsk assignment fix

2007-01-09 Thread David Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Tue, 9 Jan 2007 16:45:12 -0200 On 1/9/07, Paul Moore [EMAIL PROTECTED] wrote: A quick patch to change the inet_sock-is_icsk assignment to better fit with existing kernel coding style. Signed-off-by: Paul Moore [EMAIL PROTECTED] Cc:

Re: [PATCH] devinet: inetdev_init out label moved after RCU assignment

2007-01-09 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Fri, 5 Jan 2007 22:23:53 +1100 On Fri, Jan 05, 2007 at 12:19:10PM +0100, Jarek Poplawski wrote: Why me? (I didn't spoil this!) You spotted the problem, so it's only fair that you get the credit :) Subject: [PATCH] devinet: inetdev_init out

Re: [PATCH] d80211: don't symlink empty default keys

2007-01-09 Thread Jan Kiszka
Jan Kiszka wrote: This gets rid of annoying wlan0: cannot create symlink to default key in my syslog with latest rt2x00. The patch takes care that in case of (key/old_key == NULL set_tx_key) the existing default key symlink is removed correctly. Moreover, it tests for key!=NULL before

[PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-01-09 Thread Andy Gospodarek
These changes eliminate the messages indicating that the rtnetlink lock isn't held when bonding tries to change the MAC address of an interface. These calls generally come from timer-pops, but also from sysfs events since neither hold the rtnl lock. The spew generally looks something like

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-01-09 Thread Stephen Hemminger
On Tue, 9 Jan 2007 17:59:01 -0500 Andy Gospodarek [EMAIL PROTECTED] wrote: These changes eliminate the messages indicating that the rtnetlink lock isn't held when bonding tries to change the MAC address of an interface. These calls generally come from timer-pops, but also from sysfs events

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-01-09 Thread Jeff Garzik
Andy Gospodarek wrote: -void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave) +void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave, int rtnl_locked) { struct slave *swap_slave; int i; Although this is not a direct NAK

Re: [PATCH 1/1] bonding: eliminate RTNL assertion spew

2007-01-09 Thread Andy Gospodarek
On Tue, Jan 09, 2007 at 06:13:55PM -0500, Jeff Garzik wrote: Andy Gospodarek wrote: -void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave) +void bond_alb_handle_active_change(struct bonding *bond, struct slave *new_slave, int rtnl_locked) { struct slave

Re: [PATCH 3/3] chelsio: more rx speedup

2007-01-09 Thread Divy Le Ray
Stephen Hemminger wrote: On Tue, 9 Jan 2007 09:42:03 +0100 Ingo Oeser [EMAIL PROTECTED] wrote: Hi Stephen, Stephen Hemminger schrieb: --- netdev-2.6.orig/drivers/net/chelsio/sge.c +++ netdev-2.6/drivers/net/chelsio/sge.c [...] @@ -1043,45 +1046,42 @@ static void

Re: Question on advanced routing and/or virtual routers.

2007-01-09 Thread Ben Greear
Brendan Cully wrote: I started something like this a while ago (posted at [EMAIL PROTECTED] with a couple of replies by Thomas Graf, but I can't seem to find it in the archives) but then dropped the ball. It seems to work fairly well with a one-line kernel patch to allow route lookup before the

[PACKET]: Add PACKET_AUXDATA cmsg

2007-01-09 Thread Herbert Xu
Hi Dave: [PACKET]: Add optional checksum computation for recvmsg This patch is needed to make ISC's DHCP server (and probably other DHCP servers/clients using AF_PACKET) to be able to serve another client on the same Xen host. The problem is that packets between different domains on the same

Re: [PATCH] Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2007-01-09 Thread David Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Tue, 09 Jan 2007 14:22:44 +0900 (JST) Dave, please apply. Thank you. In article [EMAIL PROTECTED] (at Tue, 9 Jan 2007 07:11:39 +0200), Craig Schlenter [EMAIL PROTECTED] says: All credit goes to Komuro [EMAIL PROTECTED] for tracking this

[git patches, updated] net driver fixes

2007-01-09 Thread Jeff Garzik
[resend; updated with a few more bug fixes, since yesterday] Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/chelsio/my3126.c|5 +-

Re: [PATCH 1/10] cxgb3 - main header files

2007-01-09 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] This patch implements the main header files of the Chelsio T3 network driver. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] Once you think it's ready, email me a URL to a single patch that adds the driver to the

Re: [git patches, updated] net driver fixes

2007-01-09 Thread Josef Sipek
On Tue, Jan 09, 2007 at 04:50:59AM -0500, Jeff Garzik wrote: ... diff --git a/drivers/net/chelsio/my3126.c b/drivers/net/chelsio/my3126.c index c7731b6..82fed1d 100644 --- a/drivers/net/chelsio/my3126.c +++ b/drivers/net/chelsio/my3126.c @@ -170,9 +170,10 @@ static struct cphy

Re: [PATCH 1/10] cxgb3 - main header files

2007-01-09 Thread Jeff Garzik
Divy Le Ray wrote: Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] This patch implements the main header files of the Chelsio T3 network driver. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] Once you think it's ready, email me a URL to a single patch that adds the

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2007-01-09 Thread Komuro
On Thu, 4 Jan 2007 14:23:30 +0200 Craig Schlenter [EMAIL PROTECTED] wrote: --- linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c.orig 2007-01-03 11:50:04.0 +0900 +++ linux-2.6.20-rc3/net/ipv4/tcp_ipv4.c2007-01-03 15:30:44.0 +0900 @@ -648,7 +648,7 @@ static void

Re: [PATCH 1/10] cxgb3 - main header files

2007-01-09 Thread Roland Dreier
You can grab the monolithic patch at this URL: http://service.chelsio.com/kernel.org/cxgb3.patch.bz2 this is in my queue, thanks. Sorry I didn't indicate that earlier. When do you plan to merge it? For 2.6.20 or .21? I'm trying to understand when the RDMA stuff that depends on the

Re: [PATCH 1/10] cxgb3 - main header files

2007-01-09 Thread Jeff Garzik
Roland Dreier wrote: You can grab the monolithic patch at this URL: http://service.chelsio.com/kernel.org/cxgb3.patch.bz2 this is in my queue, thanks. Sorry I didn't indicate that earlier. When do you plan to merge it? For 2.6.20 or .21? The time for adding new stuff to 2.6.20

Re: [PATCH 1/10] cxgb3 - main header files

2007-01-09 Thread Roland Dreier
The time for adding new stuff to 2.6.20 is /long/ past. We stop adding things like new drivers when Linus releases 2.6.X-rc1. Well, in the past I think new drivers have been added after the merge window, given that there's no chance of regressions (old kernel == no support for device X, so

[PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Andrew, All, This patch contains a major rewrite to the e1000 driver that groups and separates e1000 hardware by chipset family. It abstracts the hardware specific code into an API that will allow us to continue to maintain the complex e1000 driver and add new hardware support to it without

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Stephen Hemminger
On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: Andrew, All, This patch contains a major rewrite to the e1000 driver that groups and separates e1000 hardware by chipset family. It abstracts the hardware specific code into an API that will allow us to continue to

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Andrew Morton
On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.6 e1000 That tree appears to be based on the -mm git tree? That's a somewhat unusual thing to do - a tree which is based on current Linus mainline would be

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Stephen Hemminger wrote: On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: Andrew, All, This patch contains a major rewrite to the e1000 driver that groups and separates e1000 hardware by chipset family. It abstracts the hardware specific code into an API that will allow

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Andrew Morton wrote: On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.6 e1000 That tree appears to be based on the -mm git tree? That's a somewhat unusual thing to do - a tree which is based on current Linus

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Randy Dunlap
On Tue, 09 Jan 2007 20:16:27 +0100 Krzysztof Halasa wrote: Auke Kok [EMAIL PROTECTED] writes: drivers/net/e1000/Makefile| 19 drivers/net/e1000/e1000.h | 95 drivers/net/e1000/e1000_80003es2lan.c | 1330 + drivers/net/e1000/e1000_80003es2lan.h | 89

[IPv6] PROBLEM? Network unreachable despite correct route

2007-01-09 Thread Bernhard Schmidt
Hi, I'm having a really ugly problem I'm trying to pinpoint, but failed so far. I'm neither completely convinced it is not related to my local setup(s), nor do I have any clue how this might be caused. I have several boxes with native IPv6 connectivity at various places. Some of them show

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Randy Dunlap wrote: On Tue, 09 Jan 2007 20:16:27 +0100 Krzysztof Halasa wrote: Auke Kok [EMAIL PROTECTED] writes: drivers/net/e1000/Makefile| 19 drivers/net/e1000/e1000.h | 95 drivers/net/e1000/e1000_80003es2lan.c | 1330 +

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Krzysztof Halasa
Auke Kok [EMAIL PROTECTED] writes: drivers/net/e1000/Makefile| 19 drivers/net/e1000/e1000.h | 95 drivers/net/e1000/e1000_80003es2lan.c | 1330 + drivers/net/e1000/e1000_80003es2lan.h | 89 drivers/net/e1000/e1000_82540.c | 586 ++

Re: [PATCH -MM] e1000: rewrite hardware initialization code

2007-01-09 Thread Auke Kok
Andrew Morton wrote: On Tue, 09 Jan 2007 09:36:29 -0800 Auke Kok [EMAIL PROTECTED] wrote: git-pull git://lost.foo-projects.org/~ahkok/git/linux-2.6 e1000 That tree appears to be based on the -mm git tree? That's a somewhat unusual thing to do - a tree which is based on current Linus

[PATCH 1/5] fixing errors handling during pci_driver resume stage [net]

2007-01-09 Thread Dmitriy Monakhov
network pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED] - diff --git a/Makefile b/Makefile diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c index 80bdcf8..ed06e48 100644 --- a/drivers/net/3c59x.c +++

[PATCH 2/5] fixing errors handling during pci_driver resume stage [ata]

2007-01-09 Thread Dmitriy Monakhov
ata pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED] - diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index b517d24..0656334 100644 --- a/drivers/ata/ahci.c +++ b/drivers/ata/ahci.c @@ -1372,7 +1372,9

[PATCH 3/5] fixing errors handling during pci_driver resume stage [fusion]

2007-01-09 Thread Dmitriy Monakhov
fusion pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED] - diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 6e068cf..51a3621 100644 --- a/drivers/message/fusion/mptbase.c

[PATCH 5/5] fixing errors handling during pci_driver resume stage [serial]

2007-01-09 Thread Dmitriy Monakhov
serial pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED] - diff --git a/drivers/parport/parport_serial.c b/drivers/parport/parport_serial.c index 78c0a26..1e14906 100644 --- a/drivers/parport/parport_serial.c

[PATCH 4/5] fixing errors handling during pci_driver resume stage [misc]

2007-01-09 Thread Dmitriy Monakhov
pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED] - diff --git a/drivers/ide/pci/sc1200.c b/drivers/ide/pci/sc1200.c index ff80937..a426905 100644 --- a/drivers/ide/pci/sc1200.c +++ b/drivers/ide/pci/sc1200.c

Re: [PATCH 5/5] fixing errors handling during pci_driver resume stage [serial]

2007-01-09 Thread Russell King
On Tue, Jan 09, 2007 at 12:01:58PM +0300, Dmitriy Monakhov wrote: serial pci drivers have to return correct error code during resume stage in case of errors. Sigh. *hate* *hate* *hate*. diff --git a/drivers/serial/8250_pci.c b/drivers/serial/8250_pci.c index 52e2e64..e26e4a6 100644 ---

Re: [PATCH 5/5] fixing errors handling during pci_driver resume stage [serial]

2007-01-09 Thread Dmitriy Monakhov
Russell King [EMAIL PROTECTED] writes: On Tue, Jan 09, 2007 at 12:01:58PM +0300, Dmitriy Monakhov wrote: serial pci drivers have to return correct error code during resume stage in case of errors. Sigh. *hate* *hate* *hate*. diff --git a/drivers/serial/8250_pci.c

Re: [PATCH 1/5] fixing errors handling during pci_driver resume stage [net]

2007-01-09 Thread Stephen Hemminger
On Tue, 09 Jan 2007 12:01:14 +0300 Dmitriy Monakhov [EMAIL PROTECTED] wrote: network pci drivers have to return correct error code during resume stage in case of errors. Signed-off-by: Dmitriy Monakhov [EMAIL PROTECTED] - Please don't introduce one dev_err() call into a device driver if

Re: [IPv6] PROBLEM? Network unreachable despite correct route

2007-01-09 Thread Bernhard Schmidt
On Tue, Jan 09, 2007 at 08:36:24PM +0100, Bernhard Schmidt wrote: Hi, I did some additional testing I'm having a really ugly problem I'm trying to pinpoint, but failed so far. I'm neither completely convinced it is not related to my local setup(s), nor do I have any clue how this might be

[PATCH] d80211: Fix __ieee80211_if_del on live interfaces

2007-01-09 Thread Michael Wu
d80211: Fix __ieee80211_if_del on live interfaces ieee80211_if_reinit is called in __ieee80211_if_del, which clears the contents of sdata-u. After that, unregister_netdevice is called. If the interface is still up, unregister_netdevice will end up calling dev-stop, and dev-stop expects the

d80211: 80211n

2007-01-09 Thread mohamed Abbas
is there any one working on the implementation of 11n to d80211 stack? I have been trying to add 11n support to d80211 stack and wondering if someone else doing the same so we can coordinate our work. I was able to parse and add IE information, handling Rx aggregation and handling 11n action

Re: [PATCH/RFC 01/10] Implement local diversion of IPv4 skbs

2007-01-09 Thread Patrick McHardy
KOVACS Krisztian wrote: The input path for non-local bound sockets requires diverting certain packets locally, even if their destination IP address is not considered local. We achieve this by assigning a specially crafted dst entry to these skbs, and optionally also attaching a socket to the

Re: [PATCH/RFC 05/10] Remove local address check on IP output

2007-01-09 Thread Patrick McHardy
KOVACS Krisztian wrote: ip_route_output() contains a check to make sure that no flows with non-local source IP addresses are routed. Unfortunately this check makes it completely impossible to use non-local bound sockets as no outbound packets will make through the stack. This patch moves

[IPSEC] flow: Cache negative results

2007-01-09 Thread Herbert Xu
Hi: [IPSEC] flow: Cache negative security checks This patch causes security policy denials to be cached instead of causing a relookup every time. This is OK because we already cache positive security policy results which is strictly worse as far as security is concerned. In particular, if the

Re: [PATCH 1/10] cxgb3 - main header files

2007-01-09 Thread Steve Wise
Roland, The T3 Ethernet driver is queued for inclusion into Jeff's tree. How do you want to merge in the RDMA driver? I can give you a single monolithic patch if you want. We also need to decide on the ib_req_notify_cq() issue. Steve. On Tue, 2007-01-09 at 05:28 -0500, Jeff Garzik

Re: [PATCH 1/10] cxgb3 - main header files

2007-01-09 Thread Michael S. Tsirkin
We also need to decide on the ib_req_notify_cq() issue. Let's clarify - do you oppose doing copy_from_user from a fixed address passed in during setup? If OK with you, this seems the best way as it is the least controversial and least disruptive one. -- MST - To unsubscribe from this list:

Re: [PATCH 1/10] cxgb3 - main header files

2007-01-09 Thread Steve Wise
On Tue, 2007-01-09 at 15:57 +0200, Michael S. Tsirkin wrote: We also need to decide on the ib_req_notify_cq() issue. Let's clarify - do you oppose doing copy_from_user from a fixed address passed in during setup? So far its been you and I arguing over this issue. Before I go implement

RE: [openib-general] [PATCH 1/10] cxgb3 - main header files

2007-01-09 Thread Caitlin Bestler
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Michael S. Tsirkin Sent: Tuesday, January 09, 2007 5:57 AM To: Steve Wise Cc: netdev@vger.kernel.org; Roland Dreier; Divy Le Ray; linux-kernel@vger.kernel.org; openib-general Subject: Re:

Re: [openib-general] [PATCH 1/10] cxgb3 - main header files

2007-01-09 Thread Steve Wise
In the interest of expediting this I'll go implement it... Steve. Here it is. I think this is the correct way to solve the issue (now that I've implemented it :). This is a delta from the driver patch series just for reviewing purposes. commit e6053f2aee764b21e28cbb19f52995cb413cf733