[git patches] net driver fixes

2007-01-22 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c | 56 +- driver

Re: Can someone please try...

2007-01-22 Thread Pavel Roskin
On Mon, 2007-01-22 at 22:00 +0100, Michael Buesch wrote: > > No more random crashes. There is still a crash if I rmmod the driver > > while wlan0 is up, but it's a separate issue, and it's easy to avoid > > (unlike the interface going down). I hope to look at it soon. > > Did you apply that d80

Re: [PATCH 11/12] forcedeth: statistics supported

2007-01-22 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch introduces hw statistics for older devices that supported it. It breaks up the counters supported into separate versions. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> ACK patches 11-12 - To unsubscribe from this list: send the line "unsubscribe netdev" in th

Re: [PATCH 10/12] forcedeth: tx max work

2007-01-22 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch adds a limit to how much tx work can be done in each iteration of tx processing. If the max limit is reached, remaining tx completions will be handled by timer interrupt. Signed-Off-By: Ayaz Abdulla <[EMAIL PROTECTED]> you attached the entire driver, rather tha

Re: [PATCH 7/12] forcedeth: tx data path optimization

2007-01-22 Thread Jeff Garzik
Ayaz Abdulla wrote: --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you

Re: [PATCH 2/2] NetXen: Use pci_register_driver() instead of pci_module_init() in init_module

2007-01-22 Thread Jeff Garzik
Amit S. Kale wrote: I am extremely sorry for sending this patch with wrong subject line before this. Now i am resending the patch with correct line. Thanks, --Amit Please include comments such as the above quoted /below/ the "---" terminator. The git merge scripts copy everything preceding

Re: [PATCH 5/12] forcedeth: optimized routines

2007-01-22 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch breaks up the routines into two versions, one for legacy descriptor versions (ver 1 and ver 2) and one for desc ver 3. This will make the new desc functions more leaner and further reductions will be made in next few patches. Signed-Off-By: Ayaz Abdulla <[EMAIL PRO

Re: [PATCH 1/2] NetXen: Firmware check modifications

2007-01-22 Thread Jeff Garzik
Amit S. Kale wrote: This patch is to make the driver work with multiple minor firmware versions Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> applied 1-2 to #upstream-fixes comments on patch #2 follow this email - To unsubscribe from this list: send the line "unsubscribe netdev" in the bo

Re: [PATCH 2.6.20-rc5 1/7] ehea: Fixed wrong dereferencation

2007-01-22 Thread Jeff Garzik
Thomas Klein wrote: Not only check the pointer against 0 but also the dereferenced value Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |6 -- 2 files changed, 5 insertions(+), 3 deletions(-) applied 1-7 to #u

Re: [PATCH 0/4] atl1: Attansic L1 ethernet driver

2007-01-22 Thread Jeff Garzik
Jay Cliburn wrote: This is the latest submittal of the patchset providing support for the Attansic L1 gigabit ethernet adapter. This patchset is built against kernel version 2.6.20-rc5. This version incorporates all comments from: Christoph Hellwig: http://lkml.org/lkml/2007/1/11/43 http://l

Re: [PATCH] PHY: Export phy ethtool helpers

2007-01-22 Thread Jeff Garzik
Kumar Gala wrote: We need to export phy_ethtool_gset and phy_ethtool_sset to allow drivers that use these functions to be built as modules. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> your patch was corrupt. applied manually Jeff - To unsubscribe from this list: send the line "

Re: [PATCH 1/4] bonding: fix device name allocation error

2007-01-22 Thread Jeff Garzik
Jay Vosburgh wrote: The code to select names for the bonding interfaces was, for the non-sysfs creation case, always using a hard-coded set of bond0, bond1, etc, up to max_bonds. This caused conflicts for the second or subsequent loads of the module. Changed the code to obtain d

Re: [PATCH 2.6.20 5/5] s2io: De-typedef driver.

2007-01-22 Thread Jeff Garzik
Ananda Raju wrote: Removed namespace collisions due to usage of nic_t as per Ralf's patch ([EMAIL PROTECTED]). Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> ACK Please make the following the first line of your email body: From: Ralf Baechle <[EMAIL PROTECTED]> That will tell the pa

Re: [PATCH 2.6.20 4/5] s2io: Removed enabling of some of the unused interrupts.

2007-01-22 Thread Jeff Garzik
Ananda Raju wrote: Removed unused code in en_dis_able_nic_intrs(), TX_DMA_INTR, RX_DMA_INTR, TX_XGXS_INTR, MC_INTR Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> ACK - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 2.6.20 3/5] s2io: Fixes in updating skb->truesize and code cleanup.

2007-01-22 Thread Jeff Garzik
Ananda Raju wrote: @@ -6999,7 +7003,7 @@ s2io_init_nic(struct pci_dev *pdev, cons goto mem_alloc_failed; } - sp->bar0 = ioremap(pci_resource_start(pdev, 0), + sp->bar0 = (caddr_t) ioremap(pci_resource_start(pdev, 0), pci_resour

Re: [PATCH 2.6.20 2/5] S2IO: Fixes for reset and link handling.

2007-01-22 Thread Jeff Garzik
Ananda Raju wrote: 1. Fix for reset and link handling. 2. Allow for promiscuos mode and multicast state be maintained through ifconfig up and down. 3. Support to print adapter serial number. Signed-off-by: Sivakumar Subramani <[EMAIL PROTECTED]> overall, looks OK, but have small nits noted

Re: why would EPIPE cause socket port to change?

2007-01-22 Thread Herbert Xu
dean gaudet <[EMAIL PROTECTED]> wrote: > in the test program below the getsockname result on a TCP socket changes > across a write which produces EPIPE... here's a fragment of the strace: > > getsockname(3, {sa_family=AF_INET, sin_port=htons(37636), > sin_addr=inet_addr("127.0.0.1")}, [178635937

Re: [PATCH 2.6.20 1/5] s2io: Making LRO and UFO as module loadable parameter.

2007-01-22 Thread Jeff Garzik
Ananda Raju wrote: This patch adds two load parameters napi and ufo. Previously NAPI was compilation option with these changes wan enable disable NAPI using load parameter. Also we are introducing ufo load parameter to enable/disable ufo feature Signed-off-by: Sivakumar Subramani <[EMAIL PROTECT

Re: Please pull 'upstream' branch of wireless-2.6

2007-01-22 Thread Jeff Garzik
John W. Linville wrote: The following changes since commit 10764889c6355cbb335cf0578ce12427475d1a65: Larry Finger (1): bcm43xx: Fix failure to deliver PCI-E interrupts are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstre

why would EPIPE cause socket port to change?

2007-01-22 Thread dean gaudet
in the test program below the getsockname result on a TCP socket changes across a write which produces EPIPE... here's a fragment of the strace: getsockname(3, {sa_family=AF_INET, sin_port=htons(37636), sin_addr=inet_addr("127.0.0.1")}, [17863593746633850896]) = 0 ... write(3, "hi!\n", 4)

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-22 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Mon, 22 Jan 2007 13:15:28 -0500), Neil Horman <[EMAIL PROTECTED]> says: > Reposted patch, with your suggestions/corrections incorporated. The only > thing > I left alone was your last comment regarding the checking of saddr for being a > unicast addres

Re: [BUG] e100: eth0 appers many times in /proc/interrupts after resume

2007-01-22 Thread Auke Kok
Frederik Deweerdt wrote: On Sun, Jan 21, 2007 at 01:45:27PM -0800, Auke Kok wrote: Frederik Deweerdt wrote: On Sun, Jan 21, 2007 at 09:17:41PM +0200, Andrei Popa wrote: It's the 10th resume and in /proc/interrupts eth0 appers 10 times. The e100_resume() function should be calling netif_device

Re: [PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-01-22 Thread Andi Kleen
On Tuesday 23 January 2007 00:00, Neil Horman wrote: > As it is currently written, sys_select checks its return code to convert > ERESTARTNOHAND to EINTR. However, the check is within an if (tvp) clause, > and so if select is called from userspace with a NULL timeval, then it is > possible for the

Re: [PATCH 50/59] sysctl: Move utsname sysctls to their own file

2007-01-22 Thread Herbert Poetzl
On Wed, Jan 17, 2007 at 12:31:22PM -0700, Eric W. Biederman wrote: > Kirill Korotaev <[EMAIL PROTECTED]> writes: > > > Eric, though I personally don't care much: > > 1. I ask for not setting your authorship/copyright on the code which you > > just > > copied > > from other places. Just doesn't

Re: [PATCH 25/59] sysctl: C99 convert arch/frv/kernel/pm.c

2007-01-22 Thread Herbert Poetzl
On Wed, Jan 17, 2007 at 08:14:17PM +0300, Kirill Korotaev wrote: > another small minor note. > > > From: Eric W. Biederman <[EMAIL PROTECTED]> - unquoted > > > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> > > --- > > arch/frv/kernel/pm.c | 50 > >

Re: Can someone please try...

2007-01-22 Thread Larry Finger
Michael Buesch wrote: > On Monday 22 January 2007 21:44, Pavel Roskin wrote: >> The problems with a MadWifi based AP turn out to be related to 802.11g. >> If the AP is configured for 802.11b only, everything is working. If >> 802.11g is enabled, strange things are happening. Judging by what's on

Re: adm8211 (from linville wireless-2.6) in xen guest

2007-01-22 Thread Jan Evert van Grootheest
Michael, Michael Wu wrote: On Saturday 20 January 2007 07:19, Jan Evert van Grootheest wrote: One question, though. I'm trying to use it in ad-hoc mode. If there's no other station with the same essid, it just keeps mentioning that (besides the BCNTC and TSFTF messages) wlan0: No matching a

Bluetooth fixes for 2.6.20-rc5

2007-01-22 Thread Marcel Holtmann
Hi Dave, here are two additional fixes for the Bluetooth subsystem that should go in before the final 2.6.20 release. It was possible that the well known PSM could be bound by anybody. That should not be possible like TCP/IP ports below 1024 are also restricted. The other one is a simple endian fi

Re: Can someone please try...

2007-01-22 Thread Michael Buesch
On Monday 22 January 2007 21:44, Pavel Roskin wrote: > Hello, Michael! > > On Mon, 2007-01-22 at 21:06 +0100, Michael Buesch wrote: > > It's obviously some stack/memory corruption. But I'm not > > sure if this is a stackoverflow. I'd rather say no, it isn't. > > > > Could probably be triggered b

Re: Can someone please try...

2007-01-22 Thread Pavel Roskin
Hello, Michael! On Mon, 2007-01-22 at 21:06 +0100, Michael Buesch wrote: > It's obviously some stack/memory corruption. But I'm not > sure if this is a stackoverflow. I'd rather say no, it isn't. > > Could probably be triggered by something like kfree()ing > a dangling pointer or something... Y

Re: [PATCH] bcm43xx: Fix problem with >1 GB RAM

2007-01-22 Thread Michael Buesch
On Monday 22 January 2007 21:18, Larry Finger wrote: > When I looked at the b44 driver to see how that code handled the problem, it > used the pci-form of > the calls rather than the dma-version. Thus I switched early in the debug > process - even before I > had the necessary hardware. Once I got

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-22 Thread Vlad Yasevich
Hi Neil I don't this is still right... > @@ -746,6 +772,7 @@ static void ndisc_recv_ns(struct sk_buff *skb) > int dad = ipv6_addr_any(saddr); > int inc; > int is_router; > + int type; > > if (ipv6_addr_is_multicast(&msg->target)) { > ND_PRINTK2(KERN_WAR

Re: [PATCH] bcm43xx: Fix problem with >1 GB RAM

2007-01-22 Thread Larry Finger
Michael Buesch wrote: > On Saturday 20 January 2007 17:18, Larry Finger wrote: >> Some versions of the bcm43xx chips only support 30-bit DMA, which means >> that the descriptors and buffers must be in the first 1 GB of RAM. On >> the i386 and x86_64 architectures with more than 1 GB RAM, an incorre

Re: Can someone please try...

2007-01-22 Thread Michael Buesch
On Friday 19 January 2007 08:54, Pavel Roskin wrote: > Hello, Michael! > > I did more testing, and the results are following. It looks like the > oopses and panics on i386 were triggered by 4k stacks. x86_64 doesn't > have this option. > > Now that I enabled other debug options on both platform

Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver

2007-01-22 Thread Luca Tettamanti
Il Sun, Jan 21, 2007 at 09:33:39PM -0600, Jay Cliburn ha scritto: > Randy Dunlap wrote: > >On Sun, 21 Jan 2007 15:07:37 -0600 Jay Cliburn wrote: > [snip] > > >>+ value = ioread16(hw->hw_addr + REG_PCIE_CAP_LIST); > >>+ return ((value & 0xFF00) == 0x6C00) ? 0 : 1; > > > >Are there defines or e

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-22 Thread Neil Horman
On Mon, Jan 22, 2007 at 08:39:24PM +0200, Mika Penttilä wrote: > Neil Horman wrote: > > I think you should remove / modify the : > if (!dad) >goto out; > > which makes the rfc4429 tests not functional. > > --Mika > Yeah, I think you're right. In fact, as I look at it more closely I think

Re: [git patches] net driver fixes

2007-01-22 Thread Auke Kok
Jeff Garzik wrote: Auke Kok wrote: Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus Jeff, is there a reason that you didn't pull the e1000 tree from us? I send you all the information 5 days ago

Re: adm8211 (from linville wireless-2.6) in xen guest

2007-01-22 Thread Michael Wu
On Saturday 20 January 2007 07:19, Jan Evert van Grootheest wrote: > Hi, > > Just writing to thank all of you that made the adm8211 driver in John > Linvilles wireless-2.6 development tree (not the dscape one, which I > will try also). > CC me then. :) Note that I only maintain the d80211 based adm

Re: [git patches] net driver fixes

2007-01-22 Thread Jeff Garzik
Auke Kok wrote: Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus Jeff, is there a reason that you didn't pull the e1000 tree from us? I send you all the information 5 days ago, WITH the changes t

Re: [git patches] net driver fixes

2007-01-22 Thread Auke Kok
Jeff Garzik wrote: Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus Jeff, is there a reason that you didn't pull the e1000 tree from us? I send you all the information 5 days ago, WITH the changes that you requested

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-22 Thread Mika Penttilä
Neil Horman wrote: On Sat, Jan 20, 2007 at 08:05:07AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: Hello. In article <[EMAIL PROTECTED]> (at Fri, 19 Jan 2007 16:23:14 -0500), Neil Horman <[EMAIL PROTECTED]> says: Patch to Implement IPv6 RFC 4429 (Optimistic Duplicate Address Detection). I

[git patches] net driver fixes

2007-01-22 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/8139cp.c|7 +- drivers/net/myri10ge/myri10ge.c | 23 - drivers/net/sis190.c

Re: [PATCH] bcm43xx_d80211: Fix major memory corruption bug

2007-01-22 Thread Michael Buesch
On Sunday 21 January 2007 06:27, Pavel Roskin wrote: > Set phy->lo_control to NULL whenever it's freed. Failure to do so leads > to zeroing a block of memory that uses to hold *phy->lo_control, which > caused random crashes down the road. > > Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> Good

Re: [PATCH] bcm43xx: Fix problem with >1 GB RAM

2007-01-22 Thread Michael Buesch
On Saturday 20 January 2007 17:18, Larry Finger wrote: > Some versions of the bcm43xx chips only support 30-bit DMA, which means > that the descriptors and buffers must be in the first 1 GB of RAM. On > the i386 and x86_64 architectures with more than 1 GB RAM, an incorrect > assignment may occur.

Re: [PATCH] IPv6: Implement RFC 4429 Optimistic Duplicate Address Detection

2007-01-22 Thread Neil Horman
On Sat, Jan 20, 2007 at 08:05:07AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote: > Hello. > > In article <[EMAIL PROTECTED]> (at Fri, 19 Jan 2007 16:23:14 -0500), Neil > Horman <[EMAIL PROTECTED]> says: > > > Patch to Implement IPv6 RFC 4429 (Optimistic Duplicate Address Detection). > > In > > Good

Re: [PATCH] bcm43xx: Check error returns in initialization routines

2007-01-22 Thread Michael Buesch
On Friday 19 January 2007 05:06, Larry Finger wrote: > A number of the calls in the initialization routines fail to check the > returned value for > errors. This patch adds the necessary checks and logs any errors found when > appropriate. ACK > Signed-off-by: Larry Finger <[EMAIL PROTECTED]> >

Re: [PATCH] Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-22 Thread Dale Farnsworth
Jarek and Thibaut, Thank you both very much for your work finding and fixing this bug. Jarek, can you verify that the following patch fixes the problem you were seeing? -Dale - Patch follows - From: Dale Farnsworth <[EMAIL PROTECTED]> mv643xx_eth: Fix race condition in mv643xx_eth_free

Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver

2007-01-22 Thread Jay Cliburn
Arjan, thank you very much for reviewing the driver. Arjan van de Ven wrote: On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote: [snip] +void atl1_irq_disable(struct atl1_adapter *adapter) +{ + atomic_inc(&adapter->irq_sem); + iowrite32(0, adapter->hw.hw_addr + REG_IMR); +

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-22 Thread Jon Smirl
On 1/22/07, Marcelo Tosatti <[EMAIL PROTECTED]> wrote: On Wed, Jan 17, 2007 at 06:01:24PM +, Johannes Berg wrote: > On Wed, 2007-01-17 at 12:43 -0500, Dan Williams wrote: > > > I said "mostly" fullmac. Sort of like ipw2100 (IIRC) is softmac but it > > does all the association stuff in firmwa

[PATCH 2/2] NetXen: Use pci_register_driver() instead of pci_module_init() in init_module

2007-01-22 Thread Amit S. Kale
I am extremely sorry for sending this patch with wrong subject line before this. Now i am resending the patch with correct line. Thanks, --Amit This will use pci_register_driver() instead of pci_module_init(). Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> Signed-off-by: Richard Knutsson <[EMAI

[PATCH 1/2] NetXen: Firmware check modifications

2007-01-22 Thread Amit S. Kale
This will use pci_register_driver() instead of pci_module_init(). Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- netxen_nic.h |2 +- netxen_nic_main.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH 1/2] NetXen: Firmware check modifications

2007-01-22 Thread Amit S. Kale
This patch is to make the driver work with multiple minor firmware versions Signed-off-by: Amit S. Kale <[EMAIL PROTECTED]> --- netxen_nic.h|7 +++ netxen_nic_hw.c |3 ++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/netxen/netxen_nic.h b/drivers/net

[PATCH 0/2] NetXen: NetXen 1G/10G Ethernet Driver updates

2007-01-22 Thread Amit S. Kale
I will be sending NetXen: 1G/10G Ethernet Driver updates in subsequent emails. Thanks, --Amit - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] tcp_output: Re: rare bad TCP checksum with 2.6.19?

2007-01-22 Thread Patrick McHardy
Herbert Xu wrote: > On Mon, Jan 22, 2007 at 07:52:14AM +0100, Jarek Poplawski wrote: > >> >>I was so impressed by the amount of work done by Michael >>that I magnified his merit and forgot to mention the role >>of Patrick and Herbert, particularly here: > > > You don't need to be so modest! >

[PATCH] select: fix sys_select to not leak ERESTARTNOHAND to userspace

2007-01-22 Thread Neil Horman
As it is currently written, sys_select checks its return code to convert ERESTARTNOHAND to EINTR. However, the check is within an if (tvp) clause, and so if select is called from userspace with a NULL timeval, then it is possible for the ERESTARTNOHAND errno to leak into userspace, which is incorr

Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().

2007-01-22 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2007-01-17 13:33 > [NETLINK]: Don't BUG on undersized allocations > > Currently netlink users BUG when the allocated skb for an event > notification is undersized. While this is certainly a kernel bug, > its not critical and crashing the kernel is too drastic,

[PATCH 2.6.20-rc5 7/7] ehea: Fixed possible nullpointer access

2007-01-22 Thread Thomas Klein
Fixed possible nullpointer access in event queue processing Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff -Nurp -X dontdiff linux-2.6.20-rc5/drivers/net/ehea/ehea_main.c patched_kernel/driv

[PATCH 2.6.20-rc5 6/7] ehea: Added logging off associated errors

2007-01-22 Thread Thomas Klein
Added logging of error events associated with a specific queue pair Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff -Nurp -X dontdiff linux-2.6.20-rc5/drivers/net/ehea/ehea_main.c patched_

[PATCH 2.6.20-rc5 5/7] ehea: Improved logging of permission issues

2007-01-22 Thread Thomas Klein
Disabled dump of hcall regs on some permission issues and fixed appropriate misleading logmessages Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c | 16 +++- drivers/net/ehea/ehea_phyp.c | 10 -- 2 files changed, 15 insertions(+), 11 dele

[PATCH 2.6.20-rc5 4/7] ehea: New method to determine number of available ports

2007-01-22 Thread Thomas Klein
Count OFDT nodes to determine the number of available ports instead of using the possibly outdated value from the hypervisor Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletion(-) diff -Nurp -X

[PATCH 2.6.20-rc5 3/7] ehea: Modified initial autoneg state determination

2007-01-22 Thread Thomas Klein
Logical partitions are not allowed to (try to) set the autonegotiation status. This patch removes the respective function call from the port setup function. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletion

[PATCH 2.6.20-rc5 2/7] ehea: Fixing firmware queue config issue

2007-01-22 Thread Thomas Klein
Fix to use exactly one queue for incoming packets in all firmware configurations Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea_main.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -Nurp -X dontdiff linux-2.6.20-rc5/drivers/net/ehea/ehea_main.c pat

[PATCH 2.6.20-rc5 1/7] ehea: Fixed wrong dereferencation

2007-01-22 Thread Thomas Klein
Not only check the pointer against 0 but also the dereferenced value Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> --- drivers/net/ehea/ehea.h |2 +- drivers/net/ehea/ehea_main.c |6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff -Nurp -X dontdiff linux-2.6.20-rc5

Re: [PATCH 2/4] atl1: Header files for Attansic L1 driver

2007-01-22 Thread Francois Romieu
> diff --git a/drivers/net/atl1/atl1_hw.h b/drivers/net/atl1/atl1_hw.h > new file mode 100644 > index 000..0450b77 > --- /dev/null > +++ b/drivers/net/atl1/atl1_hw.h [...] > +/* MII definition */ > +/* PHY Common Register */ > +#define MII_BMCR 0x00 > +#defi

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-22 Thread Marcelo Tosatti
On Wed, Jan 17, 2007 at 06:01:24PM +, Johannes Berg wrote: > > 3) Could you enumerate your issues with the command dispatching? Right > > now, many of the commands are blocking, which is suboptimal. This is an > > artifact of the embedded history of the part. We need to eventually fix > > t

Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver (v2)

2007-01-22 Thread Marcelo Tosatti
On Wed, Jan 17, 2007 at 06:01:24PM +, Johannes Berg wrote: > On Wed, 2007-01-17 at 12:43 -0500, Dan Williams wrote: > > > I said "mostly" fullmac. Sort of like ipw2100 (IIRC) is softmac but it > > does all the association stuff in firmware. It doesn't fit fullmac, but > > it's a lot more ful

Re: [PATCH] Re: kernel BUG in eth_alloc_tx_desc_index at drivers/net/mv643xx_eth.c:1069!

2007-01-22 Thread Jarek Poplawski
On Sun, Jan 21, 2007 at 02:02:15PM +0100, Thibaut VARENE wrote: > On 1/21/07, Thibaut VARENE <[EMAIL PROTECTED]> wrote: ... > >Hmm, I think this is guaranteed not to work. In between those lines > >the lock is released, while data in the mp structure is still being > >accessed. It seems that this b

Re: wake_up() takes long time to return

2007-01-22 Thread kalash nainwal
On 1/20/07, Arjan van de Ven <[EMAIL PROTECTED]> wrote: On Sat, 2007-01-20 at 15:54 +0530, kalash nainwal wrote: > Hi there, > > We've a kernel (n/w) module, which sits over ethernet. Whenever a pkt > is received (in softirq), after doing some minimal processing, > wake_up() is called to wake up

Re: [PATCH] tcp_output: Re: rare bad TCP checksum with 2.6.19?

2007-01-22 Thread Jarek Poplawski
On Mon, Jan 22, 2007 at 06:45:57PM +1100, Herbert Xu wrote: > On Mon, Jan 22, 2007 at 07:52:14AM +0100, Jarek Poplawski wrote: > > > > I was so impressed by the amount of work done by Michael > > that I magnified his merit and forgot to mention the role > > of Patrick and Herbert, particularly he

Re: [PATCH 3/4] atl1: Main C file for Attansic L1 driver

2007-01-22 Thread Arjan van de Ven
On Sun, 2007-01-21 at 15:06 -0600, Jay Cliburn wrote: > + > + /* PCI config space info */ > + pci_read_config_byte(pdev, PCI_REVISION_ID, &hw->revision_id); > + pci_read_config_word(pdev, PCI_COMMAND, &hw->pci_cmd_word); I'm highly suspicious of drivers that use the PCI_COMMAND word...

Re: [PATCH] tcp_output: Re: rare bad TCP checksum with 2.6.19?

2007-01-22 Thread Jarek Poplawski
On Mon, Jan 22, 2007 at 10:19:18AM +0300, Michael Tokarev wrote: ... > I was only running tcpdump - yes, it was running almost the > whole day, with different options. I did almost nothing. > > You over-estimate my contribution, really ;) > > The very good thing is that this bug is now found, an