From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 16 Mar 2007 06:30:48 +0100 (MET)
These patches convert the packet schedulers to use ktime as only clock
source and kill off the manual clock source selection. Additionally all
packet schedulers are converted to use hrtimer-based watchdogs,
David Miller wrote:
All 11 patches applied and pushed out, very very nice work
Patrick!
Thanks Dave :)
It would be nice to figure out why CBQ isn't working for
you, I know at least some folks have used it successfully
at some point.
Probably my own incompetence, I'll see if I can find some
[NET_SCHED]: sch_htb: use hrtimer based watchdog
Signed-off-by: Patrick McHardy [EMAIL PROTECTED]
Acked-by: Martin Devera [EMAIL PROTECTED]
---
commit a5eaa252c5da48fef25a308ebc99b4020dad7f64
tree a609ff508f5ec9a93df1ace8f814aa0a71a5ff97
parent 2d548d3ea10cb1b49db8913fbab32811d9e7c3d0
author
Hi Samuel,
Samuel Ortiz wrote:
This patch allows us to bypass the IrDA stack down to the IrLAP level.
Sending and receiving frames is done through a character device.
This is useful for e.g. doing real IrDA sniffing, testing external IrDA
stacks and for Lirc (once I will add the framing
Hello.
The patch below adds break condition for the resize operations. If
we don't achieve the desired fill factor a warning is printed. Trie
should still be operational but new thresholds should be considered.
Cheers
--ro
Signed-off-by: Robert Olsson
The threshold for root node can be more aggressive set to get
better tree compression. The new setting mekes the root grow
from 16 to 19 bits and substansial improvemnt in Aver depth
this with the current table of 214393 prefixes
But really the dynamic resize should need more investigation
The airo driver leaks memory if request_irq() fails.
Signed-off-by: Michal Schmidt [EMAIL PROTECTED]
diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 71ac1f1..0d5b433 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -2850,7 +2850,7 @@
The way airo.c keeps track of all its devices is complicated and buggy
as well (del_airo_dev forgets to free the memory add_airo_dev allocates).
It's cleaner to use the standard list primitives.
While we're at it, it's not necessary to put PCI cards in the list, because
the kernel already keeps
Hello, Just discussed this Patrick...
We have two users of trie_leaf_remove, fn_trie_flush and fn_trie_delete
both are holding RTNL. So there shouldn't be need for this preempt stuff.
This is assumed to a leftover from an older RCU-take.
Mhh .. I think I just remembered something - me
* Patrick McHardy [EMAIL PROTECTED] 2007-03-16 10:42
David Miller wrote:
It would be nice to figure out why CBQ isn't working for
you, I know at least some folks have used it successfully
at some point.
Probably my own incompetence, I'll see if I can find some
scripts that are known to
Thomas Graf wrote:
* Patrick McHardy [EMAIL PROTECTED] 2007-03-16 10:42
David Miller wrote:
It would be nice to figure out why CBQ isn't working for
you, I know at least some folks have used it successfully
at some point.
Probably my own incompetence, I'll see if I can find some
scripts that
Fix a warning introduced by my patches, seems like I didn't pay
enough attention ..
[NET_SCHED]: Fix warning
net/sched/sch_api.c: In function 'psched_show':
net/sched/sch_api.c:1219: warning: format '%08x' expects type 'unsigned int',
but argument 6 has type 's64'
Signed-off-by: Patrick
On Thu, Mar 15, 2007 at 11:13:07AM -0400, Jeff Garzik wrote:
more bitfields, more endianness bugs.
I stopped reviewing there. Repost when these issues have been fixed, as
it will be far easier to review the driver then.
Also, do not bother to post the firmware include in email. Post a
It is guaranteed to be valid only when !tp-sacked_out. In most
cases this seqno is available in the last ACK but there is no
guarantee for that. The new fast recovery loss marking algorithm
needs this as entry point.
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
include/linux/tcp.h |2
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
net/ipv4/tcp_input.c | 31 ---
1 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index dbc98ce..870404b 100644
--- a/net/ipv4/tcp_input.c
+++
This patchset provides new LOST detection algorithm. This is part
of tcp_sock diet program. Removes couple of hints, sadly enough this
is a tradeoff as one u32 is necessary for the new algorithm even though
most of the time the last SACK would give all necessary information.
It might be useful
Complete rewrite for update_scoreboard and mark_head_lost. Couple
of hints became unnecessary because of this change, NewReno code
was greatly simplified. I changed !TCPCB_TAGBITS check from the
original to a !(S|L) check but it shouldn't make a difference,
and if there ever is a R only skb TCP
1) Couple of skb states are mutually exclusive
Skb cannot be in both S and L states at the same time, adding
non-S nor L skb count (below highest sack) to that can be
compared against fackets_out to see if anything below the
current skb can still be marked with L or not. If they're
equal (or
Many assumptions that are true when no reordering or other
strange events happen are not a part of the RFC3517. FACK
implementation is based on such assumptions. Previously (before
the rewrite) the non-FACK SACK was basically doing fast rexmit
and then it times out all skbs when first cumulative
Many assumptions that are true when no reordering or other
strange events happen are not a part of the RFC3517. FACK
implementation is based on such assumptions. Previously (before
the rewrite) the non-FACK SACK was basically doing fast rexmit
and then it times out all skbs when first cumulative
On Thu, 15 Mar 2007 09:17:22 -0400
Benjamin LaHaise [EMAIL PROTECTED] wrote:
On Thu, Mar 15, 2007 at 12:25:16AM -0700, David Miller wrote:
Could we obtain %rip relative addressing with the ELF
relocation approach I mentioned?
I think we can for some of the objects -- things like slab
The ipv6_fl_socklist from listening socket is inadvertently shared
with new socket created for connection. This leads to a variety of
interesting, but fatal, bugs. For example, removing one of the
sockets may lead to the other socket's encountering a page fault
when the now freed list is
On Thu, 15 Mar 2007 13:55:36 +0100
Nadia Derbey [EMAIL PROTECTED] wrote:
Hi,
Trying to compile iproute2 (downloaded from
http://developer.osdl.org/dev/iproute2/download/iproute2-2.6.20-070313.tar.gz)
I get the following error message.
gcc -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall
It is guaranteed to be valid only when !tp-sacked_out. In most
cases this seqno is available in the last ACK but there is no
guarantee for that. The new fast recovery loss marking algorithm
needs this as entry point.
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
include/linux/tcp.h |2
Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
net/ipv4/tcp_input.c | 31 ---
1 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index dbc98ce..870404b 100644
--- a/net/ipv4/tcp_input.c
+++
It's strange how I always manage to find couple of problems quite soon
after I've sent things to public... :-) Once again two important fixes
to v4.
This patchset provides new LOST detection algorithm. This is part
of tcp_sock diet program. Removes couple of hints, sadly enough this
is a tradeoff
Complete rewrite for update_scoreboard and mark_head_lost. Couple
of hints became unnecessary because of this change, NewReno code
was greatly simplified. I changed !TCPCB_TAGBITS check from the
original to a !(S|L) check but it shouldn't make a difference,
and if there ever is a R only skb TCP
Many assumptions that are true when no reordering or other
strange events happen are not a part of the RFC3517. FACK
implementation is based on such assumptions. Previously (before
the rewrite) the non-FACK SACK was basically doing fast rexmit
and then it times out all skbs when first cumulative
1) Couple of skb states are mutually exclusive
Skb cannot be in both S and L states at the same time, adding
non-S nor L skb count (below highest sack) to that can be
compared against fackets_out to see if anything below the
current skb can still be marked with L or not. If they're
equal (or
From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 16 Mar 2007 13:45:32 +0100
Thomas Graf wrote:
* Patrick McHardy [EMAIL PROTECTED] 2007-03-16 10:42
David Miller wrote:
It would be nice to figure out why CBQ isn't working for
you, I know at least some folks have used it successfully
From: Patrick McHardy [EMAIL PROTECTED]
Date: Fri, 16 Mar 2007 14:35:04 +0100
Fix a warning introduced by my patches, seems like I didn't pay
enough attention ..
Applied, thanks Patrick.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
Hi Ingo,
On Fri, Mar 16, 2007 at 11:02:04AM +0100, Ingo Oeser wrote:
--- /dev/null
+++ b/include/net/irda/irlap_raw.h
@@ -0,0 +1,27 @@
+/*
+ * Copyright (C) 2007 Samuel Ortiz ([EMAIL PROTECTED])
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
Thanks a lot!
- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Some more cases...
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/ipv4/igmp.c |2 +-
net/ipv4/ip_output.c|2 +-
net/ipv6/exthdrs.c |2 +-
net/ipv6/netfilter/nf_conntrack_reasm.c |4 ++--
4 files
For the common sequence skb-h.raw - skb-nh.raw, similar to skb-mac_len,
that is precalculated tho, don't think we need to bloat skb with one more
member, so just use this new helper, reducing the number of non-skbuff.h
references to the layer headers even more.
Signed-off-by: Arnaldo Carvalho de
With this we save 8 bytes per network packet, leaving a 4 bytes hole to be used
in further shrinking work, likely with the offsetization of other pointers,
such as -{data,tail,end}, at the cost of adds, that were minimized by the
usual practice of setting skb-{mac,nh,n}.raw to a local variable
Update to skge driver:
1-3 bug fixes for upstream-fixes
4-7 improvements for later releases
--
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Do some minor rearrangement of data structures to try and optimize
cache usage.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/skge.h |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
--- skge-dev.orig/drivers/net/skge.h
+++ skge-dev/drivers/net/skge.h
@@
Wheen a port on the skge driver is not used, it should
mask off interrupts from theat port.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/skge.c | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
--- skge-dev.orig/drivers/net/skge.c
+++
Don't need to lock when processing transmit complete unless queue fills.
Modeled after tg3.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/skge.c | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
--- skge-dev.orig/drivers/net/skge.c
+++
New version to track changes.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/skge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- skge-dev.orig/drivers/net/skge.c
+++ skge-dev/drivers/net/skge.c
@@ -42,7 +42,7 @@
#include skge.h
#define DRV_NAME
The following hardware error bits only show up on Genesis chipset
and are handled elsewhere, so they can be masked off.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/skge.h |1 -
1 file changed, 1 deletion(-)
--- skge-dev.orig/drivers/net/skge.h
+++
Rather than a workqueue and a per-board mutex to control PHY,
use a tasklet and spinlock. Tasklet is lower overhead and works
just as well for this.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/skge.c | 82 -
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Fri, 16 Mar 2007 17:54:12 -0300
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
Pulled and pushed back out, thanks a lot!
-
To unsubscribe from this list: send the line unsubscribe
From: Robert Olsson [EMAIL PROTECTED]
Date: Fri, 16 Mar 2007 13:38:31 +0100
Hello, Just discussed this Patrick...
We have two users of trie_leaf_remove, fn_trie_flush and fn_trie_delete
both are holding RTNL. So there shouldn't be need for this preempt stuff.
This is assumed to a
We assign the return value of register_netdev to i, but return rc later
on. Fix it.
Signed-off-by: Anton Blanchard [EMAIL PROTECTED]
---
diff --git a/drivers/net/pci-skeleton.c b/drivers/net/pci-skeleton.c
index 00ca0fd..6ca4e4f 100644
--- a/drivers/net/pci-skeleton.c
+++
From: Masayuki Nakagawa [EMAIL PROTECTED]
Date: Fri, 16 Mar 2007 10:45:42 -0700
The ipv6_fl_socklist from listening socket is inadvertently shared
with new socket created for connection. This leads to a variety of
interesting, but fatal, bugs. For example, removing one of the
sockets may
David,
Please pull from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
Till I fully investigate and fix this we should just use the
pointer based approach, where this problem bug doesn't happens, good
thing its selectable :)
- Arnaldo
-
There is a bug when
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Fri, 16 Mar 2007 22:42:46 -0300
Please pull from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22
Till I fully investigate and fix this we should just use the
pointer based approach, where this problem bug
With 42101001.sb firmwares, we need a 10 ms delay between firmware chunks
upload on irda-usb.
Patch from Nigel Williams [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
drivers/net/irda/irda-usb.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git
This patch allows us to bypass the IrDA stack down to the IrLAP level.
Sending and receiving frames is done through a character device.
This is useful for e.g. doing real IrDA sniffing, testing external IrDA
stacks and for Lirc (once I will add the framing disabling switch).
Signed-off-by: Samuel
stir4200 doesn't need to include irlap.h
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
drivers/net/irda/stir4200.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/irda/stir4200.c b/drivers/net/irda/stir4200.c
index a22175f..aec86a2 100644
---
Rmmoding irda triggers a lockdep false positive.
Reported-by: Dave Jones [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
net/irda/irqueue.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/net/irda/irqueue.c b/net/irda/irqueue.c
index
We need to call ppp_unregister_channel() when IrNET disconnects, and this
must be done from a process context.
Bug reported and patch tested by Guennadi Liakhovetski.
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
net/irda/irnet/irnet.h |2 +-
net/irda/irnet/irnet_irda.c | 34
SMC SuperIO Chip LPC47N227 used for IrDA is not detected because its device
identification byte can be 0x7A instead of 0x5A.
Patch from Peter Kovar [EMAIL PROTECTED]
Cc: Jean Delvare [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
From: Samuel Ortiz [EMAIL PROTECTED]
Date: Sat, 17 Mar 2007 04:03:36 +0200
With 42101001.sb firmwares, we need a 10 ms delay between firmware chunks
upload on irda-usb.
Patch from Nigel Williams [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
Applied.
-
To unsubscribe from
From: Samuel Ortiz [EMAIL PROTECTED]
Date: Sat, 17 Mar 2007 04:04:27 +0200
Without this initialization one gets
kernel BUG at kernel/rtmutex_common.h:80!
This patch should also be included in the -stable kernel.
Signed-off-by: G. Liakhovetski [EMAIL PROTECTED]
Signed-off-by: Samuel
From: Samuel Ortiz [EMAIL PROTECTED]
Date: Sat, 17 Mar 2007 04:05:33 +0200
We need to call ppp_unregister_channel() when IrNET disconnects, and this
must be done from a process context.
Bug reported and patch tested by Guennadi Liakhovetski.
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
From: Samuel Ortiz [EMAIL PROTECTED]
Date: Sat, 17 Mar 2007 03:57:29 +0200
This patch allows us to bypass the IrDA stack down to the IrLAP level.
Sending and receiving frames is done through a character device.
This is useful for e.g. doing real IrDA sniffing, testing external IrDA
stacks and
From: Samuel Ortiz [EMAIL PROTECTED]
Date: Sat, 17 Mar 2007 03:58:02 +0200
stir4200 doesn't need to include irlap.h
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
Applied, thanks.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
From: Samuel Ortiz [EMAIL PROTECTED]
Date: Sat, 17 Mar 2007 03:58:36 +0200
Rmmoding irda triggers a lockdep false positive.
Reported-by: Dave Jones [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
Applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
From: Samuel Ortiz [EMAIL PROTECTED]
Date: Sat, 17 Mar 2007 03:59:37 +0200
SMC SuperIO Chip LPC47N227 used for IrDA is not detected because its device
identification byte can be 0x7A instead of 0x5A.
Patch from Peter Kovar [EMAIL PROTECTED]
Cc: Jean Delvare [EMAIL PROTECTED]
Signed-off-by:
Add blkcipher accessors for using kernel data directly without the use of
scatter lists.
Also add a CRYPTO_ALG_DMA algorithm capability flag to permit or deny the use
of DMA and hardware accelerators. A hardware accelerator may not be used to
access any arbitrary piece of kernel memory lest it
Export try_to_del_timer_sync() for use by the RxRPC module.
Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to
cancel a delayed work timer.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
include/linux/workqueue.h | 21 +
kernel/timer.c
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can
use it too.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
include/linux/skbuff.h |4 +
include/net/esp.h |2 -
net/core/skbuff.c | 173
These patches together supply secure client-side RxRPC connectivity as a Linux
kernel socket family. Only the transport/session side is supplied - the
presentation side (marshalling the data) is left to the client. Copies of the
patches can be found here:
Export the keyring key type definition.
Add extra alternative types into the key's type_data union to make it more
useful.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
include/linux/key.h |2 ++
security/keys/keyring.c |2 ++
2 files changed, 4 insertions(+), 0 deletions(-)
On Fri, Mar 16, 2007 at 12:50:16PM +, David Howells wrote:
Add blkcipher accessors for using kernel data directly without the use of
scatter lists.
I don't quite understand all these indirections. What's the problem
with just having a helper that builds the scatterlist for you?
Also add
On Fri, Mar 16, 2007 at 12:50:21PM +, David Howells wrote:
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can
use it too.
Signed-Off-By: David Howells [EMAIL PROTECTED]
---
include/linux/skbuff.h |4 +
include/net/esp.h |2 -
On Fri, Mar 16, 2007 at 12:50:31PM +, David Howells wrote:
Export the keyring key type definition.
Add extra alternative types into the key's type_data union to make it more
useful.
You wrote the code so there must be some reason for this, but these
changes look rather odd to me :)
On Fri, Mar 16, 2007 at 12:50:08PM +, David Howells wrote:
(*) Make fs/afs/ use it and delete the current contents of net/rxrpc/
Having this done would be a really useful use case for getting the code
merged..
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of
Christoph Hellwig [EMAIL PROTECTED] wrote:
I don't quite understand all these indirections. What's the problem
with just having a helper that builds the scatterlist for you?
I was trying to avoid building a scatterlist completely. There's not much
point because the scatterlist approach
+/**
+ * try_to_cancel_delayed_work - Try to kill pending scheduled, delayed work
+ * @work: the work to cancel
+ *
+ * Try to kill off a pending schedule_delayed_work().
+ * - The timer may still be running afterwards, and if so, the work may still
+ * be pending
+ * - Returns -1 if
very odd line split
It's not really odd. The static and inline don't actually add anything to
the function template. They're merely scope limiters / optimisation
controllers, and so make a lot of sense placed on their own line.
As do many things but the goal of the coding style is
Sockets of AF_RXRPC family are:
(1) created as type SOCK_RPC;
There is no such socket type and please don't invent one
If your messages are datagrams and unreliable - SOCK_DGRAM
If your messages are datagrams and reliable - SOCK_RDM
If your messages are datagrams, reliable and ordered -
Christoph Hellwig [EMAIL PROTECTED] wrote:
You wrote the code so there must be some reason for this, but these
changes look rather odd to me :)
The union is for use by the type in any way it sees fit, but it may not want to
use it as a list_head. So all I've done is to make it available as a
Alan Cox [EMAIL PROTECTED] wrote:
As do many things but the goal of the coding style is consistency and
almost all other code doesn't have the static inline wasting an extra
display line.
Actually it doesn't waste an extra display line. Either the static inline is
on a line of its own, or
Alan Cox [EMAIL PROTECTED] wrote:
+static inline int try_to_cancel_delayed_work(struct delayed_work *work)
+{
+ int ret;
This expands to a fair bit of code and IMHO isn't an inline candidate.
Then why is cancel_delayed_work() inline? It's very similar in terms of
expansion.
And it's
Alan Cox [EMAIL PROTECTED] wrote:
If your messages are datagrams and unreliable - SOCK_DGRAM
Nope.
If your messages are datagrams and reliable - SOCK_RDM
Nope.
If your messages are datagrams, reliable and ordered - SOCK_SEQPACKET
Nope.
If your messages are streams of bits, reliable and
On Fri, 16 Mar 2007 14:23:13 +
David Howells [EMAIL PROTECTED] wrote:
Alan Cox [EMAIL PROTECTED] wrote:
If your messages are datagrams and unreliable - SOCK_DGRAM
Nope.
If your messages are datagrams and reliable - SOCK_RDM
Nope.
If your messages are datagrams, reliable and
Alan Cox [EMAIL PROTECTED] wrote:
So your messages are neither reliable not unreliable, nor ordered, nor
unordered.
If you look at the LHS of each of your list of mappings again, you'll see
you've made an assumption there in considering it to be an exhaustive list.
You've assumed a service
I know what they are; and I don't think that what's available covers it.
and use a proper standard socket type.
Assuming that that list is exhaustive...
SOCK_RDM seems to match perfectly well here. The point isn't to enumerate
everything in the universe the point is to find works like
On Mon, Mar 05, 2007 at 05:33:39PM -0500, Ramkrishna Vepa wrote:
Comments on this patch -
1. device_close_flag is unused and is not required.
I'll submit a patch to strip this out sometime next week.
2. s2io_reset can fail to reset the device.
I thought I'd seen this occasionally, and its
Ideally s2io_reset should
return a failure in this case (return is void now)
Would you care to provide a patch that did this? I could
experiment a bit, and try to do this myself; but I really
don't know this hardware, or this driver, that well.
[Ram] Yes, I can submit a patch to address
Boring week-end in sight ?
The new serie of r8169 changes is available at:
http://www.fr.zoreil.com/people/francois/misc/20070316-2.6.21-rc4-r8169-test.patch
or:
http://www.fr.zoreil.com/linux/kernel/2.6.x/2.6.21-rc4/r8169-20070316
or (rebase happy branch):
git://electric-eye.fr.zoreil.com/home
David Miller wrote:
Perhaps the problem can be dealt with using ELF relocations.
There is another case, discussed yesterday on netdev, where run-time
resolution of ELF relocations would be useful (for
very-very-very-read-only variables) so if it can solve this problem
too it would be nice to
86 matches
Mail list logo
