Re: RFC: Established connections hash function

2007-03-24 Thread linux
Result with jenkins: 1 23880 2 12108 3 4040 4 1019 5 200 6 30 7 8 8 1 Xor: 1 65536 Precisely. This means that the Xor hash SUCKS, because its output is conspicuously non-random. What you expect is a Poisson distribution, where the chance that a chain will contain k elements is

Re: RFC: Established connections hash function

2007-03-24 Thread Evgeniy Polyakov
On Sat, Mar 24, 2007 at 08:26:58AM -0400, [EMAIL PROTECTED] ([EMAIL PROTECTED]) wrote: Result with jenkins: 1 23880 2 12108 3 4040 4 1019 5 200 6 30 7 8 8 1 Xor: 1 65536 Precisely. This means that the Xor hash SUCKS, because its output is conspicuously non-random.

Re: [PATCH 2/5 2.6.21-rc4] l2tp: pppol2tp changes to existing kernel headers

2007-03-24 Thread Patrick McHardy
James Chapman wrote: +/* For PPPIOCGL2TPSTATS */ +struct pppol2tp_ioc_stats { + __u16 tunnel_id; /* redundant */ + __u16 session_id; /* if zero, get tunnel stats */ This leaves a 32 bit hole. Maybe move using_ipsec up. + __u64 tx_packets; + __u64 tx_bytes;

Re: [PATCH 4/5 2.6.21-rc4] l2tp: pppol2tp kbuild changes

2007-03-24 Thread Patrick McHardy
James Chapman wrote: [PPPOL2TP]: Modify kbuild for the new pppol2tp driver. This patch adds a new config option, CONFIG_PPPOL2TP and adds if_pppol2tp.h to the list of exported headers. This leaves the tree in a non-compiling state. Please fold into the patch that actually adds the source

Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

2007-03-24 Thread Patrick McHardy
James Chapman wrote: [PPPOL2TP]: Add PPP-over-L2TP driver core. This driver handles only L2TP data frames; control frames are handled by a userspace application. The dfriver implements L2TP using the PPPoX socket family. Data is sent or received using regular socket sendmsg() / recvmsg()

[IPv4] fib: Fix out of bound access of fib_props[]

2007-03-24 Thread Thomas Graf
Fixes a typo which caused fib_props[] to have the wrong size and makes sure the value used to index the array which is provided by userspace via netlink is checked to avoid out of bound access. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6/net/ipv4/fib_frontend.c

[DECNet] fib: Fix out of bound access of dn_fib_props[]

2007-03-24 Thread Thomas Graf
Fixes a typo which caused fib_props[] to have the wrong size and makes sure the value used to index the array which is provided by userspace via netlink is checked to avoid out of bound access. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6/net/decnet/dn_fib.c

[2.6 patch] make dccp_write_xmit_timer() static again

2007-03-24 Thread Adrian Bunk
dccp_write_xmit_timer() needlessly became global. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- net/dccp/dccp.h |1 - net/dccp/timer.c |2 +- 2 files changed, 1 insertion(+), 2 deletions(-) --- linux-2.6.21-rc4-mm1/net/dccp/dccp.h.old2007-03-23 23:39:37.0 +0100 +++

Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

2007-03-24 Thread James Chapman
Florian Zumbiehl wrote: Hi, + * 251003 :Copied from pppoe.c version 0.6.9. you might want to have a look at the patches to the PPPoE code that were posted to netdev recently, as some of them seem to apply to code that's left over from pppoe.c. Do you mean this change? * 070228 : Fix

Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

2007-03-24 Thread Florian Zumbiehl
Hi, Florian Zumbiehl wrote: Hi, + * 251003 :Copied from pppoe.c version 0.6.9. you might want to have a look at the patches to the PPPoE code that were posted to netdev recently, as some of them seem to apply to code that's left over from pppoe.c. Do you mean this change?

Re: [PATCH] NAPI support for Sibyte MAC

2007-03-24 Thread Sergei Shtylyov
Hello, you wrote: This patch completes the NAPI functionality for SB1250 MAC, including making NAPI a kernel option that can be turned on or off and adds the sbmac_poll routine. Index: linux-2.6.14-cgl/drivers/net/Kconfig

[PATCH 3/3] [SK_BUFF]: Use skb_store_bits more extensively

2007-03-24 Thread Arnaldo Carvalho de Melo
Avoiding direct accesses to skb-data. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- arch/ia64/hp/sim/simeth.c |2 +- arch/ia64/sn/kernel/xpnet.c |2 +- drivers/isdn/hysdn/hycapi.c |2 +- drivers/net/8139too.c

Re: [NET] AX.25 Kconfig and docs updates and fixes

2007-03-24 Thread David Miller
From: Ralf Baechle [EMAIL PROTECTED] Date: Tue, 13 Mar 2007 11:55:38 + o The AX.25 Howto is unmaintained since several years. I've replaced it with a wiki at http://www.linux-ax25.org which provides more uptodate information. o Change default for AX25_DAMA_SLAVE to Y.

[PATCH]: Fix ipv6 round-robin locking

2007-03-24 Thread David Miller
There are many, many, many severe SMP locking bugs in the ipv6 advanced routing selection code. I wish the author had thought about these issues more carefully when writing that code because I'm now stuck here fixing all of this :-/ The fix for the most serious of them is below, and I'd

Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

2007-03-24 Thread Patrick McHardy
James Chapman wrote: [PPPOL2TP]: Add PPP-over-L2TP driver core. A couple more comments: - seq_file handling doesn't check seq_printf return values and tries to dump the entire hash table at once, which might exceed the available room. - there appear to be no checks for duplicate session

Re: [PATCH]: Fix ipv6 round-robin locking

2007-03-24 Thread Thomas Graf
* David Miller [EMAIL PROTECTED] 2007-03-24 12:44 As per RFC2461, section 6.3.6, item #2, when no routers on the matching list are known to be reachable or probably reachable we do round robin on those available routes so that we make sure to probe as many of them as possible

Re: [PATCH]: Fix ipv6 round-robin locking

2007-03-24 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Sun, 25 Mar 2007 00:40:30 +0100 Seondly, I'm not sure I've fully understood why this round robin mechanism is needed to ensure as many routers as possible are probed as soon as possible. ... I'm just making sure we know what we're doing :-) Ignore

2.6.21-rc4: known regressions with patches (v2)

2007-03-24 Thread Adrian Bunk
This email lists some known regressions in Linus' tree compared to 2.6.20 with patches available. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any

Re: [6/6] 2.6.21-rc4: known regressions

2007-03-24 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Mon, 19 Mar 2007 19:38:29 -0700 (PDT) From: Adrian Bunk [EMAIL PROTECTED] Date: Sun, 18 Mar 2007 19:49:38 +0100 Subject: ipv6 crash References : http://lkml.org/lkml/2007/3/10/2 Submitter : Len Brown [EMAIL PROTECTED] Status :

[PATCH] fix typo in net/ieee80211/Kconfig

2007-03-24 Thread Patrick Ringl
Hello, this is just a QA / cosmetic fix .. nevertheless the documentation about modules / drivers should be appropriate to the great work of those who write all the real important stuff. :-) The following patch is against 2.6.21-rc4: --- /root/dev/linux-2.6.20-o/net/ieee80211/Kconfig

Re: [PATCH 0/3]: Further reduction of direct access to skb-data

2007-03-24 Thread David Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Sat, 24 Mar 2007 18:07:06 -0300 Hi David, Please take a look, at first I thought about adding a skb_copy_{from,to}_data, that would do just the memcpy, but then skb_{copy,store}_bits seems to be fit for this purpose, but its

Re: [IPv4] fib: Fix out of bound access of fib_props[]

2007-03-24 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Sat, 24 Mar 2007 16:34:36 +0100 Fixes a typo which caused fib_props[] to have the wrong size and makes sure the value used to index the array which is provided by userspace via netlink is checked to avoid out of bound access. Signed-off-by: Thomas

Re: [DECNet] fib: Fix out of bound access of dn_fib_props[]

2007-03-24 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Sat, 24 Mar 2007 16:35:13 +0100 Fixes a typo which caused fib_props[] to have the wrong size and makes sure the value used to index the array which is provided by userspace via netlink is checked to avoid out of bound access. Signed-off-by: Thomas

Re: [TG3 1/3]: Eliminate the unused TG3_FLAG_SPLIT_MODE flag.

2007-03-24 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 16:12:57 -0800 [TG3]: Eliminate the unused TG3_FLAG_SPLIT_MODE flag. This flag to support multiple PCIX split completions was never used because of hardware bugs. This will make room for a new flag. Signed-off-by: Michael Chan

Re: [TG3 2/3]: Exit irq handler during chip reset.

2007-03-24 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 16:13:07 -0800 [TG3]: Exit irq handler during chip reset. On most tg3 chips, the memory enable bit in the PCI command register gets cleared during chip reset and must be restored before accessing PCI registers using memory cycles.

Re: [TG3 3/3]: Update version and reldate.

2007-03-24 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 16:13:19 -0800 [TG3]: Update version and reldate. Update version to 3.75. Signed-off-by: Michael Chan [EMAIL PROTECTED] Also applied, thanks a lot! - To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [RFC PATCHv5 1/5] [TCP]: Add highest_sack seqno, points to globally highest SACK

2007-03-24 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 16 Mar 2007 20:41:02 +0200 It is guaranteed to be valid only when !tp-sacked_out. In most cases this seqno is available in the last ACK but there is no guarantee for that. The new fast recovery loss marking algorithm needs this as entry point.

Re: [RFC PATCHv5 2/5] [TCP]: Extracted rexmit hint clearing from the LOST marking code

2007-03-24 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 16 Mar 2007 20:41:03 +0200 Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [RFC PATCHv5 3/5] [TCP]: Reworked recovery's TCPCB_LOST marking functions

2007-03-24 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 16 Mar 2007 20:41:04 +0200 Complete rewrite for update_scoreboard and mark_head_lost. Couple of hints became unnecessary because of this change, NewReno code was greatly simplified. I changed !TCPCB_TAGBITS check from the original to a !(S|L)

Re: [RFC PATCHv5 4/5] [TCP]: new LOST marker optimizations

2007-03-24 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 16 Mar 2007 20:41:05 +0200 1) Couple of skb states are mutually exclusive Skb cannot be in both S and L states at the same time, adding non-S nor L skb count (below highest sack) to that can be compared against fackets_out to see if anything

Re: [RFC PATCHv5 5/5] [TCP]: non-FACK SACK follows conservative SACK loss recovery (RFC3517)

2007-03-24 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Fri, 16 Mar 2007 20:41:06 +0200 Many assumptions that are true when no reordering or other strange events happen are not a part of the RFC3517. FACK implementation is based on such assumptions. Previously (before the rewrite) the non-FACK SACK was

Re: [PATCH 1/3] [NET] Do pmtu check in transport layer

2007-03-24 Thread David Miller
From: John Heffner [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 20:06:44 -0400 Check the pmtu check at the transport layer (for UDP, ICMP and raw), and send a local error if socket is PMTUDISC_DO and packet is too big. This is actually a pure bugfix for ipv6. For ipv4, it allows us to do pmtu

Re: [PATCH 2/3] [NET] Move DF check to ip_forward

2007-03-24 Thread David Miller
From: John Heffner [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 20:06:45 -0400 Do fragmentation check in ip_forward, similar to ipv6 forwarding. Also add a debug printk in the DF check in ip_fragment since we should now never reach it. Signed-off-by: John Heffner [EMAIL PROTECTED] I don't

Re: [2.6 patch] make dccp_write_xmit_timer() static again

2007-03-24 Thread David Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Sat, 24 Mar 2007 14:06:52 +0100 dccp_write_xmit_timer() needlessly became global. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied, thanks Adrian. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH 3/3] [NET] Add IP(V6)_PMTUDISC_RPOBE

2007-03-24 Thread David Miller
From: John Heffner [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 20:06:46 -0400 Add IP(V6)_PMTUDISC_PROBE value for IP(V6)_MTU_DISCOVER. This option forces us not to fragment, but does not make use of the kernel path MTU discovery. That is, it allows for user-mode MTU probing (or,

Re: [PATCH] tcp: cubic update for net-2.6.22

2007-03-24 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 13:38:57 -0700 The following update received from Injong updates TCP cubic to the latest version. I am running more complete tests and will have results after 4/1. According to Injong: the new version improves on its

Re: [PATCH] tcp_probe: improvements for net-2.6.22

2007-03-24 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 13:40:16 -0700 Change tcp_probe to use ktime (needed to add one export). Add option to only get events when cwnd changes - from Doug Leith Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Also applied, thanks Stephen. - To

Re: [irda-users] [2.6.20-rt8] Neighbour table overflow.

2007-03-24 Thread David Miller
From: Guennadi Liakhovetski [EMAIL PROTECTED] Date: Fri, 23 Mar 2007 13:14:43 +0100 (CET) On Wed, 21 Mar 2007, Guennadi Liakhovetski wrote: On Wed, 21 Mar 2007, Samuel Ortiz wrote: I'm quite sure the leak is in the IrDA code rather than in the ppp or ipv4 one, hence the need for full

Re: [NET_SCHED]: cls_basic: fix NULL pointer dereference

2007-03-24 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 20 Mar 2007 18:15:00 +0100 These two patches fix the cls_basic crash reported by Chris Madden and the ingress locking problem. Please apply, thanks. Applied, I'll push to -stable, thanks! - To unsubscribe from this list: send the line

Re: [NET_SCHED]: Fix ingress locking

2007-03-24 Thread David Miller
Also applied, and I also will push to -stable, thanks! - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html