Re: [patch 10/10] forcedeth: work around NULL skb dereference crash

2007-04-03 Thread Ingo Molnar
* Ayaz Abdulla [EMAIL PROTECTED] wrote: I had responded eariler to the thread asking you to try out the patch found in bug 8058: http://bugzilla.kernel.org/show_bug.cgi?id=8058 I believe that is the caush of the NULL skb dereference issue. there's a different type of regression now: under

[bug] forcedeth: hung interface under load

2007-04-03 Thread Ingo Molnar
* Ingo Molnar [EMAIL PROTECTED] wrote: I had responded eariler to the thread asking you to try out the patch found in bug 8058: http://bugzilla.kernel.org/show_bug.cgi?id=8058 I believe that is the caush of the NULL skb dereference issue. there's a different type of regression

[PATCH] [IPv6] Exclude truncated packets from InHdrErrors statistics

2007-04-03 Thread Mitsuru Chinen
Incoming trancated packets are counted as not only InTruncatedPkts but also InHdrErrors. They should be counted as InTruncatedPkts only. Signed-off-by: Mitsuru Chinen [EMAIL PROTECTED] --- net/ipv6/ip6_input.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: 2.6.20.4: NETDEV WATCHDOG and lockups

2007-04-03 Thread Christian Kujau
On Tue, 3 Apr 2007, Jarek Poplawski wrote: Did you try with 8139cp instead of 8139too? I forgot about that, thanks. (Maybe even try some other card to narrow the problem?) We're try to convince our hosting provider to replace the NIC with a e1000. You could also try to test without

Re: IPsec PMTUD problem

2007-04-03 Thread Herbert Xu
Hi Patrick: On Mon, Apr 02, 2007 at 04:10:25PM +0200, Patrick McHardy wrote: I noticed a problem with PMTUD between two IPsec tunnel endpoints. When sending a packet larger than the PMTU with IP_DF from one tunnel endpoint to the other, xfrm4_output sends an ICMP frag. required with the IPsec

Re: [PATCH 1/9] AF_RXRPC: Add blkcipher accessors for using kernel data directly

2007-04-03 Thread David Howells
Herbert Xu [EMAIL PROTECTED] wrote: Would it be possible to just use the existing scatterlist interface for now? We can simplify it later when things settle down. I'll apply the attached patch for now and drop the bypass patch. It's a bit messy, but it does let me use the sg-list interface.

[PATCH 1/8] AF_RXRPC: Move generic skbuff stuff from XFRM code to generic code [try #2]

2007-04-03 Thread David Howells
Move generic skbuff stuff from XFRM code to generic code so that AF_RXRPC can use it too. The kdoc comments I've attached to the functions needs to be checked by whoever wrote them as I had to make some guesses about the workings of these functions. Signed-Off-By: David Howells [EMAIL PROTECTED]

[PATCH 2/8] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2]

2007-04-03 Thread David Howells
Export try_to_del_timer_sync() for use by the RxRPC module. Add a try_to_cancel_delayed_work() so that it is possible to merely attempt to cancel a delayed work timer. Signed-Off-By: David Howells [EMAIL PROTECTED] --- include/linux/workqueue.h | 21 + kernel/timer.c

[PATCH 0/8] AF_RXRPC socket family and AFS rewrite [try #2]

2007-04-03 Thread David Howells
The first of these patches together provide secure client-side RxRPC connectivity as a Linux kernel socket family. Only the RxRPC transport/session side is supplied - the presentation side (marshalling the data) is left to the client. Copies of the patches can be found here:

[PATCH 6/8] AF_RXRPC: Add an interface to the AF_RXRPC module for the AFS filesystem to use [try #2]

2007-04-03 Thread David Howells
Add an interface to the AF_RXRPC module so that the AFS filesystem module can more easily make use of the services available. AFS still opens a socket but then uses the action functions in lieu of sendmsg() and registers an intercept functions to grab messages before they're queued on the socket

[PATCH 3/8] AF_RXRPC: Key facility changes for AF_RXRPC [try #2]

2007-04-03 Thread David Howells
Export the keyring key type definition and document its availability. Add alternative types into the key's type_data union to make it more useful. Not all users necessarily want to use it as a list_head (AF_RXRPC doesn't, for example), so make it clear that it can be used in other ways.

Re: 2.6.20.4: NETDEV WATCHDOG and lockups

2007-04-03 Thread Christian Kujau
On Mon, 2 Apr 2007, Chuck Ebbert wrote: Where is the info from before you changed to noapic? Or were the machines always using XT-PIC for all the interrupts??? We booted with 'acpi=off lapic' (with ACPI options compiled in, to be able to boot with acpi=on later on) and the box locked up

RE: PROBLEM: sky2 hangs

2007-04-03 Thread Peter Trifonov
Dear Stephen, I have got a PC based on Gigabyte GA-965P-S3 motherboard with an integrated Marvell Yukon 88E8056 PCI-E gigabit ethernet controller. There have been several updates since 2.6.18. Please try and reproduce with 2.6.20 or later kernel. Or contact the vendor to update their

Re: 2.6.20.4: NETDEV WATCHDOG and lockups

2007-04-03 Thread Christian Kujau
On Tue, 3 Apr 2007, Jarek Poplawski wrote: Did you try with 8139cp instead of 8139too? Tried that, 8139cp could not be loaded :( (Maybe even try some other card to narrow the problem?) You could also try to test without ehci, if it's possible. USB has been disabled completely. After

Re: IPsec PMTUD problem

2007-04-03 Thread Patrick McHardy
Herbert Xu wrote: On Mon, Apr 02, 2007 at 04:10:25PM +0200, Patrick McHardy wrote: I noticed a problem with PMTUD between two IPsec tunnel endpoints. When sending a packet larger than the PMTU with IP_DF from one tunnel endpoint to the other, xfrm4_output sends an ICMP frag. required with the

[XFRM]: Optimize MTU calculation

2007-04-03 Thread Patrick McHardy
I've updated my IPsec MTU optimization patch I've posted a couple of month ago to net-2.6.22 and added the further optimization suggested by Herbert to account for the space lost due to alignment in the room reserved for IP options in transport mode. Tested with IPv4 and IPv6 in tunnel and

[PATCH] TCP Illinois congestion control

2007-04-03 Thread Stephen Hemminger
This is a new implementation of TCP Illinois invented by Shao Liu at University of Illinois. It is a another variant of Reno which adapts the alpha and beta parameters based on RTT. The basic idea is to increase window less rapidly as delay approaches the maximum. See the papers and talks to get a

[PATCH] [iputils] Add documentation for the -l flag.

2007-04-03 Thread John Heffner
--- doc/tracepath.sgml | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/doc/tracepath.sgml b/doc/tracepath.sgml index 71eaa8d..c0f308b 100644 --- a/doc/tracepath.sgml +++ b/doc/tracepath.sgml @@ -15,6 +15,7 @@ traces path to a network host discovering MTU

[PATCH] [iputils] Document -n flag.

2007-04-03 Thread John Heffner
--- doc/tracepath.sgml |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/doc/tracepath.sgml b/doc/tracepath.sgml index c0f308b..1bc83b9 100644 --- a/doc/tracepath.sgml +++ b/doc/tracepath.sgml @@ -15,6 +15,7 @@ traces path to a network host discovering MTU along

[PATCH] net: cleanup extra semicolons

2007-04-03 Thread Stephen Hemminger
Spring cleaning time... There seems to be a lot of places in the network code that have extra bogus semicolons after conditionals. Most commonly is a bogus semicolon after: switch() { } Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/802/tr.c |3 ++- net/8021q/vlan.c

[PATCH 2/2] [iputils] Re-probe at same TTL after MTU reduction.

2007-04-03 Thread John Heffner
This fixes a bug that would miss a hop after an ICMP packet too big message, since it would continue increase the TTL without probing again. --- tracepath.c |6 ++ tracepath6.c |6 ++ 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/tracepath.c b/tracepath.c index

[PATCH 1/2] [iputils] Fix asymm messages.

2007-04-03 Thread John Heffner
We should only print the asymm messages in tracepath/6 when you receive a TTL expired message, because this is the only time when we'd expect the same number of hops back as our TTL was set to for a symmetric path. --- tracepath.c | 25 - tracepath6.c | 25

[PATCH]S2io: Change of driver maintainers

2007-04-03 Thread Ramkrishna Vepa
- Changed the maintainers for the S2io driver. (Resending; forgot to send to netdev) Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -pNur linux-2.6.org/drivers/net/s2io.c linux-2.6/drivers/net/s2io.c --- linux-2.6.org/drivers/net/s2io.c2007-03-29 18:49:39.0 -0700 +++

RE: [RFC] TCP Illinois preliminary version

2007-04-03 Thread Julian Shao Liu
HI Stephen, Do you wish me to check the modified code of the implementation in your first email yesterday? I have noticed the modification and have not had a chance to check that. I can check it tonight. BTW, are all the changes in that first email? Best regards! Yours sincerely, Shao Liu

Re: [XFRM]: Optimize MTU calculation

2007-04-03 Thread DiegoB
Patrick McHardy wrote: I've updated my IPsec MTU optimization patch I've posted a couple of month ago to net-2.6.22 and added the further optimization suggested by Herbert to account for the space lost due to alignment in the room reserved for IP options in transport mode. Tested with IPv4 and

RE: [RFC] TCP Illinois preliminary version

2007-04-03 Thread Julian Shao Liu
Hi, Stephen, David Yes, you can go ahead to implement it in Linux. We are glad to see that TCP-Illinois gets more exposure by this way. Best regards! Yours sincerely, Shao Liu (Julian) University of Illinois at Urbana Champaign Coordinated Science Laboratory and Department of Electrical

Re: 2.6.20.4: NETDEV WATCHDOG and lockups

2007-04-03 Thread Francois Romieu
Christian Kujau [EMAIL PROTECTED] : On Tue, 3 Apr 2007, Jarek Poplawski wrote: Did you try with 8139cp instead of 8139too? Tried that, 8139cp could not be loaded :( It is a different beast. -- Ueimor - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: 2.6.20.4: NETDEV WATCHDOG and lockups

2007-04-03 Thread Francois Romieu
Christian Kujau [EMAIL PROTECTED] : [...] Please see http://nerdbynature.de/bits/2.6.20.4/ for details for both hosts and feel free to ask for more details. Although both boxes are in production we'll be happy test more bootoptions/patches and the like. If the apic voodoo makes no

r8169 doesn't work

2007-04-03 Thread OGAWA Hirofumi
Hi, I have a r8169 problem, it seems RX doesn't work. To work r8169 for me I'm needing to revert the following three commits now, but I don't know why. 9cb427b6ff0b3e235c518acf5c1fcbbfc95f0ae2 12d86f682e8acad8555718dc7b0082590f2365d0 cc9f022d97d08e4e36d38661857991fe91447d68 Any

RE: [PATCH] TCP Illinois congestion control

2007-04-03 Thread Julian Shao Liu
Hi Stephen, Thanks for the implementation. I have checked the codes, and I have the following comments: 1, The math is basically correct in computing alpha and beta from da. 2, In the computation of da, you implicitly set d1=0. Setting d1=0 is a conservative approach, although it also works

[PATCH] fix MCA when shutting down tulip quad-NIC

2007-04-03 Thread Olaf Hering
From: [EMAIL PROTECTED] https://bugzilla.novell.com/show_bug.cgi?id=SUSE39204 Shutting down the network causes an MCA because of an IO TLB error when a DEC quad 10/100 card is in any slot. This problem was originally seen on an HP rx4640. Signed-off-by: Olaf Hering [EMAIL PROTECTED] ---

Re: r8169 doesn't work

2007-04-03 Thread Francois Romieu
OGAWA Hirofumi [EMAIL PROTECTED] : [...] I have a r8169 problem, it seems RX doesn't work. To work r8169 for me I'm needing to revert the following three commits now, but I don't know why. 9cb427b6ff0b3e235c518acf5c1fcbbfc95f0ae2 12d86f682e8acad8555718dc7b0082590f2365d0

Re: [PATCH 1/9] AF_RXRPC: Add blkcipher accessors for using kernel data directly

2007-04-03 Thread Herbert Xu
On Tue, Apr 03, 2007 at 02:52:53PM +0100, David Howells wrote: Note that it does paste stack space into sg-list elements, which I think should be okay, and it asks the compiler to get it appropriately aligned bits of stack. That'll do for now. Thanks! -- Visit Openswan at

Re: r8169 doesn't work

2007-04-03 Thread OGAWA Hirofumi
Francois Romieu [EMAIL PROTECTED] writes: OGAWA Hirofumi [EMAIL PROTECTED] : [...] I have a r8169 problem, it seems RX doesn't work. To work r8169 for me I'm needing to revert the following three commits now, but I don't know why. 9cb427b6ff0b3e235c518acf5c1fcbbfc95f0ae2

Re: [PATCH linux1394-2.6.git 07/15] ieee1394: eth1394: make MTU configurable

2007-04-03 Thread Stefan Richter
On 2 Apr, I wrote: +static int eth1394_data_len = 1500; +module_param_named(mtu, eth1394_data_len, int, S_IRUGO | S_IWUSR); +MODULE_PARM_DESC(mtu, MTU (default = 1500)); Can be solved without a new module load parameter. From: Stefan Richter [EMAIL PROTECTED] Subject: ieee1394: eth1394:

Re: r8169 doesn't work

2007-04-03 Thread Francois Romieu
OGAWA Hirofumi [EMAIL PROTECTED] : [...] IIRC, First broken one was 9cb427b6ff0b3e235c518acf5c1fcbbfc95f0ae2. To make sure, I'll confirm tomorrow. If your kernel includes 9cb427b6ff0b3e235c518acf5c1fcbbfc95f0ae2 but misses 81f4e6c190a0fa016fd7eecaf76a5f95d121afc2, you can consider it a known

[PATCH] zd1211rw-mac80211: Remove invalid CR write during ZD1211 phy reset

2007-04-03 Thread Daniel Drake
The vendor driver only does the CR123 write for non-USB devices (which don't exist on the consumer market) Signed-off-by: Daniel Drake [EMAIL PROTECTED] --- drivers/net/wireless/mac80211/zd1211rw/zd_chip.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) diff

[PATCH] zd1211rw-mac80211: Fix E2P_PHY_REG patching

2007-04-03 Thread Daniel Drake
Due to conflicting/confusing defines in the vendor driver, we were reading E2P_PHY_REG from the wrong location. CR157 patching was slightly incorrect in that the vendor driver only patches in an 8-bit value, whereas we were patching 24 bits. Additionally, CR157 patching was happening on both

[PATCH] zd1211rw: Remove invalid CR write during ZD1211 phy reset

2007-04-03 Thread Daniel Drake
The vendor driver only does the CR123 write for non-USB devices (which don't exist on the consumer market) Signed-off-by: Daniel Drake [EMAIL PROTECTED] --- zd_chip.c | 22 +++--- 1 files changed, 11 insertions(+), 11 deletions(-) Index:

[PATCH] zd1211rw: Fix E2P_PHY_REG patching

2007-04-03 Thread Daniel Drake
Due to conflicting/confusing defines in the vendor driver, we were reading E2P_PHY_REG from the wrong location. CR157 patching was slightly incorrect in that the vendor driver only patches in an 8-bit value, whereas we were patching 24 bits. Additionally, CR157 patching was happening on both

one more... iproute commands lockup whole system

2007-04-03 Thread Denys
I'm not sure it is mistake or error, but i feel it is dangerous, cause commands locking up the system, no kernel panic, no oops, so only watchdog can save poor server (and not sure this even) Commands to lockup system (just i am giving my example, i didnt sort out what exactly locked up

Re: one more... iproute commands lockup whole system

2007-04-03 Thread jamal
On Wed, 2007-04-04 at 03:03 +0300, Denys wrote: I'm not sure it is mistake or error, but i feel it is dangerous, cause commands locking up the system, no kernel panic, no oops, so only watchdog can save poor server (and not sure this even) Commands to lockup system (just i am giving my

Re: one more... iproute commands lockup whole system

2007-04-03 Thread Patrick McHardy
jamal wrote: On Wed, 2007-04-04 at 03:03 +0300, Denys wrote: I'm not sure it is mistake or error, but i feel it is dangerous, cause commands locking up the system, no kernel panic, no oops, so only watchdog can save poor server (and not sure this even) Commands to lockup system (just i am

[NET]: Treat CHECKSUM_PARTIAL as CHECKSUM_UNNECESSARY

2007-04-03 Thread Herbert Xu
Hi: Here's the other patch. [NET]: Treat CHECKSUM_PARTIAL as CHECKSUM_UNNECESSARY When a transmitted packet is looped back directly, CHECKSUM_PARTIAL maps to the semantics of CHECKSUM_UNNECESSARY. Therefore we should treat it as such in the stack. Signed-off-by: Herbert Xu [EMAIL PROTECTED]

Re: one more... iproute commands lockup whole system

2007-04-03 Thread jamal
On Wed, 2007-04-04 at 03:39 +0200, Patrick McHardy wrote: Are you refering to What NOT to do if you dont want your machine to crash:? yes. I think we should make sure users can't even accidentally crash their box, so this should at least be caught at runtime. It is hard to do without

Re: one more... iproute commands lockup whole system

2007-04-03 Thread Denys
I think this highly useful feature given by jamal, difficult to be avoided from crash, if user not enough experienced in networking(like me). I guess packet can be even not ipv4/ipv6 packet, maybe it can be cloned IPX or ARP, so TTL field cannot be used. I checked maybe sk_buff have some

Re: [PATCH] netpoll: trapping fix/cleanup

2007-04-03 Thread Jeff Garzik
Sergei Shtylyov wrote: CONFIG_NETPOLL_TRAP causes the TX queue controls to be completely bypassed in the netpoll's trapped mode which easily causes overflows in the drivers with short TX queues (most notably, in 8139too with its 4-deep queue). Make this option more sensible by only bypassing TX

Re: [PATCH 2.6.21-rc5] b44: fix IFF_ALLMULTI handling of CAM slots

2007-04-03 Thread Jeff Garzik
Bill Helfinstine wrote: If you set the IFF_ALLMULTI flag on a b44 device, or if you join more than B44_MCAST_TABLE_SIZE multicast groups, the device will stop receiving unicast messages. This is because the __b44_set_mac_addr call sets the zeroth CAM entry to the MAC address of the device, and

Re: [PATCH 1/2] r8169: issue request_irq after the private data are completely initialized

2007-04-03 Thread Jeff Garzik
Francois Romieu wrote: The irq handler schedules a NAPI poll request unconditionally as soon as the status register is not clean. It has been there - and wrong - for ages but a recent timing change made it apparently easier to trigger. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: Jay

Re: [PATCH] add NAPI support to sb1250-mac.c (take 2)

2007-04-03 Thread Jeff Garzik
Mark Mason wrote: Patch to add NAPI support to sb1250-mac.c (rev 2). This patch differs from the last in that the NAPI support isn't marked as experimental, nor is it configurable (ie. once applied - NAPI is enabled all the time). This was based on feedback from Ralf and others.

Re: [-mm patch] make drivers/net/qla3xxx.c:PHY_DEVICES[] static

2007-04-03 Thread Jeff Garzik
Adrian Bunk wrote: On Fri, Mar 30, 2007 at 01:05:59AM -0700, Andrew Morton wrote: ... Changes since 2.6.21-rc5-mm2: ... git-netdev-all.patch ... git trees ... This patch makes the needlessly global PHY_DEVICES[] static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- BTW: Why is the

[git patches] net driver fixes

2007-04-03 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/b44.c |2 +- drivers/net/cxgb3/common.h|9 +-- drivers/net/cxgb3/cxgb3_main.c|

[PATCH] Replace with time_after in drivers/net/tokenring/3c359.c

2007-04-03 Thread Shani Moideen
Hi, Replacing with time_after in drivers/net/tokenring/3c359.c Applies and compiles clean on latest linus tree. thanks. Signed-off-by: Shani Moideen [EMAIL PROTECTED] diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c index 7580bde..512cd4d 100644 ---

Re: NIC data corruption

2007-04-03 Thread Herbert Xu
Andi Kleen [EMAIL PROTECTED] wrote: Just providing a general global disable hardware checksumming knob for the paranoid would be much easier. I guess that would be a good idea. FWIW you can disable RX checksuming with ethtool -K ifname rx off Cheers, -- Visit Openswan at