Hi,
The five following patches contain a number of fixes and improvements
of the pasemi_mac driver:
1/5: A couple of minor bugfixes.
2/5: Move the IRQ mapping from the PCI layer under our platform, to
the driver.
3/5: A rather large patch with various NAPI/performance-related fixes
and
Ethernet bugfixes:
* Move the was_full/wake_queue logic from tx_intr to clean_tx
* Fix polarity in checks in pasemi_mac_close
Signed-off-by: Olof Johansson [EMAIL PROTECTED]
Index: linux-2.6/drivers/net/pasemi_mac.c
===
---
Fixes for ethernet IRQ mapping, to be done in the driver instead of in
the platform setup code.
Signed-off-by: Olof Johansson [EMAIL PROTECTED]
Index: powerpc/arch/powerpc/platforms/pasemi/pci.c
===
---
PHY support for pasemi_mac. Also add msg_enable flags for future
disablement of the link messages.
Signed-off-by: Olof Johansson [EMAIL PROTECTED]
Index: powerpc/drivers/net/pasemi_mac.c
===
---
Use local-mac-address in the device tree instead. Fall back to mac-address
for older firmware.
Signed-off-by: Olof Johansson [EMAIL PROTECTED]
Index: powerpc/drivers/net/pasemi_mac.c
===
--- powerpc.orig/drivers/net/pasemi_mac.c
On Tue, Apr 17, 2007 at 08:26:32AM -0500, Michal Ostrowski wrote:
The xmit function of a PPP channel is a synchronous operation. If the
transmission fails, we must notify the caller and let them re-submit the
skb later. The return status of dev_queue_xmit is needed to determine
the return
[snip]
--- linux-2.6.orig/net/bridge/br_private.h2007-04-17
13:26:48.0 -0700 +++ linux-2.6/net/bridge/br_private.h
2007-04-17 13:30:29.0 -0700 @@ -36,7 +36,7 @@
{
unsigned char prio[2];
unsigned char addr[6];
-};
+} __attribute__((aligned(8)));
Why 8?
Sorry, I forgot to put netdev and David in Cc when I first sent it.
There is a race between netlink_dump_start() and netlink_release()
that can lead to the situation when a netlink socket with non-zero
callback is freed.
Here it is:
CPU1: CPU2
netlink_release():
On Wed, Apr 18, 2007 at 12:16:18PM +0400, Pavel Emelianov ([EMAIL PROTECTED])
wrote:
Sorry, I forgot to put netdev and David in Cc when I first sent it.
There is a race between netlink_dump_start() and netlink_release()
that can lead to the situation when a netlink socket with non-zero
Evgeniy Polyakov wrote:
On Wed, Apr 18, 2007 at 12:16:18PM +0400, Pavel Emelianov ([EMAIL PROTECTED])
wrote:
Sorry, I forgot to put netdev and David in Cc when I first sent it.
There is a race between netlink_dump_start() and netlink_release()
that can lead to the situation when a netlink
Evgeniy Polyakov wrote:
On Wed, Apr 18, 2007 at 12:16:18PM +0400, Pavel Emelianov ([EMAIL PROTECTED])
wrote:
Sorry, I forgot to put netdev and David in Cc when I first sent it.
There is a race between netlink_dump_start() and netlink_release()
that can lead to the situation when a netlink
From: Pavel Emelianov [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 10:43:56 +0400
[snip]
--- linux-2.6.orig/net/bridge/br_private.h 2007-04-17
13:26:48.0 -0700 +++ linux-2.6/net/bridge/br_private.h
2007-04-17 13:30:29.0 -0700 @@ -36,7 +36,7 @@
{
unsigned char
David Miller wrote:
From: Pavel Emelianov [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 10:43:56 +0400
[snip]
--- linux-2.6.orig/net/bridge/br_private.h 2007-04-17
13:26:48.0 -0700 +++ linux-2.6/net/bridge/br_private.h
2007-04-17 13:30:29.0 -0700 @@ -36,7 +36,7 @@
{
On Wed, Apr 18, 2007 at 10:26:31AM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
Evgeniy Polyakov wrote:
On Wed, Apr 18, 2007 at 12:16:18PM +0400, Pavel Emelianov ([EMAIL
PROTECTED]) wrote:
Sorry, I forgot to put netdev and David in Cc when I first sent it.
There is a race
On Wed, Apr 18, 2007 at 12:32:40PM +0400, Pavel Emelianov ([EMAIL PROTECTED])
wrote:
Evgeniy Polyakov wrote:
On Wed, Apr 18, 2007 at 12:16:18PM +0400, Pavel Emelianov ([EMAIL
PROTECTED]) wrote:
Sorry, I forgot to put netdev and David in Cc when I first sent it.
There is a race between
Evgeniy Polyakov wrote:
On Wed, Apr 18, 2007 at 10:26:31AM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
Out of curiosity, why not to fix a netlink_dump_start() to remove
callback in error path, since in 'no-error' path it removes it in
netlink_dump().
It already does
Evgeniy Polyakov wrote:
On Wed, Apr 18, 2007 at 12:32:40PM +0400, Pavel Emelianov ([EMAIL PROTECTED])
wrote:
Evgeniy Polyakov wrote:
On Wed, Apr 18, 2007 at 12:16:18PM +0400, Pavel Emelianov ([EMAIL
PROTECTED]) wrote:
Sorry, I forgot to put netdev and David in Cc when I first sent it.
On Wed, Apr 18, 2007 at 10:50:42AM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
It already does (netlink_destroy_callback), but that doesn't help
with this race though since without this patch we don't enter the
error path.
I thought that with releasing a socket, which will have a
On Wed, Apr 18, 2007 at 01:03:56PM +0400, Pavel Emelianov ([EMAIL PROTECTED])
wrote:
Yes, you are right, that it will not be freed in netlink_release(),
but it will be freed in netlink_dump() after it is processed (in no-error
path only though).
But error path will leak it. On
Evgeniy Polyakov wrote:
On Wed, Apr 18, 2007 at 10:50:42AM +0200, Patrick McHardy ([EMAIL PROTECTED])
wrote:
I thought that with releasing a socket, which will have a callback
attached only results in a leak of the callback? In that case we can
just free it in dump() just like it is done in
Hi,
we have discovered a routing related problem in ESP tunnel and beet mode.
We don't know whether it is a bug in the XFRM, or just in the way the
virtual addresses and the corresponding routes are set-up. We set up a
dummy0 device for the virtual addresses:
[EMAIL PROTECTED]:~# ip addr show
Jean,
First, I'm the current active maintainer of the
wext-over-netlink interface, and nobody bothered to even 'inform' me
about its removal, let alone consult with me.
I definitely should have copied you on the feature-removal schedule
patch for wext-over-netlink and then the actual
From: Keiichi KII [EMAIL PROTECTED]
The netconsole is a very useful module for collecting kernel message under
certain circumstances(e.g. disk logging fails, serial port is unavailable).
But current netconsole is not flexible. For example, if you want to change ip
address for logging agent, in
From: Keiichi KII [EMAIL PROTECTED]
This patch contains the following cleanups.
- add __init for initialization functions(option_setup() and
init_netconsole()).
Acked-by: Matt Mackall [EMAIL PROTECTED]
Signed-off-by: Keiichi KII [EMAIL PROTECTED]
Signed-off-by: Takayoshi Kochi [EMAIL
From: Keiichi KII [EMAIL PROTECTED]
This patch contains the following changes.
create a sysfs entry for netconsole in /sys/class/misc.
This entry has elements related to netconsole as follows.
You can change configuration of netconsole(writable attributes such as IP
address, port number and so
From: Keiichi KII [EMAIL PROTECTED]
This patch contains the following changes for supporting multiple logging
agents.
1. extend netconsole to multiple netpolls
To send kernel messages to multiple logging agents, extend netcosnole
to be able to use multiple netpolls. Each netpoll sends
From: Keiichi KII [EMAIL PROTECTED]
We use symbolic link for net_device.
The link in sysfs represents the corresponding network etherdevice.
-+- /sys/class/misc/
|-+- netconsole/
|-+- port1/
| |--- id [r--r--r--] id
| |--- net:net_dev [rw-r--r--] net_dev: eth0,eth1,...
| ...
|---
From: Keiichi KII [EMAIL PROTECTED]
This patch contains switch function of netpoll.
If enabled attribute of certain port is '1', this port is used
and the configurations of this port are uable to change.
If enabled attribute of certain port is '0', this port isn't used
and the configurations of
From: Keiichi KII [EMAIL PROTECTED]
We add ioctls for adding/removing target.
If we use NETCONSOLE_ADD_TARGET ioctl,
we can dynamically add netconsole target.
If we use NETCONSOLE_REMOVE_TARGET ioctl,
we can dynamically remoe netconsole target.
We attach a sample program for ioctl.
Hi,
I didn't analyse this bug report but probably it
is nearly connected with one of the bugs visible in
a log from this submit:
http://bugzilla.kernel.org/show_bug.cgi?id=8132
On 15-04-2007 02:50, Paul Mackerras wrote:
David Miller writes:
Here is Patrick McHardy's patch:
So this
On Tue, 2007-04-17 at 14:58 +0200, Patrick McHardy wrote:
David Miller wrote:
From: Patrick McHardy [EMAIL PROTECTED]
Date: Mon, 16 Apr 2007 06:59:06 +0200
RTM_DELROUTE + RTM_NEWROUTE seem to be safer, although you're correct
that it might cause userspace to perform some action upon
Correct the function name in the comments supplied with register_netdev()
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
Index: 21-rc7/net/core/dev.c
===
--- 21-rc7.orig/net/core/dev.c
+++ 21-rc7/net/core/dev.c
@@ -3002,7 +3002,7
Milan Kocián wrote:
On Tue, 2007-04-17 at 14:58 +0200, Patrick McHardy wrote:
Milan, could you cook up another patch which uses NLM_F_REPLACE?
I can try it. Output is in patch below. Review carefully. I don't know
if it's best approach. It's tested and working without problem
(probably
On Wed, 18 Apr 2007 21:06:41 +0900
Keiichi KII [EMAIL PROTECTED] wrote:
From: Keiichi KII [EMAIL PROTECTED]
This patch contains the following changes for supporting multiple logging
agents.
1. extend netconsole to multiple netpolls
To send kernel messages to multiple logging agents,
On Wed, 18 Apr 2007 01:28:04 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Pavel Emelianov [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 10:43:56 +0400
[snip]
--- linux-2.6.orig/net/bridge/br_private.h2007-04-17
13:26:48.0 -0700 +++
Aubrey Li [EMAIL PROTECTED] wrote:
Here, in the attachment I wrote a small test app. Please correct if
there is anything wrong, and feel free to improve it.
Okay... I have that working... probably. I don't know what output it's
supposed to produce, but I see this:
#
On Wed, Apr 18, 2007 at 01:34:50AM +0200, Michael Buesch wrote:
I'd say nobody but you does fully understand WEXT.
Not true. If tommorow I was run over by an ICE, you could ask
Jouni, Dan or Pavel to take over.
Have fun...
Jean
-
To unsubscribe from this list: send the
Hi David
This is a bug fix, but done on top of 2.6.22 tree. I am trying
to minimize the amount of conflict this would cause during merge
by doing it this way. However, if you would rather keep all the bugfixes
in net-2.6, I can do that too, but that _will_ give you conflicts.
-vlad
---
[SCTP]
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 07:44:39 -0700
On Wed, 18 Apr 2007 01:28:04 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Pavel Emelianov [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 10:43:56 +0400
[snip]
---
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 14:38:15 -0400
This is a bug fix, but done on top of 2.6.22 tree. I am trying
to minimize the amount of conflict this would cause during merge
by doing it this way. However, if you would rather keep all the bugfixes
in net-2.6, I
David Miller wrote:
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 14:38:15 -0400
This is a bug fix, but done on top of 2.6.22 tree. I am trying
to minimize the amount of conflict this would cause during merge
by doing it this way. However, if you would rather keep all the
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 16:52:26 -0400
David Miller wrote:
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 14:38:15 -0400
This is a bug fix, but done on top of 2.6.22 tree. I am trying
to minimize the amount of conflict this would
Hi Paul:
Paul Mackerras [EMAIL PROTECTED] wrote:
So this doesn't change process_input_packet(), which treats the case
where the first byte is 0xff (PPP_ALLSTATIONS) but the second byte is
0x03 (PPP_UI) as indicating a packet with a PPP protocol number of
0xff. Arguably that's wrong since
From: Olaf Kirch [EMAIL PROTECTED]
This patch fixes an oops first reported in mid 2006 - see
http://lkml.org/lkml/2006/8/29/358 The cause of this bug report is that
when an error is signalled on the socket, irda_recvmsg_stream returns
without removing a local wait_queue variable from the socket's
From: Olaf Kirch [EMAIL PROTECTED]
This patch cleans up some code in irda_recvmsg_stream, replacing some
homebrew code with prepare_to_wait/finish_wait, and by making the
code honor sock_rcvtimeo.
Signed-off-by: Olaf Kirch [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
This patch removes a cut'n'paste copy of wait_event_interruptible
from irda_accept.
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
Acked-by: Olaf Kirch [EMAIL PROTECTED]
---
net/irda/af_irda.c | 34 --
1 files changed, 8 insertions(+), 26 deletions(-)
Index:
From: Olaf Kirch [EMAIL PROTECTED]
This patch silences an IRDA_ASSERT in irda_recvmsg_stream, as described in
http://bugzilla.kernel.org/show_bug.cgi?id=7512 irda_disconnect_indication
would set sk-sk_err to ECONNRESET, and a subsequent call to recvmsg
would print an irritating kernel message and
Through a protocol specific ioctl, one can disable IrDA TX in order to
monitor an IrDA link.
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
include/linux/irda.h |7 +
include/net/irda/irlap.h |2 +
net/irda/af_irda.c | 58 +-
From: Guennadi Liakhovetski [EMAIL PROTECTED]
Spelling corrections, from to to too.
Signed-off-by: G. Liakhovetski [EMAIL PROTECTED]
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
net/irda/irlap_event.c |2 +-
net/irda/irlap_frame.c | 14 +++---
net/irda/irttp.c |4
In af_irda.c, the multiple IRDA_ASSERT() are either hiding bugs, useless, or
returning the wrong value.
Let's clean that up.
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
net/irda/af_irda.c | 32 +---
1 files changed, 5 insertions(+), 27 deletions(-)
Index:
Hi Dave,
Here go 7 patches for IrDA, against your latest net-2.6.22.
They are mainly af_irda.c fixes/cleanup. Also, I just sent another af_irda.c
oops fix, against net-2.6 (IrDA: Correctly handling socket error).
If you want it against net-2.6.22 as well, just let me know.
Cheers,
Samuel.
-
To
From: Samuel Ortiz [EMAIL PROTECTED]
Date: Thu, 19 Apr 2007 00:45:26 +0300
From: Olaf Kirch [EMAIL PROTECTED]
This patch fixes an oops first reported in mid 2006 - see
http://lkml.org/lkml/2006/8/29/358 The cause of this bug report is that
when an error is signalled on the socket,
Signed-off-by: Samuel Ortiz [EMAIL PROTECTED]
---
drivers/net/irda/mcs7780.c | 26 +-
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/net/irda/mcs7780.c b/drivers/net/irda/mcs7780.c
index 54d1d54..0de8672 100644
--- a/drivers/net/irda/mcs7780.c
If dev_kfree_skb_any is called and it then calls dev_kfree_skb_irq.
That call will dereference the skb. If the skb is invalid, down the
drain we go.
This one-liner checks to see if the skb is valid as part of the
determination of whether to call dev_kfree_skb_irq.
Signed-off-by: Erik Hovland
From: Erik Hovland [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 15:33:44 -0700
If dev_kfree_skb_any is called and it then calls dev_kfree_skb_irq.
That call will dereference the skb. If the skb is invalid, down the
drain we go.
This one-liner checks to see if the skb is valid as part of the
When using PF_PACKET socket with bonded interfaces, there is no
way to get the slave interface (physical interface) the packet was
actually received on.
It looks like there isn't a way to pass the original device {see
packet_rcv() in ./net/packet/af_packet.c} to the socket reader.
When an
On Wed, Apr 18, 2007 at 03:44:16PM -0700, David Miller wrote:
From: Erik Hovland [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 15:33:44 -0700
If dev_kfree_skb_any is called and it then calls dev_kfree_skb_irq.
That call will dereference the skb. If the skb is invalid, down the
drain we go.
From: Laurent Chavey [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 16:05:27 -0700
When using PF_PACKET socket with bonded interfaces, there is no
way to get the slave interface (physical interface) the packet was
actually received on.
That's right.
There isn't a real good solution to this problem
From: Erik Hovland [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 16:18:15 -0700
Heh, the reason I came up with this patch is that the code in
drivers/usb/gadget/ether.c at about line 1653 will attempt to allocate
an skb. If it fails then it uses a goto to jump to line 1672 where it
will call
From: Pavel Emelianov [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 12:16:18 +0400
The proposal it to make sock_orphan before detaching the callback
in netlink_release() and to check for the sock to be SOCK_DEAD in
netlink_dump_start() before setting a new callback.
As discussed in this thread
On 4/18/07, David Miller [EMAIL PROTECTED] wrote:
Ok, it will give you one level of decapsulation.
What do we tell people who want 2 devices previous? :-)
I can tell you that the intent of PJs patch was to provide the ifindex
of the physical interface that a packet entered the system on,
On 4/18/07, David Howells [EMAIL PROTECTED] wrote:
Aubrey Li [EMAIL PROTECTED] wrote:
Here, in the attachment I wrote a small test app. Please correct if
there is anything wrong, and feel free to improve it.
Okay... I have that working... probably. I don't know what output it's
supposed to
From: Chris Leech [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 17:17:45 -0700
On 4/18/07, David Miller [EMAIL PROTECTED] wrote:
Ok, it will give you one level of decapsulation.
What do we tell people who want 2 devices previous? :-)
I can tell you that the intent of PJs patch was to provide
This backs out the the transport layer MTU checks that don't work. As a
consequence, I had to back out the PMTUDISC_PROBE patch as well. These
patches should fix the problem with ipv6 that the transport layer change
tried to address, and re-implement PMTUDISC_PROBE. I think this
approach is
This reverts commit 87e927a0583bd4a8ba9e97cd75b58d8aa1c76e37.
This idea does not work, as pointed at by Patrick McHardy.
Signed-off-by: John Heffner [EMAIL PROTECTED]
---
net/ipv4/ip_output.c |4 +---
net/ipv4/raw.c|8 +++-
net/ipv6/ip6_output.c | 11 +--
Adds a check in ip6_fragment() mirroring ip_fragment() for packets
that we can't fragment, and sends an ICMP Packet Too Big message
in response.
Signed-off-by: John Heffner [EMAIL PROTECTED]
---
net/ipv6/ip6_output.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff
This reverts commit d21d2a90b879c0cf159df5944847e6d9833816eb.
Must be backed out because commit 87e927a0583bd4a8ba9e97cd75b58d8aa1c76e37
does not work.
Signed-off-by: John Heffner [EMAIL PROTECTED]
---
include/linux/in.h |1 -
include/linux/in6.h |1 -
include/linux/skbuff.h
Add IP(V6)_PMTUDISC_PROBE value for IP(V6)_MTU_DISCOVER. This option forces
us not to fragment, but does not make use of the kernel path MTU discovery.
That is, it allows for user-mode MTU probing (or, packetization-layer path
MTU discovery). This is particularly useful for diagnostic utilities,
This reverts commit 87e927a0583bd4a8ba9e97cd75b58d8aa1c76e37.
This idea does not work, as pointed at by Patrick McHardy.
Signed-off-by: John Heffner [EMAIL PROTECTED]
---
net/ipv4/ip_output.c |4 +---
net/ipv4/raw.c|8 +++-
net/ipv6/ip6_output.c | 11 +--
This reverts commit d21d2a90b879c0cf159df5944847e6d9833816eb.
Must be backed out because commit 87e927a0583bd4a8ba9e97cd75b58d8aa1c76e37
does not work.
Signed-off-by: John Heffner [EMAIL PROTECTED]
---
include/linux/in.h |1 -
include/linux/in6.h |1 -
include/linux/skbuff.h
Add IP(V6)_PMTUDISC_PROBE value for IP(V6)_MTU_DISCOVER. This option forces
us not to fragment, but does not make use of the kernel path MTU discovery.
That is, it allows for user-mode MTU probing (or, packetization-layer path
MTU discovery). This is particularly useful for diagnostic utilities,
Adds a check in ip6_fragment() mirroring ip_fragment() for packets
that we can't fragment, and sends an ICMP Packet Too Big message
in response.
Signed-off-by: John Heffner [EMAIL PROTECTED]
---
net/ipv6/ip6_output.c | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff
Sorry, forgot the -n flag on git-format-patch. Patches resent with
correct sequence numbers.
Thanks,
-John
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: John Heffner [EMAIL PROTECTED]
Date: Wed, 18 Apr 2007 21:11:26 -0400
Sorry, forgot the -n flag on git-format-patch. Patches resent with
correct sequence numbers.
Thanks for fixing that.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL
On 4/18/07, David Miller [EMAIL PROTECTED] wrote:
Ok, I'll try to remember to high-priority reviewing PJ's patch
on my next rebase of the net-2.6.22 tree which should be
tonight or tomorrow sometime.
Thanks Dave, PJ is offline this week so I'm trying to keep an eye out
for discussions related
David Miller [EMAIL PROTECTED] wrote:
As discussed in this thread there might be other ways to a
approach this, but this fix is good for now.
Patch applied, thank you.
Actually I was going to suggest something like this:
[NETLINK]: Kill CB only when socket is unused
Since we can still
Hello Diego,
I tried to reproduce the bug. But I got a panic of the kernel :-
I'm using current net-2.6.
I suspect that some special routing for loopback is related
because I checked with kdb and got the backtrace like
fib_sync_down
ipv6_rcv
netif_receive_skb
Hi Kazunori,
thanks for reply.
In your backtrace I see that there are both input and output functions calls. Is
it the right way?
One more thing, were your two hosts you used located on the same network?
In fact it seems that if the machines are on the same network, this bug doesn't
manifest.
On Tue, Apr 17, 2007 at 09:37:44AM +0200, Jarek Poplawski wrote:
...
Yuriy - thanks for testing my patch ...(pause) Not!
It seems this patch is not visible in this version - probably
...
Sorry! It was only something with my eyes.
(Probably too much of Pamela!).
Jarek P.
-
To unsubscribe from
79 matches
Mail list logo