Re: [Security] [PATCH] infinite recursion in netlink

2007-04-26 Thread Chris Wright
* Chris Wright ([EMAIL PROTECTED]) wrote: * Greg KH ([EMAIL PROTECTED]) wrote: fyi, here's the patch that I applied, perhaps 2.6.20 needed something else too? snip @@ -809,7 +815,7 @@ static void nl_fib_input(struct sock *sk nl_fib_lookup(frn, tb); - pid =

Re: [Security] [PATCH] infinite recursion in netlink

2007-04-26 Thread David Miller
From: Chris Wright [EMAIL PROTECTED] Date: Wed, 25 Apr 2007 23:26:01 -0700 Working fine here. Any chance you booted a stale kernel? If not, what's your nl_fib_input+0xe4. Any chance that's actually in nl_fib_lookup? I'm seriously hoping it's a stale kernel or similar, because I can't

Re: very strange inet_sock corruption with rpc

2007-04-26 Thread Olaf Kirch
On Wednesday 25 April 2007 23:03, Vlad Yasevich wrote: It looks like someone is stepping all over the inet_sock. We'll continue looking, but if anyone has any ideas of what might be going on, I'd appreciate it. This could be a socket in TIME_WAIT. A socket entering TIME_WAIT will be replaced

Re: [Security] [PATCH] infinite recursion in netlink

2007-04-26 Thread Greg KH
On Wed, Apr 25, 2007 at 11:31:21PM -0700, David Miller wrote: From: Chris Wright [EMAIL PROTECTED] Date: Wed, 25 Apr 2007 23:26:01 -0700 Working fine here. Any chance you booted a stale kernel? If not, what's your nl_fib_input+0xe4. Any chance that's actually in nl_fib_lookup? I'm

Re: [Security] [PATCH] infinite recursion in netlink

2007-04-26 Thread David Miller
From: Greg KH [EMAIL PROTECTED] Date: Wed, 25 Apr 2007 23:51:51 -0700 Sorry for the false alarm, I have no idea what when wrong here. Glad the bug is really fixed. Nothing to be sorry about, it's great that you double checked things even if it turned out to be a false alarm in the end. - To

Re: [PATCH][XFRM] export SAD info

2007-04-26 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Wed, 25 Apr 2007 11:42:41 -0400 [XFRM] export SAD info On a system with a lot of SAs, counting SAD entries chews useful CPU time since you need to dump the whole SAD to user space; i.e something like ip xfrm state ls | grep -i src | wc -l I have seen

Re: [PATCH][XFRM] export SAD info

2007-04-26 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Wed, 25 Apr 2007 11:54:50 -0400 That patch has xfrm_state_num being mucked with; just ignore that bit. I need to send a patch against net-2.6.22 and i will clean that up - just need some feedback. Would it make sense to have those vars as u32 instead of

[patch 02/11] vioc-warning-fix

2007-04-26 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] Fix this, on i386: drivers/net/vioc/vioc_transmit.c: In function 'vioc_tx_interrupt': drivers/net/vioc/vioc_transmit.c:387: warning: cast from pointer to integer of different size I dunno what the driver is trying to do here, but it looks unpleasant. Cc:

[patch 06/11] 8139too: force media setting cleanup

2007-04-26 Thread akpm
From: Bernard Lee [EMAIL PROTECTED] Setting bit 4 5 alone in 8139too module media option does not really force 100Mbps full-duplex mode. When media option bit 0-3 is cleared, 8139too module does not force media setting. Therefore, bit 0-3 requires to be set for bit 4 5 to take effect. The

[patch 03/11] vioc cast warningfix

2007-04-26 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] i386: drivers/net/vioc/vioc_receive.c: In function '_vioc_fill_n_xfer': drivers/net/vioc/vioc_receive.c:198: warning: cast from pointer to integer of different size drivers/net/vioc/vioc_receive.c:199: warning: cast to pointer from integer of different

[patch 05/11] vioc: replace more deprecated SA_xxx interrupt flags

2007-04-26 Thread akpm
From: Thomas Gleixner [EMAIL PROTECTED] Fix the obnoxious users of the deprecated SA_xxx interrupt flags. Signed-off-by: Thomas Gleixner [EMAIL PROTECTED] Cc: Sriram Chidambaram [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 08/11] add NAPI support to sb1250-mac.c

2007-04-26 Thread akpm
From: Mark Mason [EMAIL PROTECTED] Patch to add NAPI support to sb1250-mac.c (rev 2). This patch differs from the last in that the NAPI support isn't marked as experimental, nor is it configurable (ie. once applied - NAPI is enabled all the time). This was based on feedback from Ralf and

[patch 09/11] forcedeth: improve NAPI logic

2007-04-26 Thread akpm
From: Ingo Molnar [EMAIL PROTECTED] Another forcedeth.c thing: i noticed that its NAPI handler does not do tx-ring processing. The patch below implements this - tested on DESC_VER_2 hardware, with CONFIG_FORCEDETH_NAPI=y. Signed-off-by: Ingo Molnar [EMAIL PROTECTED] Cc: Ayaz Abdulla [EMAIL

[patch 04/11] drivers/net/vioc/: possible cleanups

2007-04-26 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] - remove dead #ifdef EXPORT_SYMTAB code - no inline functions in C files - gcc knows best whether or not to inline static functions - move the vioc_ethtool_ops prototype to a header file - make needlessly global code static - #if 0 unused code - vioc_irq.c:

[patch 01/11] git-netdev-all: export ieee80211_debug_level

2007-04-26 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] Someone has been forgetting their SubmitChecklist medicine. ERROR: ieee80211_debug_level [net/ieee80211/ieee80211_crypt_ccmp.ko] undefined! Fix some unneeded space-wasting initialisations, too. How often must this be said? Cc: Johannes Berg [EMAIL

[patch 01/15] git-net: fix yam.c

2007-04-26 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] drivers/net/hamradio/yam.c: In function `yam_tx_byte': drivers/net/hamradio/yam.c:643: warning: passing arg 1 of `skb_copy_from_linear_data_offset' from incompatible pointer type Cc: David S. Miller [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

[patch 05/15] net: tun/tap: fixed hw address handling

2007-04-26 Thread akpm
From: Brian Braunstein [EMAIL PROTECTED] Fixed tun/tap driver's handling of hw addresses. The hw address is stored in both the net_device.dev_addr and tun.dev_addr fields. These fields were not kept synchronized, and in fact weren't even initialized to the same value. Now during both init and

[patch 07/15] iucv: fix compilation on s390-up

2007-04-26 Thread akpm
From: Alexey Dobriyan [EMAIL PROTECTED] CC [M] net/iucv/iucv.o net/iucv/iucv.c: In function 'iucv_init': net/iucv/iucv.c:1556: error: 'iucv_cpu_notifier' undeclared (first use in this function) Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] Cc: Heiko Carstens [EMAIL PROTECTED] Cc: David S.

[patch 08/15] sunrpc: cleanup: use seq_release_private() where appropriate

2007-04-26 Thread akpm
From: Martin Peschke [EMAIL PROTECTED] We can save some lines of code by using seq_release_private(). Signed-off-by: Martin Peschke [EMAIL PROTECTED] Cc: Trond Myklebust [EMAIL PROTECTED] Acked-by: Neil Brown [EMAIL PROTECTED] Cc: David S. Miller [EMAIL PROTECTED] Signed-off-by: Andrew Morton

[patch 06/15] ROUND_UP macro cleanup in drivers/net/ppp_generic.c

2007-04-26 Thread akpm
From: Milind Arun Choudhary [EMAIL PROTECTED] ROUND_UP macro cleanup use DIV_ROUND_UP Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] Cc: David S. Miller [EMAIL PROTECTED] Acked-by: Paul Mackerras [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 04/15] Delete unused header file linux/if_wanpipe_common.h

2007-04-26 Thread akpm
From: Robert P. J. Day [EMAIL PROTECTED] Delete the unreferenced header file include/linux/if_wanpipe_common.h, as well as the reference to it in the Doc file. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Cc: Krzysztof Halasa [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED]

[patch 03/15] Delete unused header file linux/sdla_fr.h.

2007-04-26 Thread akpm
From: Robert P. J. Day [EMAIL PROTECTED] Delete the unreferenced header file include/linux/sdla_fr.h. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- include/linux/sdla_fr.h | 638 -- 1 file changed, 638

Re: [PATCH RFC] Clean up sk_buff walkers

2007-04-26 Thread David Miller
From: Jean Delvare [EMAIL PROTECTED] Date: Tue, 20 Mar 2007 08:19:49 +0100 Hi all, I noticed recently that, in skb_checksum(), offset and start are essentially the same thing and have the same value throughout the function, despite being computed differently. Using a single variable allows

Re: [RFC] RF Kill

2007-04-26 Thread David Miller
From: Dmitry Torokhov [EMAIL PROTECTED] Date: Tue, 10 Apr 2007 02:29:31 -0400 On Tuesday 10 April 2007 01:58, Dmitry Torokhov wrote: Hi, This is a modified version of rfkill patch that provides infrastructure for controlling state of RF transmitters found on various cards. Well,

Re: [RFC] RF Kill

2007-04-26 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:49:51 -0700 (PDT) From: Dmitry Torokhov [EMAIL PROTECTED] Date: Tue, 10 Apr 2007 02:29:31 -0400 On Tuesday 10 April 2007 01:58, Dmitry Torokhov wrote: Hi, This is a modified version of rfkill patch that provides

Re: [patch 02/15] net/: possible cleanups

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:22 -0700 From: Adrian Bunk [EMAIL PROTECTED] - make the following needlessly global variables static: - core/rtnetlink.c: struct rtnl_msg_handlers[] - netfilter/nf_conntrack_proto.c: struct nf_ct_protos[] - make the following

Re: [patch 03/15] Delete unused header file linux/sdla_fr.h.

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:22 -0700 From: Robert P. J. Day [EMAIL PROTECTED] Delete the unreferenced header file include/linux/sdla_fr.h. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Applied. - To unsubscribe

[patch 14/15] rfcomm_worker(): fix wakeup race

2007-04-26 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] Set TASK_INTERRUPTIBLE prior to testing the flag to avoid missed wakeups. Acked-by: Marcel Holtmann [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- net/bluetooth/rfcomm/core.c |4 ++-- 1 file changed, 2 insertions(+), 2

[patch 11/11] 3C509: Remove unnecessary include of linux/pm_legacy.h

2007-04-26 Thread akpm
From: Robert P. J. Day [EMAIL PROTECTED] Remove the apparently redundant include of linux/pm_legacy.h. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/3c509.c |1 - 1 file changed, 1 deletion(-) diff -puN

[patch 15/15] use mutex instead of binary semaphore in FORE Systems 200E-series driver for ATM

2007-04-26 Thread akpm
From: Matthias Kaehlcke [EMAIL PROTECTED] (akpm: remove CVS control string too) Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/atm/fore200e.c | 20 +--- drivers/atm/fore200e.h |2 +- 2 files changed, 10

[patch 09/15] SPIN_LOCK_UNLOCKED cleanup in drivers/atm, net

2007-04-26 Thread akpm
From: Milind Arun Choudhary [EMAIL PROTECTED] SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/atm/atmtcp.c |2 +- net/atm/clip.c |2 +- net/atm/lec.c

Re: [patch 04/15] Delete unused header file linux/if_wanpipe_common.h

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:23 -0700 From: Robert P. J. Day [EMAIL PROTECTED] Delete the unreferenced header file include/linux/if_wanpipe_common.h, as well as the reference to it in the Doc file. Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] Cc: Krzysztof

[patch 13/15] irda_device_dongle_init: fix kzalloc(GFP_KERNEL) in spinlock

2007-04-26 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] Fix http://bugzilla.kernel.org/show_bug.cgi?id=8343 Cc: Samuel Ortiz [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- net/irda/irda_device.c | 21 - 1 file changed, 8 insertions(+), 13

[patch 10/11] ehea: fix for dlpar and sysfs entries

2007-04-26 Thread akpm
From: Jan-Bernd Themann [EMAIL PROTECTED] - dlpar fix: certain resources may only be allocated when first logical port is available, and must be removed when last logical port has been removed - sysfs entries: create symbolic link from each logical port to ehea

[patch 10/15] ppp_generic: fix lockdep warning

2007-04-26 Thread akpm
From: Jarek Poplawski [EMAIL PROTECTED] === [ INFO: possible circular locking dependency detected ] 2.6.21-rc4 #1 --- pppd/8926 is trying to acquire lock:

[patch 12/15] networking: bonding documentation fix for multiple bonding interfaces

2007-04-26 Thread akpm
From: Alexandra N. Kossovsky [EMAIL PROTECTED] Fix bonding driver documentation for the case of multiple bonding interfaces. Signed-off-by: Alexandra N. Kossovsky [EMAIL PROTECTED] Acked-by: Jay Vosburgh [EMAIL PROTECTED] Cc: Stephen Hemminger [EMAIL PROTECTED] Signed-off-by: Andrew Morton

Re: [patch 05/15] net: tun/tap: fixed hw address handling

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:24 -0700 From: Brian Braunstein [EMAIL PROTECTED] Fixed tun/tap driver's handling of hw addresses. The hw address is stored in both the net_device.dev_addr and tun.dev_addr fields. These fields were not kept synchronized, and in fact

Re: [RFC] RF Kill

2007-04-26 Thread Andrew Morton
On Thu, 26 Apr 2007 00:54:57 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: David Miller [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:49:51 -0700 (PDT) From: Dmitry Torokhov [EMAIL PROTECTED] Date: Tue, 10 Apr 2007 02:29:31 -0400 On Tuesday 10 April 2007 01:58, Dmitry

Re: [patch 06/15] ROUND_UP macro cleanup in drivers/net/ppp_generic.c

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:25 -0700 From: Milind Arun Choudhary [EMAIL PROTECTED] ROUND_UP macro cleanup use DIV_ROUND_UP Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] Cc: David S. Miller [EMAIL PROTECTED] Acked-by: Paul Mackerras [EMAIL PROTECTED]

[patch 11/15] input: rfkill: add support for input key to control wireless radio

2007-04-26 Thread akpm
From: Ivo van Doorn [EMAIL PROTECTED] The RF kill patch that provides infrastructure for implementing switches controlling radio states on various network and other cards. [EMAIL PROTECTED]: address review comments] [EMAIL PROTECTED]: cleanups, build fixes] Signed-off-by: Ivo van Doorn [EMAIL

Re: [patch 07/15] iucv: fix compilation on s390-up

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:26 -0700 From: Alexey Dobriyan [EMAIL PROTECTED] CC [M] net/iucv/iucv.o net/iucv/iucv.c: In function 'iucv_init': net/iucv/iucv.c:1556: error: 'iucv_cpu_notifier' undeclared (first use in this function) Signed-off-by: Alexey

Re: [patch 08/15] sunrpc: cleanup: use seq_release_private() where appropriate

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:27 -0700 From: Martin Peschke [EMAIL PROTECTED] We can save some lines of code by using seq_release_private(). Signed-off-by: Martin Peschke [EMAIL PROTECTED] Cc: Trond Myklebust [EMAIL PROTECTED] Acked-by: Neil Brown [EMAIL PROTECTED]

Re: [patch 13/15] irda_device_dongle_init: fix kzalloc(GFP_KERNEL) in spinlock

2007-04-26 Thread Samuel Ortiz
On 4/26/2007, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Fix http://bugzilla.kernel.org/show_bug.cgi?id=8343 Cc: Samuel Ortiz [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] This one was on my pipeline, looks good to

Re: [patch 13/15] irda_device_dongle_init: fix kzalloc(GFP_KERNEL) in spinlock

2007-04-26 Thread David Miller
From: Samuel Ortiz [EMAIL PROTECTED] Date: 26 Apr 2007 08:12:47 - On 4/26/2007, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Fix http://bugzilla.kernel.org/show_bug.cgi?id=8343 Cc: Samuel Ortiz [EMAIL PROTECTED] Cc: [EMAIL PROTECTED]

Re: [patch 09/15] SPIN_LOCK_UNLOCKED cleanup in drivers/atm, net

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:28 -0700 From: Milind Arun Choudhary [EMAIL PROTECTED] SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Applied. - To

Re: [patch 10/15] ppp_generic: fix lockdep warning

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:29 -0700 lockdep has seen locks - #0 - - #3 taken in circular order, but IMHO, lock - #3 (pch-downl) taken after - #2 (ppp-wlock) differs from pch-downl lock taken in - #0 (before vlan_netdev_xmit_lock_key) and lockdep should be notified

Re: [patch 12/15] networking: bonding documentation fix for multiple bonding interfaces

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:31 -0700 From: Alexandra N. Kossovsky [EMAIL PROTECTED] Fix bonding driver documentation for the case of multiple bonding interfaces. Signed-off-by: Alexandra N. Kossovsky [EMAIL PROTECTED] Acked-by: Jay Vosburgh [EMAIL PROTECTED] Cc:

Re: [patch 14/15] rfcomm_worker(): fix wakeup race

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:36 -0700 From: Andrew Morton [EMAIL PROTECTED] Set TASK_INTERRUPTIBLE prior to testing the flag to avoid missed wakeups. Acked-by: Marcel Holtmann [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Applied. - To

Re: [patch 15/15] use mutex instead of binary semaphore in FORE Systems 200E-series driver for ATM

2007-04-26 Thread David Miller
From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:37 -0700 From: Matthias Kaehlcke [EMAIL PROTECTED] (akpm: remove CVS control string too) Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send

net and tcp GIT trees rebased

2007-04-26 Thread David Miller
With the 2.6.21 release, I've rebased the two development trees: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git kernel.org:/pub/scm/linux/kernel/git/davem/tcp-2.6.git Note that net-2.6.22.git has been thus renamed to net-2.6.git since this will be merged to Linus. I

Re: [PATCH] usb-net/pegasus: simplify carrier detection

2007-04-26 Thread Petko Manolov
Good man, I owe you a beer. :) cheers, Petko On Wed, 25 Apr 2007, Dan Williams wrote: Simplify pegasus carrier detection; rely only on the periodic MII polling. Reverts pieces of c43c49bd61fdb9bb085ddafcaadb17d06f95ec43. Signed-off-by: Dan Williams [EMAIL PROTECTED] ---

[PATCH 5/9] wext: cleanup early ioctl call path

2007-04-26 Thread Johannes Berg
This patch makes the code in wireless_process_ioctl somewhat more readable. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- net/wireless/wext.c | 73 ++-- 1 file changed, 26 insertions(+), 47 deletions(-) ---

[PATCH 2/9] wext: clean up how wext is called

2007-04-26 Thread Johannes Berg
This patch cleans up the call paths from the core code into wext. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- include/net/iw_handler.h | 11 +-- include/net/wext.h | 24 net/core/dev.c | 34 --

[PATCH 7/9] wext: reduce inline abuse

2007-04-26 Thread Johannes Berg
This patch removes a bunch of inline abuse from wext. Most functions that were marked inline are only used once so the compiler will inline them anyway, others are used multiple times but there's no requirement for them to be inline since they aren't in any fast paths. Signed-off-by: Johannes

[PATCH 4/9] wext: remove options

2007-04-26 Thread Johannes Berg
This patch kills the two options in wext that are required to be enabled anyway because they influence the userspace API. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- net/wireless/wext.c | 15 --- 1 file changed, 15 deletions(-) --- net-2.6.22.orig/net/wireless/wext.c

[PATCH 3/9] wext: remove dead debug code

2007-04-26 Thread Johannes Berg
This patch kills a whole bunch of code that can only ever be used by defining some things in wext.c. Also, the things that are printed are mostly useless since the API is fairly well-tested. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- net/wireless/wext.c | 92

[PATCH 8/9] wext: misc code cleanups

2007-04-26 Thread Johannes Berg
Just a few things that didn't fit in with the other patches. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- net/wireless/wext.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) --- net-2.6.22.orig/net/wireless/wext.c 2007-04-24 19:18:49.198804911 +0200

[PATCH 6/9] wext: move EXPORT_SYMBOL statements where they belong

2007-04-26 Thread Johannes Berg
EXPORT_SYMBOL statements are supposed to go together with the symbol they're exporting. This patch moves them accordingly. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- net/wireless/wext.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) ---

[PATCH 9/9] net_device: dont include wext bits if not required

2007-04-26 Thread Johannes Berg
This patch makes the wext bits in struct net_device depend on CONFIG_WIRELESS_EXT. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- include/linux/netdevice.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- net-2.6.22.orig/include/linux/netdevice.h 2007-04-24

[PATCH 0/9] various wext cleanups

2007-04-26 Thread Johannes Berg
This patch series contains various cleanups to the wireless extensions code. johannes - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH net-2.6.22, wireless-dev] clarify locking comment in cfg80211

2007-04-26 Thread Johannes Berg
This patch clarifies the comment about locking in wiphy_unregister. Signed-off-by: Johannes Berg [EMAIL PROTECTED] --- Diffed for wireless-dev but applies with some offset to net-2.6.22 as well. net/wireless/core.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-)

[PATCH 1/2] ehea: fix for sysfs entries

2007-04-26 Thread Thomas Klein
Create symbolic link from each logical port to ehea driver Signed-off-by: Thomas Klein [EMAIL PROTECTED] --- This patch applies on top of the netdev upstream branch for 2.6.22 diff -Nurp -X dontdiff linux-2.6.21/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h ---

[PATCH 2/2] ehea: fix for dlpar support

2007-04-26 Thread Thomas Klein
Certain resources may only be allocated when first logical port is available, and must be removed when last logical port has been removed. Signed-off-by: Thomas Klein [EMAIL PROTECTED] --- This patch applies on top of the netdev upstream branch for 2.6.22 diff -Nurp -X dontdiff

Re: [patch 10/15] ppp_generic: fix lockdep warning

2007-04-26 Thread Paul Mackerras
[EMAIL PROTECTED] writes: lockdep has seen locks - #0 - - #3 taken in circular order, but IMHO, lock - #3 (pch-downl) taken after - #2 (ppp-wlock) differs from pch-downl lock taken in - #0 (before vlan_netdev_xmit_lock_key) and lockdep should be notified about this. Reported tested by:

Re: [PATCH 0/9] various wext cleanups

2007-04-26 Thread Johannes Berg
On Tue, 2007-04-24 at 20:07 +0200, Johannes Berg wrote: This patch series contains various cleanups to the wireless extensions code. Patch 1/9 got lost because it's too large, but it's only moving net/core/wireless.c to net/wireless/wext.c and doing some tiny Makefile updates. johannes

Re: [PATCH 0/9] various wext cleanups

2007-04-26 Thread David Miller
From: Johannes Berg [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 12:15:13 +0200 On Tue, 2007-04-24 at 20:07 +0200, Johannes Berg wrote: This patch series contains various cleanups to the wireless extensions code. Patch 1/9 got lost because it's too large, but it's only moving

Re: [PATCH 0/9] various wext cleanups

2007-04-26 Thread David Miller
From: Johannes Berg [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 20:07:32 +0200 This patch series contains various cleanups to the wireless extensions code. I'll wait for Linville to ACK this stuff, then I'll apply it. Thanks. - To unsubscribe from this list: send the line unsubscribe netdev in

Unexcepted latency (order of 100-200 ms) with TCP (packet receive)

2007-04-26 Thread Ilpo Järvinen
Hi, I've been trying to figure out unexcepted delay spikes that seem to occur for TCP flows with 2.6 (tested 2.6.18.8 + a punch of own modifications and also with 2.6.20.7 with a single additional changeset only that enables me to TCP's control initial window at will). I'll first describe the

Re: [patch 10/15] ppp_generic: fix lockdep warning

2007-04-26 Thread Jarek Poplawski
On Thu, Apr 26, 2007 at 01:39:11AM -0700, David Miller wrote: From: [EMAIL PROTECTED] Date: Thu, 26 Apr 2007 00:27:29 -0700 lockdep has seen locks - #0 - - #3 taken in circular order, but IMHO, lock - #3 (pch-downl) taken after - #2 (ppp-wlock) differs from pch-downl lock taken in - #0

Re: [PATCH 0/9] various wext cleanups

2007-04-26 Thread Johannes Berg
On Thu, 2007-04-26 at 03:18 -0700, David Miller wrote: I got the bounce so I have the changelog too :-) Sorry. I should've known and just posted git instructions. You should have gotten a copy directly to your inbox too. johannes signature.asc Description: This is a digitally signed message

Re: sysctls

2007-04-26 Thread Neil Horman
On Wed, Apr 25, 2007 at 04:47:34PM -0700, David Miller wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 25 Apr 2007 14:50:18 -0700 On Wed, 25 Apr 2007 15:53:19 -0400 Neil Horman [EMAIL PROTECTED] wrote: I did the optimistic dad sysctl, and have no strict use for numbered

Re: [patch 10/15] ppp_generic: fix lockdep warning

2007-04-26 Thread Jarek Poplawski
On Thu, Apr 26, 2007 at 08:04:36PM +1000, Paul Mackerras wrote: [EMAIL PROTECTED] writes: lockdep has seen locks - #0 - - #3 taken in circular order, but IMHO, lock - #3 (pch-downl) taken after - #2 (ppp-wlock) differs from pch-downl lock taken in - #0 (before vlan_netdev_xmit_lock_key)

Transforming code to using ICMP packet accessors

2007-04-26 Thread David Howells
How do I convert: addr = *(__be32 *)(skb-nh.raw + serr-addr_offset); to use the ICMP accessor macros now that skb-nh is no longer available? I was using this to pluck an address out of the ICMP packet payload, but void rxrpc_UDP_error_report(struct sock *sk) {

Re: Transforming code to using ICMP packet accessors

2007-04-26 Thread Arnaldo Carvalho de Melo
On 4/26/07, David Howells [EMAIL PROTECTED] wrote: How do I convert: addr = *(__be32 *)(skb-nh.raw + serr-addr_offset); to use the ICMP accessor macros now that skb-nh is no longer available? I was using this to pluck an address out of the ICMP packet payload, but void

Re: [RFC] RF Kill

2007-04-26 Thread Dmitry Torokhov
On 4/26/07, David Miller [EMAIL PROTECTED] wrote: Actually, I'm reverting this, sorry. Besides the locking and other issues I pointed out, this thing won't even link. Please do not test the build with various configurations when submitting new code like this. Thanks. MODPOST 139 modules

Re: Transforming code to using ICMP packet accessors

2007-04-26 Thread David Howells
Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: Yes, as this is the only use in this function. Thanks! David - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 01/11] git-netdev-all: export ieee80211_debug_level

2007-04-26 Thread John W. Linville
On Thu, Apr 26, 2007 at 12:23:14AM -0700, [EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Someone has been forgetting their SubmitChecklist medicine. ERROR: ieee80211_debug_level [net/ieee80211/ieee80211_crypt_ccmp.ko] undefined! Sent a pull request to Jeff on Tuesday that

Re: very strange inet_sock corruption with rpc

2007-04-26 Thread Vlad Yasevich
Sridhar Samudrala wrote: The corruption is triggered after about 10 minutes of running the following script: nfspath = $1 localpath = $2 while true; do mount $nfspath $localpath sleep 5 cp /boot/vmlinuz $localpath sleep 5 rm $localpath/vmlinuz sleep 5

Re: [RFC] RF Kill

2007-04-26 Thread Dmitry Torokhov
On 4/26/07, David Miller [EMAIL PROTECTED] wrote: From: Dmitry Torokhov [EMAIL PROTECTED] Date: Tue, 10 Apr 2007 02:29:31 -0400 On Tuesday 10 April 2007 01:58, Dmitry Torokhov wrote: Hi, This is a modified version of rfkill patch that provides infrastructure for controlling state of RF

Re: [PATCH][XFRM] export SAD info

2007-04-26 Thread jamal
Thanks Dave. Here's a missing bit to get in sync with latest net-2.6 I will send you the policy side sometime tonight or tommorow. cheers, jamal [XFRM] missing bits to SAD info This brings the SAD info in sync with net-2.6.22/net-2.6 Signed-off-by: Jamal Hadi Salim [EMAIL PROTECTED] ---

Re: very strange inet_sock corruption with rpc

2007-04-26 Thread Vlad Yasevich
Olaf Kirch wrote: On Wednesday 25 April 2007 23:03, Vlad Yasevich wrote: It looks like someone is stepping all over the inet_sock. We'll continue looking, but if anyone has any ideas of what might be going on, I'd appreciate it. This could be a socket in TIME_WAIT. A socket entering

Re: very strange inet_sock corruption with rpc

2007-04-26 Thread Arnaldo Carvalho de Melo
On 4/26/07, Olaf Kirch [EMAIL PROTECTED] wrote: On Wednesday 25 April 2007 23:03, Vlad Yasevich wrote: It looks like someone is stepping all over the inet_sock. We'll continue looking, but if anyone has any ideas of what might be going on, I'd appreciate it. This could be a socket in

Re: [PATCH][XFRM] export SAD info

2007-04-26 Thread jamal
On Thu, 2007-26-04 at 00:18 -0700, David Miller wrote: From: jamal [EMAIL PROTECTED] Would it make sense to have those vars as u32 instead of unsigned int? I'm ambivalent, unsigned int happens to be 32-bit on every platform. So changing it would cause no harm :-) If unsigned int is always

Re: [Bugme-new] [Bug 8342] New: sctp_getsockopt_local_addrs_old() calls copy_to_user() while a spinlock is held

2007-04-26 Thread Vlad Yasevich
David Miller wrote: From: Vlad Yasevich [EMAIL PROTECTED] Date: Mon, 23 Apr 2007 13:43:35 -0400 [PATCH] [SCTP] Fix sctp_getsockopt_local_addrs_old() to use local storage sctp_getsockopt_local_addrs_old() in net/sctp/socket.c calls copy_to_user() while the spinlock addr_lock is held. this

RE: [PATCH] IPROUTE: Modify tc for new PRIO multiqueue behavior

2007-04-26 Thread jamal
On Wed, 2007-25-04 at 10:45 -0700, Waskiewicz Jr, Peter P wrote: -Original Message- The previous version of my multiqueue patches I sent for consideration had feedback from Patrick McHardy asking that the user be able to configure the PRIO qdisc to run with multiqueue support or not.

Re: [RFT] e100 driver on ARM

2007-04-26 Thread David Acker
Lennart Sorensen wrote: Well the IT8152G+PXA255 combination used on the SBC we tried a couple of years ago did not work. The PCI bus had errors and the SBC maker gave up trying to fix it. We switched to a Geode SC1200 based board instead which works fine PCI wise. I don't think this is it.

Re: [RFT] e100 driver on ARM

2007-04-26 Thread Lennert Buytenhek
On Thu, Apr 26, 2007 at 09:41:22AM -0400, David Acker wrote: Here is a quote from Russell that describes what I believe is the main problem: http://www-gatago.com/linux/kernel/15457063.html Has e100 actually been fixed to use the PCI DMA API correctly yet? Looking at it, it doesn't look

Netchannels status

2007-04-26 Thread Ian Brown
Hello, I read a bit about netchannels in linux (according to Van Jacobson ideas). I see that the last version of netchannels (20) is from: Fri, 29 Dec 2006. http://tservice.net.ru/~s0mbre/blog/2006/12/29#2006_12_29 My question is : what is the status of the netchannels project ? is there

determining IP address within network device driver

2007-04-26 Thread Nic Gyrovague
I have a hw network device that can benefit from knowing what its associated IP addresses (if any) are... Is there a correct way to determine the IP address(es) from within the driver code? Its obviously possible to snoop into ARP and IP traffic to try to guess, but this is not always 100%

Re: [RFT] e100 driver on ARM

2007-04-26 Thread Jeff Garzik
Lennert Buytenhek wrote: This is all a while ago now, but wasn't the e100 S-bit patch originally written by Intel people in response to the very same quote by Russell King that you've quoted above? Correct. I just wanted to make sure it didn't kill any boxes. Jeff - To unsubscribe

Re: [PATCH 3/5 2.6.21-rc7] l2tp: pppol2tp core

2007-04-26 Thread Patrick McHardy
James Chapman wrote: Patrick McHardy wrote: Still the ugly old_data_ready/old_sk_destruct and pppol2tp_fget hacks. I added comments in the code about why I think pppol2tp_fget is needed. This driver handles PPP-over-L2TP sockets. These are attached to a plain UDP (L2TP) socket. When a

Re: Netchannels status

2007-04-26 Thread Evgeniy Polyakov
On Thu, Apr 26, 2007 at 05:21:35PM +0300, Ian Brown ([EMAIL PROTECTED]) wrote: Hello, I read a bit about netchannels in linux (according to Van Jacobson ideas). I see that the last version of netchannels (20) is from: Fri, 29 Dec 2006. http://tservice.net.ru/~s0mbre/blog/2006/12/29#2006_12_29

Re: [RFT] e100 driver on ARM

2007-04-26 Thread Kok, Auke
Jeff Garzik wrote: Lennert Buytenhek wrote: This is all a while ago now, but wasn't the e100 S-bit patch originally written by Intel people in response to the very same quote by Russell King that you've quoted above? Correct. I just wanted to make sure it didn't kill any boxes. Neither did

RE: 2.6.20.7 mss negotiation and path mtu discovery mostly broken?

2007-04-26 Thread Ristuccia, Brian
08:39:55.649689 IP 10.2.10.254.22 12.33.234.69.35026: . 5906:10250(4344) ack 1 794 win 674 nop,nop,timestamp 413790 3873837887 08:39:55.650532 IP 10.2.10.1 10.2.10.254: icmp 92: 12.33.234.69 unreachable - need to frag (mtu 1500) Where was this dump taken, on 10.2.10.254? Yes.

Re: [PATCH] IPROUTE: Modify tc for new PRIO multiqueue behavior

2007-04-26 Thread Patrick McHardy
jamal wrote: On Wed, 2007-25-04 at 10:45 -0700, Waskiewicz Jr, Peter P wrote: The previous version of my multiqueue patches I sent for consideration had feedback from Patrick McHardy asking that the user be able to configure the PRIO qdisc to run with multiqueue support or not. That is why TC

[PATCH] [IPV4] nl_fib_lookup: Initialise res.r before fib_res_put(res)

2007-04-26 Thread Sergey Vlasov
When CONFIG_IP_MULTIPLE_TABLES is enabled, the code in nl_fib_lookup() needs to initialize the res.r field before fib_res_put(res) - unlike fib_lookup(), a direct call to -tb_lookup does not set this field. Signed-off-by: Sergey Vlasov [EMAIL PROTECTED] --- net/ipv4/fib_frontend.c |4 1

Re: [RFT] e100 driver on ARM

2007-04-26 Thread Jeff Garzik
Kok, Auke wrote: Jeff Garzik wrote: Lennert Buytenhek wrote: This is all a while ago now, but wasn't the e100 S-bit patch originally written by Intel people in response to the very same quote by Russell King that you've quoted above? Correct. I just wanted to make sure it didn't kill any

Re: [PATCH] [IPV4] nl_fib_lookup: Initialise res.r before fib_res_put(res)

2007-04-26 Thread Alexey Kuznetsov
Hello! When CONFIG_IP_MULTIPLE_TABLES is enabled, the code in nl_fib_lookup() needs to initialize the res.r field before fib_res_put(res) - unlike fib_lookup(), a direct call to -tb_lookup does not set this field. Indeed, I am sorry. Alexey - To unsubscribe from this list: send the line

Re: Unexcepted latency (order of 100-200 ms) with TCP (packet receive)

2007-04-26 Thread Chuck Ebbert
Ilpo Järvinen wrote: ...I'm unsure how to continue the investigation from this point onward and asking for ideas/suggestions or how to rule out more possibilities... Or is there some knob which I don't know of that should be toggled or something, is 2.6 network stack expected to behave this

Re: [RFT] e100 driver on ARM

2007-04-26 Thread Kok, Auke
Jeff Garzik wrote: Kok, Auke wrote: Jeff, I think I should just push the IO patch and the sbit code to Andrew and have it sit there. That is a vastly larger test resource than we currently can generate for this. If needed we just let is sit there for a whole release cycle before moving it to

  1   2   >