[PATCH] [TCP] tcp_probe: a trivial fix for mismatched number of printl arguments.

2007-05-21 Thread Sangtae Ha
Just a fix to correct the number of printl arguments. Now, srtt is logging correctly. Signed-off-by: Sangtae Ha [EMAIL PROTECTED] --- net/ipv4/tcp_probe.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c index 3938d5d..1b72c55

r8169: hard freezes on TX

2007-05-21 Thread Rolf Eike Beer
Hi all, I often see freezes when I do much outgoing transfer. I have never seen this happening on incoming transfers. When this happens the system locks up hard, I don't see anything in the log. Since this is my laptop I have trouble debugging it: there is no serial console and debugging this

Re: [RFC] New driver API to speed up small packets xmits

2007-05-21 Thread Herbert Xu
David Miller [EMAIL PROTECTED] wrote: From: Shirley Ma [EMAIL PROTECTED] Date: Tue, 15 May 2007 14:22:57 -0700 I just wonder without TSO support in HW, how much benefit we can get by pushing GSO from interface layer to device layer besides we can do multiple packets in IPoIB. I bet

Re: Questions about IPsec and Netfilter

2007-05-21 Thread Herbert Xu
Alan Stern [EMAIL PROTECTED] wrote: Q4: Is it true that NAT-Traversal isn't implemented for transport mode? NAT-Traversal works in transport mode but you have the standard problem that if you've got two peers behind one IPsec gateway then they'll look the same to you. Cheers, -- Visit

Re: [PATCH 0/4] [Net] Support Xen accelerated network plugin modules

2007-05-21 Thread Herbert Xu
On Fri, May 18, 2007 at 02:15:48PM +0100, Kieran Mansley wrote: I've also CC'd netdev@vger.kernel.org as some of the files being patched may be merged into upstream linux soon, and so folks there may have opinions too. Jeff and Stephen, could you both take a look at these proposed patches

Re: [Xen-devel] [PATCH 0/4] [Net] Support Xen accelerated network plugin modules

2007-05-21 Thread Jun Koi
On 5/18/07, Kieran Mansley [EMAIL PROTECTED] wrote: This is a repost of some earlier patches to the xen-devel mailing list, with a number of changes thanks to some useful suggestions from others. Apologies for the short delay in getting this next version ready. I've also CC'd

Re: [PATCH 0/4] [Net] Support Xen accelerated network plugin modules

2007-05-21 Thread Kieran Mansley
On Mon, 2007-05-21 at 18:14 +1000, Herbert Xu wrote: On Fri, May 18, 2007 at 02:15:48PM +0100, Kieran Mansley wrote: This set of patches provides the hooks and support necessary for accelerated network plugin modules to attach to Xen's netback and netfront. These modules provide a fast

Re: [Xen-devel] [PATCH 0/4] [Net] Support Xen accelerated network plugin modules

2007-05-21 Thread Kieran Mansley
On Mon, 2007-05-21 at 19:02 +0900, Jun Koi wrote: On 5/18/07, Kieran Mansley [EMAIL PROTECTED] wrote: This set of patches provides the hooks and support necessary for accelerated network plugin modules to attach to Xen's netback and netfront. These modules provide a fast path for network

HI Dear friend

2007-05-21 Thread Alice Alice
Would you like to promote yourself/your company/products through a very significant and innovative way? Half of the world's poorest people are children, and one of four babies is born into poverty. Would you like to help needy children? Please see the Significant attachment text (PDF format).

[IPv6] UDP Encapsulation of IPsec ESP Packets

2007-05-21 Thread Fernando Luis Vázquez Cao
I noticed that IPv4-over-IPv6 made into 2.6.21 (thank you!) and that prompted to check the progress with the implementation of rfc3948 (UDP Encapsulation of IPsec ESP Packets) in Linux. For IPv4 the code is already there, but that does not seem to be the case for IPv6. I have checked the usagi

socket tx_queue grows and communication stops

2007-05-21 Thread Guennadi Liakhovetski
Hi all, writing to both netdev and IrDA since I don't know where the problem occurs. More likely in IrDA, but maybe someone from netdev will have debugging ideas. System: PXA270 ARM CPU Kernel: 2.6.20.1-rt8 (realtime preemption) Test case: small UDP-packet request-response test over ppp on

Re: Sending ipv6 packets from a kernel module

2007-05-21 Thread Neil Horman
On Mon, May 21, 2007 at 02:04:33PM +0930, Anton wrote: Hi all, Please excuse me if the following question has already been asked on the mailing list, I am a little new to this. I am trying to send IPv6 packets from a kernel module. As far as I understand, I would have to use the

[PATCH] declance: Remove a dangling spin_unlock_irq() thingy

2007-05-21 Thread Maciej W. Rozycki
The spin_unlock_irq() invocation in lance_start_xmit() has no matching locking request. The call is already protected by netif_tx_lock, so remove the statement. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] --- Please apply. Maciej patch-mips-2.6.18-20060920-declance-lock-0 diff -up

Re: [PATCH] libertas: skb dereferenced after netif_rx

2007-05-21 Thread Florin Malita
David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Sat, 19 May 2007 21:47:00 -0400 According to the implementation, netif_rx() can fail. It doesn't exactly fail, but it does give return values which indicate RX congestion. Assuming you're referring to NET_RX_CN_*, this

Ethernet frames filtering/relaying. Help needed

2007-05-21 Thread Primiano Tucci
Hi all, I'm new to this Mailing list Some days ago I started development of a new 2.6 network driver (formerly it should be a decentered Network Load Balancing driver). I'm not too much familiar with kernel networking, so I'm asking you what's the best approach to do something like this: -

[PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Auke Kok
Herbert Xy wrote: netif_poll_enable can only be called if you've previously called netif_poll_disable. Otherwise a poll might already be in action and you may get a crash like this. Removing the call to netif_poll_enable in e1000_open should fix this issue, the only other call to

Re: [PATCH] [TCP] tcp_probe: a trivial fix for mismatched number of printl arguments.

2007-05-21 Thread Stephen Hemminger
On Mon, 21 May 2007 03:45:42 -0400 Sangtae Ha [EMAIL PROTECTED] wrote: Just a fix to correct the number of printl arguments. Now, srtt is logging correctly. Signed-off-by: Sangtae Ha [EMAIL PROTECTED] --- net/ipv4/tcp_probe.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

Re: [PATCH] tcp_probe: use GCC printf attribute

2007-05-21 Thread Stephen Hemminger
The function in tcp_probe is printf like, use GCC to check the args. Sighed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/ipv4/tcp_probe.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/ipv4/tcp_probe.c 2007-05-21 08:48:29.0 -0700 +++

Re: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr (fwd)

2007-05-21 Thread Patrick McHardy
Herbert Xu wrote: Patrick McHardy [EMAIL PROTECTED] wrote: This leaves the question what to do in the path after ip_output, when skb-dev points to the output device. We don't know the input device anymore, so there doesn't seem to be a way to make it do what the sysctl promises. Perhaps we

Re: Sending ipv6 packets from a kernel module

2007-05-21 Thread Vlad Yasevich
Neil Horman wrote: On Mon, May 21, 2007 at 02:04:33PM +0930, Anton wrote: Hi all, Please excuse me if the following question has already been asked on the mailing list, I am a little new to this. I am trying to send IPv6 packets from a kernel module. As far as I understand, I would have

Re: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr (fwd)

2007-05-21 Thread Patrick McHardy
David Miller wrote: The post ip_output() case is very unfortunate. Perhaps we can tag the call sites, or if that doesn't work we can find some way to perhaps tag the dst as an input vs. output route in order to avoid this problem. Tagging call-sites should make sure we don't use an address

Re: [PATCH 1/2] s2io: add PCI error recovery support

2007-05-21 Thread Linas Vepstas
On Fri, May 18, 2007 at 03:06:53AM -0400, Sivakumar Subramani wrote: Hi, Fix looks good. I have couple of comments, 1) Return from s2io_updt_stats function if the PCI bus is offline (pci_channel_offline). if (pci_channel_offline(pdev)) return; OK, missed that

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-21 Thread Milton Miller
On May 18, 2007, at 12:11 PM, David Acker wrote: Kok, Auke wrote: First impression just came in: It seems RX performance is dropped to 10mbit. TX is unaffected and runs at 94mbit/tcp, but RX the new code seems to misbehave and fluctuate, dropping below 10mbit after a few netperf runs and

Re: [PATCH] fix e100 rx path on ARM (was [PATCH] e100 rx: or s and el bits)

2007-05-21 Thread Kok, Auke
Milton Miller wrote: On May 18, 2007, at 12:11 PM, David Acker wrote: Kok, Auke wrote: First impression just came in: It seems RX performance is dropped to 10mbit. TX is unaffected and runs at 94mbit/tcp, but RX the new code seems to misbehave and fluctuate, dropping below 10mbit after a

Re: [PATCH 3/4] [Net] Support Xen accelerated network plugin modules

2007-05-21 Thread Stephen Hemminger
On Fri, 18 May 2007 14:16:48 +0100 Kieran Mansley [EMAIL PROTECTED] wrote: Add support to Xen netfront for accelerated plugin module diff -r ce3d5c548e67 linux-2.6-xen- sparse/drivers/xen/netfront/netfront.c --- a/linux-2.6-xen-sparse/drivers/xen/netfront/netfront.c Thu May 17 09:56:38

Re: [PATCH 3/4] [Net] Support Xen accelerated network plugin modules

2007-05-21 Thread Stephen Hemminger
On Fri, 18 May 2007 14:16:48 +0100 Kieran Mansley [EMAIL PROTECTED] wrote: Add support to Xen netfront for accelerated plugin module +/* + * List of all netfront accelerator plugin modules available. Each + * list entry is of type struct netfront_accelerator. + */ +static struct

Re: [PATCH 3/4] [Net] Support Xen accelerated network plugin modules

2007-05-21 Thread Stephen Hemminger
O + +/* + * Macro to call one of the accelerator's function hooks. The use + * count for the accelerator's hooks is incremented for the duration + * of the call to prevent the accelerator being able to modify the + * hooks in the middle (by, for example, unloading) + */ +#define

Re: [FIX][PATCH] ipv6 addrconf.c REMOVED #if patch

2007-05-21 Thread Urs Thuermann
Oliver Hartkopp [EMAIL PROTECTED] writes: Yep - you were right. It looks better like this as ARPHRD_SIT is defined in if_arp.h in any CONFIG_* case ... Oliver asked me to resend the patch with a sane mailer that doesn't mangle white-space and line breaks. So here it is. This patch makes the

[PATCH 1/2 v4] s2io: add PCI error recovery support

2007-05-21 Thread Linas Vepstas
This patch adds PCI error recovery support to the s2io 10-Gigabit ethernet device driver. Fourth revision, blocks MSI interrupts, and statistics gathering, as well. Tested, seems to work well. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Acked-by: Ramkrishna Vepa [EMAIL PROTECTED] Cc:

[PATCH 2/2]: s2io: minor janitoring

2007-05-21 Thread Linas Vepstas
s2io cleanup suggestions, per discussion on mailing lists. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] drivers/net/s2io.c |2 -- drivers/net/s2io.h |1 - 2 files changed, 3 deletions(-) Index: linux-2.6.22-rc1/drivers/net/s2io.c

[patch 62/69] sky2: fix oops on shutdown

2007-05-21 Thread Chris Wright
-stable review patch. If anyone has any objections, please let us know. - From: Stephen Hemminger [EMAIL PROTECTED] If the device fails during module startup for some reason like unsupported chip version then the driver would crash dereferencing a null pointer, on shutdown

[patch 59/69] sky2: allow 88E8056

2007-05-21 Thread Chris Wright
-stable review patch. If anyone has any objections, please let us know. - From: Stephen Hemminger [EMAIL PROTECTED] It looks like the problems of Gigabyte 88E8056 are unique to that chip motherboard and maybe fixable by EEPROM update. Signed-off-by: Stephen Hemminger [EMAIL

[patch 60/69] sky2: 88e8071 support not ready

2007-05-21 Thread Chris Wright
-stable review patch. If anyone has any objections, please let us know. - From: Stephen Hemminger [EMAIL PROTECTED] The driver is not ready to support 88e8071 chip, it requires several more changes (not done yet). If this chip is present, system will hang on boot.

[patch 61/69] skge: crash on shutdown/suspend

2007-05-21 Thread Chris Wright
-stable review patch. If anyone has any objections, please let us know. - From: Stephen Hemminger [EMAIL PROTECTED] If device fails during module startup for some reason (like unsupported chip version) then driver would crash dereferencing a null pointer, on shutdown or

Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-21 Thread Andy Fleming
On May 11, 2007, at 05:58, Matvejchikov Ilya wrote: Signed-off-by: Matvejchikov Ilya [EMAIL PROTECTED] Acked-by: Andy Fleming [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [Bugme-new] [Bug 8519] New: NAT prerouting over tun interface broken

2007-05-21 Thread Andrew Morton
On Mon, 21 May 2007 13:05:36 -0700 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8519 Summary: NAT prerouting over tun interface broken Kernel Version: 2.6.21.1 Status: NEW Severity: normal Owner: [EMAIL PROTECTED]

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Herbert Xu
On Mon, May 21, 2007 at 08:32:41AM -0700, Auke Kok wrote: Herbert Xy wrote: netif_poll_enable can only be called if you've previously called netif_poll_disable. Otherwise a poll might already be in action and you may get a crash like this. Removing the call to netif_poll_enable in

Re: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr (fwd)

2007-05-21 Thread Herbert Xu
On Mon, May 21, 2007 at 06:36:57PM +0200, Patrick McHardy wrote: The IP stack shouldn't be too hard, we currently set skb-dev in ip_output, after that we only have the POST_ROUTING hook and ip_fragment which care. It wouldn't help with ipip/ip_gre though, at that point skb-dev must point to

Re: oops in net/ipv4/icmp.c:icmp_send() with icmp_errors_use_inbound_ifaddr (fwd)

2007-05-21 Thread Patrick McHardy
Herbert Xu wrote: On Mon, May 21, 2007 at 06:36:57PM +0200, Patrick McHardy wrote: The IP stack shouldn't be too hard, we currently set skb-dev in ip_output, after that we only have the POST_ROUTING hook and ip_fragment which care. It wouldn't help with ipip/ip_gre though, at that point skb-dev

[RTNETLINK]: Allow changing of subsets of netdevice flags in rtnl_setlink

2007-05-21 Thread Patrick McHardy
[RTNETLINK]: Allow changing of subsets of netdevice flags in rtnl_setlink rtnl_setlink doesn't allow to change subsets of the flags, just to override the set entirely by a new one. This means that for simply setting a device up or down userspace first needs to query the current flags, change it

[RTNETLINK]: Remove remains of wireless extensions over rtnetlink

2007-05-21 Thread Patrick McHardy
[RTNETLINK]: Remove remains of wireless extensions over rtnetlink Remove some unused variables and function arguments related to the recently removed wireless extensions over rtnetlink. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 192ecca1d62ada577a664410ed90b9a83315a65a tree

[PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Auke Kok
Herbert Xu wrote: netif_poll_enable can only be called if you've previously called netif_poll_disable. Otherwise a poll might already be in action and you may get a crash like this. Removing the call to netif_poll_enable in e1000_open should fix this issue, the only other call to

Re: [PATCH 1/2 v4] s2io: add PCI error recovery support

2007-05-21 Thread Andrew Morton
On Mon, 21 May 2007 13:58:53 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: This patch adds PCI error recovery support to the s2io 10-Gigabit ethernet device driver. Fourth revision, blocks MSI interrupts, and statistics gathering, as well. Tested, seems to work well. Signed-off-by:

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Dave Jones
On Mon, May 21, 2007 at 02:51:35PM -0700, Auke Kok wrote: Herbert Xu wrote: netif_poll_enable can only be called if you've previously called netif_poll_disable. Otherwise a poll might already be in action and you may get a crash like this. Removing the call to netif_poll_enable in

Re: [PATCH 1/2 v4] s2io: add PCI error recovery support

2007-05-21 Thread Linas Vepstas
On Mon, May 21, 2007 at 02:48:47PM -0700, Andrew Morton wrote: On Mon, 21 May 2007 13:58:53 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: This patch adds PCI error recovery support to the This is already in Jeff's development tree. Your new patch neither applies nor unapplies, so if

Re: UDP packet loss when running lsof

2007-05-21 Thread John Miller
Hi Eric, I CCed netdev since this stuff is about network and not lkml. Ok, dropped the CC... What kind of machine do you have ? SMP or not ? It's a HP system with two dual core CPUs at 3GHz, the storage system is connected through QLogic FC-HBA. It should really be fast enough to handle a

Re: [Bugme-new] [Bug 8519] New: NAT prerouting over tun interface broken

2007-05-21 Thread Patrick McHardy
Andrew Morton wrote: On Mon, 21 May 2007 13:05:36 -0700 [EMAIL PROTECTED] wrote: Problem Description: I have the hercules s/390 emulator running on an EM64T host, both running Debian unstable. I use a tun interface, a second IP address on eth0 and iptables/nat so the emulator has it's own

Re: [PATCH 1/2 v4] s2io: add PCI error recovery support

2007-05-21 Thread Andrew Morton
On Mon, 21 May 2007 17:23:57 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: On Mon, May 21, 2007 at 02:48:47PM -0700, Andrew Morton wrote: On Mon, 21 May 2007 13:58:53 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: This patch adds PCI error recovery support to the This is already in

Re: [PATCH 1/2 v4] s2io: add PCI error recovery support

2007-05-21 Thread Jeff Garzik
Linas Vepstas wrote: On Mon, May 21, 2007 at 02:48:47PM -0700, Andrew Morton wrote: On Mon, 21 May 2007 13:58:53 -0500 [EMAIL PROTECTED] (Linas Vepstas) wrote: This patch adds PCI error recovery support to the This is already in Jeff's development tree. Your new patch neither applies nor

[git patches] net driver fixes

2007-05-21 Thread Jeff Garzik
Two fixes and a one-line constant addition. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/declance.c |2 -- drivers/net/e1000/e1000_main.c |4

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Jeff Garzik
Auke Kok wrote: Herbert Xu wrote: netif_poll_enable can only be called if you've previously called netif_poll_disable. Otherwise a poll might already be in action and you may get a crash like this. Removing the call to netif_poll_enable in e1000_open should fix this issue, the only other call

Re: [PATCH] [NET] Add constant for FCS/CRC length (frame check sequence)

2007-05-21 Thread Jeff Garzik
Auke Kok wrote: From: Auke Kok [EMAIL PROTECTED] About a dozen drivers that have some form of crc checksumming or offloading use this constant, warranting a global define for it. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/if_ether.h |1 + 1 files changed, 1

Re: [PATCH] declance: Remove a dangling spin_unlock_irq() thingy

2007-05-21 Thread Jeff Garzik
Maciej W. Rozycki wrote: The spin_unlock_irq() invocation in lance_start_xmit() has no matching locking request. The call is already protected by netif_tx_lock, so remove the statement. Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] applied - To unsubscribe from this list: send the

[PATCH] zd1211rw-mac80211: Add ID for ZyXEL G-200v2

2007-05-21 Thread Daniel Drake
Tested by Guy Gallagher zd1211 chip 0586:3407 v4721 high 00-13-49 AL2230_RF pa0 g--- FCC ID SI5WUB200Z Signed-off-by: Daniel Drake [EMAIL PROTECTED] --- drivers/net/wireless/mac80211/zd1211rw/zd_usb.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[PATCH] zd1211rw-mac80211: Extend RF layer

2007-05-21 Thread Daniel Drake
These changes are needed for UW2453 RF support: Add pointer which RF drivers can use to store private RF data Add exit hook so that RF drivers can free private data Allow RF's to disable the generic TX power integration handling code Signed-off-by: Daniel Drake [EMAIL PROTECTED] ---

[PATCH] zd1211rw-mac80211: Add UW2453 RF support

2007-05-21 Thread Daniel Drake
This patch adds support for another radio appearing in new devices: the Ubec UW2453. It's more complicated than the other RF's we support, but Ubec publish full tech specs so we're able to understand the vendor code relatively well. Now that we support UW2453, we also support Atheros' new USB

[PATCH] zd1211rw-mac80211: Make CCK gain patching conditional on RF type

2007-05-21 Thread Daniel Drake
The vendor driver code suggests that CR47 patching happens on every channel change for every RF (depending on bit 8 in POD). Due to a bug in their driver (upper bits of RF_Mode get zeroed out, then are examined for 1s when setting some other flags), this isn't actually what happens, and their

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Kok, Auke
Jeff Garzik wrote: Auke Kok wrote: Herbert Xu wrote: netif_poll_enable can only be called if you've previously called netif_poll_disable. Otherwise a poll might already be in action and you may get a crash like this. Removing the call to netif_poll_enable in e1000_open should fix this issue,

Re: intermittant petabyte usage reported with broadcom nic

2007-05-21 Thread Michael Chan
On Mon, 2 Apr 2007 11:43:19 +1000 CaT [EMAIL PROTECTED] wrote: I take minute by minute snapshots of network traffic by sampling /proc/net/dev and most of the time everything works fine. Occasionally though I get petabyte byte traffic and corresponding packet traffic. We were able to

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Herbert Xu
On Mon, May 21, 2007 at 06:16:35PM -0400, Dave Jones wrote: On Mon, May 21, 2007 at 02:51:35PM -0700, Auke Kok wrote: Herbert Xu wrote: netif_poll_enable can only be called if you've previously called netif_poll_disable. Otherwise a poll might already be in action and you may get a

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Kok, Auke
Herbert Xu wrote: On Mon, May 21, 2007 at 06:16:35PM -0400, Dave Jones wrote: On Mon, May 21, 2007 at 02:51:35PM -0700, Auke Kok wrote: Herbert Xu wrote: netif_poll_enable can only be called if you've previously called netif_poll_disable. Otherwise a poll might already be in action and

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Herbert Xu
On Mon, May 21, 2007 at 07:42:39PM -0400, Jeff Garzik wrote: applied, though as a poster (DaveJ?) noted, I'm not sure it completely fixes the bug It should fix the problem completely in 2.6.22. For 2.6.21, we need a different fix because e1000_open is directly calling e1000_up. Cheers, --

Re: select(0, ..) is valid ?

2007-05-21 Thread Nish Aravamudan
On 5/18/07, Andi Kleen [EMAIL PROTECTED] wrote: On Wednesday 16 May 2007 17:37, Anton Blanchard wrote: Hi Hugh, It's interesting that compat_core_sys_select() shows this kmalloc(0) failure but core_sys_select() does not. That's because core_sys_select() avoids kmalloc by using a buffer

Re: [PATCH] e1000: Don't enable polling in open() (was: e1000: assertion hit in e1000_clean(), kernel 2.6.21.1)

2007-05-21 Thread Dave Jones
On Mon, May 21, 2007 at 05:58:27PM -0700, Kok, Auke wrote: This probably doesn't solve the latter bug. The code you reference isn't there in the kernel tested in that bug (2.6.21) In 2.6.21, netif_poll_enable is only called from e1000_up(), not e1000_open() Yes we need a

[PATCH 4/4] forcedeth: version bump

2007-05-21 Thread Ayaz Abdulla
This patch bumps up the version. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-21 20:09:03.0 -0400 +++ new/drivers/net/forcedeth.c 2007-05-21 20:10:32.0 -0400 @@ -112,6 +112,7 @@ * 0.58: 30 Oct 2006: Added support for sideband

[PATCH 2/4] forcedeth: fix power management support

2007-05-21 Thread Ayaz Abdulla
This patch fixes the power management functions. It includes lowering the phy speed to conserve power. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-01 15:32:03.0 -0400 +++ new/drivers/net/forcedeth.c 2007-05-21 19:54:39.0 -0400 @@ -812,6

[PATCH 1/4] forcedeth: add vitesse phy

2007-05-21 Thread Ayaz Abdulla
This patch adds errata support for the vitesse phy. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-01 15:30:53.0 -0400 +++ new/drivers/net/forcedeth.c 2007-05-01 15:30:57.0 -0400 @@ -550,6 +550,7 @@ /* PHY defines */ #define

[PATCH 3/4] forcedeth: fix cpu irq mask

2007-05-21 Thread Ayaz Abdulla
This patch fixes the cpu irq mask define to include the timer irq. Another flag check was setting up the timer bit in all cases so we didn't notice the issue. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] --- old/drivers/net/forcedeth.c 2007-05-21 20:07:44.0 -0400 +++