Re: IFF_PROMISC again

2007-05-26 Thread Martín Ferrari
Hi Ben, On 5/22/07, Ben Greear [EMAIL PROTECTED] wrote: PACKET_(ADD|REMOVE)_MEMBERSHIP, I need to query the real device state. I have the same problem. I think you can tell by looking at bit 0x100 in /sys/class/net/[ethX]/flags Not exactly fun to use, but it seems to work. Wow, I

Re: IFF_PROMISC again

2007-05-26 Thread Martín Ferrari
Hi David, On 5/22/07, David Miller [EMAIL PROTECTED] wrote: Anyone know the reasoning for masking out the PROMISC flag in dev_get_flags() ? Because promiscuous status is a counter, not a binary on-off state. You can't expect to just clear it and expect all the other promiscuous users to

Re: [PATCH][NET_SCHED] Update htb rate when stats are polled.

2007-05-26 Thread Patrick McHardy
Ranjit Manomohan wrote: Currently the HTB rate for a class is update very slowly (once every 16 seconds). This patch updates the rate whenever the stats are requested from user space. This enables more accurate rate monitoring. +/* Update packet/byte rate for a class. */ +static void

[PATCH 0/9]: tcp-2.6 patchset

2007-05-26 Thread Ilpo Järvinen
Hi, Here are some changes to TCP I've been baking. Before doing this patchset, I rebased tcp-2.6 branch to the current net-2.6 (goes almost cleanly) because there are some depencies to the TCP work in there. I booted these today and no very obvious problems showed up (OOPSes, BUG()s, reported

[PATCH 2/9] [TCP] FRTO: remove unnecessary fackets/sacked_out recounting

2007-05-26 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] F-RTO does not touch SACKED_ACKED bits at all, so there is no need to recount them in tcp_enter_frto_loss. After removal of the else branch, nested ifs can be combined. This must also reset sacked_out when SACK is not in use as TCP could

[PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out

2007-05-26 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] It is easily calculable when needed and user are not that many after all. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- include/linux/tcp.h |1 - include/net/tcp.h|4 ++-- net/ipv4/tcp_input.c | 11

[PATCH 1/9] [TCP]: Move Reno SACKed_out counter functions earlier

2007-05-26 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- net/ipv4/tcp_input.c | 98 -- 1 files changed, 47 insertions(+), 51 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c

[PATCH 4/9] [TCP]: Access to highest_sack obsoletes forward_cnt_hint

2007-05-26 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] In addition, added a reference about the purpose of the loop. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- include/linux/tcp.h |1 - net/ipv4/tcp_output.c | 23 +-- 2 files changed, 9 insertions(+), 15

[PATCH 5/9] [TCP]: Move code from tcp_ecn.h to tcp*.c and tcp.h remove it

2007-05-26 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] No other users exist for tcp_ecn.h. Very few things remain in tcp.h, for most TCP ECN functions callers reside within a single .c file and can be placed there. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- include/net/tcp.h|

[PATCH 6/9] [TCP]: Reorganize lost marking code

2007-05-26 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] The indentation started to get scary, so I reorganized code so that some trivial ifs are in tcp_update_scoreboard and the main loops remain in tcp_update_scoreboard_fack. It's much easier to view the actual changes with git-diff -w than

[PATCH 7/9] [TCP]: Correct fastpath entrypoint below high_seq

2007-05-26 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] In addition, implemented find_below using minus one. Some reorganization was necessary to make code efficient again. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- net/ipv4/tcp_input.c | 31 +-- 1 files

[PATCH 8/9] [TCP]: Reduce sacked_out with reno when purging write_queue

2007-05-26 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] Previously TCP had a transitional state during which reno counted segments that are already below the current window into sacked_out, which is now prevented. Re-try now unconditional S+L catching (I wonder if we could get that BUG_ON place

[PATCH 9/9] [RFC] [TCP]: Kill tp-fackets_out (tcp_sock diet program)

2007-05-26 Thread Ilpo Järvinen
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] The replacement fastpath uses arithmetics to find out fackets_out (or a necessary subset of it) when the sizes are less than MSS off from MSS*packets_out. Slowpath walks through the write queue. Saves some space in tcp_sock. Both

[PATCH] Avoid switch on long long in s2io driver

2007-05-26 Thread Andreas Schwab
A switch on long long causes gcc to generate a reference to __ucmpdi2 on ppc32. Avoid that by casting to int, since the value is only a small integer anyway. Signed-off-by: Andreas Schwab [EMAIL PROTECTED] --- drivers/net/s2io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH][NET_SCHED] Update htb rate when stats are polled.

2007-05-26 Thread Patrick McHardy
Patrick McHardy wrote: Ranjit Manomohan wrote: Currently the HTB rate for a class is update very slowly (once every 16 seconds). This patch updates the rate whenever the stats are requested from user space. This enables more accurate rate monitoring. +/* Update packet/byte rate for a class. */

Re: b44: regression in 2.6.22

2007-05-26 Thread Michael Buesch
On Saturday 26 May 2007 02:24:31 Stephen Hemminger wrote: Something is broken with the b44 driver in 2.6.22-rc1 or later. Now bisecting. The performance (with iperf) for receiving is normally 94Mbits or more. But something happened that dropped performance to less than 1Mbit, probably

Re: [PATCH] Avoid switch on long long in s2io driver

2007-05-26 Thread Michael Buesch
On Saturday 26 May 2007 10:58:15 Andreas Schwab wrote: A switch on long long causes gcc to generate a reference to __ucmpdi2 on ppc32. Avoid that by casting to int, since the value is only a small integer anyway. Signed-off-by: Andreas Schwab [EMAIL PROTECTED] --- drivers/net/s2io.c |

resend [PATCH 2/5 2.6.21] L2TP: Changes to existing ppp and socket kernel headers for L2TP

2007-05-26 Thread James Chapman
Add struct sockaddr_pppol2tp to carry L2TP-specific address information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't use the union inside struct sockaddr_pppox because the L2TP-specific data is larger than the current size of the union and we must preserve the size of struct

resend [PATCH 5/5 2.6.21] L2TP: Add PPPoL2TP in-kernel documentation

2007-05-26 Thread James Chapman
Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21/Documentation/networking/l2tp.txt === --- /dev/null +++ linux-2.6.21/Documentation/networking/l2tp.txt @@ -0,0 +1,167 @@ +This brief document describes how to use the

resend [PATCH 4/5 2.6.21] L2TP: Add PPPoL2TP maintainer

2007-05-26 Thread James Chapman
Signed-off-by: James Chapman [EMAIL PROTECTED] Index: linux-2.6.21/MAINTAINERS === --- linux-2.6.21.orig/MAINTAINERS +++ linux-2.6.21/MAINTAINERS @@ -2700,6 +2700,11 @@ P: Michal Ostrowski M: [EMAIL PROTECTED] S:

resend [PATCH 1/5 2.6.21] UDP: Introduce UDP encapsulation type for L2TP

2007-05-26 Thread James Chapman
This patch adds a new UDP_ENCAP_L2TPINUDP encapsulation type for UDP sockets. When a UDP socket's encap_type is UDP_ENCAP_L2TPINUDP, the skb is delivered to a function pointed to by udp_encap_l2tp_rcv. If the skb isn't wanted by L2TP, it returns 0, which causes it to be passed through to UDP. A

[PCNET32] Lock solid with netconsole

2007-05-26 Thread Emmanuel Fusté
Hello, Just to let you know that I swap my pcnet32 with a via-rhine and I no longer experienced hard machine lock after loading netconsole. Regards, Emmanuel. Hello, While trying to obtain scsi log to debug a driver problem, I tried to use netconsole on an old smp system with a 10Mbits

Re: [PCNET32] Lock solid with netconsole

2007-05-26 Thread Francois Romieu
Emmanuel Fusté [EMAIL PROTECTED] : [...] Just to let you know that I swap my pcnet32 with a via-rhine and I no longer experienced hard machine lock after loading netconsole. Any difference if you disable the debug messages in the pcnet32 driver and you apply the patch below ? diff --git

[PATCH 2.6.22 0/7] cxgb3 - bug fixes

2007-05-26 Thread Divy Le Ray
Hi Jeff, I'm submitting a set of bug fixes for inclusion in 2.6.22. The patches are built against Linus'git tree. Here is a brief description: - Fix page management in the SGE code, - Fix netpoll handler, - Fix link status detection for direct XAUI adapters, - Update FW to 4.1 and proceed to

[PATCH 1/7] cxgb3 - Fix SGE page management

2007-05-26 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Streamline page management on RX. Fix dma mappings. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/adapter.h | 38 ++-- drivers/net/cxgb3/sge.c | 425 ++- 2 files changed, 233 insertions(+),

[PATCH 2/7] cxgb3 - fix netpoll hanlder

2007-05-26 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Fix netpoll handler to work with line interrupt, msi and msi-x. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c | 12 +--- drivers/net/cxgb3/sge.c|1 - 2 files changed, 9 insertions(+), 4 deletions(-)

[PATCH 3/7] cxgb3 - Fix direct XAUI support

2007-05-26 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Check all lanes for link status on direct XAUI cards. Don't assume that direct XAUI always uses XGMAC 1. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/ael1002.c | 10 -- drivers/net/cxgb3/regs.h|2 ++ 2 files changed,

[PATCH 4/7] cxgb3 - Update FW to 4.1

2007-05-26 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Bump FW version to 4.1. Modify chip tuning in consequence. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/regs.h|4 drivers/net/cxgb3/t3_hw.c | 42 +++--- drivers/net/cxgb3/version.h |

[PATCH 5/7] cxgb3 - Stop mac RX when changing MTU

2007-05-26 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Rx traffic needs to be halted when the MTU is changed to avoid a potential chip hang. Reset/restore MAC filters around a MTU change. Also fix the pause frames high materwark setting. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/regs.h

[PATCH 6/7] cxgb3 - MAC watchdog update

2007-05-26 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Fix variables initialization and usage in the MAC watchdog. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/xgmac.c | 31 +-- 1 files changed, 21 insertions(+), 10 deletions(-) diff --git

[PATCH 7/7] cxgb3 - TP SRAM update

2007-05-26 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] The chip executes microcode present in internal RAM, whose content is loaded from EEPROM on power cycle. This patch allows an update of the microcode through PIO without forcing a power cycle. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] ---

Re: [PATCH 4/7] cxgb3 - Update FW to 4.1

2007-05-26 Thread Michael Buesch
On Sunday 27 May 2007 01:00:04 [EMAIL PROTECTED] wrote: From: Divy Le Ray [EMAIL PROTECTED] Bump FW version to 4.1. Modify chip tuning in consequence. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- @@ -2496,11 +2500,11 @@ static void __devinit init_mtus(unsigned * it can

Re: [PATCH 4/7] cxgb3 - Update FW to 4.1

2007-05-26 Thread Divy Le Ray
Michael Buesch wrote: On Sunday 27 May 2007 01:00:04 [EMAIL PROTECTED] wrote: From: Divy Le Ray [EMAIL PROTECTED] Bump FW version to 4.1. Modify chip tuning in consequence. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- @@ -2496,11 +2500,11 @@ static void __devinit

[PATCH 4/7 RESEND] cxgb3 - Update FW to 4.1

2007-05-26 Thread divy
From: Divy Le Ray [EMAIL PROTECTED] Bump FW version to 4.1. Modify chip tuning in consequence. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/regs.h|4 drivers/net/cxgb3/t3_hw.c | 40 ++-- drivers/net/cxgb3/version.h |

forcedeth: Reside in 100Mbit Kconfig but also supports 1000Mbit cards

2007-05-26 Thread Stefan Schmidt
Hello. I just needed some to tƣme to find out that the forcedeth driver I need for my dual-port 1000Mbit card on a asus M2N-SLI deluce mainboard resides in the 100Mbit category. Is there a special reason for example 10/100Mbit only cards that work with forcedeth? If all cards are 1000Mbit I

Re: [PATCH 0/9]: tcp-2.6 patchset

2007-05-26 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:53 +0300 Dave, you could consider applying other than the last one if they seem ok to you too (you'll need to rebase your tcp-2.6 in that case first to apply cleanly those that touch tcp_sync_left_out :-)). Absolutely, I'll do

Re: forcedeth: Reside in 100Mbit Kconfig but also supports 1000Mbit cards

2007-05-26 Thread Randy Dunlap
On Sun, 27 May 2007 01:07:50 +0200 Stefan Schmidt wrote: Hello. I just needed some to tƣme to find out that the forcedeth driver I need for my dual-port 1000Mbit card on a asus M2N-SLI deluce mainboard resides in the 100Mbit category. Is there a special reason for example 10/100Mbit only

[PATCH] Kill trailing whitespaces in drivers/net/Kconfig

2007-05-26 Thread Stefan Schmidt
Kill all trailing whitespaces in drivers/net/Kconfig. Signed-off-by: Stefan Schmidt [EMAIL PROTECTED] --- drivers/net/Kconfig | 48 1 files changed, 24 insertions(+), 24 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index

Re: forcedeth: Reside in 100Mbit Kconfig but also supports 1000Mbit cards

2007-05-26 Thread Stefan Schmidt
Hello. On Sat, 2007-05-26 at 17:29, Randy Dunlap wrote: On Sun, 27 May 2007 01:07:50 +0200 Stefan Schmidt wrote: What would be the best way to deal with this if there are some 10/100Mbit cards which use the same driver as 1000Mbit cards? There has been some mention of dropping the