Re: net-2.6.24 GIT state

2007-08-10 Thread Ilpo Järvinen
On Thu, 9 Aug 2007, David Miller wrote: I applied everything up until the SACK validator to net-2.6.24 Ok, thanks. Everything I hit today which had not been posted before was trivial fix or a reasonable small cleanup. ...Yeah, I know that but don't want to give impression that something

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 08:33:27AM +0200, Marcin Ślusarz wrote: 2007/8/9, Jarek Poplawski [EMAIL PROTECTED]: ... diff -Nurp 2.6.23-rc1-/kernel/irq/chip.c 2.6.23-rc1/kernel/irq/chip.c --- 2.6.23-rc1-/kernel/irq/chip.c 2007-07-09 01:32:17.0 +0200 +++ 2.6.23-rc1/kernel/irq/chip.c

Fwd: bug in kernel 2.6.20.9 in ipv6 dest opt help

2007-08-10 Thread md ayyaz
-- Forwarded message -- From: md ayyaz [EMAIL PROTECTED] Date: Aug 10, 2007 12:05 PM Subject: bug in kernel 2.6.20.9 in ipv6 dest opt help To: [EMAIL PROTECTED] Hi , i am working on mobile ipv6 protocol , so what happens whenver i pass a ipv6 packet with destination option in it

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Gabriel C
Dave Young wrote: On 8/10/07, Dave Young [EMAIL PROTECTED] wrote: On 8/10/07, Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 10 Aug 2007 16:18:38 +0800 Dave Young [EMAIL PROTECTED] wrote: Hi, 2.6.23-rc2-mm2: config with CONFIG_NF_CONNTRACK_AMANDA=y boot oops: hand copyed : the EIP:

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Michal Piotrowski
Andrew Morton pisze: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc2/2.6.23-rc2-mm2/ Yet another sysctl table check failed [ 88.949055] Netfilter messages via NETLINK v0.30. [ 89.485399] nf_conntrack version 0.5.0 (16384 buckets, 65536 max) [ 89.491892] sysctl

Re: [Bugme-new] [Bug 8876] New: Not all IPs are shown by ip addr show

2007-08-10 Thread Andrew Morton
On Fri, 10 Aug 2007 05:58:25 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8876 Summary: Not all IPs are shown by ip addr show Product: Networking Version: 2.5 KernelVersion: =2.6.22 (2.6.23.x too) Platform:

Re: [PATCH 2.6.24]S2io: Default to IntA interrupt type when there are less than 4 CPUs in the system.

2007-08-10 Thread Jeff Garzik
Rick Jones wrote: Sivakumar Subramani wrote: - Default to IntA interrupt type when there are less than 4 CPUs in the system. It might be good to include _why_ in the comment(s). I certainly am curious to know the reason, and it would be good to have in there for posterity should the

Re: [PATCH 2.6.24]S2io: Default to IntA interrupt type when there are less than 4 CPUs in the system.

2007-08-10 Thread Rick Jones
Sivakumar Subramani wrote: - Default to IntA interrupt type when there are less than 4 CPUs in the system. It might be good to include _why_ in the comment(s). I certainly am curious to know the reason, and it would be good to have in there for posterity should the underlying conditions

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Gabriel C
Michal Piotrowski wrote: Andrew Morton pisze: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc2/2.6.23-rc2-mm2/ Yet another sysctl table check failed [ 88.949055] Netfilter messages via NETLINK v0.30. [ 89.485399] nf_conntrack version 0.5.0 (16384 buckets,

Re: [PATCH] [NET] ethtool: Add LRO support

2007-08-10 Thread Kok, Auke
Jeff Garzik wrote: Auke Kok wrote: Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/ethtool.h |8 +++ include/linux/netdevice.h |1 + net/core/ethtool.c| 53 + 3 files changed, 62 insertions(+), 0 deletions(-)

Re: [RFC] IP_RECVERRC

2007-08-10 Thread Andi Kleen
On Fri, Aug 10, 2007 at 10:30:12AM -0400, jamal wrote: On Fri, 2007-10-08 at 16:02 +0200, Andi Kleen wrote: On Fri, Aug 10, 2007 at 09:35:12AM -0400, jamal wrote: Affected in what way? They dont get errors back and they just keep sending even in the presence of errors - take a

Re: [RFC] IP_RECVERRC

2007-08-10 Thread Andi Kleen
On Fri, Aug 10, 2007 at 09:35:12AM -0400, jamal wrote: It seems there are a lot of dumbass apps (latest i have found is iperf when analyzing batching results) out there whose performance is affected if they dont set IP_RECVERR. Affected in what way? If you set that option though you end

Re: [PATCH RFC]: napi_struct V5

2007-08-10 Thread jamal
On Thu, 2007-09-08 at 09:58 -0700, Roland Dreier wrote: Could you explain why this is unfair? The simple answer is the core attempts DRR scheduling (search for the paper by Varghese et al for more details) If you have multiple users of a resource (network interfaces in this case), then the

[net-2.6.24] forcedeth does not compile without CONFIG_FORCEDETH_NAPI set

2007-08-10 Thread Oliver Hartkopp
Checking some other source with the current net-2.6.24 GIT, i just discovered this: CC drivers/net/mii.o CC drivers/net/Space.o CC drivers/net/loopback.o CC drivers/net/b44.o CC drivers/net/forcedeth.o drivers/net/forcedeth.c: In function nv_nic_irq:

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Eric W. Biederman
Gabriel C [EMAIL PROTECTED] writes: Michal Piotrowski wrote: Andrew Morton pisze: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc2/2.6.23-rc2-mm2/ Yet another sysctl table check failed [ 88.949055] Netfilter messages via NETLINK v0.30. [ 89.485399]

[PATCH 1/4] /drivers/net ioremap balancing/returncode check (es3210.c)

2007-08-10 Thread Scott Thompson
patchset against 2.6.23-rc2 for /drivers/net ioremap balancing / return check: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe had incorrect/not ideal variable check on if for

[PATCH 2/4] /drivers/net ioremap balancing/returncode check (lne390.c)

2007-08-10 Thread Scott Thompson
patchset against 2.6.23-rc2 for /drivers/net ioremap balancing / return check: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe had incorrect/not ideal variable check on if for

[PATCH 4/4] /drivers/net ioremap balancing/returncode check (ucc_geth.c.c)

2007-08-10 Thread Scott Thompson
patchset against 2.6.23-rc2 for /drivers/net ioremap balancing / return check: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe had incorrect/not ideal variable check on if for

[PATCH 3/4] /drivers/net ioremap balancing/returncode check (myri_sbus.c)

2007-08-10 Thread Scott Thompson
patchset against 2.6.23-rc2 for /drivers/net ioremap balancing / return check: corrects: --sbus_ioremap return unchecked. --ioremap function unchecked --function failure cases did not clean up ioremap'd values. lne390.c -- believe had incorrect/not ideal variable check on if for

RE: [PATCH 2.6.24]S2io: Default to IntA interrupt type when there are less than 4 CPUs in the system.

2007-08-10 Thread Ramkrishna Vepa
We had found during performance measurement/analysis that with 2 cpus and napi disabled, and the system transmitting (tcp), the cpus get too busy due to receive interrupt handling, reducing performance by around 10%. But then again, when the number of cpus increase, the interrupt scaling is much

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Michal Piotrowski
On 10/08/07, Gabriel C [EMAIL PROTECTED] wrote: Michal Piotrowski wrote: Andrew Morton pisze: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc2/2.6.23-rc2-mm2/ Yet another sysctl table check failed [ 88.949055] Netfilter messages via NETLINK v0.30. [

Re: [RFC] IP_RECVERRC

2007-08-10 Thread jamal
On Fri, 2007-10-08 at 16:02 +0200, Andi Kleen wrote: On Fri, Aug 10, 2007 at 09:35:12AM -0400, jamal wrote: Affected in what way? They dont get errors back and they just keep sending even in the presence of errors - take a look at ip_push_pending_frames. I have been struggling initially

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jean-Baptiste Vignaud
see below arch/i386/kernel/io_apic.c |3 ++- arch/x86_64/kernel/genapic.c |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) Index: linux/arch/i386/kernel/io_apic.c === ---

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Andrew Morton
On Fri, 10 Aug 2007 11:33:41 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: Gabriel C [EMAIL PROTECTED] writes: Michal Piotrowski wrote: Andrew Morton pisze: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc2/2.6.23-rc2-mm2/ Yet another sysctl table

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-10 Thread Unai Uribarri
On vie, 2007-08-10 at 12:34 +0400, Evgeniy Polyakov wrote: Hi Unai. On Thu, Aug 09, 2007 at 08:44:21PM +0200, Unai Uribarri ([EMAIL PROTECTED]) wrote: There is another option: 1. Move timestampt activation to packet_set_ring(), so it's activated only once at setup instead of every

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 12:43:43PM +0200, Marcin Ślusarz wrote: 2007/8/10, Jarek Poplawski [EMAIL PROTECTED]: (..) I think, there is this one possible for your testing yet?: Subject: [patch] genirq: temporary fix for level-triggered IRQ resend Date: Wed, 8 Aug 2007 13:00:37 +0200 I think

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Marcin Ślusarz
2007/8/10, Jarek Poplawski [EMAIL PROTECTED]: (..) I think, there is this one possible for your testing yet?: Subject: [patch] genirq: temporary fix for level-triggered IRQ resend Date: Wed, 8 Aug 2007 13:00:37 +0200 I think I already tested this patch, but this thread is sooo big and I can't

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 11:33:53AM +0200, Ingo Molnar wrote: * Jarek Poplawski [EMAIL PROTECTED] wrote: + } #ifdef CONFIG_HARDIRQS_SW_RESEND we used the hw-resend method unconditionally, right? Right: unconditionally on a condition they are not edges...

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Dave Young
On 8/10/07, Dave Young [EMAIL PROTECTED] wrote: On 8/10/07, Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 10 Aug 2007 16:18:38 +0800 Dave Young [EMAIL PROTECTED] wrote: Hi, 2.6.23-rc2-mm2: config with CONFIG_NF_CONNTRACK_AMANDA=y boot oops: hand copyed : the EIP:

Re: [PATCH 6/24] make atomic_read() behave consistently on frv

2007-08-10 Thread David Howells
Chris Snook [EMAIL PROTECTED] wrote: To head off the criticism, I admit this is an oversimplification, and true busy-waiters should be using cpu_relax(), which contains a barrier. Why would you want to use cpu_relax()? That's there to waste time efficiently, isn't it? Shouldn't you be using

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 11:08:33AM +0200, Ingo Molnar wrote: * Jarek Poplawski [EMAIL PROTECTED] wrote: On 10-08-2007 10:05, Thomas Gleixner wrote: ... But suppressing the resend is not fixing the driver problem. The problem can show up with spurious interrupts and with interrupts

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 10:56:11AM +0200, Ingo Molnar wrote: ... this changes the picture completely and makes the IO-APIC/local-APIC hw retrigger code/logic the main suspect. I think you right that it's quite bogus to hw-retrigger level irqs, and that could be confusing the IO-APIC (or the

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: On 10-08-2007 10:05, Thomas Gleixner wrote: ... But suppressing the resend is not fixing the driver problem. The problem can show up with spurious interrupts and with interrupts on a shared PCI interrupt line at any time. It just might take

Re: [GENETLINK]: Question: global lock (genl_mutex) possible refinement?

2007-08-10 Thread Richard MUSIL
Hello Thomas, I wonder, if you had time to take a look at the patch I posted back then. Richard Thomas Graf wrote: Please provide a new overall patch which is not based on your initial patch so I can review your idea properly. Here it goes (merging two previous patches). I have

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 10:30:50AM +0200, Ingo Molnar wrote: * Jarek Poplawski [EMAIL PROTECTED] wrote: Hmm. This solution is still just pampering over the real problem. The delayed disable just re-sends level interrupts unnecessarily. I have a fix (needs some testing) for this,

Re: [PATCH 1/24] make atomic_read() behave consistently on alpha

2007-08-10 Thread Herbert Xu
Paul E. McKenney [EMAIL PROTECTED] wrote: The compiler is within its rights to read a 32-bit quantity 16 bits at at time, even on a 32-bit machine. I would be glad to help pummel any compiler writer that pulls such a dirty trick, but the C standard really does permit this. Code all over the

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 10:05:40AM +0200, Thomas Gleixner wrote: On Thu, 2007-08-09 at 17:54 +0200, Jarek Poplawski wrote: I'm not sure I don't miss anything (a little in hurry now), but this warning's aim was purely diagnostical and nothing wrong is meant! Unless there is something

Add 3c59x maintainer

2007-08-10 Thread Steffen Klassert
Add 3c59x maintainer. Signed-off-by: Steffen Klassert [EMAIL PROTECTED] --- MAINTAINERS |6 ++ 1 file changed, 6 insertions(+) --- linux-2.6.23-rc2.orig/MAINTAINERS +++ linux-2.6.23-rc2/MAINTAINERS @@ -97,6 +97,12 @@ M: [EMAIL PROTECTED] L: netdev@vger.kernel.org S:

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Thomas Gleixner
On Thu, 2007-08-09 at 17:54 +0200, Jarek Poplawski wrote: I'm not sure I don't miss anything (a little in hurry now), but this warning's aim was purely diagnostical and nothing wrong is meant! Unless there is something wrong... Then please try to be more explicit. If you prefer to not see

Re: 2.6.23-rc2-mm2: possible irq lock inversion dependency detected

2007-08-10 Thread Mariusz Kozlowski
Hello, Have fun :) = [ INFO: possible irq lock inversion dependency detected ] 2.6.23-rc2-mm2 #1 - depscan.sh/5928 just changed the state of lock: (_xmit_ETHER){-+..}, at:

Re: [PATCH 1/24] make atomic_read() behave consistently on alpha

2007-08-10 Thread Segher Boessenkool
The compiler is within its rights to read a 32-bit quantity 16 bits at at time, even on a 32-bit machine. I would be glad to help pummel any compiler writer that pulls such a dirty trick, but the C standard really does permit this. Code all over the kernel assumes that 32-bit reads/writes

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Jean-Baptiste Vignaud
So, we still have to wait for the exact explanation... Thanks very much Marcin! I think, there is this one possible for your testing yet?: Subject: [patch] genirq: temporary fix for level-triggered IRQ resend Date: Wed, 8 Aug 2007 13:00:37 +0200 If it's not a great problem it would be

Re: [PATCH] [NET] ethtool: Add LRO support

2007-08-10 Thread Jan-Bernd Themann
Hi On Friday 10 August 2007 00:00, David Miller wrote: From: Auke Kok [EMAIL PROTECTED] Date: Thu, 09 Aug 2007 09:41:17 -0700 Signed-off-by: Auke Kok [EMAIL PROTECTED] I think this is definitely how we should handle LRO configuration instead of the ad-hoc module parameters current LRO

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: Hmm. This solution is still just pampering over the real problem. The delayed disable just re-sends level interrupts unnecessarily. I have a fix (needs some testing) for this, which I send out tomorrow, when I'm really back from vacation.

Re: 2.6.23-rc2-mm2

2007-08-10 Thread Andrew Morton
On Fri, 10 Aug 2007 16:18:38 +0800 Dave Young [EMAIL PROTECTED] wrote: Hi, 2.6.23-rc2-mm2: config with CONFIG_NF_CONNTRACK_AMANDA=y boot oops: hand copyed : the EIP: helper_hash backtrace: do_basic_setup ... nf_conntrack_amanda_init error_code do_vivide_error ... cc netdev

Re: [PATCH 1/1] af_packet: don't enable timestamps in mmap'ed sockets

2007-08-10 Thread Evgeniy Polyakov
Hi Unai. On Thu, Aug 09, 2007 at 08:44:21PM +0200, Unai Uribarri ([EMAIL PROTECTED]) wrote: There is another option: 1. Move timestampt activation to packet_set_ring(), so it's activated only once at setup instead of every time a packet arrives. Does this break existing systems which

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 10:15:53AM +0200, Jean-Baptiste Vignaud wrote: ... I was still testing on -rc2: Subject: [patch] genirq: temporary fix for level-triggered IRQ resend Date: Wed, 8 Aug 2007 13:00:37 +0200 For me after 1day 20hours, the network is still up, with more than 1To of

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Jean-Baptiste Vignaud
For me it's enough too but Thomas seems to doubt. You've written earlier that you've 2.6.23-rc1 with HARDIRQS_SW_RESEND prepared too. So, if this is not a great problem maybe you could try this first. Tomorrow Thomas may send something, so this 100HZ could wait yet, I hope? Ok, i'll test

Re: [PATCH] [NET] ethtool: Add LRO support

2007-08-10 Thread Jeff Garzik
Auke Kok wrote: Signed-off-by: Auke Kok [EMAIL PROTECTED] --- include/linux/ethtool.h |8 +++ include/linux/netdevice.h |1 + net/core/ethtool.c| 53 + 3 files changed, 62 insertions(+), 0 deletions(-) diff --git

[GENETLINK] some thoughts on the usage

2007-08-10 Thread Richard MUSIL
Hello all, I am currently writing virtual TPM device driver. This is supposed to behave the same way as normal TPM but instead sending commands to hardware device, it will pass them back to user space. Probably similar in concept to tun/tap but with the difference it has nothing to do with

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: On Fri, Aug 10, 2007 at 10:15:53AM +0200, Jean-Baptiste Vignaud wrote: ... I was still testing on -rc2: Subject: [patch] genirq: temporary fix for level-triggered IRQ resend Date: Wed, 8 Aug 2007 13:00:37 +0200 For me after 1day 20hours,

Re: [PATCH] e1000e: New pci-express e1000 driver (currently for ICH9 devices only)

2007-08-10 Thread Kok, Auke
Andi Kleen wrote: Kok, Auke [EMAIL PROTECTED] writes: All, Another update on e1000e. Many thanks to Jeff for helping out and getting this going forward. The driver is unfortunately still too large to post, so please use the URL's below to review: Just some things I noticed; no comprehensive

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: [...] Well, there are probably (but need more testing) two other solutions: _SW_RESEND and disabling without delay for levels only... IIRC Marcin tested software-resend and it didnt fix the hang. That strongly points in the direction

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Jarek Poplawski
On Fri, Aug 10, 2007 at 10:48:41AM +0200, Ingo Molnar wrote: * Jarek Poplawski [EMAIL PROTECTED] wrote: On Fri, Aug 10, 2007 at 10:15:53AM +0200, Jean-Baptiste Vignaud wrote: ... I was still testing on -rc2: Subject: [patch] genirq: temporary fix for level-triggered IRQ resend

Re: [PATCH 1/24] make atomic_read() behave consistently on alpha

2007-08-10 Thread Andi Kleen
On Friday 10 August 2007 10:21:46 Herbert Xu wrote: Paul E. McKenney [EMAIL PROTECTED] wrote: The compiler is within its rights to read a 32-bit quantity 16 bits at at time, even on a 32-bit machine. I would be glad to help pummel any compiler writer that pulls such a dirty trick, but

Re: [PATCH] [NET] ethtool: Add LRO support

2007-08-10 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 04:42:44 -0400 I'll code this up, along with the associated generic helpers (net/core/ethtool.c), if there are no objections. No objections except I would give the driver private it's own set of flags. Otherwise the number of bits

Re: [PATCH] [NET] ethtool: Add LRO support

2007-08-10 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 10 Aug 2007 04:42:44 -0400 I'll code this up, along with the associated generic helpers (net/core/ethtool.c), if there are no objections. No objections except I would give the driver private it's own set of flags. Great

[PATCH][RFC] ethtool flags

2007-08-10 Thread Jeff Garzik
NOTE 1: note the code comments about read-only flag behavior NOTE 2: I ignored driver-private flags for the moment (these were mentioned in the previous email) NOTE 3: ethtool_op_xxx implementation will probably change a bit, as we see what drivers really need. NOTE 4: the

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: + } #ifdef CONFIG_HARDIRQS_SW_RESEND we used the hw-resend method unconditionally, right? Right: unconditionally on a condition they are not edges... But, since not resending at all seems to work so good in testing, I

Re: [patch (testing)] Re: 2.6.20-2.6.21 - networking dies after random time

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: All correct! There was also checked a possibility it can be not hw itself, but wrong way of handling after hw (acking too late). This was false idea (or bad implementation), so it looks like hw vs lapic problem. i think the problem is that local

Re: 2.6.23-rc2-mm2 -- conntrack divide error

2007-08-10 Thread Jiri Slaby
Gabriel C napsal(a): Dave Young wrote: On 8/10/07, Dave Young [EMAIL PROTECTED] wrote: On 8/10/07, Andrew Morton [EMAIL PROTECTED] wrote: On Fri, 10 Aug 2007 16:18:38 +0800 Dave Young [EMAIL PROTECTED] wrote: Hi, 2.6.23-rc2-mm2: config with CONFIG_NF_CONNTRACK_AMANDA=y boot oops: hand

[RFC PATCH v0.1] net driver: mpc52xx fec

2007-08-10 Thread Domen Puncer
Hi! Not for merge (yet)! But please do review. fec_mpc52xx driver (not in-tree, but floating around) isn't in very good shape, so I tried to change that. Diff against original is quite big (fec_phy.c is completely rewritten) and confuzing, so I'm including whole drivers/net/fec_mpc52xx/ . I

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Stephen Hemminger
On Fri, 10 Aug 2007 11:33:53 +0200 Ingo Molnar [EMAIL PROTECTED] wrote: * Jarek Poplawski [EMAIL PROTECTED] wrote: + } #ifdef CONFIG_HARDIRQS_SW_RESEND we used the hw-resend method unconditionally, right? Right: unconditionally on a condition they are not

Re: 2.6.23-rc2: WARNING: at kernel/irq/resend.c:70 check_irq_resend()

2007-08-10 Thread Ingo Molnar
* Jarek Poplawski [EMAIL PROTECTED] wrote: Ingo: I think, you have to do this in x86_64, and there is probably send_IPI_mask used for this (but I can miss something...). indeed - full patch below. Ingo --- arch/i386/kernel/io_apic.c |3 ++- arch/x86_64/kernel/genapic.c |

Driver writer hints (was [PATCH 3/4] Add ETHTOOL_[GS]PFLAGS sub-ioctls)

2007-08-10 Thread Jeff Garzik
Jeff Garzik wrote: commit 4901236cec047029b970261b95e47d6be60f523e Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Aug 10 15:52:06 2007 -0400 [ETHTOOL] Introduce -{get,set}_priv_flags, ETHTOOL_[GS]PFLAGS Signed-off-by: Jeff Garzik [EMAIL PROTECTED] include/linux/ethtool.h |

[PATCH for 2.6.24] SCTP: Rewrite of sctp buffer management code

2007-08-10 Thread Vlad Yasevich
This patch introduces autotuning to the sctp buffer management code similar to the TCP. The buffer space can be grown if the advertised receive window still has room. This might happen if small message sizes are used, which is common in telecom environmens. New tunables are introduced that

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread Jeff Garzik
All this is currently checked into the 'eflags' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git But when everybody is happy with it, IMO we should get it into net-2.6.24.git, as it enables LRO. Jeff - To unsubscribe from this list: send the line

[PATCH 6/6] ibmveth: Remove use of bitfields

2007-08-10 Thread Brian King
Removes the use of bitfields from the ibmveth driver. This results in slightly smaller object code. Signed-off-by: Brian King [EMAIL PROTECTED] --- linux-2.6-bjking1/drivers/net/ibmveth.c | 90 linux-2.6-bjking1/drivers/net/ibmveth.h | 56

[PATCH 3/6] ibmveth: Add ethtool TSO handlers

2007-08-10 Thread Brian King
Add handlers for get_tso and get_ufo to prevent errors being printed by ethtool. Signed-off-by: Brian King [EMAIL PROTECTED] --- linux-2.6-bjking1/drivers/net/ibmveth.c |2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso drivers/net/ibmveth.c ---

[PATCH 2/6] ibmveth: Implement ethtool hooks to enable/disable checksum offload

2007-08-10 Thread Brian King
This patch adds the appropriate ethtool hooks to allow for enabling/disabling of hypervisor assisted checksum offload for TCP. Signed-off-by: Brian King [EMAIL PROTECTED] --- linux-2.6-bjking1/drivers/net/ibmveth.c | 125 +++-

[patch 01/18] revert 8139too: clean up I/O remapping

2007-08-10 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] Revert git-netdev-all's 9ee6b32a47b9abc565466a9c3b127a5246b452e5. Michal was getting oopses. Cc: Michal Piotrowski [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/8139too.c | 50

[patch 07/18] PCI-X/PCI-Express read control interfaces: use them in e1000

2007-08-10 Thread akpm
From: Peter Oruba [EMAIL PROTECTED] These driver changes incorporate the proposed PCI-X / PCI-Express read byte count interface. Reading and setting those valuse doesn't take place manually, instead wrapping functions are called to allow quirks for some PCI bridges. Signed-off by: Peter Oruba

[patch 02/18] sundance: PHY address form 0, only for device ID 0x0200 (IP100A) (20070605)

2007-08-10 Thread akpm
From: Jesse Huang [EMAIL PROTECTED] Search PHY address form 0, only for device ID 0x0200 (IP100A). Other device are from PHY address 1. Signed-off-by: Jesse Huang [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/sundance.c |

[patch 05/18] PHY fixed driver: rework release path and update phy_id notation

2007-08-10 Thread akpm
From: Vitaly Bordug [EMAIL PROTECTED] device_bind_driver() error code returning has been fixed. release() function has been written, so that to free resources in correct way; the release path is now clean. Before the rework, it used to cause Device '[EMAIL PROTECTED]:1' does not have a

[patch 04/18] via-rhine: disable rx_copybreak on archs that don't allow unaligned DMA access

2007-08-10 Thread akpm
From: Dustin Marquess [EMAIL PROTECTED] Patch to disable the rx_copybreak feature on hardware architectures that don't allow unaligned DMA access. #ifdef code taken from tulip_core.c. Problem pointed out by Ivan Kokshaysky. Signed-off-by: Dustin Marquess [EMAIL PROTECTED] Cc: Francois Romieu

[patch 06/18] PCI-X/PCI-Express read control interfaces: use them in myrinet

2007-08-10 Thread akpm
From: Peter Oruba [EMAIL PROTECTED] These driver changes incorporate the proposed PCI-X / PCI-Express read byte count interface. Reading and setting those valuse doesn't take place manually, instead wrapping functions are called to allow quirks for some PCI bridges. Signed-off by: Peter Oruba

[patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation

2007-08-10 Thread akpm
From: Dan Faerch [EMAIL PROTECTED] Adds ethtool command support to driver. Initially 2 commands are implemented: force fullduplex and toggle autoneg. Also added a disable_autoneg module argument to completely disable autoneg on all cards using this driver. Signed-off-by: Dan Faerch [EMAIL

[PATCH 4/7] sysctl: remove broken netfilter binary sysctls

2007-08-10 Thread Eric W. Biederman
No one has bothered to set strategy routine for the the netfilter sysctls that return jiffies to be sysctl_jiffies. So it appears the sys_sysctl path is unused and untested, so this patch removes the binary sysctl numbers. Which fixes the netfilter oops in 2.6.23-rc2-mm2 for me. Signed-off-by:

[patch 08/18] 3c59x: check return of pci_enable_device()

2007-08-10 Thread akpm
From: Mark Hindley [EMAIL PROTECTED] Check return of pci_enable_device in vortex_up(). Signed-off-by: Mark Hindley [EMAIL PROTECTED] Acked-by: Steffen Klassert [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/net/3c59x.c |8 ++-- 1 files changed, 6

Re: [PATCH 1/4] Add ETHTOOL_[GS]FLAGS sub-ioctls

2007-08-10 Thread Ben Greear
Jeff Garzik wrote: This patch copies Auke in adding NETIF_F_LRO. Is that just for temporary merging, or does the net core really not touch it at all? Because, logically, if NETIF_F_LRO exists nowhere else but this patch, we should not add it to dev-features. LRO knowledge can be contained

[patch 07/28] Clean up duplicate includes in net/sched/

2007-08-10 Thread akpm
From: Jesper Juhl [EMAIL PROTECTED] This patch cleans up duplicate includes in net/sched/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- net/sched/act_police.c |1 - 1 files changed, 1 deletion(-) diff -puN

[patch 09/28] Clean up duplicate includes in net/tipc/

2007-08-10 Thread akpm
From: Jesper Juhl [EMAIL PROTECTED] This patch cleans up duplicate includes in net/tipc/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- net/tipc/port.c |1 - 1 files changed, 1 deletion(-) diff -puN

[patch 13/28] fib_trie: macro cleanup

2007-08-10 Thread akpm
From: Stephen Hemminger [EMAIL PROTECTED] This patch converts the messy macro for MASK_PFX to inline function and expands TKEY_GET_MASK in the one place it is used. Cc: David S. Miller [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- net/ipv4/fib_trie.c | 18

[patch 12/28] fib_trie: cleanup

2007-08-10 Thread akpm
From: Stephen Hemminger [EMAIL PROTECTED] Try this out: * replace macro's with inlines * get rid of places doing multiple evaluations of NODE_PARENT [EMAIL PROTECTED]: rcu_dereference wants an lval] Cc: David S. Miller [EMAIL PROTECTED] Cc: Paul E. McKenney [EMAIL PROTECTED]

[patch 01/28] fore200e_param_bs_queue() must be __devinit

2007-08-10 Thread akpm
From: Adrian Bunk [EMAIL PROTECTED] WARNING: drivers/built-in.o(.text+0x6203bb): Section mismatch: reference to .init.text:fore200e_param_bs_queue (between 'fore200e_initialize' and 'fore200e_monitor_putc') Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

[patch 10/28] Clean up duplicate includes in net/xfrm/

2007-08-10 Thread akpm
From: Jesper Juhl [EMAIL PROTECTED] This patch cleans up duplicate includes in net/xfrm/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- net/xfrm/xfrm_policy.c |3 +-- net/xfrm/xfrm_state.c |3 +-- 2 files changed, 2

[patch 14/28] dccp: fix memory leak and clean up style - dccp_feat_empty_confirm()

2007-08-10 Thread akpm
From: Jesper Juhl [EMAIL PROTECTED] There's a memory leak in net/dccp/feat.c::dccp_feat_empty_confirm(). If we hit the 'default:' case of the 'switch' statement, then we return without freeing 'opt', thus leaking 'struct dccp_opt_pend' bytes. The leak is fixed easily enough by adding a

[patch 03/28] Clean up duplicate includes in drivers/atm/

2007-08-10 Thread akpm
From: Jesper Juhl [EMAIL PROTECTED] This patch cleans up duplicate includes in drivers/atm/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Cc: Chas Williams [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/atm/lanai.c |1 - 1 files changed, 1 deletion(-)

[patch 04/28] Clean up duplicate includes in net/atm/

2007-08-10 Thread akpm
From: Jesper Juhl [EMAIL PROTECTED] This patch cleans up duplicate includes in net/atm/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Cc: Chas Williams [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- net/atm/lec.c |1 - 1 files changed, 1 deletion(-) diff -puN

[patch 08/28] Clean up duplicate includes in net/sunrpc/

2007-08-10 Thread akpm
From: Jesper Juhl [EMAIL PROTECTED] This patch cleans up duplicate includes in net/sunrpc/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Cc: Trond Myklebust [EMAIL PROTECTED] Cc: Neil Brown [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 16/28] drivers/net/irda/irda-usb.c: mostly kmalloc + memset conversion to k[cz]alloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski [EMAIL PROTECTED] drivers/net/irda/irda-usb.c | 59694 - 59541 (-153 bytes) drivers/net/irda/irda-usb.o | 170588 - 169256 (-1332 bytes) Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] Cc: Samuel Ortiz [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED]

[patch 06/28] Clean up duplicate includes in net/ipv6/

2007-08-10 Thread akpm
From: Jesper Juhl [EMAIL PROTECTED] This patch cleans up duplicate includes in net/ipv6/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- net/ipv6/tcp_ipv6.c |1 - 1 files changed, 1 deletion(-) diff -puN

[patch 05/28] Clean up duplicate includes in net/ipv4/

2007-08-10 Thread akpm
From: Jesper Juhl [EMAIL PROTECTED] This patch cleans up duplicate includes in net/ipv4/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- net/ipv4/ip_output.c |1 - net/ipv4/ipvs/ip_vs_ctl.c |1 -

[patch 17/28] drivers/atm/iphase.c: mostly kmalloc + memset conversion to kzalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski [EMAIL PROTECTED] drivers/atm/iphase.c | 111508 - 111431 (-77 bytes) drivers/atm/iphase.o | 254740 - 254260 (-480 bytes) Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/atm/iphase.c | 12 ++-- 1

[patch 15/28] drivers/net/wan/hdlc_fr.c: kmalloc + memset conversion to kzalloc

2007-08-10 Thread akpm
From: Mariusz Kozlowski [EMAIL PROTECTED] drivers/net/wan/hdlc_fr.c | 31260 - 31223 (-37 bytes) drivers/net/wan/hdlc_fr.o | 144872 - 144728 (-144 bytes) Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED] Acked-by: Krzysztof Halasa [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL

[patch 19/28] netconsole: Remove bogus check

2007-08-10 Thread akpm
From: Satyam Sharma [EMAIL PROTECTED] Based upon initial work by Keiichi Kii [EMAIL PROTECTED]. The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is set by netpoll_setup(), which is called by init_netconsole() before register_console(), so write_msg() cannot be

Re: [patch 03/18] drivers/net/ns83820.c: add paramter to disable autonegotiation

2007-08-10 Thread Benjamin LaHaise
On Fri, Aug 10, 2007 at 02:05:13PM -0700, [EMAIL PROTECTED] wrote: Also added a disable_autoneg module argument to completely disable autoneg on all cards using this driver. ... [akpm: this is a previously-nacked patch, but the problem is real] Please remove this part of the patch. The

[patch 10/18] ax88796 printk fixes

2007-08-10 Thread akpm
From: Andrew Morton [EMAIL PROTECTED] drivers/net/ax88796.c: In function `ax_probe': drivers/net/ax88796.c:825: warning: size_t format, different type arg (arg 4) drivers/net/ax88796.c:825: warning: size_t format, different type arg (arg 5) resource_size_t isn't size_t. Cc: Jeff Garzik [EMAIL

[patch 28/28] Introduce strtol_check_range()

2007-08-10 Thread akpm
From: Satyam Sharma [EMAIL PROTECTED] Callers (especially store functions for sysfs or configfs attributes) that want to convert an input string to a number may often also want to check for simple input sanity or allowable range. strtol10_check_range() of netconsole does this, so extract it out

[patch 27/28] Introduce U16_MAX and U32_MAX

2007-08-10 Thread akpm
From: Satyam Sharma [EMAIL PROTECTED] ... in kernel.h and clean up home-grown macros elsewhere in the tree. Leave out the one in reiserfs_fs.h as it is in the userspace-visible part of that header. Still, #undef the (equivalent) kernel version there to avoid seeing redefined, previous definition

  1   2   3   >