Re: net-2.6.24 rebased

2007-08-30 Thread Joe Perches
On Wed, 2007-08-29 at 16:47 -0700, Joe Perches wrote: On Wed, 2007-08-29 at 16:41 -0700, David Miller wrote: From: Joe Perches [EMAIL PROTECTED] Date: Wed, 29 Aug 2007 16:34:00 -0700 On Tue, 2007-08-28 at 17:59 -0700, David Miller wrote: I pushed this fix into net-2.6.24 just now,

Re: Tc bug (kernel crash) more info

2007-08-30 Thread Jarek Poplawski
On Thu, Aug 30, 2007 at 12:16:32AM +0400, [EMAIL PROTECTED] wrote: Quoting Jarek Poplawski [EMAIL PROTECTED]: On Wed, Aug 29, 2007 at 04:53:52PM +0400, Badalian Vyacheslav wrote: ... we have this kernel panic (then delete HTB) at all 2.6.18-x versions. on older kernel (2.6.x) we have

Re: ipv4_get_l4proto: Frag of proto 17

2007-08-30 Thread Patrick McHardy
Meelis Roos wrote: Yesterdays git snapsot on a normal home PC spams dmesg with the following line: ipv4_get_l4proto: Frag of proto 17 In what situation does this happen? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

AW: [RFT] r8169 changes against 2.6.23-rc3

2007-08-30 Thread Reither Robert
Hi François, tested your latest patchset with my 8110SC multicast problem (unreliable multicast receiving) Sad but true, but all still the same ... Greetings Robert - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: Tc bug (kernel crash) more info

2007-08-30 Thread Jarek Poplawski
On Thu, Aug 30, 2007 at 08:31:10AM +0200, Jarek Poplawski wrote: On Thu, Aug 30, 2007 at 12:16:32AM +0400, [EMAIL PROTECTED] wrote: ... PS. And also have we have strange bug in another computer (2.6.22-r5). Have computer XEON_CPUx2 (4 CPU) after boot have CPU0 and CPU3 SI = ~50% after

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-30 Thread Jarek Poplawski
On 29-08-2007 21:37, Michael Buesch wrote: On Wednesday 29 August 2007 21:33:43 Jon Smirl wrote: What if a patch spans both code that is pure GPL and code imported from BSD, how do you license it? I think it's a valid assumption, if we say that the author of the patch read the license

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-30 Thread Jarek Poplawski
On Thu, Aug 30, 2007 at 10:26:52AM +0200, Jarek Poplawski wrote: ... PS: there is probably some mess with gmail addresses in this thread. ...or maybe it's OK... Sorry. Jarek P. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: Tc bug (kernel crash) more info

2007-08-30 Thread Badalian Vyacheslav
Jarek Poplawski пишет: On Thu, Aug 30, 2007 at 08:31:10AM +0200, Jarek Poplawski wrote: On Thu, Aug 30, 2007 at 12:16:32AM +0400, [EMAIL PROTECTED] wrote: ... PS. And also have we have strange bug in another computer (2.6.22-r5). Have computer XEON_CPUx2 (4 CPU) after boot have

Re: malformed captured packets

2007-08-30 Thread James Chapman
Toralf Förster wrote: Am Mittwoch, 29. August 2007 schrieb James Chapman: Can you provide more information about the problem, please? Are you using a simple DSL modem with PPPoE, such that the ppp0 interface is that of the pppd started by a local PPPoE server? Is this a problem only with

bonding xmit overwrite skb-priority

2007-08-30 Thread Francesco Dolcini
Bonding code set skb-priority=1 before trasmitting frame to the slave device (bond_dev_queue_xmit() in bond_main.c). The only reason I can think of doing this is to be sure that control packet used by bonding specific implementation (802.3ad PDU for example) using priority TC_PRIO_CONTROL will

Re: pktgen terminating condition

2007-08-30 Thread jamal
On Wed, 2007-29-08 at 09:59 -0700, Mandeep Baines wrote: I'll work on a NAPI patch. It's a GoodThing - go for it. cheers, jamal - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: net-2.6.24 rebased

2007-08-30 Thread Johannes Berg
On Wed, 2007-08-29 at 23:19 -0700, Joe Perches wrote: CC drivers/net/wireless/rtl8187_dev.o drivers/net/wireless/rtl8187_dev.c: In function ‘rtl8187_probe’: drivers/net/wireless/rtl8187_dev.c:610: error: ‘IEEE80211_HW_DATA_NULLFUNC_ACK’ undeclared (first use in this function)

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-30 Thread Johannes Berg
On Wed, 2007-08-29 at 15:13 +0200, Xavier Bestel wrote: How about asking for changes to be dual-licenced too ? In theory, that could work, but in practice relying on functions that the Linux kernel offers in GPLv2-only headers etc. will make the result GPLv2 anyway, and disentangling it would

Re: oops with recent wireless-dev tree

2007-08-30 Thread Johannes Berg
Hi Jochen, [added CCs since it affects bridge code] If I read this correctly, the EIP in the last line corresponds to net/bridge/br_if.c, line 36: static int port_cost(struct net_device *dev) { if (dev-ethtool_ops-get_settings) {

Re: pktgen terminating condition

2007-08-30 Thread jamal
On Wed, 2007-29-08 at 18:32 +0200, Robert Olsson wrote: Yes it's synchronization issue... the test is over and we have sent all pkts to the device but pktgen cannot free the skb for it still has refcounts. Ok, right. I was confusing it with another issue where pktgen could send a lot

Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2)

2007-08-30 Thread OBATA Noboru
Hi Rick, From: Rick Jones [EMAIL PROTECTED] Subject: Re: [PATCH 2.6.22] TCP: Make TCP_RTO_MAX a variable (take 2) Date: Wed, 29 Aug 2007 09:16:43 -0700 OBATA Noboru wrote: What about another option to let TCP have a notification? Can it be a solution if it is standardized? It would at

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-30 Thread Christoph Hellwig
On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: It saves big chunks of code (not only initial register settings arrays) and we'll extend it's use more inside ath5k_hw.c Trust me this is a very useful step, eg. check out descriptor processing / setup or PHY functions

Re: Tc bug (kernel crash) more info

2007-08-30 Thread Jarek Poplawski
On Thu, Aug 30, 2007 at 01:09:11PM +0400, Badalian Vyacheslav wrote: Jarek Poplawski ??: ... On the other hand disabling local interrupts shouldn't be enough here, so it's really strange... Did you get this remotely? Are you sure LOC only? (Anyway this 2.6.23-rc4 should be

Re: ipv4_get_l4proto: Frag of proto 17

2007-08-30 Thread Meelis Roos
Yesterdays git snapsot on a normal home PC spams dmesg with the following line: ipv4_get_l4proto: Frag of proto 17 In what situation does this happen? It happens some times every hour on the average. Seems to be some UDP traffic. Firewall allows in any UDP that is ESTABLISHEFD,RELATED,

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-30 Thread David Newall
Is it actually necessary to change the license? With the dual-license, you can keep a single code-base for both BSD and Linux platforms, which seems terribly important to me. It'd be awful to lose that. It would be a maintenance nightmare for BSD. Is it even possible--in real life, I

Re: [PATCH 3/5] Net: ath5k, use int as retval

2007-08-30 Thread John W. Linville
On Tue, Aug 28, 2007 at 12:00:09PM -0400, Jiri Slaby wrote: ath5k, use int as retval Convert some functions to return int and proper negative return value on error as we are used to. Since I didn't apply 1/5, this one didn't apply either. It seems fine overall, so if you rediff I'll be

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-30 Thread John W. Linville
On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig [EMAIL PROTECTED]: Also this whole patch seems rather pointless. It saves only very little and turns the driver into a complete ifdef maze. Also most people will use 5212 code only, 5211 cards

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007-08-30 Thread John W. Linville
On Thu, Aug 30, 2007 at 04:50:01AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig [EMAIL PROTECTED]: ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by most drivers and ath5k_hw_inivals.o mights aswell be something like ath5k_init.o If you check out the code

Re: [PATCH 4/5] Net: ath5k, license is GPLv2

2007-08-30 Thread Jarek Poplawski
On 30-08-2007 13:59, Johannes Berg wrote: On Wed, 2007-08-29 at 15:13 +0200, Xavier Bestel wrote: How about asking for changes to be dual-licenced too ? In theory, that could work, but in practice relying on functions that the Linux kernel offers in GPLv2-only headers etc. will make the

Re: [Lksctp-developers] SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-08-30 Thread Vlad Yasevich
Wei Yongjun wrote: Vlad Yasevich wrote: Wei Yongjun wrote: Vlad Yasevich wrote: NACK Section 8.4: An SCTP packet is called an out of the blue (OOTB) packet if it is correctly formed (i.e., passed the receiver's CRC32c check; see Section 6.8), but the receiver is not able

Re: oops with recent wireless-dev tree

2007-08-30 Thread Johannes Berg
On Thu, 2007-08-30 at 07:49 -0700, Stephen Hemminger wrote: Devices aren't required to have ethtool_ops. The code there used to call ethtool directly, and it would handle the error cases. I'll rollup a fix this morning. Great, thanks. johannes signature.asc Description: This is a digitally

Re: oops with recent wireless-dev tree

2007-08-30 Thread Matthew Wilcox
On Thu, Aug 30, 2007 at 07:49:49AM -0700, Stephen Hemminger wrote: static int port_cost(struct net_device *dev) { if (dev-ethtool_ops-get_settings) { As far as I can figure out, dev-ethtool_ops is NULL and the crash happens

Re: oops with recent wireless-dev tree

2007-08-30 Thread Johannes Berg
On Thu, 2007-08-30 at 07:49 -0700, Stephen Hemminger wrote: Devices aren't required to have ethtool_ops. The code there used to call ethtool directly, and it would handle the error cases. I'll rollup a fix this morning. Great, thanks. Jochen had a patch:

[PATCH] bridge: fix OOPS when bridging device without ethtool

2007-08-30 Thread Stephen Hemminger
Bridge code calls ethtool to get speed. The conversion to using only ethtool_ops broke the case of devices without ethtool_ops. This is a new regression in 2.6.23. Rearranged the switch to a logical order, and use gcc initializer. Ps: speed should have been part of the network device structure

Re: oops with recent wireless-dev tree

2007-08-30 Thread Matthew Wilcox
On Thu, Aug 30, 2007 at 05:01:31PM +0200, Johannes Berg wrote: Jochen had a patch: http://marc.info/?l=linux-wirelessm=118842715026614w=2 That's exactly the right patch, please add Acked-by: Matthew Wilcox [EMAIL PROTECTED] I just checked over the commit that introduced the bug, and I didn't

Re: Bug? Realtek RTL-8169 Gigabit Ethernet and High Resolution Timers

2007-08-30 Thread Satyam Sharma
[ Adding relevant Cc:'s ] On Thu, 30 Aug 2007, n wrote: I found a bug when using the Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8169 Gigabit Ethernet (rev 10) ethernet card and kernel High Resolution Timers (menuconfig - Processor type and features - High Resolution Timer

Re: [PATCH] bridge: fix OOPS when bridging device without ethtool

2007-08-30 Thread Matthew Wilcox
On Thu, Aug 30, 2007 at 08:29:32AM -0700, Stephen Hemminger wrote: Bridge code calls ethtool to get speed. The conversion to using only ethtool_ops broke the case of devices without ethtool_ops. This is a new regression in 2.6.23. Rearranged the switch to a logical order, and use gcc

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable

2007-08-30 Thread Rick Jones
Krishna Kumar2 wrote: Hi Rick, From: Rick Jones [EMAIL PROTECTED] The trace I've been sent shows clean RTTs ranging from ~200 milliseconds to ~7000 milliseconds. Thanks for the info. It's pretty easy to generate examples where we might have some sockets talking over interfaces on

Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver

2007-08-30 Thread Daniel Drake
Jesper Juhl wrote: Since kmalloc() returns a void pointer there is no reason to cast its return value. This patch also removes a pointless initialization of a variable. NAK: adds a sparse warning zd_chip.c:116:15: warning: implicit cast to nocast type Signed-off-by: Jesper Juhl [EMAIL

[PATCH] e1000: Add device IDs of blade version of the 82571 quad port

2007-08-30 Thread Auke Kok
This blade-specific board form factor is identical to the 82571EB board. Signed-off-by: Auke Kok [EMAIL PROTECTED] --- drivers/net/e1000/e1000_ethtool.c |1 + drivers/net/e1000/e1000_hw.c |1 + drivers/net/e1000/e1000_hw.h |1 + drivers/net/e1000/e1000_main.c|2 ++

[PATCH] bridge: packets leaking out of disabled/blocked ports

2007-08-30 Thread Stephen Hemminger
This patch fixes some packet leakage in bridge. The bridging code was allowing forward table entries to be generated even if a device was being blocked. The fix is to not add forwarding database entries unless the port is active. The bug arose as part of the conversion to processing STP frames

Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver

2007-08-30 Thread Jesper Juhl
On 30/08/2007, Daniel Drake [EMAIL PROTECTED] wrote: Jesper Juhl wrote: Since kmalloc() returns a void pointer there is no reason to cast its return value. This patch also removes a pointless initialization of a variable. NAK: adds a sparse warning zd_chip.c:116:15: warning: implicit

Re: [PATCH 0/0] sky2: update for 2.6.24

2007-08-30 Thread Stephen Hemminger
Patch number 10 doesn't work right, it causes excess interrupts and console messages. 8 9 are only needed for #10, so skip them as well. So please only apply 1-7 to netdev for 2.6.24 -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH] bridge: packets leaking out of disabled/blocked ports

2007-08-30 Thread John W. Linville
On Thu, Aug 30, 2007 at 12:22:58PM -0700, Stephen Hemminger wrote: This patch fixes some packet leakage in bridge. The bridging code was allowing forward table entries to be generated even if a device was being blocked. The fix is to not add forwarding database entries unless the port is

[GIT PULL] SCTP updates

2007-08-30 Thread Vlad Yasevich
Hi David Please pull the following changes since commit b07d68b5ca4d55a16fab223d63d5fb36f89ff42f: Linus Torvalds (1): Linux 2.6.23-rc4 that are available in the git repository at: master.kernel.org:/pub/scm/linux/kernel/git/vxy/lksctp-dev.git master Vlad Yasevich (7): SCTP:

[PATCH] bonding: update some distro-specific documentation

2007-08-30 Thread Andy Gospodarek
These are some changes that update some of the distro-specific details in for configuring bonding. Signed-off-by: Andy Gospodarek [EMAIL PROTECTED] --- bonding.txt | 45 ++--- 1 files changed, 26 insertions(+), 19 deletions(-) diff --git

Re: [PATCH 1/3] netxen: Avoid firmware load in PCI probe

2007-08-30 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 28, 2007 at 05:23:25PM +0530, [EMAIL PROTECTED] escreveu: Loading firmware during PCI probe can lead to incorrect initialization, rendering the card unusable until next reboot. This was introduced a while ago as a workaround for firmware bug, a better workaround was submitted for

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-30 Thread Nick Kossifidis
2007/8/30, John W. Linville [EMAIL PROTECTED]: On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig [EMAIL PROTECTED]: Also this whole patch seems rather pointless. It saves only very little and turns the driver into a complete ifdef maze.

Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver

2007-08-30 Thread Joe Perches
On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote: Ok, I must admit I didn't check with sparse since it seemed pointless - we usually never cast void pointers to other pointer types, specifically because the C language nicely guarantees that the right thing will happen without the cast.

[PATCH] Don't needlessly initialize variable to NULL in zd_chip (was: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver)

2007-08-30 Thread Jesper Juhl
On Friday 31 August 2007 00:19:53 Joe Perches wrote: On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote: Ok, I must admit I didn't check with sparse since it seemed pointless - we usually never cast void pointers to other pointer types, specifically because the C language nicely

Re: [PATCH] Don't needlessly initialize variable to NULL in zd_chip (was: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver)

2007-08-30 Thread Jesper Juhl
On 31/08/2007, Randy Dunlap [EMAIL PROTECTED] wrote: ... BTW: http://marc.info/?l=linux-wirelessm=118831813500769w=2 ... Heh, thanks Randy. All too often patches get missed since I don't happen to include the right magic person to Cc. So I generally take a better to have one Cc too many than

Re: [1/1] Block device throttling [Re: Distributed storage.]

2007-08-30 Thread Daniel Phillips
On Wednesday 29 August 2007 01:53, Evgeniy Polyakov wrote: Then, if of course you will want, which I doubt, you can reread previous mails and find that it was pointed to that race and possibilities to solve it way too long ago. What still bothers me about your response is that, while you know

Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver

2007-08-30 Thread Daniel Drake
Jesper Juhl wrote: What would be wrong in applying my patch that removes the cast of the kmalloc() return value and then also remove the __nocast here? We use it as a safety measure when coding. For example the write register function takes an address and a value. We got one of these the

[PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-30 Thread Rick Jones
Enable configuration of the minimum TCP Retransmission Timeout via a new sysctl tcp_rto_min to help those who's networks (eg cellular) have quite variable RTTs avoid spurrious RTOs. Signed-off-by: Rick Jones [EMAIL PROTECTED] Signed-off-by: Lamont Jones [EMAIL PROTECTED] --- diff -r 06d7322848a3

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-30 Thread David Miller
From: Rick Jones [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 17:09:04 -0700 (PDT) Enable configuration of the minimum TCP Retransmission Timeout via a new sysctl tcp_rto_min to help those who's networks (eg cellular) have quite variable RTTs avoid spurrious RTOs. Signed-off-by: Rick Jones

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-30 Thread Rick Jones
David Miller wrote: From: Rick Jones [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 17:09:04 -0700 (PDT) Enable configuration of the minimum TCP Retransmission Timeout via a new sysctl tcp_rto_min to help those who's networks (eg cellular) have quite variable RTTs avoid spurrious RTOs.

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-08-30 Thread Andrew Morton
On Thu, 30 Aug 2007 07:41:31 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8961 This looks serious. Summary: BUG triggered by oidentd in netlink code Product: Other Version: 2.5 KernelVersion: 2.6.22.3

wither bounds checking for networking sysctls

2007-08-30 Thread Rick Jones
While messing about with sysctl_tcp_rto_min I went back and forth a bit as to whether there should have been bounds checking (as did some of the folks who did some internal review for me). That leads to the question - is it considered worthwhile to add a bit more bounds checking to sundry

Re: [Lksctp-developers] SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-08-30 Thread Wei Yongjun
Vlad Yasevich wrote: Wei Yongjun wrote: Vlad Yasevich wrote: Wei Yongjun wrote: Vlad Yasevich wrote: NACK Section 8.4: An SCTP packet is called an out of the blue (OOTB) packet if it is correctly formed (i.e., passed the receiver's CRC32c check; see

Re: wither bounds checking for networking sysctls

2007-08-30 Thread Stephen Hemminger
On Thu, 30 Aug 2007 18:09:17 -0700 Rick Jones [EMAIL PROTECTED] wrote: While messing about with sysctl_tcp_rto_min I went back and forth a bit as to whether there should have been bounds checking (as did some of the folks who did some internal review for me). That leads to the question -

Re: [PATCH RFC] iw_cxgb3: Support iwarp-only interfaces to avoid 4-tuple conflicts with the host stack.

2007-08-30 Thread Roland Dreier
The sysadmin creates for iwarp use only alias interfaces of the form devname:iw* where devname is the native interface name (eg eth0) for the iwarp netdev device. The alias label can be anything starting with iw. The iw immediately after the ':' is the key used by the iwarp driver.

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-30 Thread John Heffner
Rick Jones wrote: Like I said the consumers of this are a triffle well, anxious :) Just curious, did you or this customer try with F-RTO enabled? Or is this case you're dealing with truly hopeless? -John - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-30 Thread David Miller
From: Rick Jones [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 18:07:13 -0700 Anyhow, I'll try grubbing around the source code (already doing that to see about writing a pet tcp cong module) but if pointers to the likely relevant files were available I could try to help thrash-out the routing

Re: [GIT PULL] SCTP updates

2007-08-30 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 17:26:30 -0400 that are available in the git repository at: master.kernel.org:/pub/scm/linux/kernel/git/vxy/lksctp-dev.git master Pulled, thanks a lot Vlad. - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [PATCH] bridge: packets leaking out of disabled/blocked ports

2007-08-30 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 16:03:13 -0400 On Thu, Aug 30, 2007 at 12:22:58PM -0700, Stephen Hemminger wrote: This patch fixes some packet leakage in bridge. The bridging code was allowing forward table entries to be generated even if a device was being

Re: [PATCH] bridge: fix OOPS when bridging device without ethtool

2007-08-30 Thread David Miller
From: Matthew Wilcox [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 10:48:13 -0600 On Thu, Aug 30, 2007 at 08:29:32AM -0700, Stephen Hemminger wrote: Bridge code calls ethtool to get speed. The conversion to using only ethtool_ops broke the case of devices without ethtool_ops. This is a new

Re: [Lksctp-developers] SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-08-30 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 09:45:22 -0400 But now we are doing the same thing twice (and this is not the only place). I know I am being really picky here, but I am starting to thing the ootb handling\ is a mess and I really don't want to add to the mess.

Re: pktgen terminating condition

2007-08-30 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 08:08:40 -0400 I was confusing it with another issue where pktgen could send a lot of packets without waiting for them to be freed; there are some drivers (10G) which may hold onto 8K skbs. A gazillion ooms start spewing ;- My thinking in

Re: net-2.6.24 rebased

2007-08-30 Thread David Miller
From: Johannes Berg [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 13:58:12 +0200 Huh? I'm fairly sure I sent a patch to remove it from that driver, no idea where it got lost. FWIW, you can simply delete the | IEEE80211_HW_DATA_NULLFUNC_ACK part. It might have been a mis-merge between John and

Re: [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of tc_classify()

2007-08-30 Thread David Miller
From: Lucas Nussbaum [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 09:28:17 +0200 Hi, When CONFIG_NET_CLS_ACT is enabled, tc_classify() is called twice in prio_classify(). This causes interesting behaviour: with the setup below, packets are duplicated, sent twice to ifb0, and then loop in and

some weird corruption in net-2.6.24

2007-08-30 Thread David Miller
Every so often some piece of userland dies, and often it's bad enough that my desktop session logs out. I've been trying to find some clues and it seems to happen about as often as openswan rekeys my VPN, so one suspect area is the netlink cleanups to xfrm_user. I plan to do some auditing of

Re: [patch 0/1][RFC] add a private field to the sock structure

2007-08-30 Thread David Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Wed, 29 Aug 2007 16:18:31 -0300 Nah, it still there, sk_protinfo, its just ax25 that uses it (nudge(Ralf)). How do we state that a struct field is deprecated and will be removed soon(tm)? You get rid of all the in-tree users and then just

Re: [PATCH] Remove write-only variable from pktgen_thread

2007-08-30 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 29 Aug 2007 14:33:56 -0700 Pavel Emelianov [EMAIL PROTECTED] wrote: | The pktgen_thread.pid is set to current-pid and is never used | after this. So remove this at all. | | Found during isolating the explicit pid/tgid usage. | | Signed-off-by: Pavel