Re: malformed captured packets

2007-08-31 Thread Toralf Förster
@wireshark-devs: The topic is related to http://www.wireshark.org/lists/wireshark-users/200707/msg00187.html and http://bugzilla.kernel.org/show_bug.cgi?id=8793 @all: Hi, Am Donnerstag, 30. August 2007 schrieb James Chapman: Toralf Förster wrote: Am Mittwoch, 29. August 2007 schrieb James

tcp user timeout option

2007-08-31 Thread Joakim Koskela
Hi, Does anybody know of any effort put into implementing support for the TCP user timeout option in Linux? The related draft: http://www.ietf.org/internet-drafts/draft-ietf-tcpm-tcp-uto-06.txt Basically its a per-connection parameter which says how long data can remain unacknowledged before

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Jarek Poplawski
On Fri, Aug 31, 2007 at 12:25:22PM +0400, Badalian Vyacheslav wrote: i not have testing mashine. we have 2 mashine and dynamic routing. if 1 mashine down - all traffic go to second mashine. I can test is on this mashines but i need that testing mashine will reboot on kernel panic (sysctl

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Jarek Poplawski
On Fri, Aug 31, 2007 at 12:25:22PM +0400, Badalian Vyacheslav wrote: i not have testing mashine. we have 2 mashine and dynamic routing. if 1 mashine down - all traffic go to second mashine. I can test is on this mashines but i need that testing mashine will reboot on kernel panic (sysctl

[0/7] [PPP]: Fix shared/cloned/non-linear skb bugs (was: malformed captured packets)

2007-08-31 Thread Herbert Xu
On Thu, Aug 30, 2007 at 09:51:31AM +, James Chapman wrote: The captured PPPoE stream seems to show incorrect data lengths in the PPPoE header for some captured PPPoE packets. The kernel's PPPoE datapath uses this length to extract the PPP frame and send it through to the ppp interface.

[PATCH 2/7] [PPP] pppoe: Fix data clobbering in __pppoe_xmit and return value

2007-08-31 Thread Herbert Xu
[PPP] pppoe: Fix data clobbering in __pppoe_xmit and return value The function __pppoe_xmit modifies the skb data and therefore it needs to copy and skb data if it's cloned. In fact, it currently allocates a new skb so that it can return 0 in case of error without freeing the original skb. This

[PATCH 3/7] [PPP] pppoe: Fill in header directly in __pppoe_xmit

2007-08-31 Thread Herbert Xu
[PPP] pppoe: Fill in header directly in __pppoe_xmit This patch removes the hdr variable (which is copied into the skb) and instead sets the header directly in the skb. It also uses __skb_push instead of skb_push since we've just checked using skb_cow for enough head room. Signed-off-by:

Re: [ANNOUNCE] iproute2-2.6.23-rc3

2007-08-31 Thread Patrick McHardy
On Wed, 22 Aug 2007, Stephen Hemminger wrote: There have been a lot of changes for 2.6.23, so here is a test release of iproute2 that should capture all the submitted patches Patrick McHardy (6): TC action parsing bug fix Bug fix tc action drop IPROUTE2: RTNETLINK nested

[PATCH 4/7] [BRIDGE]: Kill clone argument to br_flood_*

2007-08-31 Thread Herbert Xu
[BRIDGE]: Kill clone argument to br_flood_* The clone argument is only used by one caller and that caller can clone the packet itself. This patch moves the clone call into the caller and kills the clone argument. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- net/bridge/br_device.c |4

[PATCH 1/7] [PPP] pppoe: Fix skb_unshare_check call position

2007-08-31 Thread Herbert Xu
[PPP] pppoe: Fix skb_unshare_check call position The skb_unshare_check call needs to be made before pskb_may_pull, not after. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- drivers/net/pppoe.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/pppoe.c

[PATCH 7/7] [PPP] generic: Fix receive path data clobbering non-linear handling

2007-08-31 Thread Herbert Xu
[PPP] generic: Fix receive path data clobbering non-linear handling This patch adds missing pskb_may_pull calls to deal with non-linear packets that may arrive from pppoe or pppol2tp. It also copies cloned packets before writing over them. Signed-off-by: Herbert Xu [EMAIL PROTECTED] ---

[PATCH 6/7] [PPP] generic: Call skb_cow_head before scribbling over skb

2007-08-31 Thread Herbert Xu
[PPP] generic: Call skb_cow_head before scribbling over skb It's rude to write over data that other people are still using. So call skb_cow_head before PPP proceeds to modify the skb data. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- drivers/net/ppp_generic.c | 14 +++--- 1 files

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Jarek Poplawski
On Fri, Aug 31, 2007 at 11:05:09AM +0200, Jarek Poplawski wrote: ... So, maybe you would better try this, 'less testing', version of my patch: Of course, the previous patch should be reverted (patch -p1 -R) or clean 2.6.22.5 used for this. Jarek P. - To unsubscribe from this list: send the

Re: [ANNOUNCE] iproute2-2.6.23-rc3

2007-08-31 Thread Patrick McHardy
On Wed, 22 Aug 2007, Stephen Hemminger wrote: There have been a lot of changes for 2.6.23, so here is a test release of iproute2 that should capture all the submitted patches Pavel Emelianov (1): Make ip utility veth driver aware Why does this add a new ip subcommand instead and uses

Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver

2007-08-31 Thread Herbert Xu
Jesper Juhl [EMAIL PROTECTED] wrote: On 30/08/2007, Daniel Drake [EMAIL PROTECTED] wrote: Jesper Juhl wrote: Since kmalloc() returns a void pointer there is no reason to cast its return value. This patch also removes a pointless initialization of a variable. NAK: adds a sparse warning

Re: [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of tc_classify()

2007-08-31 Thread Patrick McHardy
On Thu, 30 Aug 2007, Lucas Nussbaum wrote: When CONFIG_NET_CLS_ACT is enabled, tc_classify() is called twice in prio_classify(). This causes interesting behaviour: with the setup below, packets are duplicated, sent twice to ifb0, and then loop in and out of ifb0. The patch uses the previously

Re: [ANNOUNCE] iproute2-2.6.23-rc3

2007-08-31 Thread Pavel Emelyanov
Patrick McHardy wrote: On Wed, 22 Aug 2007, Stephen Hemminger wrote: There have been a lot of changes for 2.6.23, so here is a test release of iproute2 that should capture all the submitted patches Pavel Emelianov (1): Make ip utility veth driver aware Why does this add a new ip

Re: [ANNOUNCE] iproute2-2.6.23-rc3

2007-08-31 Thread Patrick McHardy
On Fri, 31 Aug 2007, Pavel Emelyanov wrote: Patrick McHardy wrote: On Wed, 22 Aug 2007, Stephen Hemminger wrote: There have been a lot of changes for 2.6.23, so here is a test release of iproute2 that should capture all the submitted patches Pavel Emelianov (1): Make ip utility veth

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Badalian Vyacheslav
i not have testing mashine. we have 2 mashine and dynamic routing. if 1 mashine down - all traffic go to second mashine. I can test is on this mashines but i need that testing mashine will reboot on kernel panic (sysctl message). No freezes =) Ok. i try 2.6.23-rc4. ...but without

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Jarek Poplawski
On Fri, Aug 31, 2007 at 01:33:04PM +0400, Badalian Vyacheslav wrote: i not have testing mashine. we have 2 mashine and dynamic routing. if 1 mashine down - all traffic go to second mashine. I can test is on this mashines but i need that testing mashine will reboot on kernel panic (sysctl

Re: [Lksctp-developers] SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-08-31 Thread Wei Yongjun
Vlad Yasevich wrote: Wei Yongjun wrote: Vlad Yasevich wrote: Wei Yongjun wrote: Vlad Yasevich wrote: NACK Section 8.4: An SCTP packet is called an out of the blue (OOTB) packet if it is correctly formed (i.e., passed the receiver's CRC32c check; see

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Badalian Vyacheslav
I get kernel panic on 2.6.23-rc4-git2 This is netconsole log! [ 3931.002707] BUG: unable to handle kernel NULL pointer dereference at virtual address 0008 [ 3931.002846] printing eip: [ 3931.002906] c01c8973 [ 3931.002967] *pde = [ 3931.003031] Oops: [#1] [ 3931.003093] SMP

Re: [PATCH 3/3] netxen: ethtool fixes

2007-08-31 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: +static int netxen_nic_set_rx_csum(struct net_device *dev, u32 data) +{ + struct netxen_adapter *adapter = netdev_priv(dev); + adapter-rx_csum = 0; + return 0; +} Bug: 'data' ignored - To unsubscribe from this list: send the line unsubscribe netdev

Re: [patch 1/7] s390: ungrouping a device must not be interruptible

2007-08-31 Thread Jeff Garzik
Applied patches 1-7, after changing the prefix back to qeth: s390: prefix should be applied to changes that affect S/390 architecture platform in general. This was a patchset specific to a single driver, thus the qeth: prefix is more informative when looking at a long list of one-line

Re: [PATCH 1/2] PS3: improve tx throughput for gelic driver

2007-08-31 Thread Jeff Garzik
Masakazu Mokuno wrote: Improve tx throughputs. netperf score gained approximately 20% This is a useless patch description. It does not adequately summarize the changes contained within the patch. Please resubmit patch with a useful patch description - To unsubscribe from this

Re: [PATCH 1/3] netxen: Avoid firmware load in PCI probe

2007-08-31 Thread Jeff Garzik
applied patches 1-2 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Badalian Vyacheslav
But sometime a new kernel can break binary compatibility with previous one (e.g. after data structures change) and e.g. iptables or iproute tools stop working or work in an unpredictable way. There were a few such changes before 2.6.20 - I don't track current changes too much. And I'm sure your

Re: [PATCH] spidernet: fix interrupt reason recognition

2007-08-31 Thread Jeff Garzik
Ishizaki Kou wrote: This patch solves a problem that the spidernet driver sometimes fails to handle IRQ. The problem happens because, - In Cell architecture, interrupts may arrive at an interrupt controller, even if they are masked by the setting on registers of devices. It happens when

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Badalian Vyacheslav
May be this bug eq [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of tc_classify()? I get kernel panic on 2.6.23-rc4-git2 This is netconsole log! ... - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 0/1][RFC] add a private field to the sock structure

2007-08-31 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 30, 2007 at 10:40:49PM -0700, David Miller escreveu: From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Wed, 29 Aug 2007 16:18:31 -0300 Nah, it still there, sk_protinfo, its just ax25 that uses it (nudge(Ralf)). How do we state that a struct field is deprecated and will

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Jarek Poplawski
On Fri, Aug 31, 2007 at 02:59:55PM +0400, Badalian Vyacheslav wrote: May be this bug eq [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of tc_classify()? I get kernel panic on 2.6.23-rc4-git2 This is netconsole log! ... So, it looks like you have found a really new (unknown) HTB

Re: [PATCH 2.6.23 1/2] cxgb3 - Fix dev-priv usage

2007-08-31 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] cxgb3 used netdev_priv() and dev-priv for different purposes. In 2.6.23, netdev_priv() == dev-priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Without this fix, cxgb3

Re: [ANNOUNCE] iproute2-2.6.23-rc3

2007-08-31 Thread Pavel Emelyanov
Patrick McHardy wrote: On Fri, 31 Aug 2007, Pavel Emelyanov wrote: Patrick McHardy wrote: On Wed, 22 Aug 2007, Stephen Hemminger wrote: There have been a lot of changes for 2.6.23, so here is a test release of iproute2 that should capture all the submitted patches Pavel Emelianov (1):

Re: [PATCH 1/2] PS3: improve tx throughput for gelic driver

2007-08-31 Thread Masakazu Mokuno
On Fri, 31 Aug 2007 06:57:03 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Masakazu Mokuno wrote: Improve tx throughputs. netperf score gained approximately 20% This is a useless patch description. It does not adequately summarize the changes contained within the patch.

[NETLINK]: Avoid pointer in netlink_run_queue

2007-08-31 Thread Herbert Xu
Hi Dave: [NETLINK]: Avoid pointer in netlink_run_queue I was looking at Patrick's fix to inet_diag and it occured to me that we're using a pointer argument to return values unnecessarily in netlink_run_queue. Changing it to return the value will allow the compiler to generate better code since

Re: [PATCH 3/3] netxen: ethtool fixes

2007-08-31 Thread Dhananjay Phadke
oops, ok regenerating patch 3 only. On Fri, 31 Aug 2007, Jeff Garzik wrote: [EMAIL PROTECTED] wrote: +static int netxen_nic_set_rx_csum(struct net_device *dev, u32 data) +{ + struct netxen_adapter *adapter = netdev_priv(dev); + adapter-rx_csum = 0; + return 0; +} Bug:

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Badalian Vyacheslav
Jarek Poplawski пишет: On Fri, Aug 31, 2007 at 02:59:55PM +0400, Badalian Vyacheslav wrote: May be this bug eq [PATCH] [NET_SCHED] sch_prio.c: remove duplicate call of tc_classify()? I get kernel panic on 2.6.23-rc4-git2 This is netconsole log! ... So, it looks like

[PATCH] Fix a lock problem in generic phy code

2007-08-31 Thread Hans-Jürgen Koch
Lock debugging finds a problem in phy.c and phy_device.c, this patch fixes it. Tested on an AT91SAM9263-EK board, kernel 2.6.23-rc4. Signed-off-by: Hans J. Koch [EMAIL PROTECTED] --- Index: linux-2.6.23-rc/drivers/net/phy/phy_device.c

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-31 Thread Dan Williams
On Thu, 2007-08-30 at 08:36 -0400, John W. Linville wrote: On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig [EMAIL PROTECTED]: Also this whole patch seems rather pointless. It saves only very little and turns the driver into a complete ifdef

[PATCH 2/2]: [NET_SCHED]: Making rate table lookups more flexible.

2007-08-31 Thread Jesper Dangaard Brouer
commit ac093f5c2f1160ece72a6fef5c779c1892fc3152 Author: Jesper Dangaard Brouer [EMAIL PROTECTED] Date: Fri Aug 31 11:53:35 2007 +0200 [NET_SCHED]: Making rate table lookups more flexible. Extend the tc_ratespec struct, with two parameters: 1) cell_align that allow adjusting the

[PATCH 1/2]: [NET_SCHED]: Make all rate based scheduler work with TSO.

2007-08-31 Thread Jesper Dangaard Brouer
commit 6fdc0f061be94f5e297650961360fb7a9d1cc85d Author: Jesper Dangaard Brouer [EMAIL PROTECTED] Date: Thu Aug 30 17:53:42 2007 +0200 [NET_SCHED]: Make all rate based scheduler work with TSO. Change L2T (length to time) macros, in all rate based schedulers, to call a common

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Jarek Poplawski
On Fri, Aug 31, 2007 at 02:48:31PM +0400, Badalian Vyacheslav wrote: ... I can only see that say netconsole. If i look to monitor i look last lines. last line is Scrolling not work netconsole run as module and start after system do full load. Then netconsole is up - i run generator

Re: [PATCH 2.6.24 1/5]S2io: Enable all the error and alarm indications

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Added support to unmask entire set of device errors and alarms. Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED] Signed-off-by: Santosh Rastapur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -Nurp orig/drivers/net/s2io.c

Re: [PATCH 2.6.24 3/5]S2io: Cleanup - removed unused variable, intr_type

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Removed the unused variable, intr_type, in device private structure. Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED] Signed-off-by: Santosh Rastapur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] ACK (but dropped, since previous patches were

Re: [PATCH 2.6.24 4/5]S2io: Check for CARD_DOWN before handling traffic

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Added check to return from the traffic handling function, if the card status is DOWN. Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED] Signed-off-by: Santosh Rastapur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -Nurp

Re: Re: pktgen terminating condition

2007-08-31 Thread Daniele Venzano
- Message d'origine - De: Mandeep Baines [EMAIL PROTECTED] Date: Wed, 29 Aug 2007 09:59:42 -0700 Sujet: Re: pktgen terminating condition Looks good to me given the desire. I would bounce it by whoever the maintainer is - they may have some insights on the lazy tx prune habit. + [EMAIL

Re: [patch]support for USB autosuspend in the asix driver

2007-08-31 Thread Jeff Garzik
Oliver Neukum wrote: Hi, this implements support for USB autosuspend in the asix USB ethernet driver. Regards Oliver Signed-off-by: Oliver Neukum [EMAIL PROTECTED] applied please put comments like Hi, and Regards Oliver below the --- terminator, otherwise they must

Re: [PATCH 2.6.24 5/5]S2io: Optimize isr fast path

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Optimized interrupt routine fast path. Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED] Signed-off-by: Santosh Rastapur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] patch description is completely inadequate. how was it optimized? what are

Re: [PATCH 2.6.24 1/2]S2io: Change kmalloc+memset to k[zc]alloc

2007-08-31 Thread Jeff Garzik
Ramkrishna Vepa wrote: - Changed kmalloc+memset to k[zc]alloc as per Mariusz's patch [EMAIL PROTECTED] Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] ACK patches 1-2, but dropped due to previous dropped patches (presumed dependencies)

Re: [REVISED PATCH] 3c59x: check return of pci_enable_device()

2007-08-31 Thread Jeff Garzik
Mark Hindley wrote: Revised patch for this. Mark commit 5cf33391eba81a49038fa8be8cbad8425b80bf7f Author: Mark Hindley [EMAIL PROTECTED] Date: Thu Aug 16 11:26:35 2007 +0100 Check return of pci_enable_device in vortex_up(). Also modify vortex_up to return error to callers.

Re: [git patches] net driver fixes

2007-08-31 Thread Jeff Garzik
Satyam Sharma wrote: On Mon, 30 Jul 2007, Jeff Garzik wrote: true, we should just remove the dev==NULL check Patch below: [PATCH] nmclan_cs: Remove bogus (dev==NULL) check in mace_interrupt() The (dev == NULL) check in drivers/net/pcmcia/nmclan_cs.c:mace_interrupt() handler is always

Re: [PATCH 3/6] ibmveth: Add ethtool TSO handlers

2007-08-31 Thread Jeff Garzik
Brian King wrote: Add handlers for get_tso and get_ufo to prevent errors being printed by ethtool. Signed-off-by: Brian King [EMAIL PROTECTED] --- linux-2.6-bjking1/drivers/net/ibmveth.c |2 ++ 1 file changed, 2 insertions(+) diff -puN drivers/net/ibmveth.c~ibmveth_ethtool_get_tso

[PATCH 0/2 v2] PS3: gelic updates

2007-08-31 Thread Masakazu Mokuno
Hi Jeff, The comments for the patch #1 was rewritten. I believe it's more descriptive than the older one. #1 Change the way to handle tx skbs (comments rewritten) #2 Remove work-around code no longer needed regards. -- Masakazu MOKUNO - To unsubscribe from this list: send the line

Re: [PATCH 2/7] fs_enet: Whitespace cleanup.

2007-08-31 Thread Jeff Garzik
Scott Wood wrote: Signed-off-by: Scott Wood [EMAIL PROTECTED] --- drivers/net/fs_enet/fs_enet-main.c | 85 --- drivers/net/fs_enet/fs_enet.h |4 +- drivers/net/fs_enet/mac-fcc.c |1 - drivers/net/fs_enet/mii-fec.c |1 - 4 files

[PATCH 1/2 v2] PS3: changed the way to handle tx skbs

2007-08-31 Thread Masakazu Mokuno
The PS3 virtual network device requires a vlan tag in the sending packet to select the destination device, ethernet port or wireless. As the vlan tag field is in the middle of the passed data, we should insert it into the packet data. To avoid copying much of the packet data, the driver used two

Re: [PATCH 1/7] Generic bitbanged MDIO library

2007-08-31 Thread Jeff Garzik
Scott Wood wrote: Previously, bitbanged MDIO was only supported in individual hardware-specific drivers. This code factors out the higher level protocol implementation, reducing the hardware-specific portion to functions setting direction, data, and clock. Signed-off-by: Scott Wood [EMAIL

Re: [REVISED PATCH] 3c59x: check return of pci_enable_device()

2007-08-31 Thread Steffen Klassert
On Fri, Aug 31, 2007 at 09:08:37AM -0400, Jeff Garzik wrote: Mark Hindley wrote: Revised patch for this. Mark commit 5cf33391eba81a49038fa8be8cbad8425b80bf7f Author: Mark Hindley [EMAIL PROTECTED] Date: Thu Aug 16 11:26:35 2007 +0100 Check return of pci_enable_device in

Re: [PATCH 2.6.24 2/3]S2io: Support for add/delete/store/restore ethernet addresses

2007-08-31 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Support to add/delete/store/restore 64 and 128 Ethernet addresses for Xframe I and Xframe II respectively. Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] What is the purpose of this? We do not support more than

Re: [PATCH 2.6.24 3/3]S2io: Updating transceiver information in ethtool function

2007-08-31 Thread Jeff Garzik
Sreenivasa Honnur wrote: - Update transceiver information in ethtool function Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -urpN patch2/drivers/net/s2io.c patch3/drivers/net/s2io.c --- patch2/drivers/net/s2io.c 2007-08-18

[PATCH 2/2 v2] PS3: Remove the workaround no longer needed

2007-08-31 Thread Masakazu Mokuno
Removed the workaround that was needed for PS3 firmware versions prior to the first release. Signed-off-by: Masakazu Mokuno [EMAIL PROTECTED] CC: Geoff Levand [EMAIL PROTECTED] --- drivers/net/ps3_gelic_net.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) ---

Re: [REVISED PATCH] 3c59x: check return of pci_enable_device()

2007-08-31 Thread Jeff Garzik
Mark Hindley wrote: Revised patch for this. Mark commit 5cf33391eba81a49038fa8be8cbad8425b80bf7f Author: Mark Hindley [EMAIL PROTECTED] Date: Thu Aug 16 11:26:35 2007 +0100 Check return of pci_enable_device in vortex_up(). Also modify vortex_up to return error to callers.

Re: [Bugme-new] [Bug 8961] New: BUG triggered by oidentd in netlink code

2007-08-31 Thread Athanasius
On Fri, Aug 31, 2007 at 01:05:04PM +0200, Patrick McHardy wrote: Seems to be a bug introduced by the netlink_run_queue conversion, since there is no locking and netlink_run_queue doesn't check for NULL results from skb_dequeue, it might pass NULL to netlink_rcv_skb, which crashes. Does this

Re: [REVISED PATCH] 3c59x: check return of pci_enable_device()

2007-08-31 Thread Jeff Garzik
Steffen Klassert wrote: commit 5cf33391eba81a49038fa8be8cbad8425b80bf7f Author: Mark Hindley [EMAIL PROTECTED] Date: Thu Aug 16 11:26:35 2007 +0100 Check return of pci_enable_device in vortex_up(). Also modify vortex_up to return error to callers. Handle failure of vortex_up in

Re: [PATCH 8/11] cxgb3 - Update internal memory management

2007-08-31 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] Set PM1 internal memory to round robin mode It balances access to this internal memory for multiport adapters. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/regs.h |2 ++ drivers/net/cxgb3/t3_hw.c |2 ++ 2

Re: [PATCH 8/11] cxgb3 - Update internal memory management

2007-08-31 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] Set PM1 internal memory to round robin mode It balances access to this internal memory for multiport adapters. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/regs.h |2 ++ drivers/net/cxgb3/t3_hw.c |2 ++ 2

Re: [PATCH 9/11] cxgb3 - engine microcode update

2007-08-31 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray [EMAIL PROTECTED] Load microcode engine when the interface is configured up. Bump up version to 1.1.0. Allow the driver to be and running with older microcode images. Allow ethtool to log the microcode version. Signed-off-by: Divy Le Ray [EMAIL PROTECTED]

Re: [PATCH 07/12] sky2: use net_device internal stats

2007-08-31 Thread Jeff Garzik
NAK -- grep around net/core, you want -get_stats() - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/12] sky2: fe+ chip support

2007-08-31 Thread Jeff Garzik
applied 1-6 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Please pull 'upstream-jgarzik' branch of wireless-2.6

2007-08-31 Thread Jeff Garzik
John W. Linville wrote: Jeff, A few more for 2.6.24 -- mostly libertas. Individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-jgarzik/ Thanks! John --- The following changes since commit

Re: pktgen terminating condition

2007-08-31 Thread jamal
On Thu, 2007-30-08 at 22:19 -0700, David Miller wrote: You could implement this quite simply using skb-destructor. Thats what i was thinking .. It will add some atomics, so on weaker pktgen source systems it might decrease the generators rate. Indeed. So maybe a config option instead; it

Re: [PATCH] bmac: add simple ethtool support for network manager

2007-08-31 Thread Jeff Garzik
Olaf Hering wrote: NetworkManager will not start dhcpd on an interface unless it reports link-up state via ethtool. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- drivers/net/bmac.c | 13 + 1 file changed, 13 insertions(+) applied - To unsubscribe from this list: send the

Re: Re: pktgen terminating condition

2007-08-31 Thread jamal
On Fri, 2007-31-08 at 14:17 +0200, Daniele Venzano wrote: I don't regard the TxOK solution as something usable for mainline, but it has its use for the users of pktgen. I dont know if you followed the discussion - by defering the freeing of skbs, you will be slowing down socket apps sending

Re: [PATCH] [01/10] pasemi_mac: Abstract out register access

2007-08-31 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] [02/10] pasemi_mac: Stop using the pci config space accessors for register read/writes

2007-08-31 Thread Jeff Garzik
Olof Johansson wrote: Move away from using the pci config access functions for simple register access. Our device has all of the registers in the config space (hey, from the hardware point of view it looks reasonable :-), so we need to somehow get to it. Newer firmwares have it in the device

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-31 Thread Jeff Garzik
Dan Williams wrote: On Thu, 2007-08-30 at 08:36 -0400, John W. Linville wrote: On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig [EMAIL PROTECTED]: Also this whole patch seems rather pointless. It saves only very little and turns the driver into a

Re: [PATCH 1/6] ibmveth: Enable TCP checksum offload

2007-08-31 Thread Jeff Garzik
Brian King wrote: This patchset enables TCP checksum offload support for IPV4 on ibmveth. This completely eliminates the generation and checking of the checksum for packets that are completely virtual and never touch a physical network. A simple TCP_STREAM netperf run on a virtual network with

Re: [PATCH 1/2 v2] PS3: changed the way to handle tx skbs

2007-08-31 Thread Jeff Garzik
Masakazu Mokuno wrote: The PS3 virtual network device requires a vlan tag in the sending packet to select the destination device, ethernet port or wireless. As the vlan tag field is in the middle of the passed data, we should insert it into the packet data. To avoid copying much of the packet

Re: [PATCH 07/12] sky2: use net_device internal stats

2007-08-31 Thread Stephen Hemminger
On Fri, 31 Aug 2007 09:43:37 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: NAK -- grep around net/core, you want -get_stats() Unneeded if device leaves get_stats as NULL, then register_netdevice sets it to internal get stats (in net-2.6.24) - To unsubscribe from this list: send the line

Re: net-2.6.24 rebased

2007-08-31 Thread John W. Linville
On Thu, Aug 30, 2007 at 10:21:29PM -0700, David Miller wrote: From: Johannes Berg [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 13:58:12 +0200 Huh? I'm fairly sure I sent a patch to remove it from that driver, no idea where it got lost. FWIW, you can simply delete the |

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Badalian Vyacheslav
I found that bug in this place (gdb) l *0xc01c8973 0xc01c8973 is in rb_insert_color (lib/rbtree.c:80). 75 76 while ((parent = rb_parent(node)) rb_is_red(parent)) 77 { 78 gparent = rb_parent(parent); 79 80 if (parent ==

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-31 Thread Dan Williams
On Fri, 2007-08-31 at 09:30 -0400, Jeff Garzik wrote: Dan Williams wrote: On Thu, 2007-08-30 at 08:36 -0400, John W. Linville wrote: On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig [EMAIL PROTECTED]: Also this whole patch seems rather

Re: Tc bug (kernel crash) more info

2007-08-31 Thread Badalian Vyacheslav
Ok =) I hope in next week you found bug place and fix it! PS. if you ask where i can read kernel panic dump logic literature and try find bugline in code. I read dump and see that bug in function rb_insert_color + some shift (in asm?) that called from htb_dequeue? But in htb_dequeue not have

Re: [PATCH 1/7] Generic bitbanged MDIO library

2007-08-31 Thread Scott Wood
On Fri, Aug 31, 2007 at 09:23:04AM -0400, Jeff Garzik wrote: I cannot ACK this, nor do I want to see it merged, until users appear and have been reviewed alongside this. I do not see any fs_enet patches that actually use this. The fs_enet patchset does use it in mii-bitbang.c, in patch 6/7

[PATCH] ucc_geth: suppress 'qe_bd_t' undeclared error

2007-08-31 Thread Kim Phillips
drivers/net/ucc_geth.c:2151: error: ‘qe_bd_t’ undeclared (first use in this function) Signed-off-by: Kim Phillips [EMAIL PROTECTED] --- Leo, this is for 2.6.23. drivers/net/ucc_geth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ucc_geth.c

Re: [PATCH] Fix a lock problem in generic phy code

2007-08-31 Thread Hans-Jürgen Koch
Am Freitag 31 August 2007 schrieb Hans-Jürgen Koch: Lock debugging finds a problem in phy.c and phy_device.c, this patch fixes it. Tested on an AT91SAM9263-EK board, kernel 2.6.23-rc4. FYI, here's the log message without that patch: [3.42] = [

Re: wither bounds checking for networking sysctls

2007-08-31 Thread Rick Jones
Stephen Hemminger wrote: On Thu, 30 Aug 2007 18:09:17 -0700 Rick Jones [EMAIL PROTECTED] wrote: While messing about with sysctl_tcp_rto_min I went back and forth a bit as to whether there should have been bounds checking (as did some of the folks who did some internal review for me). That

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-31 Thread Rick Jones
John Heffner wrote: Rick Jones wrote: Like I said the consumers of this are a triffle well, anxious :) Just curious, did you or this customer try with F-RTO enabled? Or is this case you're dealing with truly hopeless? F-RTO was mentioned to the customer and I'm awaiting their response

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-08-31 Thread Randy Dunlap
On Thu, 19 Jul 2007 23:05:57 +0100 Simon Arlott wrote: On 19/07/07 17:19, Robert P. J. Day wrote: On Thu, 19 Jul 2007, Randy Dunlap wrote: I think that Stefan means a patch to the kconfig source code, not the the Kconfig files. Good luck. I'd still like to see it. yes, i understand

Re: [1/1] Block device throttling [Re: Distributed storage.]

2007-08-31 Thread Evgeniy Polyakov
Hi Daniel. On Thu, Aug 30, 2007 at 04:20:35PM -0700, Daniel Phillips ([EMAIL PROTECTED]) wrote: On Wednesday 29 August 2007 01:53, Evgeniy Polyakov wrote: Then, if of course you will want, which I doubt, you can reread previous mails and find that it was pointed to that race and

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-08-31 Thread Robert P. J. Day
On Fri, 31 Aug 2007, Randy Dunlap wrote: On Thu, 19 Jul 2007 23:05:57 +0100 Simon Arlott wrote: On 19/07/07 17:19, Robert P. J. Day wrote: On Thu, 19 Jul 2007, Randy Dunlap wrote: I think that Stefan means a patch to the kconfig source code, not the the Kconfig files. Good luck.

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-31 Thread Rick Jones
David Miller wrote: From: Rick Jones [EMAIL PROTECTED] Date: Thu, 30 Aug 2007 18:07:13 -0700 Anyhow, I'll try grubbing around the source code (already doing that to see about writing a pet tcp cong module) but if pointers to the likely relevant files were available I could try to help

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-08-31 Thread Jeff Garzik
Robert P. J. Day wrote: On Fri, 31 Aug 2007, Randy Dunlap wrote: On Thu, 19 Jul 2007 23:05:57 +0100 Simon Arlott wrote: On 19/07/07 17:19, Robert P. J. Day wrote: On Thu, 19 Jul 2007, Randy Dunlap wrote: I think that Stefan means a patch to the kconfig source code, not the the Kconfig

Re: [PATCH 2.6.24 2/3]S2io: Support for add/delete/store/restore ethernet addresses

2007-08-31 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 31 Aug 2007 09:28:23 -0400 Sreenivasa Honnur wrote: - Support to add/delete/store/restore 64 and 128 Ethernet addresses for Xframe I and Xframe II respectively. Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED] Signed-off-by: Ramkrishna

Re: [PATCH 2.6.24 2/3]S2io: Support for add/delete/store/restore ethernet addresses

2007-08-31 Thread Jeff Garzik
David Miller wrote: From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 31 Aug 2007 09:28:23 -0400 Sreenivasa Honnur wrote: - Support to add/delete/store/restore 64 and 128 Ethernet addresses for Xframe I and Xframe II respectively. Signed-off-by: Sreenivasa Honnur [EMAIL PROTECTED]

[git patches] net driver fixes

2007-08-31 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/infiniband/hw/cxgb3/cxio_hal.c |2 +- drivers/net/cxgb3/adapter.h|2 + drivers/net/cxgb3/common.h

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-31 Thread David Miller
From: Rick Jones [EMAIL PROTECTED] Date: Fri, 31 Aug 2007 11:11:37 -0700 At the risk of showing my ignorance (what me worry about that?-) I presume this is then an interface expecting to take-in jiffies? That means the user has to know the value of HZ which can be (IIRC) one of three

Re: net-2.6.24 rebased

2007-08-31 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Fri, 31 Aug 2007 09:44:32 -0400 Sorry, I sent the patch through Jeff. http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/upstream-jgarzik/0010-rtl8187-remove-IEEE80211_HW_DATA_NULLFUNC_ACK.patch But, it sounds like you

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-08-31 Thread Jan Engelhardt
On Aug 31 2007 14:06, Jeff Garzik wrote: something like BROKEN, though, has *nothing* to do with maturity. a feature can be any of those maturity levels, and simultaneously be BROKEN. i consider BROKEN to be what i call a status, and different status levels might be the default of normal,

[PATCH] Fix e100 on systems that have cache incoherent DMA

2007-08-31 Thread David Acker
On the systems that have cache incoherent DMA, including ARM, there is a race condition between software allocating a new receive buffer and hardware writing into a buffer. The two race on touching the last Receive Frame Descriptor (RFD). It has its el-bit set and its next link equal to 0. When

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-31 Thread Rick Jones
I managed to find iproute2 sources (they were debian lenny/testing 2.6.20-1) and applied the patch, and figured-out how to add a host route back to one of my systems. I then did a change to set rto_min to 300. I started a tcpdump and then a netperf, and then forces some retransmissions the

  1   2   >