Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-08-31 Thread Robert P. J. Day
On Fri, 31 Aug 2007, Jeff Garzik wrote: Robert P. J. Day wrote: i'm sure i'm going to get shouted down here, but i really disagree with BROKEN being considered a maturity level. IMHO, things like EXPERIMENTAL, DEPRECATED and OBSOLETE represent maturity levels, for what i think are

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-08-31 Thread Robert P. J. Day
On Fri, 31 Aug 2007, Randy Dunlap wrote: What I like about the patch is that it associates some kconfig symbol with prompt strings, so that we don't have to edit (EXPERIMENTAL) all the darn time (e.g.). I'd be quite happy with calling it status rather than maturity, and with being able to

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-08-31 Thread Randy Dunlap
On Fri, 31 Aug 2007 17:00:57 -0400 (EDT) Robert P. J. Day wrote: On Fri, 31 Aug 2007, Randy Dunlap wrote: What I like about the patch is that it associates some kconfig symbol with prompt strings, so that we don't have to edit (EXPERIMENTAL) all the darn time (e.g.). I'd be quite

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-31 Thread David Miller
From: Rick Jones [EMAIL PROTECTED] Date: Fri, 31 Aug 2007 13:59:50 -0700 ip is at tcp_rto_min+0x20/0x40 diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 1ee7212..bbad2cd 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -560,7 +560,7 @@ static u32 tcp_rto_min(struct

[PATCH v3 0/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-08-31 Thread Michael Chan
Third version of the iSCSI patch for BNX2 which has addressed the comments we have received. I know there is general dislike about this stuff on netdev, as shown by the RDMA discussions. iSCSI is at least a bit more mainstream. David, please consider merging this for 2.6.24. Thanks. Full patch

Ethernet weirdness on 82xx

2007-08-31 Thread Rune Torgersen
I'm not sure if this is by design or an actual bug. We have a system witb an 8280 with two active ethernets (fcc2 and fcc3) We are running kernel 2.6.18.1 (and won't be upgrading in a while) out of arch/ppc Eth0 and eth1 are in totally different subnets. We happened to have both ehternets

Re: [1/1] Block device throttling [Re: Distributed storage.]

2007-08-31 Thread Alasdair G Kergon
On Thu, Aug 30, 2007 at 04:20:35PM -0700, Daniel Phillips wrote: Resubmitting a bio or submitting a dependent bio from inside a block driver does not need to be throttled because all resources required to guarantee completion must have been obtained _before_ the bio was allowed to proceed

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-08-31 Thread Jeff Garzik
Robert P. J. Day wrote: On Fri, 31 Aug 2007, Jeff Garzik wrote: Robert P. J. Day wrote: i'm sure i'm going to get shouted down here, but i really disagree with BROKEN being considered a maturity level. IMHO, things like EXPERIMENTAL, DEPRECATED and OBSOLETE represent maturity levels, for

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-31 Thread Joe Perches
On Tue, 2007-08-28 at 14:22 -0700, David Miller wrote: From: Joe Perches [EMAIL PROTECTED] Option 2: DECLARE_MAC_BUF(mac); printk(%s, print_mac(mac, dev-dev_addr)); I'm slightly leaning towards 2. Here are the patches for this conversion. Compiled successfully x86, defconfig and

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-31 Thread Johannes Berg
On Fri, 2007-08-31 at 15:16 -0700, Joe Perches wrote: please pull from: git pull git://repo.or.cz/linux-2.6/trivial-mods.git net-2.6.24-print_mac got a gitweb for that somewhere? johannes signature.asc Description: This is a digitally signed message part

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-31 Thread Rick Jones
David Miller wrote: From: Rick Jones [EMAIL PROTECTED] Date: Fri, 31 Aug 2007 13:59:50 -0700 ip is at tcp_rto_min+0x20/0x40 diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 1ee7212..bbad2cd 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -560,7 +560,7 @@

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-08-31 Thread Robert P. J. Day
On Fri, 31 Aug 2007, Jeff Garzik wrote: 'deprecrated' and 'obsolete' are matters of discussed opinion, describing the utility of the code in question. 'broken' describes the state of the code itself. Clear difference. precisely. thank you for making my point for me. rday --

Re: [PATCH] make _minimum_ TCP retransmission timeout configurable take 2

2007-08-31 Thread David Miller
From: Rick Jones [EMAIL PROTECTED] Date: Fri, 31 Aug 2007 15:20:52 -0700 I'm going to go ahead and take a look at input vs output units and differences between those with rto_min vs rtt. You better because that's one of the last non-trivial emails you'll get for me over the next few days

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-31 Thread Johannes Berg
On Fri, 2007-08-31 at 15:24 -0700, Joe Perches wrote: On Sat, 2007-09-01 at 00:21 +0200, Johannes Berg wrote: On Fri, 2007-08-31 at 15:16 -0700, Joe Perches wrote: please pull from: git pull git://repo.or.cz/linux-2.6/trivial-mods.git net-2.6.24-print_mac got a gitweb for that

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-31 Thread Johannes Berg
On Fri, 2007-08-31 at 15:24 -0700, Joe Perches wrote: On Sat, 2007-09-01 at 00:21 +0200, Johannes Berg wrote: On Fri, 2007-08-31 at 15:16 -0700, Joe Perches wrote: please pull from: git pull git://repo.or.cz/linux-2.6/trivial-mods.git net-2.6.24-print_mac got a gitweb for that

Re: [PATCH net-2.6.24] introduce MAC_FMT/MAC_ARG

2007-08-31 Thread Joe Perches
On Sat, 2007-09-01 at 00:32 +0200, Johannes Berg wrote: I think you got a bit too trigger-happy: p += sprintf(p, key[%d] alg=CCMP key_set=%d -tx_pn=%02x%02x%02x%02x%02x%02x -rx_pn=%02x%02x%02x%02x%02x%02x +tx_pn=%s +

[SKBUFF]: Fix up csum_start when head room changes

2007-08-31 Thread Herbert Xu
Hi Dave: [SKBUFF]: Fix up csum_start when head room changes Thanks for noticing the bug where csum_start is not updated when the head room changes. This patch fixes that. It also moves the csum/ip_summed copying into copy_skb_header so that skb_copy_expand gets it too. I've checked its

RE: [PATCH 2.6.24 4/5]S2io: Check for CARD_DOWN before handling traffic

2007-08-31 Thread Ramkrishna Vepa
Jeff, - Added check to return from the traffic handling function, if the card status is DOWN. Signed-off-by: Sivakumar Subramani [EMAIL PROTECTED] Signed-off-by: Santosh Rastapur [EMAIL PROTECTED] Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED] --- diff -Nurp

Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals

2007-08-31 Thread Nick Kossifidis
2007/8/30, John W. Linville [EMAIL PROTECTED]: On Thu, Aug 30, 2007 at 04:50:01AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig [EMAIL PROTECTED]: ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by most drivers and ath5k_hw_inivals.o mights aswell be

Re: zd1211rw regression, device does not enumerate

2007-08-31 Thread Daniel Drake
Oliver Neukum wrote: after bisection it boils down to this patch: [EMAIL PROTECTED]:/home/olli2/Trees/linux-2.6 git bisect bad 74553aedd46b3a2cae986f909cf2a3f99369decc is first bad commit commit 74553aedd46b3a2cae986f909cf2a3f99369decc Author: Daniel Drake [EMAIL PROTECTED] Date: Sun Jul 1

Re: [PATCH 5/5] Net: ath5k, kconfig changes

2007-08-31 Thread Nick Kossifidis
2007/8/31, Nick Kossifidis [EMAIL PROTECTED]: 2007/8/30, John W. Linville [EMAIL PROTECTED]: On Thu, Aug 30, 2007 at 04:38:09AM +0300, Nick Kossifidis wrote: 2007/8/28, Christoph Hellwig [EMAIL PROTECTED]: Also this whole patch seems rather pointless. It saves only very little and

<    1   2