Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread David Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Sat, 8 Sep 2007 09:53:49 +0200 > Yes a correct observation. I've spotted this bug too and it caused by the > policy change in the NAPI scheduling. Look at tx_cleaned. > > I suggest we revert this change for now. The tx_cleaned logic change was n

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Pavel Emelyanov
Eric W. Biederman wrote: > Pavel Emelyanov <[EMAIL PROTECTED]> writes: > >>> + } >>> >>> - tbp = peer_tb; >>> - } else >>> - tbp = tb; >> The intention of this part was to get the same parameters for >> peer as for the first device if no "peer" argument was specified >> f

Re: [PATCH 1/1] ipv6: corrects sended rtnetlink message

2007-09-12 Thread Thomas Graf
* Milan Kocian <[EMAIL PROTECTED]> 2007-09-12 16:50 > However I still think that this notitfication is redundant. I tried to look > at XORP, bird, USAGI , quagga and to see RTM_DELLINK handling. And imho > nobody depends on RTM_DELLINK message from ipv6. Send a patch to remove and we'll see if any

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Eric W. Biederman
Pavel Emelyanov <[EMAIL PROTECTED]> writes: >> +} >> >> -tbp = peer_tb; >> -} else >> -tbp = tb; > > The intention of this part was to get the same parameters for > peer as for the first device if no "peer" argument was specified > for ip utility. Does it still wo

Re: [PATCH 1/1] ipv6: corrects sended rtnetlink message

2007-09-12 Thread Milan Kocian
> > Now I ignore (RTM_DELLINK && ifi_family==AF_INET6) :-). But it's only > > workaround > > till next change. > > That's also correct, pure netdevice notification will always be sent > with the ifi_family set to AF_UNSPEC. > It's essential property, I missed. Thanks. > > Hard to find it. I ca

Re: [PATCH 0/6] NET_SCHED: Rate table fixes

2007-09-12 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 12:54:07 +0200 > Jesper Dangaard Brouer wrote: > > This set of patches, aim at fixing an issue with the rate table used > > by the rate based schedulers. > > > ACK for all the patches :) I added the two kernel patches to net-2.6.2

Re: [NFS] [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread Wolfgang Walter
Am Mittwoch, 12. September 2007 15:37 schrieb J. Bruce Fields: > On Wed, Sep 12, 2007 at 02:07:10PM +0200, Wolfgang Walter wrote: > > as already described old temporary sockets (client is gone) of lockd > > aren't closed after some time. So, with enough clients and some time > > gone, there are 80

Re: [PATCH 4/4] [IPROUTE2] iproute2: link_veth support bug fixes.

2007-09-12 Thread Pavel Emelyanov
[snip] > @@ -25,6 +26,3 @@ clean: > > LDLIBS += -ldl > LDFLAGS += -Wl,-export-dynamic > - > -%.so: %.c > - $(CC) $(CFLAGS) -shared $< -o $@ %) How do we get the .so file then? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL

Re: 2.6.23-rc5: possible irq lock inversion dependency detected

2007-09-12 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Tue, 11 Sep 2007 20:43:27 +0800 > On Tue, Sep 11, 2007 at 08:01:46AM -0400, jamal wrote: > > > > [NET_SCHED] protect action config/dump from irqs > > Looks good! Thanks Jamal. Applied, I'll try to push this in some time soon. - To unsubscribe from this

Re: [PATCH][2/2] Add ICMPMsgStats MIB (RFC 4293)

2007-09-12 Thread David Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Tue, 11 Sep 2007 08:21:54 -0700 > So maybe it's not so bad -- I'll roll another per-interface version > to see. Let us know how it goes. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

Re: New NAPI API: Need for netif_napi_remove() ?!

2007-09-12 Thread David Miller
From: "Kok, Auke" <[EMAIL PROTECTED]> Date: Mon, 10 Sep 2007 17:27:33 -0700 > hm, I spoke too soon, I think I can get by for now by just modifying > adapter->napi.poll when needed, and this would be clean enough for now. This > might change as I enable multiqueue in this driver later though. Ok

Re: [NFS] [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2007 at 09:37:29AM -0400, bfields wrote: > So the fact that this changes the behavior means that sk_inuse is taking > on negative values. Uh, no, I misread the tests, sorry. I'm not awake.--b. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mes

[RFT] sky2: receive hang check

2007-09-12 Thread Stephen Hemminger
Would some of the users of 2.6.23-rc5 or later who still experience hangs please test this. IT IS EXPERIMENTAL AND NOT TESTED YET. I am sending it out to see if it detects anything. --- a/drivers/net/sky2.c2007-09-12 14:52:18.0 +0200 +++ b/drivers/net/sky2.c2007-09-12 15:5

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Pavel Emelyanov
Eric W. Biederman wrote: > I was getting strange kernel crashes when attempting to > create veth devices when I did not specify a peer argument > to /bin/ip. > > So this patch defaults peer_tb to all zeros and doesn't attempt to > reuse the netlink attributes for the primary link to create the > s

Re: net-2.6.24 build problem

2007-09-12 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 16:08:33 +0200 > ERROR: "xfrm_audit_state_delete" [net/key/af_key.ko] undefined! > ERROR: "xfrm_audit_state_add" [net/key/af_key.ko] undefined! > ERROR: "xfrm_audit_policy_add" [net/key/af_key.ko] undefined! > ERROR: "xfrm_audit_po

Re: [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread Neil Brown
On Wednesday September 12, [EMAIL PROTECTED] wrote: > Hello, > > as already described old temporary sockets (client is gone) of lockd aren't > closed after some time. So, with enough clients and some time gone, there > are 80 open dangling sockets and you start getting messages of the form: > > l

Re: [PATCH] [IPROUTE2] Add support for moving links between network namespaces

2007-09-12 Thread Stephen Hemminger
On Wed, 12 Sep 2007 08:06:08 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > Stephen Hemminger <[EMAIL PROTECTED]> writes: > > > On Wed, 12 Sep 2007 07:05:42 -0600 > > [EMAIL PROTECTED] (Eric W. Biederman) wrote: > > > >> > >> This adds support for setting the IFLA_NET_NS_PID attribute > >>

net-2.6.24 build problem

2007-09-12 Thread Stephen Hemminger
ERROR: "xfrm_audit_state_delete" [net/key/af_key.ko] undefined! ERROR: "xfrm_audit_state_add" [net/key/af_key.ko] undefined! ERROR: "xfrm_audit_policy_add" [net/key/af_key.ko] undefined! ERROR: "xfrm_audit_policy_delete" [net/key/af_key.ko] undefined # # Automatically generated make config: don't

Re: [PATCH] [IPROUTE2] Add support for moving links between network namespaces

2007-09-12 Thread Eric W. Biederman
Stephen Hemminger <[EMAIL PROTECTED]> writes: > On Wed, 12 Sep 2007 07:05:42 -0600 > [EMAIL PROTECTED] (Eric W. Biederman) wrote: > >> >> This adds support for setting the IFLA_NET_NS_PID attribute >> on links allowing them to be moved between network namespaces. >> >> Signed-off-by: Eric W. Bie

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-12 Thread Stephen Hemminger
On Wed, 12 Sep 2007 14:50:01 +0100 James Chapman <[EMAIL PROTECTED]> wrote: > jamal wrote: > > On Wed, 2007-12-09 at 03:04 -0400, Bill Fink wrote: > >> On Fri, 07 Sep 2007, jamal wrote: > > > >>> I am going to be the devil's advocate[1]: > >> So let me be the angel's advocate. :-) > > > > I thi

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-12 Thread James Chapman
jamal wrote: On Wed, 2007-12-09 at 03:04 -0400, Bill Fink wrote: On Fri, 07 Sep 2007, jamal wrote: I am going to be the devil's advocate[1]: So let me be the angel's advocate. :-) I think this would make you God's advocate ;-> (http://en.wikipedia.org/wiki/God%27s_advocate) I view his re

Re: [PATCH 1/4] [IPROUTE2] Revert "Make ip utility veth driver aware"

2007-09-12 Thread Eric W. Biederman
[EMAIL PROTECTED] (Eric W. Biederman) writes: > Pavel Emelyanov <[EMAIL PROTECTED]> writes: > >> Eric W. Biederman wrote: >>> Stephen it looks like you weren't cc'd on the latest version >>> of the veth support. So this patchset first reverts the old >> >> He was. The latest version looks complet

Re: [PATCH] [IPROUTE2] Add support for moving links between network namespaces

2007-09-12 Thread Stephen Hemminger
On Wed, 12 Sep 2007 07:05:42 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > > This adds support for setting the IFLA_NET_NS_PID attribute > on links allowing them to be moved between network namespaces. > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> > --- > include/linux/if_link

Re: [NFS] [patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2007 at 02:07:10PM +0200, Wolfgang Walter wrote: > as already described old temporary sockets (client is gone) of lockd aren't > closed after some time. So, with enough clients and some time gone, there > are 80 open dangling sockets and you start getting messages of the form: > >

[PATCH] IPV4 : convert rt_check_expire() from softirq processing to workqueue

2007-09-12 Thread Eric Dumazet
On loaded/big hosts, rt_check_expire() if of litle use, because it generally breaks out of its main loop because of a jiffies change. It can take a long time (read : timer invocations) to actually scan the whole hash table, freeing unused entries. Converting it to use a workqueue instead of softi

Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Wed, 12 Sep 2007 07:19:56 -0600 > > I was getting strange kernel crashes when attempting to > create veth devices when I did not specify a peer argument > to /bin/ip. > > So this patch defaults peer_tb to all zeros and doesn't attempt to > reuse

Re: new NAPI interface broken for POWER architecture?

2007-09-12 Thread David Miller
From: Christoph Raisch <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 15:10:08 +0200 > This is definitely not something we can change in the HEA device driver > alone. And it shouldn't be, x86 implements the policy in irq balance daemon, powerpc should do it wherever it would be appropriate there. >

dscc4.c tests for "#ifndef MODULE" even though it must be modular

2007-09-12 Thread Robert P. J. Day
from drivers/net/wan/dscc4.c: = #ifndef MODULE static int __init dscc4_setup(char *str) { int *args[] = { &debug, &quartz, NULL }, **p = args; while (*p && (get_option(&str, *p) == 2)) p++; return 1; } __setup("dscc4.setup=", dscc4_setup); #endif ==

Re: new NAPI interface broken for POWER architecture?

2007-09-12 Thread Christoph Raisch
David Miller <[EMAIL PROTECTED]> wrote on 12.09.2007 14:50:04: > From: Jan-Bernd Themann <[EMAIL PROTECTED]> > Date: Fri, 7 Sep 2007 11:37:02 +0200 > > > 2) On SMP systems: after netif_rx_complete has been called on CPU1 > >(+interruts enabled), netif_rx_schedule could be called on CPU2 > >

Re: [-mm patch] make tcp_splice_data_recv() static

2007-09-12 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 9 Sep 2007 22:25:58 +0200 > On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.23-rc3-mm1: > >... > > git-block.patch > >... > > git trees > >... > > tcp_splice_data_recv() can become static. > > Signed-o

[PATCH] veth: Cleanly handle a missing peer_tb argument on creation.

2007-09-12 Thread Eric W. Biederman
I was getting strange kernel crashes when attempting to create veth devices when I did not specify a peer argument to /bin/ip. So this patch defaults peer_tb to all zeros and doesn't attempt to reuse the netlink attributes for the primary link to create the secondary link and now I can't reproduc

Re: [-mm patch] net/sctp/socket.c: make 3 variables static

2007-09-12 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 9 Sep 2007 22:25:54 +0200 > This patch makes the following needlessly globalvariables static: > - sctp_memory_pressure > - sctp_memory_allocated > - sctp_sockets_allocated > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied, thanks. - To un

Re: [2.6 patch] make sctp_addto_param() static

2007-09-12 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 9 Sep 2007 22:25:50 +0200 > sctp_addto_param() can become static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

Re: [-mm patch] unexport raise_softirq_irqoff

2007-09-12 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sun, 9 Sep 2007 21:41:53 +0100 > On Sun, Sep 09, 2007 at 10:25:44PM +0200, Adrian Bunk wrote: > > On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: > > >... > > > Changes since 2.6.23-rc3-mm1: > > >... > > > git-net.patch > > >... > >

Re: [-mm patch] really unexport do_softirq

2007-09-12 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sun, 9 Sep 2007 22:25:40 +0200 > On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.23-rc3-mm1: > >... > > git-net.patch > >... > > git trees > >... > > This hydra had more than one head... > > Signed-off-by:

Re: [PATCH 1/4] [IPROUTE2] Revert "Make ip utility veth driver aware"

2007-09-12 Thread Eric W. Biederman
Pavel Emelyanov <[EMAIL PROTECTED]> writes: > Eric W. Biederman wrote: >> Stephen it looks like you weren't cc'd on the latest version >> of the veth support. So this patchset first reverts the old > > He was. The latest version looks completely different from what > is reversed in this patch. T

[PATCH] [IPROUTE2] Add support for moving links between network namespaces

2007-09-12 Thread Eric W. Biederman
This adds support for setting the IFLA_NET_NS_PID attribute on links allowing them to be moved between network namespaces. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- include/linux/if_link.h |1 + ip/iplink.c |9 + 2 files changed, 10 insertions(+), 0 del

[PATCH] [IPROUTE2] Basic documentation for dynamic link creation/destruction.

2007-09-12 Thread Eric W. Biederman
This updates the usage to indicate that we have support link creation and destruction in addition to just setting link parameters. It's not really great documentation of the new netlink support for link creations and removal but it is a start. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>

[PATCH 4/4] [IPROUTE2] iproute2: link_veth support bug fixes.

2007-09-12 Thread Eric W. Biederman
From: Eric W. Biederman <[EMAIL PROTECTED]> Date: Sat, 8 Sep 2007 10:17:43 -0600 This patch contains small compile and implementation bug fixes for link_veth.c. The compile fixes stop trying to build a shared object when we can just as easily compile the code in. Making support of non arch/i386

[PATCH 3/4] [IPROUTE2] Module for ip utility to support veth device

2007-09-12 Thread Eric W. Biederman
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 13:33:56 +0400 The link_veth.so itself. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Acked-by: Patrick McHardy <[EMAIL PROTECTED]> --- ip/Makefile|6 - ip/link_veth.c | 63 +++

[PATCH 2/6] [IPROUTE2] Introduce iplink_parse() routine

2007-09-12 Thread Eric W. Biederman
From: Pavel Emelyanov <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 13:32:31 +0400 This routine parses CLI attributes, describing generic link parameters such as name, address, etc. This is mostly copy-pasted from iplink_modify(). Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Acked-by: Patrick

Re: [net-2.6.24][NETNS][patch 3/3] fix bad macro definition

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 14:38:14 +0200 > From: Daniel Lezcano <[EMAIL PROTECTED]> > > The macro definition is bad. When calling next_net_device with > parameter name "dev", the resulting code is: > struct net_device *dev = dev and that leads to an unexpected > beha

Re: [net-2.6.24][NETNS][patch 1/3] fix export symbols

2007-09-12 Thread Daniel Lezcano
David Miller wrote: From: [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 14:38:12 +0200 From: Daniel Lezcano <[EMAIL PROTECTED]> Add the appropriate EXPORT_SYMBOLS for proc_net_create, proc_net_fops_create and proc_net_remove to fix errors when compiling allmodconfig Signed-off-by: Mark Nelson <[EM

Re: [PATCH 1/4] [IPROUTE2] Revert "Make ip utility veth driver aware"

2007-09-12 Thread Pavel Emelyanov
Eric W. Biederman wrote: > Stephen it looks like you weren't cc'd on the latest version > of the veth support. So this patchset first reverts the old He was. The latest version looks completely different from what is reversed in this patch. > version of the veth support you merged. Then merges

Re: [net-2.6.24][NETNS][patch 2/3] fix loopback network namespace initialization

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 14:38:13 +0200 > From: Daniel Lezcano <[EMAIL PROTECTED]> > > The core patchset of the network namespace sent by > Eric Biederman does not do dynamic loopback creation. > So there is no call to alloc_netdev_mq which fills the > network namespace fie

[PATCH 1/4] [IPROUTE2] Revert "Make ip utility veth driver aware"

2007-09-12 Thread Eric W. Biederman
Stephen it looks like you weren't cc'd on the latest version of the veth support. So this patchset first reverts the old version of the veth support you merged. Then merges a tested version of the veth support. This reverts commit 4ed390ce43d1ec7c881721f312260df901d8390d. Conflicts: i

Re: [net-2.6.24][NETNS][patch 1/3] fix export symbols

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 14:38:12 +0200 > From: Daniel Lezcano <[EMAIL PROTECTED]> > > Add the appropriate EXPORT_SYMBOLS for proc_net_create, > proc_net_fops_create and proc_net_remove to fix errors when > compiling allmodconfig > > Signed-off-by: Mark Nelson <[EMAIL PROTE

Re: new NAPI interface broken

2007-09-12 Thread David Miller
From: Jan-Bernd Themann <[EMAIL PROTECTED]> Date: Fri, 7 Sep 2007 11:37:02 +0200 > 2) On SMP systems: after netif_rx_complete has been called on CPU1 >(+interruts enabled), netif_rx_schedule could be called on CPU2 >(irq handler) before net_rx_action on CPU1 has checked NAPI_STATE_SCHED.

Re: [PATCH net-2.6.23-rc5] ipsec interfamily route handling fix

2007-09-12 Thread David Miller
From: Joakim Koskela <[EMAIL PROTECTED]> Date: Thu, 6 Sep 2007 19:00:10 +0300 > This patch addresses a couple of issues related to interfamily ipsec > modes. The problem is that the structure of the routing info changes > with the family during the __xfrmX_bundle_create, which hasn't been > taken

[net-2.6.24][NETNS][patch 3/3] fix bad macro definition

2007-09-12 Thread dlezcano
From: Daniel Lezcano <[EMAIL PROTECTED]> The macro definition is bad. When calling next_net_device with parameter name "dev", the resulting code is: struct net_device *dev = dev and that leads to an unexpected behavior. Especially when llc_core is compiled in, the kernel panics at boot

[net-2.6.24][NETNS][patch 2/3] fix loopback network namespace initialization

2007-09-12 Thread dlezcano
From: Daniel Lezcano <[EMAIL PROTECTED]> The core patchset of the network namespace sent by Eric Biederman does not do dynamic loopback creation. So there is no call to alloc_netdev_mq which fills the network namespace field of the netdevice. This patch assign the loopback to the init network na

[net-2.6.24][NETNS][patch 1/3] fix export symbols

2007-09-12 Thread dlezcano
From: Daniel Lezcano <[EMAIL PROTECTED]> Add the appropriate EXPORT_SYMBOLS for proc_net_create, proc_net_fops_create and proc_net_remove to fix errors when compiling allmodconfig Signed-off-by: Mark Nelson <[EMAIL PROTECTED]> Acked-by: Benjamin Thery <[EMAIL PROTECTED]> --- fs/proc/proc_net.c |

[net-2.6.24][NETNS][patch 0/3] fixes for the core network namespace

2007-09-12 Thread dlezcano
The following patches fixes some compilation errors and boot problems related to the network namespace patchset. They apply to net-2.6.24 -- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: [NETLINK]: Introduce nested and byteorder flag to netlink attribute

2007-09-12 Thread David Miller
From: Thomas Graf <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 14:41:45 +0200 > This change allows the generic attribute interface to be used within > the netfilter subsystem where this flag was initially introduced. > > The byte-order flag is yet unused, it's intended use is to > allow automatic b

[NETLINK]: Introduce nested and byteorder flag to netlink attribute

2007-09-12 Thread Thomas Graf
This change allows the generic attribute interface to be used within the netfilter subsystem where this flag was initially introduced. The byte-order flag is yet unused, it's intended use is to allow automatic byte order convertions for all atomic types. Signed-off-by: Thomas Graf <[EMAIL PROTECT

Re: BUG: scheduling while atomic: ifconfig/0x00000002/4170

2007-09-12 Thread David Miller
From: Johannes Berg <[EMAIL PROTECTED]> Date: Thu, 06 Sep 2007 17:19:55 +0200 > > Oh btw. Can we stick a might_sleep() into dev_close() *before* the test > whether the device is up? That way, we'd have seen the bug, but > apparently nobody before Florian ever did a 'ip link set wmaster0 down' > w

Re: [PATCH] NET : convert IP route cache garbage colleciton from softirq processing to a workqueue

2007-09-12 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 14:16:56 +0200 > OK, let's try a normal prefetch(), I'll change it later when/if a > new generic macro is added. I added the missing 'static' and a comment > about the "struct {} dst_garbage". I also corrected spelling error on > patch

Re: [PATCH 4/6] [IPROUTE2]: Overhead calculation is now done in the kernel

2007-09-12 Thread Jesper Dangaard Brouer
On Wed, 2007-09-12 at 13:05 +0200, Stephen Hemminger wrote: > How is this binary compatable with older kernels? It will be binary compatable, as I use/rename some unused variables in struct tc_ratespec. -- Med venlig hilsen / Best regards Jesper Brouer ComX Networks A/S Linux Network deve

Re: [PATCH 07/16] net: Make /proc/net per network namespace

2007-09-12 Thread David Miller
From: Daniel Lezcano <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 14:12:04 +0200 > it seems the fs/proc/proc_net.c was not added to the git repository. Fixed, thanks for catching that. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED]

Re: [PATCH] NET : convert IP route cache garbage colleciton from softirq processing to a workqueue

2007-09-12 Thread Eric Dumazet
On Wed, 12 Sep 2007 04:12:00 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Eric Dumazet <[EMAIL PROTECTED]> > Date: Wed, 12 Sep 2007 12:08:45 +0200 > > > Unfortunatly, there is no equivalent for this one. > > This gives on my Opterons a nice "prefetchnta" > > > > prefetch(addr) is

Re: [PATCH 17/16] net: Disable netfilter sockopts when not in the initial network namespace

2007-09-12 Thread Eric W. Biederman
David Miller <[EMAIL PROTECTED]> writes: > I added the following patch to net-2.6.24 to kill a warning > since net_alloc() has no users (yet). Reasonable, and thanks for merging these. Having a solid place to start helps a lot. I will see if I can get the /proc races fixed shortly. Eric - To u

Re: [PATCH 07/16] net: Make /proc/net per network namespace

2007-09-12 Thread Daniel Lezcano
David Miller wrote: From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:20:36 -0600 This patch makes /proc/net per network namespace. It modifies the global variables proc_net and proc_net_stat to be per network namespace. The proc_net file helpers are modified to take a netw

Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates

2007-09-12 Thread jamal
On Wed, 2007-12-09 at 03:04 -0400, Bill Fink wrote: > On Fri, 07 Sep 2007, jamal wrote: > > I am going to be the devil's advocate[1]: > > So let me be the angel's advocate. :-) I think this would make you God's advocate ;-> (http://en.wikipedia.org/wiki/God%27s_advocate) > I view his results m

[patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread Wolfgang Walter
Hello, as already described old temporary sockets (client is gone) of lockd aren't closed after some time. So, with enough clients and some time gone, there are 80 open dangling sockets and you start getting messages of the form: lockd: too many open TCP sockets, consider increasing the number of

[PATCH 1/3] sk98lin: restore driver

2007-09-12 Thread Stephen Hemminger
This reverts commit e1abecc48938fbe1966ea6e78267fc673fa59295. The driver works on some hardware that skge doesn't handle yet. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- Patch too large for mailing list. Download from: http://developer.osdl.org/shemminger/patches/sk

Re: [PATCH 17/16] net: Disable netfilter sockopts when not in the initial network namespace

2007-09-12 Thread David Miller
I added the following patch to net-2.6.24 to kill a warning since net_alloc() has no users (yet). commit f444fa9b5d70b3d431e1554e0975e012514c39f3 Author: David S. Miller <[EMAIL PROTECTED](none)> Date: Wed Sep 12 14:01:08 2007 +0200 [NET]: #if 0 out net_alloc() for now. We will un

Re: [PATCH 17/16] net: Disable netfilter sockopts when not in the initial network namespace

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:47:12 -0600 > > Until we support multiple network namespaces with netfilter only allow > netfilter configuration in the initial network namespace. > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> Applied to net-2.6.24

Re: [PATCH 16/16] net: netlink support for moving devices between network namespaces.

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:43:44 -0600 > > The simplest thing to implement is moving network devices between > namespaces. However with the same attribute IFLA_NET_NS_PID we can > easily implement creating devices in the destination network > namespace

Re: [PATCH 15/16] net: Implement network device movement between namespaces

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:38:46 -0600 > > This patch introduces NETIF_F_NETNS_LOCAL a flag to indicate > a network device is local to a single network namespace and > should never be moved. Useful for pseudo devices that we > need an instance in each n

Re: [PATCH 14/16] net: Factor out __dev_alloc_name from dev_alloc_name

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:36:56 -0600 > > When forcibly changing the network namespace of a device > I need something that can generate a name for the device > in the new namespace without overwriting the old name. > > __dev_alloc_name provides me that

Re: [PATCH 13/16] net: Make the device list and device lookups per namespace.

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:35:46 -0600 > > This patch makes most of the generic device layer network > namespace safe. This patch makes dev_base_head a > network namespace variable, and then it picks up > a few associated variables. The functions: > de

[PATCH 3/3]: sk98lin: neuter device to only SysKonnect boards

2007-09-12 Thread Stephen Hemminger
The skge driver works better for all boards except older SysKonnect boards. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sk98lin/skge.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/net/sk98lin/skge.c b/drivers/net/sk98lin/skge.c i

[PATCH 2/3] sk98lin: ethtool perm_addr build fix

2007-09-12 Thread Stephen Hemminger
Deal with API changes while sk98lin was removed. ethtool_ops no longer has a perm_addr hook. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sk98lin/skethtool.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/sk98lin/skethtool.c b/drivers/

Re: [PATCH] Fix e100 on systems that have cache incoherent DMA

2007-09-12 Thread James Chapman
David Acker wrote: Jeff Garzik wrote: David Acker wrote: Let me know if there is any other information I can provide you. I will look through the code to see what could be going on with your machine. I will also look into reproducing these results with a newer kernel. This may be tricky si

[PATCH] [POWERPC] ucc_geth: fix module removal

2007-09-12 Thread Anton Vorontsov
- uccf should be set to NULL to not double-free memory on subsequent calls; - ind_hash_q and group_hash_q lists should be initialized in the probe() function, instead of struct_init() (called by open()), otherwise there will be an oops if ucc_geth_driver removed prior 'ifconfig ethX up'; -

[PATCH] phy: implement release function

2007-09-12 Thread Anton Vorontsov
Lately I've got this nice badness on mdio bus removal: Device 'e0103120:06' does not have a release() function, it is broken and must be fixed. [ cut here ] Badness at drivers/base/core.c:107 NIP: c015c1a8 LR: c015c1a8 CTR: c0157488 REGS: c34bdcf0 TRAP: 0700 Not tainted

Re: [PATCH] NET : convert IP route cache garbage colleciton from softirq processing to a workqueue

2007-09-12 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 12:08:45 +0200 > Unfortunatly, there is no equivalent for this one. > This gives on my Opterons a nice "prefetchnta" > > prefetch(addr) is more like __builtin_prefetch(addr, 0, 3) > > I would like to avoid to zap L2 cache with useles

Re: [PATCH] NET : convert IP route cache garbage colleciton from softirq processing to a workqueue

2007-09-12 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 11:00:54 +0100 > Can you please et rid of this useless struct? It just complicates > the code and means we can't use the proper DEFINE_SPINLOCK initializer. As long as the linker can move global variables around we need to do thi

Re: [PATCH 12/16] net: Support multiple network namespaces with netlink

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:28:27 -0600 > > Each netlink socket will live in exactly one network namespace, > this includes the controlling kernel sockets. > > This patch updates all of the existing netlink protocols > to only support the initial network

Re: [PATCH 11/16] net: Make device event notification network namespace safe

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:27:11 -0600 > > Every user of the network device notifiers is either a protocol > stack or a pseudo device. If a protocol stack that does not have > support for multiple network namespaces receives an event for a > device that

Re: [PATCH 4/6] [IPROUTE2]: Overhead calculation is now done in the kernel

2007-09-12 Thread Stephen Hemminger
On Wed, 12 Sep 2007 12:14:39 +0200 Jesper Dangaard Brouer <[EMAIL PROTECTED]> wrote: > commit 07a74a2613440fc1a68d0faa7235ed7027532d78 > Author: Jesper Dangaard Brouer <[EMAIL PROTECTED]> > Date: Tue Sep 11 16:59:58 2007 +0200 > > [IPROUTE2]: Overhead calculation is now done in the kernel.

Re: [PATCH 3/6] [IPROUTE2]: Update pkt_sched.h (to resemble the kernel one)

2007-09-12 Thread Stephen Hemminger
On Wed, 12 Sep 2007 12:14:14 +0200 Jesper Dangaard Brouer <[EMAIL PROTECTED]> wrote: > commit ef065a43b8900fbc0763eac0fa0a9a8a00c8aaa2 > Author: Jesper Dangaard Brouer <[EMAIL PROTECTED]> > Date: Tue Sep 11 16:17:46 2007 +0200 > > [IPROUTE2]: Update pkt_sched.h (to resemble the kernel one)

Re: [PATCH 10/16] net: Make packet reception network namespace safe

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:25:43 -0600 > > This patch modifies every packet receive function > registered with dev_add_pack() to drop packets if they > are not from the initial network namespace. > > This should ensure that the various network stacks do

Re: [PATCH] Move the definition of pr_err() into kernel.h

2007-09-12 Thread Stephen Hemminger
On Tue, 11 Sep 2007 09:56:05 -0500 Emil Medve <[EMAIL PROTECTED]> wrote: > Other pr_*() macros are already defined in kernel.h, but pr_err() was defined > multiple times in several other places > > Signed-off-by: Emil Medve <[EMAIL PROTECTED]> pr_error seems better than pr_err Please add the fu

Re: [PATCH 09/16] net: Initialize the network namespace of network devices.

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:24:21 -0600 > > Except for carefully selected pseudo devices all network > interfaces should start out in the initial network namespace. > Ultimately it will be register_netdev that examines what > dev->nd_net is set to and pla

Re: [PATCH 0/6] NET_SCHED: Rate table fixes

2007-09-12 Thread Patrick McHardy
Jesper Dangaard Brouer wrote: This set of patches, aim at fixing an issue with the rate table used by the rate based schedulers. ACK for all the patches :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] NET : convert IP route cache garbage colleciton from softirq processing to a workqueue

2007-09-12 Thread Eric Dumazet
On Wed, 12 Sep 2007 11:00:54 +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote: > This looks nice in general, getting things out of softirq context is > always good. I am preparing a patch to net/ipv4/route.c to migrate rt_check_expire() as well. > > On Tue, Sep 11, 2007 at 02:56:13PM +0200, Er

net/bluetooth/hci_sock.c:352: error: storage size of 'ctv' isn't known

2007-09-12 Thread Robert P. J. Day
latest git pull, "make allyesconfig" on i386: ... CC net/bluetooth/hci_sock.o net/bluetooth/hci_sock.c: In function ‘hci_sock_cmsg’: net/bluetooth/hci_sock.c:352: error: storage size of ‘ctv’ isn’t known net/bluetooth/hci_sock.c:352: warning: unused variable ‘ctv’ make[2]

[PATCH 4/6] [IPROUTE2]: Overhead calculation is now done in the kernel

2007-09-12 Thread Jesper Dangaard Brouer
commit 07a74a2613440fc1a68d0faa7235ed7027532d78 Author: Jesper Dangaard Brouer <[EMAIL PROTECTED]> Date: Tue Sep 11 16:59:58 2007 +0200 [IPROUTE2]: Overhead calculation is now done in the kernel. The only current user is HTB. HTB overhead argument is now passed on to the kernel

[PATCH 5/6] [IPROUTE2]: Cleanup: tc_calc_rtable()

2007-09-12 Thread Jesper Dangaard Brouer
commit e3bad6e344303fec9916d1420aade98a2e6c79cc Author: Jesper Dangaard Brouer <[EMAIL PROTECTED]> Date: Wed Sep 5 10:47:47 2007 +0200 [IPROUTE2]: Cleanup: tc_calc_rtable(). Change tc_calc_rtable() to take a tc_ratespec struct as an argument. (cell_log still needs to be passed o

[PATCH 6/6] [IPROUTE2]: Change the rate table calc of transmit cost to use upper bound value

2007-09-12 Thread Jesper Dangaard Brouer
commit 2e3edbef7913ac43899c8258ee59d9032778cee1 Author: Jesper Dangaard Brouer <[EMAIL PROTECTED]> Date: Wed Sep 5 15:24:51 2007 +0200 [IPROUTE2]: Change the rate table calc of transmit cost to use upper bound value. Patrick McHardy, Cite: 'its better to overestimate than underesti

[PATCH 2/6] [NET_SCHED]: Making rate table lookups more flexible

2007-09-12 Thread Jesper Dangaard Brouer
commit 57e993268df114a4270519b1004b8ea8086f671f Author: Jesper Dangaard Brouer <[EMAIL PROTECTED]> Date: Tue Sep 11 15:44:15 2007 +0200 [NET_SCHED]: Making rate table lookups more flexible. This is done in order to, add support to changing the rate table to use the upper-bound

[PATCH 3/6] [IPROUTE2]: Update pkt_sched.h (to resemble the kernel one)

2007-09-12 Thread Jesper Dangaard Brouer
commit ef065a43b8900fbc0763eac0fa0a9a8a00c8aaa2 Author: Jesper Dangaard Brouer <[EMAIL PROTECTED]> Date: Tue Sep 11 16:17:46 2007 +0200 [IPROUTE2]: Update pkt_sched.h (to resemble the kernel one) Extend the tc_ratespec struct, with two parameters: 1) "cell_align" that allow ad

[PATCH 0/6] NET_SCHED: Rate table fixes

2007-09-12 Thread Jesper Dangaard Brouer
This set of patches, aim at fixing an issue with the rate table used by the rate based schedulers. Currently we use the lower-boundry value, which result in under-estimating the actual bandwidth usage. The patches will change this to use the upper-boundry L2T (length to time) value. The patches

[PATCH 1/6] [NET_SCHED]: Cleanup L2T macros and handle oversized packets

2007-09-12 Thread Jesper Dangaard Brouer
commit a28343c933f6cfc3df1be86e0ebe8d99fa8d5f77 Author: Jesper Dangaard Brouer <[EMAIL PROTECTED]> Date: Wed Sep 12 10:01:00 2007 +0200 [NET_SCHED]: Cleanup L2T macros and handle oversized packets Change L2T (length to time) macros, in all rate based schedulers, to call a common

Re: [PATCH] NET : convert IP route cache garbage colleciton from softirq processing to a workqueue

2007-09-12 Thread Eric Dumazet
On Wed, 12 Sep 2007 02:05:25 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Eric Dumazet <[EMAIL PROTECTED]> > Date: Tue, 11 Sep 2007 14:56:13 +0200 > > > When the periodic IP route cache flush is done (every 600 seconds on > > default configuration), some hosts suffer a lot and eve

Re: [PATCH 1/2] dgrs: remove from build, config, and maintainer list

2007-09-12 Thread maximilian attems
On Wed, 12 Sep 2007, Nathanael Nerode wrote: > From: Nathanael Nerode > > Stop building and configuring driver for Digi RightSwitch, which was > never actually sold to anyone, and remove it from MAINTAINERS. > > In response to an investigation into the firmware of the "Digi Rightswitch" > driv

Re: [PATCH 08/16] net: Make socket creation namespace safe.

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:23:01 -0600 > > This patch passes in the namespace a new socket should be created in > and has the socket code do the appropriate reference counting. By > virtue of this all socket create methods are touched. In addition > th

Re: [PATCH] NET : convert IP route cache garbage colleciton from softirq processing to a workqueue

2007-09-12 Thread Christoph Hellwig
This looks nice in general, getting things out of softirq context is always good. On Tue, Sep 11, 2007 at 02:56:13PM +0200, Eric Dumazet wrote: > #if RT_CACHE_DEBUG >= 2 > static atomic_t dst_total = ATOMIC_INIT(0); > #endif > -static unsigned long dst_gc_timer_expires; >

Re: [PATCH 07/16] net: Make /proc/net per network namespace

2007-09-12 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:20:36 -0600 > > This patch makes /proc/net per network namespace. It modifies the global > variables proc_net and proc_net_stat to be per network namespace. > The proc_net file helpers are modified to take a network namespace

<    1   2   3   >