Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection

2007-10-07 Thread TAKANO Ryousei
From: Ilpo Järvinen [EMAIL PROTECTED] Subject: Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection Date: Fri, 5 Oct 2007 13:02:07 +0300 (EEST) On Thu, 4 Oct 2007, TAKANO Ryousei wrote: This patch allows to detect loss of retransmitted packets more accurately by using the highest end

Re: [RFC][PATCH 2/2] TCP: skip processing cached SACK blocks

2007-10-07 Thread TAKANO Ryousei
Hi Ilpo, Thanks for your reply. Most of my response are in the reply to patch 1/2. From: Ilpo Järvinen [EMAIL PROTECTED] Subject: Re: [RFC][PATCH 2/2] TCP: skip processing cached SACK blocks Date: Fri, 5 Oct 2007 13:37:21 +0300 (EEST) On Thu, 4 Oct 2007, TAKANO Ryousei wrote: This patch

Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection

2007-10-07 Thread David Miller
From: TAKANO Ryousei [EMAIL PROTECTED] Date: Sun, 07 Oct 2007 14:51:00 +0900 (JST) BTW, what is difference among netdev-2.6, net-2.6 (net-2.6.24), and tcp-2.6? I am not familiar with linux kernel development process. net-2.6.24 tree is current new development net-2.6 tree is only bug fixes

Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection

2007-10-07 Thread TAKANO Ryousei
From: David Miller [EMAIL PROTECTED] Subject: Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection Date: Sat, 06 Oct 2007 23:17:14 -0700 (PDT) From: TAKANO Ryousei [EMAIL PROTECTED] Date: Sun, 07 Oct 2007 14:51:00 +0900 (JST) BTW, what is difference among netdev-2.6, net-2.6

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-07 Thread Ingo Molnar
* Jeff Garzik [EMAIL PROTECTED] wrote: - spin_unlock(np-lock); - printk(KERN_DEBUG %s: too many iterations (%d) in nv_nic_irq.\n, dev-name, i); - break; i like that! One forcedeth annoyance that triggers frequently on one of my

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Ingo Molnar
* Jeff Garzik [EMAIL PROTECTED] wrote: * I feel TX NAPI is a useful tool, because it provides an independent TX process control point and system load feedback point. Thus I felt this was slightly superior to tasklets. /me agrees violently btw., when i played with this tunable under -rt:

Re: [RFC/PATCH 2/4] UDP memory usage accounting (take 4): accounting unit and variable

2007-10-07 Thread Evgeniy Polyakov
Hi. On Sat, Oct 06, 2007 at 12:01:07AM +0900, Satoshi OSHIMA ([EMAIL PROTECTED]) wrote: --- 2.6.23-rc3-udp_limit.orig/net/ipv4/udp.c +++ 2.6.23-rc3-udp_limit/net/ipv4/udp.c @@ -113,6 +113,10 @@ DEFINE_SNMP_STAT(struct udp_mib, udp_sta struct hlist_head udp_hash[UDP_HTABLE_SIZE];

libertas and endianness

2007-10-07 Thread Geert Uytterhoeven
Somehow (haven't found out why it suddenly got compiled, no .config changes) this showed up in the list of warnings in 2.6.23-rc9 compared to -rc8 on one of my m68k builds: | drivers/net/wireless/libertas/cmd.c:189: warning: large integer implicitly truncated to unsigned type |

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Jeff Garzik
Ingo Molnar wrote: * Jeff Garzik [EMAIL PROTECTED] wrote: * I feel TX NAPI is a useful tool, because it provides an independent TX process control point and system load feedback point. Thus I felt this was slightly superior to tasklets. /me agrees violently btw., when i played with this

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-07 Thread Jeff Garzik
Yinghai Lu wrote: On 10/6/07, Jeff Garzik [EMAIL PROTECTED] wrote: commit a606d2a111cdf948da5d69eb1de5526c5c2dafef Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Oct 5 22:56:05 2007 -0400 [netdrvr] forcedeth: interrupt handling cleanup * nv_nic_irq_optimized() and

2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN

2007-10-07 Thread Andreas Mohr
[not necessarily a very recent regression, used 2.6.19 kernels before...] Hi all, wondered why my main internet server (headless!) didn't come up properly on a new 2.6.23-rc8-mm2 (connections almost completely refused: firewalling not executed due to earlier OOPS?). Upon LILO emergency fallback

Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN

2007-10-07 Thread Jeff Garzik
Andreas Mohr wrote: I intend to still try to get it up and running with 2.6.23-rc8-mm2 today (with some workarounds hopefully, maybe even disabling ISDN completely)... The last running kernel (I didn't have newer ones in between), up for some 110 days was 2.6.19-cks2 (IOW, I cannot quite say

[NET] IPv6 oops bisected

2007-10-07 Thread Jeff Garzik
The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev [EMAIL PROTECTED] Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible oops in net-2.6.24.git, in ip6_route_add(). Platform: x86-64

Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN

2007-10-07 Thread Andreas Mohr
On Sun, Oct 07, 2007 at 08:24:45AM -0400, Jeff Garzik wrote: It definitely looks like ISDN is somehow to blame. Any chance you could try git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.24.git ? I'm afraid I won't make it, since this server is not at my home location, is a

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Jeff Garzik
Jeff Garzik wrote: The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev [EMAIL PROTECTED] Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible oops in net-2.6.24.git, in ip6_route_add().

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Denis V. Lunev
Jeff Garzik wrote: Jeff Garzik wrote: The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev [EMAIL PROTECTED] Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible oops in

Re: [PATCH 3/5] forcedeth: process TX completions using NAPI

2007-10-07 Thread Jeff Garzik
Jeff Garzik wrote: commit 57cbfacc00d69be2ba02b65d1021442273b76263 Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Oct 5 23:25:56 2007 -0400 [netdrvr] forcedeth: process TX completions using NAPI Signed-off-by: Jeff Garzik [EMAIL PROTECTED] drivers/net/forcedeth.c | 143

Re: [PATCH 6/n] forcedeth: protect slow path with mutex

2007-10-07 Thread Jeff Garzik
Jeff Garzik wrote: commit abca163a14b28c234df9bf38034bc967ff81c3aa Author: Jeff Garzik [EMAIL PROTECTED] Date: Sun Oct 7 07:22:14 2007 -0400 [netdrvr] forcedeth: wrap slow path hw manipulation inside hw_mutex * This makes sure everybody who wants to start/stop the RX and TX

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Jeff Garzik
Jeff Garzik wrote: The 'fe-lock' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock contains the following changes that I would like to get tested: [netdrvr] forcedeth: make NAPI unconditional [netdrvr] forcedeth: interrupt handling cleanup

Re: [NET] IPv6 oops bisected

2007-10-07 Thread Jeff Garzik
Denis V. Lunev wrote: Jeff Garzik wrote: Jeff Garzik wrote: The commit commit 5f5dace1ce001b24fb8286e09ffd3c4d2b547e09 Author: Denis V. Lunev [EMAIL PROTECTED] Date: Thu Sep 27 12:41:26 2007 -0700 [NET]: Various dst_ifdown routines to catch refcounting bugs causes a 100% reproducible

Re: [RFC][PATCH 1/2] TCP: fix lost retransmit detection

2007-10-07 Thread Ilpo Järvinen
...Dropped DaveM from cc, I guess he knows the things I describe below already... :-) On Sat, 6 Oct 2007, David Miller wrote: From: TAKANO Ryousei [EMAIL PROTECTED] Date: Sun, 07 Oct 2007 14:51:00 +0900 (JST) BTW, what is difference among netdev-2.6, netdev-2.6 is for network device

Re: [PATCH][TG3]Some cleanups

2007-10-07 Thread jamal
On Wed, 2007-03-10 at 09:18 -0400, jamal wrote: On Tue, 2007-02-10 at 16:33 -0700, Michael Chan wrote: Seems ok to me. I think we should make it more clear that we're skipping over the VLAN tag: (struct tg3_tx_cbdata *)((__skb)-cb[sizeof(struct vlan_skb_tx_cookie)]) Will do -

[PATCH][E1000E] some cleanups

2007-10-07 Thread jamal
Ok, here you go; the explanation is below. This is from net-2.6.24 of early this AM. I saw a patch you posted that is derived from Krishna; although it hasnt showed up in the tree - i have considered those changes and this patch adds a little more optimization in case of errors. I will send you

[BNX2X][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-07 Thread Eliezer Tamir
This is an initial version of the BNX2X, the Linux driver for the BCM5771X 10Gb Ethernet controller family. Although the chip is very different from the 5706-8 family we based the driver code on the BNX2 driver. Since the hardware is supposed to be generally available soon I have posted an

[BNX2X][PATCH 1/8] add bnx2x to Kconfig and Makefile

2007-10-07 Thread Eliezer Tamir
Add bnx2x to Kconfig and Makefile Signed-off-by: Eliezer Tamir [EMAIL PROTECTED] --- drivers/net/Kconfig |9 + drivers/net/Makefile |1 + 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 467532c..fbb69ac 100644 ---

[BNx2X][PATCH 3/8] bnx2x.h

2007-10-07 Thread Eliezer Tamir
bnx2x.h - main .h file Signed-off-by: Eliezer Tamir [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] --- drivers/net/bnx2x.h | 997 +++ 1 files changed, 997 insertions(+), 0 deletions(-) diff --git a/drivers/net/bnx2x.h b/drivers/net/bnx2x.h new

[BNX2X][PATCH 5/8] bnx2x_init.h

2007-10-07 Thread Eliezer Tamir
bnx2x_init.h - Various bits of init code. Signed-off-by: Eliezer Tamir [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] --- drivers/net/bnx2x_init.h | 555 ++ 1 files changed, 555 insertions(+), 0 deletions(-) diff --git a/drivers/net/bnx2x_init.h

[BNX2X][PATCH 7/8] bnx2x_self_test.h

2007-10-07 Thread Eliezer Tamir
bnx2x_self_test.h This file contains a self-test derived from HW specs, and the code that prints HW/FW/BC assert codes. Signed-off-by: Eliezer Tamir [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] --- drivers/net/bnx2x_self_test.h | 1387 + 1 files

Re: duplicated u32 filters in tc show output

2007-10-07 Thread jamal
On Sat, 2007-06-10 at 18:40 +0530, Abhijit Menon-Sen wrote: The HTB user guide (http://luxik.cdi.cz/~devik/qos/htb/manual/userg.htm) says the following: Note: The U32 classifier has an undocumented design bug which causes duplicate entries to be listed by tc filter show when you use

Re: MSI interrupts and disable_irq

2007-10-07 Thread Manfred Spraul
Jeff Garzik wrote: Interested parties should try the forcedeth patches I just posted :) The patches look good, but I would still prefer to understand why the current implementation causes crashes before rewriting everything. I've just noticed that netpoll_send_skb() calls -hard_start_xmit()

Re: 2.6.23-rc8-mm2 BUG: register_netdevice() issue as (ab)used by ISDN

2007-10-07 Thread Andreas Mohr
Hi, On Sun, Oct 07, 2007 at 03:17:24PM +0200, Andreas Mohr wrote: I thus decided to now try plain 2.6.23-rc8 whether it's corrupted, too. OK, after 3 hours of compilation the ONLY datapoint I can give right now is: 1 (one) boot on 2.6.23-rc8-mm2 had the BUG in /var/log/messages, 1 (one) boot on

[PATCHES] TX batching

2007-10-07 Thread jamal
Please provide feedback on the code and/or architecture. Last time i posted them i received little. They are now updated to work with the latest net-2.6.24 from a few hours ago. Patch 1: Introduces batching interface Patch 2: Core uses batching interface Patch 3: get rid of dev-gso_skb What

[PATCH 2/3][NET_BATCH] net core use batching

2007-10-07 Thread jamal
This patch adds the usage of batching within the core. cheers, jamal [NET_BATCH] net core use batching This patch adds the usage of batching within the core. Performance results demonstrating improvement are provided separately. I have #if-0ed some of the old functions so the patch is more

[PATCH 3/3][NET_BATCH] kill dev-gso_skb

2007-10-07 Thread jamal
This patch removes dev-gso_skb as it is no longer necessary with batching code. cheers, jamal [NET_BATCH] kill dev-gso_skb The batching code does what gso used to batch at the drivers. There is no more need for gso_skb. If for whatever reason the requeueing is a bad idea we are going to leave

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-07 Thread Yinghai Lu
On 10/7/07, Jeff Garzik [EMAIL PROTECTED] wrote: Yinghai Lu wrote: On 10/6/07, Jeff Garzik [EMAIL PROTECTED] wrote: commit a606d2a111cdf948da5d69eb1de5526c5c2dafef Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Oct 5 22:56:05 2007 -0400 [netdrvr] forcedeth: interrupt handling

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Yinghai Lu
On 10/7/07, Jeff Garzik [EMAIL PROTECTED] wrote: Jeff Garzik wrote: The 'fe-lock' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock OK, I've successfully tested patches 1-5 on an AMD64 system with 00:0a.0 Bridge: nVidia Corporation CK804 Ethernet

Re: [PATCH 0/5] forcedeth: several proposed updates for testing

2007-10-07 Thread Jeff Garzik
Yinghai Lu wrote: On 10/7/07, Jeff Garzik [EMAIL PROTECTED] wrote: Jeff Garzik wrote: The 'fe-lock' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git fe-lock OK, I've successfully tested patches 1-5 on an AMD64 system with 00:0a.0 Bridge: nVidia Corporation CK804

Re: [PATCH 2/5] forcedeth: interrupt handling cleanup

2007-10-07 Thread Jeff Garzik
Yinghai Lu wrote: On 10/7/07, Jeff Garzik [EMAIL PROTECTED] wrote: Yinghai Lu wrote: On 10/6/07, Jeff Garzik [EMAIL PROTECTED] wrote: commit a606d2a111cdf948da5d69eb1de5526c5c2dafef Author: Jeff Garzik [EMAIL PROTECTED] Date: Fri Oct 5 22:56:05 2007 -0400 [netdrvr] forcedeth: interrupt

Re: [BNX2X][PATCH 0/8] New driver for Broadcom 10Gb Ethernet, take two.

2007-10-07 Thread Matti Aarnio
On Sun, Oct 07, 2007 at 06:20:56PM +0200, Eliezer Tamir wrote: This is an initial version of the BNX2X, the Linux driver for the BCM5771X 10Gb Ethernet controller family. Although the chip is very different from the 5706-8 family we based the driver code on the BNX2 driver. Since the hardware

Re: [PATCH] [343/2many] MAINTAINERS - IPVS

2007-10-07 Thread Simon Horman
On Sun, Aug 12, 2007 at 11:32:48PM -0700, [EMAIL PROTECTED] wrote: Add file pattern to MAINTAINER entry Signed-off-by: Joe Perches [EMAIL PROTECTED] diff --git a/MAINTAINERS b/MAINTAINERS index dbfdb75..a8fb231 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3300,6 +3300,8 @@ P:

Re: [PATCH] rtnl: Simplify ASSERT_RTNL

2007-10-07 Thread Patrick McHardy
Herbert Xu wrote: On Tue, Oct 02, 2007 at 05:29:11PM +0200, Patrick McHardy wrote: I think this doesn't completely fix it, when dev_unicast_add is interrupted by dev_mc_add before the unicast changes are performed, they will get committed in the dev_mc_add context, so we might still call

Re: [PATCH 2/3][NET_BATCH] net core use batching

2007-10-07 Thread Krishna Kumar2
jamal wrote: + while ((skb = __skb_dequeue(skbs)) != NULL) + q-ops-requeue(skb, q); -requeue queues at the head, so this looks like it would reverse the order of the skbs. Excellent catch! thanks; i will fix. As a side note: Any batching driver should _never_ have to

Re: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock

2007-10-07 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Mon, 24 Sep 2007 19:38:19 -0400 How is the policy to define the qdisc queues locked/mapped to tx rings? For these high performance 10Gbit cards it's a load balancing function, really, as all of the transmit queues go out to the same physical port so you

NET_BATCH: some results

2007-10-07 Thread jamal
It seems prettier to just draw graphs and since this one is small file; here it is attached. The graph demos a patched net-2.6.24 vs a plain net-2.6.24 kernel with a udp app that sends on 4 CPUs as fast as the the lower layers would allow it. Refer to my earlier description of the test setup