Greetings, netdev!
Since the Linux Driver Project apparently has a glut of talent, I figured I'd
ask for a little help with an existing driver. As some of you may know, Jay
Cliburn and I have been working on atl1 since last summer, and we've gotten the
driver merged and stable. It does the
On Sat, Oct 27, 2007 at 03:40:04PM -0700, Joe Perches wrote:
On Sat, 2007-10-27 at 23:47 +0400, Alexey Dobriyan wrote:
Remove proc_fs.h from headers that doesn't really need it.
--- a/arch/powerpc/kernel/process.c
+++ b/arch/powerpc/kernel/process.c
@@ -17,6 +17,7 @@
#include
- Fixed memory leak by freeing MSI-X local entry memories when vector allocation
fails in s2io_add_isr.
- Added two utility functions do_rem_msix_isr and do_rem_inta_isr to eliminate
code duplication.
Signed-off-by: Veena Parat [EMAIL PROTECTED]
Signed-off-by: Ramkrishna Vepa [EMAIL PROTECTED]
As a general rule, I think it better to use includes
than use naked forward declarations.
Quite the opposite - at least in the kernel source.
The general rule is that a .h file shall include the
.h files which contain declarations used by said .h files.
But naked declarations as above is
On Sat, Oct 27, 2007 at 03:40:04PM -0700, Joe Perches wrote:
and forward declarations of
struct proc_dir_entry;
struct file_operations;
As a general rule, I think it better to use includes
than use naked forward declarations.
If you go down that route, you end up with _lots_ of circular
MODPOST 434 modules
ERROR: ioremap [drivers/ssb/ssb.ko] undefined!
ERROR: iounmap [drivers/ssb/ssb.ko] undefined!
ERROR: dma_alloc_coherent [drivers/net/b44.ko] undefined!
ERROR: dma_get_cache_alignment [drivers/net/b44.ko] undefined!
ERROR: dma_free_coherent [drivers/net/b44.ko] undefined!
* Russell King [EMAIL PROTECTED] [2007-10-28 11:34]:
If you go down that route, you end up with _lots_ of circular
dependencies - header file X needs Y needs Z which needs X. We've
been there, several times. It very quickly becomes quite
unmaintainable - you end up with hard to predict
On Sun, Oct 28, 2007 at 12:59:52PM +0100, Bernhard Walle wrote:
* Russell King [EMAIL PROTECTED] [2007-10-28 11:34]:
If you go down that route, you end up with _lots_ of circular
dependencies - header file X needs Y needs Z which needs X. We've
been there, several times. It very
* Russell King [EMAIL PROTECTED] [2007-10-28 14:04]:
On Sun, Oct 28, 2007 at 12:59:52PM +0100, Bernhard Walle wrote:
* Russell King [EMAIL PROTECTED] [2007-10-28 11:34]:
If you go down that route, you end up with _lots_ of circular
dependencies - header file X needs Y needs Z which
On Sun, Oct 28, 2007 at 04:38:46AM +, Thiemo Seufer wrote:
Hello All,
currently the mipsnet driver fails after transmitting a number of
packages because SKBs are allocated but never freed. I fixed that
and coudn't refrain from removing the most egregious warts.
- mipsnet.h folded
Please pull from branch 'upstream-jeff' in repository
git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git
upstream-jeff
to get the changes below.
Distance from 'master' (96fd4cd3e40e240f0c385af87f58e74da8b7099a)
-
Don't call napi_disable if not configured and make sure that any
misuse of napi_xxx in future fails with a compile error.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Signed-off-by: Francois Romieu [EMAIL PROTECTED]
Cc: Edward Hsu [EMAIL PROTECTED]
---
drivers/net/r8169.c |4
1
Disabling napi polling early is well enough.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Signed-off-by: Francois Romieu [EMAIL PROTECTED]
Cc: Edward Hsu [EMAIL PROTECTED]
---
drivers/net/r8169.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git
Fix for the error below while linking vmlinux:
[...]
drivers/built-in.o: In function `ipg_ioctl':
drivers/net/ipg.c:2148: undefined reference to `generic_mii_ioctl'
drivers/built-in.o: In function `ipg_get_settings':
drivers/net/ipg.c:2181: undefined reference to `mii_ethtool_gset'
Signed-off-by: Francois Romieu [EMAIL PROTECTED]
Cc: Avuton Olrich [EMAIL PROTECTED]
Cc: Jesse Huang [EMAIL PROTECTED]
Cc: Sorbica Shieh [EMAIL PROTECTED]
---
drivers/net/Kconfig | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/Kconfig
Hi,
On Sunday 28 October 2007, Russell King wrote:
On Sat, Oct 27, 2007 at 03:40:04PM -0700, Joe Perches wrote:
and forward declarations of
struct proc_dir_entry;
struct file_operations;
As a general rule, I think it better to use includes
than use naked forward declarations.
If
OK, on a process level, my plan is to pull the current driver into a
neteffect branch in my git tree with the intention of merging it for
2.6.25. I'll let you know when that's ready (probably early next
week). I'll probably do some cleanups there, and you can send me
cleanup/fix patches
On Sunday 28 October 2007 00:24:10 Alan Stern wrote:
On Sat, 27 Oct 2007, Maxim Levitsky wrote:
Use del_timer_sync(). It guarantees that when it returns, the timer
will be stopped and the timer routine will no longer be running on any
CPU.
Even if the timer re-enables itself,
Ralf Baechle wrote:
On Sun, Oct 28, 2007 at 04:38:46AM +, Thiemo Seufer wrote:
Hello All,
currently the mipsnet driver fails after transmitting a number of
packages because SKBs are allocated but never freed. I fixed that
and coudn't refrain from removing the most egregious
Dave,
Please take a look and tell me if this is better than the last attempt.
Main changes:
* Rewrite of the init code:
1. Full rewrite of the generated code into something easier to read.
2. Removed zeroes by adding a zero command.
3. Big chucks of data are read by the
Herbert Xu [EMAIL PROTECTED] writes:
But your code differs significantly from Stephen's version.
However, if it is correct it does look like a good improvement.
So please write a simple test program. It can't that bad since
there are only 65536 values to test :)
I think the code is simple
On Sun, 28 Oct 2007 20:03:08 +
Thiemo Seufer [EMAIL PROTECTED] wrote:
Ralf Baechle wrote:
On Sun, Oct 28, 2007 at 04:38:46AM +, Thiemo Seufer wrote:
Hello All,
currently the mipsnet driver fails after transmitting a number of
packages because SKBs are allocated but
Stephen Hemminger wrote:
On Sun, 28 Oct 2007 20:03:08 +
Thiemo Seufer [EMAIL PROTECTED] wrote:
Ralf Baechle wrote:
On Sun, Oct 28, 2007 at 04:38:46AM +, Thiemo Seufer wrote:
Hello All,
currently the mipsnet driver fails after transmitting a number of
packages
On Sun, Oct 28, 2007 at 01:22:04PM -0700, Stephen Hemminger wrote:
-#define MIPSNET_INTCTL_TXDONE ((uint32_t)(1 0))
-#define MIPSNET_INTCTL_RXDONE ((uint32_t)(1 1))
-#define MIPSNET_INTCTL_TESTBIT((uint32_t)(1 31))
-#define MIPSNET_INTCTL_ALLSOURCES
Sergey S. Kostyliov [EMAIL PROTECTED] :
[...]
After booting 2.6.24-rc1 on my home machine I lost onboard rtl8111b
network card. It is neither functional nor even visible by lspci
anymore.
Moreover rebooting to previous 2.6.23-rc9 didn't fix it - card was
still not available.
It should
On Sun, 2007-10-28 at 21:18 +0100, Urs Thuermann wrote:
I have written a short test program to show this and tested it on i686
(gcc-4.2.2) and powerpc (gcc-3.4.5) without optimization and with -O6.
Thanks for that.
BTW, shouldn't unsigned long be replaced by unsigned int to avoid
64-bit
On Fri, 2007-10-26 at 14:37 +0200, Jan-Bernd Themann wrote:
eHEA resources that are allocated via H_CALLs have a unique identifier each.
These identifiers are necessary to free the resources. A reboot notifier
is used to free all eHEA resources before the indentifiers get lost, i.e
before
On Fri, 2007-10-26 at 11:33 -0700, Stephen Hemminger wrote:
Don't call napi_disable if not configured.
And make sure that any misuse of napi_xxx in future fails
with a compile error.
Will test as soon as possible (been without internet in the week end).
Thanks.
As a bonus, I tried more
Hi All
During testing i found very strange thing.
After applying even example shaper:
http://linux-ip.net/tc/hfsc.en/
-
# Example from Figure 1.
tc qdisc add dev eth0 root handle 1: hfsc
tc class add dev eth0 parent 1: classid 1:1 hfsc sc rate
1000kbit ul
Additionally, it doesn't show rate in stats (so it is difficult to measure,
how much is really using each class).
qdisc hfsc 1: root default 200
Sent 1392761062 bytes 965768 pkt (dropped 52, overlimits 1620539 requeues 0)
rate 0bit 0pps backlog 0b 0p requeues 0
qdisc bfifo 200: parent 1:200
Hi.
I was trying to use bonding from a guest OS on xen in active-backup
mode with arp monitoring, but the virtual server can't communicate to
the peer server via bonding interface.
The network structure is the following.
+---+
|virtual I/F(eth0) | - have
On Sun, 2007-10-28 at 14:01 -0700, Joe Perches wrote:
probably unsigned long should be u16.
Or not.
x86 u16 performs much worse than u32 (~ 50% worse)
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
This bug was introduced by the commit
d12af679bcf8995a237560bdf7a4d734f8df5dbb.
Signed-off-by: YOSHIFUJI Hideaki [EMAIL PROTECTED]
---
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index 20cfc90..36f7dbf 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -1670,7 +1670,7 @@ int
-Original Message-
From: Anton Vorontsov [mailto:[EMAIL PROTECTED]
Sent: Saturday, October 27, 2007 10:38 PM
To: Sergei Shtylyov
Cc: Anton Vorontsov; netdev@vger.kernel.org; Li Yang-r58472;
[EMAIL PROTECTED]; [EMAIL PROTECTED]
Subject: Re: [PATCH] ucc_geth: add support for netpoll
Hello Herbert,
Let me ask a question about this patch.
After this patch was applied, 2 of the protocol stack behaviors were
changed when it receives a UDP datagram with broken checksum:
1. udp6InDatagrams is incremented instead of udpInErrors
2. In userland, recvfrom() replies an error with
In article [EMAIL PROTECTED] (at Mon, 29 Oct 2007 15:33:20 +0900), Mitsuru
Chinen [EMAIL PROTECTED] says:
Hello Herbert,
Let me ask a question about this patch.
After this patch was applied, 2 of the protocol stack behaviors were
changed when it receives a UDP datagram with broken
36 matches
Mail list logo
